Bug Report #1271
Non-Final Kohana Class / Move Bootstrap to application folder
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jeremy Bush |
% Done: | 100% |
|
| Category: | Core | |||
| Target version: | 2.4 | |||
| Resolution: | fixed | Points: |
Description
Kohana does not need to be final, here is a simple patch to change it.
Related issues
History
Updated by Ben Rogers almost 3 years ago
- Status changed from Closed to Feedback
- Resolution deleted (
fixed)
I'm confused at the point of this patch. By making Kohana abstract, with a core suffix, then doing a forceful final class Kohana extends Kohana_Core. there is no real gain here. you still cannot transparently extend the kohana instance, because you would be redeclaring the Kohana class. I guess you could extend Kohana with a different name, but all the references to the class itself(from inside and outside of the class) reference the name "Kohana"
so what does this actually accomplish?
Updated by Jeremy Bush almost 3 years ago
- Status changed from Feedback to Closed
- Resolution set to fixed
You extend the kohana class by modifying the APPPATH.'Bootstrap.php' file.
There's nothing special about the Boostrap file that required it to be in SYSPATH.
Updated by Colin Mollenhour almost 3 years ago
Thanks for accepting the patch, I like the committed version even better though with Bootstrap.php in the application folder, kinda like KO3. Very nice.
Updated by Kiall Mac Innes over 2 years ago
- File Kohana.diff added
- Status changed from Closed to Feedback
- 11 set to 2.3.4
Most of the private properties should probably be switched to protected, and self:: replaced with Kohana::..
The attached patch is untested - hence I haven't committed it!
Updated by Kiall Mac Innes over 2 years ago
Fixed in r4501
Updated by Kiall Mac Innes over 2 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100
Applied in changeset r4507.