Bug Report #1290

The new I18n system in 2.4 is broken

Added by Samuel Vogel almost 3 years ago. Updated over 2 years ago.

Status:Closed Start date:
Priority:High Due date:
Assignee:Ben Rogers % Done:

100%
Category:Libraries
Target version:2.4
Resolution:fixed Points:

Description

It couldn't load any translations. A fixed class is attached!

It also requires small changes in Kohana.php

I18n.patch - Patches for the I18n.php library (2.3 kB) Samuel Vogel, 04/24/2009 04:52 pm

I18n_Kohana_Class.patch - Patches for the Kohana.php core file (665 Bytes) Samuel Vogel, 04/24/2009 04:52 pm

I18n.php.diff (901 Bytes) Samuel Vogel, 04/30/2009 09:56 am

Kohana.diff - Default to 'en_US' if none of the locales got accepted by setlocale() (686 Bytes) Samuel Vogel, 05/02/2009 09:36 pm

I18n.diff - Use the constand defined in the last patch (370 Bytes) Samuel Vogel, 05/02/2009 09:36 pm

Associated revisions

Revision 4281
Added by Jeremy Bush almost 3 years ago

Fixing #1290.

Revision 4509
Added by Ben Rogers over 2 years ago

fixing #1290

History

#1
Updated by Jeremy Bush almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
  • Resolution set to fixed

Fixed in r4281.

#2
Updated by Samuel Vogel almost 3 years ago

  • File I18n.php.diff added
  • Status changed from Closed to Feedback
  • % Done changed from 100 to 80

Sorry, my fix wasn't complete. For locale 'en_US', the 'en' and the 'US.UTF8' directories where searched. The second one should just be 'US'.
Also it would be nice to be able to get just 'en_US' without the 'UTF8' from the I18n::get_locale() function.
Patch attached!

#3
Updated by Samuel Vogel almost 3 years ago

I have fixed another issue which would lead to setting the locale to FALSE, when none of the user defined languages in $config['locale']['languages'] got accepted by setlocale().
Now it gets set to 'en_US' in that case!

#4
Updated by Jeremy Bush over 2 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Jeremy Bush to Chris Bandy
  • Resolution deleted (fixed)
  • 11 set to 2.3.4

#5
Updated by Jeremy Bush over 2 years ago

  • Assignee changed from Chris Bandy to Ben Rogers

#6
Updated by Ben Rogers over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100

Applied in changeset r4509.

#7
Updated by Ben Rogers over 2 years ago

  • Resolution set to fixed

Also available in: Atom PDF