Bug Report #1292

All __() calls run through get_text(), when you change 'locale.language.0' from 'en_US'

Added by Samuel Vogel almost 3 years ago. Updated over 2 years ago.

Status:Closed Start date:
Priority:Urgent Due date:
Assignee:Ben Rogers % Done:

0%
Category:Libraries
Target version:2.4
Resolution:invalid Points:

Description

Since all of Kohana's system messages are written in English, I have hardcoded 'en_US' as default locale in my patch #1290.

On the downside this impacts performance if you set 'locale.language.0' to something different than 'en_US', because every call to !+() will run through get_text() then.
On the upside you don't loose the translation of system messages.

The other possibility would be to make it configureable. But if you would be able to set the default system language to something different than 'en_US' (to be able to write your !+() calls in that language), all the system messages wouldn't get translated anymore.

Somebody has to decide how this issue should be handeled!

History

#1
Updated by Jeremy Bush over 2 years ago

  • Assignee changed from Jeremy Bush to Ben Rogers
  • Priority changed from High to Urgent
  • 11 set to 2.3.4

#2
Updated by Jeremy Bush over 2 years ago

  • Status changed from New to Assigned

#3
Updated by Ben Rogers over 2 years ago

  • Resolution set to invalid
  • 11 changed from 2.3.4 to SVN HEAD

there isn't much we can really do here, while we could allow for a default language other than english to translate from, it doesn't change the fact kohana is written in english itself. the recommendation is that if you need a site specifically in another language, write it in english and leverage i18n to translate everything, or dont use i18n at all and simply write your site in the language of your chosing, assuming you only intend on it working in a single language.

#4
Updated by Ben Rogers over 2 years ago

  • Status changed from Assigned to Closed

Also available in: Atom PDF