Feature Request #1415

Instances array should use email as key

Added by Ivan Brotkin almost 6 years ago. Updated almost 6 years ago.

Status:ClosedStart date:04/20/2009
Priority:HighDue date:04/20/2009
Assignee:Sam de Freyssinet% Done:


Category:Library::GravatarEstimated time:2.00 hours
Target version:0.1.1Spent time:-
Resolution: Points:


I think, all of the current avatars use the same configuration. So the one difference (by default) will be in email field.
In this case instance(), factory() and _construct() should take _$email as first parameter and $config option as second or add config($config) method. Changing of the configuration parameters can be tracked using the Gravatar::changed flag or something else (check it before render() calls).
Also Gravatar should support config names a-la Database profiles.


#1 Updated by Sam de Freyssinet almost 6 years ago

  • Due date set to 04/20/2009
  • Status changed from New to Assigned
  • Priority changed from Normal to High
  • Estimated time set to 2.00

Accepted. I like your thinking and will implement as much as I see appropriate. Instances should be available for each email address though I agree

#2 Updated by Sam de Freyssinet almost 6 years ago

  • % Done changed from 0 to 100

Fixed in r10

This is now version 0.1.1

#3 Updated by Sam de Freyssinet almost 6 years ago

  • Status changed from Assigned to Closed

Applied in changeset r10.

Also available in: Atom PDF