Feature Request #1556

Missing controller firstly route to $routes['_default']

Added by Yahasana . over 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:04/26/2009
Priority:NormalDue date:
Assignee:Jeremy Bush% Done:

0%

Category:Core
Target version:2.4
Resolution:wontfix Points:

Description

Missing controller firstly route to $routes['_default'], then execute show_404 method. If the show_404 doesn't exist, Controller.__call() will execute.

Event::run('system.404') is the last when there's exactly not any controller to run.

404_patch.patch Magnifier (1.15 KB) Yahasana ., 04/26/2009 03:25 PM

History

#1 Updated by Jeremy Bush over 5 years ago

  • Category set to Core
  • Target version set to 2.4

#2 Updated by Chris Bandy over 5 years ago

This appears to be a feature request from the forums1 for a convention to handle missing routes/methods without hooks. The suggested implementation calls the show_404 method of the controller in the default route.

The gist of original discussion revolved around the perceived complexity of enabling a 404 hook versus the perceived simplicity of an optionally configured '_404' route.
Concerns regarding hook performance were also raised.

1 http://forum.kohanaphp.com/comments.php?DiscussionID=2437

#3 Updated by Jeremy Bush over 5 years ago

  • Tracker changed from Patch to Feature Request

#4 Updated by Jeremy Bush over 5 years ago

  • Status changed from New to Review

#5 Updated by Ben Rogers over 5 years ago

i dont see the point in this, everything can easily be accomplished by using that event hook. Kohana is meant to be an Event driven framework, and using a hook and attaching to an event is perfectly acceptable and recommended behavior.

I recommend we wontfix this ticket.

#6 Updated by Ben Rogers about 5 years ago

  • Status changed from Review to Closed
  • Resolution set to wontfix

Also available in: Atom PDF