Feature Request #1605

Text::alternate() should support array arguments

Added by Ivan Brotkin almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:05/05/2009
Priority:LowDue date:
Assignee:Kiall Mac Innes% Done:

0%

Category:Helpers
Target version:2.4
Resolution:wontfix Points:

Description

I think this line:
$args = func_get_args();
should be like this:
$args = is_array(func_get_arg(0)) ? func_get_arg(0) : func_get_args();

History

#1 Updated by Jeremy Bush almost 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Kiall Mac Innes
  • Priority changed from Normal to Low

#2 Updated by Jeremy Bush almost 5 years ago

  • Status changed from Assigned to Review

#3 Updated by Kiall Mac Innes over 4 years ago

I see no reason not to allow this - Anyone disagree?

#4 Updated by Ben Rogers over 4 years ago

my opinion is that the ticket submitter should just use call_user_func_array to pass an array of arguments to the function.

i dont think this change is necessary for the desired functionality to be available

#5 Updated by Kiall Mac Innes over 4 years ago

  • Resolution set to wontfix

Change of mind...

(16:11:14) Nodren: if he wants to pass a single array instead of spelling out the parameters
(16:11:21) Nodren: he can just use call_user_func_array
(16:11:36) Nodren: its adding unnecessary bulk to a function that doesnt need it

Agreed....

#6 Updated by Kiall Mac Innes over 4 years ago

  • Status changed from Review to Closed

Also available in: Atom PDF