KohanaPHP » Kohana v3.x

In some situations I'd like it if the Session::get() method, when returning the default value, would also set the session key with that default value. Example implementation:

    /**
     * Get a variable from the session array.
     *
     * @param   string   variable name
     * @param   mixed    default value to return
     * @param   boolean  set key with default value
     * @return  mixed
     */
    public function get($key, $default = NULL, $set = FALSE)
    {
        return array_key_exists($key, $this->_data) ? $this->_data[$key] : $set ? $this->set($key, $default)->get($key) : $default;
    }

One example of where I'd use this is with this CSRF module:

http://dev.kohanaphp.com/projects/csrf

Before I use that module I'd prefer to tidy the code up a bit and with the above change to Session::get(), I'd be able to do this:

    public static function check()
    {
        CSRF::$token_name  = Session::instance()->get('csrf_token_name', 'csrf_'.Text::random('alnum', 5), TRUE);
        CSRF::$token_value = Session::instance()->get('csrf_token_value', Text::random('alnum', 32), TRUE);

        return (empty($_POST) OR ($_POST AND ! empty($_POST[CSRF::$token_name] AND $_POST[CSRF::$token_name] === CSRF::$token_value));
    }

Instead of this:

    public static function check()
    {
        CSRF::$token_name  = Session::instance()->get('csrf_token_name');
        CSRF::$token_value = Session::instance()->get('csrf_token_value');

        if ((CSRF::$token_name === NULL) OR (CSRF::$token_value === NULL))
        {
            CSRF::$token_name  = 'csrf_'.Text::random('alnum', 5);
            CSRF::$token_value = Text::random('alnum', 32);

            Session::instance()->set('csrf_token_name', CSRF::$token_name);
            Session::instance()->set('csrf_token_value', CSRF::$token_value);
        }

        if ($_POST)
            if (( ! isset($_POST[CSRF::$token_name]) ) OR ($_POST[CSRF::$token_name] !== CSRF::$token_value))
                return FALSE;

        return TRUE;
    }