KohanaPHP » Kohana v3.x

I think if you do it this way:

echo Request->factory(array('route' => 'test', 'controller' => 'test', 'action' => 'test', 'id' => 1))->execute();

For example, some links in request's response will be generated by $this->request->uri(). Anyway, any request should know about its route ;)

I disagree. This way you will always use current route (Request::instance()->route). Thats why I suggest to add 'route' param.

Well, it will be perfect, if Route has something like get_default($segment) to get default value. I think, its not good to throw an Exception if one of the (controller|action|route) was not set. As we have default route and default values - we should use it. I think, Ko3 requires get_default() for this feature.

If by default route you mean the route with key 'default' then this feature is easy to implement.

Otherwise I looked around the routing and I think Route::$default_action doesn't make sense. It is only used by request.php at line 865, and it is a default if the route didn't provide any action. In other words it is a default for the case when in bootstrap.php you don't define the default action. I don't think this make sense, especially while the controller hasn't got a default like this.

No, default route is a current route (Request::instance()->route). And I dont want to use Route::$default_action. All we need is a special method (I named it get_default($segment)). For example:

if ( ! (array_key_exists('route', $uri) ) )
{
      $this->route = Request::instance()->route;
   }     
   if ( ! (array_key_exists('controller', $uri) ) )
{
      $this->controller = $route->get_default('controller');
   }
   // etc.

There is one problem - Request object has $uri property and we should fill it (call $this->route->uri() anyway?). As HMVC calls don't (usually) use $this->request->uri, it can be "lazy loaded". But is it wat we need?..

$uri not required contain 'controller' or 'action' if it already in defaults.
Look at my old implementation:
http://homm.stratero.ru/pages/exrequest.zip

Kohana request don't check, if controller exists, and you shouldn't.

Route must return defaults (now it not) and then we can it simple:
http://pastie.org/875026