KohanaPHP » Kohana v3.x

Problem:¶

Consider the following two config files:

modules/my_module/config/my_file.php

return array(
    'servers' => array(
        array('1.1.1.1', 4730),
    ),
);

application/config/my_file.php

return array(
    'servers' => array(
        array('2.2.2.2', 4730),
    ),
);

When these are merged, I would expect the end result to look like so:

return array(
    'servers' => array(
        array('1.1.1.1', 4730),
        array('2.2.2.2', 4730),
    ),
);

What currently (and I believe incorrectly) happens is this:

return array(
    'servers' => array(
        array(
            array('1.1.1.1', 4730),
            array('2.2.2.2', 4730),
        ),
    ),
);

This happens because both the server/port settings have a key of '0'.

Workaround:¶

Add an unnecessary descriptive key like so:

return array(
    'servers' => array(
        '1.1.1.1' => array('1.1.1.1', 4730),
    ),
);

Proposed Solution:¶

Treat non-associative arrays as always unique and ignore their original key. This change would affect the behavior of arr::merge(), ideally this would be added as a parameter.

I believe this change would not affect any of the current stock config files but it may affect users own config files - targeting for 3.1

If people agree - I'll dig in and make the necessary changes.