Bug Report #3525

Header Value incorrect parsing of user agent entry

Added by Sam de Freyssinet over 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:12/31/2010
Priority:NormalDue date:
Assignee:Sam de Freyssinet% Done:

100%

Category:Core
Target version:v3.1.4
Resolution:fixed Points:

Description

The User-Agent header field is being parsed incorrectly, separating the string on ; character. This is incorrect.

public 'user-agent' => 
    object(Http_Header_Value)[26]
      public 'properties' => 
        array
          0 => string 'en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.231 Safari/534.10' (length=78)
          1 => string 'Intel Mac OS X 10_6_5' (length=21)
          2 => string 'U' (length=1)
      public 'key' => null
      public 'value' => string 'Mozilla/5.0 (Macintosh' (length=22)

Associated revisions

Revision ec816385
Added by Sam de Freyssinet over 3 years ago

Fixes #3525, handles the user-agent header without parsing

History

#1 Updated by Sam de Freyssinet over 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:"ec816385cba405144bf3b4db4abd8c1acac1a7b2".

#2 Updated by Isaiah DeRose-Wilson over 3 years ago

  • Status changed from Closed to Needs Test

#3 Updated by Chris Smith over 3 years ago

What if you want a header not to be parsed?

#4 Updated by Sam de Freyssinet over 3 years ago

Header parsing is just creating the Http_Header object for requests/responses. It isn't parsed for the request unless you ask for the headers.

#5 Updated by Kiall Mac Innes over 3 years ago

  • Target version changed from v3.1.0 to v3.1.1

#6 Updated by Jeremy Bush over 3 years ago

  • Target version changed from v3.1.1 to v3.1.2

#7 Updated by Jeremy Bush over 3 years ago

  • Target version changed from v3.1.2 to v3.1.3

#8 Updated by Jeremy Bush over 3 years ago

  • Target version changed from v3.1.3 to v3.1.4

#9 Updated by Sam de Freyssinet about 3 years ago

  • Status changed from Needs Test to Closed
  • Resolution set to fixed

Also available in: Atom PDF