Bug Report #3719

Request caching does not cache

Added by Jeremy Bush over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:02/09/2011
Priority:NormalDue date:
Assignee:Jeremy Bush% Done:

100%

Category:Core
Target version:v3.1.2
Resolution:fixed Points:

Description

Regardless of passing a cache object as the second parameter of Request::factory(), no cached response is returned on execute().


Related issues

Duplicated by Kohana v3.x - Bug Report #3755: Response::serialize should be using $serialized, not $str... Closed 02/15/2011

Associated revisions

Revision 361c41de
Added by Jeremy Bush over 3 years ago

Unit Tests: Test that request/response cache works. Fixes #3719

Revision c9522094
Added by Jeremy Bush over 3 years ago

Fixing unit test, refs #3719

Revision 1d4fd46e
Added by Jeremy Bush over 3 years ago

Fixing response serialization, refs #3719

Revision e16fe27a
Added by Jeremy Bush over 3 years ago

Convert Request_Client::set_cache() to use normal arrays instead of arrayobjects, Refs #3719

Revision 19fa1bef
Added by Jeremy Bush over 3 years ago

Fixing typo in return for cached requests, Fixes #3719

History

#1 Updated by Jeremy Bush over 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:361c41def13ae57531059db8e61928eb40b3edc7.

#2 Updated by Jeremy Bush over 3 years ago

  • Resolution set to fixed

#3 Updated by Andrew Ellis over 3 years ago

Looking at Revision 1d4fd46e, you are still returning "$string", shouldn't that be $serialized?

Regards,
Andrew

#4 Updated by Jeremy Bush over 3 years ago

  • Status changed from Closed to Assigned
  • Resolution deleted (fixed)

Good catch. Weird that the tests pass for it...Can you make sure the tests pass with the change? We'll merge it in then.

#5 Updated by Jeremy Bush over 3 years ago

  • Target version changed from v3.1.1 to v3.1.2

#6 Updated by Jeremy Bush over 3 years ago

  • Status changed from Assigned to Closed
  • Resolution set to fixed

Also available in: Atom PDF