Bug Report #3962

URL::query() should be consistent

Added by Kemal Delalic about 1 year ago. Updated 10 months ago.

Status:New Start date:05/03/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:Core
Target version:v3.1.5
Resolution: Points:

Description

This method currently doesn't support specifying which Request's query are we referring to.

Besides, it uses $_GET directly instead of Request::initial()->query().

Pull request:
https://github.com/kohana/core/pull/111

History

#1
Updated by Kemal Delalic about 1 year ago

I closed the pull request, this needs unit tests

#2
Updated by Jeremy Bush about 1 year ago

I think that whole method needs an overhaul. It should probably use the current request by default, but allow you to pass in a request object. I'm not sure it's completely fixable in 3.1 without an api change.

#3
Updated by Matt Button 10 months ago

  • Target version changed from v3.1.4 to v3.1.5

Also available in: Atom PDF