Bug Report #4000

We don't use "and" in an integer in English

Added by Ben Midget over 3 years ago. Updated 12 months ago.

Status:ClosedStart date:05/16/2011
Priority:NormalDue date:
Assignee:Lorenzo Pisani% Done:

100%

Category:-
Target version:v3.4.0
Resolution:fixed Points:

Description

Text::number returns, for example "1024" as "five million, six hundred and thirty-two".

The correct way to write this number in English is "five million, six hundred thirty-two". The word "and" always signifies a decimal point, and shouldn't be there at all since this method only works with integers.

Associated revisions

Revision 3d2720ce
Added by Robert-Jan de Dreu about 1 year ago

Refs #4000: Enable users to choose their cent separator.

History

#1 Updated by Jeremy Bush over 3 years ago

  • Target version set to v3.1.4

#2 Updated by Jeremy Bush over 3 years ago

Does this apply to 3.0 as well?

#3 Updated by Kiall Mac Innes over 3 years ago

Are you sure? I've always used the "and", and it certainly reads better with the "and" to me.

Here's hoping I don't look too stupid right now :)

#4 Updated by Kiall Mac Innes over 3 years ago

Yea .. the more I think about this .. the more I'm sure most people use "five million, six hundred and thirty-two euro fifteen cent" rather than "five million, six hundred thirty-two euro and fifteen cent"..

(IMO I believe it's more important to match what people expect rather than what is 100% grammatically correct..)

#5 Updated by Jeremy Bush over 3 years ago

IMO, people more use AND with the cents. I don't think it's possible to please everyone here ;)

#6 Updated by Ben Midget over 3 years ago

Looks like it's an actual difference between British and American English: [[http://en.wikipedia.org/wiki/American_and_British_English_differences#Numbers]]

Shouldn't the built-in text be determined by messages and then ultimately a translation string then? If not, shouldn't we remember the following:

US population: 307,006,550 (2009)
UK population: 61,838,154 (2009)

#7 Updated by Adam Klinkosz over 3 years ago

Take a look at PEAR library: Numbers_Words. It has language support and translates numbers to words even with decimal points. It does that nicely for both English and Polish language.

#8 Updated by Sam de Freyssinet over 3 years ago

Shouldn't the built-in text be determined by messages and then ultimately a translation string then?

I agree with the first sentiment, the position of the 'and' should be controlled by the locale setting, en_US vs en_GB.

If not, shouldn't we remember the following:
US population: 307,006,550 (2009)
UK population: 61,838,154 (2009)

That is a meaningless argument in this context. i18n is about being inclusive and presenting text correctly to the world- therefore population statistics are pointless!

#9 Updated by Ben Midget over 3 years ago

@Samsoir lol I agree. It's more of a joke to myself. I know anyone outside the US gets so sick of stuff like that. I would too :)

#10 Updated by Matt Button about 3 years ago

  • Target version changed from v3.1.4 to v3.1.5

#11 Updated by Jeremy Bush over 2 years ago

  • Target version changed from v3.1.5 to v3.2.2

#12 Updated by Jeremy Bush about 2 years ago

  • Target version changed from v3.2.2 to v3.2.3

#14 Updated by Lorenzo Pisani 12 months ago

  • Status changed from New to Closed
  • Assignee set to Lorenzo Pisani
  • Target version changed from v3.2.3 to v3.4.0
  • % Done changed from 0 to 100
  • Resolution set to fixed

Merged https://github.com/kohana/core/pull/400, thanks.

If anyone has good suggestions for how to do this kind of stuff with i18n in mind, we have a few functions that would be relevant… feel free to file a ticket or leave feedback here.

Also available in: Atom PDF