Patch #4314

Use Request::query() instead of $_GET in the URL::query() function

Added by Dmitry T. 7 months ago. Updated 3 months ago.

Status:New Start date:10/25/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:Core
Target version:v3.3.0
Resolution: Points:1

Description

https://github.com/kohana/core/blob/3.2/master/classes/kohana/url.php#L138
https://github.com/kohana/core/blob/3.2/master/classes/kohana/url.php#L143

History

#1
Updated by Jeremy Bush 5 months ago

  • Target version changed from v3.3.0 to Unscheduled

#2
Updated by Kemal Delalic 3 months ago

I think this method should be able to accept Request injection, using the initial (current?) Request by default.

#3
Updated by Kiall Mac Innes 3 months ago

  • Target version changed from Unscheduled to v3.3.0

@Kemal - Agreed. I'll see about

#4
Updated by Kiall Mac Innes 3 months ago

@Kemal - Agreed. I'll see about getting this sorted in 3.3. I just want to make sure that we're consistent and allow the Request to be passed in anywhere it's needed rather than just this specific case!

(This might be the only case, offhand I can't remember!)

Also available in: Atom PDF