Bug Report #4319

Kohana_Request::redirect() and HMVC

Added by Matt Eldridge 7 months ago. Updated 4 months ago.

Status:Closed Start date:11/03/2011
Priority:Normal Due date:
Assignee:Kiall Mac Innes % Done:

100%

Category:-
Target version:v3.3.0
Resolution:duplicate Points:1

Description

When calling a sub-request via something like:

$url = 'some/local/route';
$response = Request::factory($url)->execute();

If the controller action the $url maps to contains an unconditional

$this->request->redirect($somewhere);

In the original action/request $response will not be an instance of Response.

This means you can't verify that the result of the sub-request was successful with something like:

 if($response->status() == 200)
     // do happy stuff
 else
     // so sad stuff

Related issues

related to Kohana v3.x - Feature Request #4373: Provide better isolation of requests/sub-requests v3.3.0 Closed 12/30/2011

Associated revisions

Revision 0c6854b0
Added by Kiall Mac Innes 4 months ago

Merge pull request #194 from kohana/3.3/feature/RequestResponseCleanup

Fixes #4377, #4375, #4374, #4373, #4319

History

Updated by Matt Eldridge 7 months ago

pull request is: kohana:3.2/master from cphrmky:3.2/master

Updated by Matt Eldridge 7 months ago

Matt Eldridge wrote:
pull request is: kohana:3.2/master from cphrmky:3.2/master

pull request is: kohana:3.2/develop from cphrmky:3.2/develop

Updated by Woody Gilk 4 months ago

  • Status changed from New to Feedback
  • Target version set to Unscheduled

Kiall, does this fit into the Request/Response work you are doing for v3.3?

Updated by Woody Gilk 4 months ago

  • Project changed from Userguide to Kohana v3.x

Updated by Kiall Mac Innes 4 months ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Woody Gilk to Kiall Mac Innes
  • Target version changed from Unscheduled to v3.3.0
  • % Done changed from 0 to 80

Yea, its implemented in a branch already.

I have a few hours tomorrow to try clean it all up...

Updated by Kiall Mac Innes 4 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100
  • Resolution set to duplicate

Also available in: Atom PDF