Bug Report #4344

Response::send_file determines mime type incorrectly

Added by Dmitry T. over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:11/26/2011
Priority:Normal Due date:
Assignee:Woody Gilk % Done:

100%
Category:Core
Target version:v3.2.1
Resolution:fixed Points:1

Description

https://github.com/kohana/core/blob/3.2/master/classes/kohana/response.php#L449
Should be 

1 $mime = File::mime($download);

Associated revisions

Revision e6ed6170
Added by Woody Gilk over 1 year ago

Merge pull request #183 from stillman/3.2/develop

Send the correct mime type when sending files, fixes #4344

Revision e139a64c
Added by Woody Gilk over 1 year ago

Follow up to 3bc535eb536e54451b722da9699d052c863ac1b4, determine the download mime by the extension rather than the actual download file (which will probably not exist). Refs #4344

History

#2
Updated by Woody Gilk over 1 year ago

  • Category set to Core
  • Status changed from New to Needs Test
  • Assignee set to Woody Gilk
  • % Done changed from 0 to 100
  • Resolution set to fixed

Fixed by https://github.com/kohana/core/commit/e6ed6170161e796cbe9b06903f66194d86ab0100

I don't know if this is testable, someone else can take it off of Needs Test.

#3
Updated by Woody Gilk over 1 year ago

  • Status changed from Needs Test to Closed

Applied in changeset commit:e6ed6170161e796cbe9b06903f66194d86ab0100.

Also available in: Atom PDF