Feature Request #4375
Remove redirect() from the Request class
| Status: | Closed | Start date: | 12/31/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Kiall Mac Innes |
% Done: | 100% |
|
| Category: | - | |||
| Target version: | v3.3.0 | |||
| Resolution: | fixed | Points: | 1 |
Description
Remove `Request::redirect()` and move it to the `HTTP` class, with a helper method in `Controller`
Associated revisions
Fixup CodeBench controller for $request->redirect() changes. Refs #4375.
Refs #4375 - Add redirect helper method
Refs #4375: redirect() parameter order
Refs #4375: redirect() parameter order
Refs #4375: redirect() parameter order
Add test for HTTP::redirect(). Refs #4375.
History
Updated by Kiall Mac Innes 5 months ago
Fixed in 669f3850608f823dd0966d003ce5e0053f77692a in the 3.3/feature/RequestResponseCleanup branch.
Should get merged to 3.3/develop soon.
Updated by Kiall Mac Innes 4 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
- Resolution set to fixed
Updated by Dmitry T. 4 months ago
- Status changed from Closed to Feedback
What abount interchanging url and code parameters order? (code is optional, and url is required)
Updated by Jeremy Bush 4 months ago
I think I agree. I also think that we should encourage using HTTP::redirect() over $this->redirect() in controllers. I'm not even sure why we need the controller method.
Updated by Kemal Delalic about 1 month ago
Pull request for the right parameter order: https://github.com/kohana/core/pull/233
Updated by Woody Gilk about 1 month ago
I think having `Controller::redirect` is a good idea, it allows users the ability to do some additional processing in the controller before redirecting.
Updated by Woody Gilk about 1 month ago
- Status changed from Feedback to Closed
Merged Kemal's pull request.