Bug Report #4431
View::capture no longer uses global references
| Status: | Closed | Start date: | 02/07/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Woody Gilk |
% Done: | 100% |
|
| Category: | Core | |||
| Target version: | v3.1.5 | |||
| Resolution: | fixed | Points: | 1 |
Description
As discussed here http://forum.kohanaframework.org/discussion/10366/viewcapture-extract-by-reference
This regression happened when #3450 was fixed and EXTR_REFS was replaced with EXTR_SKIP. The correct solution would have been to use EXTR_SKIP OR EXTR_REFS.
Related issues
Associated revisions
Follow up to 9803c24111b6b8a9b7665106a0a916ebefd97605, use a bitwise OR instead of logical, thanks @stillman. Refs #4431
History
Updated by Woody Gilk 3 months ago
Jeremy, should we do a hotfix on 3.0 or just target this into the final 3.1 maintenance release? The fix is currently committed to branch hotfix/3450-regressed-2919 which was branched from 3.0/master.
Updated by Woody Gilk 3 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
Applied in changeset commit:9a149a65a8cd3b321bcfbf86c10a9f09c4a44298.
Updated by Jeremy Bush 3 months ago
3.0 is unsupported. It can go in the final 3.1 release (which should be soon...)
Updated by Woody Gilk 3 months ago
- Target version set to v3.1.5
- Resolution set to fixed
Merged into 3.1/develop.
Updated by Dmitry T. 3 months ago
- Status changed from Closed to Feedback
I think there is an error
http://dev.kohanaframework.org/projects/kohana3-core/repository/revisions/9803c24111b6b8a9b7665106a0a916ebefd97605/diff/classes/kohana/view.php
Should be EXTR_SKIP | EXTR_REFS
Updated by Woody Gilk 3 months ago
Did you try it? My tests showed that using OR worked just fine. From the horse's mouth
You can use this flag on its own or combine it with any other flag by OR'ing the extract_type.
Updated by Woody Gilk 3 months ago
- Status changed from Feedback to Closed
Even if it does work, still not the correct solution. Fixed.