KohanaPHP » Kohana v3.x » ORM

This is expected. You need to include the table alias manually when it is required.

If you do where('some_field', '=', 100), how would ORM know which alias/table name to use? Please include your fix and if it can be fixed in three lines without creating more problems we will include it.

Ivan Kurnosov wrote:

If I do it in `where()` - obviously I apply the conditions to the main entity, that is used for `from`, because `with()` is optional and should never change the results.

[...]

I've put them right before `$this->join(array($target->_table_name, $target_path), 'LEFT')->on($join_col1, '=', $join_col2);` in `with()`

The problem with that solution is it makes assumptions that we don't want to make. There is no reason that where conditions couldn't be applied to the joined table. That seems like a lot to give up to save us from having to type $this->_object_name.

If you do ORM::factory('something', 1), ORM will automatically append the object_name to there WHERE id = 1 statement. For other queries you can easily do this yourself in your model.

There is no reason that where conditions couldn't be applied to the joined table.

The `with()` is used to have better performance (to load entities eager). Adding or removing `with()` should never change the behaviour. By definition.

So if you have had:

$result = $model->where('foo', '=', 'bar')->find();
$result->related->baz;

and you add `with()` just to improve performance:

$result = $model->where('foo', '=', 'bar')->with('related')->find();
$result->related->baz;

you should get the same results. This is how `with()` should work. But it doesn't now.

Ivan Kurnosov wrote:

There is no reason that where conditions couldn't be applied to the joined table.

This statement makes no sense, as long as `with()` doesn't change and shouldn't change the query logic

You are forgetting that with() can be used for find_all queries too. Consider the following:

$no_avatars = ORM::factory('user')
            ->with('profile')
            ->where('profile.avatar', 'IS', NULL) // Where condition on joined table
            ->find_all();

This is a very common way to use the with() method. On reviewing your suggest patch again I see you are checking for a '.', so the above example would still work with your patch. However, I still think it's better to be explicit about what you want instead of making ORM assume that you are referring to the main object when you don't specify.

I will leave this open and get feedback from some of the other devs. I'm not totally against this, but I don't like adding additional "magic" to ORM. Writing more verbose code isn't a bad thing.