Bug Report #4450
Character support issue
| Status: | Closed | Start date: | 02/17/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Woody Gilk |
% Done: | 100% |
|
| Category: | Core | |||
| Target version: | v3.3.0 | |||
| Resolution: | wontfix | Points: | 1 |
Description
Ellipsis characters are not supported by all IDE's or fonts and as such, should be removed from the core. See:
https://github.com/kohana/core/pull/218#issuecomment-3953700
https://github.com/kohana/core/pull/221
Associated revisions
History
Updated by Woody Gilk 3 months ago
- Category set to Core
- Status changed from New to Assigned
- Assignee set to Woody Gilk
- Target version set to v3.3.0
Updated by Anonymous 3 months ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
Applied in changeset commit:0055c46badbb846f4dd9fb80abada6749dc0c510.
Updated by Kiall Mac Innes 3 months ago
- Status changed from Closed to Feedback
From the GitHub discussion @ https://github.com/kohana/core/commit/26b90dba7b96a03b40ff53dadee6ed6e6b7571c9
Have to agree with @Zeelot here! … is the correct character to use! This should be reverted IMO
Also - I've often had graphic designers insist on
…which I would now have to manually try and convert from 3 periods rather than letting htmlentities take care of it.
I'm not sure I'm aware of any IDE's that don't support the ellipsis character, although there are certainly loads of fonts that do not. Is that a good enough reason to break the easy of htmlentities(Text::limit_words($string)) or am I missing something else here?
Updated by Clay McIlrath 3 months ago
I'm sorry but I really have to adamantly fight this one. The ellipsis character is not supported in all encoding and should be considered a special character just like the copyright, trademark, and other characters. I dont know why a designer's opinion would matter in a development framework, especially when this would actually break design due to font issues (especially with custom fonts). If the ellipsis character is preferred, it should then be the html entity …
Let's take the following scenarios and see what arguments we can make for or against the use of periods instead of ellipsis:
1) I use a font in my IDE that does not support special characters. Instead I see a blank square.
2) On the front-end if I use a custom font (like Google webfont library) and the font doesn't support, I again get a blank square. I also now break when using the W3C Validator, because the character is not a properly escaped html entity
If i need or want to override the default characters of periods, then all I have to do is pass it in, without breaking by default or having to worry about font issues. Seems the better supported format that doesn't cause issues should be the default, and allowing users to override when necessary.
Updated by Clay McIlrath 3 months ago
I should address to, the htmlentities() helper definitely helps but it seems like a bandaid solution rather than a proper fix. I still think we should support development environments and not force a dependency on another function as a workaround. Wouldn't the overall better solution be to default to the safest route and let users individually override in their application / project specifically?
Updated by Jeremy Bush 3 months ago
If you aren't using UTF-8, you are Doing It Wrong™.
Updated by Woody Gilk 3 months ago
- Status changed from Feedback to Closed
If you are using a font in your IDE that does not support UTF-8, how can you possibly be using a UTF-8 enabled framework? Reverted.
Updated by Woody Gilk 3 months ago
- Resolution changed from fixed to wontfix