Bug Report #4683

Route->uri() should allow NULL in defaults

Added by Tomek Rychlik over 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:01/08/2013
Priority:NormalDue date:
Assignee:Lorenzo Pisani% Done:

0%

Category:-
Target version:3.3.1
Resolution:invalid Points:1

Description

Default parameters values in route can be NULL, so allow look for a default NULL parameters (using array_key_exists instead of isset):

                                        // Look for a default
                    if (array_key_exists($param, $this->_defaults))
                    {
                        $replace = str_replace($key, $this->_defaults[$param], $replace);
                    }

History

#1 Updated by Lorenzo Pisani over 1 year ago

  • Status changed from New to Feedback
  • Assignee set to Lorenzo Pisani

I'm not sure I follow, could you show me a snippet of code that fails because of this? Using array_key_exists() is much slower so I would like to avoid it if possible.

#2 Updated by Robert-Jan Dreu -rjd22- about 1 year ago

Is this ticket still valid? I can't find any situation where this may apply to.

#3 Updated by Lorenzo Pisani about 1 year ago

  • Status changed from Feedback to Closed
  • Resolution set to invalid

Closing as invalid since I never heard back but feel free to reopen with more information if we missed anything.

Also available in: Atom PDF