Patch #4702

Infinite loop in some assertions fixed

Added by David Chan almost 2 years ago. Updated almost 2 years ago.

Status:NewStart date:02/22/2013
Priority:HighDue date:
Assignee:-% Done:

0%

Category:-Spent time:-
Target version:-
Resolution: Points:1

Description

a small typo prevents use of several assertions including

assertAttributeNotInternalType()
assertNotInternalType()
assertAttributeInternalType()
assertNotInstanceOf()
assertAttributeNotInstanceOf()

because they called themselves instead of their parent causing an infinite loop when used

i've submitted a patch

[[https://github.com/kohana/unittest/pull/31]]

History

#1 Updated by Lorenzo Pisani almost 2 years ago

Heh you filed it under our 2.x module :) I don't even seem to have permissions on this one! I'll go ahead and make one in the Unittest module

#2 Updated by David Chan almost 2 years ago

sorry about the clerical errors. wont happen again.

thanks for the pull!

#3 Updated by David Chan almost 2 years ago

sorry about the clerical errors. wont happen again.

thanks for the pull!

Also available in: Atom PDF