KohanaPHP » Kohana v2.x

03/04/2010

07:45 pm Bug Report #2669: XSS does not clean or check for NULL byte injection

Nathan Bentley wrote:
> If needed, I have a small script that will allow you to inject NULL bytes (normal browsers t... Jeremy Bush

06:37 pm Bug Report #2669 (Assigned): XSS does not clean or check for NULL byte injection

Isaiah DeRose-Wilson

06:25 pm Bug Report #2669: XSS does not clean or check for NULL byte injection

If needed, I have a small script that will allow you to inject NULL bytes (normal browsers tend to filter it out) - I... Nathan Bentley

06:23 pm Bug Report #2669 (Closed): XSS does not clean or check for NULL byte injection

The current 2.3/2.4 Input library's xss_clean() method does not detect for or remove NULL byte injection.
I've tes... Nathan Bentley

03/03/2010

04:49 pm Revision 4831: Squash some whitespace and use CSS instead of cellspacing

Chris Bandy

03/02/2010

09:41 pm Bug Report #2666 (New): Add try-catch to Kohana::shutdown()

Throwing an exception in the shutdown handler (Kohana::shutdown()) will result in a stack frame error. We should add ... Isaiah DeRose-Wilson

03:51 pm Feature Request #2664 (Review): .htaccess should redirect protected folders

I think this would be a useful change for Kohana 2.4 as well. See attached patch. Isaiah DeRose-Wilson

03:22 am Feature Request #2664 (Closed): .htaccess should redirect protected folders

Rather than having requests that start with application/modules/system simply show a forbidden page, we should redire... Michael Peters

03:22 am Feature Request #2703 (Closed): .htaccess should redirect protected folders

Rather than having requests that start with application/modules/system simply show a forbidden page, we should redire... Michael Peters

03/01/2010

09:51 pm Bug Report #2654: (PHP 5.3.x) Bug with database session handler

Good idea, I will get XDebug one of these weekends and play with it when I have the chance. Parnell Springmeyer

09:15 pm Bug Report #2654 (Review): (PHP 5.3.x) Bug with database session handler

I'm moving these to 2.4.1 so we have more time to test it. Isaiah DeRose-Wilson

07:20 pm Feature Request #2618 (Closed): session library docs

Applied in changeset r4830. Parnell Springmeyer

07:17 pm Revision 4830: Fixing #2618

Parnell Springmeyer

06:59 pm Revision 4829: Erg, aparrently I'm the only one experiencing that weird issue - reverting.

Parnell Springmeyer

06:51 pm Feature Request #2618 (Review): session library docs

The mysql database schema is wrong, @DATA@ needs to be renamed to @data@. Isaiah DeRose-Wilson

04:45 am Bug Report #2654 (Closed): (PHP 5.3.x) Bug with database session handler

Applied in changeset r4828. Parnell Springmeyer

04:37 am Revision 4828: Fixing #2654 changing the event to post_controller for session write_close

Parnell Springmeyer

04:36 am Bug Report #2654: (PHP 5.3.x) Bug with database session handler

You are right, I'll just change the event call in __construct() from _system.shutdown_ to _system.post_controller_ as... Parnell Springmeyer

02/28/2010

09:35 pm Bug Report #2654: (PHP 5.3.x) Bug with database session handler

Ah, I didn't notice that! Still we should just be able to use system.send_headers event, right? It doesn't matter if ... Isaiah DeRose-Wilson

09:05 pm Feature Request #2640 (Closed): Fix find_file_paths cache performance for applications that need ...

Applied in changeset r4827. Isaiah DeRose-Wilson

09:04 pm Revision 4827: Changed include_paths cache so it doesn't refresh when you load modules at runtime...

Isaiah DeRose-Wilson

08:50 pm Bug Report #2654: (PHP 5.3.x) Bug with database session handler

Well, insert_event is a private method... Parnell Springmeyer

08:42 pm Bug Report #2654 (Feedback): (PHP 5.3.x) Bug with database session handler

Sorry for reopening this again! But wouldn't it be better to change "line 182":http://dev.kohanaphp.com/projects/koha... Isaiah DeRose-Wilson

08:24 pm Bug Report #2654 (Closed): (PHP 5.3.x) Bug with database session handler

Applied in changeset r4826. Parnell Springmeyer

08:20 pm Revision 4826: Fixing #2654

Parnell Springmeyer

12:30 am Feature Request #2640: Fix find_file_paths cache performance for applications that need to set co...

Andy Staudacher wrote:
>
> I'd love to see this patch go into Kohana 2.4 as soon as possible.
Yes we plan on ad... Isaiah DeRose-Wilson

12:17 am Feature Request #2640: Fix find_file_paths cache performance for applications that need to set co...

I did some testing "In The Real World", on my account on Dreamhost.com. A typical provider of shared webhosting, and ... Andy Staudacher

12:02 am Revision 4825: Fixed a bug, also ran some tests - on average, using Kohana::Y()

instead of a tail-recursive function is, on average, three times
faster - even with the autoloading of the Kohana cla... Parnell Springmeyer

02/27/2010

11:52 pm Revision 4824: Adding a Y-Combinator to the Kohana kernel, will be used to test speed

gains from any tail-recursive functions used in Kohana (mostly in the
arr helper I think)... Parnell Springmeyer

11:39 pm Bug Report #2659: Render bug in form::label

This is true for __all__ the form helpers that allow you to attach an *extra* string. I'm not sure if it's a bug thou... Isaiah DeRose-Wilson

11:11 pm Bug Report #2654: (PHP 5.3.x) Bug with database session handler

Ahh, I did not know we were supporting 5.3 in 2.4. So, yes, it does need to be fixed.
The fix is easy, I simply ad... Parnell Springmeyer

05:36 pm Bug Report #2659 (New): Render bug in form::label

Tiny render issue in form::label when "extra" is not provided. An extraneous space is created after the "for" attribu... Jordan Thomas

04:36 pm Bug Report #2654 (Feedback): (PHP 5.3.x) Bug with database session handler

Maybe we should call Session::write_close() in the shutdown handler? We are supporting php 5.3 in 2.4, so if this is ... Isaiah DeRose-Wilson

09:53 am Revision 4823: Committing major updates and changes, fixed a bunch of issues including the eval()...

Parnell Springmeyer

09:49 am Bug Report #2654: (PHP 5.3.x) Bug with database session handler

For anyone that cares, the solution was to be sure that Session::write_close() was ran as a post_controller hook, tha... Parnell Springmeyer

09:33 am Bug Report #2654 (Closed): (PHP 5.3.x) Bug with database session handler

Apparently, this is already a reported bug in PHP, in which mysql_connect can be used reliably within the write funct... Parnell Springmeyer

09:12 am Bug Report #2654 (Closed): (PHP 5.3.x) Bug with database session handler

While working on the 2.4_experimental branch I came across a most irritating bug. PHP would exit with a segmentation ... Parnell Springmeyer

02/26/2010

02:35 am Revision 4822: adding variable names to docs

Jeremy Bush

01:57 am Revision 4821: Adding example docs for Kohana core.

Jeremy Bush

02/25/2010

07:38 pm Feature Request #2648 (Review): Change Log Level Types to Constants

Isaiah DeRose-Wilson

02/24/2010

09:39 pm Feature Request #2648 (Review): Change Log Level Types to Constants

I think that the log_level keys should be stored as constants so they can be easily changed without any major headach... Jeremy Livingston

02/23/2010

08:54 pm Revision 4820: Updating a few libraries...

Parnell Springmeyer

08:34 pm Revision 4819: Fixing a small bug in the arr helper...

Parnell Springmeyer

05:33 am Revision 4818: Renaming it to experimental, figured that is a better epithet

Parnell Springmeyer

05:33 am Revision 4817: Pushing up my experimental 2.4 branch that uses php-5.3 namespaces

Parnell Springmeyer

05:29 am Feature Request #2644 (New): Experimental Kohana Branch

I've got my experimental branch to render the welcome.php controller and the helpers converted over, I'm positive the... Parnell Springmeyer

03:32 am Revision 4816: Updating the timestamp

Parnell Springmeyer

02/22/2010

07:21 pm Feature Request #2640 (Assigned): Fix find_file_paths cache performance for applications that nee...

Jeremy Bush

06:12 am Feature Request #2640 (Closed): Fix find_file_paths cache performance for applications that need ...

The attached patch fixes the *internal_cache of Kohana::find_file()* for
applications that need to set core.modules ... Andy Staudacher

01:57 am Bug Report #2639: Review existence of the security helper

That was poorly written, I was copying from another ticket. Overall, there are no useful methods in the security help... Parnell Springmeyer

01:54 am Bug Report #2639 (Closed): Review existence of the security helper

Why do we even have the security helper? Using this: Input::instance()->xss_clean($str, 'htmlpurifier'); is only a fe... Parnell Springmeyer

01:53 am Bug Report #2638: Review security::strip_image_tags()

Come to think of it, why do we even have the security helper? Using this: @Input::instance()->xss_clean($str, 'htmlpu... Parnell Springmeyer

01:49 am Revision 4815: Adding in the examples and comments for the security helpers...

Parnell Springmeyer

01:46 am Bug Report #2638: Review security::strip_image_tags()

Come to think of it - this function doesn't even need to exist, xss_clean() does the _exact_ same thing! (unless html... Parnell Springmeyer

01:45 am Bug Report #2638 (Closed): Review security::strip_image_tags()

The function name @strip_image_tags@ is a little deceptive IMHO, it should be @clean_image_tags@ maybe, to denote tha... Parnell Springmeyer

01:30 am Revision 4814: And I goofed again...

Parnell Springmeyer

01:27 am Revision 4813: Goofed on some indentation...

Parnell Springmeyer

01:22 am Feature Request #2591 (Closed): format helper docs

Parnell Springmeyer

01:22 am Revision 4812: Updated a minor thing in the date.php helper, finished up the docs for

the format helper. Parnell Springmeyer

01:08 am Feature Request #2637 (Closed): Review format::url()

This function looks largely useless to me, why do we have a formatting method for prefixing "http://" to the beginnin... Parnell Springmeyer

02/21/2010

07:25 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Andy Staudacher wrote:
> What's your concern about the proposed solution which takes the representation with the sma... Isaiah DeRose-Wilson

07:23 pm Bug Report #2581 (Closed): Incorrect SQL generated by Database::quote() for float numbers on syst...

Applied in changeset r4811. Isaiah DeRose-Wilson

07:21 pm Revision 4811: Convert floats to strings using non-locale aware sprintf('%F', ...). Fixes #2581

Note: If you are trying to store large floats you should use sprintf('%.15E', ...) to convert the float to a string b... Isaiah DeRose-Wilson

02/20/2010

07:23 pm Revision 4810: Move remaining protected functions. Follow-up to r4738

Chris Bandy

06:06 am Revision 4809: Noticed a random mistake in my comment...

Parnell Springmeyer

02:38 am Feature Request #2619 (Closed): uri library docs

Parnell Springmeyer

02:38 am Revision 4808: Finishing up docs and examples...

Parnell Springmeyer

02:19 am Bug Report #2633 (Closed): Inflector should check irregular values as a suffix

This has already been fixed in Kohana 2.4, see #1249... Isaiah DeRose-Wilson

01:41 am Revision 4807: Getting docs and examples done - they aren't finished though so i'm

not closing the ticket... Parnell Springmeyer

12:59 am Bug Report #2633: Inflector should check irregular values as a suffix

Revised code which makes sure the plural to check is longer than the supplied string.... Rowan Parker

12:54 am Bug Report #2633 (Closed): Inflector should check irregular values as a suffix

I've run in to a problem with inflector, where I have a few tables named as:
* enrolment_courses
* template_courses... Rowan Parker

02/19/2010

05:16 pm Bug Report #2574: The database result current() function should return false

What _caused_ the inconsistent behavior is @$current_row@ and @$internal_row@ being improperly initialized to @0@ for... Chris Bandy

04:56 pm Bug Report #2574: The database result current() function should return false

In that same vein, @key()@ should return NULL when invalid. Chris Bandy

01:50 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Isaiah DeRose-Wilson wrote:
> Andy Staudacher wrote:
> > What about my concerns about large float values?
>
> I... Andy Staudacher

01:45 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Andy Staudacher wrote:
> What about my concerns about large float values?
I think it's best to document this and... Isaiah DeRose-Wilson

01:37 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

What about my concerns about large float values? I think there's some value in the proposed implementation which uses... Andy Staudacher

12:57 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

The core of the trouble with converting PHP @float@ to a SQL literal is that PHP @float@ is inexact[1]. There is no w... Chris Bandy

02/18/2010

11:36 pm Revision 4806: making headers smaller refs #2589, r4805

Ben Rogers

11:30 pm Feature Request #2590 (Assigned): form helper docs

Ben Rogers

11:28 pm Feature Request #2589 (Closed): file helper docs

Applied in changeset r4805. Ben Rogers

11:28 pm Revision 4805: fixing #2589

Ben Rogers

11:09 pm Feature Request #2589 (Assigned): file helper docs

Ben Rogers

11:08 pm Feature Request #2588 (Closed): feed helper docs

Applied in changeset r4804. Ben Rogers

11:08 pm Revision 4804: fixing #2588

Ben Rogers

10:12 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Isaiah DeRose-Wilson wrote:
> You are going to have a loss in precision either way
True.
> %F works better for... Andy Staudacher

09:05 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

After talking with Chris about this I think %F is the better choice., You are going to have a loss in precision eithe... Isaiah DeRose-Wilson

08:11 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

lgtm :) Andy Staudacher

08:08 pm Bug Report #2581 (Assigned): Incorrect SQL generated by Database::quote() for float numbers on sy...

I think @sprintf("%E", $value)@ is the way to go, anyone else have any feedback on the attached patch? Isaiah DeRose-Wilson

07:48 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Andy Staudacher wrote:
> What would be the benefit of %F over %E?
I'm not really sure, I was just wondering the reas... Isaiah DeRose-Wilson

07:38 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Isaiah DeRose-Wilson wrote:
> Andy Staudacher wrote:
> > Let's go with sprintf("%E", $value).
>
> That sounds li... Andy Staudacher

07:28 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Andy Staudacher wrote:
> Let's go with sprintf("%E", $value).
That sounds like the best idea so far! But why not ... Isaiah DeRose-Wilson

06:52 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

*Chris Bandy wrote:*
> is_float vs. is_string:
I stand corrected. I see the same results. Must have misread the r... Andy Staudacher

06:37 pm Bug Report #2629: Validation library code cleanup

We should also remove the $field_name parameter from Validation::validate(), it does nothing. Isaiah DeRose-Wilson

06:25 pm Revision 4803: Fixing display_errors bug

Jeremy Bush

06:06 pm Bug Report #2630 (Assigned): Validation::$labels should be included in Validation::field_names()

Validation labels should be included in the array returned by Validation::field_names() so that adding a label to a f... Isaiah DeRose-Wilson

06:02 pm Bug Report #2629 (Assigned): Validation library code cleanup

Validation::$messages isn't used as far as I can tell and it should be removed. Isaiah DeRose-Wilson

05:36 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Andy Staudacher wrote:
> I'd expect setlocale to be relatively slow to be considered to call it on every quote($floa... Isaiah DeRose-Wilson

05:33 pm Feature Request #2620 (Assigned): validation library docs

Isaiah DeRose-Wilson

05:33 pm Feature Request #2620 (Review): validation library docs

I just wanted to make a few more changes to it, and I would forget about them if I didn't leave this open ;) Isaiah DeRose-Wilson

05:25 pm Revision 4802: Minor updates to the Input library docs. Don't forget to update the copyright date!

Isaiah DeRose-Wilson

05:08 pm Revision 4801: Minor updates to the expires helper docs.

Isaiah DeRose-Wilson

05:06 pm Revision 4800: Minor updates to the download helper

Isaiah DeRose-Wilson

05:05 pm Revision 4799: Minor update to the num helper

Isaiah DeRose-Wilson

04:59 pm Revision 4798: Oops, missed the first one. Follow up to r4797

Isaiah DeRose-Wilson

04:56 pm Revision 4797: Minor cleanup to the remote helper docs.

Isaiah DeRose-Wilson

04:49 pm Bug Report #2580: Review Arr::unshift_assoc()

Parnell Springmeyer wrote:
> I never named that function! I thought it was poorly named too!
I didn't mean to say... Isaiah DeRose-Wilson

04:44 pm Bug Report #2574: The database result current() function should return false

Chris Bandy wrote:
> The array functions "@reset()@":http://php.net/manual/en/function.reset, "@current()@":http://p... Isaiah DeRose-Wilson

04:43 pm Bug Report #2574: The database result current() function should return false

Chris Bandy wrote:
> Can you provide an example? It looks to me like "no results" is the same as "out of bounds" whi... Isaiah DeRose-Wilson

03:41 pm Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

... Chris Bandy

03:34 pm Feature Request #2571: FIELD () support in orderby function

This syntax is "@ORDER BY expression [ ASC | DESC ]@" which I believe is accomplished with @Database_Expression@.
... Chris Bandy

03:28 pm Feature Request #2588 (Assigned): feed helper docs

Ben Rogers

03:23 pm Bug Report #2574: The database result current() function should return false

The array functions "@reset()@":http://php.net/manual/en/function.reset, "@current()@":http://php.net/manual/en/funct... Chris Bandy

03:15 pm Bug Report #2574: The database result current() function should return false

Can you provide an example? It looks to me like "no results" is the same as "out of bounds" which returns @NULL@.
... Chris Bandy

09:39 am Bug Report #2625 (New): General Documentation Refactoring

As I'm working on the docs and examples I'm often encountering ambiguous or non-descriptive function and class commen... Parnell Springmeyer

09:01 am Revision 4796: Fixing and ammending some comments, adding examples to the expires

helper. Parnell Springmeyer

09:00 am Feature Request #2587 (Closed): expires helper docs

Parnell Springmeyer

07:50 am Bug Report #2580: Review Arr::unshift_assoc()

I never named that function! I thought it was poorly named too! Parnell Springmeyer

07:49 am Revision 4795: Fixing the copyright timestamp

Parnell Springmeyer

07:48 am Feature Request #2586 (Closed): download helper docs

Cleaned up the docs, fleshed out the examples, fixed some of the comments.... Parnell Springmeyer

07:48 am Revision 4794: Fixing up the docs, indentation was a bit messy, capitalized some

comments - ammended some comments and provided the helper file header Parnell Springmeyer

07:40 am Revision 4793: Fixing a few small things for the docs - prints to echos, the examples

can probably be fleshed out some more down the road too... Parnell Springmeyer

07:38 am Feature Request #2611 (Closed): encrypt library docs

Parnell Springmeyer

07:37 am Feature Request #2613 (Closed): image library docs

Parnell Springmeyer

07:37 am Feature Request #2614 (Closed): input library docs

Parnell Springmeyer

07:37 am Feature Request #2620 (Closed): validation library docs

I finished up the Validation docs a while ago - unless there is something that needs to be ammended; reopen if I clos... Parnell Springmeyer

07:36 am Feature Request #2618 (Closed): session library docs

Parnell Springmeyer

07:35 am Feature Request #2595 (Closed): remote helper docs

This helper/method can probably be consolidated into either URL or REQUEST... Parnell Springmeyer

07:34 am Revision 4792: Finishing up docs for the remote helper

Parnell Springmeyer

07:29 am Feature Request #2594 (Closed): num helper docs

Parnell Springmeyer

07:28 am Revision 4791: Finishing up docs for the num helper

Parnell Springmeyer

06:30 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

I'd expect setlocale to be relatively slow to be considered to call it on every quote($float_value) call (twice).
... Andy Staudacher

06:12 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

I'm not sure blindly replacing @,@ with @.@ is the best way to solve this. What if we temporary change the locale whe... Isaiah DeRose-Wilson

05:05 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

The condition
elseif (is_float($value))
is not safe. A string with a numeric decimal or float value passes the te... Andy Staudacher

04:57 am Bug Report #2581: Incorrect SQL generated by Database::quote() for float numbers on system with l...

Per a conversation on IRC:... Chris Bandy

02:29 am Feature Request #2620 (Assigned): validation library docs

Isaiah DeRose-Wilson

02:26 am Revision 4790: A few changes to the db helper docs.

Isaiah DeRose-Wilson

01:58 am Revision 4789: Quick comments cleanup

Isaiah DeRose-Wilson

01:17 am Feature Request #2586 (Review): download helper docs

please update copyright Chris Bandy

02/17/2010

11:17 pm Feature Request #2603 (Closed): benchmark core docs

fixed in r4769 Ben Rogers

11:16 pm Feature Request #2609 (Closed): cache library docs

fixed in r4768 Ben Rogers

11:14 pm Feature Request #2586 (Closed): download helper docs

Applied in changeset r4788. Ben Rogers

11:14 pm Revision 4788: fixing #2586

Ben Rogers

11:04 pm Feature Request #2586 (Assigned): download helper docs

Ben Rogers

11:03 pm Feature Request #2582 (Closed): db helper docs

Applied in changeset r4787. Ben Rogers

11:01 pm Revision 4787: fixing #2582

Ben Rogers

11:00 pm Feature Request #2622 (Closed): db helper docs

Isaiah DeRose-Wilson

10:49 pm Feature Request #2622 (Closed): db helper docs

Docs for the db helper Isaiah DeRose-Wilson

10:47 pm Feature Request #2600 (Closed): url helper docs

Isaiah DeRose-Wilson

10:46 pm Feature Request #2596 (Closed): request helper docs

Isaiah DeRose-Wilson

10:43 pm Feature Request #2598 (Closed): text helper docs

Isaiah DeRose-Wilson

10:39 pm Revision 4786: Added the variable names to the @param comments

Isaiah DeRose-Wilson

10:38 pm Feature Request #2582 (Assigned): db helper docs

Ben Rogers

10:38 pm Feature Request #2583 (Closed): arr helper docs

Ben Rogers

10:35 pm Feature Request #2621 (New): view library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:34 pm Feature Request #2620 (Closed): validation library docs

Ben Rogers

10:34 pm Feature Request #2619 (Closed): uri library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:34 pm Feature Request #2618 (Closed): session library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:34 pm Feature Request #2617 (New): router library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:34 pm Feature Request #2608: kohana_exception core docs

includes all other kohana_exception libraries as well. Ben Rogers

10:33 pm Feature Request #2616: profiler library docs

includes profiler_table as well Ben Rogers

10:33 pm Feature Request #2610: database library docs

includes all datbase_ library files in this ticket as well. Ben Rogers

10:32 pm Feature Request #2616 (Assigned): profiler library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:32 pm Feature Request #2615 (New): kohana log docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:32 pm Feature Request #2614 (Closed): input library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:31 pm Feature Request #2613 (Closed): image library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:31 pm Feature Request #2612 (New): i18n library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:31 pm Feature Request #2611 (Closed): encrypt library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:31 pm Feature Request #2610 (New): database library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:30 pm Feature Request #2609 (Closed): cache library docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:29 pm Feature Request #2608 (New): kohana_exception core docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:29 pm Feature Request #2607 (New): kohana_config core docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:29 pm Feature Request #2606 (Assigned): kohana core docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:28 pm Feature Request #2605 (Closed): event core docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing wha... Ben Rogers

10:28 pm Feature Request #2603: benchmark core docs

ignore the description, meant to be this:
Documentation for the file mentioned in the subject, this is one of many... Ben Rogers

10:28 pm Feature Request #2602 (Closed): valid helper docs

Docs added in r4731, r4772 and r4773 Isaiah DeRose-Wilson

10:27 pm Feature Request #2603 (Closed): benchmark core docs

http://dev.kohanaphp.com/projects/kohana2/issues?query_id=22 Ben Rogers

10:24 pm Feature Request #2592 (Closed): html helper docs

Docs added in r4782 Isaiah DeRose-Wilson

10:23 pm Feature Request #2585 (Closed): date helper docs

Docs added in r4785 Isaiah DeRose-Wilson

10:21 pm Feature Request #2602 (Closed): valid helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:21 pm Feature Request #2601 (Closed): utf8 helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:21 pm Feature Request #2584 (Closed): cookie helper docs

Docs added in r4784 Isaiah DeRose-Wilson

10:21 pm Feature Request #2600 (Closed): url helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:21 pm Feature Request #2599 (Closed): upload helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:21 pm Feature Request #2598 (Closed): text helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Feature Request #2597 (Closed): security helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Feature Request #2596 (Closed): request helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Feature Request #2595 (Closed): remote helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Feature Request #2594 (Closed): num helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Feature Request #2593 (Closed): inflector helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:20 pm Revision 4785: Added date helper docs

Isaiah DeRose-Wilson

10:20 pm Feature Request #2592 (Closed): html helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:19 pm Feature Request #2591 (Closed): format helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:19 pm Feature Request #2590 (Closed): form helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:19 pm Feature Request #2589 (Closed): file helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:19 pm Feature Request #2588 (Closed): feed helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:19 pm Feature Request #2587 (Closed): expires helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:18 pm Feature Request #2586 (Closed): download helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:17 pm Feature Request #2585 (Closed): date helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:17 pm Feature Request #2584 (Closed): cookie helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:17 pm Feature Request #2583 (Closed): arr helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

10:17 pm Feature Request #2582 (Closed): db helper docs

Documentation for the file mentioned in the subject, this is one of many tickets, designed so we know who's doing what. Ben Rogers

09:09 pm Revision 4784: Added docs to the cookie helper

Isaiah DeRose-Wilson

08:54 pm Bug Report #2581 (Closed): Incorrect SQL generated by Database::quote() for float numbers on syst...

*Steps to reproduce:*
# Verify that your system has a de_DE locale installed, such as "de_DE.utf8". On Linux, call ... Andy Staudacher

07:59 pm Revision 4783: Minor cleanup for the arr helper docs

Isaiah DeRose-Wilson

07:53 pm Bug Report #2580 (Closed): Review Arr::unshift_assoc()

ixmatus, "This function is badly named, IMHO, and none of the other array helper methods pass by reference! I didn't ... Isaiah DeRose-Wilson

07:16 pm Revision 4782: Finished html helper docs, follow up to r4778

Isaiah DeRose-Wilson

07:07 am Revision 4781: Updated config.php config file to show default values (for docs), and added config...

Isaiah DeRose-Wilson

04:58 am Revision 4780: Fixing my example - Isaiah distracted me with his naughtiness.

Parnell Springmeyer

04:52 am Revision 4779: Adding in ammended comments, examples, and a few modifications.

Parnell Springmeyer

04:22 am Revision 4778: Added html helper docs (incomplete)

Isaiah DeRose-Wilson

12:25 am Bug Report #2575 (Closed): stylesheet() in html.php

This is expected. The current docs on the website are for 2.3.x not Kohana 2.4. For more details about this change se... Isaiah DeRose-Wilson

02/16/2010

05:26 am Revision 4777: My comments didn't sound right - I made them better

Parnell Springmeyer

05:20 am Revision 4776: Ammended a comment or two

Parnell Springmeyer

03:19 am Revision 4775: Adding in an array slice method that takes an array passed by

reference, returns the slice of the array and modifies the original
array to contain what is left from the slice... Parnell Springmeyer

02/15/2010

11:43 pm Bug Report #2575 (Closed): stylesheet() in html.php

Using kohana 2.4rc2
The documentation states that this function will add .css extention to a stylesheet if it does... Kevin Phillips

10:59 pm Bug Report #2574 (New): The database result current() function should return false

The database result current() function should return false instead of null. The php current() function returns false ... Isaiah DeRose-Wilson

07:45 pm Bug Report #2573 (Assigned): missing platform in user_agents config

Isaiah DeRose-Wilson

05:46 pm Bug Report #2573 (Assigned): missing platform in user_agents config

there is missing Windows 7 platform:
'windows nt 6.1' => 'Windows 7' thejw23 .

03:32 pm Feature Request #2571: FIELD () support in orderby function

2.3.4 has reached it's end of life, so it won't be receiving any more updates. However this would be a nice feature i... Isaiah DeRose-Wilson

04:16 am Feature Request #2571 (New): FIELD () support in orderby function

escape driver does not allow to use *ORDER BY FIELD('col', v1) DESC* syntax.
Index: ../system/libraries/Database... Olivier Larchevêque

02/14/2010

09:40 pm ORM - K2 Feature Request #2482 (Feedback): ORM::delete_all always deletes all rows

Fixed in r11 Isaiah DeRose-Wilson

09:40 pm ORM - K2 Feature Request #2513 (Feedback): ORM needs post_filter support

Fixed in r10 Isaiah DeRose-Wilson

09:39 pm ORM - K2 Feature Request #2538 (Feedback): ORM::__set should account for values which haven't changed

Isaiah DeRose-Wilson

09:38 pm ORM - K2 Bug Report #2567 (Feedback): Object data doesn't get validated when using an external validation ...

Fixed in r8 Isaiah DeRose-Wilson

09:38 pm ORM - K2 Bug Report #2568 (Feedback): __set() runs twice

Isaiah DeRose-Wilson

09:38 pm ORM - K2 Feature Request #2569 (Feedback): Add rules/filters/callback functions

Isaiah DeRose-Wilson

09:37 pm ORM - K2 Bug Report #2568: __set() runs twice

Fixed in r8 Isaiah DeRose-Wilson

09:37 pm ORM - K2 Feature Request #2569: Add rules/filters/callback functions

Fixed in r8 Isaiah DeRose-Wilson

09:14 pm ORM - K2 Feature Request #2538 (Assigned): ORM::__set should account for values which haven't changed

Isaiah DeRose-Wilson

08:38 pm ORM - K2 Feature Request #2538 (Review): ORM::__set should account for values which haven't changed

This shouldn't be closed yet... the fix is still in the experimental branch. Isaiah DeRose-Wilson

08:36 pm ORM - K2 Feature Request #2538 (Closed): ORM::__set should account for values which haven't changed

Applied in changeset r9. Isaiah DeRose-Wilson

08:05 pm ORM - K2 Bug Report #2532 (Closed): ORM::validate() doesn't load data correctly

Isaiah DeRose-Wilson

07:58 pm ORM - K2 Feature Request #2569 (Feedback): Add rules/filters/callback functions

Instead of defining rules, filters and callbacks as class properties we should define them in class methods to make e... Isaiah DeRose-Wilson

07:55 pm ORM - K2 Bug Report #2568 (Feedback): __set() runs twice

Currently __set() get called twice, one when you set the data in the model (e.g. with load_values()), and again after... Isaiah DeRose-Wilson

07:54 pm ORM - K2 Bug Report #2567 (Feedback): Object data doesn't get validated when using an external validation ...

If you use an external validation object data already in the object won't get validated.
Example:... Isaiah DeRose-Wilson

02/13/2010

04:48 pm Bug Report #2566 (Closed): SQL type constants overflow

Applied in changeset r4774. Chris Bandy

04:48 pm Revision 4774: Store numeric constants as strings to avoid any overflow. Fixes #2566

Chris Bandy

04:47 pm Bug Report #2566: SQL type constants overflow

Numeric constants are now stored as strings. Chris Bandy

04:43 pm Bug Report #2566 (Closed): SQL type constants overflow

In "system/config/sql_types.php":/projects/kohana2/repository/revisions/4773/entry/trunk/system/config/sql_types.php,... Chris Bandy

03:21 am Feature Request #2564: Validation library add_rules, add_callbacks extra parameters

Realized I didn't provide very much information. The example use case for me, would be in a callback that tests if a ... Parnell Springmeyer

03:14 am Feature Request #2564 (Closed): Validation library add_rules, add_callbacks extra parameters

I often find myself doing separate tests outside of the validation library because I need to pass in a secondary argu... Parnell Springmeyer

03:09 am Revision 4773: Chose to homogenize the example code a bit more - simplify it a bit by

using Kohana::debug() instead of if(){}else{} blocks with example output... Parnell Springmeyer

02:59 am Revision 4772: Cleaned up and ammended a lot of the docs/examples for the validation

helper, also added in a method for testing if a numeric quantity is a
true multiple (non-fractional) of another given... Parnell Springmeyer

02:20 am Revision 4771: Ammended one of my examples...

Parnell Springmeyer

02:13 am Revision 4770: Adding in examples and ammended documentation for the request helper -

protected methods I explicitly did not provide examples for assuming
that anyone that would use them would be looking... Parnell Springmeyer

02/12/2010

01:48 am Auth Module for v2.x Bug Report #2071 (Closed): validate() has changed in the 2.4 branch.

Validation should be working in r20, if you have any feedback please feel free to reopen this issue. Isaiah DeRose-Wilson

02/11/2010

10:54 pm ORM - K2 Feature Request #2552: Add a display_val method/field

Actually I think the most concise solution is to allow a callback as a third parameter to select_list().... Rowan Parker

09:55 pm Revision 4769: added documentation to Benchmark class

Ben Rogers

07:25 pm Revision 4768: writing cache api docs, fixed up stuff in database_builder docs

Ben Rogers

06:55 pm Bug Report #2557 (Closed): __construct should be protected on singleton classes

this was discussed prior but i'm not sure if it was implemented everywhere, cache for example doesnt do this correctly. Ben Rogers

04:00 pm Bug Report #2556 (Assigned): Allow tags to be specified when caching database queries

it would be nice to be able to specify tags when caching database queries. this way if one were using a cache driver... Ben Rogers

12:22 am Bug Report #2555 (Closed): MySQLi returns wrong data after seek

Applied in changeset r4767. Chris Bandy

12:21 am Revision 4767: Set internal pointer after seek. Fixes #2555

Chris Bandy

12:20 am Bug Report #2555 (Closed): MySQLi returns wrong data after seek

... Chris Bandy

02/10/2010

04:59 am Revision 4766: Finishing up examples for the final few methods...

Parnell Springmeyer

03:16 am Revision 4765: Adding in examples to the comments - not done though, last two methods

need to be finished - I plan on doing that tonight. Parnell Springmeyer

02/09/2010

06:21 pm ORM - K2 Feature Request #2552: Add a display_val method/field

i think what's really necessary is a drop in function you can drop in your model for creating the primary_key_value i... Ben Rogers

06:05 am ORM - K2 Feature Request #2552: Add a display_val method/field

If I had a 2 column table (id and name), then $obj->primary_key_value would return the value of $obj->id (according t... Rowan Parker

03:27 am ORM - K2 Feature Request #2552 (Review): Add a display_val method/field

Hmmm, I'm not totally sure I understand what you need, but doesn't @$obj->primary_key_value@ already do what you want... Isaiah DeRose-Wilson

02/08/2010

11:03 pm ORM - K2 Feature Request #2552 (Review): Add a display_val method/field

This request is for a standalone method which determines what is return as primary value for an ORM model.
You can... Rowan Parker

02/06/2010

04:37 am ORM - K2 Feature Request #2548 (New): Completely Abstracted ORM

ORM is a great concept for representing data as a class object, it would be nice to extend it beyond the use of just ... Ben Rogers

02/05/2010

11:58 pm Revision 4764: Moving ORM to it's own module, see http://dev.kohanaphp.com/projects/orm

Isaiah DeRose-Wilson

11:38 pm ORM - K2 Feature Request #2538 (Review): ORM::__set should account for values which haven't changed

Kent Davidson wrote:
> I'm not sure if you misread the code
Fair point, I did misread your code. I'm going to hav... Isaiah DeRose-Wilson

09:47 pm ORM - K2 Feature Request #2538: ORM::__set should account for values which haven't changed

Before we get too far OT, I like Kohana a lot and want to contribute, but I'm concerned with how thing appear to me (... Kent Davidson

09:18 pm ORM - K2 Feature Request #2538: ORM::__set should account for values which haven't changed

Kent Davidson wrote:
>
> I'm glad to see that Kohana development remains active; based on what I see on the web site... Jeremy Bush

09:08 pm ORM - K2 Feature Request #2538: ORM::__set should account for values which haven't changed

I'm not sure if you misread the code, but I'm comparing with !== and ===, and as well, the value is type adjusted wit... Kent Davidson

05:42 pm ORM - K2 Feature Request #2539 (Closed): Add ORM::changed, and ORM::database method

No problem :) If you run into any issues with Kohana don't hesitate to report them.
Also you should be able to acc... Isaiah DeRose-Wilson

05:35 pm ORM - K2 Feature Request #2539: Add ORM::changed, and ORM::database method

Yes, sorry for the legwork, I have been reviewing ORM in Kohana 3 this morning and saw the table_name and other metho... Kent Davidson

04:39 pm ORM - K2 Feature Request #2539: Add ORM::changed, and ORM::database method

Kent Davidson wrote:
> I'm on v2.3.4 so I'm unaware of ::saved, if that is semantically similar to ::changed, then ye... Isaiah DeRose-Wilson

04:37 pm ORM - K2 Feature Request #2539: Add ORM::changed, and ORM::database method

Kent Davidson wrote:
> I'm on v2.3.4 so I'm unaware of ::saved, if that is semantically similar to ::changed, then y... Jeremy Bush

03:19 pm ORM - K2 Feature Request #2539: Add ORM::changed, and ORM::database method

I'm on v2.3.4 so I'm unaware of ::saved, if that is semantically similar to ::changed, then yes, not necessary.
>y... Kent Davidson

02:43 am ORM - K2 Feature Request #2538: ORM::__set should account for values which haven't changed

I'm not sure this is a good idea. Comparing strings with == (or !=) generally isn't a good idea. Consider the followi... Isaiah DeRose-Wilson

01:56 am ORM - K2 Feature Request #2539 (Review): Add ORM::changed, and ORM::database method

I'm not sure what ORM::database() would be used for... you want to be able to run a custom query on the object's inte... Isaiah DeRose-Wilson

02/04/2010

10:19 pm Bug Report #2542 (Assigned): utf8::str_ireplace

Isaiah DeRose-Wilson

02:04 pm Bug Report #2542 (Assigned): utf8::str_ireplace

Function utf8::str_ireplace works wrong
Both this function works the same:... zil zil

04:46 am ORM - K2 Feature Request #2539 (Closed): Add ORM::changed, and ORM::database method

... Kent Davidson

04:42 am ORM - K2 Feature Request #2538 (Feedback): ORM::__set should account for values which haven't changed

It's convenient to know whether a database object has been modified locally, regardless of whether or not changes to ... Kent Davidson

« Previous

Next »