Activity

From 10/28/2009 to 11/26/2009

11/26/2009

11:41 pm UnitTest Revision d3ec0ca2: Changed paths in README and added requirements section
Matt Button
11:33 pm Bug Report #2382 (Closed): Move column types from class to config
As i said in http://forum.kohanaphp.com/comments.php?DiscussionID=4144&page=1#Item_9
What if I have own defined co...
Bartłomiej Kuleszewicz
11:30 pm Bug Report #2381 (Closed): Something wrong in route class
I dont know how to describe this...
When I have something like that in Route:
(/sort/<sort>)
and when I use Rout...
Bartłomiej Kuleszewicz
09:44 pm UnitTest Revision 30c8f182: Merge branch 'master' into myCC
Matt Button
09:42 pm UnitTest Revision d9605051: API BREAK! Renaming tests directory
Matt Button
09:17 pm UnitTest Revision 433535db: Added code coverage to the unit testing ui (based on banks' branch), haven't s...
Matt Button
07:19 pm Revision 9948cc68: Tracking submodules
Woody Gilk
07:16 pm Bug Report #2375 (Assigned): ORM::check() is not casting the column values before merging the fil...
Woody Gilk
07:15 pm Feature Request #2377: Schema support
> This also allows identifiers with periods to be properly quoted when necessary.
That should not be done. Using p...
Woody Gilk
07:08 pm Database Revision 33407ab7: Quote booleans as SQL-92 literals '0' and '1'. Fixes #2376
(cherry picked from commit 1840954df826cc84ed909de74864d8408ba14853) Chris Bandy
07:08 pm Bug Report #2376 (Closed): Regression: Database not quoting booleans
Merged in http://github.com/kohana/database/commit/33407ab70957f75ecb0df4d3a452292101c3c812 Woody Gilk
03:56 am Userguide Revision 6b5fe99f: Finished transhalte tutorials.database.md
icy leaf
03:19 am Bug Report #2378 (Closed): spelling mistakes in tutorials.databases.md
File: tutorials.databases.md
the Title Query Building had a anchor named '#query_building', and it was called twic...
icy leaf

11/25/2009

05:25 pm Feature Request #2377 (Closed): Schema support
Things besides columns (e.g., indexes) should be quoted by @quote_identifier()@ without a table prefix being added.
...
Chris Bandy
03:33 pm Bug Report #2376: Regression: Database not quoting booleans
Implemented in http://github.com/cbandy/kohana-database/commit/4c2038ef3550059038f46696114db5864d68afa0 Chris Bandy
03:29 pm Bug Report #2376 (Closed): Regression: Database not quoting booleans
"Database:1840954d":http://github.com/kohana/database/commit/1840954df826cc84ed909de74864d8408ba14853 was reverted du... Chris Bandy
02:07 pm Bug Report #2375 (Closed): ORM::check() is not casting the column values before merging the filte...
Currently the @ORM::check()@ method, line 808, merges the validation array with the @$this->_object@ array.... Aron C
12:38 am Bug Report #2374 (Assigned): Internal file paths don't get cached when Kohana::$errors is FALSE
Woody Gilk

11/24/2009

11:26 pm Bug Report #2374 (Closed): Internal file paths don't get cached when Kohana::$errors is FALSE
If @Kohana::$errors@ is @FALSE@, then shutdown_handler don't get executed and @Kohana::cache('Kohana::find_file()', K... Dmitry T.
08:14 pm Userguide Revision c02ac1fc: Fixing a problem with attaching the base URL to links introduced in 94c8573c17...
Woody Gilk
07:39 pm Userguide Revision 900248fd: Updated "Working with Git" tutorial, adding information about how to checkout ...
Woody Gilk
07:29 pm Image Revision 37f0bf76: Allow Image_GD to be used with the non-bundled version of GD, throw exceptions...
Woody Gilk
07:27 pm Bug Report #2373 (Closed): Image_GD bundled checks are only required for some methods
Fixed by http://github.com/kohana/image/commit/37f0bf76311beb8918cee176ba81bb9e416ec96c Woody Gilk
07:14 pm Bug Report #2373 (Closed): Image_GD bundled checks are only required for some methods
As per "this thread":http://forum.kohanaphp.com/comments.php?DiscussionID=4145 the bundled checks for GD are only nec... Woody Gilk
07:12 pm Feature Request #2277: Provide for ORM to sumarize data
This seems to be a copy of Issue #2331 Daniel Cook
05:14 pm Revision 4bf80784: Tracking submodules
Woody Gilk
05:14 pm Userguide Revision 827fbc43: Updated user guide API, fixed broken #id links and added class contents as the...
Woody Gilk
05:14 pm Bug Report #2352 (Closed): Table of contents for methods
Fixed by http://github.com/kohana/userguide/commit/827fbc43f10a89c05d3d43d1c976849675d4ddc3 Woody Gilk
02:50 pm Feature Request #2372 (Assigned): Check whether the value is empty and is_nullable in ORM->_load_...
Woody Gilk
01:10 pm Feature Request #2372 (Closed): Check whether the value is empty and is_nullable in ORM->_load_ty...
In _load_type() function in ORM class in line 1249 there is:... Bartłomiej Kuleszewicz
06:03 am Patch #2326 (Closed): Select argument as single item array fix
Incorrect documentation on the unofficial wiki was responsible for this patch. The current behavior is correct and sh... Woody Gilk
04:29 am Patch #2326: Select argument as single item array fix
I made the corrections to the unofficial Wiki. You can close this patch if you would like or maybe throw an explicit ... Joel Pittet
01:31 am Bug Report #2371 (Closed): Bootstrap should set the locale
Fixed by http://github.com/kohana/kohana/commit/29fa43354cd2335da507c9fe7557f8100008ebd6 Woody Gilk
01:31 am Bug Report #2371 (Closed): Bootstrap should set the locale
Setting locale is always a good idea and will help weed out errors with the @utf8@ class... a proper setting is very ... Woody Gilk
01:28 am kohana-3.0.3.zip
Woody Gilk
01:26 am Bug Report #2366 (Closed): Cannot perform INSERT INTO... SELECT query
Fixed by http://github.com/kohana/database/commit/fbfdea919028b951c23c3d99d2bc1f5bbeda0c0b Woody Gilk
01:20 am Revision 29fa4335: Added setlocale() call to bootstrap.php
Woody Gilk
01:17 am Revision 116bb887: Tracking submodules
Woody Gilk
01:17 am Core Revision 541c5c29: Setting next version, 3.0.3
Woody Gilk
01:16 am Core Revision c01fdac2: Set current directory in Request->uri
Colin Mollenhour
01:12 am Database Revision fbfdea91: Database_Query_Builder_Insert::select() references incorrect variable, fixes #...
Woody Gilk
01:07 am Patch #2326: Select argument as single item array fix
I still don't see a reason for this patch. It is ok if errors are triggered when someone uses the wrong syntax. Woody Gilk
01:01 am Bug Report #2365 (Closed): Indexes for _object are not loaded properly at ORM from object returne...
Woody Gilk

11/23/2009

07:45 pm Bug Report #2299 (Closed): ORM: column type is wrongly evaluated
This shouldn't be an issue with the recent patches. John Heathco
07:32 pm Bug Report #2363 (Closed): New function _parse_type in database/clasess/kohana/database.php doesn...
John Heathco
07:32 pm Bug Report #2363: New function _parse_type in database/clasess/kohana/database.php doesn't return...
Fixed in http://github.com/kohana/database/commit/6de0312c88a2ccb321575831f9751baca86ff580 John Heathco
07:31 pm Database Revision 6de0312c: Fixing #2363
jheathco -
07:30 pm Bug Report #2364: Proxy method at ORM for Database sets wrong number of arguments
I noticed from the commit that the function list_columns now has no arguments. Thus this call... Nano Documet
07:01 pm Bug Report #2364 (Closed): Proxy method at ORM for Database sets wrong number of arguments
Fixed in http://github.com/kohana/orm/commit/e68997366359d0fb18a20954a42c724eaa7c8fe4 John Heathco
06:55 pm ORM Revision e6899736: Fixing #2364
jheathco -
12:19 pm Bug Report #2366 (Assigned): Cannot perform INSERT INTO... SELECT query
Woody Gilk
12:19 pm Bug Report #2364 (Assigned): Proxy method at ORM for Database sets wrong number of arguments
Woody Gilk
05:33 am Bug Report #2365 (Resolved): Indexes for _object are not loaded properly at ORM from object retur...
Isaiah DeRose-Wilson
05:14 am Bug Report #2368 (Closed): v3.0.2.1: "ErrorException [ Notice ]: Undefined index: id" on ORM::loa...
See #2365 Isaiah DeRose-Wilson
05:07 am Bug Report #2365 (Assigned): Indexes for _object are not loaded properly at ORM from object retur...
Fixed in "abb7e55f2...":http://github.com/kohana/database/commit/abb7e55f2f2c07a3b69034a5bee3f04d5174c986 Isaiah DeRose-Wilson
05:06 am Bug Report #2369 (Closed): Database::list_columns() changes break ORM
Isaiah DeRose-Wilson
05:04 am Database Revision abb7e55f: Changed Database::list_columns() to use the field names as array keys. Fixes #...
Isaiah DeRose-Wilson
05:02 am Bug Report #2369 (Closed): Database::list_columns() changes break ORM
The ORM class expects list_columns() to return an array of all the fields using the field names as the array keys. Ho... Isaiah DeRose-Wilson
04:21 am Bug Report #2368 (Closed): v3.0.2.1: "ErrorException [ Notice ]: Undefined index: id" on ORM::loa...
New bug in 3.0.2.1, ORM::loaded() throws "ErrorException [ Notice ]: Undefined index: id" when invoked on a model obj... Muhammad Lukman Nasaruddin

11/22/2009

06:35 pm Bug Report #2313: Validate::check method returns FALSE when no rules are defined
Woody Gilk wrote:
> > This is bad assumption - you see every object should be valid unless it violates any validatio...
Master Lambaster
03:26 pm Userguide Revision 1ae673e7: Finished translate 'Route' in tutorials.urls.md
icy leaf
03:00 pm Revision 6858725b: Updated user guide
Woody Gilk
02:59 pm Userguide Revision 55db7906: Finished datases tutorial. More information about the query builder methods sh...
Woody Gilk
02:30 pm Userguide Revision 94c8573c: Do not add the base URL to links that are only #id links
Woody Gilk
02:25 pm Userguide Revision 9425c482: Updated menu CSS and JS, make the menu position "sticky" and always visible
Woody Gilk
01:42 pm Bug Report #2313: Validate::check method returns FALSE when no rules are defined
> Those who "trust nothing" should put $_rules, and those who don't put $_rules "trust anything". Kohana3 should be a... Woody Gilk
01:26 pm UnitTest Revision 58421a04: Added some more tests to ArrTest and added a basic RouteTest
Matt Button
01:16 pm Bug Report #2366: Cannot perform INSERT INTO... SELECT query
Little mistake in my fix. It should return *$this* instead of *$query*. Marek Szymczuk
01:07 pm Bug Report #2366 (Closed): Cannot perform INSERT INTO... SELECT query
There is a bug in @select()@ method of @Database_Query_Builder_Insert@ class. With current form, we cannot perform @I... Marek Szymczuk
12:53 pm Bug Report #2313: Validate::check method returns FALSE when no rules are defined
Woody Gilk wrote:
> > This is bad assumption - you see every object should be valid unless it violates any validatio...
Muhammad Lukman Nasaruddin
07:05 am Bug Report #2365 (Closed): Indexes for _object are not loaded properly at ORM from object returne...
Now the database driver returns an array of associative arrays when the method list_columns is called. This change ha... Nano Documet
06:48 am Bug Report #2364 (Closed): Proxy method at ORM for Database sets wrong number of arguments
This method at ORM:... Nano Documet
06:25 am Userguide Revision 3ee4498f: Started the Databases tutorial
Woody Gilk
06:24 am Bug Report #2363 (Assigned): New function _parse_type in database/clasess/kohana/database.php doe...
Woody Gilk
06:01 am Userguide Revision dab9c727: Moved API Browser link from Debugging to Getting Started as it should be immed...
Woody Gilk
05:01 am Bug Report #2363 (Closed): New function _parse_type in database/clasess/kohana/database.php doesn...
The decimal data type (tested with mysql) has a comma on the length definition (ie. **decimal(6,3)**), thus this line... Nano Documet
03:27 am UnitTest Revision 0e7eadd7: Adding .gitignore
Matt Button
03:27 am UnitTest Revision 02a10969: Added some partial tests for Arr
Matt Button
02:21 am UnitTest Revision 5a942ccd: Added some comments to class vars
Matt Button
02:07 am UnitTest Revision 890ef691: Fixing a group name & added some info about group name conventions
Matt Button
12:52 am UnitTest Revision 57ea0dc9: Enabling credit card tests
Matt Button
12:51 am UnitTest Revision dc7517a2: Fixing testPhone() data
Matt Button
12:31 am Feature Request #2140 (Closed): Configurable DB tables/columns names letter case
Woody Gilk
12:31 am Bug Report #2299 (Assigned): ORM: column type is wrongly evaluated
Woody Gilk
12:25 am kohana-3.0.2.1.zip
Woody Gilk
12:24 am UnitTest Revision e2c2f77f: Pointing links at the unittest repo and removing section on kohana-unittest
Matt Button
12:20 am Revision bdc5d89f: Tracking submodules
Woody Gilk
12:20 am Core Revision 990e31dd: Num::format() should not include the currency symbol, money_format() should be...
Woody Gilk
12:16 am Revision 614970b9: Tracking submodules... forgot ORM this time
Woody Gilk
12:14 am Auth Bug Report #2323 (Closed): wrong assign paramete in 'logout' method
Thanks Ivan! Woody Gilk
12:08 am Revision 8b834f36: Tracking submodules
Woody Gilk
12:05 am Auth Revision 8dfabcdf: fixing #2323
Ivan Brotkin

11/21/2009

11:57 pm Revision 2ce06c44: Tracking submodules
Woody Gilk
11:57 pm Core Revision f922e845: E_DEPRECATED only exists in PHP >= 5.3.0, fixes #2362
Woody Gilk
11:56 pm Bug Report #2362 (Closed): Use of undefined constant E_DEPRECATED - assumed 'E_DEPRECATED'
http://github.com/kohana/core/commit/f922e845ae6f098077d368f45874cec33682cad3 Woody Gilk
11:46 pm Bug Report #2362 (Closed): Use of undefined constant E_DEPRECATED - assumed 'E_DEPRECATED'
E_DEPRECATED was added to php 5.3, so if you are using an older version you will get, "Use of undefined constant E_DE... Isaiah DeRose-Wilson
11:45 pm UnitTest Revision aefc7986: Fixed colours - failures should be red, errors yellow not both yellow
Paul Banks
10:42 pm Auth Bug Report #2323 (Assigned): wrong assign paramete in 'logout' method
Woody Gilk
10:39 pm kohana-3.0.2.zip
Woody Gilk
10:04 pm Revision 4bbe1917: Tracking submodules
Woody Gilk
10:04 pm Core Revision 2ddfef5e: Setting next version number
Woody Gilk
09:56 pm Revision 6d44261c: Tracking submodules
Woody Gilk
09:56 pm Core Revision 20efc318: Merge remote branch 'origin/master'
Woody Gilk
09:55 pm Core Revision 38ab9404: Accidently disabled the erorr handler in 950976bae1ff27e32e7778bcef984a1acef60cf2
Woody Gilk
09:31 pm Userguide Revision 5d171139: Filled in userguide section for routes and urls
Colin Mollenhour
06:03 pm Bug Report #2349: Valid::phone() doesn't work with for numbers with a 2 digit international code
Woody Gilk wrote:
> For future reference, @Validate::phone@ accepts an array as the 2nd argument, which contains a l...
Matt Button
05:55 pm UnitTest Revision f8ef457c: Some more use cases
Matt Button
04:14 pm Bug Report #2313 (Feedback): Validate::check method returns FALSE when no rules are defined
> This is bad assumption - you see every object should be valid unless it violates any validation rules.
I would a...
Woody Gilk
04:10 pm Revision 8cf3d727: Tracking submodules
Woody Gilk
04:09 pm Database Revision 3cc0c590: DQB::compile_conditions() should properly handle the BETWEEN operator, fixes #...
Woody Gilk
04:08 pm Bug Report #2069 (Closed): Database Between Statement
Fixed by http://github.com/kohana/database/commit/3cc0c590e87c46f89e51607df664672223cdbbfd Woody Gilk
03:57 pm Database Revision 80ae4f74: Merge branch 'master' of git://github.com/kohana/database
Woody Gilk
03:57 pm Database Revision cc749ee5: Corrected invalid @license class comments
Woody Gilk
03:56 pm UnitTest Revision 91ea9b8a: Added some info about --exclude-group info, updated path to tests.php and move...
Matt Button
03:50 pm Bug Report #2349 (Closed): Valid::phone() doesn't work with for numbers with a 2 digit internatio...
I came up with the same conclusion last night, Geert. The current defaults work for the USA, and since the rest of th... Woody Gilk
03:48 pm UnitTest Revision 484f2f94: Added a message to the validate test
Matt Button
03:45 pm UnitTest Revision b7593cb2: Chaning the validate test slightly. filter_var is out of our control
Matt Button
03:35 pm UnitTest Revision 44873cd6: Modifying the test suite file to be compatible with phpunit cli
Matt Button
10:01 am Revision 2d7d5fd2: Merge branch 'master' of [email protected]:kohana/kohana
Geert De Deckere
09:56 am Bug Report #2349: Valid::phone() doesn't work with for numbers with a 2 digit international code
I would rather opt for a more general default check. Check whether the length of the number is at least seven digits,... Geert De Deckere
09:26 am Bug Report #2337 (Closed): Kohana should ship with the credit cards config file
http://github.com/kohana/core/commit/3f381edc6527be731013708969c8a927ba1e6c64 Geert De Deckere
09:24 am Core Revision 3f381edc: Credit cards config file added. Closes #2337.
Geert De Deckere
07:51 am Revision 9790cff6: Updated system and added comments about E_DEPRECATED to index.php related to #...
Woody Gilk
07:51 am Bug Report #2350 (Closed): Respect error reporting level
Fixed by http://github.com/kohana/core/commit/950976bae1ff27e32e7778bcef984a1acef60cf2 and http://github.com/kohana/k... Woody Gilk
07:49 am Core Revision 950976ba: Kohana::shutdown_handler() should respect the current error reporting settings...
Woody Gilk
07:32 am Bug Report #2350 (Assigned): Respect error reporting level
Woody Gilk

11/20/2009

09:53 pm Feature Request #2355 (Closed): KO3 Request::instance() necessary?
KO3 uses Request::instance() for the main external request and Request::factory() for internal HMVC requests. Initial... Rick Jolly
09:33 pm Bug Report #2352 (Assigned): Table of contents for methods
You mean a complete list on a single page, don't you? Woody Gilk
09:32 pm Bug Report #2352 (Closed): Table of contents for methods
"It does":http://v3.kohanaphp.com/guide/api
!http://img.skitch.com/20091120-r5ceb41wce93qmb45558qudy42.jpg!
Woody Gilk
08:06 pm ORM Revision 564b718c: Follow-up fix for #2261
jheathco -
07:51 pm ORM Revision e1acc9ed: More changes for #2261, compatibility with http://github.com/kohana/database/c...
jheathco -
07:50 pm Bug Report #2261 (Closed): Standardized column/table metadata methods for Database
See http://github.com/kohana/database/commit/448754bec60536927962b81a04ce60d1de059683 and http://github.com/kohana/or... John Heathco
07:39 pm Database Revision 448754be: Merging cbandy's changes for #2261 (column/table metadata)
jheathco -
12:02 am Bug Report #2352 (Closed): Table of contents for methods
The API browser should have a table of contents for each class to quickly reference functions. John Heathco

11/19/2009

10:15 pm Feature Request #2140: Configurable DB tables/columns names letter case
Hi John,
that is all right, agreed.
When you will return back to the issue, do not forget to think about these ...
Andrei Molchanov
08:02 pm ORM Revision a4db9f74: Implementing #2121
jheathco -
08:01 pm Patch #2121 (Closed): Allow saving addtional fields to ORM many-to-many pivot tables
See http://github.com/kohana/orm/commit/a4db9f74e3a65f180a633c7689621873604ea1f5. John Heathco
07:51 pm Feature Request #2331 (Feedback): Don't select all columns when select() was applied
I'm not sure of a solution for this - perhaps writing custom methods in your models to do the raw queries. John Heathco
07:51 pm Bug Report #2231 (Closed): ORM doesn't wake up properly
John Heathco
07:43 pm Feature Request #2140: Configurable DB tables/columns names letter case
Andrei,
This is because plurality is a much more common issue than casing in table names. However, you are right,...
John Heathco
05:11 pm Bug Report #2350 (Closed): Respect error reporting level
line 923 of system/classes/kohana/core.php (in the shutdown_handler) reads the following:... Timothy Antonissen
02:06 pm Feature Request #2279 (Closed): Pagination::factory() should support text values (config names)
Woody Gilk
01:13 pm Feature Request #2251: Pass to the next route if controller or method not found
http://github.com/MasterLambaster/core/commit/2628ceffa15226c42abf9cddf91e41841512f07e
One of the possible ways to s...
Master Lambaster
09:44 am Bug Report #2349: Valid::phone() doesn't work with for numbers with a 2 digit international code
Sorry I meant Validate::phone(), not Valid::phone() Matt Button
09:04 am Bug Report #2349 (Closed): Valid::phone() doesn't work with for numbers with a 2 digit internatio...
1) Kohana_ValidateTest::testPhone with data set #5 ('+44 20-7031-3000', true)
Failed asserting that <boolean:false> ...
Matt Button
05:52 am Feature Request #2279: Pagination::factory() should support text values (config names)
Ok, I forgot about this feature. I'm sorry, close this ticket please. Ivan Brotkin
12:29 am Feature Request #2140 (Feedback): Configurable DB tables/columns names letter case
Hi John,
look at the code snippet
// Model configuration
protected $_table_names_plural = TRUE;
ie we have ...
Andrei Molchanov

11/18/2009

11:58 pm Bug Report #2305: ORM - _preload_data not being saved
I figured that the default behavior would be to persist the data that is preloaded. Hence my attached patch. Howeve... Eric Kingery
11:06 pm Bug Report #2305 (Closed): ORM - _preload_data not being saved
I'm guessing you're trying to override default values for the ORM model. You have to mark those columns as changed i... John Heathco
11:03 pm Bug Report #2304 (Closed): ORM - Primary Key Errors After Using values()
I'll mark this invalid. You can re-open this ticket if you run into problems again. John Heathco
10:51 pm Bug Report #2310: auto_render doesn't actually render in Controller_Template
That's fine, thanks for changing the comment.
Mr Anchovy
09:38 pm Feature Request #2279: Pagination::factory() should support text values (config names)
If you want to load settings from a certain Pagination config group, you can pass on @array('group' => 'group_name')@... Geert De Deckere
09:31 pm Feature Request #2247 (Closed): Pagination Class should have an offset property for using in db::...
This property has been added in http://github.com/kohana/pagination/commit/81fe5691c4f2e206707f3e8ae2408d5ba846b8d9 Geert De Deckere
09:27 pm Feature Request #2346: Formatting Decimal Numbers
Creating a locale-aware version of number_format is useful. Trying to add money_format functionality to Num::format i... Geert De Deckere
09:21 pm Bug Report #2305: ORM - _preload_data not being saved
I don't think this issue is related to the primary key. I am setting $this->_preload_data in the constructor of my m... Eric Kingery
09:04 pm Bug Report #2304: ORM - Primary Key Errors After Using values()
I am no longer seeing this issue, with or without the patch on github. As far as I am concerned, it can be closed. ... Eric Kingery
07:40 pm Feature Request #2331: Don't select all columns when select() was applied
my suggestion, because when we use with() than it applies select so we must manually do the $this->_table_name.'.*'
...
Bartłomiej Kuleszewicz
07:38 pm UnitTest Revision b9fde49f: Adding test for URL helper
Matt Button
07:01 pm ORM Revision 3f37c052: Fixing #2187
jheathco -
07:00 pm Patch #2187 (Closed): Joining tables in ORM::with
Thanks, fixed in http://github.com/kohana/orm/commit/3f37c0526bc6a554e925e6254135538eae248dc2 John Heathco
06:59 pm Feature Request #2331: Don't select all columns when select() was applied
What causes problems, the current implementation or your suggested fix? John Heathco
06:54 pm ORM Revision f5b5d2ca: Fixing #2322
jheathco -
06:53 pm Bug Report #2322 (Closed): ORM __set() method does not flag $_belongs_to data as $_changed, thus ...
Thanks! Fixed in http://github.com/kohana/orm/commit/f5b5d2caafb5a617feb4d49663f8d0690b9242fa John Heathco
06:49 pm Bug Report #2305 (Feedback): ORM - _preload_data not being saved
John Heathco
06:47 pm Feature Request #2140 (Closed): Configurable DB tables/columns names letter case
Hi Andrei,
I believe it is unnecessary overhead to support different casing methods - just use _table_name.
John Heathco
06:45 pm Bug Report #2026 (Closed): ORM as_array method not work
Closing this ticket until feedback is provided. John Heathco
06:44 pm Bug Report #2280: Error with ORM & Validation when overloading __set() in model
Please see http://dev.kohanaphp.com/issues/2301 John Heathco
06:44 pm Bug Report #2301 (Closed): Post validation in ORM, the _object member should be updated directly,...
John Heathco
06:43 pm Bug Report #2280 (Closed): Error with ORM & Validation when overloading __set() in model
This should be resolved in the latest git trunk. Please advise if not. John Heathco
06:42 pm Bug Report #2305: ORM - _preload_data not being saved
I'm confused here... shouldn't the primary key be set in the preloaded data? Is this not occurring? John Heathco
06:34 pm ORM Revision 369ea7d1: Fixing #2304
jheathco -
06:33 pm Bug Report #2304: ORM - Primary Key Errors After Using values()
Possible fix in http://github.com/kohana/orm/commit/369ea7d16d621ac1f02a4ee3dad02b0fd3899a33
Please give me an upd...
John Heathco
04:48 pm Feature Request #2347 (Closed): ReflectionException if routing failed
Woody Gilk
06:51 am Feature Request #2347 (Closed): ReflectionException if routing failed
Better to throw something another (e.g. RoutingException), no?
It will be easier to catch this and show 404 error, ...
Alex Grebennik
01:24 am Bug Report #2313: Validate::check method returns FALSE when no rules are defined
I think this is a validation issue, although I need to discuss this with Woody more. If no rules are defined on a gi... John Heathco
12:45 am Feature Request #2346 (Closed): Formatting Decimal Numbers
Fixed by http://github.com/kohana/core/commit/5841fa930f96f833ac391efc49850f0a0e445234
This should technically be ...
Woody Gilk
12:41 am Core Revision e242e68c: Merge branch 'master' of git://github.com/kohana/core
Woody Gilk
12:40 am Core Revision 5841fa93: Added Num::format(), i18n version of number_format() for monetary and non-mone...
Woody Gilk
12:39 am Feature Request #2346 (Closed): Formatting Decimal Numbers
The "@number_format@":http://php.net/number_format function is not locale-aware, and "@money_format@":http://php.net/... Woody Gilk

11/17/2009

08:20 pm UnitTest Revision 1a863d95: Adding an explanation for the absurd camelCase
Matt Button
08:18 pm UnitTest Revision 7dc35334: Offloading preservation of globals to phpunit
Matt Button
08:13 pm UnitTest Revision 69953cef: Adding CLI tests
Matt Button
08:04 pm Feature Request #2345: Query builder should support MySQL native functions.
I did spend a while searching, but completely missed the search box here on /dev, whoops :)
I guess this is anothe...
Andrew Ellis
07:54 pm Feature Request #2345 (Closed): Query builder should support MySQL native functions.
There are two ways to use any SQL function (not just MySQL). The first is by using double quotes:... Woody Gilk
06:37 pm Feature Request #2345 (Closed): Query builder should support MySQL native functions.
Currently the query builder wraps MySQL native functions in single quotes, which causes the function to not run, rath... Andrew Ellis
04:50 pm UnitTest Revision 9bd57a7c: Moved test suite to classes/kohana/tests.
Replaced references in the webrunner & provided a faux tests.php for cli
users
Matt Button
04:21 pm Revision 5040ab3f: Merge branch 'master' of [email protected]:kohana/kohana
Geert De Deckere
04:15 pm Core Revision 1028f348: Small comment cleanup
Geert De Deckere
01:45 pm Revision 8a457dc9: Tracking submodules
Woody Gilk
01:43 pm Core Revision d78bf96b: This should have been part of b392b7cdb16c80fddcba0e47103d07afe2cbf484
Woody Gilk
06:43 am Revision 0b772ddf: Tracking submodules
Woody Gilk
06:32 am Bug Report #2266: Make region optional in i18n::$lang
Fixed a bug introduced introduced by the above fix in http://github.com/kohana/core/commit/b392b7cdb16c80fddcba0e4710... Woody Gilk
06:30 am Core Revision 35d75d75: Cleaned up comments on Encrypt::decode()
Woody Gilk
06:30 am Core Revision 6b8ae470: Cleaning up I18n::load()
Woody Gilk
06:30 am Core Revision 1d49b4bb: Added Kohana::deinit(), cleans up (some of) the changes that Kohana::init() ma...
Woody Gilk
06:30 am Core Revision b392b7cd: Fixes a bug introduced in e5f3685af265252e81144d16d39a8d271177542d that would ...
Woody Gilk
03:50 am Feature Request #2182 (Closed): kohana cleanup after work is done
Fixed by http://github.com/kohana/core/commit/1d49b4bb8e77ea2dca1ee25f28f1700e23877eaa Woody Gilk
03:19 am Bug Report #1981 (Closed): spl_register_autoload() playing friendly with others
I think this an upstream issue with $framework. No autoloader should ever throw an exception if a file is not found. ... Woody Gilk
03:14 am Patch #2023: Form input helper
The simple solution would be to not set @id@ if @name@ contains invalid characters. Woody Gilk
03:11 am Bug Report #2069: Database Between Statement
The proper usage of this would be:... Woody Gilk
03:09 am Core Revision 1ee6c2c0: Fixed comments in Controller_Template that conflict with what is actually done
Woody Gilk
03:09 am Bug Report #2310: auto_render doesn't actually render in Controller_Template
Removed the conflicting comment in http://github.com/kohana/core/commit/1ee6c2c0daf44ba76f107a03980d99068acca69c Woody Gilk
03:07 am Bug Report #2310 (Closed): auto_render doesn't actually render in Controller_Template
Woody Gilk
03:06 am Core Revision 56df7080: Added I18n::lang(), to get and set I18n::$lang, performs additional normalizat...
Woody Gilk
03:06 am Feature Request #2112 (Closed): I18n::$lang "standardisation"
Woody Gilk
03:06 am Bug Report #2266 (Closed): Make region optional in i18n::$lang
Fixed by http://github.com/kohana/core/commit/e5f3685af265252e81144d16d39a8d271177542d Woody Gilk
03:06 am Feature Request #2112: I18n::$lang "standardisation"
Fixed by http://github.com/kohana/core/commit/56df708092899ff7c0bca6547b1bc0e177cf9f9e Woody Gilk
03:05 am Core Revision e5f3685a: Make it possible to set I18n::$lang to a value that does not include a region ...
Woody Gilk

11/15/2009

12:12 am UnitTest Revision 30f3e484: Changing some inaccuracies in the groups
Matt Button

11/14/2009

11:30 pm UnitTest Revision e5733b21: Changing the submodule pull url
Matt Button
10:24 pm UnitTest Revision e80175c8: Removed old test suite file as it now resides in classes dir
Paul Banks
10:23 pm UnitTest Revision b13a28c0: Added web based test runner
Paul Banks
11:50 am Feature Request #2331: Don't select all columns when select() was applied
hm... this causes problems with "ORM::with()" because it applies the select:... Bartłomiej Kuleszewicz
12:34 am Feature Request #2278: Add transaction support
I was going to say this is impossible because PDO would not be able to support it. However, PDO has @beginTransaction... Woody Gilk
12:30 am Bug Report #2318 (Closed): Kohana_PHP_Exception: fopen(Unknown)
Fixed by http://github.com/kohana/core/commit/ef359a1703dabbaf6a3ab3821e1704fc460b18ca (fingers crossed) Woody Gilk
12:28 am Core Revision ef359a17: Do not try to open unreadable files in Kohana::debug_source(), fixes #2318
Woody Gilk
12:22 am Bug Report #2333 (Closed): The Encrypt->decode() assumes too much about the input data
Fixed by http://github.com/kohana/core/commit/2937445626c8e96c30ed2c5c778cab351a1ea7bb Woody Gilk
12:20 am Core Revision 29374456: More strict checking when calling Encrypt::decode(), fixes #2333
Woody Gilk
12:15 am Revision 00d6dcf5: Tracking submodules
Woody Gilk
12:14 am Userguide Revision 3ca1145d: Merge branch 'master' of git://github.com/biakaveron/userguide-ru
Woody Gilk
12:14 am Userguide Revision 4fd8a7c5: Sync offical to "zh-cn" language package.
icy leaf
12:12 am Feature Request #2336 (Closed): Adding mime by extention to send_file
Fixed by http://github.com/kohana/core/commit/cf19e356b241e419dd7e3fe0155119f9c51498b5 Woody Gilk
12:11 am Core Revision cf19e356: Cleaning up the manual mime type settings and method comments on Request::send...
Woody Gilk
12:00 am Core Revision f0a3eb10: forgot semicolon in send file
store libraries
12:00 am Core Revision 88f26de7: Document send_file $options change
store libraries
12:00 am Core Revision c0f53b00: Added support for an override of the mime type in send_file()
store libraries

11/13/2009

07:20 pm UnitTest Revision 1b08ebd9: There's now a test for every validate helper apart from Regex. Some tests are ...
Matt Button
06:41 pm UnitTest Revision f127e9a4: Added the notorious STEP 0 (thanks jerph ;)
Matt Button

11/12/2009

06:54 pm Core Revision 174f23c5: Fixed incorrect @license for several classes
Woody Gilk
06:53 pm Core Revision b4d78542: Added doc comment to Num::ordinal()
Woody Gilk
02:58 pm Revision 8b71c5a9: updated the DEVELOPERS.markdown to clarify
Signed-off-by: Woody Gilk <[email protected]> Joel Pittet
02:57 pm Revision 0ef92da8: updated the DEVELOPERS.markdown to the new github address
Signed-off-by: Woody Gilk <[email protected]> Joel Pittet
05:25 am Core Revision 77f389c5: Merge branch 'master' of git://github.com/kohana/core
Woody Gilk
05:24 am Core Revision 4d5cc1ab: Updated File::mime(), switched to using Finfo OOP rather than procedural
Woody Gilk
05:23 am Core Revision c9793d1d: Updated Request::send_file(), changed $resumable parameter to $options paramet...
Woody Gilk
05:22 am Core Revision 47061c98: Added Num class, a helper for dealing with numbers
Woody Gilk

11/11/2009

09:04 pm Feature Request #2336 (Review): Adding mime by extention to send_file
Woody Gilk
08:58 pm Bug Report #2335 (Rejected): Response code not set in Request::send_headers() if Request::$header...
The @send_headers()@ method should only be called on the request instance, never on sub requests. Woody Gilk
08:19 pm Feature Request #2336 (Feedback): Adding mime by extention to send_file
I route many files through send_file. Detection works on everything besides css files. Which it returns the file with... Tyler Tallman
08:13 pm Patch #2332 (Closed): Re-order caching checks
Woody Gilk
07:57 pm Patch #2332: Re-order caching checks
Ah ok. Thanks! Marcus Cobden
06:42 pm UnitTest Revision dc788f0f: Added tests for Validate helpers
Matt Button
06:26 pm Bug Report #2337 (Closed): Kohana should ship with the credit cards config file
Validate::credit_card() uses the credit_cards config file from k2, but it doesn't exist in k3.
See: http://source....
Matt Button
06:19 pm Patch #2332 (Rejected): Re-order caching checks
The cache directly must always be writable, even if caching is off. The @caching@ option only turns off caching that ... Woody Gilk
06:16 pm Feature Request #2336 (Closed): Adding mime by extention to send_file
That is not necessary, since File::mime() already falls back to returning the mime by extension. See http://github.co... Woody Gilk
05:09 pm UnitTest Revision 780b8940: Typo
Matt Button
05:07 pm UnitTest Revision 658b8951: Added some documentation about data providers & linked to some resources for g...
Matt Button
04:57 pm Feature Request #2336 (Closed): Adding mime by extention to send_file
Php's mime handling is unbearable.
Here is a possible patch I made. That leaves default behavior and requires anothe...
Tyler Tallman
04:40 pm UnitTest Revision a6f7f01d: Added some more info about groups to the README
Matt Button
03:34 pm Bug Report #2335: Response code not set in Request::send_headers() if Request::$headers is empty.
my temporary solution for this issue:... Eduard B
11:29 am Bug Report #2335 (Rejected): Response code not set in Request::send_headers() if Request::$header...
If you create a Request using the factory method, assign a response code to the 'status' property then call @Request:... Aron C

11/10/2009

11:52 am Bug Report #2333 (Closed): The Encrypt->decode() assumes too much about the input data
Let me start with a little history which affects this library.
1st failure case:
Till PHP 5.2.0 the base64_decode...
Ștefan-Mircea Rusu
10:07 am Patch #2332 (Closed): Re-order caching checks
This is just a small patch to re-order the caching checks in core, so that if caching is off, kohana doesn't bother t... Marcus Cobden

11/09/2009

09:19 pm Userguide Revision 7569b639: start.foo -> about.foo
Ivan Brotkin
07:42 pm Cache Revision c2406183: Amended the documentation to correctly demonstrate the the lifetime parameter
Sam de Freyssinet
11:31 am Feature Request #1962: Add span method to Kohana_HTML
I find this quite useful when dealing with multiple classes. (first, last, errors etc)... Jonathan Sully
09:32 am Feature Request #2331 (Closed): Don't select all columns when select() was applied
In ORM::_load_result() replace:... Bartłomiej Kuleszewicz
05:07 am Revision c178e800: updated the DEVELOPERS.markdown to clarify
Joel Pittet
04:57 am Revision 7c86ed79: updated the DEVELOPERS.markdown to the new github address
Joel Pittet
04:41 am Feature Request #2297: Allow Database_Result serialization through conversion to Database_Cache_R...
Hi all, i was recently trying to figure out why i couldn't store a complete ORM_Iterator object in memcache and i was... shawn t

11/08/2009

10:50 pm Patch #2326: Select argument as single item array fix
Joel Pittet wrote:
> Any chance you would consider changing the params to allow for an array argument to set the fie...
Woody Gilk
10:20 pm Patch #2326: Select argument as single item array fix
Any chance you would consider changing the params to allow for an array argument to set the fields and use Arr::is_as... Joel Pittet
10:06 pm Patch #2326: Select argument as single item array fix
Ok, I will update that wiki page to include the alias syntax Joel Pittet
07:14 pm Bug Report #2318 (Feedback): Kohana_PHP_Exception: fopen(Unknown)
Woody Gilk
06:28 pm Patch #2326: Select argument as single item array fix
Hmm, that wiki page in question has some broken code... you should never be doing @array('col')@, arrays are *only* f... Woody Gilk
05:20 pm Patch #2326: Select argument as single item array fix
Ok here it is... Joel Pittet
05:15 pm Patch #2326: Select argument as single item array fix
Hold up, patch is wrong... give me a sec... Joel Pittet
05:09 pm Patch #2326: Select argument as single item array fix
Sorry, I must not have had my modules up to date.
I'll try a single file this time. (new to patches and git)
Joel Pittet
02:23 pm Patch #2326 (Feedback): Select argument as single item array fix
Your license change is invalid and results in an error. Woody Gilk
08:23 am Auth Bug Report #2323: wrong assign paramete in 'logout' method
"fixed":http://github.com/biakaveron/kohana-auth/commit/cbfc7db65cf41dd8e286238a7a91d7693e57356f, thanks! Ivan Brotkin
07:15 am Patch #2326 (Closed): Select argument as single item array fix
Added code to count the array items if passed to the select method as a single item array in kohana/database.php's qu... Joel Pittet
04:17 am Revision 64ca9f4f: Tracking submodules
Woody Gilk
04:15 am Userguide Revision f5dcad34: Merge branch 'master' of git://github.com/icyleaf/userguide-cn
Woody Gilk
04:14 am Image Revision 97e87536: Cleaned up whitespace
Woody Gilk
04:11 am Patch #2324 (Closed): Comment fix and min/max additions to image.php
Fixed by http://github.com/kohana/image/commit/de4ff2087cbd7d48a82602fc5acead19decce257 Woody Gilk
04:03 am Image Revision de4ff208: Apply proper min/max values where missing, fixes #2324
Woody Gilk

11/07/2009

08:05 pm Patch #2324 (Closed): Comment fix and min/max additions to image.php
These are some minor changes: a comment fix and applied the min/max code to methods that had min-max range in the com... Joel Pittet
06:44 pm Auth Bug Report #2323 (Closed): wrong assign paramete in 'logout' method
Fie: classes/kohana/auth/orm.php
Line: 195...
icy leaf
05:39 pm Feature Request #2297 (Feedback): Allow Database_Result serialization through conversion to Datab...
Apologies for continuing with a closed issue but I don't feel the reason for closing it was valid.
I agree complet...
Paul Banks
03:04 pm Userguide Revision 809253d9: Sync offical to "zh-cn" language package.
icy leaf
02:27 pm Bug Report #2322 (Assigned): ORM __set() method does not flag $_belongs_to data as $_changed, thu...
Woody Gilk
02:13 pm Bug Report #2322 (Closed): ORM __set() method does not flag $_belongs_to data as $_changed, thus ...
Even after setting $orm->field where field is a $_belongs_to alias, ORM does not save the value to database upon call... Muhammad Lukman Nasaruddin
07:46 am Feature Request #2278 (Feedback): Add transaction support
Wouldn't it be better to abstract the transaction queries? Because the syntax for different Databases vary:
http:/...
Tomas Mikelskas
05:34 am Patch #2321 (Closed): Exception thrown for writable cache file with caching turned off
The cache directory is not just used for internal caching (@Kohana::$caching@) but for *all* @Kohana::cache()@ calls,... Woody Gilk
05:00 am Patch #2321 (Closed): Exception thrown for writable cache file with caching turned off
Exception thrown for writable cache file with caching turned off in Kohana_Core.
First time patch, hope it's the...
Joel Pittet
01:22 am Bug Report #2308: Table prefix ignored in list_columns method
Thanks again for the feedback! Isaiah DeRose-Wilson
01:21 am Bug Report #2308: Table prefix ignored in list_columns method
Yes, that's ok now. Thanks :) Alex Grebennik
12:57 am Bug Report #2308 (Closed): Table prefix ignored in list_columns method
Isaiah DeRose-Wilson
12:55 am Bug Report #2308: Table prefix ignored in list_columns method
Ah right, it's a value not an database identifier! Duh! Thanks for your feedback :)
Fixed (for real) in "35d51f624...
Isaiah DeRose-Wilson
12:51 am Database Revision 35d51f62: Fixed quoting of table names in list_columns() function. Refs #2308
unknown
12:40 am Feature Request #2297 (Closed): Allow Database_Result serialization through conversion to Databas...
This doesn't actually apply to @Database_Result@ directly, but rather to the classes that use them, so I am going to ... Woody Gilk
12:31 am Patch #2238 (Closed): HTML::Image does not support index.php in link
Fixed by http://github.com/kohana/core/commit/7f87b0ddcd3eeca48c02851799500f76019a20d0 Woody Gilk
12:30 am Core Revision 7f87b0dd: HTML::image() should have an $index parameter, similar to HTML::script() and H...
Woody Gilk
12:27 am Bug Report #2310: auto_render doesn't actually render in Controller_Template
I am not really sure that this is a universal issue. Keeping the template object as an object is much more flexible. Woody Gilk
12:25 am Bug Report #2304 (Feedback): ORM - Primary Key Errors After Using values()
Woody Gilk
12:25 am Bug Report #2305 (Assigned): ORM - _preload_data not being saved
Woody Gilk
12:25 am Bug Report #2310 (Review): auto_render doesn't actually render in Controller_Template
Woody Gilk
12:23 am Feature Request #2319 (Closed): Have option for Remote::get() to not throw an error
Woody Gilk
12:15 am Bug Report #2308 (Feedback): Table prefix ignored in list_columns method
Alex Grebennik
12:15 am Bug Report #2308: Table prefix ignored in list_columns method
because it generates wrong query:
Database_Exception [ 1054 ]: Unknown column 'prefix_table_name' in 'where clause...
Alex Grebennik

11/06/2009

11:58 pm Bug Report #2308 (Closed): Table prefix ignored in list_columns method
Why do you want to use $this->quote($this->table_prefix().$table) instead of $this->quote_table($table)?
Fixed in...
Isaiah DeRose-Wilson
11:54 pm Database Revision 496db7d9: Added table prefix support to list_columns(), fixes #2308
unknown
11:40 pm Feature Request #2319 (Closed): Have option for Remote::get() to not throw an error
When working with Remote it is not desirable to always throw a Kohana exception when the curl request responds with n... Ryan Mayberry
07:18 pm Bug Report #2317 (Closed): Allow extension of Kohana::find_file() for us in Kohana::auto_load()
Has already been fixed by http://github.com/kohana/core/commit/65361f66a302cb83ae4ae30b9705b89010f12e20 Woody Gilk
06:11 pm Bug Report #2317 (Closed): Allow extension of Kohana::find_file() for us in Kohana::auto_load()
The call to Kohana::find_file() in Kohana::auto_load() shouldn't be on 'self::' but on 'Kohana::'.
Otherwise a self ...
Samuel Vogel
08:37 am Bug Report #2313: Validate::check method returns FALSE when no rules are defined
Ivan Brotkin wrote:
> IMO, its a Validate issue. No rules -> no data for validating -> $submitted === FALSE -> retur...
Master Lambaster

11/05/2009

11:35 pm Bug Report #2307 (Closed): database query builder support for functions in select columns
@COUNT("*")@ will be processed correctly. If you add double quotes to an identifier, only the value inside the quotes... Woody Gilk
11:32 pm Bug Report #2307: database query builder support for functions in select columns
Just to be clear, Bence Eros is talking about @COUNT(*)@ rather than @COUNT()@. Chris Bandy
11:18 pm Database Bug Report #2188: Database PDO dosn't support last inserted id in PGSQL Driver
Patch moved to http://github.com/cbandy/kohana-database/commits/bug-2188
fn. "(commit)":http://github.com/cbandy/k...
Chris Bandy
07:33 pm Bug Report #2315 (Closed): ReflectionException is thrown in core.php when a closure throws an Exc...
Fixed by http://github.com/kohana/core/commit/f84b576d1cf92158b6c0878d66bef545af4e393d Woody Gilk
07:31 pm Revision f6d9de44: Tracking submodules
Woody Gilk
07:30 pm Core Revision f84b576d: Add handling for closures to Kohana::trace(), fixes #2315
Woody Gilk
06:50 pm Feature Request #2312 (Feedback): Optional third parameter for Session::get() to set the session ...
Woody Gilk
06:29 pm Bug Report #2315 (Closed): ReflectionException is thrown in core.php when a closure throws an Exc...
When an Exception is thrown inside a Closure Kohana::trace() breaks, since it tries to create a ReflectionFunction Ob... Samuel Vogel
02:53 pm Bug Report #2313: Validate::check method returns FALSE when no rules are defined
IMO, its a Validate issue. No rules -> no data for validating -> $submitted === FALSE -> return FALSE.
We can use...
Ivan Brotkin
09:55 am Bug Report #2313 (Closed): Validate::check method returns FALSE when no rules are defined
If in ORM descending class $_rules variable is not redefined, check method always return false. ... Master Lambaster

11/04/2009

11:43 pm Feature Request #2312 (Closed): Optional third parameter for Session::get() to set the session ke...
In some situations I'd like it if the Session::get() method, when returning the default value, would also set the ses... Neutral Person
04:12 pm Revision 019f1cdf: Remove KOHANA_START_* from index.php, they are now defined in base.php
Woody Gilk
04:11 pm Revision dbda2ea7: Tracking submodules
Woody Gilk
04:05 pm Bug Report #2275 (Closed): SQL TRUE and FALSE are not SQL-92
Fixed by http://github.com/kohana/database/commit/1840954df826cc84ed909de74864d8408ba14853 Woody Gilk
02:31 pm Bug Report #2307 (Feedback): database query builder support for functions in select columns
There are two big problems with this patch:
1. It uses eregi, which is against our "guidelines":http://dev.kohanaf...
Woody Gilk
02:26 pm Bug Report #2310: auto_render doesn't actually render in Controller_Template
Oops, please ignore the last part of that report after 'confusing the heck out of my JSON API implementation.' Mr Anchovy
02:24 pm Bug Report #2310 (Closed): auto_render doesn't actually render in Controller_Template
In system/controller/template.php, the after() method of Controller_Template should render the view assigned to $this... Mr Anchovy
11:10 am Bug Report #2307: database query builder support for functions in select columns
Woody Gilk wrote:
> Not necessary, this is what @DB::expr()@ is for:
>
> DB::select(DB::expr('COUNT()'), ...)...
Bence Eros
04:13 am Bug Report #2307: database query builder support for functions in select columns
Not necessary, this is what @DB::expr()@ is for:
DB::select(DB::expr('COUNT()'), ...)
Although typically, y...
Woody Gilk

11/03/2009

11:06 pm Bug Report #2308: Table prefix ignored in list_columns method
FIX: $this->quote($table) should be $this->quote($this->table_prefix().$table) Alex Grebennik
10:54 pm Bug Report #2308 (Closed): Table prefix ignored in list_columns method
Just updated to latest revision and got error:... Alex Grebennik
09:52 pm Patch #2263: Fix for translation of parameters in Kohana_Validate::errors
I used a "review" button to add my first response when looking for a way to respond. That was probably the wrong thin... Michael Brownlow
09:19 pm Database Revision 1840954d: Quote booleans as SQL-92 literals '0' and '1'. Fixes #2275
Chris Bandy
09:13 pm Bug Report #2307 (Closed): database query builder support for functions in select columns
if the code is
@DB::select('count(*)')@ ...
then the compiled sql is: @select `count(*)`@
the following code could...
Bence Eros
07:58 pm Patch #2273: Native Postgresql driver for Kohana 3
I've moved my work to http://github.com/cbandy/kohana-postgresql. Chris Bandy
07:54 pm Feature Request #2297: Allow Database_Result serialization through conversion to Database_Cache_R...
Agreed. Since we have a resource-free @Database_Result@ (i.e., @Database_Result_Cached@,) it seems reasonable to prov... Chris Bandy
05:17 pm Patch #2263: Fix for translation of parameters in Kohana_Validate::errors
I'm not sure how we could fix this. Going to move this to v3.1.0 as the fix would require some kind of API change.
...
Woody Gilk
05:16 pm Feature Request #2229 (Closed): Allow to have NULL in first parameter of order_by
Chris is 100% correct. Reverted in http://github.com/kohana/database/commit/be81e9bb0c0b7996d2b4ff0969349f626b00c8e9 Woody Gilk
05:14 pm Database Revision be81e9bb: Revert "Allow sorting without a column name (eg: RAND()), fixes #2229"
This reverts commit c56ad72eaec8a0a440a9f290e77eb5b973e35b5d.
The correct solution is to use DB::expr('RAND()') for ...
Woody Gilk
05:08 pm Bug Report #2306 (Closed): Database Connection Failure Displays Incorrect Error
Fixed by http://github.com/kohana/database/commit/339b5a67d71eecdd2088b8fd3c685b8ec01ed2c8 Woody Gilk
05:07 pm Bug Report #2306 (Closed): Database Connection Failure Displays Incorrect Error
When connecting to a database with invalid parameters, no error message is displayed because the @Error_Exception@ is... Woody Gilk
05:07 pm Database Revision 339b5a67: Database connection errors display no information, fixes #2306
Woody Gilk
04:50 pm Bug Report #2305: ORM - _preload_data not being saved
This bug was brought up in the forums on 10/29:
http://forum.kohanaphp.com/comments.php?DiscussionID=3908
Eric Kingery
04:49 pm Bug Report #2305 (Closed): ORM - _preload_data not being saved
$_preload_data is not working for me. The data is getting loaded into $_object, but it is never getting marked as 'c... Eric Kingery
04:46 pm Bug Report #2304 (Closed): ORM - Primary Key Errors After Using values()
http://forum.kohanaphp.com/comments.php?DiscussionID=3908
The first issue is with the $model->values() method. If ...
Eric Kingery
03:20 pm Bug Report #2303 (Closed): table name aliasing does not work in db query builder
Duplicate of #2237. Woody Gilk
03:01 pm Bug Report #2303 (Closed): table name aliasing does not work in db query builder
If you use a database query builder and you write
->from('tablename as alias')
then it will be quoted this way:
`...
Bence Eros
12:12 pm Bug Report #2318 (Closed): Kohana_PHP_Exception: fopen(Unknown)
I'm getting this error sometimes, but can't reproduce this.
The error screen (without formatting) is:...
Caio Ariede -

11/02/2009

11:13 pm Bug Report #2301: Post validation in ORM, the _object member should be updated directly, not via ...
Fixed in http://github.com/kohana/orm/commit/a0bf32843b2bfbfa2fa0e3ef04f500e30e948284 John Heathco
11:11 pm ORM Revision f9d7b7f5: Merge branch 'master' of [email protected]:kohana/orm
jheathco -
11:09 pm Bug Report #2301 (Closed): Post validation in ORM, the _object member should be updated directly,...
See subject John Heathco
11:09 pm ORM Revision a0bf3284: Fixing #2301
jheathco -
08:41 pm Core Revision c6122c0c: Added declaration of KOHANA_START_* to base.php, if not already defined
Woody Gilk
11:57 am Bug Report #2299 (Closed): ORM: column type is wrongly evaluated
Just as a clue, in _load_type() method after:... Josip Jelic
09:30 am Bug Report #2231: ORM doesn't wake up properly
As per my last post and thanks to Ivan, I suppose now this was a bug in my app or in A1. Object data is not set in my... Cédric Cazette

11/01/2009

08:10 pm Bug Report #2231 (Feedback): ORM doesn't wake up properly
Can I get some more feedback on what exactly needs to be fixed here? Thanks! John Heathco
08:02 pm Bug Report #2244 (Closed): ORM with method should use LEFT join
I believe it should always use LEFT JOINs. If you want other types of joins, it is best to write a custom method. John Heathco
08:01 pm Bug Report #2262 (Closed): $_load_with not applied
Fixed in http://github.com/kohana/orm/commit/ba6adfddf59b80f5701064a903ae240f21250a63 John Heathco
07:59 pm ORM Revision ba6adfdd: Fixing #2262
unknown
03:18 pm Feature Request #2229 (Review): Allow to have NULL in first parameter of order_by
Woody, you were right the first time. Passing a direction without a column does not make sense.
What the user really...
Chris Bandy
11:42 am Feature Request #2297 (Closed): Allow Database_Result serialization through conversion to Databas...
h2. Problem
Currently Database_MySQL_Result objects can't be serialized due to their reliance on a mysql resource....
Paul Banks

10/31/2009

10:59 pm Feature Request #2140: Configurable DB tables/columns names letter case
Hi John!
Yeah, you are right. Also I am able to set plurality/singularity by means of proper _table_name member se...
Andrei Molchanov
10:54 pm Feature Request #2290: SESSION, $_POST, $_GET, $_COOKIE in Profiler
No, but you can certainly fork on github and send a pull request when it get it implemented. Woody Gilk
10:46 pm Patch #2263: Fix for translation of parameters in Kohana_Validate::errors
Aha, after looking more closely I didn't see the full context of how :param's were being used. So yes, that patch is ... Michael Brownlow
10:18 pm Revision 36eeae57: Tracking submodules
Woody Gilk
10:18 pm Revision 080f8ee3: Tracking submodules
Woody Gilk
10:18 pm Revision 3085cb1a: Adding unserialize_callback_func setting to bootstrap.php, fixes #2222
Woody Gilk
10:17 pm Feature Request #2232 (Closed): Get name from route
Fixed by http://github.com/kohana/core/commit/8579a1c41114e557334097dcfab8cdd0ff3ac2bb Woody Gilk
10:16 pm Core Revision 8579a1c4: Added Route::name() to get the name of a route
Woody Gilk
10:13 pm Core Revision 000c1281: Clean up Validate::errors() and remove Route::__set_state()
Woody Gilk
10:08 pm Patch #2263: Fix for translation of parameters in Kohana_Validate::errors
Your patch makes no sense... labels are for field names, not values. What are you expecting this to do? Woody Gilk
10:05 pm Bug Report #2204 (Closed): Translate validation labels
Fixed by http://github.com/kohana/core/commit/59b77717b56526a80fd020cea409719d0b0ef56d Woody Gilk
10:04 pm Core Revision 59b77717: Translate Validate labels, fixes #2204
Woody Gilk
10:01 pm Bug Report #2219 (Closed): Allow Kohana_Database_Query_Builder_Select to accept OFFSET without LIMIT
Since different databases implement this differently, or not at all, I am going to close this. Woody Gilk
09:58 pm Bug Report #2268 (Closed): Kohana_Remote 20x status codes
Fixed by http://github.com/kohana/core/commit/a26b4cb32a691a627b3274907f94bf0465b1f7ea Woody Gilk
09:56 pm Core Revision a26b4cb3: All 2xx HTTP codes are signify success, fixes #2268
Woody Gilk
08:25 pm Feature Request #2140: Configurable DB tables/columns names letter case
You can override the _table_name member to use whichever table name you'd like. John Heathco
08:09 pm Feature Request #2290: SESSION, $_POST, $_GET, $_COOKIE in Profiler
could I take ownership of this request?
Chris Webb
04:07 pm Feature Request #2229 (Closed): Allow to have NULL in first parameter of order_by
Fixed by http://github.com/kohana/database/commit/c56ad72eaec8a0a440a9f290e77eb5b973e35b5d Woody Gilk
04:05 pm Database Revision c56ad72e: Allow sorting without a column name (eg: RAND()), fixes #2229
Woody Gilk
03:49 pm Feature Request #2222 (Closed): A workaround for Session to avoid __PHP_Incomplete_Class !
Fixed by http://github.com/kohana/kohana/commit/3085cb1ab6eff708324ead6ed47c8613cee6eea0 Woody Gilk
03:46 pm Revision a1c8371b: Tracking submodules
Woody Gilk
03:43 pm Bug Report #2243 (Closed): Kohana_Database_Result_Cached constructor throws an error with get_cla...
Fixed by http://github.com/kohana/database/commit/5d16a95b062850d10e9f3d1977bab3fe7b720346 Woody Gilk
03:42 pm Database Revision 5d16a95b: $as_object should be changed to a class name when it is an object, fixes #2243
Woody Gilk
03:40 pm Bug Report #2257 (Closed): Typo in class Kohana_File in method File::mime
Fixed by http://github.com/kohana/core/commit/1cf8081cf3168bfcef71981825684fd55d470278 Woody Gilk
03:38 pm Core Revision 1cf8081c: Typo in File::mime(), fixes #2257
Woody Gilk
04:52 am Feature Request #2140: Configurable DB tables/columns names letter case
I think there is some confusion, this is an ORM "issue" not a problem with the database module. Isaiah DeRose-Wilson

10/30/2009

11:31 pm Bug Report #2244 (Feedback): ORM with method should use LEFT join
Maybe it's better to allow choosing join type?
Instead of
@public function with($target_path)@
use
@ public funct...
Dmitry T.
09:05 pm Feature Request #2140 (Feedback): Configurable DB tables/columns names letter case
I am looking for your answer,
thanks
Andrei Molchanov
09:05 pm Feature Request #2140: Configurable DB tables/columns names letter case
Hi Woody Gilk,
You are right, it would be fine if user would be solely responsible for the tables and columns lett...
Andrei Molchanov
11:56 am Bug Report #2295 (Closed): arr::get() is redundant
As I see it, it's just a subset of arr::path().
Shouldn't it be removed?
Samuel Vogel
08:54 am Bug Report #2280: Error with ORM & Validation when overloading __set() in model
Yes, _set() is called twice. Once by me, to set the values, and then validation calls it again at some point.
Than...
pete webbo
07:52 am Bug Report #2204: Translate validation labels
I reported this issue 2 moths ago, very grad it's accepted now. Yahasana .
03:02 am Feature Request #2138: Handling of 404 (and other client errors)
Yes, @Kohana_HTTP_Exception@ would be an elegant and intuitive improvement.
Mr Anchovy
02:43 am Database Revision 5f1a2952: Use type metadata in list_columns()
Chris Bandy
02:41 am Database Revision dd919f10: Add MySQL types metadata
Chris Bandy
02:37 am Database Revision 1b1b9459: Add SQL types metadata
Chris Bandy
02:35 am Database Revision 03ebab08: Modify list_columns() to emulate SQL-92 Information Schema
*API change* Chris Bandy
02:35 am Database Revision 8a37436b: Modify list_tables() to emulate SQL-92 Information Schema
Requires MySQL >= 5.0.2
*API change*
Chris Bandy
02:35 am Database Revision 87136d89: Revert "Adding standardized list_columns and list_tables methods with optional...
This reverts upstream commit c2ab87fde409ecdf6428c0fcb13401f5fd900db4. Chris Bandy
02:24 am Feature Request #2259 (Closed): Database_Result optimizations
Merged in "Database:d9d99b64":http://github.com/kohana/database/commit/d9d99b64781b2db46530154706e36b32a1dd11f6 Chris Bandy
02:02 am Bug Report #2275: SQL TRUE and FALSE are not SQL-92
Not all databases implement booleans as integers. For example, DB2 recommends storing boolean values in @char(1)@. Ir... Chris Bandy
01:27 am Feature Request #2138: Handling of 404 (and other client errors)
I think the proper way to handle this is to create a new exception, @Kohana_HTTP_Exception@, which contains the HTTP ... Woody Gilk
01:23 am Feature Request #2138 (Assigned): Handling of 404 (and other client errors)
Woody Gilk
01:22 am Feature Request #2140 (Closed): Configurable DB tables/columns names letter case
I think if a user wants to SCREAM their table and column names, it should be up to them. I don't think Kohana should ... Woody Gilk
01:18 am Bug Report #2185 (Closed): Spell wrong in tutorials.helloworld.md
Fixed by http://github.com/kohana/userguide/commit/2f44e2d54cbc442ad16e4073b455da2ed951a701 Woody Gilk
01:17 am Patch #2187 (Assigned): Joining tables in ORM::with
Woody Gilk
01:17 am Bug Report #2204 (Assigned): Translate validation labels
Woody Gilk
01:16 am Feature Request #2232 (Assigned): Get name from route
Woody Gilk
01:16 am Bug Report #2243 (Assigned): Kohana_Database_Result_Cached constructor throws an error with get_c...
Woody Gilk
01:15 am Feature Request #2251: Pass to the next route if controller or method not found
I'm not sure there is a nice way to implement this, but it might be possible with another parameter to @Route@, such ... Woody Gilk
01:14 am Bug Report #2275 (Assigned): SQL TRUE and FALSE are not SQL-92
Returning strings doesn't make sense. Integer values should be returned. Woody Gilk
01:12 am Patch #2263 (Review): Fix for translation of parameters in Kohana_Validate::errors
Woody Gilk
01:12 am Bug Report #2262 (Assigned): $_load_with not applied
Woody Gilk
01:04 am Bug Report #2266 (Assigned): Make region optional in i18n::$lang
This is actually a bug. Not all languages require a region. See http://www.i18nguy.com/unicode/language-identifiers.h... Woody Gilk
01:01 am Bug Report #2288 (Closed): Turkish dotted I problem in utf8
Fixed by http://github.com/kohana/core/commit/613f71689983dbd05a7936dde82210dfe9f7e0b1 Woody Gilk
01:00 am Core Revision 613f7168: Fixing transliteration of the "undotted lower i" and the "dotted upper i" char...
Woody Gilk
01:00 am Bug Report #2288 (Assigned): Turkish dotted I problem in utf8
Woody Gilk
12:54 am Feature Request #1998 (Resolved): Add a using function to the Database Query Builder
This will need to be merged into v3.1.0 before release. Woody Gilk
12:51 am Database Revision ffd090d8: Always wrap JOIN conditions in parentheses
MySQL, Oracle, PostgreSQL, SQLite, and SQL Server all allow it Chris Bandy

10/29/2009

10:14 pm Feature Request #2286 (Feedback): Add support for multiple selected options in form::select
I absolutely *do not* want to see this implemented in KO3, and think it was a horrible decision to implement it in KO... Woody Gilk
10:10 pm Feature Request #1998 (Closed): Add a using function to the Database Query Builder
Woody Gilk
10:09 pm Patch #2294 (Closed): JOIN conditions can use parentheses
Fixed and merged. Woody Gilk
10:08 pm Revision 71e8f581: Tracking submodules
Woody Gilk
10:07 pm Database Revision 14b7d2b0: Merge branch 'master' of git://github.com/cbandy/kohana-database
Woody Gilk
10:00 pm Bug Report #2293 (Closed): Kohana::debug() does not escape array keys
http://github.com/kohana/core/commit/817676841676917372c721ffb13b84b16170bd10 Woody Gilk
09:59 pm Core Revision 81767684: Kohana::debug() should escape array keys the same as values, fixes #2293
Woody Gilk
04:01 pm Userguide Revision 3715311a: Added welcome page image
Woody Gilk
04:00 pm Userguide Revision 70a2d36d: Fixing outdated start.foo links to about.foo
Woody Gilk
04:00 pm Userguide Revision cb9ecd71: Moved upgrading to a Getting Started item
Woody Gilk
03:48 pm Core Revision 260b5329: Updated @package class comments
Woody Gilk
02:43 pm Feature Request #1998: Add a using function to the Database Query Builder
Implemented in http://github.com/cbandy/kohana-database/commit/b89fb715b7dd7bf08c0b85ce69427ba029ef5e9a
The above ...
Chris Bandy
02:40 pm Patch #2294 (Closed): JOIN conditions can use parentheses
From my research, it is always valid to wrap JOIN conditions in parentheses. MySQL[1], Oracle, PostgreSQL[1], "SQLite... Chris Bandy
02:19 pm Bug Report #2293 (Closed): Kohana::debug() does not escape array keys
@Kohana::debug()@ escapes the values of arrays, but does no escaping to array keys. This poses a security risk and al... Woody Gilk
12:48 pm Bug Report #2280: Error with ORM & Validation when overloading __set() in model
Sounds like @__set()@ is being called more than once. The first time @'2009-10-29 07:42:27-05:00'@ is converted to @1... Chris Bandy
12:46 pm Feature Request #2291 (Closed): Setting default session driver
Duplicate of #2190 Woody Gilk
12:45 pm Feature Request #2292 (Closed): Bootstraps for Modules (Code included)
This is already done using @init.php@. Woody Gilk
12:30 pm Userguide Revision 3936db27: Merge branch 'master' of git://github.com/cyberval/kohana-userguide-fr
Woody Gilk
09:10 am Feature Request #2291: Setting default session driver
See #2180 and #2190 Dmitry T.
05:26 am Database Bug Report #2188: Database PDO dosn't support last inserted id in PGSQL Driver
Database_Query needed a method to access this parameter as well. Chris Bandy
03:38 am Feature Request #2292: Bootstraps for Modules (Code included)
the bootstrap files for Modules is init.php. DRY
However, I think the loading init.php for each modules should be muc...
Yahasana .
02:57 am Feature Request #2292: Bootstraps for Modules (Code included)
Oops, did not upload the file. Franklin Davenport
02:55 am Feature Request #2292 (Closed): Bootstraps for Modules (Code included)
I wanted something so that each module could have a bootstrap. This can be used by each module to set its own routes ... Franklin Davenport

10/28/2009

11:05 pm Feature Request #2291 (Closed): Setting default session driver
In Kohana 2.3.x I could do:... Cole Frankel
10:30 pm Feature Request #2290 (Assigned): SESSION, $_POST, $_GET, $_COOKIE in Profiler
In Kohana 2.3 the profiler included a dump of $_SESSION, $_POST, $_GET, $_COOKIE variables.
I think it'd be nice t...
Cole Frankel
04:15 pm Userguide Revision ce71780c: Proper escaping of code blocks, thanks s1kx
Woody Gilk
04:15 pm Userguide Revision 4ff60be8: Updated template for the correct XML language
Woody Gilk
04:15 pm Userguide Revision a316dd3e: Switched package name to "Userguide"
Woody Gilk
04:15 pm Userguide Revision f140655e: - Renamed the "start.foo" to "about.foo"
- Updated menu.md with changes
- Deleted unnecessary menu items that would never have a real purpose
- Updated the wa...
Woody Gilk
04:15 pm Userguide Revision f8f20a5b: Added contributor notice about forks to README
Woody Gilk
04:15 pm Userguide Revision b6f357f4: More small cleanups.
Geert De Deckere
04:15 pm Userguide Revision 5d2f2134: Fixing a conflict with userguide media and the media controller, fixes #2141
Woody Gilk
02:32 pm Bug Report #2288 (Closed): Turkish dotted I problem in utf8
In system/utf8/transliterate_to_ascii.php
'ı' => 'i' should be added to $UTF8_LOWER_ACCENTS array and
'İ' => 'I' ...
Caner Ag
12:15 pm Database Bug Report #2188: Database PDO dosn't support last inserted id in PGSQL Driver
Make retrieval of the last inserted id optional by passing a column name. The auto-increment/sequenced value returned... Chris Bandy
08:30 am Bug Report #2287 (Closed): deflate flag shouldn't appear in Request::accept_lang()
Here is the $_SERVER['HTTP_ACCEPT_LANGUAGE'] value (firefox 3.5.4)... Yahasana .
04:04 am Feature Request #2286 (Closed): Add support for multiple selected options in form::select
In KO3, the third argument, $selected, can be only string. It should accept string or array same as form::dropdown in... Worawit Wang
12:29 am Bug Report #2285 (Closed): Many ORM method calls fail when used in overriding magic set method
The 'loaded' method of ORM will now return FALSE if the object has not been initialized by doing a check on the _obje... John Heathco
12:28 am ORM Revision 2a6b9e97: Fixing #2285
jheathco -
12:27 am Bug Report #2285 (Closed): Many ORM method calls fail when used in overriding magic set method
When calling ORM methods from within the magic set method, many ORM methods will fail (such as the 'loaded' method). ... John Heathco
12:01 am Revision 5a018069: Tracking submodules
Woody Gilk
« Previous
Next »
 

Also available in: Atom