Activity

From 06/07/2010 to 07/06/2010

07/06/2010

07:09 pm Userguide Revision 3caad7d3: Merge branch 'master' of http://github.com/kohana/userguide
Jonas De Smet
07:07 pm Userguide Revision 664d2ece: Translated the "security"-section to dutch
Jonas De Smet
07:05 pm Userguide Revision c305e2dd: Clean up + fixed some typos
Jonas De Smet
06:49 pm ORM Feature Request #2848 (Feedback): list_columns() caching
Woody, what do you think about moving this to the database layer versus ORM? John Heathco
06:16 pm Feature Request #3038 (Closed): ORM::with() should allow to select specific columns
This isn't something I believe is necessary - you can construct a manual query in your own method call if you wish to... John Heathco
05:22 pm ORM Bug Report #2982 (Feedback): Can't read or update additional data in pivot tables using Through a...
Jose,
You can create a model for the pivot table if you wish to access this data. Is this what you're referring t...
John Heathco
01:32 pm Revision feb45b7c: Merge branch 'master' of github.com:kohana/kohana
Woody Gilk
01:31 pm Revision a3c42519: Updated submodules
Woody Gilk
12:45 pm Userguide Revision fc1c14a1: Merge branch 'master' of git://github.com/glamorous/userguide
Woody Gilk
11:54 am Cache Bug Report #3049 (Assigned): delete_all() - Error with 'file' driver
When i try test example which goes with module (OS Windows XP SP3, AMP), i see error
*Kohana_Cache_Exception [ ...
Viktor Buyakov
09:33 am Codebench Revision b4d5d7d9: Switching to HTML5
Geert De Deckere
09:33 am Cache Revision b4d5d7d9: Switching to HTML5
Geert De Deckere

07/05/2010

10:59 pm Bug Report #3033 (Closed): ORM: find() throws an error of unknown column when sorting by joined t...
Kiall Mac Innes
10:30 pm Userguide Revision 436041ed: Translated "basic usage" to dutch
Jonas De Smet
10:26 pm Userguide Revision e9b496e6: Fixed some typos
Jonas De Smet
09:32 pm Revision 17fb5b0e: Fixed typo on SUPPRESS_REQUEST check for unittest module.
Kiall Mac Innes
07:57 pm Auth Revision c2c62e2d: Follow-up to #3029, 1bab01e01f.
Reduce the try block scope and return rather than break. Chris Bandy
07:36 pm Core Revision d843bc35: Typo
Geert De Deckere
04:41 pm Bug Report #3045: Userguide unusable if class not found
Surely the "easiest" way to avoid this error would be to add a second autoloader which just declares stubs for classe... Matt Button
03:27 pm Bug Report #3048 (Closed): MSSQL SET NAMES error
I found error using pdo (mssql).
PDOException [ HY000 ]: SQLSTATE[HY000]: General error: 195 General SQL Server er...
slik jay
11:32 am Bug Report #3039: Native session does not expire if session cookies are not being used
The session timeout behaviour in Kohana relies on the expiration of the session cookie. If cookie-based sessions are ... Jonathan Abourbih
11:26 am Bug Report #3045: Userguide unusable if class not found
This is a tricky issue. The error occurs as a fatal error when the file is included through the auto-loader (and sub... Kyle Treubig
02:47 am Userguide Revision 0ccc45b2: Missing some string words to translate in the head of using.messages.md
icy leaf
02:40 am Userguide Revision 427e4627: Translation completed for using.views.md
icy leaf
01:53 am Userguide Revision 652921ea: Translation completed for using.messages.md
icy leaf
01:39 am Userguide Revision 765504c4: Sync
icy leaf
01:29 am Cache Bug Report #3047: Cache error on __construct() - Linux machine
The APPATH.'cache/.kohana_cache' directory also has a .gitignore file. FYI Lysender Dc Eros
01:25 am Cache Bug Report #3047 (New): Cache error on __construct() - Linux machine
My code is working fine Windows (in the office) but has errors on my Linux machine at home. Using KO 3.0.6.2 Kohana_C... Lysender Dc Eros

07/04/2010

10:20 pm UnitTest Revision 35c5f61e: Fixing merge conflicts
Matt Button
10:12 pm Bug Report #3039: Native session does not expire if session cookies are not being used
Cannot reproduce (3.0.6.2)... Ivan Kurnosov
09:54 pm Feature Request #3017: Add Request::url() function
I need to write a test for it. Jeremy Bush
09:53 pm Feature Request #3017: Add Request::url() function
Why was it not closed? Ivan Kurnosov
09:43 pm Feature Request #3041: Add Arr:in() method, return value from array of allowed values
I think it is too specific to be a part of core. Ivan Kurnosov
03:43 pm Feature Request #3024: A method to convert Database_Result object to an array of arrays
Woody Gilk wrote:
> Then maybe you shouldn't be using ORM.
Or maybe you should extend ORM?
Dmitry T.
03:40 pm Bug Report #3015: Reverse routing should not include the default parameters
Woody Gilk wrote:
> > i proposed do not insert chunk even if it was specified explicitly, but equals to default one:...
Dmitry T.
03:19 pm Revision 9aacab3c: Updated oauth with @since
Woody Gilk
03:18 pm OAuth Revision 63e128aa: Added @since to all classes
Woody Gilk
03:13 pm Revision 3a03527b: Added oauth as an official sub-module
Woody Gilk
03:12 pm OAuth Revision 14494e08: Updated guide files for github, oauth.usage is currently a stub.
Woody Gilk
02:25 pm OAuth Revision db231eb5: Started creating user guide pages
Woody Gilk
02:14 pm Userguide Revision 43c362b0: Invalid reference to classes/model in infographic removed
Woody Gilk
01:56 pm Userguide Revision b871b9e1: Added support for PHPDoc @param tag parsing with $param name, fixes #3028
Woody Gilk
01:56 pm Patch #3028 (Closed): Kodoc: @param and parameter names
Fixed by http://github.com/kohana/userguide/commit/b871b9e1804cc30ea44ab8e43482b78a4a67c34b Woody Gilk
01:54 pm Userguide Revision df003456: Add @link PHPDoc tag parsing, fixes #3026
Woody Gilk
01:54 pm Patch #3026 (Closed): Kodoc: Support @link
Fixed by http://github.com/kohana/userguide/commit/df0034568c3043e7b0407410e0b330767659f210 Woody Gilk
01:42 pm Patch #3026 (Assigned): Kodoc: Support @link
Good point, I didn't think of documenting non-Kohana classes. Woody Gilk
01:39 pm Patch #3026: Kodoc: Support @link
When a class documented with Kodoc extends a class documented with PHPdoc the inherited docs appear in the API browse... Chris Bandy
01:38 pm OAuth Revision b2e2dddd: We no longer need init.php, the demos have been removed
Woody Gilk
01:35 pm OAuth Revision 81b069f3: Making OAuth classes extensible, step four, adding empty classes
Woody Gilk
01:33 pm OAuth Revision f168eac3: Fixed issue with OAuth_Provider_Google that got lost when cleaning up providers
Woody Gilk
01:32 pm OAuth Revision f0f5950a: Fixing an error with the class renaming, incorrect class referenced by OAuth_P...
Woody Gilk
01:09 pm OAuth Revision c0bcb795: Making OAuth classes extensible, step two, renaming classes
Woody Gilk
01:09 pm OAuth Revision 5494c744: Making OAuth classes extensible, step three, renaming classes
Woody Gilk
01:08 pm OAuth Revision 18a51b87: Making OAuth classes extensible, step one, prefix classes
Woody Gilk
12:55 pm OAuth Revision 5b49c016: Removed demo controllers, they will be imported into the user guide for the mo...
Woody Gilk
12:52 pm OAuth Revision 206c2003: Cleaning up OAuth providers:
- Removed OAuth_Provider::$params
- Removed OAuth_Provider::$urls and added url_request_token, url_authorize, and url...
Woody Gilk
12:28 pm Bug Report #3015: Reverse routing should not include the default parameters
> i proposed do not insert chunk even if it was specified explicitly, but equals to default one:
No, this ticket d...
Woody Gilk
12:18 pm Bug Report #3015: Reverse routing should not include the default parameters
does this ticket include my http://dev.kohanaframework.org/issues/3046 completely?
i proposed do not insert chunk ...
Ivan Kurnosov
12:10 pm Revision 250536d7: Updated submodules
Woody Gilk
12:08 pm Revision e7c53474: Added unit test module and updated bootstrap.php with requirements for testing
Woody Gilk
11:25 am Feature Request #3046 (Closed): Default chunks in routes
This will be handled properly in v3.1.x. Woody Gilk
09:57 am Feature Request #3046: Default chunks in routes
> If I explicitly set a route part, I want the class to respect that.
hm, did not you miss that i've specified expli...
Ivan Kurnosov
09:50 am Feature Request #3046: Default chunks in routes
Hi.
I agree with you on the first case, but two and three seem totally unintuitive to me.
If I explicitly set a route...
Friedemann Altrock
06:16 am Feature Request #3046 (Closed): Default chunks in routes
Hello there.
What about getting rid of default parts in routes, like Zend doing this.
Let I clarify this in sam...
Ivan Kurnosov

07/03/2010

11:17 pm Feature Request #3024 (Closed): A method to convert Database_Result object to an array of arrays
Then maybe you shouldn't be using ORM. Woody Gilk
08:09 pm Feature Request #3024 (Feedback): A method to convert Database_Result object to an array of arrays
I'm sorry I keep re-opening this issue, but what you're suggesting is simply impossible when working with the ORM, as... Human Internals
07:40 pm Core Revision 66e0dd9c: Typo
Geert De Deckere
07:29 pm UnitTest Revision 6faf4823: Merge branch 'master' of [email protected]:kohana/unittest
Geert De Deckere
07:27 pm UnitTest Revision 260c997d: Fixed action URLs for the run and report forms
Geert De Deckere
03:18 pm Feature Request #3043 (Closed): Make UTF8 class extendable
Fixed by http://github.com/kohana/core/commit/e905f9512ee2e5481aab4b9a294debe2f6e9a5a5 Geert De Deckere
03:17 pm Core Revision e905f951: Fixed #3043. UTF8 class is now extendable.
Geert De Deckere
01:35 pm Auth Bug Report #3029 (Closed): Possible conditional race in Auth module
Fixed by http://github.com/kohana/auth/commit/1bab01e01f12a355bc75e985e48bb01adda96ba5
Still not entirely happy wi...
Woody Gilk
01:35 pm Auth Revision 1bab01e0: Use Database to determine if auth tokens are duplicates, fixes #3029
Woody Gilk
01:22 pm Auth Bug Report #3029 (Feedback): Possible conditional race in Auth module
1. *API will not be changed*!! All interfaces will stay the same!
2. Why to do fast select, if we can to not do it at...
Ivan Kurnosov
01:21 pm Feature Request #3034 (Closed): Request::redirect() $code parameter to be 303 as default (instead...
Using @302@ is appropriate in most situations, and it can be set per call when it needs to be different. Woody Gilk
01:19 pm Auth Bug Report #3029 (Closed): Possible conditional race in Auth module
The current implementation is fine, there is no reason to change the API for this. @SELECT@ queries are fast, and the... Woody Gilk
01:17 pm Auth Bug Report #3030 (Assigned): Consistency in logins count autoincrement
I agree, it prevents race conditions. Woody Gilk
01:16 pm ORM Bug Report #3031 (Assigned): Expires field in tokens table is not covered by index
Woody Gilk
01:14 pm Patch #3026 (Feedback): Kodoc: Support @link
I'm not sure we need this, since Kodoc already use Markdown for parsing. Originally, it supported @link, but I remove... Woody Gilk
01:12 pm Feature Request #3024 (Closed): A method to convert Database_Result object to an array of arrays
You can already control how the results are returned by setting the @Database_Query::$as_object = FALSE@. Woody Gilk
01:00 pm Bug Report #3037 (Closed): Incorrect reference in Request's new shortcut for url
Fixed by http://github.com/kohana/core/commit/85abce49922bcfa4471643baaffcb299151561a7 Woody Gilk
12:59 pm Bug Report #3044 (Rejected): Route::url() should not be a static method
I don't see what the issue here is... you add a route, then run some tests to see if it works.
The point of @Rout...
Woody Gilk
12:53 pm Bug Report #3016: Exceptions aren't getting HTML encoded
Exceptions escaped in view, fixed by http://github.com/kohana/core/commit/769b41694e59b3c52055accd5fb22d5f349f4bf4 an... Woody Gilk
12:52 pm Core Revision 769b4169: Follow up to 9cbe795ba0adeb20b3dc0ffd063a86325677120f, do not escape the excep...
Woody Gilk
12:50 pm Core Revision 9cbe795b: Reapply b7aa13dac330add85883692b2d063882169f1b0e
Woody Gilk
12:48 pm Core Revision 85abce49: Follow up to 647e09b435073c360c9baebc3a8e613e5585c85b, use the proper scope
Woody Gilk

07/02/2010

01:08 pm Bug Report #3045: Userguide unusable if class not found
I'll try to take a look at it over the weekend and work on a patch. Kyle Treubig
01:00 pm Bug Report #2975: Request instance gets lost when there is no matching route for the URI
> So what is the point in setting request status to 404 here if the request object is not created and i cannot read t... Woody Gilk
12:59 pm Bug Report #3045 (Feedback): Userguide unusable if class not found
Patches welcome! Woody Gilk
11:14 am Bug Report #3045 (Closed): Userguide unusable if class not found
If any class in one's Kohana setup extends a class that does not exist in the current setup, the userguide API browse... Kyle Treubig
11:11 am Bug Report #2975: Request instance gets lost when there is no matching route for the URI
May be a haven't explained my problem clearly.
Consider an example:
Let's imagine that an URL is requested which ...
Ivan Skryabin

07/01/2010

07:31 pm Cache Revision d10a8e4e: Bench_Transliterate
Geert De Deckere
07:31 pm Codebench Revision d10a8e4e: Bench_Transliterate
Geert De Deckere
07:19 pm Bug Report #3044: Route::url() should not be a static method
If you can't properly unit test something, the code is most likely written improperly. The unit tests define your api... Jeremy Bush
06:09 pm Bug Report #3044: Route::url() should not be a static method
Dmitry T. wrote:
> Ease of testing at the price of usability? Hm... I disagree.
> I thought that this function was ma...
Matt Button
05:37 pm Bug Report #3044: Route::url() should not be a static method
Ease of testing at the price of usability? Hm... I disagree.
I thought that this function was made as a shortcut, so...
Dmitry T.
05:04 pm Bug Report #3044: Route::url() should not be a static method
Ack, I didn't check the title before I submitted, it should be "Route::url() should not be a static method" Matt Button
05:03 pm Bug Report #3044 (Rejected): Route::url() should not be a static method
Related to issue #2979 and http://github.com/kohana/core/commit/22a9c6bbf1beaec691fb4757267e3325b292638e
Route::ur...
Matt Button
04:53 pm Feature Request #3034: Request::redirect() $code parameter to be 303 as default (instead of 302)
As I said, I just wanted to know what others think about it, and your declamations speak to me, so we can safely clos... N Komay
02:51 pm Userguide Revision 0ad6304b: Added note about git tags
Geert De Deckere
02:46 pm Bug Report #3042 (Needs Test): UTF8::ucwords() not preserving capitals within words
Jeremy Bush
02:07 pm Feature Request #3034: Request::redirect() $code parameter to be 303 as default (instead of 302)
There's some additional information on the subject on wikipedia "Post/Redirect/Get":http://en.wikipedia.org/wiki/Post... Mathew Davies
02:07 pm Feature Request #3041: Add Arr:in() method, return value from array of allowed values
Ups...... Miodrag Tokić
12:56 pm Bug Report #3042 (Closed): UTF8::ucwords() not preserving capitals within words
Fixed: http://github.com/kohana/core/commit/bf37e0a255b89df5397e15caa20eb283727e773c Geert De Deckere
12:55 pm Core Revision bf37e0a2: Fixed #3042
Geert De Deckere
10:01 am Feature Request #3043 (Closed): Make UTF8 class extendable
There are several problems with the UTF8 class (see http://forum.kohanaframework.org/comments.php?DiscussionID=6113) ... Arno Nöbl
09:50 am Bug Report #3042 (Closed): UTF8::ucwords() not preserving capitals within words
If mb functions are available, UTF8::ucwords() will use mb_convert_case(), which does not preserve capital letters wi... Arno Nöbl
07:59 am Feature Request #3041 (Closed): Add Arr:in() method, return value from array of allowed values
Similar to Arr::get(), but return only if value is within range of values... Miodrag Tokić
01:20 am Bug Report #3040 (Closed): Profiler showing up under [Unknown] in the userguide module
It is a PHP bug in Reflection, nothing we can do about it. Some versions of PHP show it, some don't. Woody Gilk

06/30/2010

09:35 pm Bug Report #3037: Incorrect reference in Request's new shortcut for url
Ha, incorrect spelling of inNcorrect! Joel Pittet
09:34 pm Userguide Revision ee29310b: Translated debugging section to dutch
Jonas De Smet
09:30 pm Bug Report #3040 (Closed): Profiler showing up under [Unknown] in the userguide module
Attached screenshot should say it all. Not sure why it is happening really... Torleif Berger
09:18 pm Userguide Revision 2a534001: Cleaned up the debugging files
The debugging files had some old markup code. Changed the code blocks to real markdown code. Jonas De Smet
08:32 pm Bug Report #3039 (Feedback): Native session does not expire if session cookies are not being used
It appears that if Session_Native is being used for session management, setting the session lifetime has no effect un... Jonathan Abourbih
08:12 pm Feature Request #3038 (Closed): ORM::with() should allow to select specific columns
The with() method on the ORM should allow to set specific columns to be selected from the joined table.
For exampl...
Human Internals
06:57 pm Bug Report #3037: Incorrect reference in Request's new shortcut for url
Here is a patch
http://github.com/joelpittet/core/commit/76c02fa9c5c6a3f84b1856115bcec4c43aeee537
Joel Pittet
06:55 pm Bug Report #3037 (Closed): Incorrect reference in Request's new shortcut for url
Request is calling $this->request in the new url method of the Request Class. Should be $this-> Joel Pittet
03:26 pm Feature Request #2665: Add request type variable to the Request class and delete $is_ajax, it wil...
Internal and External requests are already detected in 3.1 - Regarding type, type is ambiguous. I never really liked ... Sam de Freyssinet
02:54 pm Bug Report #2990 (Closed): testModules test in CoreTest.php causes modules to be reset.
Woody Gilk
02:53 pm Feature Request #2665 (Assigned): Add request type variable to the Request class and delete $is_a...
Woody Gilk
02:53 pm Bug Report #3005 (Closed): Tests failed on windows
Fixed by http://github.com/kohana/core/commit/944908f9911a8341c3e1b41dc358448191e2c24b Woody Gilk
02:52 pm Bug Report #3007 (Closed): Test_dir not cleaned after tests performed
Fixed by http://github.com/kohana/core/commit/944908f9911a8341c3e1b41dc358448191e2c24b Woody Gilk
02:22 pm Feature Request #3036 (Closed): Kohana_Log_File::write() should be made more flexible so the app ...
Added three parameters to Kohana_Log_File::write():
* $prepend: set a string to prepend it to the log file, `TRUE`...
Fred Wu
02:20 pm Feature Request #3035 (Closed): Timezone and timestamp format (used in Kohana_Log) should be avai...
Timezone and timestamp format right now are hard coded in Kohana_Log. Let's put 'em into Kohana_Date instead, so they... Fred Wu
01:37 pm Bug Report #2739 (Closed): image property of rss channel
Fixed by http://github.com/kohana/core/commit/944908f9911a8341c3e1b41dc358448191e2c24b Woody Gilk
01:31 pm Bug Report #3007: Test_dir not cleaned after tests performed
was successfully merged. ticket may be closed Ivan Kurnosov
01:31 pm Bug Report #2739: image property of rss channel
was successfully merged. ticket may be closed Ivan Kurnosov
01:07 pm Bug Report #3005: Tests failed on windows
so, changes has been merged. issue ready to be closed Ivan Kurnosov
12:02 pm Feature Request #3034: Request::redirect() $code parameter to be 303 as default (instead of 302)
I'm not sure about making it default, esp. since you may specify the code when using @Request::redirect()@...
Othe...
Korney Czukowski
10:44 am Feature Request #3034 (Closed): Request::redirect() $code parameter to be 303 as default (instead...
I just want to know how the community feels about changing the default value of $code param in Request::redirect() fr... N Komay
09:42 am Feature Request #2665: Add request type variable to the Request class and delete $is_ajax, it wil...
I think Request::$is_internal is meaningless, ... Yahasana .
08:39 am Feature Request #2665: Add request type variable to the Request class and delete $is_ajax, it wil...
:D
That will do!
N Komay
06:37 am Userguide Feature Request #2959: Use jQuery.Syntax for syntax highlighting
Alternatively, there's Codemirror, that doesn't use any framework at all:
http://marijn.haverbeke.nl/codemirror/contr...
Korney Czukowski
01:36 am Bug Report #2739: image property of rss channel
@Woody: here is the test case for new image property: http://github.com/zerkms/kohana-core/commit/c3d6b97a83b02c9d1d7... Ivan Kurnosov
12:02 am Userguide Revision b3665e75: Translation for upgrade-page (dutch)
The upgrading page was translated to dutch but the english version still needs some work such as a decent example in ... Jonas De Smet

06/29/2010

11:29 pm Bug Report #2990: testModules test in CoreTest.php causes modules to be reset.
This has been merged with blessed so can be closed Matt Button
05:42 pm Auth Bug Report #3029: Possible conditional race in Auth module
It's a good change based only on the fact that it eliminates a query. It's also probably more correct to utilize data... Rick Jolly
01:12 pm Bug Report #3033: ORM: find() throws an error of unknown column when sorting by joined table column
I think there is something wrong somewhere else in my own code...
Solution for this was that I have not attached t...
N Komay
12:54 pm Auth Bug Report #3029: Possible conditional race in Auth module
Woody Gilk wrote:
> I just don't see this happening.
don't you agree that anyway my code is more correct? it is s...
Ivan Kurnosov
12:48 pm Bug Report #3032 (Closed): Session's constructor shouldn't be protected
Fixed by http://github.com/kohana/core/commit/6bd1b3ca2f6f37e1e53b6ea5ebb794753c09e1ac Woody Gilk
12:48 pm Core Revision 9b82d467: Merge remote branch 'matt/master'
Woody Gilk
12:45 pm Auth Bug Report #3029: Possible conditional race in Auth module
> if create_token will generate the same token twice from two simultaneous requests - then one of them will be failed... Woody Gilk
12:01 pm Bug Report #3033: ORM: find() throws an error of unknown column when sorting by joined table column
Please wait... I have found that the problem may be somewhere else... ehh... N Komay
11:45 am Bug Report #3033 (Closed): ORM: find() throws an error of unknown column when sorting by joined t...
To reproduce it create a model that is related to other model by 1-to-1 relationship. Use *$_load_with* to setup auto... N Komay
11:24 am Bug Report #3032: Session's constructor shouldn't be protected
Fix is at: http://github.com/BRMatt/core/commit/6bd1b3ca2f6f37e1e53b6ea5ebb794753c09e1ac Matt Button
11:24 am Core Revision 6bd1b3ca: Modifying Session to use public constructor. Class is already abstract,
this makes it easier to test.
Fixes #3032
Matt Button
11:23 am Bug Report #3032 (Closed): Session's constructor shouldn't be protected
The class is already abstract, having a protected constructor just makes it harder to test.
I've implemented this in...
Matt Button
05:32 am Auth Bug Report #3029: Possible conditional race in Auth module
@Ivan: i'm carrying not of duplication but of "Race Condition" (sorry, i had misspelled the term in the ticket descri... Ivan Kurnosov
05:25 am Auth Bug Report #3029: Possible conditional race in Auth module
Whats wrong with current version? It already has check for duplication Ivan Brotkin
05:19 am Auth Bug Report #3030: Consistency in logins count autoincrement
@Ivan: if two requests will be performed simultaneously, then the field in database will be updated twice to the same... Ivan Kurnosov
05:12 am Auth Bug Report #3030: Consistency in logins count autoincrement
What is the advantage? Ivan Brotkin
04:14 am ORM Bug Report #3031 (Closed): Expires field in tokens table is not covered by index
... Ivan Kurnosov
04:08 am Auth Bug Report #3030 (Closed): Consistency in logins count autoincrement
... Ivan Kurnosov
03:52 am Auth Bug Report #3029 (Closed): Possible conditional race in Auth module
The token generation process is affected of conditional race.... Ivan Kurnosov
12:09 am Patch #3028: Kodoc: @param and parameter names
Detects the parameter name and removes it from the parameter description. @@param@ tags must still be in the same ord... Chris Bandy
12:06 am Patch #3026: Kodoc: Support @link
This patch supports the single URL + optional description format. Chris Bandy

06/28/2010

11:39 pm Patch #3028 (Closed): Kodoc: @param and parameter names
Kodoc can support the @@param@ format which includes the parameter name.
http://manual.phpdoc.org/HTMLSmartyConver...
Chris Bandy
11:39 pm Userguide Bug Report #3027 (Closed): Kodoc: @uses and method names
Kodoc does not parse method names in @@uses@ when they have parentheses, e.g. @"@uses class::method()"@.
http://ma...
Chris Bandy
11:39 pm Patch #3026 (Closed): Kodoc: Support @link
Kodoc can support @@link@ to create hyperlinks to external resources.
http://manual.phpdoc.org/HTMLSmartyConverter...
Chris Bandy
10:05 pm Bug Report #3020: It should be encouraged to change the Cookie salter
Any chance you'll be setting Cookie::$salt to DOCUMENT_ROOT in the bootstrap with a comment telling people to change ... Human Internals
08:57 pm UnitTest Revision 0aad4c4a: Fixing problem where SERVER vars don't exist in cli
Matt Button
08:06 pm Bug Report #3016: Exceptions aren't getting HTML encoded
Great, thank you.
I do agree with Zeelot's note on the commit (http://github.com/kohana/core/commit/fee3b8c002ff79...
Human Internals
07:57 pm Bug Report #2780: Database Table Prefixes aren't correctly handled when joining
Are you sure its the right file/line/link? I think that's the code that was always there, and not the fixed one.
T...
Human Internals
07:51 pm Feature Request #3024 (Feedback): A method to convert Database_Result object to an array of arrays
I'm sorry if I misunderstood something or misused your code, but cached()->as_array() does not return an array of arr... Human Internals
06:49 pm Bug Report #3020: It should be encouraged to change the Cookie salter
I wouldn't worry too much about salts becoming invalid, it'll just require people to login again, I don't think anyon... Human Internals
06:33 pm Bug Report #2949 (Closed): PHPUnit fails to restore $_SERVER
There seems to be some sort of bug in phpunit, until I find out what it is I've changed setEnvironment to backup supe... Matt Button
06:30 pm UnitTest Revision 55590745: It appears phpunit does not backup superglobals automatically, this is a tempo...
Matt Button
06:17 pm UnitTest Revision b5827f23: Force absolute url for web ui forms
Matt Button
04:51 pm Bug Report #2946 (Review): Whitelist not set - O/S Windows
Added fix in http://github.com/kohana/unittest/commit/d44c455a557c66591865e1fa6a448faed54870a9
Please can you confir...
Matt Button
04:51 pm UnitTest Revision d44c455a: Fix win support #2946
Matt Button
03:57 pm Feature Request #2672: Add support for request caching
You may be right, I saw your changes in the 3.1 branch, and now the request and response are 2 different things, the ... Claudiu Andrei -
03:50 pm Feature Request #2665: Add request type variable to the Request class and delete $is_ajax, it wil...
I think that Sam added this in the 3.1 official branch. Is the opposite i think is called $external :D. Claudiu Andrei -
03:32 pm Feature Request #2665: Add request type variable to the Request class and delete $is_ajax, it wil...
Hi there.
The status of this feature request is still "new" after 4 months, so I refresh that topic, as the $is_inte...
N Komay
02:23 pm Core Revision 643281df: Updated comments for Form::select to reflect changes in 23acd239ff1e125c5d3939...
Woody Gilk
02:20 pm Feature Request #2286 (Needs Test): Add support for multiple selected options in form::select
Fixed by http://github.com/kohana/core/commit/23acd239ff1e125c5d393946f7ab44db30be64c3
Comments updated in http://gi...
Woody Gilk
02:20 pm Core Revision 23acd239: Added support for "select multiple" form elements, fixes #2286. I hate my life.
Woody Gilk
02:19 pm Feature Request #2286 (Assigned): Add support for multiple selected options in form::select
Woody Gilk
02:09 pm Bug Report #2968 (Closed): $this->response isn't defined in initial ReflectionException in 3.1
Woody Gilk
02:09 pm Bug Report #3020: It should be encouraged to change the Cookie salter
Changing the @Cookie::salt@ to add @DOCUMENT_ROOT@ to the salting method will have to be done in v3.1.0 as it would c... Woody Gilk
02:07 pm Core Revision 647e09b4: Added Request::url, similar to Route::url, fixes #3017
Woody Gilk
02:06 pm Feature Request #3017 (Needs Test): Add Request::url() function
Fixed by http://github.com/kohana/core/commit/647e09b435073c360c9baebc3a8e613e5585c85b Woody Gilk
02:03 pm Core Revision fee3b8c0: Follow up to 6947f29fc1a1e7069332d23fc38a2c76aaa48699, escape the entire excep...
Woody Gilk
02:03 pm Bug Report #3016 (Needs Test): Exceptions aren't getting HTML encoded
Fixed by http://github.com/kohana/core/commit/fee3b8c002ff794b48f7384a581f6b3d4757208a Woody Gilk
02:01 pm Bug Report #3016 (Assigned): Exceptions aren't getting HTML encoded
Woody Gilk
02:00 pm Bug Report #3020 (Assigned): It should be encouraged to change the Cookie salter
> As far as I can see, its not documented and its not mentioned anywhere that you should change it.
It is quite cl...
Woody Gilk
01:55 pm Bug Report #2780: Database Table Prefixes aren't correctly handled when joining
Yes, I am sure. The logic has been slightly altered, but the fix is there, http://github.com/kohana/database/blob/mas... Woody Gilk
01:50 pm Feature Request #3024 (Closed): A method to convert Database_Result object to an array of arrays
You can already do this with:
$result = $result->cached()->as_array();
This was done in #2297.
Woody Gilk
01:45 pm Feature Request #3025: Merge Kohana_Cli and Request
I don't think they should be combined, as CLI allows you to get parameters from arguments in an agnostic way. But I d... Woody Gilk
01:22 pm Bug Report #3018 (Closed): The Validate class should have a method to simply allow a column to "p...
Your opinion has been taken into consideration. Woody Gilk
12:46 pm Feature Request #3024: A method to convert Database_Result object to an array of arrays
Maybe I should've made it clearer that I'm talking about cases where Database_Result objects has _as_object property ... Human Internals
11:01 am Feature Request #3025 (Closed): Merge Kohana_Cli and Request
I think that Request and the Kohana_Cli class should be merged. This would be on the condition that a new Request_Cli... Sam de Freyssinet
10:56 am Feature Request #2672: Add support for request caching
There is an implementation of this within the "Vitesse":http://github.com/samsoir/vitesse module, albeit without the ... Sam de Freyssinet
09:56 am Feature Request #3024: A method to convert Database_Result object to an array of arrays
Database already has such function called @as_array()@. It returns exactly what you need - the array of arrays. Or yo... Dmitry T.
09:52 am Bug Report #3018 (Feedback): The Validate class should have a method to simply allow a column to ...
I know I can. as I said in the description, the two choices that I currently have is either adding a dummy rule or se... Human Internals
09:39 am Feature Request #3024 (Closed): A method to convert Database_Result object to an array of arrays
I want to propose a method on the Database_Result class that'll allow to get an array of rows, where each row is an a... Human Internals
08:33 am Cache Bug Report #3021 (Assigned): Problems with the driver Kohana_Cache_File - _resolve_directory()
Sam de Freyssinet
08:12 am Bug Report #2780: Database Table Prefixes aren't correctly handled when joining
Are you sure? I'm on 3.0.6.2, my quote_table method at modules/database/classes/kohana/database.php looks like:
<pre...
Human Internals
08:11 am Cache Bug Report #3013: Move default driver to config
> It is possible to configure the Database entirely without config files
I think this is some kind of special case...
Dmitry T.
07:15 am Bug Report #3020: It should be encouraged to change the Cookie salter
About hash lengths:
May be just use first delimiter (~) occurence? Hash consists of alnum symbols only...
Ivan Brotkin
04:42 am ORM Revision 324991c1: ORM should respect Database::$default, fixes #3023
Woody Gilk
04:41 am Bug Report #3023 (Closed): ORM does not respect Database::$default
Fixed by http://github.com/kohana/orm/commit/324991c1904a4b6b4a8b2020fb7a7d17f368ba80 Woody Gilk
04:39 am Bug Report #3023 (Closed): ORM does not respect Database::$default
The change made in #2849 was not carried over to @ORM::$_db@, which still uses "default" as the default database name. Woody Gilk
03:27 am Bug Report #3018 (Closed): The Validate class should have a method to simply allow a column to "p...
Woody Gilk
03:27 am Bug Report #3018: The Validate class should have a method to simply allow a column to "pass thru"
You could always use @is_string@ or something like that. Woody Gilk
03:24 am Bug Report #2780: Database Table Prefixes aren't correctly handled when joining
It was part of v3.0.5, the change is already there. Woody Gilk
03:23 am Bug Report #3022 (Closed): Queries do not respect Database::$default
Fixed by http://github.com/kohana/database/commit/7ac0f05dc7256b94f26861e5352a108aa84fa230 Woody Gilk
03:23 am Database Revision 7ac0f05d: Database_Query was never updated to reflect the changes made in da2b5f9a658a21...
Woody Gilk
03:21 am Bug Report #3022 (Closed): Queries do not respect Database::$default
The change made in #2849 was not carried over to @Database_Query::execute@, which still uses "default" as the default... Woody Gilk
02:10 am Bug Report #3019 (Closed): Kohana_Database_Query_Builder_Join doesn't properly handle table prefix
Woody Gilk
01:39 am Bug Report #2780: Database Table Prefixes aren't correctly handled when joining
Any chance to merge this to 3.0.7? It might take a long time until 3.1.0 is out, as its a critical bug that breaks th... Human Internals
01:17 am Bug Report #2901: XSS issue in the default error page
Added a ticket at http://dev.kohanaframework.org/issues/3016. Human Internals
01:16 am Bug Report #3018 (Feedback): The Validate class should have a method to simply allow a column to ...
I know, and I did say that's what I'm currently doing, but I still think there should be a different method for that,... Human Internals
01:07 am Bug Report #3019: Kohana_Database_Query_Builder_Join doesn't properly handle table prefix
Heh. seems like it. I didn't know there was already a ticket for that
We did write a very similar description :)
...
Human Internals
12:57 am Bug Report #3018 (Closed): The Validate class should have a method to simply allow a column to "p...
You can do that simply by setting a label:
$array->label('pass_through', 'Ignored');
Woody Gilk
12:46 am Bug Report #3019: Kohana_Database_Query_Builder_Join doesn't properly handle table prefix
Isn't this an exact duplicate of #2780? Woody Gilk

06/27/2010

11:27 pm Bug Report #3020: It should be encouraged to change the Cookie salter
Another thing I forgot to mention - I think the salter protection on cookies should be configurable.
When other prot...
Human Internals
11:26 pm Bug Report #3019: Kohana_Database_Query_Builder_Join doesn't properly handle table prefix
Oops. commented on the wrong issue. Ignore this Human Internals
11:10 pm Cache Bug Report #3021: Problems with the driver Kohana_Cache_File - _resolve_directory()
php 5.2.13, linux (gento, centos) Vad Cool
11:08 pm Cache Bug Report #3021 (Closed): Problems with the driver Kohana_Cache_File - _resolve_directory()
_resolve_directory() returns an incorrect path to the directory.
Because $this->_cache_dir->getRealPath() return:
1...
Vad Cool
11:00 pm Bug Report #3020 (Closed): It should be encouraged to change the Cookie salter
I'm not quite sure if its a bug report or feature request, change it if its considered a feature request.
--
U...
Human Internals
10:18 pm Bug Report #3019 (Closed): Kohana_Database_Query_Builder_Join doesn't properly handle table prefix
Join is broken when a table prefix is set and an alias is used on the table being joined. An alias is always used whe... Human Internals
09:45 pm Bug Report #3018: The Validate class should have a method to simply allow a column to "pass thru"
Hrr. had a typo. meant "column_that_should_not_have_any_validation".
Also, I accidentally submitted it as a bug inst...
Human Internals
09:41 pm Bug Report #3018 (Closed): The Validate class should have a method to simply allow a column to "p...
If I want the Validate class to allow a column to be passed but without applying any rules, filters or callbacks on i... Human Internals
09:35 pm Bug Report #3016: Exceptions aren't getting HTML encoded
I wrote '(like "Missing foo & bar", which should get encoded to "*& amp;*")' but it didn't quote my &, so "& amp;" tu... Human Internals
08:50 pm Cache Bug Report #3013: Move default driver to config
> If you're going to use Cache library, Database or something, config files will be loaded anyway, so is it a good id... Woody Gilk
08:25 pm Cache Bug Report #3013 (Rejected): Move default driver to config
This suggestion goes against the standard Kohana convention. This in fact was how the default driver was set in the f... Sam de Freyssinet
07:03 pm UnitTest Revision a94d8b14: Re-adding tests.php that was (accidentally?) deleted when the tests were moved...
Matt Button
05:56 pm Cache Bug Report #3013: Move default driver to config
I think Woody is right. In KO3 configuration is done not only in config files, but also in the bootstrap.php for main... Dmitry T.
05:49 pm Feature Request #3017 (Closed): Add Request::url() function
Like @Route::url()@ Dmitry T.
05:46 pm Revision 9fc3f5fc: Updated submodules
Woody Gilk
05:38 pm Userguide Revision c0788031
WorksChen
05:32 pm Bug Report #3014: The Validator class doesn't properly pass params to errors
The value must be removed from the parameters because it may change. It is "added back":http://github.com/kohana/core... Woody Gilk
05:30 pm Bug Report #3015: Reverse routing should not include the default parameters
Fixed by http://github.com/kohana/core/commit/99f78f973b811e6ac8dc4bfa6b810f3651e284fb
As this changes the API and...
Woody Gilk
05:30 pm Bug Report #3014: The Validator class doesn't properly pass params to errors
I don't quite understand - shouldn't the value stay in the parameters so it'll get passed to the error later on?
Or ...
Human Internals
05:29 pm Core Revision fccba513: Added missing @since tag to Arr::flatten
Woody Gilk
05:29 pm Core Revision 99f78f97: Do not include the default parameters when generating a reverse routed URI fro...
Woody Gilk
05:13 pm Bug Report #3015: Reverse routing should not include the default parameters
In many ways, this should be reserved for v3.1, but it is a hard call to make. Woody Gilk
04:50 pm Bug Report #3015: Reverse routing should not include the default parameters
Right, this is the test I would be worried about:
http://github.com/kohana/core/commit/a9ec0e7130d47d4dbe01b78a9c0e2...
Jeremy Bush
04:47 pm Bug Report #3015: Reverse routing should not include the default parameters
Theoretically, it could break compatibility. This falls into a rather grey area, as it both a bug and a feature. It m... Woody Gilk
04:31 pm Bug Report #3015: Reverse routing should not include the default parameters
Doesn't this break backwards compatibility (is in, it changes how the uri() method works [even if it's desirable])? I... Jeremy Bush
04:27 pm Feature Request #3010 (Feedback): Compile routes only if required
Please provide a benchmark to prove that this is actually worth the impact it will have on extensions. Woody Gilk
04:22 pm Cache Bug Report #3013: Move default driver to config
But it isn't hard coded, it is a @public static@ variable, which means that it can be overloaded in @bootstrap.php@. ... Woody Gilk
04:20 pm Bug Report #3015 (Needs Test): Reverse routing should not include the default parameters
Fixed by http://github.com/kohana/core/commit/19f6018d681414b64e45cf37ff9cd0c65afa837a Woody Gilk
04:17 pm Core Revision 7d6ed2f5: Merge branch 'master' of git://github.com/kohana/core
Woody Gilk
04:07 pm Core Revision aa299854: Comment in Validate::check does not reflect what is actually happening
Woody Gilk
04:05 pm Bug Report #3014: The Validator class doesn't properly pass params to errors
The comment in question does not reflect what is actually happening.
> Remove the field name from the parameters
...
Woody Gilk
04:05 pm Bug Report #3016 (Closed): Exceptions aren't getting HTML encoded
This was already raised at http://dev.kohanaframework.org/issues/2901, but I propose a different solution and was ask... Human Internals
04:03 pm Bug Report #3014 (Closed): The Validator class doesn't properly pass params to errors
Woody Gilk
03:58 pm Feature Request #2947 (Closed): Add Route::$default_controller
This issue title and description does not fit with the conclusion that was reached during feedback. As such, I have c... Woody Gilk
03:57 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters
The default parameters (@Route::defaults@) of a route are there to provide fallbacks when those segments are not incl... Woody Gilk
03:54 pm Bug Report #3014 (Closed): The Validator class doesn't properly pass params to errors
Where the validator handles the rules, in system/classes/kohana/validator.php line 851:... Human Internals
03:12 pm Cache Bug Report #3013: Move default driver to config
Bence, I agree. I think this what the "convention" is. The same could be done with Session, Database, Encrypt etc. Dmitry T.
03:05 pm Cache Bug Report #3013 (Rejected): Move default driver to config
It would be better to read the default driver from the configuration then hard-coding it as a class-level constant. Bence Eros
03:00 pm Feature Request #2947 (Feedback): Add Route::$default_controller
Woody, couldn't you please re-read all discussion? During the discussion, we concluded that there is no need to add t... Dmitry T.
02:12 pm Feature Request #3012 (Closed): FlashData support
Add simple flashdata (set, keep, get) methods to the Session class.
Ofcourse this can easily be extended by any user...
Daniel Idén
02:01 pm Patch #2939 (Closed): /modules/userguide/views/api/class.php
We don't change our code to work around buggy IDEs. Use an IDE that doesn't suck and the "issue" will disappear. Woody Gilk
02:01 pm Feature Request #2947 (Closed): Add Route::$default_controller
This should be handled with Routing, not by setting a default controller name. Woody Gilk
01:58 pm Bug Report #2975 (Closed): Request instance gets lost when there is no matching route for the URI
You have to create a new @Request@ and assign it as the @Request::$instance@ if it does not exist. Woody Gilk
01:52 pm Feature Request #3011 (Closed): limit() for DB::Update()
DB::Update() doesn't compile specified limit() Daniel Idén
01:31 pm Feature Request #3010: Compile routes only if required
Not yet. Bence Eros
01:23 pm Feature Request #3010: Compile routes only if required
Have you created a Codebench done any other benchmarks to test this theory? Woody Gilk
12:12 pm Feature Request #3010 (Closed): Compile routes only if required
Hi All,
I think it would come with some performance improvement to compile routes only when the @matches()@ method...
Bence Eros
09:19 am Patch #2847 (Closed): URL Validation
More tests: http://github.com/kohana/core/commit/59be438ab2027923a45c9d0b78edb9ac3d2988b6
Fix: http://github.com/koh...
Geert De Deckere
08:58 am Core Revision 22019c0f: Fixed #2847
Geert De Deckere
04:07 am OAuth Revision f35de8f6: Missing @category for OAuth_Server
Woody Gilk
04:07 am OAuth Revision 5dca3ce1: Missing @category class comment
Woody Gilk
04:05 am OAuth Revision fda6ed12: Add OAuth_Request::$name to the base class
Woody Gilk
04:04 am OAuth Revision 8ecd3182: Completed comments on OAuth_Token classes
Woody Gilk
03:50 am OAuth Revision 381ca1cd: Added OAuth RFC comments to OAuth_Request_Token, OAuth_Request_Authorize, OAut...
Woody Gilk
03:46 am OAuth Revision 757d7442: Finished comments on OAuth_Request
Woody Gilk
03:39 am OAuth Revision 27c54da6: Completed comments for OAuth_Consumer
Woody Gilk

06/26/2010

10:30 pm Patch #2847 (Feedback): URL Validation
For reference, this is the regex that I started with:
@((((([a-z0-9]{1}[a-z0-9\-]{0,62}[a-z0-9]{1})|[a-z])\.)+[a-z...
Woody Gilk
06:49 pm Patch #2847 (Review): URL Validation
Tricky stuff. What are the exact rules for valid URLs? And how strict do we want to be? Here are some points which ar... Geert De Deckere
05:31 pm OAuth Revision 8c1922df: Added OAuth_Request::required to allow changing the required parameters, this ...
Woody Gilk
05:06 pm OAuth Revision 04ec8651: Use the new OAuth_Request_Authorize, and allow custom request parameters per m...
Woody Gilk
05:06 pm OAuth Revision aed5b3b0: Added OAuth_Request_Authorize, allows the creation of an OAuth_Request that ex...
Woody Gilk
04:22 pm Feature Request #3004 (Closed): Generated feed XML can be better
Updated the test with http://github.com/kohana/core/commit/c025f077a3ca9f2a66e8ebfbe74a0d92d51c22f9
Should be more...
Jeremy Bush
04:13 pm Bug Report #3008 (Closed): Kohana_FeedTest::test_create is broken
Correct, #3004 currently has a "Needs Test" status. Woody Gilk
04:06 pm Bug Report #3009 (Closed): undefined method Arr::flatten()
Woody Gilk
04:05 pm Bug Report #3009: undefined method Arr::flatten()
Remove the issue, the thing just "got to work" by itself, lol Kemal Delalic
04:03 pm Bug Report #3009: undefined method Arr::flatten()
I really don't know how this happens, method is still there and I haven't extended the arr class Kemal Delalic
04:01 pm Bug Report #3009 (Closed): undefined method Arr::flatten()
... Kemal Delalic
03:47 pm Bug Report #3008 (Closed): Kohana_FeedTest::test_create is broken
... Ivan Kurnosov
02:21 pm Patch #2847: URL Validation
Thanks Geert, I was hoping you would review my regex! Woody Gilk
02:19 pm Bug Report #2901 (Closed): XSS issue in the default error page
I think escaping the parameters works just fine, and still allows the developer to do some interesting things. Please... Woody Gilk
12:54 pm UnitTest Revision 03e42268: Readme update, coding style cleanup
Geert De Deckere
12:16 pm UnitTest Revision 17283546: Typo: environment
Geert De Deckere
10:42 am Patch #2847: URL Validation
More tests:
* http://github.com/kohana/core/commit/b1cb676de3453c072bf9eaf5d831cf1e839620e3
* http://github.com/koh...
Geert De Deckere
10:38 am Core Revision b0ed32fa: Fixing Validate::url #2847
Geert De Deckere
10:21 am Bug Report #3006 (Closed): Obsolete "+" char at Route class (?)
Right. It is a good idea to use possessive quantifiers whenever possible. It can save you some needless backtracking.... Geert De Deckere
09:56 am Bug Report #2901 (Feedback): XSS issue in the default error page
In my opinion message should be sanitized regardless of its variables.
It is very unlikely but user input may finall...
Human Internals
09:30 am Bug Report #3007 (Closed): Test_dir not cleaned after tests performed
github.png.001 is not removed after tests are runned
Also - it is typo in .gitignore in "logs" dir
possible fix...
Ivan Kurnosov
09:01 am Bug Report #3006: Obsolete "+" char at Route class (?)
Oops, it is "possessive" quantifier.
Wrong ticket.
Ivan Kurnosov
08:57 am Bug Report #3006 (Closed): Obsolete "+" char at Route class (?)
http://github.com/kohana/core/blob/master/classes/kohana/route.php#L39
http://github.com/kohana/core/blob/master/cla...
Ivan Kurnosov
07:53 am Bug Report #3005: Tests failed on windows
Possible fix: http://github.com/zerkms/kohana-core/commit/d9258f3ee8bfdcc47a57bfd80f80ec2a4f4b1607
Tests: 520, Ass...
Ivan Kurnosov
07:53 am Bug Report #3005 (Closed): Tests failed on windows
Tests: 520, Assertions: 1937, Failures: 13, Skipped: 2. Ivan Kurnosov
07:52 am Revision 255129e3: Updated submodules
Woody Gilk
06:02 am Core Revision 71ca9cf2: Using DOMDocument to format the output of Feed::create results in more readabl...
Woody Gilk
06:02 am Feature Request #3004 (Needs Test): Generated feed XML can be better
Fixed by http://github.com/kohana/core/commit/71ca9cf269d9862362a61190cb70fd5a4472a15d Woody Gilk
06:00 am Feature Request #3004 (Closed): Generated feed XML can be better
The output generated by "DOMDocument::saveXML":http://php.net/manual/en/domdocument.savexml.php is far better than "S... Woody Gilk
05:56 am Bug Report #2739 (Needs Test): image property of rss channel
Fixed by http://github.com/kohana/core/commit/34f20b111c70a4b9501e6942315a44e2eaae17a5 Woody Gilk
05:55 am Core Revision 34f20b11: Added image tag support to Feed::create, fixes #2739
Woody Gilk
05:41 am Core Revision 756012b2: Must be a leftover from porting the v2 helper
Woody Gilk
05:38 am Bug Report #2999: Remote::get() handling of network errors can be improved
Jeremy, I have no idea if @Remote::get@ can be unit tested properly. Woody Gilk
05:37 am Core Revision faf2f36a: Prevent Remote::get from returning "0" as the response text when a network err...
Woody Gilk
05:37 am Bug Report #2999 (Needs Test): Remote::get() handling of network errors can be improved
Fixed by http://github.com/kohana/core/commit/faf2f36a29163cc284147770f58446b08918731d Woody Gilk
05:23 am Bug Report #2945 (Closed): Arr::merge() doesn't properly merge single dimension non-associative a...
Test added in http://github.com/kohana/core/commit/db35973e5430d47875331223086c86871476250a Woody Gilk
05:23 am Core Revision c3a6ab7c: Code formatting for 0df3dfbfcde91ec4427f5e4a5db105dfb327d722
Woody Gilk
05:23 am Bug Report #2945 (Needs Test): Arr::merge() doesn't properly merge single dimension non-associati...
Fixed by http://github.com/kohana/core/commit/0df3dfbfcde91ec4427f5e4a5db105dfb327d722 Woody Gilk
05:21 am Core Revision 0df3dfbf: Fix Arr::merge() to properly merge single dimension non-associative arrays, fi...
Signed-off-by: Woody Gilk <[email protected]> Chris Smith

06/25/2010

10:29 pm Bug Report #3001: Request::$uri changes based on the server.
Ah, it helps if i look what around the changeset :)
btw, this is #3001 :)
Jeremy Bush
10:25 pm Bug Report #3001 (Closed): Request::$uri changes based on the server.
I think this is also the same as #3001, just worded differently. Woody Gilk
10:25 pm Bug Report #2680 (Closed): Request::uri() should url-encode parameters
I think this is also the same as #3001, just worded differently. Woody Gilk
10:23 pm Bug Report #3001: Request::$uri changes based on the server.
The code in question tests for @PATH_INFO@,@REQUEST_URI@, and @PHP_SELF@ to attempt to find the URI. Almost all serve... Woody Gilk
10:21 pm Core Revision 9ddd534e: Change the wording of a comment about finding the request path
Woody Gilk
10:19 pm Bug Report #3001: Request::$uri changes based on the server.
What was the reason for using REQUEST_URI as opposed to a "pre-decoded" value? Jeremy Bush
10:16 pm Core Revision 040a51cc: Merge branch 'master' of git://github.com/kohana/core
Woody Gilk
10:16 pm Core Revision c6b92e64: Use rawurldecode() on the REQUEST_URI when using it in Request::instance, fixe...
Woody Gilk
10:15 pm Bug Report #3001 (Needs Test): Request::$uri changes based on the server.
Fixed by http://github.com/kohana/core/commit/c6b92e646cceb1e93c4ac75e2297b04bfed848fd Woody Gilk
08:51 pm Bug Report #3003 (Closed): Stack Traces Fail when cause is a language construct
Fixed by http://github.com/kohana/core/commit/c78adca8213c3486f16331e2810314bd29aec5ce Jeremy Bush
08:51 pm Core Revision c78adca8: Fixing #3003
Jeremy Bush
08:50 pm Bug Report #3003 (Closed): Stack Traces Fail when cause is a language construct
Because the stack trace tries to do reflection on language constructs, the handler fails out. Jeremy Bush
08:39 pm Bug Report #3001: Request::$uri changes based on the server.
I doubt the results would vary much, this is all "RFC specification":http://ftp.ics.uci.edu/pub/ietf/http/rfc1945.htm... Woody Gilk
08:33 pm Bug Report #3001: Request::$uri changes based on the server.
Just a note, this was running under nginx/0.8.41. Results _could_ vary from server to server. Mathew Davies
08:19 pm Bug Report #3001: Request::$uri changes based on the server.
Perfect Mathew, that was exactly the comparison I needed. Woody Gilk
08:16 pm Bug Report #3001: Request::$uri changes based on the server.
I'd prefer *rawurldecode*. This way the "addition character isn't parsed as a space":http://codepad.org/ZPCZNL0R. Thi... Mathew Davies
06:01 pm Userguide Revision 0a864921: Merge branch 'master' of git://github.com/icyleaf/userguide-cn
Woody Gilk
05:54 pm Feature Request #2980 (Closed): Unable to use include_path when setting up SYSPATH
Kohana has never used include paths and we don't support this kind of setup. Woody Gilk
05:52 pm Bug Report #3001: Request::$uri changes based on the server.
Would using @urldecode@ on @$_SERVER['REQUEST_URI']@ fix this? Woody Gilk
05:49 pm Bug Report #2972 (Closed): Form::image (undefined $index variable)
Yes, fixed. Woody Gilk
05:47 pm Bug Report #2978 (Closed): (site issue) latest link
Fixed by http://github.com/kohana/kohanaphp.com/commit/b82daf7e70b6b64eb0f812ab2f78ccc68a8af274 Woody Gilk
05:46 pm OAuth Revision 5a17562d: Oops, config example should not be inside the classes/ directory
Woody Gilk
03:25 pm Bug Report #2968: $this->response isn't defined in initial ReflectionException in 3.1
Resolved status is still considered "open" by Redmine. Should be changed to closed unless the workflow is for Woody ... Anonymous
03:20 pm Bug Report #2972: Form::image (undefined $index variable)
This appears to have been resolved: http://github.com/kohana/core/commit/880321b20be674aa1cce9a4cb9ae9a5d7413b227 Anonymous
11:01 am Bug Report #2949: PHPUnit fails to restore $_SERVER
Sorry my mistake, the test strings which change HTTP_HOST are 'example.com' and 'kohanaframework.org'.
If you want...
Marcus Cobden
07:09 am ORM Bug Report #3002 (Closed): ORM doesnt filter Validate rules for missing fields
For example, if I have rules for 'a' and 'b' fields in my model, ORM should search them in $_object and $_ignored_col... Ivan Brotkin
04:36 am Bug Report #2978: (site issue) latest link
The download link should be http://dev.kohanaframework.org/attachments/download/1569/kohana-3.0.6.2.zip.
The .2 is...
Andrew Wong
01:17 am Bug Report #2978 (Feedback): (site issue) latest link
404 though :-S Ivan Kurnosov

06/24/2010

11:52 pm Feature Request #2286: Add support for multiple selected options in form::select
Arguing by using the spec, well done. As much as I hate them, you have a point there. Woody Gilk
11:17 pm Bug Report #3001 (Closed): Request::$uri changes based on the server.
h1. Scenario 1.
You have a server with *PATH_INFO* and request the following URL:
http://example.com/ö
*PATH...
Mathew Davies
10:39 pm Bug Report #3000 (Closed): Config system rewrite
While writing tests for Kohana_Config I noticed a lack of consistency across the system.
h2. Problem 1 - Object cl...
Matt Button
10:04 pm Userguide Revision 32f5a2d7: Updated the Dutch translation of installing
Jonas De Smet
09:44 pm Userguide Revision 150edab9: Cleaned up some code fragments
Jonas De Smet
09:41 pm Userguide Revision 151ab64c: Updated Dutch translation of conventions
Jonas De Smet
06:12 pm Feature Request #2286: Add support for multiple selected options in form::select
N Komay wrote:
> I would rather leave *the possibility* to pass an array of selected values to the Form::select().
...
Matt Button
04:57 pm Auth Bug Report #2987 (Closed): Auth user model login validation object does not use labels
"fixed":http://github.com/kohana/auth/commit/d4bfd31b3962f6cfd633ed9abc8bf010baf02a92 Ivan Brotkin
04:47 pm Bug Report #2999: Remote::get() handling of network errors can be improved
Sorry, the error is _not_ in the response but retrieved by curl_error(). Samuel Vogel
04:45 pm Bug Report #2999 (Closed): Remote::get() handling of network errors can be improved
When there is a network error while fetching the response (unknown host, unable to connect) the HTTP response code is... Samuel Vogel
03:34 pm Bug Report #2978 (Closed): (site issue) latest link
Fixed by http://github.com/kohana/kohanaphp.com/commit/77841cb497c4f308e3454daf08a9ba4a33bf4100 Woody Gilk
02:02 pm Bug Report #2998: Windows, php < 5.3.0 and checkdnsrr()
Ivan, we won't be creating compatibility functions, but thanks! Woody Gilk
01:49 pm Bug Report #2998 (Closed): Windows, php < 5.3.0 and checkdnsrr()
Fixed by http://github.com/kohana/core/commit/399ec34672b37b21171218f3de1a1a91dca4dcb8 Jeremy Bush
01:47 pm Feature Request #2286: Add support for multiple selected options in form::select
I would rather leave *the possibility* to pass an array of selected values to the Form::select().
Who does not want ...
N Komay
01:13 pm Bug Report #2998: Windows, php < 5.3.0 and checkdnsrr()
Here is possible solution: http://github.com/zerkms/kohana-core/commit/195c413a813e6a1d7536fba859ac052d126f8ffa Ivan Kurnosov
01:10 pm Bug Report #2998 (Closed): Windows, php < 5.3.0 and checkdnsrr()
There is no checkdnsrr() implementation in php < 5.3.0 in windows
So tests runing failed:...
Ivan Kurnosov
09:21 am Bug Report #2997 (Closed): apache segfault
When i extend the orm class to use by my model:
class Model_Myuser extends ORM {
protected $_table_name = 'u...
zera tool
08:07 am Auth Revision 2a550591: Coding style
Geert De Deckere
03:20 am ORM Bug Report #2996 (Closed): Can't read or update additional data in pivot tables using Through and...
I have two tables connected by a pivot table. In that pivot table i have additional data that i can add using the add... Jose Albornoz
03:20 am ORM Bug Report #2982: Can't read or update additional data in pivot tables using Through and ORM.
i putted the target version 3.0.6
it's my mistake.
I re-opened it correct.
Please close this one.
Jose Albornoz
02:55 am Feature Request #2979 (Closed): Url helper to compose urls from routes
Tested by:
http://github.com/kohana/core/commit/b1fdea7c1d1977a2f2516f208e66b43641252bb2
http://github.com/kohana...
Jeremy Bush
02:45 am Userguide Revision 8bc6f470: Translation completed for about.install.md
icy leaf
02:28 am Userguide Revision 388f9821: 90% translation complated for about.conventions.md
icy leaf
01:48 am Userguide Revision 743c8b1f: Sync
icy leaf
01:45 am OAuth Revision 690647c2: Updated Google demo with profile request
Woody Gilk
01:44 am OAuth Revision 64031e0b: Added user_profile API call, gets the Google Profile for the authed user
Woody Gilk
01:26 am OAuth Revision a03dcda7: Forgot to change a URL location
Woody Gilk
01:24 am OAuth Revision 9eabcd1c: Added OAuth_Provider_Google, currently only allows access the Contacts API, ne...
Woody Gilk
01:24 am OAuth Revision ffe5681f: Added Google demo controller
Woody Gilk
01:24 am OAuth Revision 1b20af39: Fixing OAuth_Provider_Twitter for changes in 0de8edb1bb84c4e68fb25724cb7c8007b...
Woody Gilk
01:24 am OAuth Revision 5ae7e8c2: Change OAuth_Provider $urls to require the entire method name, added $params, ...
Woody Gilk
01:18 am OAuth Revision ba9a528a: The header should include all of the parameters, but not the post body
Woody Gilk
01:17 am OAuth Revision bd9ac09d: The provider should be dynamic, not always "twitter"
Woody Gilk
12:23 am Revision 3cb1cb98: Updated submodules
Woody Gilk
12:17 am Feature Request #2966 (Assigned): Update Validate class for 3.1.0
Thanks Jonathan! This should probably go into 3.1, but I will let Sam decide if he wants to merge it in right now. Woody Gilk
12:14 am Userguide Revision 20ee1307: Merge branch 'master' of git://github.com/BRMatt/userguide
Woody Gilk
12:09 am OAuth Revision 1a21352e: Added oauth example oauth config file
Woody Gilk

06/23/2010

11:56 pm Core Revision 35a4e4bb: Change codename and version to 3.0.7
Woody Gilk
11:55 pm Core Revision ef696f78: Added @since to Route::url
Woody Gilk
11:35 pm Userguide Revision 64a57977: First part of translation, most of about-part is translated to dutch
Jonas De Smet
11:33 pm Bug Report #2930 (Closed): Static classes should not have constructor
Woody Gilk
10:43 pm ORM Bug Report #2983: Updating Model Property Triggers Validation Errors if Property Missing in $_POST
After some further reading on various documentation and online posts, this issue is caused because:... Daniel Cannon
10:23 pm Bug Report #2949: PHPUnit fails to restore $_SERVER
Please can you update your copy of the tests / unittest module and try again? I've done a quick grep and can't find ... Matt Button
10:19 pm Bug Report #2932 (Closed): testFileAnchor isn't environment independent
Fixed via use of setEnvironment Matt Button
10:07 pm Bug Report #2995: Kohana_UploadTest assertions failed
... Ivan Kurnosov
10:00 pm Bug Report #2990: testModules test in CoreTest.php causes modules to be reset.
Fixed by http://github.com/BRMatt/core/commit/badebd0a9af5d74c597a295b0d40eb4c809a9cf5
Needs merging with blessed core
Matt Button
09:55 pm Bug Report #2995: Kohana_UploadTest assertions failed
It was a problem with the unittest module, it didn't have support for changing the _FILES array.
Fixed in 38a2811 ht...
Matt Button
09:55 pm UnitTest Revision 38a2811f: Added _FILES support to setEnvironment()
Fixes #2995 http://dev.kohanaframework.org/issues/2995 Matt Button
09:39 pm Bug Report #2995: Kohana_UploadTest assertions failed
sorry, missed "pre" and "code" tags in ticket description... Ivan Kurnosov
09:38 pm Bug Report #2995 (Closed): Kohana_UploadTest assertions failed
... Ivan Kurnosov
08:29 pm Userguide Revision e3e9e89f: Initialised nl as a translation with recent EN-files as fall back, nothing tra...
Jonas De Smet
08:27 pm Auth Feature Request #2889 (Closed): Enable auto-login in Model_Auth_User
fixed in "9971fbbb":http://github.com/kohana/auth/commit/9971fbbb09b2b386dd3dacb12092c350b3b430e0 Ivan Brotkin
08:25 pm Auth Feature Request #2510 (Closed): Checking password (without login)
implemented in "77a1c6a76":http://github.com/kohana/auth/commit/77a1c6a76a5cfe3b5f0dbe4bcc4b4ddb859cd4ca Ivan Brotkin
08:17 pm Auth Revision d4bfd31b: implementing #2987 (Model_Auth_User doesnt use labels)
Ivan Brotkin
07:36 pm Userguide Revision 656c7ffe: Merge branch 'master' of http://github.com/kohana/userguide
Jonas De Smet
05:31 pm Bug Report #2994 (Closed): Pagination : add rel="..." to links
Took care of the other view too. Now using the HTML5 @rel@ attributes which also has a @last@ value.
http://www.w3.o...
Geert De Deckere
04:16 pm Bug Report #2994 (Feedback): Pagination : add rel="..." to links
What about the other view? Dmitry T.
03:34 pm Patch #2847 (Closed): URL Validation
The redmine workflow needed to be updated for Patches. Jeremy Bush
03:30 pm Patch #2847: URL Validation
Please take this issue out of Review status. Woody Gilk
03:29 pm Patch #2847: URL Validation
Fixed by http://github.com/kohana/core/commit/8e3a625b68c4e7b06c1ae1e2524a40c1c734cb63
Added additional tests:
* ...
Woody Gilk
03:28 pm Core Revision 8e3a625b: Updated Validate::url, allow hostnames with no domain, allow paths in URLs, se...
Woody Gilk
02:50 pm Bug Report #2930: Static classes should not have constructor
Woody Gilk wrote:
> But they aren't abstract classes. If we aren't going to add a private @__construct@, then we sho...
Jeremy Bush
02:48 pm Bug Report #2930: Static classes should not have constructor
But they aren't abstract classes. If we aren't going to add a private @__construct@, then we shouldn't call a class a... Woody Gilk
02:46 pm Feature Request #2979: Url helper to compose urls from routes
Jeremy, these "Needs Test" issues are still fixed, but just not a "Closed" Status. Woody Gilk
02:45 pm Feature Request #2979: Url helper to compose urls from routes
> What about $protocol = true default value? Following the URL definition - it should include the schema.
Like @UR...
Woody Gilk
02:10 pm Feature Request #2979: Url helper to compose urls from routes
... Ivan Kurnosov
01:31 pm Feature Request #2979 (Needs Test): Url helper to compose urls from routes
Jeremy Bush
01:29 pm Bug Report #2994 (Closed): Pagination : add rel="..." to links
Sorry, pagination has no tests yet. Jeremy Bush
01:28 pm Bug Report #2994 (Needs Test): Pagination : add rel="..." to links
Jeremy Bush
01:27 pm Bug Report #2973 (Closed): Upload::size() doesn't take into account php.ini settings
Tested by http://github.com/kohana/core/commit/ed3b5a477c818b8bf776dc77b4e6a4db7c0b40f5 Jeremy Bush
01:27 pm Bug Report #2969 (Closed): Validation - :param1 doesn't get replaced with actual parameter
Tested by http://github.com/kohana/core/commit/5feadbbf68e5a8c11b131ee39533262a75f16af1 Jeremy Bush
01:26 pm Patch #2847 (Review): URL Validation
This change fails this unit test: http://github.com/kohana/core/blob/testing/tests/kohana/ValidateTest.php#L761 Jeremy Bush
01:08 pm Bug Report #2994 (Closed): Pagination : add rel="..." to links
Didn't know about those @rel@ attributes. Thanks, Thomas.
http://github.com/kohana/pagination/commit/bccf6e9d5c783...
Geert De Deckere
09:22 am Bug Report #2930 (Feedback): Static classes should not have constructor
Maybe these classes should be also marked as abstract? Dmitry T.
06:41 am Bug Report #2994 (Closed): Pagination : add rel="..." to links
Hello everybody,
I think this could be considered as an issue for the pagination module, links are missing the "re...
Thomas Lété
05:52 am Bug Report #2968 (Resolved): $this->response isn't defined in initial ReflectionException in 3.1
This has been fixed - good catch. Sam de Freyssinet
05:50 am Core Revision 4cf6f5f7: Fixes #2968
Sam de Freyssinet
05:43 am Bug Report #2968 (Assigned): $this->response isn't defined in initial ReflectionException in 3.1
Sam de Freyssinet
05:24 am Bug Report #2517: ORM throwing ErrorException Undefined index: id
I've been digging through Kohana investigating what I think might be the same problem and it seems that it is caused ... Jason Blair
05:08 am Userguide Revision 6c43be65: Merge branch 'master' of git://github.com/kohana/userguide
Woody Gilk
05:07 am Auth Bug Report #2989 (Closed): Model_Auth_User unique key problem
Ivan Brotkin
05:03 am Core Revision 1d2e3c3a: Replaced Validate::url with a regex-based test, fixes #2847
Woody Gilk
05:03 am Patch #2847 (Closed): URL Validation
Fixed by http://github.com/kohana/core/commit/1d2e3c3aa5240c9ba4099dda1e9f1b2cd3e5b3df Woody Gilk
04:45 am Feature Request #2857 (Closed): Request should check for file existance
This is duplicate of #2251. Woody Gilk
04:43 am Bug Report #2954 (Closed): PDO Identifier is set in connect()
Woody Gilk
04:43 am Core Revision daf56a51: Use HTML::chars for profiler stats names, fixes #2977
Woody Gilk
04:42 am Bug Report #2977 (Closed): profiler/stats view, SQL queries output error malformed document, wit...
Fixed by http://github.com/kohana/core/commit/daf56a51e2646ee89bfef9f5a9d5769de5e5077c Woody Gilk
04:40 am Core Revision f468de5d: Removed "final private __construct" from classes, fixes #2930
Woody Gilk
04:40 am Bug Report #2930 (Closed): Static classes should not have constructor
Fixed by http://github.com/kohana/core/commit/f468de5d396244837dbb2a5916a2ac40af26bcc0 Woody Gilk
04:36 am Core Revision 22a9c6bb: Added new method Route::uri as a shortcut to URL::site(Route::get(...)->uri(.....
Woody Gilk
04:35 am Feature Request #2979 (Closed): Url helper to compose urls from routes
Fixed by http://github.com/kohana/core/commit/22a9c6bbf1beaec691fb4757267e3325b292638e Woody Gilk
04:24 am ORM Bug Report #2962: ORM: Validation with TRUE filters adds empty properties visible when doing $ent...
Validate specifically checks for TRUE values, this must be an ORM issue. Woody Gilk
04:01 am Auth Bug Report #2987 (Assigned): Auth user model login validation object does not use labels
Woody Gilk
04:00 am Bug Report #2973 (Needs Test): Upload::size() doesn't take into account php.ini settings
Fixed by http://github.com/kohana/core/commit/132a1c7c4c3e994e6ffe0731df9e32b9e8a2f251 Woody Gilk
04:00 am Core Revision 737bfaec: Cleaned up Upload::size, now throws an exception for an invalid size and optim...
Woody Gilk
03:53 am Core Revision 132a1c7c: Added a check for UPLOAD_ERR_INI_SIZE in Upload::size, fixes #2973
Woody Gilk
03:47 am Revision a0c66f4f: Add ctype check to install.php, even though it is enabled by default since PHP...
Woody Gilk
03:47 am Bug Report #2948 (Closed): install script needs to check for ctype support in php
Fixed by http://github.com/kohana/kohana/commit/a0c66f4fa3cc23bf33c507b431aa1b62eb4a4d60 Woody Gilk
03:38 am Feature Request #2955: About the ability to UPDATE and DELETE from multiple tables
Documentation issue. You need to call @table()@ a second time. Woody Gilk
03:34 am Bug Report #2954: PDO Identifier is set in connect()
This can probably be passed through, there's no Database module tests yet. Only Core. Jeremy Bush
03:23 am Bug Report #2970 (Closed): Unit test references $_SERVER['argc']
Fixed by http://github.com/kohana/core/commit/0a96afcc9e1997cff38bbdd642af3712a77549b5 Jeremy Bush
03:17 am Bug Report #2970 (Assigned): Unit test references $_SERVER['argc']
Jeremy Bush
03:16 am Bug Report #2993: Bug in the Url Helper
vlad suciuv wrote:
> The url Helper has a bug in the "title" function.
> is completely removing all the characters...
Jeremy Bush
03:13 am Bug Report #2991: Errors and assertion fails with unittests
Core tests should be run like this:
http://github.com/kohana/core/blob/testing/README.md
just run `phpunit` fro...
Jeremy Bush
03:11 am Bug Report #2969 (Needs Test): Validation - :param1 doesn't get replaced with actual parameter
This needs a unit test. Woody Gilk
03:11 am Bug Report #2914 (Closed): Add Value to Validation Messages
Jeremy, issue #2969 needs the test, not this one. This issue was incorrectly resolved. Woody Gilk
03:08 am Bug Report #2973 (Assigned): Upload::size() doesn't take into account php.ini settings
Woody Gilk
03:08 am Bug Report #2914 (Needs Test): Add Value to Validation Messages
Needs test pls. Jeremy Bush
03:07 am Bug Report #2993 (Closed): Bug in the Url Helper
But that is quite obviously not what it is doing, or it wouldn't be written that way. Woody Gilk
03:05 am Bug Report #2988 (Closed): Validate does not travel recursively through $_POST
> Basically, I think Validate works with the assumption that all fields are strings, so I'm just making it work with ... Woody Gilk
03:02 am Bug Report #2969 (Closed): Validation - :param1 doesn't get replaced with actual parameter
Fixed by http://github.com/kohana/core/commit/7e85602b888405ca0ce069cb8e84e428004424ae Woody Gilk
03:02 am Patch #2976 (Closed): Patches :param# not being replaced in validation
This patch simply is an "undo" for #2914, not the correct solution. Woody Gilk
03:01 am Core Revision 7e85602b: Related to #2914, commit 9b927c45a937a9f6a9c5953d12408a759d44e359 improperly s...
Woody Gilk

06/22/2010

09:07 pm Bug Report #2991: Errors and assertion fails with unittests
Matt Button wrote:
> Are you running the tests from within the system folder?
>
> i.e. cd system; phpunit;
No,...
Kevin D
08:47 pm Feature Request #2981 (Feedback): Delete expired cache entries
Is this purely for the File and SQLite drivers? The other memory based drivers do not implement the requested method.... Sam de Freyssinet
07:28 pm Bug Report #2991: Errors and assertion fails with unittests
Are you running the tests from within the system folder?
i.e. cd system; phpunit;
Matt Button
07:10 pm Feature Request #2981 (Assigned): Delete expired cache entries
Woody Gilk
07:04 pm Bug Report #2970: Unit test references $_SERVER['argc']
He's talking about the K3 repo, the unit tests got merged into the testing branch of core.
http://github.com/kohana/...
Matt Button
06:29 pm Bug Report #2970: Unit test references $_SERVER['argc']
It would be far more helpful if you linked to the github page for that commit or even if you mentioned which repo you... Anonymous
05:43 pm Bug Report #2993 (Closed): Bug in the Url Helper
The url Helper has a bug in the "title" function.
It seems that this line:
$title = preg_replace('![^'.preg_quote(...
vlad suciuv
01:40 pm ORM Feature Request #2992 (Closed): ORM::has() for multiple objects
At this moment ORM::has($alias, $model) supports only one model at once. What about multiple checking:
public func...
Ivan Brotkin
12:21 pm Bug Report #2991 (Closed): Errors and assertion fails with unittests
When executing the unittests, I get some errors and failures. I have added an attachment with the logs of the phpunit... Kevin D
12:05 pm Bug Report #2990 (Closed): testModules test in CoreTest.php causes modules to be reset.
When executing the unittests, a warning is shown on line 275 of unittest\classes\controller\unittest.php because ther... Kevin D
11:36 am Auth Bug Report #2989: Model_Auth_User unique key problem
> By the way...is there a way how I can close this issue? I don't want others to worry about it...
nope :)
Dmitry T.
10:50 am Auth Bug Report #2989: Model_Auth_User unique key problem
Doublechecked it. My kohana version is still 3.0.4. A great moment to upgrade since we're moving to a new server.
By...
Marius Grauzinis
10:39 am Auth Bug Report #2989: Model_Auth_User unique key problem
Oh, sorry. I downloaded and started using Kohana 3 about 2 weeks ago...by that time the query builder wasn't so smar... Marius Grauzinis
09:51 am Auth Bug Report #2989: Model_Auth_User unique key problem
I think its not Auth issue. Current Database_Query_Builder's version "already knows":http://gist.github.com/kohana/da... Ivan Brotkin
08:02 am Auth Bug Report #2989 (Closed): Model_Auth_User unique key problem
Auth module crashes when adding a new user (pk = null) and the username or email isn't unique. The problem is in uniq... Marius Grauzinis
04:25 am OAuth Revision eacd1242: Decode the tweet response
Woody Gilk
04:23 am OAuth Revision c8d1a15a: YABC
- Providers can now be as little as a name and a list of URLs
- Updated the demo controllers, now extensible and twee...
Woody Gilk

06/21/2010

08:52 pm Userguide Revision bd14379e: Merge branch 'master' of http://github.com/kohana/userguide
Jonas De Smet
08:01 pm Bug Report #2988: Validate does not travel recursively through $_POST
For my fix, I replaced line 775 with... Tyler Rasmussen
07:38 pm Bug Report #2988: Validate does not travel recursively through $_POST
I was wrong; different issue is why I wasn't getting arrays in my output. I'm using ->filter(TRUE, 'trim') and when ... Tyler Rasmussen
06:58 pm Bug Report #2988 (Closed): Validate does not travel recursively through $_POST
See http://www.php.net/manual/en/arrayobject.construct.php#84206 for possible fix, though the code looks poor and wou... Tyler Rasmussen
06:53 pm Auth Bug Report #2987 (Closed): Auth user model login validation object does not use labels
The login() function for the Model_Auth_User model does not apply labels set in the _labels property to the validatio... eric beeson
06:20 pm Bug Report #2986 (Closed): Form::label and other Form fields
The fields build by the Form class use the first variable to set the "name" attribute.
According to W3C (http://ww...
Tyler Rasmussen
09:37 am Bug Report #2985 (Closed): sqlite pdo list taables and columns
Would be great to have it. BAsed on Tiger's Way from the forum... zsolt sandor
08:32 am Feature Request #2984 (Closed): Additional data to be passed with callback
I think that validate::callback() should accept 3 parameters (field, callback and additional data) as well as validat... Ivan Kurnosov
05:34 am ORM Bug Report #2983 (Closed): Updating Model Property Triggers Validation Errors if Property Missing...
Posting a Form to Update an ORM Model Instance Triggers, Validation Errors if a Field That was not in the Form is not... Daniel Cannon
04:30 am ORM Bug Report #2982 (Closed): Can't read or update additional data in pivot tables using Through and...
I have two tables connected by a pivot table. In that pivot table i have additional data that i can add using the add... Jose Albornoz
12:59 am OAuth Revision a23a0002: Another nasty, huge commit. Finished the implementation of Twitter OAuth! Chec...
Woody Gilk
12:27 am Feature Request #2981 (Closed): Delete expired cache entries
I think there should be a function like Cache::delete_expired() to delete expired entries from the cache Dmitry T.
12:20 am Feature Request #2979: Url helper to compose urls from routes
I agree with Ivan. There is definitely a need for such function. And the name is rather good Dmitry T.

06/20/2010

11:59 pm Feature Request #2980 (Closed): Unable to use include_path when setting up SYSPATH
In my current setting things looks like follows:
Application path is c:/web/gallery
And system path is c:/web/_in...
Konstantin Kostyk
10:38 pm Feature Request #2979: Url helper to compose urls from routes
Yeah. I will glad to see either Route (that depends on URL class) or URL (that depends on Route class) ;-)
ps: at th...
Ivan Kurnosov
10:35 pm Feature Request #2979: Url helper to compose urls from routes
I thought @Route::url($name, $options)@ would make more sense. Woody Gilk
08:45 pm Feature Request #2979: Url helper to compose urls from routes
I oferred feature and its one possible "implementation" ;-) developers are free to accept this feature with another, ... Ivan Kurnosov
07:38 pm Feature Request #2979: Url helper to compose urls from routes
The name is not very clear, because it doesn't return a route or something, but a url. Kevin D
07:37 pm Bug Report #2905: Request class can't handle PUT requests with XML data
A proposed non-api breaking solution: http://github.com/Ikke/core/commit/a09465c07a5f25d1d3828cb97d80ebb9c7a0e494 Kevin D
02:46 pm Feature Request #2979 (Closed): Url helper to compose urls from routes
What about making some helper method in URL class to prevent of implementing such code:... Ivan Kurnosov
02:43 pm Bug Report #2978 (Closed): (site issue) latest link
The link http://kohanaframework.org/download/kohana-latest points not to the really latest (3.0.6.2) version Ivan Kurnosov
01:45 am OAuth Revision c6e6b35b: Finished implementation of OAuth_Twitter::request_token, it works!
Woody Gilk
01:44 am OAuth Revision 9e8471f5: Do not include the Kohana consumer details
Woody Gilk
01:16 am OAuth Revision 3f75c1ac: Do not encode the signature
Woody Gilk
01:09 am OAuth Revision dc77cf15: Thanks Twitter... the proper param is "oauth_signature_method", without "consu...
Woody Gilk
12:22 am OAuth Revision 37857feb: Implemented a big pile of stuff
Woody Gilk

06/19/2010

08:49 pm Userguide Revision 55c1e4b8: Added nix temp files and swp files to gitignore
BRMatt
08:42 pm Userguide Revision a5d10025: Ported the Production environment settings page from kerkness.ca
BRMatt
05:58 pm Userguide Revision 504c04ce: Merge branch 'master' of git://github.com/kohana/userguide
BRMatt
05:55 pm Userguide Revision 7fbd96fa: Added coding conventions to the docs
BRMatt
03:58 pm OAuth Revision 6402fc14: Rename "urlencode_rfc3986" to just "urlencode", less typing
Woody Gilk
03:56 pm OAuth Revision 53a75dad: Implemented PLAINTEXT and HMAC-SHA1 signatures
Woody Gilk
03:55 pm OAuth Revision e148a4fb: The "consumer" is the website that is requesting authorization
Woody Gilk
03:54 pm OAuth Revision 988b67d9: A "client" is not part of the OAuth protocol
Woody Gilk
02:39 pm OAuth Revision 57ceefc6: Added OAuth_Provider
Woody Gilk
02:36 pm OAuth Revision 6cff9434: Cleaning up formatting and class comments
Woody Gilk
02:17 pm Userguide Revision 296cd8a1: Added a new section in the git-tutorial
Jonas De Smet
02:10 pm OAuth Revision cf73639e: Updated README contents
Woody Gilk
02:09 pm OAuth Revision 779a12c3: Made README a Markdown file
Woody Gilk

06/18/2010

10:45 pm Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
Updated patch. Daniel Enman
10:44 pm Patch #2976: Patches :param# not being replaced in validation
Updated patch. Daniel Enman
10:26 pm Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
I've decided on a much better way to approach the patch. I will update it here (and in Patch #2976) when I have a cou... Daniel Enman
10:26 pm Patch #2976: Patches :param# not being replaced in validation
I've decided on a much better way to do this. I'll update the patch when I get some time to fully work it out. Daniel Enman
08:35 pm Bug Report #2977: profiler/stats view, SQL queries output error malformed document, with header ...
at line 32
echo HTML::chars($name), ' (', count($tokens), ')'
instead of
echo $name, ' (', count($tokens), '...
Philippe Jos
08:31 pm Bug Report #2977 (Closed): profiler/stats view, SQL queries output error malformed document, wit...
When using a content-type header application/xhtml (outputing an xhtml document), the output of the profiler/stats vi... Philippe Jos
07:00 pm Patch #2976 (Closed): Patches :param# not being replaced in validation
This diff resolves the issue of parameters not being replaced during validation of some forms (in specifically, user ... Daniel Enman
06:57 pm Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
I've patched my copy of validate.php and :param# is replaced now.
I've attached a copy of the .diff. Should I open...
Daniel Enman
05:22 pm Bug Report #2975: Request instance gets lost when there is no matching route for the URI
Thanks, Korney. I'll use this sollution Ivan Skryabin
10:36 am ORM Bug Report #2958: ORM not loading values when using has_many "through" relationships.
Here is a better patch... Deon George
07:50 am Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
Dai I don't quite understand what are you suggesting... I'm not validating an ORM model simply a form. This example l... Josip Jelic
06:58 am Bug Report #2975: Request instance gets lost when there is no matching route for the URI
You can have a route at the very end, that mathces anything. The controller can then throw appropriate exception. Korney Czukowski
06:51 am Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
Josip Jelic wrote:
> ...
Dai Jobou

06/17/2010

11:49 pm Bug Report #2974: JOIN ON values are quoted
Dmitry T. wrote:
> how about this?
> [...]
This will cause the mysql performance degradation and composing of su...
Ivan Kurnosov
09:44 pm Bug Report #2974: JOIN ON values are quoted
how about this?... Dmitry T.
08:28 pm Bug Report #2974: JOIN ON values are quoted
Zombor suggested I used a db expression which worked like a charm. The ON.. using OR oporator could still be a prob... Joel Pittet
08:24 pm Bug Report #2974: JOIN ON values are quoted
Well, you can use DB::expr() :... Ivan Skryabin
08:21 pm Bug Report #2975 (Closed): Request instance gets lost when there is no matching route for the URI
When there is no matching route for uri, a constructor sets $this->status to 404 and throws an exception.
But there ...
Ivan Skryabin
08:11 pm Userguide Revision 9eadfb42: Added a new section in the git-tutorial
Jonas De Smet
07:37 pm Bug Report #2974: JOIN ON values are quoted
Thanks Dmitry, but I should of clarified. I am using LEFT JOIN so I keep my original table's records and appending ... Joel Pittet
07:10 pm Bug Report #2974: JOIN ON values are quoted
I think you should move such conditions to WHERE clause Dmitry T.
06:49 pm Bug Report #2974 (Closed): JOIN ON values are quoted
The following JOIN statement is quote the numeric ON values... Joel Pittet
08:09 am Bug Report #2971: form input and hidden tags are not self closing
View Selected Source shows you a fragment of the current DOM state, while just View Source shows raw HTML data, it's ... Korney Czukowski
04:44 am Bug Report #2971: form input and hidden tags are not self closing
This is actual something unique to Firefox. Whenever you highlight a form input with your cursor and view selected so... Akiva Levy

06/16/2010

11:31 pm Bug Report #2971 (Closed): form input and hidden tags are not self closing
Maybe Firefox is changing them based on your doctype? They are "clearly self-closing":http://github.com/kohana/core/b... Isaiah DeRose-Wilson
10:38 pm Bug Report #2973 (Closed): Upload::size() doesn't take into account php.ini settings
At the moment there is no test for UPLOAD_ERR_INI_SIZE in the upload::size() method. If you therefore try to upload a... Leo -
08:17 pm Bug Report #2972 (Closed): Form::image (undefined $index variable)
Funtion:
Kohana_Form::image()
ErrorException [ Notice ]: Undefined variable: index
There appears to be a variabl...
mudi ugbo
07:45 pm Feature Request #2537: Validation filters as callbacks.
Oliver Morgan wrote:
> Not re-inventing the wheel is only a minor reason to not stick with the kohana validation cla...
Jonathan Geiger
03:09 pm Feature Request #2966: Update Validate class for 3.1.0
It's also entirely possible for my implementation to be backwards-compatible (which I haven't done yet). I will work ... Jonathan Geiger
12:40 pm Bug Report #2971: form input and hidden tags are not self closing
Tags were in fact closing, however when viewing source via Firefox's View Selected Source, Firefox was in fact removi... Akiva Levy
12:22 pm Bug Report #2971 (Closed): form input and hidden tags are not self closing
via form helpers, inputs generated are not self closed (ie. <input />) Akiva Levy
10:30 am Bug Report #2970 (Closed): Unit test references $_SERVER['argc']
Commit c43c9f3a2d67ed223f6311179ec6dbde143bd83b adds tests which reference $_SERVER['argc'] which won't be defined in... Marcus Cobden
08:42 am Bug Report #2969: Validation - :param1 doesn't get replaced with actual parameter
forgot to mention the obvious :)
:param1 doesn't get replaced with actual value (in this case '6')
Josip Jelic
08:41 am Bug Report #2969 (Closed): Validation - :param1 doesn't get replaced with actual parameter
when using (for example): ... Josip Jelic
07:46 am Bug Report #2968: $this->response isn't defined in initial ReflectionException in 3.1
Amended the lines 1117 & 1122 respectively to:... Tony Holdstock-Brown
07:29 am Bug Report #2968 (Closed): $this->response isn't defined in initial ReflectionException in 3.1
Just downloaded 3.1 to have a little browse and, without a controller for the default route, the Request class doesn'... Tony Holdstock-Brown
02:22 am Feature Request #2966: Update Validate class for 3.1.0
Threw up some ideas here:
http://github.com/jonathangeiger/core/commits/3.1
Jonathan Geiger
12:13 am Feature Request #2965 (Closed): Form::input - set default value of ID attribute to the value of $...
You can overload @HTML::attributes@ if you want to do that. See the related ticket for how it used to be done. Woody Gilk

06/15/2010

09:35 pm Feature Request #2965: Form::input - set default value of ID attribute to the value of $name para...
While I can see how this might be handy some of the time, in my experience it actually just makes thing more complica... Isaiah DeRose-Wilson
09:07 pm Feature Request #2537: Validation filters as callbacks.
Jonathan Geiger wrote:
> @ollym
>
> That looks pretty good actually. I've been wanting to upgrade Jelly to someth...
Oliver Morgan
08:02 pm Feature Request #2966 (Closed): Update Validate class for 3.1.0
Currently, myself and a few other third-party module developers are having a bit of trouble with the @Validate@ class... Jonathan Geiger
07:18 pm Feature Request #2537: Validation filters as callbacks.
@ollym
That looks pretty good actually. I've been wanting to upgrade Jelly to something similar but I'm concerned ...
Jonathan Geiger
10:32 am Feature Request #2965 (Closed): Form::input - set default value of ID attribute to the value of $...
I think that it is basically safe to set the default value of ID attribute of any input element to the same of $name ... N Komay
08:29 am Userguide Feature Request #2964 (Closed): Add link to ORM Tutorial in ORM API Browser
Please add a link pointing to ORM Tutorial page (http://kohanaframework.org/guide/tutorials.orm) in ORM API Browser (... Korney Czukowski
07:59 am Bug Report #2963 (Closed): The API guide requires models for "through" relationships even though ...
If I define a through relationship, ORM doesnt need a model for that relationship.
However, if you go the guide/ap...
Deon George
07:50 am ORM Bug Report #2958: ORM not loading values when using has_many "through" relationships.
OK, I understand now, through queries are not performed unless you do a find() on the through branch.
Attached is a ...
Deon George

06/14/2010

07:30 pm Core Revision ba5448e0: Merged in changes from trunk
Sam de Freyssinet
07:16 pm Core Revision 2d37db70: Refactored the Request class to assign properties correctly
Sam de Freyssinet
05:08 pm ORM Bug Report #2962 (Closed): ORM: Validation with TRUE filters adds empty properties visible when d...
I have the following filters in a simple model:... Torleif Berger
04:25 pm Bug Report #2943 (Closed): File::mime is unreliable.
Fixed by http://github.com/kohana/core/commit/fa3b4af1a036c81e0834716a8a022a77526aded2 Jeremy Bush
04:24 pm Core Revision 1108a339: Merge branch 'master' of github.com:kohana/core
Jeremy Bush
04:24 pm Core Revision fa3b4af1: fixing #2943
Jeremy Bush
04:23 pm Bug Report #2943 (Assigned): File::mime is unreliable.
Jeremy Bush
03:59 pm Bug Report #2961: Pagination should url-encode parameters
When you use Request::uri() or Route::uri() directly, at least you can encode parameters manually, in pagination you ... Dmitry T.
03:56 pm Bug Report #2961 (Closed): Pagination should url-encode parameters
I'm not sure this is the pagination bug, nor this is a bug at all, but anyways: pagination does not encode the parame... Dmitry T.
03:40 pm ORM Bug Report #2958: ORM not loading values when using has_many "through" relationships.
OK, a little further playing I have learnt that... Deon George
11:57 am Bug Report #2960 (Closed): Session drivers should have different _name by default
If you use different session types (say Native and Database), you'll soon end up with plenty of errors :
session_s...
Cédric Cazette

06/13/2010

03:56 pm Userguide Feature Request #2959 (Closed): Use jQuery.Syntax for syntax highlighting
"jQuery.Syntax":http://www.oriontransfer.co.nz/software/jquery-syntax works better than Syntax Highlighter and integr... Woody Gilk
03:54 pm ORM Bug Report #2958 (Closed): ORM not loading values when using has_many "through" relationships.
Hi, I've found a problem where I cant get values to show from a "through" relationship.
I have a database with tab...
Deon George
05:45 am Userguide Revision 5a27e420: Fixed some typos
Geert De Deckere
05:27 am Userguide Revision 4132671c: Optimized PNG files, saving about 65 kB
Geert De Deckere
05:18 am Userguide Revision 62663c6f: Merge branch 'master' of [email protected]:kohana/userguide
Geert De Deckere
05:18 am Userguide Revision 4a401b98: CRLF to LF
Geert De Deckere

06/12/2010

07:53 pm Feature Request #2864: Add an is_sub flag to the Request class
I did declare the variable in a previous commit. As I said I'm only getting to grips with git and github, so it took ... Andrew Clarke
05:59 pm Bug Report #2957 (Closed): Make sure Session::write is called last
Unexpected behavior may arise when using *register_shutdown_function* and if the function called by *register_shutdow... Israel Canasa
02:19 pm Bug Report #2954: PDO Identifier is set in connect()
Good idea, the comments have been updated in http://github.com/kohana/database/commit/eccee9a4dbc23b27002464412fcbe35... Woody Gilk
02:18 pm Database Revision b1beaa88: Clean up database config comments
Woody Gilk
02:18 pm Database Revision eccee9a4: Follow up to f52e71f0f84a0a0d56f3d182c154539262115875, add a comment about the...
Woody Gilk
02:14 pm Bug Report #2956 (Closed): Route::$uri does not respect base_url and index_file
Correct, Routes are not aware of the base URL and index settings, only the URL helper is. Woody Gilk
02:04 pm Feature Request #2947: Add Route::$default_controller
I agree with you. Route::uri() should not add params to the uri if they are omitted.
In our case we should get someth...
Dmitry T.
01:56 pm Bug Report #2956: Route::$uri does not respect base_url and index_file
I got it. I should use URL::site(Route::get('admin')->uri(array('controller' => 'manage', 'action' => 'posts'))); Dmitry T.
01:52 pm Bug Report #2956: Route::$uri does not respect base_url and index_file
Sorry, not Route::$uri, but Route::uri() Dmitry T.
01:40 pm Bug Report #2956 (Closed): Route::$uri does not respect base_url and index_file
... Dmitry T.
12:53 pm Feature Request #2947: Add Route::$default_controller
> Really? $default_action *DOES* exist already, furthermore it is public (configurable). So why not to make
Guess w...
neko fs
12:21 pm Patch #2812 (Closed): Paginator view with limited number of links
Thanks, Alexey. I added your view as a separate view called "floating". Besides some coding style changes, I also mad... Geert De Deckere
12:11 pm Feature Request #2537: Validation filters as callbacks.
I have created a similar Validation library for kohark, which addresses theses issues and provides a lot more functio... Oliver Morgan
10:11 am Feature Request #2541 (Closed): Pagination: how to manually define page number
http://github.com/kohana/pagination/commit/88d3b44cc473c7d4f073c93269da65836d14da6c
I implemented the proposed patch.
Geert De Deckere
08:27 am Feature Request #2947: Add Route::$default_controller
> I don't think it's justifiable to set up a variable $default_action
Really? $default_action *DOES* exist already, ...
Dmitry T.
05:40 am Feature Request #2947: Add Route::$default_controller
So basically you want to get the default route uri with default parts neglected? I don't think it's justifiable to se... neko fs
05:08 am Bug Report #2954: PDO Identifier is set in connect()
maybe you can make a note in config/database.php that the identifier is now out of the connection group. I hadn't rea... neko fs
02:16 am Bug Report #2950 (Closed): Kohana_Core::debug_path($file) should use DIRECTORY_SEPARATOR constant
Semi tested by http://github.com/kohana/core/commit/84476837bbd2561b944ae3b0920d47f28eb6402e Jeremy Bush
01:46 am Feature Request #2537: Validation filters as callbacks.
I almost posted a new issue for this comment but wanted to see if I'd get any more feedback first.
First off, I ju...
Jonathan Geiger
01:42 am Bug Report #2950 (Needs Test): Kohana_Core::debug_path($file) should use DIRECTORY_SEPARATOR cons...
Jeremy Bush
12:28 am Feature Request #2955 (Closed): About the ability to UPDATE and DELETE from multiple tables
I want build a query like "DELETE block_module FROM module,
block_module WHERE module.id = block_module.module_id an...
Jack Lee

06/11/2010

11:39 pm Bug Report #2915 (Closed): Lacking identifier option of PDO
See #2954 Woody Gilk
11:39 pm Bug Report #2954 (Needs Test): PDO Identifier is set in connect()
Fixed by http://github.com/kohana/database/commit/f52e71f0f84a0a0d56f3d182c154539262115875 Woody Gilk
11:38 pm Bug Report #2954 (Closed): PDO Identifier is set in connect()
If a query is compiled before connecting, the identifier will not be used. Woody Gilk
11:37 pm Bug Report #2915: Lacking identifier option of PDO
This needs a new issue, as the versions are different. Woody Gilk
11:37 pm Database Revision f52e71f0: Follow up to 4b9ad733348e9ccf19200a77fa6c6acd3b332e63, make Database::__constr...
Woody Gilk
11:30 pm Bug Report #2950 (Closed): Kohana_Core::debug_path($file) should use DIRECTORY_SEPARATOR constant
Fixed by http://github.com/kohana/core/commit/0c9f18dd4e2a850fea8f740f463cf90c095fa7ca Woody Gilk
11:30 pm Core Revision 0c9f18dd: Use DIRECTORY_SEPARATOR in Kohana::debug_path(), fixes #2950
Woody Gilk
10:20 pm Bug Report #2952 (Closed): Validate::digit() should not allow negative integers
Fixed by http://github.com/kohana/core/commit/c792a375a5a9d154639c9f960362fbdf4f024fd8 Jeremy Bush
10:14 pm Bug Report #2952 (Needs Test): Validate::digit() should not allow negative integers
Jeremy Bush
09:56 pm Bug Report #2952: Validate::digit() should not allow negative integers
Please can you set the status to "needs tests"? This could be a useful candidate Matt Button
08:57 pm Feature Request #2864: Add an is_sub flag to the Request class
You should really declare the variable in the class, that way it'll show up in the api docs. Matt Button
08:37 pm Feature Request #2864: Add an is_sub flag to the Request class
I forked kohana/core on github, committed code to add this feature, and sent a pull request.
http://github.com/gly...
Andrew Clarke
08:18 pm Bug Report #2953: ORM Callbacks
Possible fix, this way any ignored_fields get ignored as they should be.... Joel Pittet
08:03 pm Bug Report #2953 (Closed): ORM Callbacks
The ORM's check method merges changes from the validate object but doesn't update any values that may have changed du... Joel Pittet
06:19 pm Bug Report #2952 (Closed): Validate::digit() should not allow negative integers
http://github.com/kohana/core/commit/eb8f70d5a825f2bc5acdcf5a1b801912770e27be Geert De Deckere
06:18 pm Core Revision eb8f70d5: Fixed #2952
Geert De Deckere
06:18 pm Bug Report #2952 (Closed): Validate::digit() should not allow negative integers
@Validate::digit()@ checks whether a string consists of digits only (no dots or dashes). However, if you are not enab... Geert De Deckere
06:06 pm Feature Request #2951 (Closed): Add valid_page() check to Pagination
http://github.com/kohana/pagination/commit/99f0669aae4f91eab0484430ef68a70e5b20d85c Geert De Deckere
06:04 pm Feature Request #2951 (Closed): Add valid_page() check to Pagination
Instead of automatically displaying the first or last page when the given page number falls out of the available rang... Geert De Deckere
04:10 pm Bug Report #2915 (Feedback): Lacking identifier option of PDO
Hi, there is a new bug on the same issue. There happens to be a query compiled BEFORE calling connect() where identif... neko fs
03:55 pm Bug Report #2949: PHPUnit fails to restore $_SERVER
3.4.13 is what I have.
PHP version 5.3.2
Marcus Cobden
03:11 pm Bug Report #2950 (Closed): Kohana_Core::debug_path($file) should use DIRECTORY_SEPARATOR constant
Just discovered today that when using the userguide api browser (with Apache running on Windows) I get stuff like thi... Torleif Berger
02:13 pm UnitTest Revision 30d42dd4: Fixed link path problem.
Marcus Cobden
02:13 pm UnitTest Revision 249746dc: Fixed updated filename.
Marcus Cobden
02:13 pm UnitTest Revision e4eb3194: Fixed an exception thrown when there are no groups returned.
Marcus Cobden
02:06 pm Bug Report #2949: PHPUnit fails to restore $_SERVER
What version of phpunit are you running? 3.4.13 is the latest Matt Button
01:07 pm Bug Report #2949 (Closed): PHPUnit fails to restore $_SERVER
I noticed this because the 'view' link on the test results page redirected me to a url on the host 'example.org'.
...
Marcus Cobden
12:10 pm Bug Report #2948 (Closed): install script needs to check for ctype support in php
I did a new install for kohana3 and started working with ORM.
I got the following error:
ErrorException [ Fatal Err...
Tonko Mulder
09:31 am Feature Request #2947 (Closed): Add Route::$default_controller
There is Route::$default_action variable, and when in routes we don't specify the action or set it to NULL - this def... Dmitry T.
08:01 am Bug Report #2942 (Closed): Kohana_Cache_Exception [ 0 ]: Kohana_Cache_File::_delete_file failed t...
Fixed in http://github.com/kohana/cache/commit/7911ce544bd15d6223af48fb8fd0103522f675bc Sam de Freyssinet
07:56 am Cache Revision 7911ce54: Fixes an issue in Windows XP where the open files iterator stops the parent di...
Sam de Freyssinet
02:43 am Revision 54cd7708: Updated submodules
Woody Gilk
02:42 am Userguide Revision fb9333b6: Changed to LF line endings
Woody Gilk
02:34 am Bug Report #2942: Kohana_Cache_Exception [ 0 ]: Kohana_Cache_File::_delete_file failed to delete ...
modules/cache/classes/kohana/cache/file.php中第369行(line 369),增加unset($files);即可解决此问题:
try
{
unset($files);
// ...
宗鑫 朱
12:42 am Bug Report #2946: Whitelist not set - O/S Windows
In a WIN environment it should be searching for 'classes\\', or more appropriately 'classes'.DIRECTORY_SEPARATOR David Grinberg
12:41 am Bug Report #2946 (Closed): Whitelist not set - O/S Windows
O/S: Win XP (IIS 7)
PHP: 5.3.2
PHPUnit: 3.4.13
XDebug: 2.1RC1
Under a windows O/S the white list is never set...
David Grinberg

06/10/2010

09:51 pm Patch #2939: /modules/userguide/views/api/class.php
Trevor, you should create a patch file which can be applied to the existing code; This will show the developers what ... Mathew Davies
06:58 pm Bug Report #2943: File::mime is unreliable.
I should have read the code comment!
@This method is horribly unreliable@
I spotted another issue.
*Line 48*:
<pre...
Mathew Davies
04:10 pm Bug Report #2945: Arr::merge() doesn't properly merge single dimension non-associative arrays
Fix http://github.com/cs278/kohana-core/compare/ticket/2945 Chris Smith
04:02 pm Bug Report #2945 (Closed): Arr::merge() doesn't properly merge single dimension non-associative a...
Arr::merge() merges nested arrays differently to non-nested arrays, as demonstrated by the following example:
<pre...
Chris Smith
03:25 pm Bug Report #2943: File::mime is unreliable.
Here's the relevant test case:
http://github.com/kohana/core/blob/testing/tests/kohana/FileTest.php#L26
It's po...
Jeremy Bush
03:19 pm Bug Report #2943 (Closed): File::mime is unreliable.
File::mime unittest fails.
The expected result is *application/x-httpd-php*, but finfo returns a different valid t...
Mathew Davies
03:04 pm UnitTest Revision 2433d17c: Whitelist should not be used by default on cli
Matt Button
03:03 pm UnitTest Revision 3c31edf4: Fixed a problem with setEnvironment() not changing globals properly
Matt Button
11:34 am Core Revision f3c29c85: Using marginly faster method for checking Request::$instance
Sam de Freyssinet
08:30 am Bug Report #2942 (Closed): Kohana_Cache_Exception [ 0 ]: Kohana_Cache_File::_delete_file failed t...
Kohana_Cache_Exception [ 0 ]: Kohana_Cache_File::_delete_file failed to delete directory : D:\workspace\5pl\applicati... 宗鑫 朱
01:19 am Bug Report #2941 (Closed): Form::image() undefined variable
Fixed by http://github.com/kohana/core/commit/880321b20be674aa1cce9a4cb9ae9a5d7413b227 Woody Gilk
01:19 am Core Revision 880321b2: Follow up to 8b2a340fbb0b674e7eb36c0d8ae7ab177812d686, added missing parameter
Signed-off-by: Woody Gilk <[email protected]> Marek Szymczuk
01:05 am Bug Report #2941 (Closed): Form::image() undefined variable
There's an undefined variable: $index in form::image():
http://github.com/kohana/core/blob/master/classes/kohana/f...
Jeremy Bush

06/09/2010

11:10 pm Bug Report #2940 (Closed): Impossible to remove config readers
Fixed by:
http://github.com/kohana/core/commit/9a4fb61b8f2e32bfcbf181a638d56d5f2c371971
and
http://github.com/ko...
Jeremy Bush
11:09 pm Bug Report #2940 (Closed): Impossible to remove config readers
A bug in Config::detach() makes it impossible to remove config readers. Jeremy Bush
09:51 pm Core Revision c8e927ff: Followup to 9a4fb61b8f2e32bfcbf181a638d56d5f2c371971.
Jeremy Bush
09:39 pm Core Revision 9a4fb61b: Fixing a bug in config where it would be impossible to remove readers.
Jeremy Bush
08:34 pm Feature Request #2893: Use proper phpdoc @param and @return type hints
Mathew Davies wrote:
> No need to use @Kohana_Request@ in the phpDoc, using @Request@ will work fine and is better s...
Josh Johnston
05:34 pm UnitTest Revision 5d3bc996: Added a setEnvironment() helper to Kohana_Unittest_TestCase
Allows setting, backup and restoration of Superglobals, Static
properties and kohana config options
Matt Button
05:19 pm Database Feature Request #2931: Support for SQL operator "NOT" in query builders
No,... Alexey Khrulev
04:55 pm UnitTest Revision 20946a9f: removing unit tests, they were moved to kohana/core:testing
Jeremy Bush
12:38 pm Patch #2939 (Closed): /modules/userguide/views/api/class.php
/modules/userguide/views/api/class.php
class.php has many html tags which gives an error on "Ecilips PDT"
So I've c...
Trevor Sonic
02:41 am Bug Report #2938: 验证类ErrorException [ Notice ]: Undefined index: :values
在3.0.6.2已经解决此问题。 宗鑫 朱
02:40 am Bug Report #2938 (Closed): 验证类ErrorException [ Notice ]: Undefined index: :values
Woody Gilk
02:36 am Bug Report #2938 (Closed): 验证类ErrorException [ Notice ]: Undefined index: :values
$validate->rule('name', 'Upload::valid');
$validate->rule('name', 'Upload::not_empty');
$validate->rule('name', 'Up...
宗鑫 朱
02:32 am kohana-3.0.6.2.zip
Woody Gilk
02:29 am Revision 3dbe4434: Updated submodules
Woody Gilk
12:07 am Bug Report #2936 (Closed): Documentation Tweak [Papercut]
Woody Gilk
12:07 am Bug Report #2937 (Assigned): Profiler doesn't show nice in the API browser
I noticed that as well. It seems to be dependent on PHP version, I'm not sure that we can fix it. Woody Gilk

06/08/2010

11:54 pm Bug Report #2937 (Closed): Profiler doesn't show nice in the API browser
Hi, I try to find the problem myself but for now, with no luck. It seems like Profiler doesn't show up nice in the AP... Jonas De Smet
11:52 pm Bug Report #2928 (Closed): Do not assume Request::instance() has been run
Fixed by Woody Gilk
11:52 pm Core Revision ac6a07c9: Do not assume Request::$current has been set when calling Request::execute wit...
Woody Gilk
11:49 pm Database Feature Request #2931: Support for SQL operator "NOT" in query builders
Isn't that the short version of @WHERE ... NOT IN (...)@? Woody Gilk
11:46 pm Bug Report #2934 (Closed): Validate->error breaks when the 3rd argument isn't passed.
Fixed by http://github.com/kohana/core/commit/b20437bbc05423a95f10f95d9fa2b260ac7e397f Woody Gilk
11:45 pm Core Revision b20437bb: Validate::errors must check that parameters are present before parsing, fixes ...
Woody Gilk
11:21 pm Database Bug Report #2935 (Closed): MySQL :: Cannot connect to database after disconnect
Woody Gilk
11:21 pm Database Bug Report #2935: MySQL :: Cannot connect to database after disconnect
"Fixed" by http://github.com/kohana/database/commit/77facd61337ed08c086d42ed7b26a0e02ba20a9e Woody Gilk
11:13 pm Database Revision 8e79869b: Merge branch 'master' of git://github.com/kohana/database
Woody Gilk
11:12 pm Database Revision 77facd61: Reset the database connection when disconnecting in Database_MySQL, (sort of) ...
Woody Gilk
11:11 pm Database Bug Report #2935: MySQL :: Cannot connect to database after disconnect
Unfortunately, it is not that simple. The @connect@ method clears out the database username and password, which would... Woody Gilk
10:55 pm Bug Report #2930: Static classes should not have constructor
If you extend it, sure. I think better test coverage/lack of useless code is better than trying to "protect" the deve... Jeremy Bush
10:52 pm Feature Request #2873: Class Based Views
Jeremy Lindblom wrote:
> Can you post a new link, that one isn't working.
Doh, I deleted that repo. I have a dedi...
Jeremy Bush
10:47 pm Feature Request #2893: Use proper phpdoc @param and @return type hints
No need to use @Kohana_Request@ in the phpDoc, using @Request@ will work fine and is better suited to the transparent... Mathew Davies
10:43 pm Bug Report #2936: Documentation Tweak [Papercut]
Request to close this issue. It's a duplicate of #2893. Should have done a search first. Mathew Davies
10:06 pm Bug Report #2810: Kohana::$environment constants should be integers
If you do this then you need to space the 4 constants apart so people's custom environments can be inserted in between. Jeremy Lindblom
10:04 pm Feature Request #2873: Class Based Views
Can you post a new link, that one isn't working. Jeremy Lindblom
09:45 pm Bug Report #2936 (Closed): Documentation Tweak [Papercut]
"http://github.com/kohana/core/blob/master/classes/kohana/controller.php#L28":http://github.com/kohana/core/blob/mast... Mathew Davies
09:10 pm Bug Report #2928 (Assigned): Do not assume Request::instance() has been run
Woody Gilk
09:10 pm Database Bug Report #2935 (Assigned): MySQL :: Cannot connect to database after disconnect
Woody Gilk
09:04 pm kohana-3.0.6.1.zip
Woody Gilk
09:04 pm Bug Report #2929 (Closed): Validate error
Fixed by http://github.com/kohana/core/commit/d7cdbfde9cc9acabf6bbfdba53d35b20719c8ab5 Woody Gilk
08:59 pm Revision eb1c3a3a: Updated submodules
Woody Gilk
08:59 pm Core Revision d7cdbfde: Follow up to a0cc82434c233ce477ab6b576b504c4e6f649db0, errors will be generate...
Woody Gilk
08:56 pm Bug Report #2930 (Assigned): Static classes should not have constructor
I disagree, it prevents the class from ever being constructed. An abstract class will not prevent that. Woody Gilk
08:46 pm Database Bug Report #2935 (Closed): MySQL :: Cannot connect to database after disconnect
database/classes/kohana/database/mysql.php
How to cause the error:
$db = Database::instance();
$db->connect();
...
Tyler Rasmussen
08:25 pm Bug Report #2934 (Closed): Validate->error breaks when the 3rd argument isn't passed.
... Mathew Davies
07:37 pm UnitTest Revision af2a5eac: Changed the spacing on the web ui index page
Matt Button
07:25 pm Feature Request #2933 (Closed): Change camelCase test names to under_scores
As the title suggests, there aren't really enough benefits of camelCase to warrant using it instead of the more reada... Matt Button
07:22 pm Bug Report #2932 (Closed): testFileAnchor isn't environment independent
*Test results:*... Matt Button
06:10 pm Database Feature Request #2931 (New): Support for SQL operator "NOT" in query builders
Following functions:
* Database_Query_Builder_Where::and_where()
* Database_Query_Builder_Where::and_where_open()...
Alexey Khrulev
05:31 pm Bug Report #2930 (Closed): Static classes should not have constructor
Classes that are only used for static methods should not have this:
final private function __construct() {}
Thi...
Jeremy Bush
04:34 pm Bug Report #2929 (Closed): Validate error
ErrorException [ Notice ]: Undefined index: :values
SYSPATH/classes/kohana/validate.php [ 989 ]
984 $values[':value...
Leif Körner
02:28 pm Feature Request #2861 (Closed): Database::list_columns() should return field length as well
If your app is specifically for MySQL, I would recommend writing a MySQL query. @list_columns()@ is supposed to provi... Chris Bandy
02:23 pm Database Revision b0ca0de4: Expose MySQL integer length, fixes #2861
Chris Bandy
02:17 pm Bug Report #2928: Do not assume Request::instance() has been run
Something like this fixes it: http://gist.github.com/430079 Jeremy Bush
02:11 pm Bug Report #2928 (Closed): Do not assume Request::instance() has been run
We should not assume Request::instance() is run, and we should not assume Request::$current is properly filled in. Th... Jeremy Bush
10:42 am Core Revision 1c482016: Fixed a minor typo
Sam de Freyssinet
10:39 am Core Revision b5a2e1df: Fixed a small issue in the Remote class. Thanks Ikke
Sam de Freyssinet
09:50 am Core Revision 1c8c51a0: Small tidying up around Request / Response
Sam de Freyssinet
09:23 am Core Revision 086a6832: Ensured Request::_init_environment() is only run if the request is not the ori...
Sam de Freyssinet
06:25 am Feature Request #2861: Database::list_columns() should return field length as well
I think the @display@ attribute would suffice, but you don't mean that it'll be limited to only those @integer@ colum... Sam Wilson
02:32 am Bug Report #2908 (Closed): [Validate] errors() method exception due to array param
Whoops, wrong version. Woody Gilk
02:18 am kohana-3.0.6.zip
Woody Gilk
02:08 am Revision 249971a9: Updated submodules
Woody Gilk
02:04 am Bug Report #2914: Add Value to Validation Messages
Additional fix in http://github.com/kohana/core/commit/a0cc82434c233ce477ab6b576b504c4e6f649db0 Woody Gilk
02:03 am Core Revision a0cc8243: Follow up to 9b927c45a937a9f6a9c5953d12408a759d44e359, use Arr::flatten to for...
Woody Gilk
02:00 am Bug Report #2926 (Closed): rename views directory to view
The "views" directory is located outside of @classes/@ and has nothing to do with autoloading. Just as "classes" is c... Woody Gilk

06/07/2010

10:28 pm Bug Report #2926: rename views directory to view
Models aren't given any "special" privileges in K3 - they're treated like any other class, therefore their location i... Matt Button
10:04 pm Bug Report #2926: rename views directory to view
Did you mean *views* or *models*?
If models, then it has been fixed, see http://github.com/kohana/kohana/commit/e5b0...
Dmitry T.
09:04 pm Userguide Revision 1bded6e5: attaching a body class name of language in template view for right-to-left sup...
Rafael B.
09:04 pm Bug Report #2926: rename views directory to view
I reported it as a bug because some modules I have used expected "model".
"Model" is logical because "View", "Contro...
Yanis K
09:03 pm Userguide Revision 9285753b: typos
Rafael B.
05:34 pm Userguide Revision 11fea7c5: working on about, trans a few menu items
Rafael B.
05:33 pm Userguide Revision ffafac81: direction: rtl in css (we need to talk to shadowhand for a dynamic way)
Rafael B.
04:35 pm Bug Report #2926: rename views directory to view
In my opinion, everything is correct and logical now: *classes*, *logs*, *views*, ... Dmitry T.
04:26 pm Bug Report #2926: rename views directory to view
First off, this should be a feature request, not a bug report.
Secondly, why should this be changed? It makes perfec...
Matt Button
03:41 pm Bug Report #2926 (Closed): rename views directory to view
rename views directory to view Yanis K
03:25 pm Userguide Revision 9eb33310: Hebrew version for 8 articles so far. this is just the beginning...
adamli
02:50 pm Bug Report #2879 (Feedback): Error on Object of type 'variant' causes ReflectionException
Please provide a working patch. Woody Gilk
02:38 pm Userguide Revision 6c8d2f2a: Merge branch 'master' of git://github.com/icyleaf/userguide-cn
Woody Gilk
02:37 pm Feature Request #2924 (Closed): Flattening Arrays
Fixed by http://github.com/kohana/core/commit/94f1ff3a2524a932da260eec025f176a1a4f01cd Woody Gilk
02:36 pm Feature Request #2925 (Closed): Mapping callbacks to arrays recursively
Fixed by http://github.com/kohana/core/commit/87f095c6d16b8a314c94f2e2e587201fff7df8b7 Woody Gilk
02:36 pm Core Revision 87f095c6: Added Arr::map, a recursive array_map method that applies a callback to every ...
Woody Gilk
02:36 pm Core Revision 94f1ff3a: Added Arr::flatten, a method to convert a multi-dimensional array into a singl...
Woody Gilk
02:35 pm Feature Request #2925 (Closed): Mapping callbacks to arrays recursively
The @array_map@ method does not recursively work on arrays within arrays, which makes it hard to map callbacks that e... Woody Gilk
02:26 pm Feature Request #2924 (Closed): Flattening Arrays
Sometimes it is necessary to flatten a multi-dimensional array into a single-dimensional array. This method could be ... Woody Gilk
02:18 pm Feature Request #2919 (Closed): Write access to global data with references in views
Fixed by http://github.com/kohana/core/commit/15aa9cd99e5e81c1c83a559e78ca0eef9eca4aa4 Woody Gilk
02:18 pm Core Revision 15aa9cd9: Extract global variables by reference in View::capture, to allow references to...
Woody Gilk
01:28 pm Bug Report #2921 (Closed): Error with escaped exception variables
Woody Gilk
11:23 am Bug Report #2921: Error with escaped exception variables
I see this was fixed by http://github.com/kohana/core/commit/6947f29fc1a1e7069332d23fc38a2c76aaa48699 as a result of ... Kyle Treubig
09:25 am Auth Revision 9971fbbb: fixed #2889 (Auth_User model doesnt support autologin)
Ivan Brotkin
04:36 am Patch #2922 (Closed): Exception variable escaping
Woody Gilk
04:33 am Feature Request #2919 (Assigned): Write access to global data with references in views
Good use case. Consider your request accepted. Woody Gilk
02:24 am Feature Request #2919: Write access to global data with references in views
Alright this doesn't make sense. Say I have a snippet of javascript in a form view called by the base template, and w... neko fs
« Previous
Next »
 

Also available in: Atom