Activity

From 12/05/2010 to 01/03/2011

01/03/2011

09:05 pm ORM Revision c02f651d: empty_pk() now checks to see if the PK is empty OR PK === '0'
Andrew Ellis
09:00 pm ORM Bug Report #3540 (Closed): ORM::empty_pk issue
Thanks for the pull request. Fixed by "c02f651d3...":https://github.com/kohana/orm/commit/c02f651d37827aa50d46c97092f... Isaiah DeRose-Wilson
08:48 pm ORM Bug Report #3540: ORM::empty_pk issue
GitHub Pull Request: https://github.com/kohana/orm/pull/17 Andrew Ellis
08:39 pm ORM Bug Report #3540: ORM::empty_pk issue
Simply put, the current way this code sounds is like this:
"if empty AND it doesn't equal 0"
Just doesn't make ...
Andrew Ellis
08:32 pm ORM Bug Report #3540 (Closed): ORM::empty_pk issue
Because of the way ORM runs it's "check" method, this causes the _object[primary_key] to get set to {string} "0" if t... Andrew Ellis
07:19 pm ORM Revision c794a795: throwing an exception when find() or find_all() is called on a loaded object. ...
Isaiah DeRose-Wilson
07:15 pm ORM Revision 2b1fb54f: adding calls to ORM::wish() in count_all() (refs #3457)
Lorenzo Pisani
07:13 pm ORM Bug Report #3524 (Closed): find() and find_all() should throw exceptions when the model is loaded
Fixed by "c794a7959...":https://github.com/kohana/orm/commit/c794a795902ba56fbe67dc6e2fc4547994dba1ae Isaiah DeRose-Wilson
07:11 pm ORM Revision e4433c1e: Made ORM extend the Model class. Fixes #3532
Isaiah DeRose-Wilson
07:09 pm ORM Bug Report #3457 (Closed): count_all does not use $_load_with
Fixed by "2b1fb54fe149...":https://github.com/kohana/orm/commit/2b1fb54fe1496a262c6363f8546b95a3ef1f640a Isaiah DeRose-Wilson
07:06 pm ORM Feature Request #3532 (Closed): ORM should extend the Model class
Fixed by "e4433c1eb...":https://github.com/kohana/orm/commit/e4433c1ebd0f21f29220b47b42dd0b24535dfda2 Using Model::fa... Isaiah DeRose-Wilson
07:04 pm ORM Revision 8e0ca447: Removed unused ORM::$_primary_val, fixes #3246
Isaiah DeRose-Wilson
06:59 pm ORM Feature Request #3246 (Closed): Added a function to return primary value.
Removed ORM:::$_primary_val. I don't really see a need for this. See "8e0ca447...":https://github.com/kohana/orm/comm... Isaiah DeRose-Wilson
03:30 pm Core Revision 2e417f10: Exceptions should use the correct http headers. Refs #3537
Isaiah DeRose-Wilson
02:55 pm Core Revision ec945ea5: Remove Kohana_ prefix from some http exception calls. Fixes #3539
Jeremy Bush
02:50 pm Bug Report #3539 (Closed): Kohana_Http_* Exception should be Http_*
Fixed by https://github.com/kohana/core/commit/ec945ea5406962267e4940acf08d5a3e505b70a5 Jeremy Bush
02:48 pm Bug Report #3539 (Closed): Kohana_Http_* Exception should be Http_*
We have a few lines in core which throws new Kohana_Http_* exceptions. They should be changed to remove the Kohana_ p... Jeremy Bush
08:09 am Feature Request #3536: Remove controller method parameters
I see what your saying, but I believe your missing the point of routes :)
the "tips section":http://kohanaframework....
Kiall Mac Innes
07:38 am Feature Request #3536: Remove controller method parameters
I am talking about changing the key name of route parameters.
if I don't want to set too many route and just merge...
Yahasana .
07:17 am OAuth Bug Report #3323 (Closed): OAuth library conflicts with PECL OAuth
The OAuth module has been depreciated in 3.1, this is no longer an issue. Kiall Mac Innes
07:15 am Cache Patch #3337: Session handler using Cache
There are a few issues with the code in that repo:
@protected $_memcached;@ looks like a leftover?
The @if ( ! ...
Kiall Mac Innes
07:08 am Bug Report #3340 (Closed): Kohana's image library can fall over when given an invalid JPEG
An @ErrorException@ is already thrown when any PHP error/warning occurs, and silently failing is not really an option.. Kiall Mac Innes
06:53 am Bug Report #3512: Conflicting standards dealing with whitespace
Personally, I believe @'{'.(int) $digits.'}'@ is correct (even if the standards aren't 100% clear)... Kiall Mac Innes
06:39 am Feature Request #3536: Remove controller method parameters
Yahasana . wrote:
> Yes, you are right. but I seldom use reverse routing, and I believe it's a rare cases.
I believe...
Kiall Mac Innes
05:34 am Revision f1fde9db: Cleanup build.xml phpcs target
Kiall Mac Innes
05:25 am Revision d011025e: Cleanup build.xml pdepend-log target
Kiall Mac Innes
05:21 am Revision 0a01f87e: Cleanup build.xml phpcpd target
Kiall Mac Innes
05:07 am Feature Request #3536: Remove controller method parameters
Jeremy Bush wrote:
> That is a non-issue. If you change your route parameters, you already have to go any change all ...
Yahasana .
05:01 am Revision d6b61e93: Cleanup build.xml dist target logic
Kiall Mac Innes
04:57 am Bug Report #3538 (Closed): Validation changes ignores Geiger's context bit
The 3.1 changes are definitely in the right direction, but they do ignore the dynamic contexts spec from Mr. Geiger: ... Ben Midget
04:46 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Sincere apologies. I could have sworn I had set up NetBeans right for tabs, but I clearly hadn't. Will check my setti... Andrew Coulton
04:45 am Feature Request #3537 (Closed): Http_Exception_* exceptions should be displayed like normal excep...
Applied in changeset commit:"bff5081a1e6089fc20efb9ef29719c34a029a1da". Isaiah DeRose-Wilson
04:38 am Feature Request #3537 (Needs Test): Http_Exception_* exceptions should be displayed like normal e...
Fixed by "bff5081a":https://github.com/kohana/core/commit/bff5081a1e6089fc20efb9ef29719c34a029a1da Isaiah DeRose-Wilson
04:38 am Revision cbf1fbc5: Removing checkreturn="true" from test targets, hudson should determine this fr...
Kiall Mac Innes
04:37 am Core Revision bff5081a: Display Http_Exceptions like normal exceptions including backtrace and other d...
Isaiah DeRose-Wilson
04:35 am Revision 71aead36: Fix to build.xml dist paths.
Kiall Mac Innes
04:28 am Feature Request #3537 (Closed): Http_Exception_* exceptions should be displayed like normal excep...
Http_Exception_* exceptions should be displayed like normal exceptions to make debugging easier. It's important to se... Isaiah DeRose-Wilson
04:23 am Revision d106d7ea: Fixing comment syntax error in build.xml
Kiall Mac Innes
04:17 am Revision db0089dd: Adding initial dist target to build.xml. Needs some cleanup.
Kiall Mac Innes
04:17 am Revision d2d57276: Merge branch '3.1/develop' of github.com:kohana/kohana into 3.1/develop
Kiall Mac Innes
04:09 am Feature Request #3536: Remove controller method parameters
That is a non-issue. If you change your route parameters, you already have to go any change all your route::uri() cal... Jeremy Bush
04:01 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Also, there's lots of style violations in your pull request. Please review the style guidelines and update your pull ... Jeremy Bush
04:01 am Feature Request #3536: Remove controller method parameters
$this->request->param() is depended on the key name set in Route::set(), if these keys name are changed, all the $thi... Yahasana .
03:58 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Actually, userguide changes should be fine. It's not an api that developers use, it's more of a pre-built application... Jeremy Bush
03:38 am Core Revision 4efabae1: Mark controller action parameters deprecated. Refs #3536
Jeremy Bush
03:38 am Userguide Revision 957e4697: Fixed @3535 minor typo in API browser when no class methods
Andrew Coulton
03:34 am Userguide Bug Report #3535: Typo in API view when no class methods
Fixed in https://github.com/kohana/userguide/pull/12 Andrew Coulton
03:30 am Feature Request #3536 (Closed): Remove controller method parameters
This behavior is confusing to beginners and even advanced users. We should recommend all users use $this->request->pa... Jeremy Bush
03:15 am Userguide Bug Report #3535 (Closed): Typo in API view when no class methods
The API Browser currently shows "one" rather than "None" under the methods column when the class has no methods. Andrew Coulton
03:13 am Userguide Feature Request #3486: Show what interfaces a class implements
Implemented in https://github.com/kohana/userguide/pull/11 - nothing particularly special in the styling, but it works. Andrew Coulton
02:48 am Revision e7b1d186: Tracking system submodule
Jeremy Bush
02:46 am Core Revision c7c097b0: Merge fallout
Jeremy Bush
02:42 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Have:
* Updated branch name to new pattern (3.2/feature/3529-exclude-configurable-transparent-classes).
* Created uni...
Andrew Coulton
02:30 am Revision 30498cd0: Tracking system for release branch
Jeremy Bush
02:28 am Userguide Patch #3534 (Closed): User guide CSS updates
Updated jQuery, fixed an overflow auto from adding scrollbar to footer, changed the grays for the code background col... Joel Pittet
02:26 am Core Revision 703217fb: Fixing merge fallout
Jeremy Bush
02:26 am Userguide Revision c578da14: Updated jQuery, fixed an overflow auto from adding scrollbar to footer, change...
Joel Pittet
02:12 am Revision c651291a: Updating build.xml to reference the new branch naming scheme
Kiall Mac Innes
01:52 am Revision b9e2ecb2: updating readme for the master branch
Jeremy Bush
01:44 am Revision e728f596: Merge remote branch 'origin/3.1.x' into 3.1.x
Jeremy Bush
01:43 am Revision 5d9e9ffc: tracking 3.1 system dir
Jeremy Bush
01:39 am Core Revision f001bc73: Merge remote branch 'origin/3.1/develop' into 3.1/develop
Jeremy Bush
01:36 am Core Revision e7f33744: Merge branch '3.0/develop' into 3.1/develop
Conflicts:
classes/kohana/controller.php
classes/kohana/core.php
classes/kohana/log.php
classes/kohana/log/stderr...
Jeremy Bush
01:11 am Patch #3533 (Closed): Comments and core guide changes for 3.1.0
Updated some copyright to 2011. Fixed a comment for response->body() and all the docs related to $this->request->resp... Joel Pittet

01/02/2011

09:16 pm ORM Feature Request #3246: Added a function to return primary value.
I think we should just remove ORM::$_primary_val Isaiah DeRose-Wilson
09:14 pm ORM Feature Request #3532 (Closed): ORM should extend the Model class
ORM should extend the model class to make using it more transparent by allowing you to do instanceof Model or Model::... Isaiah DeRose-Wilson
07:26 pm Core Revision 35075cbb: Code cleanup, Refs #3506
Isaiah DeRose-Wilson
06:26 pm Bug Report #3531 (Closed): Response body should be converted into string only when output is gene...
We discussed this at great length, and decided it was best if it was converted to a string when setting the body. Jeremy Bush
05:26 pm Bug Report #3531 (Closed): Response body should be converted into string only when output is gene...
Hi All,
I think the @Response::body()@ method should not convert it's parameter into a string, maybe it is needed ...
Bence Eros
03:43 pm Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Fair enough - wasn't sure if that was the case for the submodules too - good to have confirmation.
Have looked fur...
Andrew Coulton
10:35 am Feature Request #3530 (Closed): Subdomain method added to Request class
Method to get the current subdomain name (alt. false if no subdomain).
Something like this:
// Request::subdomai...
Jonas Nyström
06:25 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
We aren't accepting new features in 3.0 or 3.1, so this is moving to 3.2. Jeremy Bush
02:20 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Implemented at https://github.com/acoulton/userguide/tree/3.2%2Ffeature%2F3529-exclude-configurable-transparent-class... Andrew Coulton
02:12 am Userguide Feature Request #3529 (Closed): Configurable transparent extension prefixes in API browser
Currently, KoDoc automatically excludes classes beginning with Kohana_ so that the API browser isn't cluttered with t... Andrew Coulton
02:03 am Bug Report #3528 (Closed): debug_source should ignore "Unknown" files
As per http://forum.kohanaframework.org/discussion/7714/intermittant-is_readable-open_basedir-error, the debug_source... Daniel Lo Nigro
01:30 am Bug Report #3527 (Closed): bootstrap should use getenv ranter than $_ENV
Applied in changeset commit:"8b8c569177eff6efb884fae9f8fa4eb2af68170a". Isaiah DeRose-Wilson
01:27 am Revision 8b8c5691: Replaced $_ENV['KOHANA_ENV'] with getenv('KOHANA_ENV'). Fixes #3527
Isaiah DeRose-Wilson

01/01/2011

07:39 pm Bug Report #3527: bootstrap should use getenv ranter than $_ENV
Seems like 3.1 branch has this
https://github.com/kohana/kohana/blob/3.1-RC1/application/bootstrap.php#L62-65
Dmitry T.
06:56 pm Bug Report #3527 (Assigned): bootstrap should use getenv ranter than $_ENV
Jeremy Bush
10:18 am Bug Report #3527 (Closed): bootstrap should use getenv ranter than $_ENV
The bootstrap should be using @getenv()@ rather than @$_ENV@ as @$_ENV@ is rarely set in a production environment.
...
Brandon Summers
12:03 am Bug Report #3526 (Closed): Wrong Kohana version
When use Kohana 3.0.9... Mulia Arifandy Nasution

12/31/2010

09:38 pm Revision 3e9fc446: updating readme for 3.1
Jeremy Bush
09:30 pm Revision 8bfabf79: Tracking new submodule branches. Removing oauth and pagination from 3.1
Jeremy Bush
08:16 pm Revision abf82d46: Merge remote branch 'origin/3.1.x' into 3.1.x
Conflicts:
system
Jeremy Bush
08:14 pm Revision a204ad01: Tracking system submodule for 3.1 rc1
Jeremy Bush
07:47 pm Core Revision 05c8512b: Required route parameters should output from uri(). Fixes #3015
Jeremy Bush
07:41 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters
Fixed and tested by https://github.com/kohana/core/commit/05c8512b86369e8913ce7dd1822b42af4df83bdd. Jeremy Bush
06:16 pm Revision 205d6f4d: Updating system
Isaiah DeRose-Wilson
06:15 pm Core Revision 2aa872b4: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
06:15 pm Core Revision 9d6eedec: Added tests for Kohana::$expose, fixes #2269
Isaiah DeRose-Wilson
06:09 pm Feature Request #2269 (Closed): X-Powered-By
Tested by "9d6eedecad...":https://github.com/kohana/core/commit/9d6eedecad7afb78211cb01c1967a6a3f1db0ad1 Isaiah DeRose-Wilson
05:39 pm Database Feature Request #2009: Implement or_on() in Database
There should be a better way to do this. Do we need to support parentheses too? This should probably be done like the... Isaiah DeRose-Wilson
04:34 pm Core Revision 82b87a6b: More secure Security::token, hashing the generated uniqid(), fixes #3437
Woody Gilk
04:29 pm Core Revision 83e29859: Fixed issue that prevented local View variables from taking precendence over g...
Woody Gilk
04:28 pm Bug Report #3437 (Closed): CSRF token does not need a prefix
Fixed by https://github.com/kohana/core/commit/82b87a6b2c4587eab301775f0e57b21a4de97221 Woody Gilk
04:23 pm Core Revision cc6e0ed1: Add status code to the exception in Remote::get, fixes #3477
Woody Gilk
04:23 pm Bug Report #3450 (Closed): Have local variables override global in Kohana_View
Fixed by https://github.com/kohana/core/commit/83e298593dba3927a198a6b558f327ff97b00f68 Woody Gilk
04:19 pm Core Revision 60c8cd77: Added iPad and iPod to mobile user agents, fixes #3463
Woody Gilk
04:17 pm Feature Request #3477 (Closed): Remote Exception codes
Fixed by https://github.com/kohana/core/commit/cc6e0ed1344466787df4519f747fd504e0899b12 Woody Gilk
04:15 pm Core Revision bfdfc8e5: Make the removal of spaces in Upload::save() UTF-8 safe, fixes #3460
Woody Gilk
04:13 pm Core Revision 22801e01: Added tests for 74f1be84ac44cac479fec27d1e59a9bb22385a64, refs #3496
Woody Gilk
04:12 pm Bug Report #3463 (Closed): User agents is missing mobile detection of ipod touch and ipad
Fixed by https://github.com/kohana/core/commit/60c8cd7755375cd8f989cbe29ef88b6a0ae30b0e Woody Gilk
04:11 pm Core Revision 74f1be84: Added more uncountable words to Inflector configuration, fixes #3496
Woody Gilk
04:09 pm Bug Report #3460 (Closed): Upload::save() UTF-8 problem
Fixed by https://github.com/kohana/core/commit/bfdfc8e57ba6cee1e4709536742a120e546d64f1 Woody Gilk
04:07 pm Bug Report #3496 (Closed): Uncountable words for inflector config
Tested by https://github.com/kohana/core/commit/22801e014f638f1a5245ee2f2823ae9230012f2e Woody Gilk
04:05 pm Bug Report #3496 (Needs Test): Uncountable words for inflector config
Fixed by https://github.com/kohana/core/commit/74f1be84ac44cac479fec27d1e59a9bb22385a64 Woody Gilk
03:29 pm Bug Report #3525 (Needs Test): Header Value incorrect parsing of user agent entry
Isaiah DeRose-Wilson
12:00 pm Bug Report #3525 (Closed): Header Value incorrect parsing of user agent entry
Applied in changeset commit:"ec816385cba405144bf3b4db4abd8c1acac1a7b2". Sam de Freyssinet
11:54 am Core Revision ec816385: Fixes #3525, handles the user-agent header without parsing
Sam de Freyssinet
11:34 am Bug Report #3525 (Closed): Header Value incorrect parsing of user agent entry
The User-Agent header field is being parsed incorrectly, separating the string on @;@ character. This is incorrect.
...
Sam de Freyssinet
04:57 am Revision c270d406: Updating system
Isaiah DeRose-Wilson
04:51 am Core Revision 928c6ff9: Merging in 3.0.x branch
Isaiah DeRose-Wilson
01:53 am Bug Report #3015 (Assigned): Reverse routing should not include the default parameters
Jeremy Bush
01:25 am Core Revision c5471e3e: Arr::set_path cleanup. Refs 2566918b5748ea3f0a05
Isaiah DeRose-Wilson
01:23 am ORM Bug Report #3524 (Closed): find() and find_all() should throw exceptions when the model is loaded
This causes quite a few bugs and is very confusing. The change will make it required to call clear() on any loaded ob... Lorenzo Pisani
01:20 am Core Revision 7398b430: Validation docs cleanup. Refs ac7e555c104e664177e4
Isaiah DeRose-Wilson
01:14 am ORM Revision e62f93e5: cleaning up some code conventions and simplifying recent code changes
Isaiah DeRose-Wilson
01:01 am ORM Revision c27802a3: preventing ORM from running multiple queries for the same related model in __g...
Lorenzo Pisani
01:01 am ORM Revision 65ec0f1f: allowing ORM::has() to check by primary key and look for many related rows at ...
Lorenzo Pisani
12:56 am ORM Bug Report #3066 (Closed): ORM overwrites related objects if they are not loaded
Fixed by "c27802a3...":https://github.com/kohana/orm/commit/c27802a3dbf34c174d2a1fc7b6ad55f3eb53c142 Isaiah DeRose-Wilson
12:55 am ORM Feature Request #2992 (Closed): ORM::has() for multiple objects
Fixed by "65ec0f1f11...":https://github.com/kohana/orm/commit/65ec0f1f11fa80dce899c4e1ac9ebdb83c1cfe95 Isaiah DeRose-Wilson
12:48 am Revision 5d0e85f2: Merge branch '3.1.x' of github.com:kohana/kohana into 3.1.x
Isaiah DeRose-Wilson
12:48 am Revision ae1afb13: Updating system. Removed unittest module for phpcs checks because it doesn't f...
Isaiah DeRose-Wilson
12:46 am ORM Bug Report #3457: count_all does not use $_load_with
That bug should have been fixed by #3522 Isaiah DeRose-Wilson

12/30/2010

11:54 pm Core Revision 992d8ee7: Merge remote branch 'origin/3.1.x' into 3.1.x
Jeremy Bush
11:50 pm ORM Revision 7a11581d: Removed default order by. Fixes #3523
Isaiah DeRose-Wilson
11:45 pm ORM Feature Request #3523 (Closed): Remove default order by
Applied in changeset commit:"7a11581db7758f68509e46dcd9934aec847afab9". Isaiah DeRose-Wilson
11:43 pm ORM Feature Request #3523 (Closed): Remove default order by
We should remove the default order by. If you want a default for a model it can be specified in ORM::$_sorting Isaiah DeRose-Wilson
11:36 pm ORM Bug Report #3522: The primary key is ambiguous when using with()
Fixed by "8521f557...":https://github.com/kohana/orm/commit/8521f5570b90507e8b3bbdd48e5cf0c49a2b3032 Isaiah DeRose-Wilson
11:34 pm ORM Revision 6be1f831: Merge branch '3.1.x' of github.com:kohana/orm into 3.1.x
Isaiah DeRose-Wilson
11:33 pm ORM Revision 8521f557: Added table name to where for primary key, fixes #3522
Isaiah DeRose-Wilson
11:31 pm Core Revision ac7e555c: Adding better example for validation rules
Jeremy Bush
11:30 pm ORM Bug Report #3522 (Closed): The primary key is ambiguous when using with()
Applied in changeset commit:"8521f5570b90507e8b3bbdd48e5cf0c49a2b3032". Isaiah DeRose-Wilson
11:27 pm Core Revision e93d2378: Fix bug in determining action, Refs #3099
Jeremy Bush
11:24 pm ORM Bug Report #3522 (Closed): The primary key is ambiguous when using with()
When using with() the where for the primary key is ambiguous because it doesn't include the table name. Isaiah DeRose-Wilson
10:29 pm Core Revision 82eb595e: "CHecks" should be "Checks"
Andrew Ellis
10:27 pm Feature Request #2893: Use proper phpdoc @param and @return type hints
Merged in Andrew's change (pull 60) https://github.com/kohana/core/commit/82eb595e8bcdef3cf160d6068f2d18fbfd767919 Matt Button
10:01 pm Feature Request #2893: Use proper phpdoc @param and @return type hints
GitHub Pull Request: https://github.com/kohana/core/pull/60
Changed "CHecks" to "Checks"
Andrew Ellis
09:09 pm Codebench Revision 1a63103a: Merge branch '3.0.x' into 3.1.x
Matt Button
09:09 pm Cache Revision 1a63103a: Merge branch '3.0.x' into 3.1.x
Matt Button
09:07 pm Codebench Revision c3116853: Merge branch '3.0.x' of https://github.com/bobeagan/codebench into 3.0.x
Matt Button
09:07 pm Cache Revision c3116853: Merge branch '3.0.x' of https://github.com/bobeagan/codebench into 3.0.x
Matt Button
08:58 pm Auth Feature Request #3103: 'remember' option on force login
Why 3.0.9.1? This commit was created 23 hours ago. Ivan Brotkin
08:49 pm Core Revision c6cc033f: Removing final, private constructor in Kohana_HTTP
Matt Button
08:44 pm Bug Report #3518 (Closed): Coding standard does not allow for empty methods
Matt Button
08:44 pm Auth Bug Report #3217 (Closed): logged_in doesn't really check arrays
Implemented in "16c86107":https://github.com/kohana/auth/commit/16c86107c0e6cc2a94a87d7faf32a7bb757b3412 Ivan Brotkin
08:44 pm Bug Report #3518: Coding standard does not allow for empty methods
Removed the private constructor.
https://github.com/kohana/core/commit/c6cc033f1e14294bf7b322cfebbea176e1f6566f
Matt Button
08:42 pm Auth Feature Request #3103: 'remember' option on force login
Oops, my mistake. Implemented in "d950cbfff":https://github.com/kohana/auth/commit/d950cbfff525a3a252b0ffabe506b02697... Ivan Brotkin
08:40 pm Userguide Bug Report #3197 (Closed): debugging.errors formatting doesn't work
Fixed by https://github.com/kohana/userguide/commit/7e60f6da7010d219367d11167ffceb27712549f2 Woody Gilk
08:24 pm kohana-3.0.9.zip
Woody Gilk
08:24 pm Revision 183938c2: Tracking submodules
Woody Gilk
08:23 pm Core Revision fe2bc592: Merge branch '3.0.x'
Woody Gilk
08:23 pm Core Revision d57cd5bb: Updated the version and codename for 3.0.9
Woody Gilk
08:16 pm Feature Request #2530: Get all configs loaded (config cache)
What's the use case behind this? I can't see it speeding up @load($group)@ as you'll be loading config that you might... Matt Button
07:49 pm Feature Request #2530: Get all configs loaded (config cache)
Going to push this to 3.2 when we hopefully will do the config rewrite. Jeremy Bush
07:37 pm Revision 3688f0d4: Merge branch '3.0.x' in preparation for 3.0.9 release
Conflicts:
modules/cache
system
Woody Gilk
07:33 pm Core Revision 1dd4bd33: Merge branch '3.0.x'
Woody Gilk
07:32 pm Userguide Revision 2193dfbf: Merge branch '3.0.x'
Woody Gilk
07:32 pm UnitTest Revision f86566d3: Merge branch '3.0.x'
Woody Gilk
07:32 pm ORM Revision 7edd666d: Merge branch '3.0.x'
Woody Gilk
07:31 pm OAuth Revision 21bbf29e: Merge branch '3.0.x'
Woody Gilk
07:31 pm Image Revision 6d15f8e8: Merge branch '3.0.x'
Woody Gilk
07:31 pm Codebench Revision aa1a5808: Merge branch '3.0.x'
Woody Gilk
07:30 pm Database Revision 5b522aeb: Merge branch '3.0.x'
Woody Gilk
07:30 pm Cache Revision 9ecc8f2e: Merge branch '3.0.x'
Conflicts:
classes/kohana/cache/file.php
classes/kohana/cache/memcache.php
Woody Gilk
07:27 pm Auth Revision 653963a2: Merge branch '3.0.x'
Conflicts:
classes/kohana/auth/orm.php
Woody Gilk
07:24 pm Revision 4012c4ce: Merge branch '3.0.x' of git://github.com/kohana/kohana into 3.0.x
Woody Gilk
07:23 pm Revision 0b888c0c: Tracking submodules
Woody Gilk
07:00 pm ORM Feature Request #2992: ORM::has() for multiple objects
https://github.com/kohana/orm/pull/16 Lorenzo Pisani
07:00 pm ORM Bug Report #3066: ORM overwrites related objects if they are not loaded
https://github.com/kohana/orm/pull/16 Lorenzo Pisani
06:57 pm ORM Bug Report #3457: count_all does not use $_load_with
I'm having issues with this... 3.1.x _load_with does not seem to work... switching to 3.0.x works fine.
This is th...
Lorenzo Pisani
06:47 pm Bug Report #3515 (Closed): Invalid or poorly defined standard for multiline return statement
The commit has since been reverted Matt Button
06:45 pm Cache Revision 17bcd541: fixing coding standards violation: Single-line if statements should only be us...
Bob Eagan
06:45 pm Codebench Revision 17bcd541: fixing coding standards violation: Single-line if statements should only be us...
Bob Eagan
06:40 pm Cache Revision 59282f7c: fixing coding standards violation: Single-line if statements should only be us...
Bob Eagan
06:40 pm Codebench Revision 59282f7c: fixing coding standards violation: Single-line if statements should only be us...
Bob Eagan
06:40 pm Revision 1064b3ed: Fixing bug in unittest module
Matt Button
06:39 pm UnitTest Revision 5edab575: Fixing typo
Matt Button
06:39 pm Cache Revision 3903b984: fixing coding standard violations: Typecast operators must have a space on eit...
Bob Eagan
06:39 pm Codebench Revision 3903b984: fixing coding standard violations: Typecast operators must have a space on eit...
Bob Eagan
06:37 pm Codebench Revision 61711d25: fixing coding standards: Comparisons and operations must be in parentheses in ...
Bob Eagan
06:37 pm Cache Revision 61711d25: fixing coding standards: Comparisons and operations must be in parentheses in ...
Bob Eagan
06:36 pm Bug Report #3521 (Closed): PHPUnit Warnings
Fixed in unittest module (3.1.x) https://github.com/kohana/unittest/commit/078ee86d89f8339400907f7c8af0c5edffddf243 (... Matt Button
06:29 pm Database Bug Report #2935: MySQL :: Cannot connect to database after disconnect
For correct reconnect to database we should delete database instance after disconnect:... Michał Wadowski
06:23 pm Revision 6f121d56: Updating submodules
Matt Button
06:20 pm Revision d1b30936: Updating submodules
Matt Button
06:20 pm ORM Revision 982867e6: Merge branch '3.1.x' of github.com:kohana/orm into 3.1.x
Matt Button
06:18 pm Core Revision 7aaf868d: Updating tests to be compatible with PHPUnit 3.5
Matt Button
06:08 pm Core Revision 520d16de: Updating tests to be compatible with PHPUnit 3.5
Matt Button
06:06 pm UnitTest Revision a9e294d6: Adding compatability layer for phpunit 3.5 type assertions
Matt Button
06:04 pm UnitTest Revision 078ee86d: Adding compatability layer for phpunit 3.5 type assertions
Matt Button
05:04 pm Core Revision 1c0332f2: Added tests for 6709e84e6e5bbcefd0588a34b803bac19255313c, refs #3500
Woody Gilk
04:58 pm Bug Report #3500 (Closed): Incorrect handling of attributes without values in HTML::attributes
Test added in https://github.com/kohana/core/commit/1c0332f294d25c081b2c1c8ff5ca7d12f7f6e040 Woody Gilk
04:45 pm Core Revision 6670f21a: Updated cascading filesystem graphic
Woody Gilk
04:34 pm Bug Report #3521 (Closed): PHPUnit Warnings
After upgrading to PHPUnit 3.5, I am seeing a lot of warnings:
> assertType() will be removed in PHPUnit 3.6 and s...
Woody Gilk
04:28 pm Feature Request #3308 (Closed): Arr::set_path() function
Fixed by "2566918b574...":https://github.com/kohana/core/commit/2566918b5748ea3f0a05d4d62d0a90d1fdf1e50a Isaiah DeRose-Wilson
04:24 pm Revision f8030532: Updating submodules
Isaiah DeRose-Wilson
04:22 pm Core Revision e39ab5f9: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
04:22 pm Core Revision 2566918b: Added Arr::set_path() method. Fixes #3308 Tests included.
Isaiah DeRose-Wilson
02:18 pm Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
Michael Mior wrote:
> I understand that Woody, but it IS valid HTML5. By making the change in this way, you're makin...
Chris Smith
10:14 am Revision aabaf3db: Merge branch '3.0.x' of git://github.com/kohana/kohana into 3.0.x
Woody Gilk
10:13 am Revision 6114cc55: Tracking submodules
Woody Gilk
10:13 am Userguide Revision 72f02e8a: Merge branch 'docs' into 3.0.x
Conflicts:
views/userguide/api/class.php
Woody Gilk
10:08 am Cache Revision 8873f935: Docs cleanup: cache/usage
Woody Gilk
10:05 am Core Revision 729358de: Docs cleanup: kohana/tutorials/clean-urls
Woody Gilk
09:54 am Core Revision 249edc57: Docs cleanup: kohana/routing
Woody Gilk
09:48 am Core Revision cd8bf047: Docs cleanup: kohana/security/validation
Woody Gilk
09:46 am Core Revision a5b222b7: Docs cleanup: kohana/security/xss
Woody Gilk
09:43 am Core Revision 4fc6fcf9: Docs cleanup: kohana/errors
Woody Gilk
09:42 am Userguide Revision 7e60f6da: When loading views with Markdown, render the exception if loading the view fai...
Woody Gilk
09:34 am Core Revision 64e40058: Docs cleanup: kohana/upgrading
Woody Gilk
09:30 am Userguide Revision fa525c54: Tweaking the "link to this" header anchors
Woody Gilk
05:47 am Userguide Revision 64a65c5f: Scrolling side menu is annoying.
Woody Gilk
05:45 am Userguide Revision ed29b70e: Remove toggling the page TOC, it really doesn't add anything benefical to the ...
Woody Gilk
05:04 am ORM Revision 96a77a5b: Fixed issue with wildcard rules/filters/callbacks in ORM. Fixes #2962
Isaiah DeRose-Wilson
05:01 am ORM Bug Report #3002 (Closed): ORM doesnt filter Validate rules for missing fields
Isaiah DeRose-Wilson
04:59 am ORM Bug Report #2962 (Closed): ORM: Validation with TRUE filters adds empty properties visible when d...
Fixed by "96a77a5b...":https://github.com/kohana/orm/commit/96a77a5bab5af4800445b5c4226607e85818cdfa Isaiah DeRose-Wilson
04:58 am ORM Revision 370e3366: Updating phpdoc comments, refs #3489
Isaiah DeRose-Wilson
04:55 am Userguide Revision 05a11bf2: Moved page TOC to just above the first <p>, so that the first header starts th...
Woody Gilk
04:46 am ORM Bug Report #3145 (Assigned): ORM one-to-one reference set through values() call is not saved
Isaiah DeRose-Wilson
04:33 am ORM Bug Report #2903 (Closed): orm function with a bit incorrect behaviour
I'm not seeing the problem here. Your example works fine. ORM will add select($this->_table_name.'.*') to the query s... Isaiah DeRose-Wilson
04:26 am ORM Bug Report #3318 (Closed): ORM as_array() after a find_all()
This is expected behavior. After calling find_all() you are using a database result object, so the as_array() method ... Isaiah DeRose-Wilson
04:21 am ORM Bug Report #2904 (Closed): has_many + through with pdo adapter
ORM already does a select tablename.* for select queries. Maybe this was fixed a while back and never closed. I don't... Isaiah DeRose-Wilson
04:16 am Core Revision b41cc008: Docs cleanup: kohana/index
Woody Gilk
03:52 am Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
As stated previously, Kohana targets XHTML, not HTML. Woody Gilk
03:46 am ORM Bug Report #2958 (Closed): ORM not loading values when using has_many "through" relationships.
Does this problem still exist? I looked at your patch but I'm not really sure I see what the issue is or what you are... Isaiah DeRose-Wilson
03:43 am ORM Feature Request #3113 (Closed): ORM adds 'ORDER BY id ASC' although id column doesn't exist
Isaiah DeRose-Wilson

12/29/2010

11:44 pm ORM Revision 5b8a1377: Fixed comments for ORM::remove()
Isaiah DeRose-Wilson
11:42 pm ORM Revision 7bbe98d4: Merge branch 'feature/simplify-api' into 3.1.x
Isaiah DeRose-Wilson
11:30 pm ORM Revision 81dc8f7e: fixing more references to the old Validate class
Isaiah DeRose-Wilson
11:26 pm ORM Feature Request #2754 (Closed): [ORM] changes to validation
Validation changes finished by "81dc8f7e970b9...":https://github.com/kohana/orm/commit/81dc8f7e970b935a94e02c0a34373f... Isaiah DeRose-Wilson
11:25 pm ORM Revision 0f570925: Fixed comments for ORM::remove()
Isaiah DeRose-Wilson
10:29 pm ORM Bug Report #3242 (Closed): ORM __wakeup() needs to clear _db
I'm moving this to 3.1.x because it's really an api change. Fixed by "8b44bcae...":https://github.com/kohana/orm/comm... Isaiah DeRose-Wilson
10:26 pm ORM Feature Request #2992: ORM::has() for multiple objects
I think we should only support "and_has", i.e. all the ids must be valid. Isaiah DeRose-Wilson
10:25 pm ORM Feature Request #2992 (Assigned): ORM::has() for multiple objects
What if we used the new syntax that add/remove use, and allowed you to pass in an array of ids. It could run one quer... Isaiah DeRose-Wilson
10:22 pm ORM Bug Report #3066 (Assigned): ORM overwrites related objects if they are not loaded
I'm okay with removing the loaded check. Can you please create a pull request for this? Thanks! Isaiah DeRose-Wilson
10:19 pm ORM Bug Report #3457 (Assigned): count_all does not use $_load_with
Isaiah DeRose-Wilson
10:18 pm ORM Feature Request #2913 (Closed): Empty save for insert()
This is a feature request and a behavior change so I think it would be better to just apply it in 3.1.x even know the... Isaiah DeRose-Wilson
10:15 pm ORM Feature Request #3202 (Closed): Allow ORM::remove() to delete all relationships
Fixed by "0339effb17...":https://github.com/kohana/orm/commit/0339effb173b9d763bd29fd9416167ba96ba735f Isaiah DeRose-Wilson
10:15 pm ORM Revision fef42a7f: documenting all the usages of add() and remove()
Lorenzo Pisani
10:14 pm ORM Revision e1be4f0d: allowing removal of multiple relationships with arrays of primary keys remove(...
Lorenzo Pisani
10:14 pm ORM Feature Request #3489 (Closed): Add updated and created columns to properties array
Fixed by "a3841077...":https://github.com/kohana/orm/commit/a3841077e69b3351f062cfa8a2d10ff8ea08dca5 Isaiah DeRose-Wilson
10:14 pm ORM Revision dc586e7d: add() now takes a more flexible second parameter. It can either be a model ins...
Lorenzo Pisani
10:14 pm ORM Revision cc56a3df: renaming all occurances of _validate with _validation
Lorenzo Pisani
10:14 pm ORM Revision 44ea554b: removing $data parameter from ORM::add(), this breaks the idea of models valid...
If your pivot table has data in it, it is technically not a 'pivot' table.
The proper way to use these tables is to c...
Lorenzo Pisani
10:14 pm ORM Revision a3841077: added updated_column and created_column to $_properties (fixes #3489)
Lorenzo Pisani
10:14 pm ORM Revision 0339effb: allowing the removal of all related objects with one query by using remove('al...
Lorenzo Pisani
10:13 pm ORM Revision efa48d54: removing unused properties for old validation
Lorenzo Pisani
10:13 pm ORM Revision ef5663fd: removing callbacks code as they no longer exist in Validation
Lorenzo Pisani
10:13 pm ORM Feature Request #2254 (Closed): Add support for using array syntax for many-to-many add/updates
Fixed by "dc586e7d3...":https://github.com/kohana/orm/commit/dc586e7d3adcebb75fa91ca59fd845495167445a Isaiah DeRose-Wilson
09:48 pm Auth Revision 16c86107: define strict level for logged_in() role checks, implements #3217
Ivan Brotkin
09:45 pm Auth Revision f9106fc6: cookie/session flags must have configurable names, fixes #3154
Ivan Brotkin
09:45 pm Auth Bug Report #3154 (Closed): authautologin cookie
Applied in changeset commit:"f9106fc6d80e37ab514703ef8d40820d40a0c8a2". Ivan Brotkin
09:41 pm Auth Revision d950cbff: create separated remember() method, implements #3103
Ivan Brotkin
09:40 pm Revision abeccd87: fixing coding standards: incorrect usage of single line statements
Bob Eagan
09:37 pm Bug Report #3519 (Closed): Pull requests for fixing coding standards in various repos
Thanks Bob. I applied these pull requests. Most of them were applied to the 3.0.x branch. These changes will be added... Isaiah DeRose-Wilson
09:34 pm Core Revision a7afd13f: fixing coding standard violation: No space is allowed after concatenation oper...
Bob Eagan
09:34 pm Core Revision 398c6e49: fixing coding standard violation: elseif should be used rather than else if
Bob Eagan
09:33 pm Codebench Revision 63cbb348: fixing coding standards: Comparisons and operations must be in parentheses in ...
Bob Eagan
09:33 pm Cache Revision 63cbb348: fixing coding standards: Comparisons and operations must be in parentheses in ...
Bob Eagan
09:33 pm UnitTest Revision 56c5ab0e: fixing coding standards: incorrect usage of single line statements
Bob Eagan
09:32 pm Userguide Revision ea28aa54: fixing coding standards: incorrect usage of single line statements
Bob Eagan
09:21 pm Database Revision 9c86dc67: Added examples to DB::expr()
Jose Albornoz
09:20 pm Feature Request #2290: SESSION, $_POST, $_GET, $_COOKIE in Profiler
I'm bumping this back because we are planning lots of profiler changes in 3.2 and this would be a good thing to inclu... Isaiah DeRose-Wilson
09:16 pm Patch #3517 (Closed): Pull Request on github. kohana/database
Fixed by "9c86dc67d9...":https://github.com/kohana/database/commit/9c86dc67d9cd1bb5315a5aadfd338372ca2fcc14 Isaiah DeRose-Wilson
08:38 pm ORM Feature Request #3520 (Assigned): Allow a database connection to be injected into an ORM model
In order to properly test a model you should be inject a database connection into it, something like:... Matt Button
08:28 pm Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
Just write your html in your template, the way it's supposed to be done, and have anything you want :)
If it were ...
Jeremy Bush
08:03 pm Bug Report #3519 (Closed): Pull requests for fixing coding standards in various repos
https://github.com/kohana/core/pull/59
https://github.com/kohana/codebench/pull/2
https://github.com/kohana/use...
Bob Eagan
08:02 pm Bug Report #3518 (Closed): Coding standard does not allow for empty methods
final private function __construct() {}
Is throwing violation for: Opening brace should be on a new line
Bob Eagan
07:50 pm Codebench Revision 7ae99cd8: fixing coding standards: Comparisons and operations must be in parentheses in ...
Bob Eagan
07:48 pm Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
I understand that Woody, but it IS valid HTML5. By making the change in this way, you're making it impossible for peo... Michael Mior
07:39 pm Patch #3517 (Closed): Pull Request on github. kohana/database
I forked database on github and added a few examples for DB::expr().
I did a pull request.
https://github.com/kohan...
Jose Albornoz
07:30 pm Feature Request #3516 (Feedback): Add Logs plus "custom" debug output to the profiler
See #3508 for the details.. Specifically "this":http://dev.kohanaframework.org/issues/3508#note-2 comment
Adding t...
Kiall Mac Innes
07:17 pm UnitTest Revision 8488b0a1: Adding method to get a kohana_database connection to the test db
Matt Button
07:17 pm UnitTest Revision fb5f7cdb: Adding method to get a kohana_database connection to the test db
Matt Button
07:08 pm UnitTest Revision e4fbd088: Adding Database TestCase
Matt Button
07:08 pm UnitTest Revision c91f2f74: Adding Database TestCase
Matt Button
06:53 pm Bug Report #3513 (Closed): Blank line in switch case should be ignored
Matt Button
06:53 pm Bug Report #3513: Blank line in switch case should be ignored
Fixed in https://github.com/kohana/coding-standards/commit/3cc493fb93984630186bd4d94d9171527530d07c
Includes test
Matt Button
06:32 pm Bug Report #3513: Blank line in switch case should be ignored
Blank lines should never be indented. Jeremy Bush
06:30 pm Bug Report #3500 (Needs Test): Incorrect handling of attributes without values in HTML::attributes
Jeremy Bush
06:27 pm Bug Report #3513: Blank line in switch case should be ignored
Correct, see here where the violation is being reported:
http://ci.managedit.ie/job/Kohana.3.1.x/80/violations/fil...
Bob Eagan
06:17 pm Bug Report #3512 (Feedback): Conflicting standards dealing with whitespace
I usually do:... Matt Button
06:15 pm Bug Report #3513: Blank line in switch case should be ignored
So phpcs is complaining the blank line isn't indented? Matt Button
06:10 pm Core Revision 3a478454: Refs #3364, used jeremeamias implementation which is neater. Thanx
Sam de Freyssinet
06:07 pm Bug Report #3000: Config system rewrite
Pushing back to 3.2 Matt Button
05:59 pm Core Revision f2f0104e: Refs #3506, applied fixes and tidied up the code
Sam de Freyssinet
05:55 pm Bug Report #3511 (Closed): Typos in readme of coding standards repo
Fixed in https://github.com/kohana/coding-standards/commit/f0b466664e0ad14a9099acbcb2490bbd7a887338 Matt Button
05:55 pm Core Revision 85cd844f: Refs #3506, restored the Request::is_ajax() method to silence the majority ;)
Sam de Freyssinet
05:35 pm Bug Report #3515 (Closed): Invalid or poorly defined standard for multiline return statement
http://ci.managedit.ie/job/Kohana.3.1.x/80/violations/file/system/classes/kohana/request.php/?#line457
A type cast...
Bob Eagan
05:31 pm Bug Report #3015: Reverse routing should not include the default parameters
I mean, what if the defaults contain parameters that are required for the URI? Eg, if I define a route such as @<acti... Woody Gilk
05:17 pm Revision bfd089f1: Updating submodules
Isaiah DeRose-Wilson
05:02 pm Database Revision dfdb8154: Merge branch '3.1.x' of github.com:kohana/database into 3.1.x
Isaiah DeRose-Wilson
05:02 pm Database Revision cb4d061e: Changed query cache lifetime to allow 0 to invalidate the cache. Fixes #2883
Isaiah DeRose-Wilson
04:57 pm Bug Report #3401: Set Request::$client_ip from HTTP headers only if a trusted proxy set the header.
I agree on moving REMOTE_ADDR first. In regards to handling HTTP X_FORWARDED_FOR, general practice is to pop the last... Corey Ballou
04:57 pm Feature Request #2883 (Closed): Database_Query clearing cache
Fixed by "cb4d061e13dc9...":https://github.com/kohana/database/commit/cb4d061e13dc99e45dbbe9b3ed15eba4ee7061ae Isaiah DeRose-Wilson
04:51 pm Bug Report #3506: $referrer, $is_ajax and $protocol is set only localy
OK, my point was, that it should be mentioned somewhere. Michal Kocian
04:49 pm Bug Report #3015: Reverse routing should not include the default parameters
I don't understand what you mean. If there's missing required parameters, an exception will be thrown. It was a direc... Jeremy Bush
04:49 pm Bug Report #3506: $referrer, $is_ajax and $protocol is set only localy
Given it's non-standard implementation and potential for abuse, I have removed it. It is pretty simple to check for t... Sam de Freyssinet
04:43 pm Feature Request #2174 (Feedback): Route::uri should chop of the directory prefix from conroller n...
Cannot see a valid use case. Need more examples. Sam de Freyssinet
04:40 pm Bug Report #3506: $referrer, $is_ajax and $protocol is set only localy
So there won't be ajax detection any more? (I know it's not working on all servers) Michal Kocian
04:36 pm Core Revision af09554d: Refs #3503, shortened Response::delete_cookie() method to use blind operation ...
Sam de Freyssinet
04:31 pm Bug Report #3015 (Feedback): Reverse routing should not include the default parameters
What if the default parameters are required? I think this commit side steps the issue rather than fixing it properly. Woody Gilk
04:27 pm Core Revision ae94fb86: Followup to 1cb5bdf92961ddb613aaa8c96741e61456318b0a, throw a 404 if the contr...
Jeremy Bush
04:24 pm Bug Report #3500 (Closed): Incorrect handling of attributes without values in HTML::attributes
Woody Gilk
04:24 pm Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
Attributes without values are "not allowed in XHTML":http://www.w3.org/TR/xhtml1/#h-4.5. Woody Gilk
04:21 pm Bug Report #3514: Request::execute() is setting the 404 status incorrectly
here is my (bit hacky) quick fix for one of my projects: http://kohana.pastebin.com/BK9udR1Q
Suggest using class_e...
Lorenzo Pisani
04:18 pm Bug Report #3514 (Closed): Request::execute() is setting the 404 status incorrectly
The ReflectionException that is caught will also include the ones caused by the invoke() calls which should not be th... Lorenzo Pisani
04:10 pm Core Revision d0c36548: Followup to 1cb5bdf92961ddb613aaa8c96741e61456318b0a, throw a 404 if the actio...
Jeremy Bush
04:10 pm Bug Report #3513 (Closed): Blank line in switch case should be ignored
According to http://kohanaframework.org/guide/about.conventions the following is invalid because the blank line is no... Bob Eagan
04:02 pm Core Revision 2128dad8: Default parameters should not generate for Route::uri(), Fixes #3015
Jeremy Bush
03:56 pm Bug Report #3512 (Feedback): Conflicting standards dealing with whitespace
According to http://kohanaframework.org/guide/about.conventions which of these is correct?... Bob Eagan
03:56 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters
Fixed by https://github.com/kohana/core/commit/2128dad8172f858170ad06382bfb8d8f2aa50f53 Jeremy Bush
03:53 pm Bug Report #3511 (Closed): Typos in readme of coding standards repo
"These tests are meant to a guide and are may not be 100% accurate."
Should probably read something like:
"Thes...
Bob Eagan
03:43 pm Core Revision 71d5ac07: followup to 1cb5bdf92961ddb613aaa8c96741e61456318b0a, determine action after b...
Jeremy Bush
03:39 pm Feature Request #3249 (Closed): base.php file
Jeremy Bush
03:39 pm Bug Report #3500 (Feedback): Incorrect handling of attributes without values in HTML::attributes
The issue I have with this fix is that it takes away options from the users of the framework. If someone wants to use... Michael Mior
03:37 pm Core Revision 1cb5bdf9: Reverting 9dfbded765d2712658b52621ff91231d4345af3d, Fixes #3099
Jeremy Bush
03:31 pm Bug Report #3099 (Closed): Request::execute() should find all methods before executing any of them
Reverted by https://github.com/kohana/core/commit/1cb5bdf92961ddb613aaa8c96741e61456318b0a and 71d5ac07ab3fbea58e0a5e... Jeremy Bush
03:00 pm ORM Bug Report #3509: Overriding filters and rules set by TRUE key
Well, filter is removed in 3.1, and callback and rules are combined.
Either way, im not sure I like this suggestion.
Jeremy Bush
02:52 pm Bug Report #3506: $referrer, $is_ajax and $protocol is set only localy
I was sure I tagged it, but here is the commit https://github.com/kohana/core/commit/02b60ec952aecd3f333cdf9c38909842... Sam de Freyssinet
02:42 pm Feature Request #2864: Add an is_sub flag to the Request class
Please set as "fixed" Dmitry T.
02:20 pm Bug Report #3506: $referrer, $is_ajax and $protocol is set only localy
Is there a commit that fixes this? Jeremy Bush
02:18 pm Core Revision 6709e84e: HTML::attributes should treat values without keys as mirrored attributes, fixe...
Woody Gilk
02:11 pm Bug Report #3500 (Closed): Incorrect handling of attributes without values in HTML::attributes
Fixed by https://github.com/kohana/core/commit/6709e84e6e5bbcefd0588a34b803bac19255313c Woody Gilk
02:11 pm Bug Report #3500 (Assigned): Incorrect handling of attributes without values in HTML::attributes
Woody Gilk
02:04 pm Bug Report #3505 (Closed): Adjust the way default qualities are assigned to mime-types in Request...
Woody Gilk
02:04 pm Bug Report #3505: Adjust the way default qualities are assigned to mime-types in Request::_parse_...
The default for all "q" values is 1.0, as per RFC 2616 § 14.1, although this can be overloaded by setting @*/*; q=0.5... Woody Gilk
02:00 pm Feature Request #3364 (Closed): Detecting post_max_size exceeded errors
Applied in changeset commit:"cd1ed05e43a614623b0dd747bbe760e89e6dd312". Sam de Freyssinet
02:00 pm Feature Request #2864 (Closed): Add an is_sub flag to the Request class
Applied in changeset commit:"c2170af173ea69f3c75e393fbe3c259c6f7361dc". Sam de Freyssinet
01:59 pm Feature Request #1885 (Needs Test): Expires or ETag Support
I am writing the tests for this now. The logic is encapsulated into the Request_Client at the moment, so to use it yo... Sam de Freyssinet
01:53 pm Core Revision c2170af1: Fixes #2864, provides a way to test for initial/sub requests
Sam de Freyssinet
01:49 pm Core Revision cd1ed05e: Fixes #3364, included a test for post size exceeded into Request
Sam de Freyssinet
01:47 pm Feature Request #2138 (Closed): Handling of 404 (and other client errors)
Sam de Freyssinet
01:47 pm Bug Report #2755 (Closed): Request should be able to statically access headers
Sam de Freyssinet
01:33 pm Core Revision 8b4f9130: Fixes #3508, removed the forced application of response content length based o...
Sam de Freyssinet
01:32 pm Bug Report #3506 (Closed): $referrer, $is_ajax and $protocol is set only localy
Sam de Freyssinet
01:31 pm Bug Report #3459 (Closed): lambda call in header.php needs to be removed
Sam de Freyssinet
01:31 pm Bug Report #3301 (Closed): Kohana_Controller_REST and $this->request->method
Sam de Freyssinet
01:30 pm Bug Report #3508 (Closed): Content-Length header is set based on current Kohana::$environment
Applied in changeset commit:"8b4f913030389d25342c3906b67910c1d0184680". Sam de Freyssinet
01:30 pm Bug Report #3510 (Closed): RESTful request is assumed by defaul
Applied in changeset commit:"4fa23d13bd61393c609b8e7d90bedf8be22e5140". Sam de Freyssinet
01:25 pm Bug Report #3508: Content-Length header is set based on current Kohana::$environment
I like the argument Kiall makes regarding controlling output, baring in mind that the cli should also be accounted fo... Sam de Freyssinet
01:21 pm Core Revision 4fa23d13: Fixes #3510, lazy loads Request headers for initial request
Sam de Freyssinet
01:07 pm Bug Report #3510 (Closed): RESTful request is assumed by defaul
RESTful request is assumed by default? I think request is always just plain one, which don't need to take care what t... Sam de Freyssinet
01:05 pm ORM Bug Report #3509: Overriding filters and rules set by TRUE key
What I've put here is an ORM example but this is targeted to Kohana_Validate's callback(), filter() and rule() Kemal Delalic
01:03 pm ORM Bug Report #3509 (Rejected): Overriding filters and rules set by TRUE key
Say we have a table with.. 10 columns, where all except for one need .. 'UTF8::trim' callback.
At the moment we ca...
Kemal Delalic
01:01 pm Core Revision fac103fe: Fixes #3507, Request_Client_External no longer requires PECL_HTTP
Sam de Freyssinet
01:00 pm Bug Report #3507 (Closed): External requests don't work without PECL_HTTP
Applied in changeset commit:"fac103fe7620dadda50cfd753aca4e3606f81269". Sam de Freyssinet
12:46 pm Bug Report #3505: Adjust the way default qualities are assigned to mime-types in Request::_parse_...
Per RFC2616 § 3.9 the q value must be between the range of 0 and 1. I think if this gets accepted after the array is ... Chris Smith
11:56 am Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
Seems to me that either a non-associative array entry needs to be ignored or expanded to the 'foo="foo"' form. Chris Smith
02:50 am Bug Report #3508: Content-Length header is set based on current Kohana::$environment
I would do an if/else for setting the content length in the bootstrap that way the developer can decide what environm... Isaiah DeRose-Wilson
01:31 am Bug Report #3508: Content-Length header is set based on current Kohana::$environment
Another possible option.. (needs more thought .. specifically around CLI usage)
> <Kiall_> .. What about clearing ...
Kiall Mac Innes
01:10 am Bug Report #3508 (Closed): Content-Length header is set based on current Kohana::$environment
See https://github.com/kohana/core/commit/eb205543f0c9b6544e48752025511e7dbb66af49 for initial discussion..
My pro...
Kiall Mac Innes

12/28/2010

09:47 pm Bug Report #3507: External requests don't work without PECL_HTTP
"cd59677da3a":https://github.com/kohana/core/commit/cd59677da3a6302d14b41eb2d121c00331cceb01 is what created the issue. Isaiah DeRose-Wilson
08:53 pm Bug Report #3507 (Closed): External requests don't work without PECL_HTTP
HttpRequest constants are used in the Request_Client_External class so if you don't have the http extension installed... Isaiah DeRose-Wilson
08:00 pm Feature Request #2687 (Closed): Isolated request and response classes.
Applied in changeset commit:"d3ddb7d655bce814f2ed61701481265eaf304952". Sam de Freyssinet
07:59 pm Core Revision 42cbe051: Fixed Unit Tests for Request class
Fixes for #3506 Sam de Freyssinet
07:55 pm Feature Request #2687 (Assigned): Isolated request and response classes.
Sam de Freyssinet
07:09 pm Core Revision 5280c569: Tidied code in Route to meet coding standards and layout
Sam de Freyssinet
07:06 pm Core Revision d3ddb7d6: Fixes #2687, isolation moved to 3.2.0
Sam de Freyssinet

12/27/2010

07:18 pm Core Revision 5d70b35c: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
05:50 pm ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
@Stuart, I agree. This is something the database would be much better at enforcing and it can throw an exception that... Isaiah DeRose-Wilson
05:48 pm Feature Request #3068 (Closed): Get the current session id
Isaiah DeRose-Wilson
05:31 pm ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
There are a couple of problems with this. Firstly it is entirely possible that there is potential for concurrency iss... Stuart Harland
12:13 pm Bug Report #3506 (Closed): $referrer, $is_ajax and $protocol is set only localy
core / classes / kohana / request.php [Lines 79 - 95]... Michal Kocian
05:11 am Auth Feature Request #3103 (Feedback): 'remember' option on force login
This probably should be part of 3.1.x. The master branch is for releases only. This change should be reverted and app... Isaiah DeRose-Wilson
05:08 am Auth Bug Report #3154 (Feedback): authautologin cookie
This change should be applied to the 3.0.x branch, not the master branch. The master branch is _always_ that current ... Isaiah DeRose-Wilson
05:08 am Auth Bug Report #3217 (Feedback): logged_in doesn't really check arrays
This change should be applied to the 3.0.x branch, not the master branch. The master branch is _always_ that current ... Isaiah DeRose-Wilson

12/26/2010

09:35 pm Auth Revision 2a19b87f: define strict level for logged_in() role checks, implements #3217
Ivan Brotkin
09:30 pm Auth Bug Report #3217 (Closed): logged_in doesn't really check arrays
Use $all_required param, implemented in "2a19b87":https://github.com/kohana/auth/commit/2a19b87f07bc058cbc1709ccf55a1... Ivan Brotkin
09:15 pm Auth Bug Report #3154 (Closed): authautologin cookie
Applied in changeset commit:"38abe2e151edf78b6e7caedfe59b1637f6824647". Ivan Brotkin
09:10 pm Auth Revision 38abe2e1: cookie/session flags must have configurable names, fixes #3154
Ivan Brotkin
09:10 pm Auth Feature Request #3133: Marking forced logins should (at least) be optional
It was implemented "3 months":http://dev.kohanaframework.org/issues/3133#note-1 ago, whats wrong? Ivan Brotkin
09:07 pm Auth Feature Request #3103: 'remember' option on force login
You can remember user using special remember() method, implemented in "f6cd93765":https://github.com/kohana/auth/comm... Ivan Brotkin
09:05 pm Auth Bug Report #3154: authautologin cookie
fixed in "38abe2e15":https://github.com/kohana/auth/commit/38abe2e151edf78b6e7caedfe59b1637f6824647 Ivan Brotkin
08:48 pm Auth Revision f6cd9376: create separated remember() method, implements #3103
Ivan Brotkin
08:26 pm Auth Bug Report #3406: bug in module auth.
You are talking about
> $user->has('roles', ORM::factory('role', array('name' => 'login')))
am i right? ORM auto...
Ivan Brotkin
05:07 pm Bug Report #3505: Adjust the way default qualities are assigned to mime-types in Request::_parse_...
There was a minor error in the file i submitted. A continue managed to get deleted that was important. Stuart Harland
04:57 pm Bug Report #3505 (Closed): Adjust the way default qualities are assigned to mime-types in Request...
Currently the default quality for all parsed accepted mime-types is 1.0, and @Request::accept_type()@ also sets the *... Stuart Harland

12/24/2010

04:57 pm Feature Request #3491: Route interface
> What's the advantage of this? All I'm seeing is unnecessary complicated syntax and structure, with nothing gained.
...
Jeremy Bush
01:22 pm Core Revision eb205543: Response::render() now only calculates content length if Kohana is in production
Sam de Freyssinet
01:21 pm Core Revision 02b60ec9: Tidied up Request::factory() method, ensured that Referrer and Method are stor...
Sam de Freyssinet
12:58 pm Core Revision 02469e41: Fixing situation where modules aren't restored if the modules test fails
Matt Button
12:56 pm Core Revision b0db6939: Fixing situation where modules aren't restored if the modules test fails
Matt Button
11:08 am Feature Request #3451: Alternative routes format
Dmitry T. wrote:
> @Woody: my arguments are brevity, compactness and readability.
> You've made a branch "yii-style...
Steven G.
10:01 am Feature Request #3491: Route interface
Chris Bandy wrote:
> Here is quick mock-up of a potential API.
>
> fn. https://gist.github.com/3716a7c292f5090c48...
Steven G.
03:27 am ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
We can talk about this for version 3.2.x. I don't really think this is very important and I don't like the idea of fo... Isaiah DeRose-Wilson
12:17 am ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
Lorenzo Pisani wrote:
> I don't think this is necessary. These new syntaxes for @add()@ and @remove()@ should be ava...
Dino Krtanjek

12/23/2010

11:27 pm ORM Bug Report #3066: ORM overwrites related objects if they are not loaded
There are a couple issues here and I don't know which solution is best.... Lorenzo Pisani
10:46 pm Feature Request #3497: Allow a controller to query the name of the matched route
Indeed so, though it is a bit ungainly. I missed that API until you mentioned it, and I think that having the name ac... Oded Arbel
10:34 pm ORM Feature Request #2254 (Assigned): Add support for using array syntax for many-to-many add/updates
Apologies, I closed this too early... I actually did implement @add('roles', array(1,2,3))@ in this pull request: htt... Lorenzo Pisani
10:31 pm ORM Feature Request #2913: Empty save for insert()
Isaiah moved the version from 3.0.9 to 3.1.0 so I assumed this was not being implemented in 3.0.x... if the devs want... Lorenzo Pisani
10:28 pm ORM Revision f3204fa3: Merge branch 'feature/validation-implementation' into feature/simplify-api
Conflicts:
classes/kohana/orm.php
Lorenzo Pisani
10:27 pm ORM Revision a405b8e5: Merge branch 'feature/3489-accessible-updated-and-created-column-properties' i...
Lorenzo Pisani
10:24 pm ORM Revision 075cba1c: documenting all the usages of add() and remove()
Lorenzo Pisani
10:18 pm ORM Revision 08794a87: allowing removal of multiple relationships with arrays of primary keys remove(...
Lorenzo Pisani
10:07 pm ORM Revision ca5158e7: Merge branch 'feature/3202-remove-all-related' into feature/simplify-api
Lorenzo Pisani
10:05 pm ORM Revision 00db1bc4: add() now takes a more flexible second parameter. It can either be a model ins...
Lorenzo Pisani
09:51 pm ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
I don't think this is necessary. These new syntaxes for @add()@ and @remove()@ should be available in 3.1.x (if they ... Lorenzo Pisani
09:33 pm ORM Revision 27a17b84: removing $data parameter from ORM::add(), this breaks the idea of models valid...
If your pivot table has data in it, it is technically not a 'pivot' table.
The proper way to use these tables is to c...
Lorenzo Pisani
08:52 pm ORM Revision 56fa9fd4: added updated_column and created_column to $_properties (fixes #3489)
Lorenzo Pisani
08:50 pm ORM Feature Request #2426 (Closed): ORM makeover for 3.1.0
Many of the things discussed in this ticket were implemented and many became irrelevant. Closing this issue in favor ... Lorenzo Pisani
08:47 pm ORM Feature Request #3489: Add updated and created columns to properties array
applied here: https://github.com/kohana/orm/pull/14 Lorenzo Pisani
08:34 pm ORM Revision 84d000cb: allowing the removal of all related objects with one query by using remove('al...
Lorenzo Pisani
08:30 pm ORM Feature Request #3202: Allow ORM::remove() to delete all relationships
applied here: https://github.com/kohana/orm/pull/13 Lorenzo Pisani
08:05 pm ORM Feature Request #2913 (Feedback): Empty save for insert()
It's not changed in 3.x branches
https://github.com/kohana/orm/blob/3.0.x/classes/kohana/orm.php#L824
https://git...
Joel Pittet
07:51 pm ORM Feature Request #2754: [ORM] changes to validation
Should be all done!
The filtering on __get() is being put on hold until further discussion (3.2.x)
Pull request: ht...
Lorenzo Pisani
07:40 pm ORM Feature Request #2913 (Closed): Empty save for insert()
This is already possible (not sure if it was fixed intentionally or just as a result of all the refactoring). @create... Lorenzo Pisani
06:51 pm ORM Feature Request #3174: Add data serializing to Kohana_ORM
I like the idea of being able to specify the format, I personally prefer json to php serialized strings in my database. Lorenzo Pisani
06:27 pm UnitTest Revision 2cdc2209: Adding some required parts to make the bootstrap compatible with 3.0.x
Matt Button
06:13 pm Core Revision 8a3cb95d: Modifying comments
Matt Button
06:05 pm Feature Request #3249: base.php file
You can specify __() in a module init.php and then just move the i18n::lang() load to after module load. Jeremy Bush
06:00 pm ORM Revision 17db1866: fixing more references to the old Validate class
Lorenzo Pisani
05:59 pm UnitTest Revision 1e286bdb: Moved tests bootstrap from the application directory to the unittest module. R...
Isaiah DeRose-Wilson
05:56 pm Feature Request #3498: Move tests bootstrap into the unittest module
Although the request section has not yet been removed from 3.0.x I merged this commit into unittest:3.0.x in case any... Matt Button
05:45 pm ORM Revision cc1ca1de: renaming all occurances of _validate with _validation
Lorenzo Pisani
05:41 pm ORM Revision 456969be: removing callbacks code as they no longer exist in Validation
Lorenzo Pisani
05:33 pm ORM Revision 331ea620: removing unused properties for old validation
Lorenzo Pisani
05:32 pm Feature Request #3497: Allow a controller to query the name of the matched route
Or just use Route::name($this->request->route)
Though I can't particularly see a reason not to store the name in t...
Andrew Coulton
04:58 pm Bug Report #3501: Cookie::$salt is not set; can not destroy session
Thank You. Next time, I will try to be more accurate from the beginning. Michal Kocian
04:51 pm ORM Feature Request #2254 (Closed): Add support for using array syntax for many-to-many add/updates
This makes a lot less sense in 3.1.x because @add()@ inserts right away and does not require @save()@.... Lorenzo Pisani
04:48 pm Core Revision 1aadf652: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
04:48 pm Core Revision 9df9bc28: Don't call Cookie::set() to delete cookies. Fixes #3501 refs #3020
Isaiah DeRose-Wilson
04:47 pm Bug Report #3501: Cookie::$salt is not set; can not destroy session
Fixed by "9df9bc28f0...":https://github.com/kohana/core/commit/9df9bc28f077cda2b12c6f039913b8f5bc9e4678 Cookie::delet... Isaiah DeRose-Wilson
04:45 pm Bug Report #3501 (Closed): Cookie::$salt is not set; can not destroy session
Applied in changeset commit:"9df9bc28f077cda2b12c6f039913b8f5bc9e4678". Isaiah DeRose-Wilson
04:36 pm Bug Report #3501 (Assigned): Cookie::$salt is not set; can not destroy session
You have to set a salt because the native session driver uses a Cookie::* method and that requires a valid salt. The ... Isaiah DeRose-Wilson
02:38 pm Core Revision 9d0a4234: Removed the Request::$current assignment in Request::factory(), it should not ...
Sam de Freyssinet
01:55 pm Feature Request #3249 (Feedback): base.php file
Jeremy, how is it possible to extend this in a module? Write your own __() function in init.php or isn't this possibl... Jonas De Smet
10:15 am Bug Report #3504 (Closed): Request::$user_agent is not set
Applied in changeset commit:"c8e8133f0098c17bbae48437515568c16d7c948c". Sam de Freyssinet
10:15 am Core Revision 38b55f4e: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
10:00 am Core Revision c8e8133f: Fixes #3504. User agent is now set to the Request::$user_agent static property
Sam de Freyssinet
09:43 am Feature Request #3497: Allow a controller to query the name of the matched route
Well, Request::route is a public instance field that contains the route that was matched. Getting access to its name ... Oded Arbel
08:53 am Bug Report #3504 (Closed): Request::$user_agent is not set
... Michal Kocian
08:27 am Bug Report #3501: Cookie::$salt is not set; can not destroy session
(I believe that the native session driver is used as the default)
I am not using cookie based session and I don't ...
Michal Kocian

12/22/2010

09:18 pm Feature Request #2682 (Closed): Remove the debug methods into a seperate class.
Tested by "f08fe287332...":https://github.com/kohana/core/commit/f08fe287332c1c5cf2834877f50a6bbe52d4c171 and "9b393b... Isaiah DeRose-Wilson
08:54 pm Feature Request #3497: Allow a controller to query the name of the matched route
So do you have some kind of "fix" for this? It's a little ambiguous what should be done here. Jeremy Bush
07:32 pm Revision 0f5629ad: Updating system submodule
Isaiah DeRose-Wilson
07:29 pm Core Revision 35859a20: Fixed tests for http_header_value tests. A Kohana_Exception is throw when you ...
Isaiah DeRose-Wilson
07:16 pm Core Revision 047bd62f: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
07:15 pm Core Revision 774b4eb2: Code cleanup. Refs #2687
Isaiah DeRose-Wilson
07:12 pm Feature Request #2138 (Needs Test): Handling of 404 (and other client errors)
Isaiah DeRose-Wilson
06:53 pm Database Feature Request #3502: Getter (and setter?) for PDO instance on database module
Sorry about wrong type, this should be feature request, not bug report. Didn't find a way to change it. Miika Koskela
06:50 pm Database Feature Request #3502 (Closed): Getter (and setter?) for PDO instance on database module
Could there be a getter (and setter?) for PDO instance on database module? I don't know if there's other use cases bu... Miika Koskela
06:19 pm Core Revision df8488f8: Removed the duplicate code from Http_Exception_XXX, maintaining DRY
Sam de Freyssinet
06:14 pm Core Revision f260e92f: Fixed a small typo in Http_Exception
Sam de Freyssinet
06:13 pm Core Revision 62c22d43: Reorganised the Kohana_Http_Exception classes so they can be extended by appli...
Sam de Freyssinet
06:12 pm Core Revision a3848364: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
06:12 pm Core Revision 67dd8357: Reorganised the Kohana_Http_Exception classes so they can be extended by appli...
Sam de Freyssinet
06:05 pm Core Revision fbff8478: Fixed a small issue where Kohana_Http_Exception was causing an exception as Re...
Sam de Freyssinet
05:50 pm Feature Request #1883: Extensible i18n in bootstrap
Does it make sence to move @setlocale@ and @date_default_timezone_set@ to the I18n class?
If there will be an @Koh...
David Pommer
05:47 pm Revision c6946438: Use body() setter method, refs #3498
Isaiah DeRose-Wilson
05:20 pm Bug Report #3099 (Feedback): Request::execute() should find all methods before executing any of them
This needs to be fixed/reverted in 3.1.x before we can close this issue. Currently you can't change the action in the... Isaiah DeRose-Wilson
05:13 pm Bug Report #3501 (Closed): Cookie::$salt is not set; can not destroy session
In 3.1.x the default is NULL, so you will get that exception. However this isn't a bug, this is the expected behavior... Isaiah DeRose-Wilson
04:27 pm Bug Report #3501: Cookie::$salt is not set; can not destroy session
This would only happen if @Cookie::$salt@ was empty, which it is not by default. Unless I'm missing something, this i... Woody Gilk
02:53 pm Bug Report #3501 (Closed): Cookie::$salt is not set; can not destroy session
... Michal Kocian
07:56 am Userguide Revision ddde197e: Refactored breadcrumb magic JS
Woody Gilk
07:54 am Userguide Revision 247129b7: Cleaned up page table of contents style
Woody Gilk
03:25 am Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
I understand that works as an alternative, but supporting HTML5 won't break what currently works for XHTML, and gives... Michael Mior
03:13 am Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
At this point in time we target XHTML, not HTML, which requires a value for attributes. You can use @array('required'... Woody Gilk
01:12 am Bug Report #3500: Incorrect handling of attributes without values in HTML::attributes
Just thought I would point out that this solution does cause the problem of not allowing any attribute with a name th... Michael Mior
01:10 am Bug Report #3500 (Closed): Incorrect handling of attributes without values in HTML::attributes
The HTML class does not correctly handle attributes which don't have values. These are totally valid in HTML5, and it... Michael Mior
12:20 am Bug Report #3099 (Closed): Request::execute() should find all methods before executing any of them
I'm going to close this. The above issue is a different issue, and the real solution are proper events or event like ... Jeremy Bush
12:06 am Bug Report #3099: Request::execute() should find all methods before executing any of them
Reverting the change is not good enough. We still need to make sure that only the relevant exceptions get turned into... Lorenzo Pisani

12/21/2010

10:36 pm Userguide Revision 5439f41e: Emulating position:fixed for the main menu
Woody Gilk
10:35 pm Userguide Revision 6e12e488: Slightly simplified the collapsing menu code
Woody Gilk
10:33 pm Bug Report #3499: Widont and HTML-tags with attributes
Maybe an additional method isn't the best solution, I think an extra argument like "$html = FALSE" is a better option... Jonas De Smet
10:28 pm Bug Report #3499: Widont and HTML-tags with attributes
It definitelly is possible but it'd slow it down a lot. At first it wasn't planned that there'll be anything but text... Kemal Delalic
09:54 pm Bug Report #3499 (New): Widont and HTML-tags with attributes
Hi,
I'm experiencing some "problems" with the Text::widont() function. When the last words are some HTML for examp...
Jonas De Smet
09:45 pm Userguide Revision 87a72b74: Further work on matching the website style with the docs, and refactoring the ...
Woody Gilk
08:41 pm Revision cd82a4e4: Merged in new docs, tracking submodules
Woody Gilk
08:38 pm Core Revision a8ddbdb9: Merge branch 'docs' into 3.0.x
Woody Gilk
08:37 pm UnitTest Revision 18d4bc6f: Merge branch 'docs' into 3.0.x
Woody Gilk
08:37 pm ORM Revision 81228358: Merge branch 'docs' into 3.0.x
Woody Gilk
08:36 pm OAuth Revision 4f1696ca: Merge branch 'docs' into 3.0.x
Woody Gilk
08:36 pm Image Revision 57e13e38: Merge branch 'docs' into 3.0.x
Woody Gilk
08:36 pm Database Revision 5228b93d: Merge branch 'docs' into 3.0.x
Woody Gilk
08:35 pm Cache Revision 6b5f55ca: Merge branch 'docs' into 3.0.x
Woody Gilk
08:35 pm Codebench Revision 6b5f55ca: Merge branch 'docs' into 3.0.x
Woody Gilk
08:35 pm Cache Revision cfe8eb39: Merge branch '3.0.x' of git://github.com/kohana/cache into 3.0.x
Woody Gilk
08:35 pm Cache Revision 71349e16: Merge branch 'docs' into 3.0.x
Woody Gilk
08:34 pm Auth Revision a0fae96c: Merge branch 'docs' into 3.0.x
Woody Gilk
07:58 pm Core Revision 0d6ff50c: Merging in 3.1.x
Matt Button
06:04 pm Core Revision c3edc8a9: Removing unneeded has_callback() method, refs #3090
Jeremy Bush
05:45 pm Feature Request #3498 (Closed): Move tests bootstrap into the unittest module
Applied in changeset commit:"775feadaa0b800394536700e482a321b541631ac". Isaiah DeRose-Wilson
05:36 pm Revision 775feada: Moved tests bootstrap into the unittest module. Fixes #3498
Isaiah DeRose-Wilson
05:32 pm UnitTest Revision dfd28544: Merge branch '3.1.x' of github.com:kohana/unittest into 3.1.x
Isaiah DeRose-Wilson
05:32 pm UnitTest Revision 5526fb18: Moved tests bootstrap from the application directory to the unittest module. R...
Isaiah DeRose-Wilson
05:25 pm Feature Request #3498 (Closed): Move tests bootstrap into the unittest module
Now that we moved the Request call to index.php, we can move the bootstrap file into the unittest module to clean up ... Isaiah DeRose-Wilson
05:20 pm Feature Request #2687 (Needs Test): Isolated request and response classes.
This should really stay open until we have tests for the new classes related to this change. If you have other issues... Isaiah DeRose-Wilson
03:23 pm Feature Request #2687 (Closed): Isolated request and response classes.
Sam de Freyssinet
03:20 pm Feature Request #3328: Request Global Parameters Management($_POST,$_GET)
I would like to get this into 3.1 - it's quite important for true HMVC Sam de Freyssinet
02:45 pm Bug Report #3418 (Closed): Routes with hyphens don't work
This is fixed, if this feature will be in 3.2, open a new feature request. Jeremy Bush
02:43 pm Feature Request #3475 (Closed): Raise the required PHP version (5.2)
Unless something in core needs a higher version, I'm going to close this. Jeremy Bush
02:02 pm Core Revision 65e54551: Refs #2102, applied the exception response to the current executing request ra...
Sam de Freyssinet
01:43 pm Core Revision b4a22b7e: Refs #2102, enforced valid HTTP status code is used with Kohana_Http_Exception...
Sam de Freyssinet
01:39 pm Core Revision 5b7a6cf7: Refs #2102, enforced valid HTTP status code is used with Kohana_Http_Exception
Sam de Freyssinet
11:30 am Feature Request #3497 (Closed): Allow a controller to query the name of the matched route
Currently a controller can get all the parameters from a matched route, as described in the documentation ( http://ko... Oded Arbel
11:16 am Feature Request #2138 (Closed): Handling of 404 (and other client errors)
Fixed in https://github.com/kohana/core/commit/7c7217bc050356be109b158590505cc0b96bb8f1 Sam de Freyssinet
11:16 am Bug Report #2214 (Closed): Remote::get does not allow getting URLs with errors
3.1 will only throw an exception if the request fails now, not if a correctly formatted HTTP response is returned. Fi... Sam de Freyssinet
04:55 am Bug Report #3496 (Closed): Uncountable words for inflector config
‘deer’, ‘moose’, ‘bison’, ‘salmon’, ‘swine’, ‘blues’ and ‘aircraft’ are all missing from the uncountable array in /sy... Jason Straughan
04:36 am Database Feature Request #3495 (New): Ability to remove "commands" from SQL builder
For example, you created a complex SQL query that you added offset() and limit() to it:
@DB::select()->[...]->offset...
Gah Gneh
02:07 am Revision 897ec390: Updating system (fixed tests)
Isaiah DeRose-Wilson
02:05 am Core Revision 37f55013: Fixed failing tests when error code isn't in Response::$messages and a little ...
Isaiah DeRose-Wilson
01:49 am Revision f489e3e8: Updating system
Isaiah DeRose-Wilson
12:16 am Core Revision da4af680: Fixed the incorrect closing HTML element in views/kohana/http/error.php
Sam de Freyssinet
12:05 am Feature Request #3090 (Closed): Lambda/Callback Routes
Tests complete. Had to change the api a tad, the reverse route uri string now replaces the $regex parameter in the co... Jeremy Bush
12:03 am Core Revision 05ece836: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
12:03 am Core Revision 88f9154f: Fixes #2102, Kohana_Http_Exception allows throwing of customer HTTP exceptions...
HTTP exceptions can have customisable views Sam de Freyssinet
12:00 am Bug Report #2102 (Closed): Request::execute overrides HTTP headers on thrown exception.
Applied in changeset commit:"88f9154f88cbd6e911ab5df2ebd0b8602599b32c". Sam de Freyssinet

12/20/2010

11:53 pm Core Revision cd59677d: Ensured that cookies are supported by Request class in all circumstances
Sam de Freyssinet
11:23 pm Core Revision 09307f28: Tests for lambda/callback routes, along with an api fix to make them behave li...
Jeremy Bush
10:11 pm Feature Request #3090: Lambda/Callback Routes
Good to hear, thank you! Dmitry T.
09:30 pm Feature Request #3090 (Needs Test): Lambda/Callback Routes
Manually setting the uri should do exactly the same thing as the first parameter as a string (old style routes). So i... Jeremy Bush
09:24 pm Feature Request #3090: Lambda/Callback Routes
Jeremy, are optional parameters supported? I.e. @(<controller>(/<action>(/<id>)))@ Dmitry T.
08:01 pm Bug Report #3494 (Closed): Assert messages display using HTML Entities
Ah, you are talking about the error exception message that is generated in the red background. That is expected behav... Jeremy Bush
07:42 pm Bug Report #3494: Assert messages display using HTML Entities
Test case. Create a controller with the following code:
<?php defined('SYSPATH') or die('No direct script acc...
Dan Hulton
07:35 pm Bug Report #3494: Assert messages display using HTML Entities
You need to provide more information, and a sample test case. We don't do anything with assert(). Jeremy Bush
07:01 pm Bug Report #3494 (Closed): Assert messages display using HTML Entities
When using assert(), the strings inside assert() are displayed on the exception screen as HTML entity codes, like so;... Dan Hulton
05:48 pm Core Revision 96c12f4d: Removing process_callback() and moving logic to matches() to reduce api comple...
Jeremy Bush
05:45 pm Feature Request #3491: Route interface
Here is quick mock-up of a potential API.
fn. https://gist.github.com/3716a7c292f5090c48d0
Chris Bandy
05:37 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
This suggestion is using @Controller::before()@ method incorrectly. The request execution stack does not, nor should,... Sam de Freyssinet
05:36 pm Core Revision 34f043ff: adding "uri" key support, adding docs, refs #3090
Jeremy Bush
05:33 pm Feature Request #3090 (Closed): Lambda/Callback Routes
Solution obtained with https://github.com/kohana/core/commit/34f043fff0361e149954455a37c9bd21b1cf53d8
Closing as f...
Jeremy Bush
05:24 pm Feature Request #3493 (Closed): Request_Client_External interface
Request_Client_External should be broken out so that the Curl, PECL HTTP and Native execution methods are separate cl... Sam de Freyssinet
05:23 pm Feature Request #3492 (Closed): Request Client Cache
Request Client should use an adaptor class for HTTP caching, rather than internally processing the logic. I propose a... Sam de Freyssinet
05:21 pm Feature Request #3491 (New): Route interface
Routes are now using either a callback (lambda) or regex methodology match urls. Presently both methods are implement... Sam de Freyssinet
05:02 pm Feature Request #3090: Lambda/Callback Routes
Indeed this is a problem. In picombo, I defined routes like this:
https://github.com/zombor/Picombo/blob/master/te...
Jeremy Bush
04:39 pm Feature Request #3090: Lambda/Callback Routes
I mean that @Request::uri@ must take the route mask (something like @<controller>/<action>@), replace all params with... Dmitry T.
03:57 pm Core Revision def36b65: Fixing problems with lambda routes and adding basic test for it, refs #3090
Jeremy Bush
03:37 pm Feature Request #3090: Lambda/Callback Routes
There should be no change to the uri() method. The only thing lambda/callback routes add is matching logic. It is bas... Jeremy Bush
03:29 pm Feature Request #3090: Lambda/Callback Routes
Jeremy, I have a question: in case of lambda routes, what @Request::uri()@ will return?
And what about @Route::cache()@?
Dmitry T.
03:14 pm Feature Request #3090: Lambda/Callback Routes
This has been merged into the 3.1.x branch. It needs testing. Jeremy Bush
03:10 pm Core Revision 66def2e7: Merge remote branch 'origin/3.1.x' into 3.1.x
Jeremy Bush
03:08 pm Core Revision 515ef3d1: Fixing tests for lambda routing, refs #3090
Jeremy Bush
02:57 pm Core Revision 94cd674f: Fixed the serialization/unserialization logic so that it maps to correct prope...
Fixed the unserialize logic so that it does not check for property existence, which ensures that parent::unserialize(... Sam de Freyssinet
02:50 pm Core Revision 4fb423a0: Merge branch '3.1.x' into feature/3090-new-routing
Conflicts:
classes/kohana/request.php
classes/kohana/route.php
Jeremy Bush
02:09 pm Core Revision b9f6489b: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
02:08 pm Core Revision 79086624: Provided interface parity for Cookies in the response
Sam de Freyssinet
02:07 pm Core Revision c141cfed: Fixed interface to Request and Response headers.
Added full support for old HTTP/1.0 pragma no cache directive Sam de Freyssinet
12:48 pm Feature Request #3160: Kohana_Controller_REST should interpret X-HTTP-Method-Override header para...
Personally I think this is a bad idea for the record. Overriding RFC 2616 defined headers with custom ones is an edge... Sam de Freyssinet
08:56 am Image Feature Request #3490 (Closed): ImageMagick support out of box
In one of the forks of Image module (https://github.com/PaNtHeR/kohana-imagemagick/blob/master/classes/kohana/image/i... Sergei Gladkovskiy
03:59 am ORM Feature Request #3489 (Closed): Add updated and created columns to properties array
Currently there is no way to access the _updated_column and _created_column properties.
Can these be added to the ...
Rowan Parker
02:30 am Feature Request #1885 (Resolved): Expires or ETag Support
This appears to be completed (see system/classes/kohana/request/client.php methods set_cache, cache_response, cache_l... Kiall Mac Innes
02:15 am Revision 6b2c1d74: Updating submodules.
Kiall Mac Innes
02:14 am UnitTest Revision 6424d67d: Updating @package
Kiall Mac Innes
02:14 am ORM Revision 65cf83df: Updating @package
Kiall Mac Innes
02:14 am Database Revision 9930c1b2: Updating @package
Kiall Mac Innes
02:13 am Codebench Revision 2af332e0: Updating @package
Kiall Mac Innes
02:13 am Cache Revision 2af332e0: Updating @package
Kiall Mac Innes
02:07 am Revision 028f001c: Updating system
Kiall Mac Innes
02:06 am Core Revision b2e609d9: Fix a minor syntax error.
Kiall Mac Innes
01:56 am Revision 545c9eb9: Updating system submodule
Kiall Mac Innes
01:55 am Cache Bug Report #3407 (Closed): cache file garbage collect delete git file
I'm assuming garbage_collect is not deleting "everything", but rather, all expired/unknown files?
I believe this w...
Kiall Mac Innes
01:54 am Core Revision a3608467: Allow for alternate body formats when using PUT etc - fixes #2905
Kiall Mac Innes
01:51 am Bug Report #2905 (Closed): Request class can't handle PUT requests with XML data
Fixed by https://github.com/kohana/core/commit/a3608467cf8d03d3d47dff8c8bb993f1feb01075 Kiall Mac Innes
01:48 am Bug Report #2905: Request class can't handle PUT requests with XML data
Infact, why are we adding a special case for x-www-form-urlencoded over non GET/POST methods? And why does it get pla... Kiall Mac Innes
01:42 am Bug Report #2905: Request class can't handle PUT requests with XML data
This issue has, in part, resurfaced: https://github.com/kohana/core/blob/3.1.x/classes/kohana/request.php#L121
parse...
Kiall Mac Innes
01:30 am Bug Report #3301: Kohana_Controller_REST and $this->request->method
Changes for other issues (see related issues) have fixed this. Closing as invalid. Kiall Mac Innes
01:27 am Core Revision 242b9abf: More readable code - I should read my own ticket comments in future ;) refs #3160
Kiall Mac Innes
01:26 am Cache Bug Report #3216: try/catch block in kohana_cache_file __constructor never caught
Vibol: If this is still an issue, please re-open this issue. Kiall Mac Innes
01:25 am Cache Bug Report #3216 (Closed): try/catch block in kohana_cache_file __constructor never caught
Kiall Mac Innes
01:24 am Revision ad4d422a: Adding support for HTTP_X_HTTP_METHOD_OVERRIDE (and a minor bugfix) to Control...
Kiall Mac Innes
01:24 am Core Revision 26629739: Adding support for HTTP_X_HTTP_METHOD_OVERRIDE (and a minor bugfix) to Control...
Kiall Mac Innes
01:18 am Feature Request #3160 (Closed): Kohana_Controller_REST should interpret X-HTTP-Method-Override he...
Kiall Mac Innes
01:07 am Cache Feature Request #3469: Cache Config Reader
The code I've got is older than I thought .. Its in a K2 project!
Not sure how easy this will be to implement with...
Kiall Mac Innes
12:59 am Revision 3cd77759: Updating cache submodule
Kiall Mac Innes
12:57 am Cache Revision aa8997c7: Prevent Cache::_delete_file() from removing .gitignore file
Kiall Mac Innes
12:45 am Revision 56bc0af2: Updating system submodule
Kiall Mac Innes
12:44 am Core Revision 11e937dc: Removing Remote tests.
Kiall Mac Innes
12:40 am Revision 35817a0e: Updating submodules
Kiall Mac Innes

12/19/2010

10:10 pm Core Revision e5cca5d9: Included correct close procedure for file stream in Request_Client_External::_...
Sam de Freyssinet
06:12 pm Core Revision 43d74d82: Removed the test commented out code (whoops)
Sam de Freyssinet
05:48 pm Core Revision 7c7217bc: Finalised the Request_External_Client, supports PECL HTTP, CURL or none of the...
Sam de Freyssinet
05:12 pm Bug Report #3474 (Closed): URL:base port bug
Isaiah DeRose-Wilson
11:22 am Core Revision c957487f: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
11:22 am Core Revision 857efef4: WIP on Request_Client_External
Sam de Freyssinet

12/18/2010

11:14 pm Revision f1a455c2: Updating system
Isaiah DeRose-Wilson
09:38 pm Core Revision 9a1e25d5: Coding style cleanup
Isaiah DeRose-Wilson
09:05 pm Revision dc7e4909: Updating system
Isaiah DeRose-Wilson
09:02 pm Core Revision ce7b90aa: Skip Request tests until we rewrite them for the new Request class. Refs #2687
Isaiah DeRose-Wilson
09:01 pm Core Revision c823c359: Updated Route tests for changes in #3488
Isaiah DeRose-Wilson
09:00 pm Core Revision 078408ac: Updated url tests for changes in #3488
Isaiah DeRose-Wilson
08:59 pm Core Revision 2c5eae0d: Cleaned up URL::base() api, Fixes #3488
Isaiah DeRose-Wilson
08:59 pm Bug Report #3488 (Closed): URL::base() clean up
Isaiah DeRose-Wilson
08:58 pm Bug Report #3488: URL::base() clean up
Fixed in "2c5eae0df43def8e...":https://github.com/kohana/core/commit/2c5eae0df43def8eeb5ccd57be6ad25c70a98709 Isaiah DeRose-Wilson
08:58 pm Bug Report #3487 (Closed): Route::is_external returns true for internal routes
Fixed in "0f59f2d09fc2e6c...":https://github.com/kohana/core/commit/0f59f2d09fc2e6c8afc30ad4fff5fcb9fc72dc0c Isaiah DeRose-Wilson
08:45 pm Core Revision 0f59f2d0: Reversed the results from Route::is_external(). Fixes #3487
Isaiah DeRose-Wilson
08:43 pm Bug Report #3488 (Closed): URL::base() clean up
Currently the URL::base() api is messy. You can pass a boolean, string or request object in for the protocol. It woul... Isaiah DeRose-Wilson
08:37 pm Bug Report #3487 (Closed): Route::is_external returns true for internal routes
It looks like the Route::is_external() method is backward. It should be @return ! in_array($this->_host, Route::$loca... Isaiah DeRose-Wilson
08:37 pm Core Revision 6a8310bc: Moved the Remote config to Curl config, as Remote class is now removed
Sam de Freyssinet
08:36 pm Core Revision 28672ede: Added better handling of HTTP header rendering
Sam de Freyssinet
08:26 pm Core Revision d17ffcf3: Fixed a regression with regards to sub-request execution benchmarking
Sam de Freyssinet
08:10 pm Core Revision c5544b0c: Added basic support for the PECL HTTP client
Sam de Freyssinet
07:51 pm Core Revision 84d70fee: Added better support for cookies to Response
Sam de Freyssinet
07:32 pm Core Revision 96abb1a4: Added cookie support to requests
Sam de Freyssinet
06:47 pm Core Revision 61883295: Updated URL, Html and Form classes to use DI method of protocol resolution
Sam de Freyssinet
06:38 pm Core Revision 3b2251b4: Ensured the Controller_Rest class uses new interfaces
Sam de Freyssinet
06:34 pm Core Revision 3b774bcb: Ensured that URL::base() uses dependency injection for protocol resolution, re...
Sam de Freyssinet
06:08 pm Core Revision e6cfc642: Updated header doc example to use new interface
Sam de Freyssinet
06:06 pm Core Revision 80cc83aa: More tidy up and interface parity
Sam de Freyssinet
05:49 pm Core Revision 693ebf3a: Tidied up Request and Response so they have interface parity
Sam de Freyssinet
05:48 pm Core Revision 750f234b: Tidied up Request and Response so they have interface parity
Sam de Freyssinet
05:16 pm Userguide Feature Request #3486 (Closed): Show what interfaces a class implements
The API browser should indicate which interfaces a class implements.
fn(((. For example, "Kohana_Database_Result":...
Chris Bandy
04:30 pm Bug Report #3372 (Closed): HMVC broken for alternate HTTP methods (static Request::$method)
Fixed in Kohana 3.1.x (https://github.com/kohana/core/commit/46707e25718a7b18deccea80387f37a6fabfbec1) Sam de Freyssinet
04:23 pm Core Revision f3554bfe: Ensured the http protocol is always output uppercase in Response::send_headers()
Sam de Freyssinet
04:00 pm Bug Report #3479 (Closed): URL::base() doesn't use the protocol correctly
Applied in changeset commit:"04a245aab38653ddf35132f788febfd56374f871". Sam de Freyssinet
03:55 pm Core Revision 04a245aa: Tidied up the code a little, and changed protected properties to use underscor...
Fixed Http::$protocol so that URL::base() works as expected, fixes #3479 Sam de Freyssinet
03:18 pm Bug Report #2905: Request class can't handle PUT requests with XML data
Marçal Juan Llaó wrote:
> One thing, if you want to send a binary file with PUT method?
Use of a multi-part reque...
Sam de Freyssinet
01:31 am Database Revision 74117b6b: Marked Database::count_last_query() as deprecated. Refs #3394
Isaiah DeRose-Wilson
01:28 am Bug Report #3394 (Closed): SQL Injection issue with Database::count_last_query()
Marked as deprecated in 3.0.9 (refs "74117b6b46a39...":https://github.com/kohana/database/commit/74117b6b46a3904f6844... Isaiah DeRose-Wilson
01:27 am Database Revision 22fa56c8: Removed deprecated method Database::count_last_query(). Refs #3394
Isaiah DeRose-Wilson
01:25 am Database Revision 9d50020d: Merge branch '3.1.x' of github.com:kohana/database into 3.1.x
Isaiah DeRose-Wilson
01:11 am Bug Report #3394 (Assigned): SQL Injection issue with Database::count_last_query()
This will just be removed in 3.1. Jeremy Bush
12:56 am Core Revision a43a4c69: Use Response::body() to set the response output. Refs #3482
Isaiah DeRose-Wilson

12/17/2010

11:08 am Bug Report #2905 (Feedback): Request class can't handle PUT requests with XML data
One thing, if you want to send a binary file with PUT method? Marçal Juan Llaó

12/16/2010

05:25 pm Database Revision ba3b9d4e: Do not call empty() when it is not necessary
Woody Gilk
05:24 pm Database Revision db74dd6e: Enabling order_by(NULL, ...) to do ordering without columns, fixes #3485
Woody Gilk
05:18 pm Patch #3485 (Closed): _compile_order_by don't support order by SQL functions like RAND()
Fixed by https://github.com/kohana/database/commit/db74dd6eb579bc0ed2098f44235241439afecada Woody Gilk
04:17 pm Patch #3485 (Assigned): _compile_order_by don't support order by SQL functions like RAND()
You can always do: @order_by(DB::expr('RAND()'))@. Woody Gilk
11:22 am Patch #3485 (Closed): _compile_order_by don't support order by SQL functions like RAND()
When you try query something like this:
$random_item = ORM::factory('student')
...
Juan Lago
08:27 am Core Revision 665eab6e: Merge branch '3.0.x' into docs
Conflicts:
classes/kohana/core.php
Woody Gilk
04:10 am Core Revision 8b3ca859: Merge branch '3.0.x' of https://github.com/awellis/core into 3.0.x
Woody Gilk
04:05 am Feature Request #2893: Use proper phpdoc @param and @return type hints
Merged pull 57 in https://github.com/kohana/core/commit/8b3ca859586200a155573b0567e21a18adb2c4bd Woody Gilk
03:57 am ORM Feature Request #3484: Automatic has() check when add()ing or remove()ing relations
Why does it need to be run on remove()? If there relation doesn't exist, no rows will be deleted. Rowan Parker
01:35 am ORM Feature Request #3484 (Assigned): Automatic has() check when add()ing or remove()ing relations
Isaiah DeRose-Wilson
12:05 am ORM Feature Request #3484 (Closed): Automatic has() check when add()ing or remove()ing relations
It would be nice if the add() and remove() methods automaticaly do a has() check when adding/removing relations. Dino Krtanjek

12/15/2010

07:09 pm Feature Request #2893: Use proper phpdoc @param and @return type hints
GitHub Pull Request: https://github.com/kohana/core/pull/57
This is for classes/kohana/encrypt.php to fix the docu...
Andrew Ellis
07:06 pm Core Revision fc1378fd: Changing the PHPDoc for classes/kohana/encrypt.php to support IDE auto-complet...
Andrew Ellis
02:36 am Revision fe8defd7: Updating system
Isaiah DeRose-Wilson
02:34 am Patch #3483 (Closed): Remote doesnt support sessions.
When using Remote::get to interact with another web service, you cannot use Remote if the web service requires you to... Deon George
02:33 am Core Revision 33d59f81: Cleaned up coding style and comments, refs #2687
Isaiah DeRose-Wilson
02:01 am Core Revision 87783f86: Cleaned up Request_Client_Internal, refs #2687
Isaiah DeRose-Wilson
01:42 am Revision b6aa7c4c: Use the body() getter method to get the Response::$body variable. Refs #3482
Isaiah DeRose-Wilson
01:39 am Core Revision 8053fa9d: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
01:38 am Core Revision 99584f90: Made response class variables protected to force the use of the setter/getter ...
Isaiah DeRose-Wilson
01:34 am Bug Report #3482 (Closed): The Response class should ensure that $body is a string when it's set
Fixed by "99584f90...":https://github.com/kohana/core/commit/99584f90f5fcf976c1f13bc66f563e00a96b0575 Isaiah DeRose-Wilson
01:29 am Bug Report #3482 (Closed): The Response class should ensure that $body is a string when it's set
The response class should typecast $body into a string when it's set to avoid issues later on in the request and to c... Isaiah DeRose-Wilson
01:29 am Core Revision 57c05642: Cleaned up coding style and comments in response, refs #2687
Isaiah DeRose-Wilson

12/14/2010

11:23 pm Revision a58503dc: Updating system submodule
Kiall Mac Innes
09:00 pm Userguide Revision 9729bf98: New Response class. Refs #2687
Chris Bandy
08:59 pm Userguide Revision c1102e00: Debug methods have moved. Refs #2682
Chris Bandy
08:07 pm Bug Report #3481 (Closed): Controller_Template does not render correctly with the new Response class
Fixed in http://github.com/kohana/core/commit/55ec7aef3bcf89f8bdd344127b1699e32b2cdb50 Chris Bandy
08:06 pm Core Revision 55ec7aef: Render the template view in after(). Fixes #3481
Chris Bandy
08:00 pm Bug Report #3481 (Closed): Controller_Template does not render correctly with the new Response class
Some view helpers need the current request, e.g., @form::open(NULL)@, but if you render the view after @Request::exec... Chris Bandy
04:32 pm Bug Report #3434 (Closed): Inaccurate memory reporting
Right, I'm saying that's what you want, but that's not the design of it. Jeremy Bush
04:13 pm Core Revision af66404b: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Isaiah DeRose-Wilson
04:12 pm Core Revision 80d6bf83: Updated Route Tests for new 'host' default value. Refs 014a94c4da847182bc595d2...
Isaiah DeRose-Wilson
03:37 pm Database Feature Request #3329 (Assigned): Add sql_mode to db config
Isaiah DeRose-Wilson
03:29 pm Database Bug Report #2005: Let the database query result $as_object = FALSE or TRUE
I think this has been fixed and should be closed Yahasana .
03:13 pm Bug Report #3434: Inaccurate memory reporting
Actually, you'll want the _memory_get_peak_usage_. Too bad this value can't be reset otherwise it'd be perfect. That ... Mathew Davies
03:13 pm Revision 6bfbe00d: Update database submodule
Chris Bandy
03:12 pm Revision cf62903a: Update database submodule
Chris Bandy
03:08 pm Database Revision 16552186: Clean up some whitespace
Chris Bandy
03:08 pm Database Revision 1b85b509: Clean up some whitespace
Chris Bandy
02:50 pm Bug Report #3434: Inaccurate memory reporting
I think it does. You are specifically concerned about *max memory* in your situation, when in most cases, we only car... Jeremy Bush
02:32 pm Bug Report #3434: Inaccurate memory reporting
Okay. I actually gave up trying to use the solution from my StackOverflow question as it is just too sensitive to cha... Mathew Davies
12:49 pm Core Revision 4e661198: Adding StdErr and Std - fixes #3480
Kiall Mac Innes
12:47 pm Core Revision 3da3e387: Merge branch '3.1.x' of git://github.com/kohana/core into 3.1.x
Kiall Mac Innes
12:45 pm Feature Request #3480 (Closed): StdErr and StdOut log writers.
Kiall Mac Innes
12:43 pm Core Revision a5b1ac4d: Updating StdErr and StdOut log writers for K3.1 - refs #3480
Kiall Mac Innes
12:40 pm Core Revision f2b16c99: Adding StdErr and Std - fixes #3480
Kiall Mac Innes
12:31 pm Feature Request #3480 (Closed): StdErr and StdOut log writers.
Add Stderr and StdOut log writers. Kiall Mac Innes
07:12 am Database Feature Request #3329: Add sql_mode to db config
I can take this one when it's time. Chris Bandy
06:46 am Bug Report #3434: Inaccurate memory reporting
I saw this recently and just wanted to point out that the behavior of @memory_get_usage@ varies between PHP versions.... Chris Bandy
06:26 am Feature Request #3439: Defined routes should be separate from bootstrap
Miodrag Tokić wrote:
> I put them in @application/routes.php@ and then in bootstrap:
>
> [...]
This is exactly...
Chris Bandy
04:06 am Patch #3471 (Closed): Controller_Template doesnt work with a new Response class
Isaiah DeRose-Wilson
03:12 am Revision 5d7b8c3d: Moved request call to index.php file and loading core files into the bootstrap...
Isaiah DeRose-Wilson
03:08 am Patch #3188 (Closed): Request call should be moved to index.php
Fixed by "5d7b8c3d70...":https://github.com/kohana/kohana/commit/5d7b8c3d704ec46d134202f880ab505a85142686 Isaiah DeRose-Wilson
01:08 am Feature Request #3475: Raise the required PHP version (5.2)
Woody Gilk wrote:
> With 3.1 or 3.2 we are going to require PHP 5.3 anyways
My understanding was that PHP 5.3 was...
Chris Bandy

12/13/2010

11:47 pm Bug Report #3479 (Closed): URL::base() doesn't use the protocol correctly
URL::base() uses the current request protocol, but it isn't formatted to concatenate directly to the url string becau... Isaiah DeRose-Wilson
10:34 pm Revision 4db031b2: Updating system
Isaiah DeRose-Wilson
10:34 pm Core Revision 48a03694: Replaced Request::instance() with Request::factory() so tests will run.
Isaiah DeRose-Wilson
10:20 pm Core Revision 60f69faf: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
10:19 pm Bug Report #2755 (Needs Test): Request should be able to statically access headers
Fixed in https://github.com/kohana/core/commit/ef10a28867dc2feb9db2bfb8220b2ab0ec1224e1 Sam de Freyssinet
10:17 pm Core Revision 8e0a848f: Small fix to solve GET error when null
Sam de Freyssinet
10:16 pm Core Revision ef10a288: Fixes #2755, static headers are now accessible from Request::$initial->headers()
Sam de Freyssinet
10:13 pm Patch #3471: Controller_Template doesnt work with a new Response class
https://github.com/kohana/core/blob/3.1.x/classes/kohana/controller/template.php#L44 Sam de Freyssinet
10:04 pm Revision 5fc9298e: Updating system
Isaiah DeRose-Wilson
10:02 pm Core Revision 772076e1: Removed pass-by-reference from Request::factory(), fixes #3478
Isaiah DeRose-Wilson
09:58 pm Patch #3471: Controller_Template doesnt work with a new Response class
I'm afraid seem tedious, but I do not see any changes in the branch 3.1.x for this issue... :) Ivan Brotkin
09:57 pm Bug Report #3478 (Closed): Request::factory() shouldn't use pass-by-reference for the uri
Fixed by "772076e...":https://github.com/kohana/core/commit/772076e14637f06e2b2be4b955af7d53b16586cf Isaiah DeRose-Wilson
09:55 pm Bug Report #3478 (Closed): Request::factory() shouldn't use pass-by-reference for the uri
It's impossible to pass a simple string into Request::factory() anymore. This behavior was added when factory() repla... Isaiah DeRose-Wilson
09:46 pm Patch #3471: Controller_Template doesnt work with a new Response class
it's in v3.1.x at HEAD now too Sam de Freyssinet
09:44 pm Patch #3471 (Feedback): Controller_Template doesnt work with a new Response class
> Merged the recent Request.php changes into trunk.
> Need to examin the kohana/master Request vs samsoir/master Re...
Ivan Brotkin
09:39 pm Patch #3471 (Closed): Controller_Template doesnt work with a new Response class
Gotta love those huge merges ;) Isaiah DeRose-Wilson
09:26 pm Patch #3471: Controller_Template doesnt work with a new Response class
Strange commit link... Ivan Brotkin
09:25 pm Patch #3471 (Resolved): Controller_Template doesnt work with a new Response class
Sam de Freyssinet
09:24 pm Bug Report #3459 (Needs Test): lambda call in header.php needs to be removed
Fixed in https://github.com/kohana/core/commit/18a1c558e864ce27f9a4270bf079fa0505201921#diff-3 Sam de Freyssinet
09:21 pm Patch #3471: Controller_Template doesnt work with a new Response class
Fixed in https://github.com/kohana/core/commit/b7f93d3f0b9bbbb947c3943a14bfc59695d3ee0a Sam de Freyssinet
09:19 pm Core Revision 4d2511b1: Fixed the typo in Kohana_Http, thanks zombor and shadowhand
Sam de Freyssinet
08:18 pm Core Revision a6a50b39: Removed the URI pass by reference
Removed the Request::send_response_headers() method, which is not needed Sam de Freyssinet
08:17 pm Core Revision f1678ab2: Removed the check for __call() method existence in controller. That should nev...
Sam de Freyssinet
07:56 pm UnitTest Feature Request #3455: Deprecate Unittesting Web UI
I've just started using the unittest module. After using the command line a few times, I found the web UI. It's easie... Hallvard Nygård
04:58 pm Revision 9cbf872a: Updated bootstrap and Welcome controller for new request/response changes. Ref...
Isaiah DeRose-Wilson
04:55 pm Feature Request #3476: Upload::size should valid a range of sizes
It currently does a maximum, not an exact, size. Why would you ever need to set a minimum? Woody Gilk
04:52 pm Feature Request #3475: Raise the required PHP version (5.2)
I don't see a reason to bump the version. With 3.1 or 3.2 we are going to require PHP 5.3 anyways, I don't see any bi... Woody Gilk
03:37 pm Feature Request #3477 (Assigned): Remote Exception codes
Woody Gilk
03:25 pm Bug Report #3447 (Closed): Validate::errors() does not properly use the $translate parameter
Isaiah DeRose-Wilson
03:22 pm Bug Report #3342 (Closed): No default messages for some of Kohana_Validate validate methods
Tested by "23fa10ab...":https://github.com/kohana/core/commit/23fa10ab937f0d466192823873e237a701c7a5be Isaiah DeRose-Wilson
02:56 pm Feature Request #3475: Raise the required PHP version (5.2)
I wouldn't have a problem bumping the version number, but if all the issues are related to a non-official module I th... Isaiah DeRose-Wilson
02:54 pm Revision 2ff81513: Updating System
Isaiah DeRose-Wilson
02:24 pm UnitTest Feature Request #3455: Deprecate Unittesting Web UI
If someone wants to maintain it as such after 3.2 is out, they can. Jeremy Bush
02:13 pm Feature Request #3477: Remote Exception codes
Unless you have other specific areas where exception codes need to be set, I'm going to rename this issue to "Remote ... Jeremy Bush
01:47 pm UnitTest Feature Request #3455: Deprecate Unittesting Web UI
Why not simply extract it into an unofficial module? Kiall Mac Innes
12:25 pm UnitTest Feature Request #3455 (Assigned): Deprecate Unittesting Web UI
Matt Button
12:25 pm UnitTest Feature Request #3455: Deprecate Unittesting Web UI
Bumping this back to 3.2, should really give more notice for this Matt Button
12:20 pm Feature Request #3477 (Closed): Remote Exception codes
I have noticed that error codes are not set when an exception occurs. There are many cases where error codes are need... Michael R
06:08 am Feature Request #3476 (New): Upload::size should valid a range of sizes
Upload::size($file, $min, $max) Yahasana .
02:41 am Feature Request #3475: Raise the required PHP version (5.2)
I'm fine with it. All your bugs seem to be pg related though, which don't have anything to do with core. I don't see ... Jeremy Bush
01:01 am Feature Request #3475: Raise the required PHP version (5.2)
| http://bugs.php.net/50195 | Cannot pass schema to pg_copy_to() | Fixed in 5.2.12, 5.3.2 |
| http://bugs.php.net/51...
Chris Bandy
12:46 am Core Revision dd825fb1: Applied the initial request body to the correct property
Sam de Freyssinet
12:44 am Core Revision 5d7b5b57: Minor fixes to global handling of GET/POST in Kohana_Request
Sam de Freyssinet
12:29 am Core Revision 184ef452: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x
Sam de Freyssinet
12:28 am Core Revision 6c72e1b6: Implemented the Kohana_Request_Client and derivative classes for handling requ...
Implemented the RFC 2616 cache lifetime logic into Kohana_Request_Client Sam de Freyssinet

12/12/2010

09:07 pm Revision dc340173: Updating system submodule
Kiall Mac Innes
09:05 pm Core Revision 2ad3732a: Fixing an accidential copy and paste in DateTest
Kiall Mac Innes
09:02 pm Core Revision 014a94c4: Added simple host support to Kohana_Route
Fixed some issues with req/response
Added better support for sending headers correctly, and added content length output
Sam de Freyssinet
08:05 pm Core Revision d63e8721: Implemented the Kohana_Response::render() method
Added Kohana_Request::send_response_headers() method to proxy to Kohana_Response::send_headers()
Small fixes
Sam de Freyssinet
07:43 pm Core Revision a7928e01: Merged in changes from 3.1.x and removed conflicts
WIP Sam de Freyssinet
07:01 pm Core Revision 46707e25: Lots of work on the request response separation
Better handling of the HTTP protocol
Request can render itself to RFC 2616
Sam de Freyssinet
05:04 pm Feature Request #3475: Raise the required PHP version (5.2)
What php bugs are you having issues with? Isaiah DeRose-Wilson
04:06 pm Feature Request #3475: Raise the required PHP version (5.2)
Here are some quick stats.
|_. System |_. Version |
| Arch | stable | 5.3.3 |
| CentOS | 4 |(highlight). 4.3.9 |...
Chris Bandy
02:46 pm Core Revision fe537b2b: Switched Kohana expose to default to false
Sam de Freyssinet
03:53 am Userguide Revision d8f5526a: Added styles for the page TOC
Woody Gilk
03:34 am Core Revision 251afd23: Merge branch 'docs' of git://github.com/bluehawk/core into docs
Woody Gilk

12/11/2010

11:44 pm Feature Request #3475 (Closed): Raise the required PHP version (5.2)
Is there anything stopping us from raising the required version from 5.2.3 to 5.2.7?
I'd like to use @PHP_VERSION_...
Chris Bandy
04:23 pm Bug Report #3474 (Assigned): URL:base port bug
Woody Gilk
04:22 pm Bug Report #3473 (Closed): Security::token uses native session driver
@Security::token@ uses @Session::instance@. To set the default Session adapter, you need to set @Session::$default@. ... Woody Gilk
01:29 pm Bug Report #3474 (Closed): URL:base port bug
When you assign to apache a different port like 8080 and while you are using HTML::style() function, you had a url wi... Gökmen Koç
10:19 am Bug Report #3473 (Closed): Security::token uses native session driver
I use mangodb session driver, and when try to add token into the form it says:... Alexey Zinchenko
05:16 am Bug Report #3470: error screen shows an <a> tag instead of interpreting it as html
What about the possibilty of disabling html_errors in as part of Kohana then? Rowan Parker
03:49 am Bug Report #3470 (Closed): error screen shows an <a> tag instead of interpreting it as html
By default Kohana will show the uri (and other unsafe data) in some exception messages (Request_Exception for one), s... Isaiah DeRose-Wilson

12/10/2010

11:48 pm Bug Report #3470: error screen shows an <a> tag instead of interpreting it as html
This is because line 51 of systems/views/kohana/error.php uses html::chars() to output the error message.
I'm not ...
Rowan Parker
09:13 pm Bug Report #3472 (Closed): Errors after run
Michal Dziczkowski wrote:
> Fresh after install I get following error (see the attachment)
That's because you for...
Isaiah DeRose-Wilson
06:39 pm Revision 1bcba0df: Update submodules for coding style
Chris Bandy
06:31 pm Cache Revision 262b4f00: Merge branch '3.0.x' into 3.1.x
Chris Bandy
06:26 pm UnitTest Revision 10ded460: Clean up some parentheses and whitespace
Chris Bandy
06:06 pm Revision 1cd08751: Update submodules. Mostly coding style.
Chris Bandy
05:56 pm Bug Report #3472: Errors after run
Isaiah DeRose-Wilson wrote:
> I'm not sure why install.php would care about the timezone setting, but you can fix th...
Michal Dziczkowski
04:58 pm Patch #3471 (Assigned): Controller_Template doesnt work with a new Response class
Isaiah DeRose-Wilson
04:53 pm Bug Report #3472: Errors after run
It looks like these are multiple unrelated errors.
The clearstatcache() error has already been fixed, see #3292. ...
Isaiah DeRose-Wilson
03:48 pm Core Revision a02f4d9b: Ensure we have a consistant timezone during the Date class tests. Fixes #3405
Kiall Mac Innes
03:42 pm Bug Report #3405 (Closed): Failed unittest test_offset, test_unix2dos, test_dos2unix when it has ...
Kiall Mac Innes
03:42 pm Bug Report #3405: Failed unittest test_offset, test_unix2dos, test_dos2unix when it has changed t...
Fixed in 3.0.x - https://github.com/kohana/core/commit/3e92a870b00b80f1d0dae7e456345a9d130e13a8
Fixed in 3.1.x - htt...
Kiall Mac Innes
03:41 pm Core Revision 3e92a870: Ensure we have a consistant timezone during the Date class tests. Fixes #3405
Kiall Mac Innes
02:33 pm Bug Report #3472 (Closed): Errors after run
At first run I get following errors:
== Error start ==
Strict Standards: clearstatcache() [function.clearstatca...
Michal Dziczkowski
01:08 pm Patch #3471 (Closed): Controller_Template doesnt work with a new Response class
Here is controller example:
class Controller_Test extends Controller_Template {
public $template = 'test...
Ivan Brotkin
11:08 am Bug Report #3470 (Closed): error screen shows an <a> tag instead of interpreting it as html
i'm using array_map, i get an error because of an incorrect param that i'm passing to it, and i get the kohana error ... Ranko Radonić
08:14 am UnitTest Revision aaf1bd38: Clean up some parentheses and whitespace
Chris Bandy
08:00 am Cache Revision 8da6b7b2: Clean up some parentheses and whitespace
Chris Bandy
01:17 am Revision 8e29ad39: Updating System
Isaiah DeRose-Wilson
01:16 am Core Revision 9591eb7d: Clean up some parentheses and whitespace
Isaiah DeRose-Wilson
12:23 am Core Revision 31fd206f: Fix concatenation spacing in the conventions page in the guide. (thanks bandi...
Michael Peters
12:09 am Feature Request #3466: items per page parameter can be overwrite automatically by query string
> you can already specify the items per page with a single line of code...
I know it. I have to take care and rewr...
Yahasana .
12:08 am Revision 49ce39c5: Updating system
Isaiah DeRose-Wilson
12:07 am Core Revision c80348aa: More UTF8 coding style fixes.
Isaiah DeRose-Wilson

12/09/2010

11:53 pm ORM Revision 68842808: Moved the ignored columns code from ORM::__construct() into ORM::_initialize(...
Isaiah DeRose-Wilson
11:49 pm ORM Bug Report #3331 (Closed): ORM on wakeup doesn`t restore proper ignored_columns
Fixed by "68842808...":https://github.com/kohana/orm/commit/68842808c39f17753a54ae4045e287f6d479631b Isaiah DeRose-Wilson
11:48 pm Cache Feature Request #3469 (Assigned): Cache Config Reader
I have a cache config reader/proxy buried in an old project - I'll dig it out and commit tomorrow.
Essentially, it...
Kiall Mac Innes
11:33 pm Core Revision ba550a1c: Clean up some parentheses and whitespace
Chris Bandy
11:30 pm ORM Bug Report #3331: ORM on wakeup doesn`t restore proper ignored_columns
Moved the _ignored_columns code from __construct into _initialize (which is called it __construct and __wakeup), and ... Mike CONSTANTIN
11:29 pm Feature Request #3466: items per page parameter can be overwrite automatically by query string
Yeah, I don't see what the feature request is here.
*Just a note* if you plan on using this feature; Please enfor...
Mathew Davies
11:17 pm UnitTest Revision c2d69bc0: Clean up some parentheses and whitespace
Chris Bandy
10:17 pm Database Feature Request #3432: Nested Transactions
Lorenzo, Isaiah and I talked about the above implementation on IRC.
The API behaves similarly to SQL in that @rollba...
Chris Bandy
08:54 pm Core Revision 11515df2: humanized labels should be trim()d, Fixes #3468
Jeremy Bush
08:49 pm Bug Report #3468 (Closed): Validation doesn't trim() labels
Fixed by https://github.com/kohana/core/commit/11515df2e7878b4b9789aba50fc7cc2ac60cb9b2 Jeremy Bush
08:45 pm Bug Report #3468 (Closed): Validation doesn't trim() labels
L655 of Validate.php runs a preg_replace, replacing characters with spaces. If any of the characters are at the begin... Jeremy Bush
06:30 pm Bug Report #3099: Request::execute() should find all methods before executing any of them
Jeremy Bush wrote:
> I think the problem here is really the lack of places to put code that doesn't have directly to...
Isaiah DeRose-Wilson
05:26 pm Bug Report #3099: Request::execute() should find all methods before executing any of them
I think the problem here is really the lack of places to put code that doesn't have directly to do with the controlle... Jeremy Bush
03:56 pm Bug Report #3099: Request::execute() should find all methods before executing any of them
While I agree with Lorenzo, changing the action inside the request can be confusing and lead to difficult to understa... Isaiah DeRose-Wilson
02:53 pm Revision 9b400885: Merge branch '3.0.x' of github.com:kohana/kohana into 3.0.x
Isaiah DeRose-Wilson
02:52 pm Revision f87ee018: Updating system
Isaiah DeRose-Wilson
02:51 pm Core Revision 05b22ab4: More UTF8 coding style fixes.
Isaiah DeRose-Wilson
07:44 am Core Revision 84317b0c: Use lowercase variable names
Chris Bandy
07:44 am Core Revision 6730521e: Clean up some parentheses and whitespace
Chris Bandy
07:36 am UnitTest Revision b2b0ad1a: Minor Coding Style fixes
Kiall Mac Innes
07:23 am Core Revision 983b62f7: Clean up some parentheses and whitespace
Chris Bandy
07:21 am Core Revision 959c0c8c: Use lowercase variable names
Chris Bandy
06:39 am UnitTest Revision 15627780: Clean up some parentheses and whitespace
Chris Bandy
06:34 am Bug Report #3099: Request::execute() should find all methods before executing any of them
Woody Gilk wrote:
> Here's a use case that I've used before... make an abstract controller called Controller_Authoriz...
Lorenzo Pisani
05:05 am Revision 673dffd1: Adding **/tests/** ignore to PHP CodeSniffer
Kiall Mac Innes
05:04 am Revision 120b1ed0: Adding **/tests/** ignore to PHP CodeSniffer
Kiall Mac Innes
04:40 am Revision 96d21ff1: kohana 3.0.x branch should point at submodules 3.0.x branches
Kiall Mac Innes
04:24 am Revision b6774876: Updating build.xml to match 3.1.x branch.
Kiall Mac Innes
03:53 am Bug Report #3099 (Feedback): Request::execute() should find all methods before executing any of them
This still does not fix the issue properly. The action must be found *after* @before@ is executed, otherwise it preve... Woody Gilk
03:45 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
This issue isn't about being able to change the action inside a controller's before() method. That discussion should ... Isaiah DeRose-Wilson
03:33 am Revision cf5c19bb: Updating auth submodule.
Kiall Mac Innes
03:32 am Revision da7302bf: Disabling 'userguide' module is test_bootstrap.php - it triggers a syntax erro...
Kiall Mac Innes
03:26 am Auth Revision 9db24b62: Fixing a syntax error introduced in 1b4e0c9167483a68aabb63747580bfe645082a79
Kiall Mac Innes
03:21 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Woody Gilk wrote:
> Here's a use case that I've used before... make an abstract controller called @Controller_Author...
Yahasana .
03:21 am Revision a34d1988: Updating unittest submodule
Kiall Mac Innes
03:20 am UnitTest Revision 1d3af850: Enabling unittest whitelist by default. Otherwise, code coverage numbers are w...
Kiall Mac Innes
03:03 am Revision 7f4103d4: Updating system submodule.
Kiall Mac Innes
03:02 am Revision 8a51b7a6: Enabling all modules in test_bootstrap
Kiall Mac Innes
02:35 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Here's a use case that I've used before... make an abstract controller called @Controller_Authorized@ with a @login@ ... Woody Gilk
02:27 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
The action should be decided by the routes, not the controller. Also, the before() method can only change the method ... Lorenzo Pisani
02:03 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
> actually, in 3.1.x, it doesn't look like you change the action in before() any more... thankfully. (just a warning ... Woody Gilk
01:58 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
actually, in 3.1.x, it doesn't look like you change the action in before() any more... thankfully. (just a warning to... Lorenzo Pisani
01:57 am Feature Request #3439: Defined routes should be separate from bootstrap
Lorenzo Pisani wrote:
> ... and see no problem with manually adding a require line myself when I want to move routes...
Isaiah DeRose-Wilson
01:56 am Core Revision 37d6d2d7: Removed E_COMPILE_ERROR from Kohana::$shutdown_errors, compile errors cause th...
Isaiah DeRose-Wilson
01:54 am Revision ba0b55a3: Disabling passthru of phpcs output in build.xml
Kiall Mac Innes
01:53 am Core Revision eaf83f7c: Removed E_COMPILE_ERROR from Kohana::$shutdown_errors, compile errors cause th...
Isaiah DeRose-Wilson
01:51 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Changing the action you're about to execute in the before() method is also a bad idea and is very confusing... redire... Lorenzo Pisani
01:51 am Bug Report #3467 (Closed): to functions with same name in model (ORM) causes to unhandled exception
Fixed in "eaf83f7c8...":https://github.com/kohana/core/commit/eaf83f7c8ef2f633d5359dbddce3a2229f6a2b3e (3.0.x) and in... Isaiah DeRose-Wilson
01:44 am Feature Request #3439: Defined routes should be separate from bootstrap
They do not belong in config files. Config files should not have logic in them and routes with lambda functions would... Lorenzo Pisani
01:40 am Bug Report #3467 (Assigned): to functions with same name in model (ORM) causes to unhandled excep...
This doesn't have anything to do with orm. It's an issue with how the shutdown handler deals with fatal errors. I thi... Isaiah DeRose-Wilson
01:38 am Revision a0ddfbb9: Fixing argument order for test-log phing target
Kiall Mac Innes
01:32 am Feature Request #3466: items per page parameter can be overwrite automatically by query string
This doesn't seem useful, you can already specify the items per page with a single line of code... Lorenzo Pisani
01:30 am Revision 19c61c7f: Re-formatting phing help
Kiall Mac Innes
01:27 am Bug Report #3467: to functions with same name in model (ORM) causes to unhandled exception
Updated description so code is displayed properly. Kiall Mac Innes
01:18 am Revision f6d48fc0: Updating build.xml help target to match the correct task names and adding miss...
Kiall Mac Innes
01:11 am Feature Request #3385: Miscellaneous Files
Everything to be removed, bar release-tag has been removed from the 3.1.x branch.
This includes phpunit.xml - buil...
Kiall Mac Innes
01:08 am Revision fd847446: Removing unnecessary files from the kohana/kohana project. Refs #3385
Kiall Mac Innes
01:08 am Userguide Revision 19368aed: Moving DEVELOPERS.md content from the kohana/kohana project to the userguide.
Kiall Mac Innes
01:01 am Revision d9336231: Removed duplicated git-push target
Kiall Mac Innes
12:59 am Revision 7fa8a179: Minor bugfix to build.xml, and updating checkout order
Kiall Mac Innes
12:47 am Revision e29e30a1: Switched build.xml to phing, part of prep for #3385 (refs #3385)
Kiall Mac Innes

12/08/2010

11:17 pm Bug Report #3467 (Closed): to functions with same name in model (ORM) causes to unhandled exception
try to define 2 member functions with same name in model class (orm)
then when you'll try to instantiate this model,...
Dmitry Selin
05:46 pm Core Revision e46e9ee2: Clarify a file name for the error pages tutorial.
Michael Peters
05:16 pm Feature Request #3466: items per page parameter can be overwrite automatically by query string
@yahasana now I understand the request as you didn't really clarify what you mean and it sounded more like bug report... Kemal Delalic
11:55 am Feature Request #3466: items per page parameter can be overwrite automatically by query string
... Yahasana .
08:52 am Feature Request #3466: items per page parameter can be overwrite automatically by query string
I think that's the point of having the query string and really can't see your point.
P.S. how exactly did you get th...
Kemal Delalic
08:25 am Feature Request #3439: Defined routes should be separate from bootstrap
I put them in @application/routes.php@ and then in bootstrap:... Miodrag Tokić
06:11 am Feature Request #3466 (Closed): items per page parameter can be overwrite automatically by query ...
e.g. ?page=10&items=50 Yahasana .

12/07/2010

10:57 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
@Dmitry,
Once I believed it's cool that return FALSE from before() will suspend execution of the request action, but...
Yahasana .
10:05 pm Feature Request #3308: Arr::set_path() function
> I don't really see the need for this.
>
> @Arr::set_path($array, 'one.two.three.four', 'my value');@
>
> @$arra...
Jeremy Lindblom
09:08 pm Bug Report #3463: User agents is missing mobile detection of ipod touch and ipad
Jeremy is correct that the iPad has been designed as a mobile device, albeit one to revolutionize the term.
When i...
Akiva Levy
08:41 pm Bug Report #3462: Validate class error() AND check() method
Oh I see that point now. Rafał Łyczkowski
06:42 pm Revision 0e5c7778: Updating submodules
Kiall Mac Innes
06:41 pm Userguide Revision bc1e66c1: refs #3464
Kiall Mac Innes
06:40 pm Feature Request #3465 (Closed): Change log level constants to numeric values, and allow for easie...
Kiall Mac Innes
06:40 pm Feature Request #3464 (Closed): Move log level constants from Kohana to Log
Kiall Mac Innes
06:39 pm Image Revision 3e48a2e3: refs #3464
Kiall Mac Innes
06:22 pm Revision 56da95bc: Updating system submodule
Kiall Mac Innes
06:21 pm Core Revision 2238b465: Merge branch 'feature/3464-Move-Log-Constants' into 3.1.x
Kiall Mac Innes
06:20 pm Core Revision 0a8186e9: Fixes #3464 and #3465
Kiall Mac Innes
06:05 pm Core Revision c7432cda: Merge branch '3.0.x' of https://github.com/awellis/core into 3.0.x
Conflicts:
classes/kohana/core.php
Woody Gilk
05:58 pm Core Revision 045cffaa: Moved log level constants to Kohana_Log class, and changed them to integers ra...
Kiall Mac Innes
05:42 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Woody, normally there are 3 main functions executed: @before()@, @action_xxx@ and @after()@
So if I want to skip the...
Dmitry T.
05:19 pm Core Revision 6b2b0691: Removed @access docs, and reformatted some invalid doc to @var type comment
Andrew Ellis
05:03 pm Bug Report #3463: User agents is missing mobile detection of ipod touch and ipad
The iPad uses a mobile version of safari on a mobile version of OS X, but the screen is "large".
It's a coin flip ...
Jeremy Bush
04:42 pm Core Revision d2ce6921: Adding CRITICAL, STRACE, ALERT Kohana constants, fixes #3441
Jeremy Bush
04:41 pm Feature Request #3465 (Closed): Change log level constants to numeric values, and allow for easie...
Change log level constants to numeric values, and allow for easier level range's per log writer
Allow for both:
...
Kiall Mac Innes
04:38 pm Feature Request #3464 (Closed): Move log level constants from Kohana to Log
Move log level constants from Kohana to Log Kiall Mac Innes
04:36 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
No one has answered my question... what happens when you return @FALSE@ in @before()@? If it halts execution, then no... Woody Gilk
04:34 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Dmitry, I can't think of a reason you would want to abort a request that wouldn't be an exception. Adding stuff like ... Isaiah DeRose-Wilson
04:32 pm Bug Report #3463 (Feedback): User agents is missing mobile detection of ipod touch and ipad
That's a bit fuzzy... does the iPad count as a mobile device? It has an almost full sized screen and is arguably more... Woody Gilk
04:31 pm Bug Report #3462: Validate class error() AND check() method
Isaiah is correct, the @error()@ method is supposed by be used by callbacks, not manually. However, it can be used *a... Woody Gilk
04:15 pm Bug Report #3462 (Closed): Validate class error() AND check() method
It doesn't make sense to set an error before check() runs. You can only add errors in your validate callbacks (they r... Isaiah DeRose-Wilson
02:06 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Sure, that's why I've created this request. Maybe you'll find this feature useful too.
Please understand me correct,...
Dmitry T.
12:59 pm Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Dmitry T. wrote:
> Excuse me guys, but we are here not to discuss if am I doing something wrong or not :) We discuss...
Matt Button
11:48 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
> Meanwhile, you can change action name in before() method.
Yes, I know that
> I don't think I'd ever want to skip ...
Dmitry T.
11:25 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Meanwhile, you can change action name in before() method.
If I wanted to display messages and didn't want to resor...
Korney Czukowski
10:23 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Excuse me guys, but we are here not to discuss if am I doing something wrong or not :) We discuss the feature I'm ask... Dmitry T.
08:51 am Bug Report #3463 (Closed): User agents is missing mobile detection of ipod touch and ipad
Fixed by extending user agents config file like so:
'mobile' => array(
'mobileexplorer' => 'Mobile Explorer',
...
Akiva Levy
08:47 am Bug Report #3462 (Closed): Validate class error() AND check() method
I have a problem when I noticed that Validate->check() is clearing _errors array and then ->error() it seems to be us... Rafał Łyczkowski
07:03 am Userguide Revision 1308ff5f: First stage of modifying the userguide template to match the website template
Woody Gilk
04:57 am Userguide Revision d94f3208: Merge remote branch 'bluehawk/docs' into docs_test
Conflicts:
guide/about.install.md
guide/about.upgrading.md
guide/de-de/menu.md
guide/nl/about.conventions.md
gui...
Shadowhand -
04:56 am UnitTest Revision 7e37a5a7: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am Image Revision 01392b02: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am ORM Revision 1732d1d9: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am OAuth Revision 86ea23da: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am Codebench Revision f7bf523b: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am Database Revision 9c6e44d2: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:56 am Cache Revision f7bf523b: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:55 am Cache Revision f78d6a03: Merge remote branch 'bluehawk/docs' into docs_test
Conflicts:
classes/kohana/cache/file.php
classes/kohana/cache/memcache.php
guide/cache.about.md
guide/menu.cache.md
Shadowhand -
04:53 am Auth Revision f2f35965: Merge remote branch 'bluehawk/docs' into docs_test
Shadowhand -
04:52 am Core Revision 4030888d: Merge remote branch 'bluehawk/docs' into docs_test
Woody Gilk
03:09 am Database Revision e462c0eb: Coding style updates
Isaiah DeRose-Wilson
02:06 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Or if you want to display an error message without a redirect throw an exception and catch it in your bootstrap to di... Isaiah DeRose-Wilson
01:55 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
... Rowan Parker
01:45 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
OK, let's rephrase. Instead of "do not execute the action" let's say "Skip action", "Skip after() function" etc.
>...
Dmitry T.
01:25 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
In the example you gave you can redirect the user to a login page.
I agree with Woody, just saying "do not execute th...
Matt Button
12:13 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Woody Gilk wrote:
> And then what happens?
Then request response is displayed without executing any action
How can ...
Dmitry T.
12:12 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
Or even better to add properties to controller:... Dmitry T.
12:11 am Feature Request #3461: Do not execute action if Controller::before() returns FALSE
And then what happens? Woody Gilk
12:05 am Feature Request #3461 (Closed): Do not execute action if Controller::before() returns FALSE
Useful i.e. for checking if user has permissions to the page... Dmitry T.

12/06/2010

04:20 pm Bug Report #3460 (Closed): Upload::save() UTF-8 problem
I've run into a weird issue when trying to upload a couple of files with international names. Most were uploaded just... Korney Czukowski
09:23 am Bug Report #3393: PHPUnit 3.5.x addFileToFilter
#3369 Fixed this Matt Button
07:14 am Feature Request #2522: $i18n and language substring
You can also add your language string representation to i18n files:
i18n/en.php
return array(
'js_loca...
Korney Czukowski
07:10 am Feature Request #2431: I18n plural_form function
https://github.com/czukowski/I18n_Plural
This is how I've implemented it. There's still quite a lot of room to imp...
Korney Czukowski
04:56 am Revision f4d18df9: Merge branch '3.1.x' of github.com:kohana/kohana into 3.1.x
Isaiah DeRose-Wilson
04:56 am Revision d2777cda: Updating system
Isaiah DeRose-Wilson
04:55 am Core Revision 46b123f4: Coding style cleanup.
Isaiah DeRose-Wilson
04:47 am Bug Report #3459 (Closed): lambda call in header.php needs to be removed
The uasort() lambda call in header.php needs to be removed for php 5.2 compatibility. Isaiah DeRose-Wilson
04:25 am Core Revision c88fef06: Coding style fixes, refs #3167
Isaiah DeRose-Wilson
04:14 am Core Revision 0cb8c08e: Fix an absolute url to my test machine (oops) and clarify that index_file is o...
Michael Peters
04:02 am Feature Request #3036 (Closed): Kohana_Log_File::write() should be made more flexible so the app ...
Kohana_Log_File is now transparently extendable, I don't think these extra options are necessary anymore.
Feel fre...
Kiall Mac Innes
03:46 am Bug Report #2102: Request::execute overrides HTTP headers on thrown exception.
In fact - I believe this has already been resolved with Sam's to be pushed changes:
> Yes, the HTTP status concept...
Kiall Mac Innes
03:44 am Bug Report #2102: Request::execute overrides HTTP headers on thrown exception.
I'd like to wait for Sam's Request/Response 3.1 changes to be pushed before we tackle this ticket. Should be any day ... Kiall Mac Innes
03:41 am Bug Report #3393 (Closed): PHPUnit 3.5.x addFileToFilter

Works here .. I'm running both the 3.0.x and 3.1.x branch's tests on phpunit 3.5 without error.
Kiall Mac Innes
03:34 am Feature Request #2431: I18n plural_form function
I'm really not sure I like the implementation of this, using @create_function()@ seems wrong ..
I think we need to ...
Kiall Mac Innes
03:15 am Feature Request #2522 (Closed): $i18n and language substring
If you only want "en" rather than "en-us", "en-gb" etc, then simply set the language to "en" as Dos Moonen suggests, ... Kiall Mac Innes
03:13 am Revision 3487a193: Adding File::mimes_by_ext() and File::exts_by_mime() - refs #3167
Kiall Mac Innes
03:10 am Core Revision 0c1e4b43: Cleanup cs278's commits for coding style and fix a bug preventing transparant ...
Kiall Mac Innes
03:07 am Core Revision ff869071: Correct method signature for Kohana standard
Chris Smith
03:07 am Core Revision 9a0e3fdd: Added various methods for file extension to MIME lookups and vice-versa
* mimes_by_ext() gets a list of MIMEs associated with an extension
* exts_by_mime() gets a list of extensions associa...
Chris Smith
03:07 am Feature Request #3167 (Needs Test): Additional MIME handling methods for File
Merged in:
https://github.com/kohana/core/commit/ff869071662dbf029423549eb53ea566e00a4fb4
https://github.com/kohana...
Kiall Mac Innes
03:00 am Revision 0668002c: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:55 am Revision b730be82: Fixing unittest failures caused by my previous commit - refs #3129
Kiall Mac Innes
02:54 am Feature Request #3129 (Closed): Recreate Log/Config classes
Kiall Mac Innes
02:53 am Core Revision 778337e1: Fixing unittest failures caused by my previous commit - refs #3129
Kiall Mac Innes
02:53 am Feature Request #3129: Recreate Log/Config classes
https://github.com/kohana/kohana/commit/0668002cea39f0eb2cab34bcf25715d9f41f6446
https://github.com/kohana/core/comm...
Kiall Mac Innes
02:47 am Revision 9ef76b55: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:44 am Userguide Revision eea0e04c: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:42 am Cache Revision b40b251b: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:40 am UnitTest Revision 8ddb4a8b: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:39 am Revision e09ab2da: Updating system
Isaiah DeRose-Wilson
02:36 am Database Revision c0d0f500: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
02:32 am Core Revision a313c99b: Merge branch 'feature/3126-log-config-transparent-extension' into 3.1.x
Kiall Mac Innes
02:25 am Core Revision 2af1f678: Adding transparent extension support to Log and Config classes - refs #3129
Kiall Mac Innes
01:56 am Revision 981947e1: Copying build.xml from Kohana 3.0.x branch.
Kiall Mac Innes
01:55 am Revision 4281bdaf: Updaing build.xml to run tasks in parallel where possible.
Kiall Mac Innes
12:16 am Revision baf896b0: Updating submodules to test Hudson
Isaiah DeRose-Wilson
12:13 am ORM Revision 346f52b8: Fixed coding style issues.
Isaiah DeRose-Wilson

12/05/2010

11:50 pm ORM Bug Report #3457: count_all does not use $_load_with
I have added load with loop into count_all():... Tomek Rychlik
11:44 pm Revision 5fd39320: Updating ORM submodule
Isaiah DeRose-Wilson
11:42 pm ORM Bug Report #3126 (Closed): ORM marks column as changed even if the value remained the same
Fixed in "a2223d993...":https://github.com/kohana/orm/commit/a2223d993c86791acbd2419c67953a759baf652e Isaiah DeRose-Wilson
11:35 pm ORM Revision a2223d99: Added check to see if $value was really changed in ORM::set(), fixes #3126
Isaiah DeRose-Wilson
10:47 pm ORM Feature Request #3458 (Closed): ORM should provide errors() after check()
You are looking for @$model->validate()->errors()@ Isaiah DeRose-Wilson
09:53 pm ORM Feature Request #3458 (Closed): ORM should provide errors() after check()
Currently ORM model provides validation with @check()@ but it gives nothing but @true@ or @false@, while often it is ... Andrey Vyrodov
05:08 pm ORM Bug Report #3457 (Closed): count_all does not use $_load_with
... Tomek Rychlik
03:10 pm Database Bug Report #2188: Database PDO dosn't support last inserted id in PGSQL Driver
SQL Server >= 2005 also has the "@OUTPUT@ SQL syntax":http://msdn.microsoft.com/en-us/library/ms177564.aspx which beh... Chris Bandy
05:20 am Feature Request #3308: Arr::set_path() function
I don't really see the need for this.
@Arr::set_path($array, 'one.two.three.four', 'my value');@
@$array['one']['...
Lorenzo Pisani
« Previous
Next »
 

Also available in: Atom