KohanaPHP » Kohana v3.x

01/29/2011

11:33 pm Auth Bug Report #3670 (Closed): Auth logged_in always returns true even if the user isn't logged in.

That line https://github.com/kohana/auth/blob/3.1%2Fdevelop/classes/kohana/auth.php#L135 should either be:
return ($... Sören Z.

10:45 pm Bug Report #3669 (Closed): wrong link to coding style in conventions page of userguide

The first paragraph on this page: http://kohanaframework.org/guide/kohana/conventions has a link on the words "coding... Anonymous

07:41 pm Feature Request #3666: Some added functionality in CLI

The Fuel CLI class is interesting: https://github.com/fuel/fuel/blob/develop/fuel/core/classes/cli.php
Some of the... Kiall Mac Innes

06:49 pm Bug Report #3667: Route method is_external() does not work

And when this is resolved, there is a continuing problem in the ... Michal Kocian

06:00 pm Bug Report #3668 (Closed): Unused property $_http_view in Kohana_Http_Exception

There is a property which is never used and referenced view does not exist.... Michal Kocian

05:47 pm Bug Report #3667 (Closed): Route method is_external() does not work

There is ... Michal Kocian

06:59 am Bug Report #3658: Validation should use the method name as the error rule

Sorry for the long delay! https://github.com/kohana/core/pull/73 Lorenzo Pisani

06:57 am Core Revision 25b97366: adding unittest (refs #3658)

Lorenzo Pisani

06:32 am Feature Request #3666 (Closed): Some added functionality in CLI

It would be nice to have @CLI::input()@, @CLI::output()@, and @CLI::error()@ to work with @STDIN@, @STDOUT@, and @STD... Lorenzo Pisani

01/28/2011

09:07 pm Feature Request #3661: Add a generic valid rule for comparing 2 fields

I suggest not adding the error manually but just returning true/false, the rule can accept data arrays other than Val... Lorenzo Pisani

06:20 pm Userguide Bug Report #3665: Filter does not work on API Browser.

GitHub Pull Request: https://github.com/kohana/userguide/pull/18 Andrew Ellis

06:20 pm Userguide Bug Report #3665 (Closed): Filter does not work on API Browser.

Currently when you type a search query into the box on the API browser, nothing is filtered. This is due to some jQue... Andrew Ellis

06:17 pm Userguide Revision c58239c3: Fixed fiter search for API Browser.

Andrew Ellis

02:37 pm UnitTest Bug Report #3663: DOCROOT is wrong

This fixed it for me in a typical setup, but it depends on where the module is installed. Maybe DOCROOT should move u... Chris Bandy

02:32 pm Bug Report #3664: Fatal error: Undefined class constant 'ERROR' in "session.php" on line 371

Please fix the docs also
https://github.com/kohana/core/blob/3.1%2Frelease%2F3.1.0/guide/kohana/tutorials/error-page... Dmitry T.

01/27/2011

10:00 pm Bug Report #3664 (Closed): Fatal error: Undefined class constant 'ERROR' in "session.php" on line...

It seems that this was the old way to define the call for the log
https://github.com/kohana/core/blob/3.1%2Fdevelo... Nano Documet

09:10 pm UnitTest Bug Report #3663 (Closed): DOCROOT is wrong

When using unittest/bootstrap.php to bootstrap PHPUnit, DOCROOT gets set to the directory containing unittest/bootstr... Chris Bandy

08:49 pm Core Revision 0e363a9b: the error name depends on the format of the rule (refs #3658)

lambda functions cannot simply return FALSE to set an error, they must set it manually on the validation object
array... Lorenzo Pisani

03:32 pm Bug Report #3662 (Closed): Kohana_Request::__construct() should throw HTTP_Exception_404

Jeremy Bush

12:50 pm Bug Report #3662 (Closed): Kohana_Request::__construct() should throw HTTP_Exception_404

Current Kohana_Request::__construct() does this when a route is not found (line 695 ):... Luke Morton

09:21 am Cache Bug Report #3407 (Feedback): cache file garbage collect delete git file

It seems that first two conditions are unnecessary anymore after adding third condition. Alexey Zagaichuk

05:44 am Feature Request #3661 (New): Add a generic valid rule for comparing 2 fields

In some of my ORM models I have fields which need to be greater than or less than other fields in the same model. In ... Rowan Parker

02:19 am Core Revision 3fd4ca86: Just for consistency updated text to match Kohana::FILE_SECURITY

Signed-off-by: Woody Gilk <[email protected]> Nick Gregory

02:17 am Core Revision e051609a: Just for consistency updated text to match Kohana::FILE_SECURITY

Signed-off-by: Woody Gilk <[email protected]> Nick Gregory

01/26/2011

11:35 pm ORM Support Request #3660 (Closed): ORM exception

Thanks for the answer Rowan! Isaiah DeRose-Wilson

09:36 pm ORM Support Request #3660: ORM exception

You can:... Rowan Parker

07:22 pm ORM Support Request #3660 (Closed): ORM exception

Why ORM throws exception when Validation fails.... Damian Stasik

12:58 pm Bug Report #3657: Environments and KOHANA_ENV

I usually check @$_SERVER@ and fallback to @getenv()@ but I've no idea why there is a variance between PHP installati... Chris Smith

02:10 am Bug Report #3658 (Assigned): Validation should use the method name as the error rule

Jeremy Bush

02:08 am Feature Request #3555 (Closed): .htaccess on fast-cgi

The default rewrite rules work fine for me in fcgi. If you are still having issues with this please paste the content... Isaiah DeRose-Wilson

01:59 am Bug Report #3657: Environments and KOHANA_ENV

I'm not really sure I see the reason for including $_SERVER in this. Yes environmental variables can be included in $... Isaiah DeRose-Wilson

12:02 am Bug Report #3659 (Closed): Irregular Inflector class term

release => releases needs to be added to the irregular inflector terms (thanks Zeelot) Ryan Pilbeam

01/25/2011

11:43 pm Bug Report #3658: Validation should use the method name as the error rule

Just want to add that this is the same idea as to why Valid::not_empty() creates an error for 'not_empty' Lorenzo Pisani

11:42 pm Bug Report #3658 (Closed): Validation should use the method name as the error rule

If the following rule fails:... Lorenzo Pisani

10:42 pm Bug Report #3657 (Closed): Environments and KOHANA_ENV

Environmental variables are passed in $_ENV global array only if they are set on the system, otherwise they are usual... Karol Janyst

09:40 pm Feature Request #3656 (Closed): Allow Route::defaults() to return the defaults if no parameters a...

I would like to be able to do @Route::get('something')->defaults()@ and get the default values for that route. This i... Lorenzo Pisani

04:11 pm Bug Report #3655 (Closed): Email address obfuscation

I noticed my client started receiving spam on a shiny new website, where he wanted to have his name @ hiswebsite emai... Gah Gneh

11:26 am Bug Report #3653 (Closed): exception_handler does not exit with proper status code

If I throw an exception via CLI in Kohana then it should exit with that exception code.
A quick look at Kohana::exce... Marcel Evenson

09:39 am Image Revision ce5919a2: ImageMagick Driver for the KO3 Image Module

tamas mihalik

06:32 am Bug Report #3652 (Feedback): Validation bind() should allow callbacks, closures

The value of a parameter added by bind() should allow callbacks/closures. Without this simple change, it is impossibl... Ben Midget

03:15 am Bug Report #3643: Request->_status = 404; will never be observable

There's another issue to change how this is handled. Unfortunately it will have to wait for 3.2. Jeremy Bush

12:51 am Bug Report #3643: Request->_status = 404; will never be observable

I think this got mangled somewhere between my original implementation and the latter altered version. 404 status' sho... Sam de Freyssinet

01/24/2011

11:52 pm Auth Bug Report #3649 (Closed): ORM's Auth driver still returns multiple data types

What? Isaiah DeRose-Wilson

11:06 pm Core Revision 244c32ec: Docs: Update error-pages tutorial for 3.1, misc typos

Jeremy Bush

10:42 pm Core Revision 810f8802: Docs: Move content from orphan model.md to mvc/models.md

Jeremy Bush

10:40 pm Core Revision f33172ac: Docs: typos

Jeremy Bush

10:40 pm Core Revision 7a5bae31: Docs: removing routing empty routing tutorial

Jeremy Bush

09:50 pm Auth Bug Report #3649 (Closed): ORM's Auth driver still returns multiple data types

Dino Krtanjek

07:24 pm Core Revision b04a22a7: Docs: Fixing typos

Jeremy Bush

07:24 pm Core Revision ca7c8a2c: Adding basic model docs

Jeremy Bush

06:07 pm Database Feature Request #3625: Creating tables in database

We are talking about using something like the "real-database module":https://github.com/cbandy/real-database in 3.2 (... Isaiah DeRose-Wilson

05:22 pm Database Feature Request #3625: Creating tables in database

I think if this feature will be implemented then all DDL operations should be supported by the Database module. Furth... Bence Eros

05:10 pm Bug Report #3526 (Closed): Wrong Kohana version

Works for me, see "d57cd5bb...":https://github.com/kohana/core/commit/d57cd5bbdc0cd7184cf71ffc3021d48dee714868 Isaiah DeRose-Wilson

05:06 pm Auth Bug Report #3630 (Assigned): coding standard violation: Variables should precede constants in com...

Isaiah DeRose-Wilson

05:01 pm Core Revision 5e3a93d0: Docs: adding upgrade note about index.php/bootstrap.php

Jeremy Bush

04:55 pm Feature Request #3635: Checking if module is active

I fixed the issue and improved the error handling of the method (now it throws an exception if a module path is not a... Bence Eros

04:27 pm Feature Request #3648: Return a Request instance for requests which do not match any routes

It's only related to #3647 as I posted the suggestion as part of that description, rather than a new issue as I shoul... Marcus Cobden

04:24 pm Feature Request #3648 (Closed): Return a Request instance for requests which do not match any routes

Currently the constructor of the request class throws an exception if it doesn't match a route, this will prevent you... Marcus Cobden

04:21 pm Auth Bug Report #3644 (Closed): Attempt to use get_user() function

This has been fixed in "fc8781e926c8...":https://github.com/kohana/auth/commit/fc8781e926c88b214abb154af94ff83b237f19... Isaiah DeRose-Wilson

03:39 pm Bug Report #3643: Request->_status = 404; will never be observable

Actually fdabce.
$this->_status = 404; line should be gone, as requests don't have statuses. Jeremy Bush

03:37 pm Core Revision fdabce37: Throw 404 exception is no routes match the uri. Fixes #3643

Jeremy Bush

03:36 pm Bug Report #3643 (Closed): Request->_status = 404; will never be observable

Fixed by 48482a. Jeremy Bush

03:34 pm Feature Request #3647 (Closed): Throw a Http_Exception_404 if no routes match a request

Closing this because the current behavior is a bug and can be fixed with the associated issue. Jeremy Bush

03:33 pm Bug Report #3643: Request->_status = 404; will never be observable

Kiall Mac Innes wrote:
> I believe this should just be throwing a 404 execption..
I'd agree, a uri without a matc... Jeremy Bush

03:26 pm Bug Report #3643 (Assigned): Request->_status = 404; will never be observable

I believe this should just be throwing a 404 execption..
Sam would know for sure ;) Kiall Mac Innes

03:21 pm Bug Report #3643: Request->_status = 404; will never be observable

This bug is now sort of eclipsed by the related feature request.
If the feature request is declined I'd suggest co... Marcus Cobden

03:12 pm Feature Request #3647 (Closed): Throw a Http_Exception_404 if no routes match a request

It might be good to throw a @Http_Exception_404@ instead of a @Kohana_Request_Exception@ if no routes match a request... Marcus Cobden

03:08 pm Core Revision bb61e727: Bunches of 3.1 doc updates, all over the place

Jeremy Bush

02:32 pm Core Revision a39cd8ae: Updates to userguide: upgrading from 3.0, exception handling, etc

Jeremy Bush

02:31 pm Bug Report #3646 (Closed): Bad form action

I assume you are talking about 3.1, and this is expected behavior in 3.1. Jeremy Bush

02:14 pm Bug Report #3646 (Closed): Bad form action

This code:... Damian Stasik

12:01 pm Feature Request #3645: Session::get should use Arr::path

Or maybe add a new function and name it like @Session::get_path/set_path@? Dmitry T.

12:00 pm Feature Request #3645 (New): Session::get should use Arr::path

Now it's inconvenient to get values from nested session arrays. You have to do something like:... Dmitry T.

11:37 am Auth Bug Report #3644 (Closed): Attempt to use get_user() function

When I try to use one of Auth module function (get_user), I get this error:... Damian Stasik

10:58 am Bug Report #3643 (Closed): Request->_status = 404; will never be observable

Forgive me if I'm missing something here but with the following code in the constructor of the Request class:

//... Marcus Cobden

12:47 am Feature Request #3141: Config merging should treat non-associative array elelemts as unique

I actually prefer replacing non-associative arrays to treating them as associative, as proposed in #3642. I recommend... Woody Gilk

12:46 am Bug Report #3642: Arr::merge() shouldn't treat non-associative arrays differently than associative.

Avoiding the bug doesn't fix the bug ;)
It's not specific to config reading, it's a flaw in arr::merge() which was... Jeremy Bush

12:44 am Bug Report #3642 (Feedback): Arr::merge() shouldn't treat non-associative arrays differently than...

I don't think this is a good idea. IMO, the proper solution is to make that array associative by naming each server *... Woody Gilk

12:42 am Feature Request #3141: Config merging should treat non-associative array elelemts as unique

This is fundamentally broken because you wouldn't be able to remove system/module level config values. See #3642. Jeremy Bush

12:40 am Bug Report #3642: Arr::merge() shouldn't treat non-associative arrays differently than associative.

Note my sittercity patch could be optimized by just not having the if/else block. Jeremy Bush

12:37 am Bug Report #3642 (Closed): Arr::merge() shouldn't treat non-associative arrays differently than a...

I don't think arr::merge() should treat non-associative arrays any differently than associative.
The specific prob... Jeremy Bush

12:27 am Bug Report #3604: Kohana_Session_Native should optionally Cookie Parameters when calling session_...

> Wouldn't it be better to call Cookie::$domain = ini_get(...);?
Perhaps, but I don't think this should be expecte... Jeremy Bush

01/23/2011

11:03 pm Bug Report #3313 (Closed): Request::detect_uri must never return FALSE

Unit test added in https://github.com/kohana/core/commit/63fbc5c0ac04e452910c7c9779d79d2195a3341e Woody Gilk

11:01 pm Core Revision 63fbc5c0: Added unit test for #3313

Woody Gilk

07:45 pm Bug Report #3420 (Closed): Kohana_Remote get method has hardcoded CURLOPT_RETURNTRANSFER

Applied in changeset commit:277decf108647ad7391584a896707c761fe5e284. Anonymous

07:44 pm Core Revision 277decf1: Put CURLOPT_RETURNTRANSFER in the Remote default options to allow it to be ove...

Woody Gilk

07:42 pm Bug Report #3604 (Assigned): Kohana_Session_Native should optionally Cookie Parameters when calli...

Wouldn't it be better to call @Cookie::$domain = ini_get(...);@? There really is no way to fix this, because the cook... Woody Gilk

07:39 pm Feature Request #3010 (Closed): Compile routes only if required

No additional information or any tests provided. Woody Gilk

07:38 pm Bug Report #3414 (Closed): Arr::path() doesn't work when the key is FALSE (NULL, 0, emptry string)

You example returns @FALSE@ for me, I think this is invalid. The only time the default would be returned instead of t... Woody Gilk

07:32 pm Bug Report #2957 (Feedback): Make sure Session::write is called last

I think closing #3454 also closes this. In fact, the fix for #3454 probably makes using @register_shutdown_function@ ... Woody Gilk

07:27 pm Bug Report #3454: Session is not closed prior to writing files, can cause delays with site

This likely needs to be merged into 3.1 as well. Woody Gilk

07:26 pm Bug Report #3454 (Closed): Session is not closed prior to writing files, can cause delays with site

Fixed by https://github.com/kohana/core/commit/c53bef31cfbadc32b84549b30c7fb371ceb35b91 Woody Gilk

07:26 pm Core Revision c53bef31: Write all sessions when calling Request::send_headers, fixes #3454

Woody Gilk

07:12 pm Feature Request #3641 (Closed): Make Session::$instances public

Fixed by https://github.com/kohana/core/commit/30fccab093507cbddd9ae9fddd6332100d20e283 Woody Gilk

07:12 pm Core Revision 30fccab0: Made Sesssion::$instances public, fixes #3641

Woody Gilk

07:12 pm Feature Request #3641 (Closed): Make Session::$instances public

There is no good reason for @Session::$instances@ to be protected. It prevents people from doing clever things. Woody Gilk

07:08 pm Database Bug Report #3404 (Closed): Error creating Exception object for SQLSTATE[42S22]: Column not found:...

Fixed by https://github.com/kohana/database/commit/f2e5662d373e8d5847ee12c3e27c8210500bb5d2 Woody Gilk

07:08 pm Database Bug Report #3358 (Closed): pdo Database_Exception vs pgsql

Fixed by https://github.com/kohana/database/commit/f2e5662d373e8d5847ee12c3e27c8210500bb5d2 Woody Gilk

07:07 pm Database Revision f2e5662d: Moving all error codes into messages for Database_Exception calls, fixes #3404

Woody Gilk

05:56 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

Isaiah DeRose-Wilson wrote:
> With a normal php install on windows, the php that is added to the system path is the ... Alexey Popov

04:10 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

With a normal php install on windows, the php that is added to the system path is the cli build. So if you type 'php ... Isaiah DeRose-Wilson

03:51 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

Kiall Mac Innes wrote:
> I would have imagined the windows builds of PHP come with a CLI sapi.. If they dont, an alte... Alexey Popov

03:41 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

I just downloaded php-5.3.5-Win32-VC6-x86.zip from http://windows.php.net.. It includes two executables. the CLI sapi... Kiall Mac Innes

03:34 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

I would have imagined the windows builds of PHP come with a CLI sapi.. If they dont, an alternative method of trigger... Kiall Mac Innes

03:27 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

> Examples
> (This is what you use for running cli scripts)
So, what, then, should I do if I'm using to develop W... Alexey Popov

03:18 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

Kiall Mac Innes wrote:
> I should also point out .. your patch is backwards .. you diff'ed the files in the wrong or... Alexey Popov

03:16 pm Feature Request #3640 (Closed): Add ORM models for the Auth module

They already are ;)
https://github.com/kohana/orm/tree/3.1%2Fdevelop/classes/model Kiall Mac Innes

03:14 pm Feature Request #3640 (Closed): Add ORM models for the Auth module

The ORM models for Auth should be included in ORM. I know that one can use ORM without Auth, but it's far more likely... Dino Krtanjek

03:10 pm Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi

I have no idea how the status and resolution changed on my last comment :/ Kiall Mac Innes

03:09 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi

(oops too slow!)
I don't think this is an issue. The problem is you are using the wrong php to run your code. If you... Isaiah DeRose-Wilson

03:07 pm Bug Report #3638 (Assigned): Invalid parameter Kohana::$is_cli if PHP is running as fcgi

I should also point out .. your patch is backwards .. you diff'ed the files in the wrong order :) Kiall Mac Innes

03:03 pm Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi

the @Kohana::$is_cli@ flag is not intended to determine if your application is running under the cgi or fcgi sapi.
I... Kiall Mac Innes

12:29 pm Patch #3639 (Closed): Remove unnecessary comment

In 3.1.x file @base.php@ was removed, but there still is an unnecessary comment in i18n.php.... Damian Stasik

10:48 am Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi

When PHP is running as cgi-process, parameter Kohana::$is_cli returns FALSE.
It doesn't matter, we call the script ... Alexey Popov

05:20 am ORM Bug Report #3632 (Closed): Wildcard filters should run first

Fixed in "af3137ed332...":https://github.com/kohana/orm/commit/af3137ed33244a18909ab25a5f417e759ac6a224
Thanks! Isaiah DeRose-Wilson

05:18 am ORM Revision af3137ed: making wildcard filters run first (refs #3632)

Lorenzo Pisani

01/22/2011

10:54 pm Bug Report #3637 (Closed): Incorrect doc comment in Arr::overwrite

Fixed by https://github.com/kohana/core/commit/bcbaaef5ecafc18d26aed36f9c1e7e1bda9eb425 Woody Gilk

10:54 pm Core Revision bcbaaef5: Typo in Arr::overwrite, fixes #3637

Woody Gilk

10:53 pm Bug Report #3637 (Closed): Incorrect doc comment in Arr::overwrite

From Ian Chilton:
> There is a mistake in the overwrite example:
>
> // The output of $array will now be:
> ar... Woody Gilk

10:51 pm ORM Bug Report #3632: Wildcard filters should run first

https://github.com/kohana/orm/pull/22 Lorenzo Pisani

10:48 pm Core Revision b2049c7d: Typo in documentation guide/upgrading

Woody Gilk

10:31 pm Bug Report #3636 (Closed): Incorrect doc comment in Validate::errors

Fixed by https://github.com/kohana/core/commit/06f5a27c58fce60410d1698b59f55cb194769e3e
Documentation only, does n... Woody Gilk

10:30 pm Core Revision 06f5a27c: Fixed incomplete and incorrect doc comment for Validate::errors, fixes #3636

Woody Gilk

10:30 pm Bug Report #3636 (Closed): Incorrect doc comment in Validate::errors

Andrew Hunt notified me that there is a rather misleading doc comment in Validate::errors.
> There is a slight bug... Woody Gilk

09:57 pm Bug Report #3634 (Assigned): Cannot set external request options

Isaiah DeRose-Wilson

03:26 pm Image Feature Request #3563: static function valid() to validate image

Hi.
Please consider to return TRUE by method Upload::image() if there was no file uploaded, cause now it returning F... Tiger SEO

11:58 am Feature Request #3635 (Closed): Checking if module is active

@Kohana::modules@ should be able to check if the module is active.... Damian Stasik

01:24 am ORM Bug Report #3632 (Assigned): Wildcard filters should run first

I agree, please do a pull request with this fix and it will get applied. Isaiah DeRose-Wilson

01/21/2011

10:18 pm Bug Report #3634 (Closed): Cannot set external request options

In Kohana_Request_Client_External there is a property called $_options but no way to set that with any values.
https... Bob Eagan

10:12 pm Bug Report #3633 (Closed): Missing remote.php config for request

This file is referenced here but does not exist:
https://github.com/kohana/core/blob/3.1%2Frelease%2F3.1.0/classes... Bob Eagan

10:07 pm Bug Report #3000: Config system rewrite

No, I'm afraid not; 3.1 is feature complete - only bug fixes are being accepted now.
You can extract the changes f... Matt Button

09:11 pm Bug Report #3000: Config system rewrite

Any chance of this feature making it's way in during a 3.1.x release? The application I'm build really needs this fea... Andrew Ellis

06:11 pm ORM Bug Report #3632 (Closed): Wildcard filters should run first

Currently, wildcard filters are being appended to the array of filters for a field, but I think they should be run fi... Lorenzo Pisani

04:26 pm Feature Request #3631 (Closed): Response::bodyAppend()

The standard way of adding content to the response body in 3.1 is with the Response::body() method. I think it would ... Oliver Stollmann

03:42 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface

Yeah, was not feeling 100% when writing that. Stepping away from keyboard until home. Thanks for fix Kiall. Sam de Freyssinet

03:25 pm Auth Bug Report #3630: coding standard violation: Variables should precede constants in comparison ope...

For readability - that should probably be surrounded by brackets aswell.
Not sure what the CodingStyle says about ... Kiall Mac Innes

03:22 pm Auth Bug Report #3630: coding standard violation: Variables should precede constants in comparison ope...

https://github.com/kohana/auth/pull/8
Change should be applied to both 3.0 and 3.1 branches Bob Eagan

03:22 pm Auth Bug Report #3630 (Closed): coding standard violation: Variables should precede constants in compa...

auth / classes / kohana / auth.php (line 151)... Bob Eagan

02:58 pm Cache Bug Report #3629 (Closed): Cache_Apc::get() not using correct APC interface

The APC driver does not handle retrieving values from cache correctly, allowing FALSE value to return the default val... Jeremy Bush

02:45 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface

This is a candidate for 3.0 Chris Bandy

02:12 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface

@Bence: I believe you're right, Sam's on holidays snowboarding .. he probably shouldn't be writing code ;)
Ill fix... Kiall Mac Innes

01:46 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface

this commit seems to be a bit strange for me..
@return $success ? $default : $data;@
wtf? I think it should be
@... Bence Eros

01:27 pm Bug Report #3531: Response body should be converted into string only when output is generated

Jeremy Bush wrote:
> We discussed this at great length, and decided it was best if it was converted to a string when... Paul Dixon

03:49 am Bug Report #3628 (Closed): 3.1RC2 - External POSTing Request, not sending post key/value pairs

I have gone through the code for a few hours and to me (please correct me if I am wrong) it does not seem possible to... Sam de Freyssinet

01:01 am Cache Revision 9e7ae17f: Refs #3627. Fixed the APC interface to handle FALSE values correctly

Sam de Freyssinet

12:52 am Cache Bug Report #3627 (Closed): Cache_Apc::get() not using correct APC interface

The APC driver does not handle retrieving values from cache correctly, allowing FALSE value to return the default val... Sam de Freyssinet

01/20/2011

11:52 pm Feature Request #3341: Add before_$action and after_$action support to Request class.

Can't you just put any code that you would put in before_$action or after_$action into the action itself. The only c... Wade Christie

08:13 pm Auth Feature Request #3295 (Closed): Model_Auth_User_Token::create_token() needs improvement

Fixed by "9720af86d0...":https://github.com/kohana/orm/commit/9720af86d005d3590bb85f204e753cee520c4507 Isaiah DeRose-Wilson

07:25 pm Auth Bug Report #3611 (Closed): Auth - The _now property does not exist in the Model_User_Toke

Fixed by "9720af86...":https://github.com/kohana/orm/commit/9720af86d005d3590bb85f204e753cee520c4507 Isaiah DeRose-Wilson

07:22 pm Auth Bug Report #3612 (Closed): ORM - unique_id doesn't exist.

Thanks! Fixed by "1d70bde920...":https://github.com/kohana/orm/commit/1d70bde920dedaeddeba528ac0275415d834c112 Isaiah DeRose-Wilson

07:21 pm ORM Revision 92100812: Merge branch '3.1/develop' of github.com:kohana/orm into 3.1/develop

Isaiah DeRose-Wilson

07:20 pm ORM Revision 9720af86: Added token generation method, and make it check the database to enforce uniqu...

Isaiah DeRose-Wilson

07:19 pm ORM Revision 1d70bde9: User agent should be hashed, fixes #3618

Removed token generation, tokens are generated by the token model automatically (see #3295), fixes #3612 Isaiah DeRose-Wilson

07:17 pm Auth Bug Report #3618 (Closed): ORM - _login() does not sha1 the user agent

Fixed by "1d70bde9...":https://github.com/kohana/orm/commit/1d70bde920dedaeddeba528ac0275415d834c112 Isaiah DeRose-Wilson

04:27 pm Patch #3626: Session pattern and configuration changes

Thank you, not sure why Google didn't return that earlier. I think I've corrected them all now. Stuart Harland

03:54 pm Patch #3626: Session pattern and configuration changes

The "code style guide":http://kohanaframework.org/guide/kohana/conventions for 3.x is located in the userguide under ... Isaiah DeRose-Wilson

03:19 pm Patch #3626: Session pattern and configuration changes

Now I have located the coding style guide (the only one I could locate was the one relating to v2). The code has been... Stuart Harland

02:12 pm Patch #3626: Session pattern and configuration changes

Also, your commit doesn't follow our coding standards. Please review them and update your code if it's going to be me... Jeremy Bush

02:11 pm Patch #3626: Session pattern and configuration changes

The session class design has known problems, and was going to be reviewed for re-writing in 3.2. We'll keep this tick... Jeremy Bush

01:59 pm Patch #3626 (Assigned): Session pattern and configuration changes

Note this patch has a pull request https://github.com/kohana/core/pull/68
This patch covers multiple Problems.
... Stuart Harland

12:15 pm Database Feature Request #3625 (New): Creating tables in database

Is it possible to add new query type - creating tables in database.
Code e.g.... Damian Stasik

01/19/2011

06:57 pm ORM Bug Report #3624: ORM count_all() with $_load_with

GitHub Pull Request: https://github.com/kohana/orm/pull/21 Andrew Ellis

06:55 pm ORM Bug Report #3624 (Closed): ORM count_all() with $_load_with

Currently, when you define $_load_with on an ORM model, and call count_all(), the models via $_load_with are not set.... Andrew Ellis

06:20 pm Bug Report #3623 (Closed): Any reason why request->protocol() returns in uppercase?

https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/request.php#L1132
Makes my Url::base(Request::$cu... Nano Documet

01/18/2011

08:38 pm Bug Report #3622 (Closed): whitespace rule for type casting is incorrect when tabs precede type

A single line statement like so:... Bob Eagan

08:03 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db

Cool, I understand.
But let's say you create a new, empty user record, then pass it off to another library that has ... Ben Midget

07:25 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db

I will talk with other devs and see what they say, but I don't really see this as something that is important to chan... Isaiah DeRose-Wilson

06:44 pm Bug Report #3621 (New): no rule for hanging parentheses with arrays

The proper way to do arrays is:... Bob Eagan

05:59 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db

What about the interrim fix for queueing add() on records not yet in the database? Because right now it just throws e... Ben Midget

04:11 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db

This is how ORM worked in 2.x. I can see the advantages to having save() save the relationships instead of making the... Isaiah DeRose-Wilson

12:43 pm Image Feature Request #3563: static function valid() to validate image

I know you guys work very hard for the new coming release of Kohana, but I don't believe 3.2 will be there after 6 mo... Yahasana .

11:36 am Image Feature Request #3563: static function valid() to validate image

https://github.com/kohana/kohana/wiki/Kohana-Development-Procedures
It's our policy is to not introduce new features... Jeremy Bush

10:53 am Feature Request #3617: Pagination module for 3.1?

I'm replying from my phone .. so no code examples just now ;)
Re the bootstrap - I believe it has already been rem... Kiall Mac Innes

10:50 am Feature Request #3617: Pagination module for 3.1?

Sorry for posting here, but can you suggest the simpler way to do the pagination? Write everytime all the functions b... Dmitry T.

10:42 am Image Feature Request #3563: static function valid() to validate image

Kiall, I understand your point, and these reasons are really important (especially about bugs and documentation), but... Dmitry T.

10:24 am Feature Request #3218: Database - add parameters to mysql_fetch_object in Database_Result

If fixing a core bug breaks a 3rd party module, its up to the 3rd party developer to fox it!
I will mention it to ... Kiall Mac Innes

10:20 am Feature Request #3617 (Closed): Pagination module for 3.1?

The qpagination module has been removed from 3.1.
I believe this was because none of the dev's use it.. it is an ... Kiall Mac Innes

10:14 am Feature Request #3620 (Closed): XSS Clean in 3.1

Security::XSS_clean was a mess and a false sense of security. Use a more robust library such as HTML purifier.
Als... Kiall Mac Innes

10:09 am Image Feature Request #3563: static function valid() to validate image

Isaiah already mentioned one - not adding new features means not adding new bugs to delay release.
I'll give you th... Kiall Mac Innes

09:52 am Feature Request #3620 (Closed): XSS Clean in 3.1

What's happend to Security::xss_clean? There is any substitution for this? Paweł Golonko -

09:44 am Image Feature Request #3563: static function valid() to validate image

Isaiah, why non API-breaking feature can't be included in 3.1.x?
3.0.x has many features added in the middle (since 3... Dmitry T.

09:21 am ORM Bug Report #3619 (Assigned): Add() should be queued if the record isn't in the db

You should be able to do the following when creating a new record:... Ben Midget

05:12 am Auth Bug Report #3618 (Assigned): ORM - _login() does not sha1 the user agent

Isaiah DeRose-Wilson

04:26 am Auth Bug Report #3618 (Closed): ORM - _login() does not sha1 the user agent

The user agent is not hashed here: https://github.com/kohana/orm/blob/3.1/develop/classes/kohana/auth/orm.php#L88
... Mathew Davies

03:00 am Feature Request #3218: Database - add parameters to mysql_fetch_object in Database_Result

This broke compatibility with postgresql in the postgresql module maintained by cbandy/kohana-postgresql. Matt Tessar

01:24 am Bug Report #3615: ternary rule incorrectly requires parentheses

Here is another example to show that it is not just due to the PHP 5.3 implementation or the somewhat confusing conca... Bob Eagan

01:19 am Image Feature Request #3563: static function valid() to validate image

I don't think zombor meant to be funny. We have a feature-freeze before a release so we can get bugs squished and mak... Isaiah DeRose-Wilson

01:05 am Image Feature Request #3563: static function valid() to validate image

i`m agree with Yahasana
this is not a breaking api feature, so, IMHO, it can be included into 3.1.1 Tiger SEO

12:32 am Image Feature Request #3563: static function valid() to validate image

The schedule of 3.2 is long away from now. setting completed features to the future version is NOT funny. Yahasana .

01/17/2011

11:46 pm Feature Request #3617 (Closed): Pagination module for 3.1?

Unfortunately haven't found the pagination module for KO3.1. Does it exist? I think it is very popular module and it ... Dmitry T.

11:25 pm Feature Request #3616 (New): Fragment should use cache module if possible

If the cache module is enabled, @Fragment@ should use it instead of the internal file cache. I also suggest config it... Dmitry T.

11:24 pm Auth Bug Report #3611 (Assigned): Auth - The _now property does not exist in the Model_User_Toke

Isaiah DeRose-Wilson

11:23 pm Auth Bug Report #3612 (Assigned): ORM - unique_id doesn't exist.

Isaiah DeRose-Wilson

10:39 pm Bug Report #3615 (Closed): ternary rule incorrectly requires parentheses

I have the following code:... Bob Eagan

10:29 pm Bug Report #3614 (Closed): incorrectly throws an error when using closures

If I have a closure like this:... Bob Eagan

10:24 pm Bug Report #3613 (Closed): handle empty methods properly

Currently something like this:... Bob Eagan

10:21 pm Auth Bug Report #3612 (Closed): ORM - unique_id doesn't exist.

https://github.com/kohana/orm/blob/3.1/develop/classes/kohana/auth/orm.php#L89
The correct function to use here wo... Mathew Davies

10:20 pm Auth Bug Report #3611 (Closed): Auth - The _now property does not exist in the Model_User_Toke

https://github.com/kohana/orm/blob/3.1/develop/classes/model/auth/user/token.php#L25
Not sure what that line is fo... Mathew Davies

09:10 pm Image Feature Request #3563: static function valid() to validate image

3.1 is feature complete. Jeremy Bush

04:38 pm Core Revision f1acbe1e: Added Upload::image, allows checking that an upload is an image and (optionall...

Woody Gilk

04:33 pm Image Feature Request #3563 (Feedback): static function valid() to validate image

Added @Upload::image@ in a separate branch, see https://github.com/kohana/core/compare/3.0/develop...feature/3563-ima... Woody Gilk

02:39 pm Bug Report #3609 (Closed): Form::open() no longer handles NULL, breaks API

This was an intended change. It probably would be better to remove the check for the Request object altogether, becau... Isaiah DeRose-Wilson

03:51 am Bug Report #3609 (Closed): Form::open() no longer handles NULL, breaks API

... Nick Gregory

01/16/2011

04:19 pm Core Revision 773cf4f7: Merge branch '3.0/develop' of https://github.com/iammerrick/core into 3.0/develop

Woody Gilk

04:12 pm Bug Report #3589 (Closed): API Documentation Issue - Small text for Arr class.

Fixed by https://github.com/kohana/core/commit/773cf4f746c8334f7df6f82005b9879664d910d1 Woody Gilk

01:42 pm Database Bug Report #3608 (Closed): Kohana_Database_MySQL::connect() problem

both mysql_connect() and mysql_pconnect() (especially the latter - an example is the first comment on the PHP manual ... Stuart Harland

08:47 am Revision 746de0a9: Adding MySQL test to install.php

Kiall Mac Innes

08:44 am Revision 88157d69: Updating install.php to test for PECL http

Kiall Mac Innes

08:06 am Revision e3c355d3: Fixed merge error in build.xml

Kiall Mac Innes

07:55 am Revision 00b9055e: Merge branch '3.1/develop' into 3.1/release/3.1.0

Conflicts:
build.xml
system Kiall Mac Innes

07:52 am Core Revision 43974a1e: Merge branch '3.1/develop' into 3.1/release/3.1.0

Kiall Mac Innes

07:50 am Revision 12f557ef: Updating submodules

Kiall Mac Innes

07:49 am Core Revision 53b6cd69: Minor coding style cleanup

Kiall Mac Innes

07:47 am UnitTest Revision 748b8d16: Minor coding style cleanup

Kiall Mac Innes

07:44 am UnitTest Revision 30a85227: Fixing phpDoc @category

Kiall Mac Innes

07:09 am Userguide Revision 90d16959: Fixing userguide to work with "un-clean" URLs (ie those with index.php in them)

Kiall Mac Innes

06:54 am Core Revision 339f19ba: Updating the tests phpDoc.

Kiall Mac Innes

04:26 am Bug Report #3538 (Closed): Validation changes ignores Geiger's context bit

No problem Ben, glad that works for what you need :) Isaiah DeRose-Wilson

04:16 am Bug Report #3538: Validation changes ignores Geiger's context bit

@Isaiah dude, I feel like an ass. Thanks for the clarification. Shoulda studied the source more carefully :). This is... Ben Midget

04:13 am Bug Report #3538 (Feedback): Validation changes ignores Geiger's context bit

You can bind whatever parameters you want with the Validation::bind() method. E.g. if you want to be able to use :mod... Isaiah DeRose-Wilson

03:48 am Bug Report #3538: Validation changes ignores Geiger's context bit

3.1 has entered RC 2 - Any more changes have to wait 6 months for 3.2... Kiall Mac Innes

02:30 am Bug Report #3538: Validation changes ignores Geiger's context bit

To clarify, I personally think this should be a 3.1 issue to make the validation class what it should be.
I don't ... Ben Midget

01/15/2011

11:09 pm Revision 419d2e92: Tracking 3.1.0-rc2 system

Jeremy Bush

10:59 pm Core Revision 7a1a199e: Merge branch '3.1/develop' into 3.1/release/3.1.0

Conflicts:
classes/kohana/request/client/internal.php Jeremy Bush

10:42 pm Revision 78eeba6d: Updating system submodule.

Kiall Mac Innes

10:41 pm Core Revision 2c43f9ae: Fixing minor HTML helper bugs and updating the tests.

Kiall Mac Innes

10:08 pm Revision d5497543: Updating submodules

Kiall Mac Innes

10:07 pm Userguide Revision b97c54eb: Updating userguide for 3.1 HTML helper changes

Kiall Mac Innes

10:06 pm Core Revision 7bd187bb: Updating HTML helper for 3.1 URL::base() changes.

Kiall Mac Innes

09:44 pm Revision f3045e2c: Updating submodules

Kiall Mac Innes

09:40 pm ORM Revision 3e874f78: Fixes #3607 - Adding create_user() and update_user() methods to ORM's Auth_Use...

Kiall Mac Innes

09:35 pm Auth Feature Request #3607 (Closed): Add create_user/update_user methods to the user model

Kiall Mac Innes

09:32 pm Auth Feature Request #3607 (Closed): Add create_user/update_user methods to the user model

We should have methods for creating/updating users in the user model that include the extra password validation that ... Isaiah DeRose-Wilson

07:11 pm Revision 1f381ae7: Updating ORM submodule

Kiall Mac Innes

07:00 pm Bug Report #3606 (Closed): Kohana_View_Exception on main site

Kiall Mac Innes

06:57 pm Bug Report #3606 (Closed): Kohana_View_Exception on main site

http://kohanaframework.org/forum
I got "Kohana_View_Exception [ 0 ]: The requested view pages/blah could not be fo... Valeriy Viktorovskiy

06:45 pm ORM Revision 635b328a: Added the not_empty rule back to the user model. It's needed to make sure a mo...

Isaiah DeRose-Wilson

06:35 pm Feature Request #3536: Remove controller method parameters

Kiall Mac Innes wrote:
>
> I really can't see this as a feature worth having and can see users getting very confuse... Tyler Larson

05:47 pm Feature Request #3536: Remove controller method parameters

Some more discussion of this started in the pull request for those who havn't seen it. https://github.com/kohana/core... Kiall Mac Innes

05:45 pm Revision 53e92ccd: Updating submodules.

Kiall Mac Innes

05:38 pm Bug Report #3599 (Closed): Validation should _not_ modify data

Fixed by "485de87...":https://github.com/kohana/core/commit/485de877b0770a59f84a94e406942986a4783f28 Isaiah DeRose-Wilson

05:31 pm Bug Report #3602 (Closed): Passing objects as a Validation parameter will result in a fatal error

Fixed by "beaf6f...":https://github.com/kohana/core/commit/beaf6fe9006e9fe45ba9861742f53208dce401d0 Isaiah DeRose-Wilson

08:18 am Auth Bug Report #3605 (Closed): AUTH login hashes the password if passed as string

Not all the drivers will require to have the password sent as hash for the _login abstract function.
For example, ... Nano Documet

05:53 am Bug Report #3599: Validation should _not_ modify data

I phrased it badly and us minions are not allowed to edit the original ticket. What I meant is that based on the plan... Lorenzo Pisani

04:26 am Bug Report #3599: Validation should _not_ modify data

It's not a bug when you write code to intentionally do something. Woody Gilk

12:48 am Core Revision 465527d3: Merge branch '3.1/develop' of github.com:kohana/core into 3.1/develop

Isaiah DeRose-Wilson

12:45 am Core Revision f484a3ef: adding tests for #3599 and #3602

Lorenzo Pisani

12:44 am Core Revision beaf6fe9: not allowing objects to be used in message strings (refs #3602)

Lorenzo Pisani

12:43 am Core Revision ebf5690e: restoring the original data array after validation has run (refs #3599)

Lorenzo Pisani

12:43 am Core Revision 485de877: making sure data is not removed from the object when validating (refs #3599)

Lorenzo Pisani

12:29 am Bug Report #3599 (Assigned): Validation should _not_ modify data

Isaiah DeRose-Wilson

12:29 am Bug Report #3602 (Assigned): Passing objects as a Validation parameter will result in a fatal error

Isaiah DeRose-Wilson

01/14/2011

11:57 pm ORM Revision 4d3e929e: Clean up user model rules and filters. The password field should be validated ...

Isaiah DeRose-Wilson

10:38 pm Auth Bug Report #3597 (Closed): Model_User::hash_password should not run on empty values.

You should validate the password field outside of the model. The password is always a hash in the model, so rules lik... Isaiah DeRose-Wilson

10:32 pm Bug Report #3600 (Closed): Validation error/label breakage

Isaiah DeRose-Wilson

10:23 pm Feature Request #3536: Remove controller method parameters

My way: https://github.com/TdroL/kohana-params
IMO less "hardcore" than pull/67, with some flexibility. It extends Re... Michał Lipka

09:00 pm Bug Report #3604 (Assigned): Kohana_Session_Native should optionally Cookie Parameters when calli...

The related bug causes ini session cookie settings to be ignored.
If I set my cookie domain in php.ini to '.domain... Jeremy Bush

08:58 pm Feature Request #3536: Remove controller method parameters

https://github.com/kohana/core/pull/67
Patch to assign action parameters by name, not by the order they were parse... Tyler Larson

08:31 pm Auth Feature Request #3541 (Closed): Update ORM driver and related models for new ORM version

Kiall Mac Innes

08:27 pm Bug Report #3548 (Closed): cache_response() must be called from current Request object instead of...

Looks like this was done to me? Kiall Mac Innes

06:58 pm Revision 096369c3: Switching submodules from git:// to http://

Kiall Mac Innes

06:57 pm Revision 1a0a0b52: Switching submodules from git:// to http://

Kiall Mac Innes

06:55 pm Revision 04b53775: Updating submodules

Kiall Mac Innes

06:52 pm Revision c5a3e7f6: Updating submodules.

Kiall Mac Innes

06:52 pm Patch #3603 (Closed): Docs and Downloads Updates

Removed 2.4 from download, update links to 3.1 RC download, changed order and style of documentation to put more emph... Joel Pittet

06:49 pm Core Revision c5c018c0: Merge Fixes #3601 - Tests fail when Kohana_Core has been extended in applicati...

Kiall Mac Innes

06:30 pm Bug Report #3601 (Closed): debug path test fails if kohana class is overridden in the application

Applied in changeset commit:"3599e7cd77f8cb73721c4b547885ee044d6a23cc". Kiall Mac Innes

06:27 pm Core Revision 3599e7cd: Fixes #3601 - Tests fail when Kohana_Core has been extended in application.

Kiall Mac Innes

06:24 pm Bug Report #3601: debug path test fails if kohana class is overridden in the application

Fixed in 3.1: https://github.com/kohana/core/commit/3599e7cd77f8cb73721c4b547885ee044d6a23cc
Fixed in 3.0: https://g... Kiall Mac Innes

06:23 pm Core Revision c8c10189: Fixes #3601 - Tests fail when Kohana_Core has been extended in application.

Kiall Mac Innes

06:03 pm Bug Report #3602 (Closed): Passing objects as a Validation parameter will result in a fatal error

@->rule('field', 'matches', array(':validation', ':field', 'another'))@ will result in an exception because of a chec... Lorenzo Pisani

05:42 pm Bug Report #3601 (Closed): debug path test fails if kohana class is overridden in the application

https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L320
We override the kohana class so t... Bob Eagan

05:11 pm Bug Report #3600 (Closed): Validation error/label breakage

I've created a quick repository for this: https://github.com/ThePixelDeveloper/The-Kohana-Validation-is-Broke-Reposit... Mathew Davies

04:25 pm Bug Report #3599 (Closed): Validation should _not_ modify data

Now that Validation is only for validating data it shouldn't modify the array of data pass to it. All validation is d... Lorenzo Pisani

04:25 pm Bug Report #3598 (New): poor implementation of test_messages

https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L151
This causes issues when the valid... Bob Eagan

04:12 pm Auth Bug Report #3597 (Closed): Model_User::hash_password should not run on empty values.

@Model_User::hash_password@ processes all values at the minute. This causes an issue with ORM Validation because when... Mathew Davies

03:18 pm Auth Bug Report #3579 (Closed): Sample schema is too "small" for a sha256

Kiall Mac Innes

03:17 pm Bug Report #3549 (Closed): Request_Client::set_cache() uses undefined property Response::$header

Kiall Mac Innes

03:17 pm Core Revision e1425a0d: Fixes #3596 - Typo in text_exception_handler

Kiall Mac Innes

03:12 pm Bug Report #3596 (Closed): typo in test function name

Kiall Mac Innes

03:06 pm Bug Report #3596 (Closed): typo in test function name

https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L269
teste_exception_handler()
shou... Bob Eagan

03:03 pm Revision 4232b619: Updating submodules.

Kiall Mac Innes

03:00 pm ORM Revision 19f1670f: Updating Model_Auth_User::filters() to the new 3.1 syntax.

Kiall Mac Innes

02:59 pm Bug Report #3595 (Closed): Auth files duplicated in 2 official modules auth-driver-orm and orm.

auth-driver-orm has been deleted. Jeremy Bush

02:39 pm Bug Report #3595 (Closed): Auth files duplicated in 2 official modules auth-driver-orm and orm.

Didn't Auth ORM get split off into its own module: auth-driver-orm?
https://github.com/kohana/auth-driver-orm/tree... Mathew Davies

01:00 pm UnitTest Bug Report #3593 (Closed): Compatibility changes for 3.1

Applied in changeset commit:"f23d61846c9df3d751e7e4d1608ecefd0ab549e0". Anonymous

12:58 pm UnitTest Revision f23d6184: Fixing unittest controller for 3.1 fixes #3593

Matt Button

12:57 pm ORM Revision be5aabe4: Merge branch '3.1/feature/documentation' of https://github.com/Zeelot/kohana-o...

Kiall Mac Innes

12:54 pm ORM Feature Request #3592 (Closed): Documentation Improvements

Commit: https://github.com/kohana/orm/commit/be5aabe4431f57d08982595b21748d849ab7da9f Kiall Mac Innes

12:50 pm Userguide Revision da4edc6d: Fix 404's for 3.1 compatibility. Should this change to a 404 Exception? refs #...

Kiall Mac Innes

12:48 pm ORM Bug Report #3591 (Closed): ORM::_validation() is not binding the model instance to :model

Kiall Mac Innes

12:45 pm Userguide Bug Report #3594 (Feedback): 3.1 Userguide 404 handling

In the 3.1 userguide, we are using @$this->response->status(404);@ as part of the @error()@ function .. should this m... Kiall Mac Innes

11:57 am UnitTest Bug Report #3593 (Closed): Compatibility changes for 3.1

> https://github.com/kohana/unittest/blob/3.1/develop/classes/controller/unittest.php#L64
>
> The uri needs to be ... Matt Button

10:09 am ORM Revision 7a8e95ca: binding :model to the validation object (refs #3591)

Lorenzo Pisani

10:04 am ORM Bug Report #3591: ORM::_validation() is not binding the model instance to :model

https://github.com/kohana/orm/pull/19 Lorenzo Pisani

09:58 am ORM Revision 818895f7: adding a section on ORM::rules() to the validation page

Lorenzo Pisani

09:56 am ORM Feature Request #3592: Documentation Improvements

https://github.com/kohana/orm/pull/18 Lorenzo Pisani

09:54 am ORM Feature Request #3592 (Closed): Documentation Improvements

I started by cherry-picking the commits that provided documentation for ORM 3.0.x into 3.1.x, fixed any differences, ... Lorenzo Pisani

09:52 am ORM Bug Report #3591 (Closed): ORM::_validation() is not binding the model instance to :model

The same way :model is available to ORM filters, it should be available to rules(). Lorenzo Pisani

09:14 am ORM Revision eb405253: adding documentation for ORM filters

Lorenzo Pisani

08:58 am ORM Revision deb4d880: Adding a pretty complete example of validation

Lorenzo Pisani

08:01 am ORM Revision 7eaf3162: tiny format change of the simple example header

Lorenzo Pisani

07:58 am ORM Revision 0c095680: final touches on the ORM validation documentation

Lorenzo Pisani

07:47 am ORM Revision d6d5bda5: creating the initial ORM validation documentation

Lorenzo Pisani

07:07 am ORM Revision 3cdbd1e0: another minor typo

Lorenzo Pisani

07:06 am ORM Revision 5d58b865: missed a documentation file (updating verbiage for 3.1.x)

Lorenzo Pisani

07:05 am ORM Revision f86294a3: Updating the documentation for 3.1.x and cleaning up any minor grammar mistakes

Lorenzo Pisani

06:06 am ORM Revision 6d5c3d60: removing ORM::count_last_query() (refs #3590)

Lorenzo Pisani

06:03 am ORM Revision 8d266bfb: adding an ORM::$_db_group property to clean up some code (refs #3588)

Lorenzo Pisani

06:02 am Core Revision 91e4ab12: Updated to comment for Arr::unshift, addresses issue #3589

Merrick Christensen

05:59 am ORM Bug Report #3590 (Closed): Remove count_last_query()

Fixed by "6d5c3d...":https://github.com/kohana/orm/commit/6d5c3d60e537a2ec3506778d9763f14bc71f0e28 Isaiah DeRose-Wilson

05:56 am ORM Bug Report #3588 (Closed): ORM::$_db should not be used as a string and object property

Fixed by "8d266bfbdbf...":https://github.com/kohana/orm/commit/8d266bfbdbffc775e0185b2dc6d1bef71c70e83b Isaiah DeRose-Wilson

05:56 am ORM Bug Report #3590 (Closed): Remove count_last_query()

count_last_query() was removed from Database because of security risks. It needs to be removed from ORM as well. Lorenzo Pisani

05:54 am Bug Report #3589 (Closed): API Documentation Issue - Small text for Arr class.

The Arr::unshift() method has a comment that is referencing an old function and it is being pulled into the API brows... Merrick Christensen

05:45 am ORM Bug Report #3588 (Closed): ORM::$_db should not be used as a string and object property

@ORM::$_db@ should default to NULL and hold the database object, @ORM::$_db_group@ should be the string that holds th... Lorenzo Pisani

05:30 am Bug Report #3556 (Closed): Validation callbacks should run on empty fields

Applied in changeset commit:"5de93c0ee108cd58e38c67719fc7cdd4906c80ef". Isaiah DeRose-Wilson

05:27 am Core Revision 5de93c0e: Always run rules on empty fields. Fixes #3556

Isaiah DeRose-Wilson

05:21 am ORM Revision d0a41f1d: updating copyright year

Lorenzo Pisani

05:20 am ORM Revision f860bdd3: Fixed typo. `modle` to `model`.

Torleif Berger

05:20 am ORM Revision 190c186b: Renamed `author` foreign keys to `author_id`.

In my experience, you will end up with a bit of collision issues when having an alias with the same name as a column/... Torleif Berger

05:20 am ORM Revision 34bc39a6: adding a delete example

Ryder Ross

05:19 am ORM Revision fdd0b094: Fix menu to show the simple example

Michael Peters

05:19 am ORM Revision 4b0ce9a3: And I forgot to save a file :/

Michael Peters

05:19 am ORM Revision 5970a1bb: Renamed some files and rerranged some stuff

Michael Peters

05:19 am ORM Revision 41679e16: ORM quick introduction

Rune Bonsu

05:19 am ORM Revision 90b34ad2: added a base for Using ORM

Ryder Ross

05:18 am ORM Revision 9134154b: Adding docs for relationships. Started with jheathco's documetation as a base

Ryder Ross

05:18 am ORM Revision f83c9a23: ORM introduction

Rune Bonsu

05:18 am ORM Revision ef73ddd7: Added userguide stbs

Michael Peters

04:57 am Bug Report #3580: No way to get the current route from a Request instance

Steven G. wrote:
> Also, unless I'm mistaken, isn't this what you wanted?
That won't work in Kohana 3.1, the route i... Isaiah DeRose-Wilson

04:55 am ORM Revision b717bb70: Fixed the recursive generate_errors() method for orm validation exceptions, fi...

Lorenzo Pisani

04:53 am ORM Revision 77f112fa: Updated ORM for new filters syntax (now works the same as validation rules). F...

Isaiah DeRose-Wilson

04:50 am ORM Bug Report #3585 (Closed): Filters need to be adapted to the Validation syntax

Fixed by "77f112fa0...":https://github.com/kohana/orm/commit/77f112fa04923d33e55c42a0b07269574230712f Isaiah DeRose-Wilson

04:50 am ORM Bug Report #3586 (Closed): The validation exception does not properly namespace errors

Fixed by "b717bb7033...":https://github.com/kohana/orm/commit/b717bb7033acb720b4fa71407d796da3b38fe2c6 Isaiah DeRose-Wilson

03:48 am ORM Bug Report #3587: ORM and sqlite virtual tables not accessed properly breaking object

sample code to replicate
virtual tables have a pk called rowid
sqlite3
create virtual table foo using fts3 (txt)... tomek gruschsky

03:41 am ORM Bug Report #3587 (Review): ORM and sqlite virtual tables not accessed properly breaking object

Isaiah DeRose-Wilson

03:39 am ORM Bug Report #3587: ORM and sqlite virtual tables not accessed properly breaking object

This seems to be an issue for any ORM model that uses a custom PK name other than 'id'; The PK isn't returned with th... tomek gruschsky

03:21 am ORM Bug Report #3587 (Closed): ORM and sqlite virtual tables not accessed properly breaking object

sqlite has virtual tables which can be used for (amongst other things) powerful full text searches. virtual tables ar... tomek gruschsky

02:52 am ORM Bug Report #3585 (Assigned): Filters need to be adapted to the Validation syntax

Isaiah DeRose-Wilson

01:40 am ORM Bug Report #3586 (Closed): The validation exception does not properly namespace errors

@$e->errors('directory');@ is completely broken at the moment. Seems some code refactoring broke the feature.
Give... Lorenzo Pisani

01/13/2011

06:03 pm ORM Bug Report #3585 (Closed): Filters need to be adapted to the Validation syntax

filters() should return an array in the same syntax as rules()... Lorenzo Pisani

04:14 pm Image Feature Request #3584 (Closed): Method resize with argument Image::PRECISE

Hi, I wrote a patch extension method "resize".
Optional argument to resize Image::PRECISE allows you to create pre... Max Kamashev

02:40 pm Bug Report #3583 (Closed): Inconsistent returning of array of found files in Kohana::Find_File wh...

When trying to find an array of files using Kohana::Find_File() with caching enabled, the cache only accounts for the... Joe Noyes

06:22 am Revision 9af92251: Removed oauth and pagination from .gitmodules-dev

Isaiah DeRose-Wilson

05:58 am Revision 96f2f5f5: Updating submodules

Isaiah DeRose-Wilson

05:33 am Core Revision 7fe67398: Fixed coding style issues in tests

Isaiah DeRose-Wilson

05:05 am Revision 748ee228: Removed oauth and pagination modules from build.xml and bootstrap.php refs 8bf...

Isaiah DeRose-Wilson

04:58 am Core Revision 39082158: Code cleanup and fixed failing request unit test.

Isaiah DeRose-Wilson

01:58 am Bug Report #3582 (Closed): Second code example on Arr::is_assoc() doesn't do what it says

The code example says the following will return FASLE:... Darryl Hein

01/12/2011

07:57 pm Auth Bug Report #3574 (Closed): Declaration of Kohana_Auth_ORM::get_user() should be compatible with t...

Fixed by "4e671485...":https://github.com/kohana/orm/commit/4e671485b1aed792735105a49acf900793b19e47 Isaiah DeRose-Wilson

07:57 pm Core Revision 5a2e9ea1: Updated copyright dates and some comments relating to $this->request->response...

Joel Pittet

07:54 pm Patch #3533 (Closed): Comments and core guide changes for 3.1.0

Thanks Joel!
Fixed by "5a2e9ea193e...":https://github.com/kohana/core/commit/5a2e9ea193e082d2e8c4ac8f3852a122fced... Isaiah DeRose-Wilson

07:36 pm Revision cd95db7f: Updating system

Isaiah DeRose-Wilson

07:33 pm Core Revision fe6873b5: Merge branch '3.1/develop' of github.com:kohana/core into 3.1/develop

Isaiah DeRose-Wilson

07:31 pm Core Revision ed004fbd: Fixed controller.php phpDoc comments. Fixes #3578

Isaiah DeRose-Wilson

07:29 pm Bug Report #3578 (Closed): Incorrect phpDoc comment in controller.php

Fixed by "ed004fbdb...":https://github.com/kohana/core/commit/ed004fbdb9ad3481e3ba52b2402e1f02f151b3fe Isaiah DeRose-Wilson

06:51 pm Bug Report #3551: Error with cookies in Response::send_headers()

Please keep this discussion on topic. Jeremy Bush

06:28 pm Core Revision 6a3a6275: Refs #3551, removed the incorrect variable - damn over coffee brain

Sam de Freyssinet

06:24 pm Bug Report #3551: Error with cookies in Response::send_headers()

The reason for while/each in this instance is because each() produces such a horrible interface for the foreach loop.... Sam de Freyssinet

06:15 pm Bug Report #3551: Error with cookies in Response::send_headers()

Isaiah DeRose-Wilson wrote:
> Jeremy Bush wrote:
> > list/while is faster than foreach().
>
> Actually I don't t... Steven G.

05:52 pm Bug Report #3551: Error with cookies in Response::send_headers()

I agree with Isaiah. IMO code readability is more important than speed (futhermore when spped gain is doubtful), so I... Dmitry T.

05:49 pm Bug Report #3551: Error with cookies in Response::send_headers()

Sorry, I didn't mean faster. it uses less memory in some situations where a foreach() would consume more memory and n... Jeremy Bush

05:43 pm Bug Report #3551: Error with cookies in Response::send_headers()

Jeremy Bush wrote:
> list/while is faster than foreach().
Actually I don't think that's true. I haven't benchmarked ... Isaiah DeRose-Wilson

05:27 pm Bug Report #3551: Error with cookies in Response::send_headers()

Probably :) Jeremy Bush

05:06 pm Bug Report #3551: Error with cookies in Response::send_headers()

Jeremy, I see, thanks for the reply.
Nevertheless ... Dmitry T.

04:54 pm Bug Report #3551: Error with cookies in Response::send_headers()

list/while is faster than foreach(). Jeremy Bush

04:52 pm Patch #3581 (Closed): URL::base() port patch

What Kohana version are you using? This was fixed a few versions back. See #3307 Isaiah DeRose-Wilson

04:38 pm Bug Report #3551: Error with cookies in Response::send_headers()

Sam, what is @$fruit@ here?
https://github.com/kohana/core/blob/705d5fc5d95af4ce466dc37f46d5ec902a18c4b4/classes/koh... Dmitry T.

04:37 pm Core Revision 8bb1ea4a: Refs #3548, fixes the request client to use correct method on itself, rather t...

Sam de Freyssinet

04:33 pm Core Revision 6a00a465: Refs #3549, fixes the incorrect referencing of member properties and methods

Sam de Freyssinet

04:31 pm Core Revision b1979c73: Refs #3550, fixes the profiler issue where the current request would be posted...

Sam de Freyssinet

04:28 pm Core Revision 705d5fc5: Refs #3551, fixes the cookie interface in Response to use compatible interface...

Sam de Freyssinet

04:22 pm Bug Report #3551 (Needs Test): Error with cookies in Response::send_headers()

Fixed in https://github.com/kohana/core/commit/705d5fc5d95af4ce466dc37f46d5ec902a18c4b4 Sam de Freyssinet

03:37 pm Image Feature Request #3563: static function valid() to validate image

Hello.
Futher development lead me to upgrade method to make it compatible with rules in Validate routine. Code:
<pr... Tiger SEO

02:22 pm Revision 2f59d5a1: Update submodule

Chris Bandy

02:15 pm Database Bug Report #3569 (Closed): Database subquery can't support aliases

Applied in changeset commit:"bd29aba3dd9a7f6dbc682558f5de5911f224f72f". Anonymous

02:10 pm Database Revision bd29aba3: Allow aliases on expressions and queries in quote_* methods. Fixes #3569

Chris Bandy

01:10 pm Userguide Revision 818a5797: Even more 3.1 fixes..

Kiall Mac Innes

09:25 am Patch #3581 (Closed): URL::base() port patch

On my staging server I have to use non-standard port 8181. When I upload new kohana project to this server I found th... Ivan Mosiev

08:28 am Bug Report #3580: No way to get the current route from a Request instance

Kiall Mac Innes wrote:
> Applied in changeset commit:"cc3e043d8181cf326e2bcae9bdcccf9bc3403aa8".
I get "No input ... Steven G.

05:57 am Userguide Revision c01e82c6: More 3.1 Fixes..

Kiall Mac Innes

05:23 am Revision a2577255: Updating submodules

Kiall Mac Innes

05:21 am Core Revision cc3e043d: Fixes #3580 - No way to get the current route from a Request instance

Kiall Mac Innes

05:15 am Bug Report #3580 (Closed): No way to get the current route from a Request instance

Applied in changeset commit:"cc3e043d8181cf326e2bcae9bdcccf9bc3403aa8". Kiall Mac Innes

05:08 am Bug Report #3580 (Closed): No way to get the current route from a Request instance

There is currently no way to get the current route from a Request instance.. This is actually needed by the userguide... Kiall Mac Innes

04:32 am Core Revision 8fdf71cb: Fix a minor phpDoc issue.

Kiall Mac Innes

04:30 am ORM Revision 1eee5868: Fixes #3579 - Sample schema is too "small" for a sha256

Kiall Mac Innes

04:27 am ORM Revision 4e671485: Fixes #3574 - Declaration of Kohana_Auth_ORM::get_user() should be compatible ...

Kiall Mac Innes

04:23 am Auth Bug Report #3579 (Closed): Sample schema is too "small" for a sha256

Sample schema is too "small" for a sha256.. Kiall Mac Innes

03:42 am ORM Revision b4978dbd: Moving Auth ORM driver from its own repo to the ORM module for consistency wit...

Kiall Mac Innes

03:37 am Userguide Revision 4356d8d3: Fixing 3.1 some compatibility issues.

Kiall Mac Innes

01/11/2011

10:49 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes

Jeremy Bush wrote:
> The answer is to not use any php in the error views, I think.
You can't avoid not using any ... Steven G.

09:46 pm Feature Request #2113: Kohana::message() & I18n

I think what I'm trying to articulate is that the tight coupling of translation strings to Kohana::message value in f... Andrew Coulton

09:22 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes

The answer is to not use any php in the error views, I think. Jeremy Bush

09:18 pm Bug Report #3566: Kohana environment constants and custom environments

Decision made. Jeremy Bush

09:17 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes

Steven G. wrote:
>
> Is there a problem with just using Kohana_* classes
Yes, we only use the extended classes.... Jeremy Bush

08:43 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes

Jeremy Bush wrote:
> The problem is in the autoloader, which I though was fixed by http://dev.kohanaframework.org/is... Steven G.

07:16 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes

The problem is in the autoloader, which I though was fixed by http://dev.kohanaframework.org/issues/3327 in 3.0.9. Jeremy Bush

07:07 pm Bug Report #3578 (Closed): Incorrect phpDoc comment in controller.php

https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/controller.php#L31
Correct comment would be:
<... Mathew Davies

07:04 pm Bug Report #3577 (New): system/view/kohana/error.php should not be dependent on other classes

I don't believe dependencies to the class Kohana are a problem. But dependencies to something like HTML which is also... Steven G.

06:06 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

Also we do have "docs that explain":http://kohanaframework.org/guide/kohana/conventions#type-casting this stuff ;) Isaiah DeRose-Wilson

06:01 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

Dmitry T. wrote:
> what about @foo( (int) $bar);@ or @foo((int) $bar)@ or @foo((int)$bar)@?
> I haven't found anyth... Matt Button

05:15 pm Revision 81420023: Merge branch '3.0/hotfix/3.0.9.buildfix' into 3.0/master

Jeremy Bush

05:15 pm Revision 2b2ff325: Adding proper build file for ci

Jeremy Bush

05:11 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

what about @foo( (int) $bar);@ or @foo((int) $bar)@ or @foo((int)$bar)@?
I haven't found anything about it in coding... Dmitry T.

03:54 pm Core Revision 7c909d75: Debug methods were moved to separate class refs #2682

Michal Kocian

03:50 pm Userguide Revision c261d04a: Debug methods were moved to separate class refs #2682

Michal Kocian

03:49 pm Image Revision 697c9862: Debug methods were moved to separate class refs #2682

Michal Kocian

03:45 pm Bug Report #3575 (Closed): Coding-Standards: The & sign in function for refrences throws Paranthe...

What isn't clear? It says: "A single space is required on either side of ! and & operators" They are still operators ... Jeremy Bush

03:38 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

ok. i could not find a clear statement to that point. So i might be wrong with this. Matthias Lill

03:28 pm Auth Bug Report #3574 (Assigned): Declaration of Kohana_Auth_ORM::get_user() should be compatible with...

Isaiah DeRose-Wilson

03:09 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

Yes we do require a space, it should be function foo( & $bar) Isaiah DeRose-Wilson

02:48 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...

I'm not sure that we don't want a space there. Jeremy Bush

02:17 pm Bug Report #3575 (Closed): Coding-Standards: The & sign in function for refrences throws Paranthe...

Don't know it this was submitted before:
The message "A single space is required on either side of ! and & operato... Matthias Lill

02:16 pm Feature Request #2113: Kohana::message() & I18n

I don't think anything like this is on our radar. I've always maintained that our i18n class is meant to be a simple ... Jeremy Bush

12:26 pm Feature Request #2113 (Feedback): Kohana::message() & I18n

I appreciate this has already been considered and closed, but there have been two forum threads in recent weeks with ... Andrew Coulton

01:14 am Bug Report #3572 (Closed): Protocol-less URIs

I'm fine with the reasons provided in the duplicated issue. Jeremy Bush

01/10/2011

11:32 pm Image Revision bc718df7: Merge branch '3.0/master' of https://github.com/awellis/image into 3.0/develop

Woody Gilk

11:28 pm Auth Bug Report #3574 (Closed): Declaration of Kohana_Auth_ORM::get_user() should be compatible with t...

Simple warning:... Mathew Davies

11:03 pm Image Revision 1f545cb8: Fixed a couple spelling mistakes in the PHPDoc.

Andrew Ellis

10:05 pm Bug Report #3572: Protocol-less URIs

We talked about this before and decided it wasn't a good idea. See the related issue. Isaiah DeRose-Wilson

06:29 pm Bug Report #3572: Protocol-less URIs

Sure, we do that too. We have dedicated url methods that give us just the domain base, without the url base from kohana. Jeremy Bush

05:58 pm Cache Bug Report #3573 (Assigned): Cache_MemcacheTag::set_with_tags() does not sanitize ID

Jeremy Bush

05:48 pm Bug Report #3572: Protocol-less URIs

Jeremy Bush wrote:
> You shouldn't be using absolute urls like that. It adds the base onto it so that you have porta... Luke Morton

05:31 pm Cache Bug Report #3573 (Closed): Cache_MemcacheTag::set_with_tags() does not sanitize ID

@set_with_tags()@ does not sanitize the ID value when calling @add_tag()@ to associate each tag with the ID. This ca... Jimmy Mabey

04:49 pm Bug Report #3572: Protocol-less URIs

Luke Morton wrote:
> On a side note, why do absolute URIs still get the base appended to them? I.e. "/js/script.js" ... Jeremy Bush

04:29 pm Bug Report #3565: Kohana environment consideration

Or ... ... Chris Smith

04:20 pm Bug Report #3572 (Closed): Protocol-less URIs

URIs can in fact be protocol-less, that is "//ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js" is a valid re... Luke Morton

04:17 pm Database Bug Report #3569: Database subquery can't support aliases

Assigned to Chris, since it was his commit that broke this functionality. Woody Gilk

04:16 pm Database Bug Report #3569: Database subquery can't support aliases

Running @git diff 3.0/develop:classes/kohana/database.php 3.1/develop:classes/kohana/database.php@ produces the follo... Woody Gilk

04:15 pm Revision 74094aa3: Fixes #3565 - Allow KOHANA_ENV to be specified as a string rather than an int.

Kiall Mac Innes

04:15 pm Bug Report #3565 (Closed): Kohana environment consideration

Applied in changeset commit:"74094aa3af0c17d33522165448fb7a28cbf9a543". Kiall Mac Innes

04:14 pm Revision a17ba697: Tracking submodules

Woody Gilk

04:12 pm Userguide Revision 0a2a3cdf: Merge branch '3.0/develop' into 3.1/develop

Conflicts:
classes/controller/userguide.php
classes/kohana/kodoc/property.php
guide/about.flow.md
guide/about.ins... Woody Gilk

04:07 pm Database Bug Report #3569: Database subquery can't support aliases

The problem commit is here "e8b3053e...":https://github.com/kohana/database/commit/e8b3053e955cd74eee9754636c5e81ff13... Isaiah DeRose-Wilson

04:06 pm OAuth Revision bc79b8aa: Merge branch '3.0/develop' into 3.1/develop

Woody Gilk

04:05 pm Database Revision 6176469d: Merge branch '3.0/develop' into 3.1/develop

Conflicts:
classes/kohana/database.php
classes/kohana/database/query/builder.php Woody Gilk

04:00 pm Cache Revision ef8656e5: Merge branch '3.0/develop' into 3.1/develop

Woody Gilk

03:55 pm Image Revision 1b5fb0f4: Merge branch '3.0/develop' into 3.1/develop

Woody Gilk

03:51 pm Image Bug Report #3571 (Closed): property declaration is absent

Fixed by https://github.com/kohana/image/commit/1b5fb0f4fd4a93742d30fe08095e8248738fbcf2 Woody Gilk

03:49 pm Image Bug Report #3571 (Assigned): property declaration is absent

Isaiah DeRose-Wilson

03:48 pm Image Bug Report #3571 (Closed): property declaration is absent

Hello.
line 110 in file MODPATH."image\classes\kohana\image.php":... Tiger SEO

03:41 pm Image Revision c1c79f84: Declaring Image::$mime before using it, fixes #3561

Woody Gilk

03:39 pm Database Bug Report #3569: Database subquery can't support aliases

Only 3.1, I have word from BRMatt this problem doesn't exist in 3.0.x Mathew Davies

03:37 pm Database Bug Report #3569: Database subquery can't support aliases

Does this appear in 3.0.x or only 3.1.x? Woody Gilk

03:36 pm Database Bug Report #3569: Database subquery can't support aliases

The expected output is:... Mathew Davies

03:34 pm Image Bug Report #3561 (Closed): property declaration is absent

Fixed by https://github.com/kohana/image/commit/c1c79f84fd04c1b2aacca6c65780a98b72e687fa Woody Gilk

03:32 pm Database Bug Report #3569: Database subquery can't support aliases

I don't understand what you are getting at. What's what's expected and actual output? Woody Gilk

03:25 pm Database Bug Report #3569 (Closed): Database subquery can't support aliases

... Mathew Davies

03:06 pm Bug Report #3565: Kohana environment consideration

Right so ... swapping the bootstrap.php to this in 3.1.0 has been decided on ..... Kiall Mac Innes

02:50 pm Image Feature Request #3568: allow to save image without extension

Chris Smith wrote:
> Further to this you can't actually save an image without an extension.
The report points tha... Chris Smith

02:47 pm Image Feature Request #3568: allow to save image without extension

I had a look at the code and it would appear that the following code throws an exception:... Chris Smith

02:25 pm Image Feature Request #3568: allow to save image without extension

As you wish =) I`m already using this fix by overloading Image_GD class. Tiger SEO

02:23 pm Image Feature Request #3568: allow to save image without extension

This is a behavior change. Jeremy Bush

02:20 pm Bug Report #3565: Kohana environment consideration

I've always erred on the side of "let the developer decide how to implement environments". I'd rather have a very sim... Jeremy Bush

02:17 pm Patch #3567: Kohana outputs HTML on CLI

This should be handled all at once with the two related issues. Jeremy Bush

12:56 pm Image Feature Request #3568 (Closed): allow to save image without extension

Hello.
Method @_do_save()@ in class Kohana_Image_GD call`s ("classes/kohana/image/gd.php:478":https://github.com/koh... Tiger SEO

10:31 am Bug Report #3401: Set Request::$client_ip from HTTP headers only if a trusted proxy set the header.

Ignoring the issue of whether we trust REMOTE_ADDR for a while; I'd propose a whitelist mechanism, to allow chains of... Marcus Cobden

10:28 am Image Bug Report #3561: property declaration is absent

@Isaiah "classes/kohana/image.php:110":https://github.com/kohana/image/blob/3.0%2Fmaster/classes/kohana/image.php#L11... Chris Smith

10:22 am Bug Report #3565 (Assigned): Kohana environment consideration

@Chris Smith - heh .. I guess you use constants more often than the rest of us ;)
@Jeremy - I'll give you a shout on... Kiall Mac Innes

10:17 am Bug Report #3565: Kohana environment consideration

Err use reflection or constant() to see if that constant exists? Chris Smith

08:04 am Image Bug Report #3561: property declaration is absent

Issue with IDE and auto-completion feature :)
And it is a good tone to declare public properties :)
Can you change ... Tiger SEO

05:40 am Bug Report #3566 (Assigned): Kohana environment constants and custom environments

Isaiah DeRose-Wilson

04:23 am Bug Report #3566: Kohana environment constants and custom environments

I think we need to focus on essential changes in 3.1.0 only. I'm bumping this to 3.1.1 and we can decide later if thi... Isaiah DeRose-Wilson

04:03 am Patch #3567 (Closed): Kohana outputs HTML on CLI

If you run into an exception while using the CLI you'll get all the HTML output. I've attached a patch to suppress th... Mathew Davies

02:01 am Bug Report #3565: Kohana environment consideration

Kiall Mac Innes wrote:
> Jeremy - would that (translation in bootstrap) be considered an API change? If it is ... Le... Jeremy Bush

01:59 am Bug Report #3565: Kohana environment consideration

A translation in the bootstrap may be the best option. Using an array like that is pretty crap ;)
Jeremy - would t... Kiall Mac Innes

01:52 am Bug Report #3565: Kohana environment consideration

We aren't going to change the api of 3.1 unless something really needs changing. Jeremy Bush

01:47 am Bug Report #3565: Kohana environment consideration

2 options I can think of.
Ditch the constants and use the array. I'm not that'd make people very happy though.
@Koh... Mathew Davies

01:42 am Bug Report #3565: Kohana environment consideration

Having a way to specify the environment using a string outside of Kohana would be great, But a lookup table means def... Kiall Mac Innes

01:38 am Bug Report #3566 (Closed): Kohana environment constants and custom environments

The current 3.1 environment constants do not allow custom environments to be inserted between the defaults.
I sugg... Kiall Mac Innes

01:23 am Image Bug Report #3561: property declaration is absent

What is the issue you are having? Yes the Image class is abstract, you never create an instance of the Image class...... Isaiah DeRose-Wilson

01:05 am Bug Report #3565 (Feedback): Kohana environment consideration

Isaiah DeRose-Wilson

12:10 am Bug Report #3565 (Closed): Kohana environment consideration

In 3.1 I've noticed you've switched over to using integers for the different environments. While this means you can d... Mathew Davies

01/09/2011

11:00 pm ORM Bug Report #3564 (Closed): ORM lazy loading issue

i downloaded fresh kohana 3.0.9
there is such issue.
[code]
$user = ORM::factory('user',$realid);
if(Arr... Dmitry Selin

08:43 pm Bug Report #3562: Validate library - bug when using ->rule/filter(TRUE, 'some_rule');

Aha, ok than. If expected then I will adjust :) Jarek Bolo

08:42 pm Bug Report #3562: Validate library - bug when using ->rule/filter(TRUE, 'some_rule');

Version 3.0.8 Jarek Bolo

08:33 pm ORM Feature Request #3559: Overloading ORM::factory

I just want to remake model basing on some condition. Anyway when I'm creating Test object with given ID all in all i... Rafał Łyczkowski

08:32 pm Bug Report #3562 (Closed): Validate library - bug when using ->rule/filter(TRUE, 'some_rule');

This is expected behavior. Jeremy Bush

08:26 pm Image Feature Request #3563 (Closed): static function valid() to validate image

Hello.
Alternative to Upload::valid($file) i suggest to add function Image::valid($file)... Tiger SEO

08:21 pm Bug Report #3562 (Closed): Validate library - bug when using ->rule/filter(TRUE, 'some_rule');

Hi there.
My rules are like that:... Jarek Bolo

08:04 pm Image Bug Report #3561 (Closed): property declaration is absent

Hello.
line 110 in file MODPATH."image\classes\kohana\image.php":... Tiger SEO

06:17 pm ORM Feature Request #3559 (Feedback): Overloading ORM::factory

I don't think this is a good idea. Your example is getting close to abusing the factory pattern, I don't really think... Isaiah DeRose-Wilson

06:08 pm ORM Feature Request #3560 (Closed): function set() in ORM class

It is already included in 3.1. We are trying to limit changes to minor versions to bug fixes only so this won't be ad... Isaiah DeRose-Wilson

05:30 pm ORM Feature Request #3560 (Closed): function set() in ORM class

Hello.
Please consider to add a new function set() into ORM class... Tiger SEO

12:41 pm ORM Feature Request #3559: Overloading ORM::factory

I think one and only disadvantage is that ORM::factory will be runned 2 times while checking existing factory method... Rafał Łyczkowski

12:38 pm ORM Feature Request #3559: Overloading ORM::factory

Example of using:... Rafał Łyczkowski

12:36 pm ORM Feature Request #3559 (Closed): Overloading ORM::factory

All structure in Kohana core are using ORM::factory to create valid ORM object. But there is no way to overload facto... Rafał Łyczkowski

01/08/2011

06:14 pm Bug Report #3505: Adjust the way default qualities are assigned to mime-types in Request::_parse_...

As promised I have had a stab at coding a suitable replacement.
Rather than attempt to take on the nightmare of wh... Stuart Harland

11:46 am Bug Report #3558 (Closed): Request::$client_ip retuns a list of addresses

X-Forwarded-For can contain multiple IPs acording to http://wiki.squid-cache.org/SquidFaq/ConfiguringSquid#What_is_.2... Alex Kurilo

01/07/2011

09:10 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules'

The issue with callbacks not running on empty fields will be resolved by zombor's suggestion, see #3556. Better suppo... Isaiah DeRose-Wilson

09:07 pm Bug Report #3556 (Closed): Validation callbacks should run on empty fields

"Run all rules (as it's done now), but ignore return values for the rules unless the rule is "not_empty". Callbacks c... Isaiah DeRose-Wilson

09:06 pm Bug Report #3552 (Feedback): Validation needs a better way to specify '_empty_rules'

Isaiah DeRose-Wilson

05:38 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules'

The same has to be done to 'matches' not to ignore the return value. Lorenzo Pisani

05:21 pm Bug Report #3552 (Assigned): Validation needs a better way to specify '_empty_rules'

After a discussion on IRC, I think the best behavior is to mimic how it worked in 3.0 by doing:
Run *all* rules (a... Jeremy Bush

04:29 pm UnitTest Revision 9d3b086e: Adding compatability fix for 3.4 fixes #3547

Matt Button

04:28 pm UnitTest Revision 6d9ff513: Adding compatability fix for 3.4 fixes #3547

Matt Button

04:26 pm UnitTest Bug Report #3547 (Closed): Class 'PHPUnit_Runner_Version' not found

Fixed in 3.0 https://github.com/kohana/unittest/commit/6d9ff51387aa4a6cd98ee2bc43971c418fc6fa3b and 3.1 https://githu... Matt Button

03:53 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules'

I think it makes more sense to have the TRUE on the rule that you want to run on empty fields. I.e. the third paramet... Isaiah DeRose-Wilson

03:00 pm Patch #3550 (Assigned): Profiler uses the same request uri twice for external requests

Sam de Freyssinet

02:59 pm Bug Report #3525: Header Value incorrect parsing of user agent entry

Header parsing is just creating the Http_Header object for requests/responses. It isn't parsed for the request unless... Sam de Freyssinet

02:57 pm Feature Request #3554 (Assigned): Response object: "live" or cached?

I was thinking of implementing this, but ran out of time before the release. I can confirm it will be in 3.2, however... Sam de Freyssinet

01:26 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules'

From @Lorenzo's pull:... Kiall Mac Innes

01:14 pm Bug Report #3552 (Review): Validation needs a better way to specify '_empty_rules'

Woody Gilk

12:14 pm Bug Report #3525: Header Value incorrect parsing of user agent entry

What if you want a header not to be parsed? Chris Smith

12:11 pm Feature Request #3555 (Assigned): .htaccess on fast-cgi

@Isaiah you're always good at know which rewrite rule to use! As far as I was aware, the standard rule works with fCG... Kiall Mac Innes

12:03 pm UnitTest Bug Report #3547: Class 'PHPUnit_Runner_Version' not found

You can include that file just fine, that file contains the PHPUnit version. ;) Chris Smith

10:38 am Feature Request #3555 (Closed): .htaccess on fast-cgi

In .htaccess should by line with comment about rule with `index.php`
# If your server run on fast-cgi use: Rewrite... Riu Ueshiba

09:16 am Feature Request #3477: Remote Exception codes

This update does not give me the CURL error code only the HTTP codes. It's interesting to know if the request e.g. ti... Michael R

08:15 am Bug Report #3552: Validation needs a better way to specify '_empty_rules'

https://github.com/kohana/core/pull/63
As mentioned in the pull request, I will add unit tests tomorrow night if n... Lorenzo Pisani

08:15 am Feature Request #3553: Validation::not_empty()

Ignore the fact that I called it required() in the title... was using verbiage from 2.x.
https://github.com/kohana... Lorenzo Pisani

06:36 am Feature Request #3554 (Closed): Response object: "live" or cached?

Current Response object doesnt provide any information about its history. I suggest to use special property like $_fr... Ivan Brotkin

05:24 am Feature Request #3553 (Closed): Validation::not_empty()

The removal of Validation::$_empty_rules based on #3552 will make not_empty act like all other rules and not be run o... Lorenzo Pisani

05:15 am Bug Report #3552 (Assigned): Validation needs a better way to specify '_empty_rules'

In 3.0.x Validate had an _empty_rules property to specify rules that would run when the value was empty, but callback... Lorenzo Pisani

05:00 am Bug Report #3551 (Closed): Error with cookies in Response::send_headers()

@send_headers()@ expects cookie to be an "array of value and expiration":https://github.com/kohana/core/blob/3.1%2Fde... Ivan Brotkin

04:32 am Patch #3550 (Closed): Profiler uses the same request uri twice for external requests

Request benchmarks must contain two URIs - from current and parent requests. But these values are the same for now. I... Ivan Brotkin

03:28 am Userguide Revision 39812933: Merge branch '3.0/develop' of https://github.com/acoulton/userguide into 3.0/d...

Woody Gilk

03:25 am Revision c22206e4: Tracking submodules

Woody Gilk

03:23 am Userguide Bug Report #3535 (Closed): Typo in API view when no class methods

Fixed by https://github.com/kohana/userguide/commit/39812933e45c91ecc2a615f6e122c2edfc85de4b Woody Gilk

03:23 am Userguide Patch #3534 (Closed): User guide CSS updates

Fixed by https://github.com/kohana/userguide/commit/963894ecf2e15e3bf7971cc371ecedff20a6ed95 Woody Gilk

03:14 am Userguide Revision 963894ec: Merge remote branch 'joelpittet/doc-css-fixes' into 3.0.x

Woody Gilk

02:31 am Support Request #3546: Rule not executed if field empty

> For example, email could be empty if user provided another information (phone number for example), and vice versa. ... Woody Gilk

01/06/2011

09:04 pm Bug Report #3505 (Feedback): Adjust the way default qualities are assigned to mime-types in Reque...

Sorry to reopen this, however I think that you haven't understood the problem that I was attempting to convey. This i... Stuart Harland

08:55 pm Bug Report #3549: Request_Client::set_cache() uses undefined property Response::$header

Another .diff (fixed one more typo in cache_lifetime()), I think there is no reason for creating new issue for it. Ivan Brotkin

08:46 pm Bug Report #3549 (Closed): Request_Client::set_cache() uses undefined property Response::$header

"this line":https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/request/client.php#L155 : Response has n... Ivan Brotkin

08:24 pm Bug Report #3548 (Assigned): cache_response() must be called from current Request object instead ...

Jeremy Bush

08:19 pm Bug Report #3548 (Closed): cache_response() must be called from current Request object instead of...

"here":https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/request/client/internal.php#L45 is error, rep... Ivan Brotkin

05:25 pm Revision 8d99e0cd: Adding a help line for dist target in build.xml

Kiall Mac Innes

05:25 pm Revision 19bbec71: Cleanup build.xml phpcs target

Kiall Mac Innes

05:25 pm Revision ab6c4fc8: Cleanup build.xml pdepend-log target

Kiall Mac Innes

05:25 pm Revision 6134008b: Cleanup build.xml phpcpd target

Kiall Mac Innes

05:25 pm Revision 621bed5e: Cleanup build.xml dist target logic

Kiall Mac Innes

05:25 pm Revision fbdd7bff: Removing checkreturn="true" from test targets, hudson should determine this fr...

Kiall Mac Innes

05:25 pm Revision a08dc435: Fix to build.xml dist paths.

Kiall Mac Innes

05:24 pm Revision a73f6848: Fixing comment syntax error in build.xml

Kiall Mac Innes

05:24 pm Revision 0d8645b1: Adding initial dist target to build.xml. Needs some cleanup.

Kiall Mac Innes

05:22 pm UnitTest Bug Report #3547: Class 'PHPUnit_Runner_Version' not found

I don't believe there is an easy way to fix this.. unless there is a PHPUNIT_VERSION constant or similar in which cas... Kiall Mac Innes

05:00 pm UnitTest Bug Report #3547: Class 'PHPUnit_Runner_Version' not found

So how can I resolve the problem if I use PHPUnit 3.4.15? Joannie Racine

04:55 pm UnitTest Bug Report #3547 (Feedback): Class 'PHPUnit_Runner_Version' not found

I believe adding this line will break phpunit 3.5 compatibility (3.5 depreciated the ability to manually include the ... Kiall Mac Innes

04:45 pm UnitTest Bug Report #3547 (Closed): Class 'PHPUnit_Runner_Version' not found

In version 3.0.9, Unittest module doesn't work because the class 'PHPUnit_Runner_Version' is not found in file MODPAT... Joannie Racine

03:58 pm Revision 3b4be351: Adding "dist" target

Kiall Mac Innes

01:01 pm Support Request #3546: Rule not executed if field empty

This needs to be done dynamically as there are so many possible use cases that any one solution will fail.
So in the... Kiall Mac Innes

12:47 pm Support Request #3546: Rule not executed if field empty

And what if I don't know may this field be empty or not?
For example, email could be empty if user provided another i... Dmitry T.

11:56 am Support Request #3546: Rule not executed if field empty

I've just seen this by @andrewc in the forum thread you linked to:
> he doesn't want to make the value optional, h... Kiall Mac Innes

11:51 am Support Request #3546 (Closed): Rule not executed if field empty

Kiall Mac Innes

11:50 am Support Request #3546: Rule not executed if field empty

This is correct.
For example:
If you have an *optional* email address field, you set it to @valid::email@.
If ... Kiall Mac Innes

10:44 am Support Request #3546: Rule not executed if field empty

This is not correct.
Why the rule is she not done.
If I have to check my mandatory fields dynamically, how do I do ... Mathias Strasser

01/05/2011

07:53 pm Support Request #3546: Rule not executed if field empty

Use not_empty rule for mandatory fields. Paul Chubaty

03:07 pm Support Request #3546 (Closed): Rule not executed if field empty

I noticed that the validation of a form with rules using custom functions were not executed if the field is empty.
... Mathias Strasser

02:18 pm Bug Report #3543: Kohana_Form::label() shouldn't use ucwords()

Alex Cartwright wrote:
> Jeremy Bush wrote:
> > Either way would be "correct" as valid points can be made either wa... Jeremy Bush

11:52 am Bug Report #3543: Kohana_Form::label() shouldn't use ucwords()

Jeremy Bush wrote:
> Either way would be "correct" as valid points can be made either way. I'm not compelled to chang... Alex Cartwright

01:12 am Auth Feature Request #3295 (Assigned): Model_Auth_User_Token::create_token() needs improvement

Isaiah DeRose-Wilson

01/04/2011

09:49 pm ORM Revision 2c011df8: Added checks to insure the object state is correct before running update/creat...

Isaiah DeRose-Wilson

09:44 pm ORM Bug Report #3544 (Closed): ORM::has() shouldn't run query when the model isn't loaded.

Fixed by "d790561af...":https://github.com/kohana/orm/commit/d790561af1c0e8358d7421716228fb9cb55456ca Isaiah DeRose-Wilson

09:43 pm ORM Bug Report #3545 (Closed): ORM::delete()/update()/create() should throw an exception if the model...

Fixed by "2c011df846a12a...":https://github.com/kohana/orm/commit/2c011df846a12a63a9daf3e0cec82ac8d90e4232 Isaiah DeRose-Wilson

09:05 pm ORM Revision d790561a: Check to make sure the model is loaded and $far_keys isn't null in ORM::has(),...

Isaiah DeRose-Wilson

09:01 pm ORM Bug Report #3545 (Closed): ORM::delete()/update()/create() should throw an exception if the model...

ORM::delete() and ORM::updated() should throw an exception if the model isn't loaded. ORM::create() should throw an e... Isaiah DeRose-Wilson

08:57 pm ORM Bug Report #3544 (Closed): ORM::has() shouldn't run query when the model isn't loaded.

If the model calling has() isn't loaded or if the far_keys are null (i.e. the model you passed in isn't loaded) no qu... Isaiah DeRose-Wilson

06:59 pm Bug Report #3543 (Closed): Kohana_Form::label() shouldn't use ucwords()

Either way would be "correct" as valid points can be made either way. I'm not compelled to change the current behavio... Jeremy Bush

06:05 pm Bug Report #3543: Kohana_Form::label() shouldn't use ucwords()

The label is a proper noun, it refers to a specific field, so it is correct and logical to capitalize each word. Isaiah DeRose-Wilson

05:52 pm Bug Report #3543: Kohana_Form::label() shouldn't use ucwords()

It's grammatically incorrect (I am however no grammar expect so no nick picking :P), causing my website text to be in... Alex Cartwright

05:03 pm Bug Report #3543: Kohana_Form::label() shouldn't use ucwords()

Can you provide an example and specific reason why it should do this? Jeremy Bush

03:49 pm Bug Report #3543 (Closed): Kohana_Form::label() shouldn't use ucwords()

Kohana_Form::label() currently uses ucwords() on the $input variable if $text is null, however this can cause issues ... Alex Cartwright

02:48 pm Auth Revision ee35422d: Merge branch '3.0/master' into 3.1/develop

Isaiah DeRose-Wilson

02:25 pm Auth Revision fc8781e9: Fix parse error in get_user() and require hash_key to be set, fixes #3542

Isaiah DeRose-Wilson

02:20 pm Auth Bug Report #3542 (Closed): Auth::hash() should require a valid hash key

Fixed by "fc8781e92...":https://github.com/kohana/auth/commit/fc8781e926c88b214abb154af94ff83b237f1902 Isaiah DeRose-Wilson

02:17 pm Auth Bug Report #3542 (Closed): Auth::hash() should require a valid hash key

The Auth::hash() method should throw an exception if you don't have a hash key defined. Also the Auth::hash_password(... Isaiah DeRose-Wilson

02:29 am Auth Feature Request #3541 (Closed): Update ORM driver and related models for new ORM version

The ORM driver and related orm models need to be updated for the new 3.1 orm. Isaiah DeRose-Wilson

01/03/2011

09:05 pm ORM Revision c02f651d: empty_pk() now checks to see if the PK is empty OR PK === '0'

Andrew Ellis

09:00 pm ORM Bug Report #3540 (Closed): ORM::empty_pk issue

Thanks for the pull request. Fixed by "c02f651d3...":https://github.com/kohana/orm/commit/c02f651d37827aa50d46c97092f... Isaiah DeRose-Wilson

08:48 pm ORM Bug Report #3540: ORM::empty_pk issue

GitHub Pull Request: https://github.com/kohana/orm/pull/17 Andrew Ellis

08:39 pm ORM Bug Report #3540: ORM::empty_pk issue

Simply put, the current way this code sounds is like this:
"if empty AND it doesn't equal 0"
Just doesn't make ... Andrew Ellis

08:32 pm ORM Bug Report #3540 (Closed): ORM::empty_pk issue

Because of the way ORM runs it's "check" method, this causes the _object[primary_key] to get set to {string} "0" if t... Andrew Ellis

07:19 pm ORM Revision c794a795: throwing an exception when find() or find_all() is called on a loaded object. ...

Isaiah DeRose-Wilson

07:15 pm ORM Revision 2b1fb54f: adding calls to ORM::wish() in count_all() (refs #3457)

Lorenzo Pisani

07:13 pm ORM Bug Report #3524 (Closed): find() and find_all() should throw exceptions when the model is loaded

Fixed by "c794a7959...":https://github.com/kohana/orm/commit/c794a795902ba56fbe67dc6e2fc4547994dba1ae Isaiah DeRose-Wilson

07:11 pm ORM Revision e4433c1e: Made ORM extend the Model class. Fixes #3532

Isaiah DeRose-Wilson

07:09 pm ORM Bug Report #3457 (Closed): count_all does not use $_load_with

Fixed by "2b1fb54fe149...":https://github.com/kohana/orm/commit/2b1fb54fe1496a262c6363f8546b95a3ef1f640a Isaiah DeRose-Wilson

07:06 pm ORM Feature Request #3532 (Closed): ORM should extend the Model class

Fixed by "e4433c1eb...":https://github.com/kohana/orm/commit/e4433c1ebd0f21f29220b47b42dd0b24535dfda2 Using Model::fa... Isaiah DeRose-Wilson

07:04 pm ORM Revision 8e0ca447: Removed unused ORM::$_primary_val, fixes #3246

Isaiah DeRose-Wilson

06:59 pm ORM Feature Request #3246 (Closed): Added a function to return primary value.

Removed ORM:::$_primary_val. I don't really see a need for this. See "8e0ca447...":https://github.com/kohana/orm/comm... Isaiah DeRose-Wilson

03:30 pm Core Revision 2e417f10: Exceptions should use the correct http headers. Refs #3537

Isaiah DeRose-Wilson

02:55 pm Core Revision ec945ea5: Remove Kohana_ prefix from some http exception calls. Fixes #3539

Jeremy Bush

02:50 pm Bug Report #3539 (Closed): Kohana_Http_* Exception should be Http_*

Fixed by https://github.com/kohana/core/commit/ec945ea5406962267e4940acf08d5a3e505b70a5 Jeremy Bush

02:48 pm Bug Report #3539 (Closed): Kohana_Http_* Exception should be Http_*

We have a few lines in core which throws new Kohana_Http_* exceptions. They should be changed to remove the Kohana_ p... Jeremy Bush

08:09 am Feature Request #3536: Remove controller method parameters

I see what your saying, but I believe your missing the point of routes :)
the "tips section":http://kohanaframework.... Kiall Mac Innes

07:38 am Feature Request #3536: Remove controller method parameters

I am talking about changing the key name of route parameters.
if I don't want to set too many route and just merge... Yahasana .

07:17 am OAuth Bug Report #3323 (Closed): OAuth library conflicts with PECL OAuth

The OAuth module has been depreciated in 3.1, this is no longer an issue. Kiall Mac Innes

07:15 am Cache Patch #3337: Session handler using Cache

There are a few issues with the code in that repo:
@protected $_memcached;@ looks like a leftover?
The @if ( ! ... Kiall Mac Innes

07:08 am Bug Report #3340 (Closed): Kohana's image library can fall over when given an invalid JPEG

An @ErrorException@ is already thrown when any PHP error/warning occurs, and silently failing is not really an option.. Kiall Mac Innes

06:53 am Bug Report #3512: Conflicting standards dealing with whitespace

Personally, I believe @'{'.(int) $digits.'}'@ is correct (even if the standards aren't 100% clear)... Kiall Mac Innes

06:39 am Feature Request #3536: Remove controller method parameters

Yahasana . wrote:
> Yes, you are right. but I seldom use reverse routing, and I believe it's a rare cases.
I believe... Kiall Mac Innes

05:34 am Revision f1fde9db: Cleanup build.xml phpcs target

Kiall Mac Innes

05:25 am Revision d011025e: Cleanup build.xml pdepend-log target

Kiall Mac Innes

05:21 am Revision 0a01f87e: Cleanup build.xml phpcpd target

Kiall Mac Innes

05:07 am Feature Request #3536: Remove controller method parameters

Jeremy Bush wrote:
> That is a non-issue. If you change your route parameters, you already have to go any change all ... Yahasana .

05:01 am Revision d6b61e93: Cleanup build.xml dist target logic

Kiall Mac Innes

04:57 am Bug Report #3538 (Closed): Validation changes ignores Geiger's context bit

The 3.1 changes are definitely in the right direction, but they do ignore the dynamic contexts spec from Mr. Geiger: ... Ben Midget

04:46 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Sincere apologies. I could have sworn I had set up NetBeans right for tabs, but I clearly hadn't. Will check my setti... Andrew Coulton

04:45 am Feature Request #3537 (Closed): Http_Exception_* exceptions should be displayed like normal excep...

Applied in changeset commit:"bff5081a1e6089fc20efb9ef29719c34a029a1da". Isaiah DeRose-Wilson

04:38 am Feature Request #3537 (Needs Test): Http_Exception_* exceptions should be displayed like normal e...

Fixed by "bff5081a":https://github.com/kohana/core/commit/bff5081a1e6089fc20efb9ef29719c34a029a1da Isaiah DeRose-Wilson

04:38 am Revision cbf1fbc5: Removing checkreturn="true" from test targets, hudson should determine this fr...

Kiall Mac Innes

04:37 am Core Revision bff5081a: Display Http_Exceptions like normal exceptions including backtrace and other d...

Isaiah DeRose-Wilson

04:35 am Revision 71aead36: Fix to build.xml dist paths.

Kiall Mac Innes

04:28 am Feature Request #3537 (Closed): Http_Exception_* exceptions should be displayed like normal excep...

Http_Exception_* exceptions should be displayed like normal exceptions to make debugging easier. It's important to se... Isaiah DeRose-Wilson

04:23 am Revision d106d7ea: Fixing comment syntax error in build.xml

Kiall Mac Innes

04:17 am Revision db0089dd: Adding initial dist target to build.xml. Needs some cleanup.

Kiall Mac Innes

04:17 am Revision d2d57276: Merge branch '3.1/develop' of github.com:kohana/kohana into 3.1/develop

Kiall Mac Innes

04:09 am Feature Request #3536: Remove controller method parameters

That is a non-issue. If you change your route parameters, you already have to go any change all your route::uri() cal... Jeremy Bush

04:01 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Also, there's lots of style violations in your pull request. Please review the style guidelines and update your pull ... Jeremy Bush

04:01 am Feature Request #3536: Remove controller method parameters

$this->request->param() is depended on the key name set in Route::set(), if these keys name are changed, all the $thi... Yahasana .

03:58 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Actually, userguide changes should be fine. It's not an api that developers use, it's more of a pre-built application... Jeremy Bush

03:38 am Core Revision 4efabae1: Mark controller action parameters deprecated. Refs #3536

Jeremy Bush

03:38 am Userguide Revision 957e4697: Fixed @3535 minor typo in API browser when no class methods

Andrew Coulton

03:34 am Userguide Bug Report #3535: Typo in API view when no class methods

Fixed in https://github.com/kohana/userguide/pull/12 Andrew Coulton

03:30 am Feature Request #3536 (Closed): Remove controller method parameters

This behavior is confusing to beginners and even advanced users. We should recommend all users use $this->request->pa... Jeremy Bush

03:15 am Userguide Bug Report #3535 (Closed): Typo in API view when no class methods

The API Browser currently shows "one" rather than "None" under the methods column when the class has no methods. Andrew Coulton

03:13 am Userguide Feature Request #3486: Show what interfaces a class implements

Implemented in https://github.com/kohana/userguide/pull/11 - nothing particularly special in the styling, but it works. Andrew Coulton

02:48 am Revision e7b1d186: Tracking system submodule

Jeremy Bush

02:46 am Core Revision c7c097b0: Merge fallout

Jeremy Bush

02:42 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Have:
* Updated branch name to new pattern (3.2/feature/3529-exclude-configurable-transparent-classes).
* Created uni... Andrew Coulton

02:30 am Revision 30498cd0: Tracking system for release branch

Jeremy Bush

02:28 am Userguide Patch #3534 (Closed): User guide CSS updates

Updated jQuery, fixed an overflow auto from adding scrollbar to footer, changed the grays for the code background col... Joel Pittet

02:26 am Core Revision 703217fb: Fixing merge fallout

Jeremy Bush

02:26 am Userguide Revision c578da14: Updated jQuery, fixed an overflow auto from adding scrollbar to footer, change...

Joel Pittet

02:12 am Revision c651291a: Updating build.xml to reference the new branch naming scheme

Kiall Mac Innes

01:52 am Revision b9e2ecb2: updating readme for the master branch

Jeremy Bush

01:44 am Revision e728f596: Merge remote branch 'origin/3.1.x' into 3.1.x

Jeremy Bush

01:43 am Revision 5d9e9ffc: tracking 3.1 system dir

Jeremy Bush

01:39 am Core Revision f001bc73: Merge remote branch 'origin/3.1/develop' into 3.1/develop

Jeremy Bush

01:36 am Core Revision e7f33744: Merge branch '3.0/develop' into 3.1/develop

Conflicts:
classes/kohana/controller.php
classes/kohana/core.php
classes/kohana/log.php
classes/kohana/log/stderr... Jeremy Bush

01:11 am Patch #3533 (Closed): Comments and core guide changes for 3.1.0

Updated some copyright to 2011. Fixed a comment for response->body() and all the docs related to $this->request->resp... Joel Pittet

01/02/2011

09:16 pm ORM Feature Request #3246: Added a function to return primary value.

I think we should just remove ORM::$_primary_val Isaiah DeRose-Wilson

09:14 pm ORM Feature Request #3532 (Closed): ORM should extend the Model class

ORM should extend the model class to make using it more transparent by allowing you to do instanceof Model or Model::... Isaiah DeRose-Wilson

07:26 pm Core Revision 35075cbb: Code cleanup, Refs #3506

Isaiah DeRose-Wilson

06:26 pm Bug Report #3531 (Closed): Response body should be converted into string only when output is gene...

We discussed this at great length, and decided it was best if it was converted to a string when setting the body. Jeremy Bush

05:26 pm Bug Report #3531 (Closed): Response body should be converted into string only when output is gene...

Hi All,
I think the @Response::body()@ method should not convert it's parameter into a string, maybe it is needed ... Bence Eros

03:43 pm Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Fair enough - wasn't sure if that was the case for the submodules too - good to have confirmation.
Have looked fur... Andrew Coulton

10:35 am Feature Request #3530 (Closed): Subdomain method added to Request class

Method to get the current subdomain name (alt. false if no subdomain).
Something like this:
// Request::subdomai... Jonas Nyström

06:25 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

We aren't accepting new features in 3.0 or 3.1, so this is moving to 3.2. Jeremy Bush

02:20 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser

Implemented at https://github.com/acoulton/userguide/tree/3.2%2Ffeature%2F3529-exclude-configurable-transparent-class... Andrew Coulton

02:12 am Userguide Feature Request #3529 (Closed): Configurable transparent extension prefixes in API browser

Currently, KoDoc automatically excludes classes beginning with Kohana_ so that the API browser isn't cluttered with t... Andrew Coulton

02:03 am Bug Report #3528 (Closed): debug_source should ignore "Unknown" files

As per http://forum.kohanaframework.org/discussion/7714/intermittant-is_readable-open_basedir-error, the debug_source... Daniel Lo Nigro

01:30 am Bug Report #3527 (Closed): bootstrap should use getenv ranter than $_ENV

Applied in changeset commit:"8b8c569177eff6efb884fae9f8fa4eb2af68170a". Isaiah DeRose-Wilson

01:27 am Revision 8b8c5691: Replaced $_ENV['KOHANA_ENV'] with getenv('KOHANA_ENV'). Fixes #3527

Isaiah DeRose-Wilson

01/01/2011

07:39 pm Bug Report #3527: bootstrap should use getenv ranter than $_ENV

Seems like 3.1 branch has this
https://github.com/kohana/kohana/blob/3.1-RC1/application/bootstrap.php#L62-65 Dmitry T.

06:56 pm Bug Report #3527 (Assigned): bootstrap should use getenv ranter than $_ENV

Jeremy Bush

10:18 am Bug Report #3527 (Closed): bootstrap should use getenv ranter than $_ENV

The bootstrap should be using @getenv()@ rather than @$_ENV@ as @$_ENV@ is rarely set in a production environment.
... Brandon Summers

12:03 am Bug Report #3526 (Closed): Wrong Kohana version

When use Kohana 3.0.9... Mulia Arifandy Nasution

12/31/2010

09:38 pm Revision 3e9fc446: updating readme for 3.1

Jeremy Bush

09:30 pm Revision 8bfabf79: Tracking new submodule branches. Removing oauth and pagination from 3.1

Jeremy Bush

08:16 pm Revision abf82d46: Merge remote branch 'origin/3.1.x' into 3.1.x

Conflicts:
system Jeremy Bush

08:14 pm Revision a204ad01: Tracking system submodule for 3.1 rc1

Jeremy Bush

07:47 pm Core Revision 05c8512b: Required route parameters should output from uri(). Fixes #3015

Jeremy Bush

07:41 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters

Fixed and tested by https://github.com/kohana/core/commit/05c8512b86369e8913ce7dd1822b42af4df83bdd. Jeremy Bush

06:16 pm Revision 205d6f4d: Updating system

Isaiah DeRose-Wilson

06:15 pm Core Revision 2aa872b4: Merge branch '3.1.x' of github.com:kohana/core into 3.1.x

Isaiah DeRose-Wilson

06:15 pm Core Revision 9d6eedec: Added tests for Kohana::$expose, fixes #2269

Isaiah DeRose-Wilson

06:09 pm Feature Request #2269 (Closed): X-Powered-By

Tested by "9d6eedecad...":https://github.com/kohana/core/commit/9d6eedecad7afb78211cb01c1967a6a3f1db0ad1 Isaiah DeRose-Wilson

05:39 pm Database Feature Request #2009: Implement or_on() in Database

There should be a better way to do this. Do we need to support parentheses too? This should probably be done like the... Isaiah DeRose-Wilson

04:34 pm Core Revision 82b87a6b: More secure Security::token, hashing the generated uniqid(), fixes #3437

Woody Gilk

04:29 pm Core Revision 83e29859: Fixed issue that prevented local View variables from taking precendence over g...

Woody Gilk

04:28 pm Bug Report #3437 (Closed): CSRF token does not need a prefix

Fixed by https://github.com/kohana/core/commit/82b87a6b2c4587eab301775f0e57b21a4de97221 Woody Gilk

04:23 pm Core Revision cc6e0ed1: Add status code to the exception in Remote::get, fixes #3477

Woody Gilk

04:23 pm Bug Report #3450 (Closed): Have local variables override global in Kohana_View

Fixed by https://github.com/kohana/core/commit/83e298593dba3927a198a6b558f327ff97b00f68 Woody Gilk

04:19 pm Core Revision 60c8cd77: Added iPad and iPod to mobile user agents, fixes #3463

Woody Gilk

04:17 pm Feature Request #3477 (Closed): Remote Exception codes

Fixed by https://github.com/kohana/core/commit/cc6e0ed1344466787df4519f747fd504e0899b12 Woody Gilk

04:15 pm Core Revision bfdfc8e5: Make the removal of spaces in Upload::save() UTF-8 safe, fixes #3460

Woody Gilk

04:13 pm Core Revision 22801e01: Added tests for 74f1be84ac44cac479fec27d1e59a9bb22385a64, refs #3496

Woody Gilk

04:12 pm Bug Report #3463 (Closed): User agents is missing mobile detection of ipod touch and ipad

Fixed by https://github.com/kohana/core/commit/60c8cd7755375cd8f989cbe29ef88b6a0ae30b0e Woody Gilk

04:11 pm Core Revision 74f1be84: Added more uncountable words to Inflector configuration, fixes #3496

Woody Gilk

04:09 pm Bug Report #3460 (Closed): Upload::save() UTF-8 problem

Fixed by https://github.com/kohana/core/commit/bfdfc8e57ba6cee1e4709536742a120e546d64f1 Woody Gilk

04:07 pm Bug Report #3496 (Closed): Uncountable words for inflector config

Tested by https://github.com/kohana/core/commit/22801e014f638f1a5245ee2f2823ae9230012f2e Woody Gilk

04:05 pm Bug Report #3496 (Needs Test): Uncountable words for inflector config

Fixed by https://github.com/kohana/core/commit/74f1be84ac44cac479fec27d1e59a9bb22385a64 Woody Gilk

03:29 pm Bug Report #3525 (Needs Test): Header Value incorrect parsing of user agent entry

Isaiah DeRose-Wilson

12:00 pm Bug Report #3525 (Closed): Header Value incorrect parsing of user agent entry

Applied in changeset commit:"ec816385cba405144bf3b4db4abd8c1acac1a7b2". Sam de Freyssinet

11:54 am Core Revision ec816385: Fixes #3525, handles the user-agent header without parsing

Sam de Freyssinet

11:34 am Bug Report #3525 (Closed): Header Value incorrect parsing of user agent entry

The User-Agent header field is being parsed incorrectly, separating the string on @;@ character. This is incorrect.
... Sam de Freyssinet

04:57 am Revision c270d406: Updating system

Isaiah DeRose-Wilson

04:51 am Core Revision 928c6ff9: Merging in 3.0.x branch

Isaiah DeRose-Wilson

01:53 am Bug Report #3015 (Assigned): Reverse routing should not include the default parameters

Jeremy Bush

01:25 am Core Revision c5471e3e: Arr::set_path cleanup. Refs 2566918b5748ea3f0a05

Isaiah DeRose-Wilson

01:23 am ORM Bug Report #3524 (Closed): find() and find_all() should throw exceptions when the model is loaded

This causes quite a few bugs and is very confusing. The change will make it required to call clear() on any loaded ob... Lorenzo Pisani

01:20 am Core Revision 7398b430: Validation docs cleanup. Refs ac7e555c104e664177e4

Isaiah DeRose-Wilson

01:14 am ORM Revision e62f93e5: cleaning up some code conventions and simplifying recent code changes

Isaiah DeRose-Wilson

01:01 am ORM Revision c27802a3: preventing ORM from running multiple queries for the same related model in __g...

Lorenzo Pisani

01:01 am ORM Revision 65ec0f1f: allowing ORM::has() to check by primary key and look for many related rows at ...

Lorenzo Pisani

12:56 am ORM Bug Report #3066 (Closed): ORM overwrites related objects if they are not loaded

Fixed by "c27802a3...":https://github.com/kohana/orm/commit/c27802a3dbf34c174d2a1fc7b6ad55f3eb53c142 Isaiah DeRose-Wilson

12:55 am ORM Feature Request #2992 (Closed): ORM::has() for multiple objects

Fixed by "65ec0f1f11...":https://github.com/kohana/orm/commit/65ec0f1f11fa80dce899c4e1ac9ebdb83c1cfe95 Isaiah DeRose-Wilson

12:48 am Revision 5d0e85f2: Merge branch '3.1.x' of github.com:kohana/kohana into 3.1.x

Isaiah DeRose-Wilson

12:48 am Revision ae1afb13: Updating system. Removed unittest module for phpcs checks because it doesn't f...

Isaiah DeRose-Wilson

12:46 am ORM Bug Report #3457: count_all does not use $_load_with

That bug should have been fixed by #3522 Isaiah DeRose-Wilson

« Previous

Next »