Activity
From 01/08/2011 to 02/06/2011
02/06/2011
-
05:41 pm Core Revision a85fc0ab: Updated exception handler example in the error-pages tutorial
-
04:53 pm ORM Feature Request #3706 (Closed): Allow has() to check if there is a relationship without specifyin...
- Calling @has()@ with just the alias should check if the model has any of the alias, regardless of the foreign model's...
-
06:27 am Bug Report #3653 (Closed): exception_handler does not exit with proper status code
- I tend to agree.
Handle exceptions and provide the proper exit code that you need. -
05:41 am Revision 196c9f0e: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
05:41 am Revision 3e2e5251: Updating modules
-
05:36 am Database Revision 2e450995: Fixes #3704 - Database error codes are inaccessible without parsing the except...
-
05:35 am Database Bug Report #3704 (Closed): Database error codes are inaccessible without parsing the exception $m...
- Fixed in 82a47ba819b51605a50868afab99ae26cb0af205
-
05:35 am Database Bug Report #3705 (Closed): Database error codes are inaccessible without parsing the exception $m...
- Fixed in 2e4509950a49b42e1c866958d8676f1a54fd984f
-
05:33 am Database Revision 82a47ba8: Fixes #3704 - Database error codes are inaccessible without parsing the except...
-
05:29 am Database Bug Report #3705 (Closed): Database error codes are inaccessible without parsing the exception $m...
- Database error codes are inaccessible without parsing the exception $message!
-
05:27 am Database Bug Report #3704 (Closed): Database error codes are inaccessible without parsing the exception $m...
- Database error codes are inaccessible without parsing the exception $message!
-
05:26 am Bug Report #3653: exception_handler does not exit with proper status code
- I don’t agree - most exceptions will have a code of 0 meaning exit(0) will indicate a successful response.
This sh... -
05:07 am Bug Report #3652: Validation bind() should allow callbacks, closures
- We are feature-locked in 3.1. Only bug fixes can be added. Sorry.
-
04:59 am Bug Report #3628: 3.1RC2 - External POSTing Request, not sending post key/value pairs
- I'm not happy either, but it's not a bug, so we can't add it to 3.1. We can use 3.2 to refine what the original desig...
-
04:51 am Auth Bug Report #3670 (Closed): Auth logged_in always returns true even if the user isn't logged in.
- Fixed by "aeb815cf82813...":https://github.com/kohana/auth/commit/aeb815cf8281310f6bae34458157a71c87153c02
-
04:51 am Auth Revision aeb815cf: Auth::get_user() returns null when there is no user. Fixed #3670
-
04:47 am Bug Report #3628: 3.1RC2 - External POSTing Request, not sending post key/value pairs
- I have started on this already. As Kiall rightly points out, there are numerous considerations for posting data. It i...
-
04:47 am Bug Report #3658 (Closed): Validation should use the method name as the error rule
- Fixed by "1cb969039b...":https://github.com/kohana/core/commit/1cb969039b2f9cfc3920c030066179033e981d1b
-
04:47 am Bug Report #3652 (Feedback): Validation bind() should allow callbacks, closures
-
04:46 am Bug Report #3652 (Closed): Validation bind() should allow callbacks, closures
- Oops wrong ticket!
-
04:44 am Core Revision 1cb96903: Merge branch '3.1/bugfix/3658-validation-class-method-as-error-name' of https:...
-
04:42 am Bug Report #3628: 3.1RC2 - External POSTing Request, not sending post key/value pairs
- I should add that you can do this:...
-
04:39 am Bug Report #3628: 3.1RC2 - External POSTing Request, not sending post key/value pairs
- This touches on a few different areas ..
* We need to support content types other than @application/x-www-form-url... -
04:23 am Bug Report #3633 (Closed): Missing remote.php config for request
- Fixed by "8c483326f...":https://github.com/kohana/core/commit/8c483326f9a43e300eab173a5d8d3d6f8b8f8bc4
-
04:22 am Bug Report #3634 (Closed): Cannot set external request options
- Fixed by "8c48332...":https://github.com/kohana/core/commit/8c483326f9a43e300eab173a5d8d3d6f8b8f8bc4
You use the g... -
04:17 am Core Revision 8c483326: Added options() setter/getter method. Fixes #3634
- Removed call to non-existent remote.php Fixes #3633
-
04:02 am Bug Report #3703: error view overrides all the classes on the HTML element
- Fized in b59dcf2
-
04:02 am Core Revision b59dcf22: Fixes #3701 - error view overrides all the classes on the HTML element
-
04:02 am Bug Report #3703 (Closed): error view overrides all the classes on the HTML element
- Dupe of #3701 for K3.0
On line 30 of views/kohana/error, the following JS replaces all of the existing classes o... -
03:54 am Auth Bug Report #3630 (Closed): coding standard violation: Variables should precede constants in compa...
- Fixed by "ee35422db1...":https://github.com/kohana/auth/commit/ee35422db1c17391aaedb59ccc1843adb564fbc5
-
03:51 am Patch #3639 (Closed): Remove unnecessary comment
- Fixed by "f5cb342076e...":https://github.com/kohana/core/commit/f5cb342076efaec076c2208676023bce38f36c4b
-
03:48 am Bug Report #3668 (Closed): Unused property $_http_view in Kohana_Http_Exception
- Fixed by "07ad7c77f4...":https://github.com/kohana/core/commit/07ad7c77f4fda42f27302d684955697211a0ef47
-
03:48 am Core Revision 9e24a5ff: Merge branch '3.1/develop' of github.com:kohana/core into 3.1/develop
-
03:47 am Core Revision 07ad7c77: Removed unused variable. Fixes #3668
-
03:37 am ORM Bug Report #3289 (Closed): Not editable fields in ORM
- That's correct. I was fixed
-
02:53 am Core Revision a132fd68: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
02:53 am Core Revision 173c0656: Fixes #3701 - error view overrides all the classes on the HTML element
-
02:52 am Bug Report #3701 (Closed): error view overrides all the classes on the HTML element
- Fixed in 173c065
-
02:48 am Feature Request #3702 (New): Support RFC2518 status codes
- Support both sending and receiving (via Request_Client_External) RFC 2518 (WebDAV) status codes:
* 102 Processing
... -
02:33 am Bug Report #3701 (Closed): error view overrides all the classes on the HTML element
- On line 30 of views/kohana/error, the following JS replaces all of the existing classes on the HTML (documentElement)...
-
01:31 am Core Revision fe3cd474: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
01:31 am Core Revision d07e3c97: Fixes #3700 - Request_Client_External, when using curl, does not set the reque...
-
01:30 am Bug Report #3700 (Closed): Request_Client_External, when using curl, does not set the request body.
-
01:29 am Bug Report #3700 (Closed): Request_Client_External, when using curl, does not set the request body.
- Request_Client_External, when using curl, does not set the request body.
-
01:01 am Core Revision af23203a: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
12:59 am Bug Report #3699 (Closed): Request_Client_External, when using curl, does not set the request met...
-
12:58 am Core Revision af9d0793: Fixes #3699 - Request_Client_External, when using curl, does not set the reque...
-
12:58 am Bug Report #3699 (Closed): Request_Client_External, when using curl, does not set the request met...
- Request_Client_External, when using curl, does not set the request method.
02/05/2011
-
11:25 pm UnitTest Patch #3698 (Closed): Exception traces in Unit Test web interface
- See https://github.com/leth/unittest/commit/c49f1a599b1920cf98934ccec213477e4314883d
There's a bit of code copy/pa... - 10:49 pm UnitTest Revision bb20b54e: Fixed redirect for viewing code coverage reports.
-
03:49 pm ORM Feature Request #3697 (New): Late static binding on table dependent model settings
- There are many properties in the model which should be static, there is no need to have them in each object instance.
- 03:48 pm UnitTest Revision 40423b9b: Fixed form submission URL.
-
01:57 pm Patch #3603: Docs and Downloads Updates
- I'd like to see these changes land ASAP.
02/04/2011
-
10:39 pm Core Revision e0fb226b: Fixing bug in HTML tests, fixes #3696
-
07:44 pm Bug Report #3696 (Closed): Fix HTMLTest to include index_file environmentDefault
- Fixed in https://github.com/kohana/core/commit/9fa387eb5547fe4ad3cb18fab594c68a7575202c
-
07:43 pm Core Revision 9fa387eb: Fixing bug in HTML tests, fixes #3696
-
07:03 pm Bug Report #3615 (Closed): ternary rule incorrectly requires parentheses
- Fixed in https://github.com/kohana/coding-standards/commit/0e509375897e8c12866b90d41e66ca9c2fd93957
-
04:27 pm Bug Report #3696 (Closed): Fix HTMLTest to include index_file environmentDefault
- If you change Kohana::$index_file to be anything other than index.php, then the HTMLTest tests for test_script|style|...
-
03:52 pm Userguide Bug Report #3695 (Closed): Markdown should not be included in the controller
- https://github.com/kohana/userguide/blob/3.1/master/classes/controller/userguide.php#L61
Having it happen here cau... -
03:51 pm Userguide Bug Report #3694 (Closed): Markdown should not be included in the controller
- https://github.com/kohana/userguide/blob/3.0/master/classes/controller/userguide.php#L41
Having it happen here cau... -
03:37 pm Bug Report #2305: ORM - _preload_data not being saved
- ORM::$_preload_data isn't meant to be used like that. ORM::$_preload_data is designed to store data set by mysql_fetc...
-
02:57 pm Core Revision 69ebbf2a: Fixes #3693 - HTTP POST requests are allowed to contain a body per RFC2616
-
02:56 pm Bug Report #3693 (Closed): HTTP POST requests are allowed to contain a body per RFC2616
- Fixed in 69ebbf2
-
02:56 pm Bug Report #3693 (Closed): HTTP POST requests are allowed to contain a body per RFC2616
- HTTP POST Requests are allowed to contain a entity-body per RFC2616
This code in the Request class prevents consis... -
01:00 pm Bug Report #3655: Email address obfuscation
- Honestly - @HTML::obfuscate()@ should probably just be removed. The only way to prevent crawlers reading the email ad...
-
12:54 pm ORM Bug Report #3289 (Feedback): Not editable fields in ORM
- Has this made it into 3.1? (either by mistake or on purpose!)
99% sure it has! -
12:50 pm ORM Feature Request #3692 (Closed): Add changed() method to ORM
- Eg: ...
-
12:48 pm ORM Feature Request #3691 (Closed): Add :original_value and :changed bind's to ORM's validation
- This allows for rules to always pass if :changed is FALSE
or
decide if a new value is valid based on the old v... -
12:32 pm Bug Report #3015: Reverse routing should not include the default parameters
- #3690 has been logged against 3.2 for this issue.
-
12:32 pm Bug Report #3690 (Closed): Request::uri() should return the actual URI
- The default parameters (@Route::defaults@) of a route are there to provide fallbacks when those segments are not incl...
-
12:29 pm Bug Report #3015: Reverse routing should not include the default parameters
- This cannot be fixed in 3.1. The 3.1 API is frozen! (adding a new class property and changing a methods output are bo...
-
11:48 am Bug Report #3015: Reverse routing should not include the default parameters
- Jeremy Bush i agree with you.
I have solution for this:
In Route class add new field '$params_from_default' to stor... -
09:13 am Bug Report #2305: ORM - _preload_data not being saved
- This example doesn't work in 3.0.9.
You need use _changed after parent::__construct($id) becouse in parent::__constr... -
09:03 am Bug Report #3689 (Closed): send_file() method in response class causes error
- Trying the following inside a controller action results in an *Kohana_Exception [ 0 ]: Unrecognized HTTP status code:...
02/03/2011
-
09:03 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters
- A new issue will be made for it. This issue is fixed and closed already.
-
08:53 pm Bug Report #3015 (Feedback): Reverse routing should not include the default parameters
- > we'll fix it in 3.2.
I think it should be pointed to 3.2 in this case -
04:47 pm Bug Report #3688 (New): Allow tabs before and after parentheses to improve long conditional forma...
- Difficult to format long statements with grouped AND and OR sections (like the one below) without getting whitespace ...
-
04:28 pm Bug Report #3015 (Closed): Reverse routing should not include the default parameters
- The real problem is actually something completely different.
Request::uri() should give you the uri that the reque... -
04:06 pm Bug Report #3015: Reverse routing should not include the default parameters
- For example:
Route::set(list', 'list(/<kind>)(/<country)')
->defaults(array(
'controller' => 'video... -
03:56 pm Bug Report #3687 (Closed): Switch case with nothing to do incorrectly flags break;
- The following code results in a "Code inside case and default blocks should be indented"...
-
02:44 pm Bug Report #3015: Reverse routing should not include the default parameters
- I don't see how this is possible. Request::uri simply adds the directory, controller and action from the request, and...
-
12:28 pm Bug Report #3015: Reverse routing should not include the default parameters
- Sorry! Route->uri works fine! Please fix only Request->uri()
Request->uri() should use request parameter only if para...
02/02/2011
-
09:37 pm Bug Report #3686 (Closed): Request_Client_External does not restore Request::$current when an err...
-
09:37 pm Core Revision 20a63514: Fixes #3686 - Request_Client_External does not restore Request::$current when ...
-
09:34 pm Bug Report #3686 (Closed): Request_Client_External does not restore Request::$current when an err...
- Request_Client_External does not restore Request::$current when an error occors during execute().
-
04:17 pm Bug Report #3685: additional white space sniffs
- Would it make sense to also throw a warning when it detects two or more adjacent space characters? Would have to tes...
-
04:04 pm Bug Report #3685: additional white space sniffs
- This might provide a starting point for this: http://pear.php.net/reference/PHP_CodeSniffer-1.1.0/__filesource/fsourc...
-
03:46 pm Bug Report #3685 (New): additional white space sniffs
- Detect if any tab or space character is followed by a newline to prevent trailing tabs or spaces on the end of lines ...
-
09:41 am Userguide Bug Report #3684 (New): Going to a specific url gives an error
- Going to "this":http://kohanaframework.org/guide/api/Array page on the kohana userguide, you get an syntax error:
... -
08:05 am Feature Request #3683 (Feedback): Exception naming conventions
- As of KO 3.x all classes are suffixed (e.g. @Controller_Template@, @Model_User@ or @Database_Query@).
Now there ar... -
04:45 am Bug Report #3682 (Closed): Inconsistency between cookie() post() and query() in Request class
- Applied in changeset commit:b7cbf71a89ae342730bbe7f6acfbc9126bf71351.
-
04:39 am Core Revision b7cbf71a: Fixes #3682 - Inconsistency between cookie() post() and query() in Request class
-
04:38 am Bug Report #3682 (Closed): Inconsistency between cookie() post() and query() in Request class
- Inconsistency between cookie() post() and query() in Request class.
-
01:44 am Revision 7e12545e: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
01:44 am Revision 5d8e77f4: Updating system
-
01:43 am Core Revision 186a2d70: Actually Fixes #3678
-
01:10 am Revision 85cb95f4: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
01:09 am Revision 5f3a8fa8: Updating system submodule.
-
01:06 am Core Revision 1a6f06a1: Merge branch '3.1/release/3.1.0' into 3.1/develop
- Conflicts:
guide/kohana/tutorials/error-pages.md -
01:06 am Revision d7792a42: Updating system submodule
-
12:56 am Core Revision 0de05f79: Merge remote branch 'origin/3.1/develop' into 3.1/develop
- Conflicts:
guide/kohana/bootstrap.md
guide/kohana/errors.md
guide/kohana/security/deploying.md -
12:45 am Bug Report #3678 (Closed): Make Kohana_Exception extendable
- Applied in changeset commit:82046bb1fb3e77c3995cd52b704dfc40ed7a20ab.
-
12:38 am Bug Report #3678 (Closed): Make Kohana_Exception extendable
- Make Kohana_Exception extendable ..
-
12:38 am Core Revision 82046bb1: Made Kohana_Exception extendable and updated error-pages tutorial. Fixes #3678
02/01/2011
- 06:35 pm Image Revision 480ff7c6: Follow up to 60f8b4e65448e22a992c3a85624b40f504d5f320, several bugs squashed t...
-
06:01 pm Bug Report #3015 (Feedback): Reverse routing should not include the default parameters
- I confirm.
-
05:47 pm Bug Report #3675: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- It shouldn't be a problem. Fixes are done in lower versions and merged up. Since this issue follows the original, the...
-
05:18 pm UnitTest Bug Report #3677: Remove the need for a separate database group
- Indeed this is giving a bad example of how to use database groups to everyone new to Kohana.
-
05:11 pm Bug Report #3675: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- Before anyone fixes this, please be aware of the updated discussion that happened on #3674. This turned out to be a ...
-
05:09 pm UnitTest Bug Report #3677: Remove the need for a separate database group
- Completely agree - what if the app uses 2x databases, forcing a "unittest" DB group is wrong
-
05:06 pm UnitTest Bug Report #3677 (Closed): Remove the need for a separate database group
- I don't think I should have to create a separate database group just for unit tests. It should be handled by the deve...
-
05:00 pm Revision 6194aec3: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
04:53 pm Revision 78147210: Updating cache submodule
-
04:51 pm Cache Bug Report #3629 (Closed): Cache_Apc::get() not using correct APC interface
-
04:51 pm Cache Bug Report #3627 (Closed): Cache_Apc::get() not using correct APC interface
-
04:50 pm Cache Revision 66c3fd8e: Fixes #3627 and Fixes #3629
-
04:49 pm Cache Revision 71eb3e91: Fixes #3627
-
04:46 pm Bug Report #3664 (Closed): Fatal error: Undefined class constant 'ERROR' in "session.php" on line...
-
04:45 pm Revision 4004a79f: Updating submodules.
-
04:40 pm Core Revision 67e41ee6: Fixing log constants - Refs #3664
-
04:29 pm Core Revision c15d620f: Merge branch '3.1/release/3.1.0' of https://github.com/kohana/core into 3.1/re...
-
04:28 pm Core Revision e1db78af: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
04:26 pm Core Revision 64fe16b5: Followup to #3160
-
04:03 pm Bug Report #3015: Reverse routing should not include the default parameters
- Im testing 3.1.0 and it isn't working :( Route::get('name')->uri() adds default params.
And what about using reverse ... -
02:28 pm Patch #3603: Docs and Downloads Updates
- If we can get 3.1 out the door this weekend, I'd rather wait on that.
-
02:19 pm Core Revision 8ac03f9d: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
02:11 pm Bug Report #3675: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- Ah I see, I forgot we were doing that
-
01:03 pm Core Revision 54f9bf38: Docs: adding messages docs
-
12:57 pm Core Revision f5cb3420: Docs: i18n docs
-
12:44 pm Core Revision 3883cf49: Docs: Add 404 handling note to migration guide, fix various typos
- 08:12 am Image Revision 60f8b4e6: Cleaned up Imagick driver and finished incomplete methods
- 06:03 am Bug Report #3674: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- I agree, this is definitely a bug in the find_file and not an issue with the unit test as originally suspected.
-
05:46 am Bug Report #3674 (Assigned): Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_...
- I think this is actually a bug in the Kohana::find_file() method. It is mixing up the results from find_file() and gi...
- 05:36 am Image Revision 6857c7c8: Use scaleImage instead of resizeImage to provide the most default behavior
- 05:20 am Image Revision 8cbc9551: Renamed ImageMagick classes to Imagick, to allow for a CLI ImageMagick driver
-
05:01 am Patch #3603 (Review): Docs and Downloads Updates
- What do people think about getting these changes merged into the site? I think it would be good to get 2.4 off the do...
-
01:11 am Bug Report #3675: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- Yes, look at the version and related issues.
-
01:11 am Bug Report #3675: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- This looks to be an exact duplicate of #3674?
- 12:16 am Database Revision 4b240a3f: Merge branch '3.0/develop' into 3.1/develop
- 12:15 am Database Revision a2de18c8: Follow up to 65adda9c1dbf944aeb8b12586a3e326f4334639f, better handling of boun...
-
12:12 am Database Bug Report #3676 (Closed): Cannot use parameter binding within WHERE conditions
- Consider the following example:...
01/31/2011
-
07:53 pm Bug Report #3675 (Closed): Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on...
- Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
<boolean:false> does not match expected type "arra... - 07:50 pm Bug Report #3673: typo on validate test class
- This only appears to be a 3.0 issue.
- 07:50 pm Bug Report #3674: Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
- This also appears to affect 3.1.0
- 07:35 pm Bug Report #3674 (Closed): Problem with Kohana_CoreTest::test_find_file_returns_false_or_array_on...
- Kohana_CoreTest::test_find_file_returns_false_or_array_on_failure
<boolean:false> does not match expected type "arra... - 06:43 pm Bug Report #3673 (Closed): typo on validate test class
- https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/ValidateTest.php#L15
Class -> class -
12:25 pm ORM Bug Report #3671: ORM do not override SELECT parameters
- The way select currently works (appending the table_name.* at the end of the select query builder) is just fine and s...
-
03:51 am Bug Report #3672: echo Debug::dump(...) returns inline text
- @Michal, you can open a feature request for formatting changes to the output of Debug::vars() for Kohana 3.2 if you'd...
01/30/2011
-
09:48 pm Bug Report #3672: echo Debug::dump(...) returns inline text
- I know, but I would expect the same behavior ...
And what about improving the readability of this listing?
By hig... -
09:22 pm Bug Report #3672 (Closed): echo Debug::dump(...) returns inline text
- Have a look at Debug::vars()... It does what you want..
-
07:31 pm Bug Report #3672 (Closed): echo Debug::dump(...) returns inline text
- This code will display a long line of something...
-
02:11 pm ORM Bug Report #3671 (Closed): ORM do not override SELECT parameters
- I have found a rare bug in ORM module.
If you use Select method in a ORM call, ORM do not override select fields.
...
01/29/2011
-
11:33 pm Auth Bug Report #3670 (Closed): Auth logged_in always returns true even if the user isn't logged in.
- That line https://github.com/kohana/auth/blob/3.1%2Fdevelop/classes/kohana/auth.php#L135 should either be:
return ($... - 10:45 pm Bug Report #3669 (Closed): wrong link to coding style in conventions page of userguide
- The first paragraph on this page: http://kohanaframework.org/guide/kohana/conventions has a link on the words "coding...
-
07:41 pm Feature Request #3666: Some added functionality in CLI
- The Fuel CLI class is interesting: https://github.com/fuel/fuel/blob/develop/fuel/core/classes/cli.php
Some of the... -
06:49 pm Bug Report #3667: Route method is_external() does not work
- And when this is resolved, there is a continuing problem in the ...
-
06:00 pm Bug Report #3668 (Closed): Unused property $_http_view in Kohana_Http_Exception
- There is a property which is never used and referenced view does not exist....
-
05:47 pm Bug Report #3667 (Closed): Route method is_external() does not work
- There is ...
-
06:59 am Bug Report #3658: Validation should use the method name as the error rule
- Sorry for the long delay! https://github.com/kohana/core/pull/73
-
06:57 am Core Revision 25b97366: adding unittest (refs #3658)
-
06:32 am Feature Request #3666 (Closed): Some added functionality in CLI
- It would be nice to have @CLI::input()@, @CLI::output()@, and @CLI::error()@ to work with @STDIN@, @STDOUT@, and @STD...
01/28/2011
-
09:07 pm Feature Request #3661: Add a generic valid rule for comparing 2 fields
- I suggest not adding the error manually but just returning true/false, the rule can accept data arrays other than Val...
-
06:20 pm Userguide Bug Report #3665: Filter does not work on API Browser.
- GitHub Pull Request: https://github.com/kohana/userguide/pull/18
-
06:20 pm Userguide Bug Report #3665 (Closed): Filter does not work on API Browser.
- Currently when you type a search query into the box on the API browser, nothing is filtered. This is due to some jQue...
-
06:17 pm Userguide Revision c58239c3: Fixed fiter search for API Browser.
-
02:37 pm UnitTest Bug Report #3663: DOCROOT is wrong
- This fixed it for me in a typical setup, but it depends on where the module is installed. Maybe DOCROOT should move u...
-
02:32 pm Bug Report #3664: Fatal error: Undefined class constant 'ERROR' in "session.php" on line 371
- Please fix the docs also
https://github.com/kohana/core/blob/3.1%2Frelease%2F3.1.0/guide/kohana/tutorials/error-page...
01/27/2011
-
10:00 pm Bug Report #3664 (Closed): Fatal error: Undefined class constant 'ERROR' in "session.php" on line...
- It seems that this was the old way to define the call for the log
https://github.com/kohana/core/blob/3.1%2Fdevelo... -
09:10 pm UnitTest Bug Report #3663 (Closed): DOCROOT is wrong
- When using unittest/bootstrap.php to bootstrap PHPUnit, DOCROOT gets set to the directory containing unittest/bootstr...
-
08:49 pm Core Revision 0e363a9b: the error name depends on the format of the rule (refs #3658)
- lambda functions cannot simply return FALSE to set an error, they must set it manually on the validation object
array... -
03:32 pm Bug Report #3662 (Closed): Kohana_Request::__construct() should throw HTTP_Exception_404
-
12:50 pm Bug Report #3662 (Closed): Kohana_Request::__construct() should throw HTTP_Exception_404
- Current Kohana_Request::__construct() does this when a route is not found (line 695 ):...
-
09:21 am Cache Bug Report #3407 (Feedback): cache file garbage collect delete git file
- It seems that first two conditions are unnecessary anymore after adding third condition.
-
05:44 am Feature Request #3661 (New): Add a generic valid rule for comparing 2 fields
- In some of my ORM models I have fields which need to be greater than or less than other fields in the same model. In ...
-
02:19 am Core Revision 3fd4ca86: Just for consistency updated text to match Kohana::FILE_SECURITY
- Signed-off-by: Woody Gilk <[email protected]>
-
02:17 am Core Revision e051609a: Just for consistency updated text to match Kohana::FILE_SECURITY
- Signed-off-by: Woody Gilk <[email protected]>
01/26/2011
-
11:35 pm ORM Support Request #3660 (Closed): ORM exception
- Thanks for the answer Rowan!
-
09:36 pm ORM Support Request #3660: ORM exception
- You can:...
-
07:22 pm ORM Support Request #3660 (Closed): ORM exception
- Why ORM throws exception when Validation fails....
-
12:58 pm Bug Report #3657: Environments and KOHANA_ENV
- I usually check @$_SERVER@ and fallback to @getenv()@ but I've no idea why there is a variance between PHP installati...
-
02:10 am Bug Report #3658 (Assigned): Validation should use the method name as the error rule
-
02:08 am Feature Request #3555 (Closed): .htaccess on fast-cgi
- The default rewrite rules work fine for me in fcgi. If you are still having issues with this please paste the content...
-
01:59 am Bug Report #3657: Environments and KOHANA_ENV
- I'm not really sure I see the reason for including $_SERVER in this. Yes environmental variables can be included in $...
-
12:02 am Bug Report #3659 (Closed): Irregular Inflector class term
- release => releases needs to be added to the irregular inflector terms (thanks Zeelot)
01/25/2011
-
11:43 pm Bug Report #3658: Validation should use the method name as the error rule
- Just want to add that this is the same idea as to why Valid::not_empty() creates an error for 'not_empty'
-
11:42 pm Bug Report #3658 (Closed): Validation should use the method name as the error rule
- If the following rule fails:...
-
10:42 pm Bug Report #3657 (Closed): Environments and KOHANA_ENV
- Environmental variables are passed in $_ENV global array only if they are set on the system, otherwise they are usual...
-
09:40 pm Feature Request #3656 (Closed): Allow Route::defaults() to return the defaults if no parameters a...
- I would like to be able to do @Route::get('something')->defaults()@ and get the default values for that route. This i...
-
04:11 pm Bug Report #3655 (Closed): Email address obfuscation
- I noticed my client started receiving spam on a shiny new website, where he wanted to have his name @ hiswebsite emai...
-
11:26 am Bug Report #3653 (Closed): exception_handler does not exit with proper status code
- If I throw an exception via CLI in Kohana then it should exit with that exception code.
A quick look at Kohana::exce... -
09:39 am Image Revision ce5919a2: ImageMagick Driver for the KO3 Image Module
-
06:32 am Bug Report #3652 (Feedback): Validation bind() should allow callbacks, closures
- The value of a parameter added by bind() should allow callbacks/closures. Without this simple change, it is impossibl...
-
03:15 am Bug Report #3643: Request->_status = 404; will never be observable
- There's another issue to change how this is handled. Unfortunately it will have to wait for 3.2.
-
12:51 am Bug Report #3643: Request->_status = 404; will never be observable
- I think this got mangled somewhere between my original implementation and the latter altered version. 404 status' sho...
01/24/2011
-
11:52 pm Auth Bug Report #3649 (Closed): ORM's Auth driver still returns multiple data types
- What?
-
11:06 pm Core Revision 244c32ec: Docs: Update error-pages tutorial for 3.1, misc typos
-
10:42 pm Core Revision 810f8802: Docs: Move content from orphan model.md to mvc/models.md
-
10:40 pm Core Revision f33172ac: Docs: typos
-
10:40 pm Core Revision 7a5bae31: Docs: removing routing empty routing tutorial
-
09:50 pm Auth Bug Report #3649 (Closed): ORM's Auth driver still returns multiple data types
-
07:24 pm Core Revision b04a22a7: Docs: Fixing typos
-
07:24 pm Core Revision ca7c8a2c: Adding basic model docs
-
06:07 pm Database Feature Request #3625: Creating tables in database
- We are talking about using something like the "real-database module":https://github.com/cbandy/real-database in 3.2 (...
-
05:22 pm Database Feature Request #3625: Creating tables in database
- I think if this feature will be implemented then all DDL operations should be supported by the Database module. Furth...
-
05:10 pm Bug Report #3526 (Closed): Wrong Kohana version
- Works for me, see "d57cd5bb...":https://github.com/kohana/core/commit/d57cd5bbdc0cd7184cf71ffc3021d48dee714868
-
05:06 pm Auth Bug Report #3630 (Assigned): coding standard violation: Variables should precede constants in com...
-
05:01 pm Core Revision 5e3a93d0: Docs: adding upgrade note about index.php/bootstrap.php
-
04:55 pm Feature Request #3635: Checking if module is active
- I fixed the issue and improved the error handling of the method (now it throws an exception if a module path is not a...
-
04:27 pm Feature Request #3648: Return a Request instance for requests which do not match any routes
- It's only related to #3647 as I posted the suggestion as part of that description, rather than a new issue as I shoul...
-
04:24 pm Feature Request #3648 (Closed): Return a Request instance for requests which do not match any routes
- Currently the constructor of the request class throws an exception if it doesn't match a route, this will prevent you...
-
04:21 pm Auth Bug Report #3644 (Closed): Attempt to use get_user() function
- This has been fixed in "fc8781e926c8...":https://github.com/kohana/auth/commit/fc8781e926c88b214abb154af94ff83b237f19...
-
03:39 pm Bug Report #3643: Request->_status = 404; will never be observable
- Actually fdabce.
$this->_status = 404; line should be gone, as requests don't have statuses. -
03:37 pm Core Revision fdabce37: Throw 404 exception is no routes match the uri. Fixes #3643
-
03:36 pm Bug Report #3643 (Closed): Request->_status = 404; will never be observable
- Fixed by 48482a.
-
03:34 pm Feature Request #3647 (Closed): Throw a Http_Exception_404 if no routes match a request
- Closing this because the current behavior is a bug and can be fixed with the associated issue.
-
03:33 pm Bug Report #3643: Request->_status = 404; will never be observable
- Kiall Mac Innes wrote:
> I believe this should just be throwing a 404 execption..
I'd agree, a uri without a matc... -
03:26 pm Bug Report #3643 (Assigned): Request->_status = 404; will never be observable
- I believe this should just be throwing a 404 execption..
Sam would know for sure ;) -
03:21 pm Bug Report #3643: Request->_status = 404; will never be observable
- This bug is now sort of eclipsed by the related feature request.
If the feature request is declined I'd suggest co... -
03:12 pm Feature Request #3647 (Closed): Throw a Http_Exception_404 if no routes match a request
- It might be good to throw a @Http_Exception_404@ instead of a @Kohana_Request_Exception@ if no routes match a request...
-
03:08 pm Core Revision bb61e727: Bunches of 3.1 doc updates, all over the place
-
02:32 pm Core Revision a39cd8ae: Updates to userguide: upgrading from 3.0, exception handling, etc
-
02:31 pm Bug Report #3646 (Closed): Bad form action
- I assume you are talking about 3.1, and this is expected behavior in 3.1.
-
02:14 pm Bug Report #3646 (Closed): Bad form action
- This code:...
-
12:01 pm Feature Request #3645: Session::get should use Arr::path
- Or maybe add a new function and name it like @Session::get_path/set_path@?
-
12:00 pm Feature Request #3645 (New): Session::get should use Arr::path
- Now it's inconvenient to get values from nested session arrays. You have to do something like:...
-
11:37 am Auth Bug Report #3644 (Closed): Attempt to use get_user() function
- When I try to use one of Auth module function (get_user), I get this error:...
-
10:58 am Bug Report #3643 (Closed): Request->_status = 404; will never be observable
- Forgive me if I'm missing something here but with the following code in the constructor of the Request class:
//... -
12:47 am Feature Request #3141: Config merging should treat non-associative array elelemts as unique
- I actually prefer replacing non-associative arrays to treating them as associative, as proposed in #3642. I recommend...
-
12:46 am Bug Report #3642: Arr::merge() shouldn't treat non-associative arrays differently than associative.
- Avoiding the bug doesn't fix the bug ;)
It's not specific to config reading, it's a flaw in arr::merge() which was... -
12:44 am Bug Report #3642 (Feedback): Arr::merge() shouldn't treat non-associative arrays differently than...
- I don't think this is a good idea. IMO, the proper solution is to make that array associative by naming each server *...
-
12:42 am Feature Request #3141: Config merging should treat non-associative array elelemts as unique
- This is fundamentally broken because you wouldn't be able to remove system/module level config values. See #3642.
-
12:40 am Bug Report #3642: Arr::merge() shouldn't treat non-associative arrays differently than associative.
- Note my sittercity patch could be optimized by just not having the if/else block.
-
12:37 am Bug Report #3642 (Closed): Arr::merge() shouldn't treat non-associative arrays differently than a...
- I don't think arr::merge() should treat non-associative arrays any differently than associative.
The specific prob... -
12:27 am Bug Report #3604: Kohana_Session_Native should optionally Cookie Parameters when calling session_...
- > Wouldn't it be better to call Cookie::$domain = ini_get(...);?
Perhaps, but I don't think this should be expecte...
01/23/2011
-
11:03 pm Bug Report #3313 (Closed): Request::detect_uri must never return FALSE
- Unit test added in https://github.com/kohana/core/commit/63fbc5c0ac04e452910c7c9779d79d2195a3341e
-
11:01 pm Core Revision 63fbc5c0: Added unit test for #3313
- 07:45 pm Bug Report #3420 (Closed): Kohana_Remote get method has hardcoded CURLOPT_RETURNTRANSFER
- Applied in changeset commit:277decf108647ad7391584a896707c761fe5e284.
-
07:44 pm Core Revision 277decf1: Put CURLOPT_RETURNTRANSFER in the Remote default options to allow it to be ove...
-
07:42 pm Bug Report #3604 (Assigned): Kohana_Session_Native should optionally Cookie Parameters when calli...
- Wouldn't it be better to call @Cookie::$domain = ini_get(...);@? There really is no way to fix this, because the cook...
-
07:39 pm Feature Request #3010 (Closed): Compile routes only if required
- No additional information or any tests provided.
-
07:38 pm Bug Report #3414 (Closed): Arr::path() doesn't work when the key is FALSE (NULL, 0, emptry string)
- You example returns @FALSE@ for me, I think this is invalid. The only time the default would be returned instead of t...
-
07:32 pm Bug Report #2957 (Feedback): Make sure Session::write is called last
- I think closing #3454 also closes this. In fact, the fix for #3454 probably makes using @register_shutdown_function@ ...
-
07:27 pm Bug Report #3454: Session is not closed prior to writing files, can cause delays with site
- This likely needs to be merged into 3.1 as well.
-
07:26 pm Bug Report #3454 (Closed): Session is not closed prior to writing files, can cause delays with site
- Fixed by https://github.com/kohana/core/commit/c53bef31cfbadc32b84549b30c7fb371ceb35b91
-
07:26 pm Core Revision c53bef31: Write all sessions when calling Request::send_headers, fixes #3454
-
07:12 pm Feature Request #3641 (Closed): Make Session::$instances public
- Fixed by https://github.com/kohana/core/commit/30fccab093507cbddd9ae9fddd6332100d20e283
-
07:12 pm Core Revision 30fccab0: Made Sesssion::$instances public, fixes #3641
-
07:12 pm Feature Request #3641 (Closed): Make Session::$instances public
- There is no good reason for @Session::$instances@ to be protected. It prevents people from doing clever things.
-
07:08 pm Database Bug Report #3404 (Closed): Error creating Exception object for SQLSTATE[42S22]: Column not found:...
- Fixed by https://github.com/kohana/database/commit/f2e5662d373e8d5847ee12c3e27c8210500bb5d2
-
07:08 pm Database Bug Report #3358 (Closed): pdo Database_Exception vs pgsql
- Fixed by https://github.com/kohana/database/commit/f2e5662d373e8d5847ee12c3e27c8210500bb5d2
- 07:07 pm Database Revision f2e5662d: Moving all error codes into messages for Database_Exception calls, fixes #3404
-
05:56 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- Isaiah DeRose-Wilson wrote:
> With a normal php install on windows, the php that is added to the system path is the ... -
04:10 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- With a normal php install on windows, the php that is added to the system path is the cli build. So if you type 'php ...
-
03:51 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- Kiall Mac Innes wrote:
> I would have imagined the windows builds of PHP come with a CLI sapi.. If they dont, an alte... -
03:41 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- I just downloaded php-5.3.5-Win32-VC6-x86.zip from http://windows.php.net.. It includes two executables. the CLI sapi...
-
03:34 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- I would have imagined the windows builds of PHP come with a CLI sapi.. If they dont, an alternative method of trigger...
-
03:27 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- > Examples
> (This is what you use for running cli scripts)
So, what, then, should I do if I'm using to develop W... -
03:18 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- Kiall Mac Innes wrote:
> I should also point out .. your patch is backwards .. you diff'ed the files in the wrong or... -
03:16 pm Feature Request #3640 (Closed): Add ORM models for the Auth module
- They already are ;)
https://github.com/kohana/orm/tree/3.1%2Fdevelop/classes/model -
03:14 pm Feature Request #3640 (Closed): Add ORM models for the Auth module
- The ORM models for Auth should be included in ORM. I know that one can use ORM without Auth, but it's far more likely...
-
03:10 pm Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- I have no idea how the status and resolution changed on my last comment :/
-
03:09 pm Bug Report #3638: Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- (oops too slow!)
I don't think this is an issue. The problem is you are using the wrong php to run your code. If you... -
03:07 pm Bug Report #3638 (Assigned): Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- I should also point out .. your patch is backwards .. you diff'ed the files in the wrong order :)
-
03:03 pm Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- the @Kohana::$is_cli@ flag is not intended to determine if your application is running under the cgi or fcgi sapi.
I... -
12:29 pm Patch #3639 (Closed): Remove unnecessary comment
- In 3.1.x file @base.php@ was removed, but there still is an unnecessary comment in i18n.php....
-
10:48 am Bug Report #3638 (Closed): Invalid parameter Kohana::$is_cli if PHP is running as fcgi
- When PHP is running as cgi-process, parameter Kohana::$is_cli returns FALSE.
It doesn't matter, we call the script ... -
05:20 am ORM Bug Report #3632 (Closed): Wildcard filters should run first
- Fixed in "af3137ed332...":https://github.com/kohana/orm/commit/af3137ed33244a18909ab25a5f417e759ac6a224
Thanks! -
05:18 am ORM Revision af3137ed: making wildcard filters run first (refs #3632)
01/22/2011
-
10:54 pm Bug Report #3637 (Closed): Incorrect doc comment in Arr::overwrite
- Fixed by https://github.com/kohana/core/commit/bcbaaef5ecafc18d26aed36f9c1e7e1bda9eb425
-
10:54 pm Core Revision bcbaaef5: Typo in Arr::overwrite, fixes #3637
-
10:53 pm Bug Report #3637 (Closed): Incorrect doc comment in Arr::overwrite
- From Ian Chilton:
> There is a mistake in the overwrite example:
>
> // The output of $array will now be:
> ar... -
10:51 pm ORM Bug Report #3632: Wildcard filters should run first
- https://github.com/kohana/orm/pull/22
-
10:48 pm Core Revision b2049c7d: Typo in documentation guide/upgrading
-
10:31 pm Bug Report #3636 (Closed): Incorrect doc comment in Validate::errors
- Fixed by https://github.com/kohana/core/commit/06f5a27c58fce60410d1698b59f55cb194769e3e
Documentation only, does n... -
10:30 pm Core Revision 06f5a27c: Fixed incomplete and incorrect doc comment for Validate::errors, fixes #3636
-
10:30 pm Bug Report #3636 (Closed): Incorrect doc comment in Validate::errors
- Andrew Hunt notified me that there is a rather misleading doc comment in Validate::errors.
> There is a slight bug... -
09:57 pm Bug Report #3634 (Assigned): Cannot set external request options
-
03:26 pm Image Feature Request #3563: static function valid() to validate image
- Hi.
Please consider to return TRUE by method Upload::image() if there was no file uploaded, cause now it returning F... -
11:58 am Feature Request #3635 (Closed): Checking if module is active
- @Kohana::modules@ should be able to check if the module is active....
-
01:24 am ORM Bug Report #3632 (Assigned): Wildcard filters should run first
- I agree, please do a pull request with this fix and it will get applied.
01/21/2011
-
10:18 pm Bug Report #3634 (Closed): Cannot set external request options
- In Kohana_Request_Client_External there is a property called $_options but no way to set that with any values.
https... -
10:12 pm Bug Report #3633 (Closed): Missing remote.php config for request
- This file is referenced here but does not exist:
https://github.com/kohana/core/blob/3.1%2Frelease%2F3.1.0/classes... -
10:07 pm Bug Report #3000: Config system rewrite
- No, I'm afraid not; 3.1 is feature complete - only bug fixes are being accepted now.
You can extract the changes f... -
09:11 pm Bug Report #3000: Config system rewrite
- Any chance of this feature making it's way in during a 3.1.x release? The application I'm build really needs this fea...
-
06:11 pm ORM Bug Report #3632 (Closed): Wildcard filters should run first
- Currently, wildcard filters are being appended to the array of filters for a field, but I think they should be run fi...
-
04:26 pm Feature Request #3631 (Closed): Response::bodyAppend()
- The standard way of adding content to the response body in 3.1 is with the Response::body() method. I think it would ...
-
03:42 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface
- Yeah, was not feeling 100% when writing that. Stepping away from keyboard until home. Thanks for fix Kiall.
-
03:25 pm Auth Bug Report #3630: coding standard violation: Variables should precede constants in comparison ope...
- For readability - that should probably be surrounded by brackets aswell.
Not sure what the CodingStyle says about ... -
03:22 pm Auth Bug Report #3630: coding standard violation: Variables should precede constants in comparison ope...
- https://github.com/kohana/auth/pull/8
Change should be applied to both 3.0 and 3.1 branches -
03:22 pm Auth Bug Report #3630 (Closed): coding standard violation: Variables should precede constants in compa...
- auth / classes / kohana / auth.php (line 151)...
-
02:58 pm Cache Bug Report #3629 (Closed): Cache_Apc::get() not using correct APC interface
- The APC driver does not handle retrieving values from cache correctly, allowing FALSE value to return the default val...
-
02:45 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface
- This is a candidate for 3.0
-
02:12 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface
- @Bence: I believe you're right, Sam's on holidays snowboarding .. he probably shouldn't be writing code ;)
Ill fix... -
01:46 pm Cache Bug Report #3627: Cache_Apc::get() not using correct APC interface
- this commit seems to be a bit strange for me..
@return $success ? $default : $data;@
wtf? I think it should be
@... -
01:27 pm Bug Report #3531: Response body should be converted into string only when output is generated
- Jeremy Bush wrote:
> We discussed this at great length, and decided it was best if it was converted to a string when... -
03:49 am Bug Report #3628 (Closed): 3.1RC2 - External POSTing Request, not sending post key/value pairs
- I have gone through the code for a few hours and to me (please correct me if I am wrong) it does not seem possible to...
-
01:01 am Cache Revision 9e7ae17f: Refs #3627. Fixed the APC interface to handle FALSE values correctly
-
12:52 am Cache Bug Report #3627 (Closed): Cache_Apc::get() not using correct APC interface
- The APC driver does not handle retrieving values from cache correctly, allowing FALSE value to return the default val...
01/20/2011
-
11:52 pm Feature Request #3341: Add before_$action and after_$action support to Request class.
- Can't you just put any code that you would put in before_$action or after_$action into the action itself. The only c...
-
08:13 pm Auth Feature Request #3295 (Closed): Model_Auth_User_Token::create_token() needs improvement
- Fixed by "9720af86d0...":https://github.com/kohana/orm/commit/9720af86d005d3590bb85f204e753cee520c4507
-
07:25 pm Auth Bug Report #3611 (Closed): Auth - The _now property does not exist in the Model_User_Toke
- Fixed by "9720af86...":https://github.com/kohana/orm/commit/9720af86d005d3590bb85f204e753cee520c4507
-
07:22 pm Auth Bug Report #3612 (Closed): ORM - unique_id doesn't exist.
- Thanks! Fixed by "1d70bde920...":https://github.com/kohana/orm/commit/1d70bde920dedaeddeba528ac0275415d834c112
-
07:21 pm ORM Revision 92100812: Merge branch '3.1/develop' of github.com:kohana/orm into 3.1/develop
-
07:20 pm ORM Revision 9720af86: Added token generation method, and make it check the database to enforce uniqu...
-
07:19 pm ORM Revision 1d70bde9: User agent should be hashed, fixes #3618
- Removed token generation, tokens are generated by the token model automatically (see #3295), fixes #3612
-
07:17 pm Auth Bug Report #3618 (Closed): ORM - _login() does not sha1 the user agent
- Fixed by "1d70bde9...":https://github.com/kohana/orm/commit/1d70bde920dedaeddeba528ac0275415d834c112
-
04:27 pm Patch #3626: Session pattern and configuration changes
- Thank you, not sure why Google didn't return that earlier. I think I've corrected them all now.
-
03:54 pm Patch #3626: Session pattern and configuration changes
- The "code style guide":http://kohanaframework.org/guide/kohana/conventions for 3.x is located in the userguide under ...
-
03:19 pm Patch #3626: Session pattern and configuration changes
- Now I have located the coding style guide (the only one I could locate was the one relating to v2). The code has been...
-
02:12 pm Patch #3626: Session pattern and configuration changes
- Also, your commit doesn't follow our coding standards. Please review them and update your code if it's going to be me...
-
02:11 pm Patch #3626: Session pattern and configuration changes
- The session class design has known problems, and was going to be reviewed for re-writing in 3.2. We'll keep this tick...
-
01:59 pm Patch #3626 (Assigned): Session pattern and configuration changes
- Note this patch has a pull request https://github.com/kohana/core/pull/68
This patch covers multiple Problems.
... -
12:15 pm Database Feature Request #3625 (New): Creating tables in database
- Is it possible to add new query type - creating tables in database.
Code e.g....
01/19/2011
-
06:57 pm ORM Bug Report #3624: ORM count_all() with $_load_with
- GitHub Pull Request: https://github.com/kohana/orm/pull/21
-
06:55 pm ORM Bug Report #3624 (Closed): ORM count_all() with $_load_with
- Currently, when you define $_load_with on an ORM model, and call count_all(), the models via $_load_with are not set....
-
06:20 pm Bug Report #3623 (Closed): Any reason why request->protocol() returns in uppercase?
- https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/request.php#L1132
Makes my Url::base(Request::$cu...
01/18/2011
-
08:38 pm Bug Report #3622 (Closed): whitespace rule for type casting is incorrect when tabs precede type
- A single line statement like so:...
-
08:03 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db
- Cool, I understand.
But let's say you create a new, empty user record, then pass it off to another library that has ... -
07:25 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db
- I will talk with other devs and see what they say, but I don't really see this as something that is important to chan...
-
06:44 pm Bug Report #3621 (New): no rule for hanging parentheses with arrays
- The proper way to do arrays is:...
-
05:59 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db
- What about the interrim fix for queueing add() on records not yet in the database? Because right now it just throws e...
-
04:11 pm ORM Bug Report #3619: Add() should be queued if the record isn't in the db
- This is how ORM worked in 2.x. I can see the advantages to having save() save the relationships instead of making the...
-
12:43 pm Image Feature Request #3563: static function valid() to validate image
- I know you guys work very hard for the new coming release of Kohana, but I don't believe 3.2 will be there after 6 mo...
-
11:36 am Image Feature Request #3563: static function valid() to validate image
- https://github.com/kohana/kohana/wiki/Kohana-Development-Procedures
It's our policy is to not introduce new features... -
10:53 am Feature Request #3617: Pagination module for 3.1?
- I'm replying from my phone .. so no code examples just now ;)
Re the bootstrap - I believe it has already been rem... -
10:50 am Feature Request #3617: Pagination module for 3.1?
- Sorry for posting here, but can you suggest the simpler way to do the pagination? Write everytime all the functions b...
-
10:42 am Image Feature Request #3563: static function valid() to validate image
- Kiall, I understand your point, and these reasons are really important (especially about bugs and documentation), but...
-
10:24 am Feature Request #3218: Database - add parameters to mysql_fetch_object in Database_Result
- If fixing a core bug breaks a 3rd party module, its up to the 3rd party developer to fox it!
I will mention it to ... -
10:20 am Feature Request #3617 (Closed): Pagination module for 3.1?
- The qpagination module has been removed from 3.1.
I believe this was because none of the dev's use it.. it is an ... -
10:14 am Feature Request #3620 (Closed): XSS Clean in 3.1
- Security::XSS_clean was a mess and a false sense of security. Use a more robust library such as HTML purifier.
Als... -
10:09 am Image Feature Request #3563: static function valid() to validate image
- Isaiah already mentioned one - not adding new features means not adding new bugs to delay release.
I'll give you th... -
09:52 am Feature Request #3620 (Closed): XSS Clean in 3.1
- What's happend to Security::xss_clean? There is any substitution for this?
-
09:44 am Image Feature Request #3563: static function valid() to validate image
- Isaiah, why non API-breaking feature can't be included in 3.1.x?
3.0.x has many features added in the middle (since 3... -
09:21 am ORM Bug Report #3619 (Assigned): Add() should be queued if the record isn't in the db
- You should be able to do the following when creating a new record:...
-
05:12 am Auth Bug Report #3618 (Assigned): ORM - _login() does not sha1 the user agent
-
04:26 am Auth Bug Report #3618 (Closed): ORM - _login() does not sha1 the user agent
- The user agent is not hashed here: https://github.com/kohana/orm/blob/3.1/develop/classes/kohana/auth/orm.php#L88
... -
03:00 am Feature Request #3218: Database - add parameters to mysql_fetch_object in Database_Result
- This broke compatibility with postgresql in the postgresql module maintained by cbandy/kohana-postgresql.
-
01:24 am Bug Report #3615: ternary rule incorrectly requires parentheses
- Here is another example to show that it is not just due to the PHP 5.3 implementation or the somewhat confusing conca...
-
01:19 am Image Feature Request #3563: static function valid() to validate image
- I don't think zombor meant to be funny. We have a feature-freeze before a release so we can get bugs squished and mak...
-
01:05 am Image Feature Request #3563: static function valid() to validate image
- i`m agree with Yahasana
this is not a breaking api feature, so, IMHO, it can be included into 3.1.1 -
12:32 am Image Feature Request #3563: static function valid() to validate image
- The schedule of 3.2 is long away from now. setting completed features to the future version is NOT funny.
01/17/2011
-
11:46 pm Feature Request #3617 (Closed): Pagination module for 3.1?
- Unfortunately haven't found the pagination module for KO3.1. Does it exist? I think it is very popular module and it ...
-
11:25 pm Feature Request #3616 (New): Fragment should use cache module if possible
- If the cache module is enabled, @Fragment@ should use it instead of the internal file cache. I also suggest config it...
-
11:24 pm Auth Bug Report #3611 (Assigned): Auth - The _now property does not exist in the Model_User_Toke
-
11:23 pm Auth Bug Report #3612 (Assigned): ORM - unique_id doesn't exist.
-
10:39 pm Bug Report #3615 (Closed): ternary rule incorrectly requires parentheses
- I have the following code:...
-
10:29 pm Bug Report #3614 (Closed): incorrectly throws an error when using closures
- If I have a closure like this:...
-
10:24 pm Bug Report #3613 (Closed): handle empty methods properly
- Currently something like this:...
-
10:21 pm Auth Bug Report #3612 (Closed): ORM - unique_id doesn't exist.
- https://github.com/kohana/orm/blob/3.1/develop/classes/kohana/auth/orm.php#L89
The correct function to use here wo... -
10:20 pm Auth Bug Report #3611 (Closed): Auth - The _now property does not exist in the Model_User_Toke
- https://github.com/kohana/orm/blob/3.1/develop/classes/model/auth/user/token.php#L25
Not sure what that line is fo... -
09:10 pm Image Feature Request #3563: static function valid() to validate image
- 3.1 is feature complete.
-
04:38 pm Core Revision f1acbe1e: Added Upload::image, allows checking that an upload is an image and (optionall...
-
04:33 pm Image Feature Request #3563 (Feedback): static function valid() to validate image
- Added @Upload::image@ in a separate branch, see https://github.com/kohana/core/compare/3.0/develop...feature/3563-ima...
-
02:39 pm Bug Report #3609 (Closed): Form::open() no longer handles NULL, breaks API
- This was an intended change. It probably would be better to remove the check for the Request object altogether, becau...
-
03:51 am Bug Report #3609 (Closed): Form::open() no longer handles NULL, breaks API
- ...
01/16/2011
-
04:19 pm Core Revision 773cf4f7: Merge branch '3.0/develop' of https://github.com/iammerrick/core into 3.0/develop
-
04:12 pm Bug Report #3589 (Closed): API Documentation Issue - Small text for Arr class.
- Fixed by https://github.com/kohana/core/commit/773cf4f746c8334f7df6f82005b9879664d910d1
-
01:42 pm Database Bug Report #3608 (Closed): Kohana_Database_MySQL::connect() problem
- both mysql_connect() and mysql_pconnect() (especially the latter - an example is the first comment on the PHP manual ...
-
08:47 am Revision 746de0a9: Adding MySQL test to install.php
-
08:44 am Revision 88157d69: Updating install.php to test for PECL http
-
08:06 am Revision e3c355d3: Fixed merge error in build.xml
-
07:55 am Revision 00b9055e: Merge branch '3.1/develop' into 3.1/release/3.1.0
- Conflicts:
build.xml
system -
07:52 am Core Revision 43974a1e: Merge branch '3.1/develop' into 3.1/release/3.1.0
-
07:50 am Revision 12f557ef: Updating submodules
-
07:49 am Core Revision 53b6cd69: Minor coding style cleanup
-
07:47 am UnitTest Revision 748b8d16: Minor coding style cleanup
-
07:44 am UnitTest Revision 30a85227: Fixing phpDoc @category
-
07:09 am Userguide Revision 90d16959: Fixing userguide to work with "un-clean" URLs (ie those with index.php in them)
-
06:54 am Core Revision 339f19ba: Updating the tests phpDoc.
-
04:26 am Bug Report #3538 (Closed): Validation changes ignores Geiger's context bit
- No problem Ben, glad that works for what you need :)
-
04:16 am Bug Report #3538: Validation changes ignores Geiger's context bit
- @Isaiah dude, I feel like an ass. Thanks for the clarification. Shoulda studied the source more carefully :). This is...
-
04:13 am Bug Report #3538 (Feedback): Validation changes ignores Geiger's context bit
- You can bind whatever parameters you want with the Validation::bind() method. E.g. if you want to be able to use :mod...
-
03:48 am Bug Report #3538: Validation changes ignores Geiger's context bit
- 3.1 has entered RC 2 - Any more changes have to wait 6 months for 3.2...
-
02:30 am Bug Report #3538: Validation changes ignores Geiger's context bit
- To clarify, I personally think this should be a 3.1 issue to make the validation class what it should be.
I don't ...
01/15/2011
-
11:09 pm Revision 419d2e92: Tracking 3.1.0-rc2 system
-
10:59 pm Core Revision 7a1a199e: Merge branch '3.1/develop' into 3.1/release/3.1.0
- Conflicts:
classes/kohana/request/client/internal.php -
10:42 pm Revision 78eeba6d: Updating system submodule.
-
10:41 pm Core Revision 2c43f9ae: Fixing minor HTML helper bugs and updating the tests.
-
10:08 pm Revision d5497543: Updating submodules
-
10:07 pm Userguide Revision b97c54eb: Updating userguide for 3.1 HTML helper changes
-
10:06 pm Core Revision 7bd187bb: Updating HTML helper for 3.1 URL::base() changes.
-
09:44 pm Revision f3045e2c: Updating submodules
-
09:40 pm ORM Revision 3e874f78: Fixes #3607 - Adding create_user() and update_user() methods to ORM's Auth_Use...
-
09:35 pm Auth Feature Request #3607 (Closed): Add create_user/update_user methods to the user model
-
09:32 pm Auth Feature Request #3607 (Closed): Add create_user/update_user methods to the user model
- We should have methods for creating/updating users in the user model that include the extra password validation that ...
-
07:11 pm Revision 1f381ae7: Updating ORM submodule
-
07:00 pm Bug Report #3606 (Closed): Kohana_View_Exception on main site
-
06:57 pm Bug Report #3606 (Closed): Kohana_View_Exception on main site
- http://kohanaframework.org/forum
I got "Kohana_View_Exception [ 0 ]: The requested view pages/blah could not be fo... -
06:45 pm ORM Revision 635b328a: Added the not_empty rule back to the user model. It's needed to make sure a mo...
-
06:35 pm Feature Request #3536: Remove controller method parameters
- Kiall Mac Innes wrote:
>
> I really can't see this as a feature worth having and can see users getting very confuse... -
05:47 pm Feature Request #3536: Remove controller method parameters
- Some more discussion of this started in the pull request for those who havn't seen it. https://github.com/kohana/core...
-
05:45 pm Revision 53e92ccd: Updating submodules.
-
05:38 pm Bug Report #3599 (Closed): Validation should _not_ modify data
- Fixed by "485de87...":https://github.com/kohana/core/commit/485de877b0770a59f84a94e406942986a4783f28
-
05:31 pm Bug Report #3602 (Closed): Passing objects as a Validation parameter will result in a fatal error
- Fixed by "beaf6f...":https://github.com/kohana/core/commit/beaf6fe9006e9fe45ba9861742f53208dce401d0
-
08:18 am Auth Bug Report #3605 (Closed): AUTH login hashes the password if passed as string
- Not all the drivers will require to have the password sent as hash for the _login abstract function.
For example, ... -
05:53 am Bug Report #3599: Validation should _not_ modify data
- I phrased it badly and us minions are not allowed to edit the original ticket. What I meant is that based on the plan...
-
04:26 am Bug Report #3599: Validation should _not_ modify data
- It's not a bug when you write code to intentionally do something.
-
12:48 am Core Revision 465527d3: Merge branch '3.1/develop' of github.com:kohana/core into 3.1/develop
-
12:45 am Core Revision f484a3ef: adding tests for #3599 and #3602
-
12:44 am Core Revision beaf6fe9: not allowing objects to be used in message strings (refs #3602)
-
12:43 am Core Revision ebf5690e: restoring the original data array after validation has run (refs #3599)
-
12:43 am Core Revision 485de877: making sure data is not removed from the object when validating (refs #3599)
-
12:29 am Bug Report #3599 (Assigned): Validation should _not_ modify data
-
12:29 am Bug Report #3602 (Assigned): Passing objects as a Validation parameter will result in a fatal error
01/14/2011
-
11:57 pm ORM Revision 4d3e929e: Clean up user model rules and filters. The password field should be validated ...
-
10:38 pm Auth Bug Report #3597 (Closed): Model_User::hash_password should not run on empty values.
- You should validate the password field outside of the model. The password is always a hash in the model, so rules lik...
-
10:32 pm Bug Report #3600 (Closed): Validation error/label breakage
-
10:23 pm Feature Request #3536: Remove controller method parameters
- My way: https://github.com/TdroL/kohana-params
IMO less "hardcore" than pull/67, with some flexibility. It extends Re... -
09:00 pm Bug Report #3604 (Assigned): Kohana_Session_Native should optionally Cookie Parameters when calli...
- The related bug causes ini session cookie settings to be ignored.
If I set my cookie domain in php.ini to '.domain... -
08:58 pm Feature Request #3536: Remove controller method parameters
- https://github.com/kohana/core/pull/67
Patch to assign action parameters by name, not by the order they were parse... -
08:31 pm Auth Feature Request #3541 (Closed): Update ORM driver and related models for new ORM version
-
08:27 pm Bug Report #3548 (Closed): cache_response() must be called from current Request object instead of...
- Looks like this was done to me?
-
06:58 pm Revision 096369c3: Switching submodules from git:// to http://
-
06:57 pm Revision 1a0a0b52: Switching submodules from git:// to http://
-
06:55 pm Revision 04b53775: Updating submodules
-
06:52 pm Revision c5a3e7f6: Updating submodules.
-
06:52 pm Patch #3603 (Closed): Docs and Downloads Updates
- Removed 2.4 from download, update links to 3.1 RC download, changed order and style of documentation to put more emph...
-
06:49 pm Core Revision c5c018c0: Merge Fixes #3601 - Tests fail when Kohana_Core has been extended in applicati...
-
06:30 pm Bug Report #3601 (Closed): debug path test fails if kohana class is overridden in the application
- Applied in changeset commit:"3599e7cd77f8cb73721c4b547885ee044d6a23cc".
-
06:27 pm Core Revision 3599e7cd: Fixes #3601 - Tests fail when Kohana_Core has been extended in application.
-
06:24 pm Bug Report #3601: debug path test fails if kohana class is overridden in the application
- Fixed in 3.1: https://github.com/kohana/core/commit/3599e7cd77f8cb73721c4b547885ee044d6a23cc
Fixed in 3.0: https://g... -
06:23 pm Core Revision c8c10189: Fixes #3601 - Tests fail when Kohana_Core has been extended in application.
-
06:03 pm Bug Report #3602 (Closed): Passing objects as a Validation parameter will result in a fatal error
- @->rule('field', 'matches', array(':validation', ':field', 'another'))@ will result in an exception because of a chec...
-
05:42 pm Bug Report #3601 (Closed): debug path test fails if kohana class is overridden in the application
- https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L320
We override the kohana class so t... -
05:11 pm Bug Report #3600 (Closed): Validation error/label breakage
- I've created a quick repository for this: https://github.com/ThePixelDeveloper/The-Kohana-Validation-is-Broke-Reposit...
-
04:25 pm Bug Report #3599 (Closed): Validation should _not_ modify data
- Now that Validation is only for validating data it shouldn't modify the array of data pass to it. All validation is d...
-
04:25 pm Bug Report #3598 (New): poor implementation of test_messages
- https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L151
This causes issues when the valid... -
04:12 pm Auth Bug Report #3597 (Closed): Model_User::hash_password should not run on empty values.
- @Model_User::hash_password@ processes all values at the minute. This causes an issue with ORM Validation because when...
-
03:18 pm Auth Bug Report #3579 (Closed): Sample schema is too "small" for a sha256
-
03:17 pm Bug Report #3549 (Closed): Request_Client::set_cache() uses undefined property Response::$header
-
03:17 pm Core Revision e1425a0d: Fixes #3596 - Typo in text_exception_handler
-
03:12 pm Bug Report #3596 (Closed): typo in test function name
-
03:06 pm Bug Report #3596 (Closed): typo in test function name
- https://github.com/kohana/core/blob/3.0%2Fdevelop/tests/kohana/CoreTest.php#L269
teste_exception_handler()
shou... -
03:03 pm Revision 4232b619: Updating submodules.
-
03:00 pm ORM Revision 19f1670f: Updating Model_Auth_User::filters() to the new 3.1 syntax.
-
02:59 pm Bug Report #3595 (Closed): Auth files duplicated in 2 official modules auth-driver-orm and orm.
- auth-driver-orm has been deleted.
-
02:39 pm Bug Report #3595 (Closed): Auth files duplicated in 2 official modules auth-driver-orm and orm.
- Didn't Auth ORM get split off into its own module: auth-driver-orm?
https://github.com/kohana/auth-driver-orm/tree... - 01:00 pm UnitTest Bug Report #3593 (Closed): Compatibility changes for 3.1
- Applied in changeset commit:"f23d61846c9df3d751e7e4d1608ecefd0ab549e0".
-
12:58 pm UnitTest Revision f23d6184: Fixing unittest controller for 3.1 fixes #3593
-
12:57 pm ORM Revision be5aabe4: Merge branch '3.1/feature/documentation' of https://github.com/Zeelot/kohana-o...
-
12:54 pm ORM Feature Request #3592 (Closed): Documentation Improvements
- Commit: https://github.com/kohana/orm/commit/be5aabe4431f57d08982595b21748d849ab7da9f
-
12:50 pm Userguide Revision da4edc6d: Fix 404's for 3.1 compatibility. Should this change to a 404 Exception? refs #...
-
12:48 pm ORM Bug Report #3591 (Closed): ORM::_validation() is not binding the model instance to :model
-
12:45 pm Userguide Bug Report #3594 (Feedback): 3.1 Userguide 404 handling
- In the 3.1 userguide, we are using @$this->response->status(404);@ as part of the @error()@ function .. should this m...
-
11:57 am UnitTest Bug Report #3593 (Closed): Compatibility changes for 3.1
- > https://github.com/kohana/unittest/blob/3.1/develop/classes/controller/unittest.php#L64
>
> The uri needs to be ... -
10:09 am ORM Revision 7a8e95ca: binding :model to the validation object (refs #3591)
-
10:04 am ORM Bug Report #3591: ORM::_validation() is not binding the model instance to :model
- https://github.com/kohana/orm/pull/19
-
09:58 am ORM Revision 818895f7: adding a section on ORM::rules() to the validation page
-
09:56 am ORM Feature Request #3592: Documentation Improvements
- https://github.com/kohana/orm/pull/18
-
09:54 am ORM Feature Request #3592 (Closed): Documentation Improvements
- I started by cherry-picking the commits that provided documentation for ORM 3.0.x into 3.1.x, fixed any differences, ...
-
09:52 am ORM Bug Report #3591 (Closed): ORM::_validation() is not binding the model instance to :model
- The same way :model is available to ORM filters, it should be available to rules().
-
09:14 am ORM Revision eb405253: adding documentation for ORM filters
-
08:58 am ORM Revision deb4d880: Adding a pretty complete example of validation
-
08:01 am ORM Revision 7eaf3162: tiny format change of the simple example header
-
07:58 am ORM Revision 0c095680: final touches on the ORM validation documentation
-
07:47 am ORM Revision d6d5bda5: creating the initial ORM validation documentation
-
07:07 am ORM Revision 3cdbd1e0: another minor typo
-
07:06 am ORM Revision 5d58b865: missed a documentation file (updating verbiage for 3.1.x)
-
07:05 am ORM Revision f86294a3: Updating the documentation for 3.1.x and cleaning up any minor grammar mistakes
-
06:06 am ORM Revision 6d5c3d60: removing ORM::count_last_query() (refs #3590)
-
06:03 am ORM Revision 8d266bfb: adding an ORM::$_db_group property to clean up some code (refs #3588)
-
06:02 am Core Revision 91e4ab12: Updated to comment for Arr::unshift, addresses issue #3589
-
05:59 am ORM Bug Report #3590 (Closed): Remove count_last_query()
- Fixed by "6d5c3d...":https://github.com/kohana/orm/commit/6d5c3d60e537a2ec3506778d9763f14bc71f0e28
-
05:56 am ORM Bug Report #3588 (Closed): ORM::$_db should not be used as a string and object property
- Fixed by "8d266bfbdbf...":https://github.com/kohana/orm/commit/8d266bfbdbffc775e0185b2dc6d1bef71c70e83b
-
05:56 am ORM Bug Report #3590 (Closed): Remove count_last_query()
- count_last_query() was removed from Database because of security risks. It needs to be removed from ORM as well.
-
05:54 am Bug Report #3589 (Closed): API Documentation Issue - Small text for Arr class.
- The Arr::unshift() method has a comment that is referencing an old function and it is being pulled into the API brows...
-
05:45 am ORM Bug Report #3588 (Closed): ORM::$_db should not be used as a string and object property
- @ORM::$_db@ should default to NULL and hold the database object, @ORM::$_db_group@ should be the string that holds th...
-
05:30 am Bug Report #3556 (Closed): Validation callbacks should run on empty fields
- Applied in changeset commit:"5de93c0ee108cd58e38c67719fc7cdd4906c80ef".
-
05:27 am Core Revision 5de93c0e: Always run rules on empty fields. Fixes #3556
-
05:21 am ORM Revision d0a41f1d: updating copyright year
- 05:20 am ORM Revision f860bdd3: Fixed typo. `modle` to `model`.
- 05:20 am ORM Revision 190c186b: Renamed `author` foreign keys to `author_id`.
- In my experience, you will end up with a bit of collision issues when having an alias with the same name as a column/...
-
05:20 am ORM Revision 34bc39a6: adding a delete example
-
05:19 am ORM Revision fdd0b094: Fix menu to show the simple example
-
05:19 am ORM Revision 4b0ce9a3: And I forgot to save a file :/
-
05:19 am ORM Revision 5970a1bb: Renamed some files and rerranged some stuff
-
05:19 am ORM Revision 41679e16: ORM quick introduction
-
05:19 am ORM Revision 90b34ad2: added a base for Using ORM
-
05:18 am ORM Revision 9134154b: Adding docs for relationships. Started with jheathco's documetation as a base
-
05:18 am ORM Revision f83c9a23: ORM introduction
-
05:18 am ORM Revision ef73ddd7: Added userguide stbs
-
04:57 am Bug Report #3580: No way to get the current route from a Request instance
- Steven G. wrote:
> Also, unless I'm mistaken, isn't this what you wanted?
That won't work in Kohana 3.1, the route i... -
04:55 am ORM Revision b717bb70: Fixed the recursive generate_errors() method for orm validation exceptions, fi...
-
04:53 am ORM Revision 77f112fa: Updated ORM for new filters syntax (now works the same as validation rules). F...
-
04:50 am ORM Bug Report #3585 (Closed): Filters need to be adapted to the Validation syntax
- Fixed by "77f112fa0...":https://github.com/kohana/orm/commit/77f112fa04923d33e55c42a0b07269574230712f
-
04:50 am ORM Bug Report #3586 (Closed): The validation exception does not properly namespace errors
- Fixed by "b717bb7033...":https://github.com/kohana/orm/commit/b717bb7033acb720b4fa71407d796da3b38fe2c6
-
03:48 am ORM Bug Report #3587: ORM and sqlite virtual tables not accessed properly breaking object
- sample code to replicate
virtual tables have a pk called rowid
sqlite3
create virtual table foo using fts3 (txt)... -
03:41 am ORM Bug Report #3587 (Review): ORM and sqlite virtual tables not accessed properly breaking object
-
03:39 am ORM Bug Report #3587: ORM and sqlite virtual tables not accessed properly breaking object
- This seems to be an issue for any ORM model that uses a custom PK name other than 'id'; The PK isn't returned with th...
-
03:21 am ORM Bug Report #3587 (Closed): ORM and sqlite virtual tables not accessed properly breaking object
- sqlite has virtual tables which can be used for (amongst other things) powerful full text searches. virtual tables ar...
-
02:52 am ORM Bug Report #3585 (Assigned): Filters need to be adapted to the Validation syntax
-
01:40 am ORM Bug Report #3586 (Closed): The validation exception does not properly namespace errors
- @$e->errors('directory');@ is completely broken at the moment. Seems some code refactoring broke the feature.
Give...
01/13/2011
-
06:03 pm ORM Bug Report #3585 (Closed): Filters need to be adapted to the Validation syntax
- filters() should return an array in the same syntax as rules()...
-
04:14 pm Image Feature Request #3584 (Closed): Method resize with argument Image::PRECISE
- Hi, I wrote a patch extension method "resize".
Optional argument to resize Image::PRECISE allows you to create pre... -
02:40 pm Bug Report #3583 (Closed): Inconsistent returning of array of found files in Kohana::Find_File wh...
- When trying to find an array of files using Kohana::Find_File() with caching enabled, the cache only accounts for the...
-
06:22 am Revision 9af92251: Removed oauth and pagination from .gitmodules-dev
-
05:58 am Revision 96f2f5f5: Updating submodules
-
05:33 am Core Revision 7fe67398: Fixed coding style issues in tests
-
05:05 am Revision 748ee228: Removed oauth and pagination modules from build.xml and bootstrap.php refs 8bf...
-
04:58 am Core Revision 39082158: Code cleanup and fixed failing request unit test.
-
01:58 am Bug Report #3582 (Closed): Second code example on Arr::is_assoc() doesn't do what it says
- The code example says the following will return FASLE:...
01/12/2011
-
07:57 pm Auth Bug Report #3574 (Closed): Declaration of Kohana_Auth_ORM::get_user() should be compatible with t...
- Fixed by "4e671485...":https://github.com/kohana/orm/commit/4e671485b1aed792735105a49acf900793b19e47
-
07:57 pm Core Revision 5a2e9ea1: Updated copyright dates and some comments relating to $this->request->response...
-
07:54 pm Patch #3533 (Closed): Comments and core guide changes for 3.1.0
- Thanks Joel!
Fixed by "5a2e9ea193e...":https://github.com/kohana/core/commit/5a2e9ea193e082d2e8c4ac8f3852a122fced... -
07:36 pm Revision cd95db7f: Updating system
-
07:33 pm Core Revision fe6873b5: Merge branch '3.1/develop' of github.com:kohana/core into 3.1/develop
-
07:31 pm Core Revision ed004fbd: Fixed controller.php phpDoc comments. Fixes #3578
-
07:29 pm Bug Report #3578 (Closed): Incorrect phpDoc comment in controller.php
- Fixed by "ed004fbdb...":https://github.com/kohana/core/commit/ed004fbdb9ad3481e3ba52b2402e1f02f151b3fe
-
06:51 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Please keep this discussion on topic.
-
06:28 pm Core Revision 6a3a6275: Refs #3551, removed the incorrect variable - damn over coffee brain
-
06:24 pm Bug Report #3551: Error with cookies in Response::send_headers()
- The reason for while/each in this instance is because each() produces such a horrible interface for the foreach loop....
-
06:15 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Isaiah DeRose-Wilson wrote:
> Jeremy Bush wrote:
> > list/while is faster than foreach().
>
> Actually I don't t... -
05:52 pm Bug Report #3551: Error with cookies in Response::send_headers()
- I agree with Isaiah. IMO code readability is more important than speed (futhermore when spped gain is doubtful), so I...
-
05:49 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Sorry, I didn't mean faster. it uses less memory in some situations where a foreach() would consume more memory and n...
-
05:43 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Jeremy Bush wrote:
> list/while is faster than foreach().
Actually I don't think that's true. I haven't benchmarked ... -
05:27 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Probably :)
-
05:06 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Jeremy, I see, thanks for the reply.
Nevertheless ... -
04:54 pm Bug Report #3551: Error with cookies in Response::send_headers()
- list/while is faster than foreach().
-
04:52 pm Patch #3581 (Closed): URL::base() port patch
- What Kohana version are you using? This was fixed a few versions back. See #3307
-
04:38 pm Bug Report #3551: Error with cookies in Response::send_headers()
- Sam, what is @$fruit@ here?
https://github.com/kohana/core/blob/705d5fc5d95af4ce466dc37f46d5ec902a18c4b4/classes/koh... -
04:37 pm Core Revision 8bb1ea4a: Refs #3548, fixes the request client to use correct method on itself, rather t...
-
04:33 pm Core Revision 6a00a465: Refs #3549, fixes the incorrect referencing of member properties and methods
-
04:31 pm Core Revision b1979c73: Refs #3550, fixes the profiler issue where the current request would be posted...
-
04:28 pm Core Revision 705d5fc5: Refs #3551, fixes the cookie interface in Response to use compatible interface...
-
04:22 pm Bug Report #3551 (Needs Test): Error with cookies in Response::send_headers()
- Fixed in https://github.com/kohana/core/commit/705d5fc5d95af4ce466dc37f46d5ec902a18c4b4
-
03:37 pm Image Feature Request #3563: static function valid() to validate image
- Hello.
Futher development lead me to upgrade method to make it compatible with rules in Validate routine. Code:
<pr... -
02:22 pm Revision 2f59d5a1: Update submodule
- 02:15 pm Database Bug Report #3569 (Closed): Database subquery can't support aliases
- Applied in changeset commit:"bd29aba3dd9a7f6dbc682558f5de5911f224f72f".
- 02:10 pm Database Revision bd29aba3: Allow aliases on expressions and queries in quote_* methods. Fixes #3569
-
01:10 pm Userguide Revision 818a5797: Even more 3.1 fixes..
-
09:25 am Patch #3581 (Closed): URL::base() port patch
- On my staging server I have to use non-standard port 8181. When I upload new kohana project to this server I found th...
-
08:28 am Bug Report #3580: No way to get the current route from a Request instance
- Kiall Mac Innes wrote:
> Applied in changeset commit:"cc3e043d8181cf326e2bcae9bdcccf9bc3403aa8".
I get "No input ... -
05:57 am Userguide Revision c01e82c6: More 3.1 Fixes..
-
05:23 am Revision a2577255: Updating submodules
-
05:21 am Core Revision cc3e043d: Fixes #3580 - No way to get the current route from a Request instance
-
05:15 am Bug Report #3580 (Closed): No way to get the current route from a Request instance
- Applied in changeset commit:"cc3e043d8181cf326e2bcae9bdcccf9bc3403aa8".
-
05:08 am Bug Report #3580 (Closed): No way to get the current route from a Request instance
- There is currently no way to get the current route from a Request instance.. This is actually needed by the userguide...
-
04:32 am Core Revision 8fdf71cb: Fix a minor phpDoc issue.
-
04:30 am ORM Revision 1eee5868: Fixes #3579 - Sample schema is too "small" for a sha256
-
04:27 am ORM Revision 4e671485: Fixes #3574 - Declaration of Kohana_Auth_ORM::get_user() should be compatible ...
-
04:23 am Auth Bug Report #3579 (Closed): Sample schema is too "small" for a sha256
- Sample schema is too "small" for a sha256..
-
03:42 am ORM Revision b4978dbd: Moving Auth ORM driver from its own repo to the ORM module for consistency wit...
-
03:37 am Userguide Revision 4356d8d3: Fixing 3.1 some compatibility issues.
01/11/2011
-
10:49 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes
- Jeremy Bush wrote:
> The answer is to not use any php in the error views, I think.
You can't avoid not using any ... -
09:46 pm Feature Request #2113: Kohana::message() & I18n
- I think what I'm trying to articulate is that the tight coupling of translation strings to Kohana::message value in f...
-
09:22 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes
- The answer is to not use any php in the error views, I think.
-
09:18 pm Bug Report #3566: Kohana environment constants and custom environments
- Decision made.
-
09:17 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes
- Steven G. wrote:
>
> Is there a problem with just using Kohana_* classes
Yes, we only use the extended classes.... -
08:43 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes
- Jeremy Bush wrote:
> The problem is in the autoloader, which I though was fixed by http://dev.kohanaframework.org/is... -
07:16 pm Bug Report #3577: system/view/kohana/error.php should not be dependent on other classes
- The problem is in the autoloader, which I though was fixed by http://dev.kohanaframework.org/issues/3327 in 3.0.9.
-
07:07 pm Bug Report #3578 (Closed): Incorrect phpDoc comment in controller.php
- https://github.com/kohana/core/blob/3.1%2Fdevelop/classes/kohana/controller.php#L31
Correct comment would be:
<... -
07:04 pm Bug Report #3577 (New): system/view/kohana/error.php should not be dependent on other classes
- I don't believe dependencies to the class Kohana are a problem. But dependencies to something like HTML which is also...
-
06:06 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- Also we do have "docs that explain":http://kohanaframework.org/guide/kohana/conventions#type-casting this stuff ;)
-
06:01 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- Dmitry T. wrote:
> what about @foo( (int) $bar);@ or @foo((int) $bar)@ or @foo((int)$bar)@?
> I haven't found anyth... -
05:15 pm Revision 81420023: Merge branch '3.0/hotfix/3.0.9.buildfix' into 3.0/master
-
05:15 pm Revision 2b2ff325: Adding proper build file for ci
-
05:11 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- what about @foo( (int) $bar);@ or @foo((int) $bar)@ or @foo((int)$bar)@?
I haven't found anything about it in coding... -
03:54 pm Core Revision 7c909d75: Debug methods were moved to separate class refs #2682
-
03:50 pm Userguide Revision c261d04a: Debug methods were moved to separate class refs #2682
-
03:49 pm Image Revision 697c9862: Debug methods were moved to separate class refs #2682
-
03:45 pm Bug Report #3575 (Closed): Coding-Standards: The & sign in function for refrences throws Paranthe...
- What isn't clear? It says: "A single space is required on either side of ! and & operators" They are still operators ...
-
03:38 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- ok. i could not find a clear statement to that point. So i might be wrong with this.
-
03:28 pm Auth Bug Report #3574 (Assigned): Declaration of Kohana_Auth_ORM::get_user() should be compatible with...
-
03:09 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- Yes we do require a space, it should be function foo( & $bar)
-
02:48 pm Bug Report #3575: Coding-Standards: The & sign in function for refrences throws ParantheseSniff e...
- I'm not sure that we don't want a space there.
-
02:17 pm Bug Report #3575 (Closed): Coding-Standards: The & sign in function for refrences throws Paranthe...
- Don't know it this was submitted before:
The message "A single space is required on either side of ! and & operato... -
02:16 pm Feature Request #2113: Kohana::message() & I18n
- I don't think anything like this is on our radar. I've always maintained that our i18n class is meant to be a simple ...
-
12:26 pm Feature Request #2113 (Feedback): Kohana::message() & I18n
- I appreciate this has already been considered and closed, but there have been two forum threads in recent weeks with ...
-
01:14 am Bug Report #3572 (Closed): Protocol-less URIs
- I'm fine with the reasons provided in the duplicated issue.
01/10/2011
- 11:32 pm Image Revision bc718df7: Merge branch '3.0/master' of https://github.com/awellis/image into 3.0/develop
-
11:28 pm Auth Bug Report #3574 (Closed): Declaration of Kohana_Auth_ORM::get_user() should be compatible with t...
- Simple warning:...
-
11:03 pm Image Revision 1f545cb8: Fixed a couple spelling mistakes in the PHPDoc.
-
10:05 pm Bug Report #3572: Protocol-less URIs
- We talked about this before and decided it wasn't a good idea. See the related issue.
-
06:29 pm Bug Report #3572: Protocol-less URIs
- Sure, we do that too. We have dedicated url methods that give us just the domain base, without the url base from kohana.
-
05:58 pm Cache Bug Report #3573 (Assigned): Cache_MemcacheTag::set_with_tags() does not sanitize ID
-
05:48 pm Bug Report #3572: Protocol-less URIs
- Jeremy Bush wrote:
> You shouldn't be using absolute urls like that. It adds the base onto it so that you have porta... -
05:31 pm Cache Bug Report #3573 (Closed): Cache_MemcacheTag::set_with_tags() does not sanitize ID
- @set_with_tags()@ does not sanitize the ID value when calling @add_tag()@ to associate each tag with the ID. This ca...
-
04:49 pm Bug Report #3572: Protocol-less URIs
- Luke Morton wrote:
> On a side note, why do absolute URIs still get the base appended to them? I.e. "/js/script.js" ... -
04:29 pm Bug Report #3565: Kohana environment consideration
- Or ... ...
-
04:20 pm Bug Report #3572 (Closed): Protocol-less URIs
- URIs can in fact be protocol-less, that is "//ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js" is a valid re...
-
04:17 pm Database Bug Report #3569: Database subquery can't support aliases
- Assigned to Chris, since it was his commit that broke this functionality.
-
04:16 pm Database Bug Report #3569: Database subquery can't support aliases
- Running @git diff 3.0/develop:classes/kohana/database.php 3.1/develop:classes/kohana/database.php@ produces the follo...
-
04:15 pm Revision 74094aa3: Fixes #3565 - Allow KOHANA_ENV to be specified as a string rather than an int.
-
04:15 pm Bug Report #3565 (Closed): Kohana environment consideration
- Applied in changeset commit:"74094aa3af0c17d33522165448fb7a28cbf9a543".
-
04:14 pm Revision a17ba697: Tracking submodules
- 04:12 pm Userguide Revision 0a2a3cdf: Merge branch '3.0/develop' into 3.1/develop
- Conflicts:
classes/controller/userguide.php
classes/kohana/kodoc/property.php
guide/about.flow.md
guide/about.ins... -
04:07 pm Database Bug Report #3569: Database subquery can't support aliases
- The problem commit is here "e8b3053e...":https://github.com/kohana/database/commit/e8b3053e955cd74eee9754636c5e81ff13...
- 04:06 pm OAuth Revision bc79b8aa: Merge branch '3.0/develop' into 3.1/develop
- 04:05 pm Database Revision 6176469d: Merge branch '3.0/develop' into 3.1/develop
- Conflicts:
classes/kohana/database.php
classes/kohana/database/query/builder.php - 04:00 pm Cache Revision ef8656e5: Merge branch '3.0/develop' into 3.1/develop
- 03:55 pm Image Revision 1b5fb0f4: Merge branch '3.0/develop' into 3.1/develop
-
03:51 pm Image Bug Report #3571 (Closed): property declaration is absent
- Fixed by https://github.com/kohana/image/commit/1b5fb0f4fd4a93742d30fe08095e8248738fbcf2
-
03:49 pm Image Bug Report #3571 (Assigned): property declaration is absent
-
03:48 pm Image Bug Report #3571 (Closed): property declaration is absent
- Hello.
line 110 in file MODPATH."image\classes\kohana\image.php":... - 03:41 pm Image Revision c1c79f84: Declaring Image::$mime before using it, fixes #3561
-
03:39 pm Database Bug Report #3569: Database subquery can't support aliases
- Only 3.1, I have word from BRMatt this problem doesn't exist in 3.0.x
-
03:37 pm Database Bug Report #3569: Database subquery can't support aliases
- Does this appear in 3.0.x or only 3.1.x?
-
03:36 pm Database Bug Report #3569: Database subquery can't support aliases
- The expected output is:...
-
03:34 pm Image Bug Report #3561 (Closed): property declaration is absent
- Fixed by https://github.com/kohana/image/commit/c1c79f84fd04c1b2aacca6c65780a98b72e687fa
-
03:32 pm Database Bug Report #3569: Database subquery can't support aliases
- I don't understand what you are getting at. What's what's expected and actual output?
-
03:25 pm Database Bug Report #3569 (Closed): Database subquery can't support aliases
- ...
-
03:06 pm Bug Report #3565: Kohana environment consideration
- Right so ... swapping the bootstrap.php to this in 3.1.0 has been decided on .....
-
02:50 pm Image Feature Request #3568: allow to save image without extension
- Chris Smith wrote:
> Further to this you can't actually save an image without an extension.
The report points tha... -
02:47 pm Image Feature Request #3568: allow to save image without extension
- I had a look at the code and it would appear that the following code throws an exception:...
-
02:25 pm Image Feature Request #3568: allow to save image without extension
- As you wish =) I`m already using this fix by overloading Image_GD class.
-
02:23 pm Image Feature Request #3568: allow to save image without extension
- This is a behavior change.
-
02:20 pm Bug Report #3565: Kohana environment consideration
- I've always erred on the side of "let the developer decide how to implement environments". I'd rather have a very sim...
-
02:17 pm Patch #3567: Kohana outputs HTML on CLI
- This should be handled all at once with the two related issues.
-
12:56 pm Image Feature Request #3568 (Closed): allow to save image without extension
- Hello.
Method @_do_save()@ in class Kohana_Image_GD call`s ("classes/kohana/image/gd.php:478":https://github.com/koh... -
10:31 am Bug Report #3401: Set Request::$client_ip from HTTP headers only if a trusted proxy set the header.
- Ignoring the issue of whether we trust REMOTE_ADDR for a while; I'd propose a whitelist mechanism, to allow chains of...
-
10:28 am Image Bug Report #3561: property declaration is absent
- @Isaiah "classes/kohana/image.php:110":https://github.com/kohana/image/blob/3.0%2Fmaster/classes/kohana/image.php#L11...
-
10:22 am Bug Report #3565 (Assigned): Kohana environment consideration
- @Chris Smith - heh .. I guess you use constants more often than the rest of us ;)
@Jeremy - I'll give you a shout on... -
10:17 am Bug Report #3565: Kohana environment consideration
- Err use reflection or constant() to see if that constant exists?
-
08:04 am Image Bug Report #3561: property declaration is absent
- Issue with IDE and auto-completion feature :)
And it is a good tone to declare public properties :)
Can you change ... -
05:40 am Bug Report #3566 (Assigned): Kohana environment constants and custom environments
-
04:23 am Bug Report #3566: Kohana environment constants and custom environments
- I think we need to focus on essential changes in 3.1.0 only. I'm bumping this to 3.1.1 and we can decide later if thi...
-
04:03 am Patch #3567 (Closed): Kohana outputs HTML on CLI
- If you run into an exception while using the CLI you'll get all the HTML output. I've attached a patch to suppress th...
-
02:01 am Bug Report #3565: Kohana environment consideration
- Kiall Mac Innes wrote:
> Jeremy - would that (translation in bootstrap) be considered an API change? If it is ... Le... -
01:59 am Bug Report #3565: Kohana environment consideration
- A translation in the bootstrap may be the best option. Using an array like that is pretty crap ;)
Jeremy - would t... -
01:52 am Bug Report #3565: Kohana environment consideration
- We aren't going to change the api of 3.1 unless something really needs changing.
-
01:47 am Bug Report #3565: Kohana environment consideration
- 2 options I can think of.
Ditch the constants and use the array. I'm not that'd make people very happy though.
@Koh... -
01:42 am Bug Report #3565: Kohana environment consideration
- Having a way to specify the environment using a string outside of Kohana would be great, But a lookup table means def...
-
01:38 am Bug Report #3566 (Closed): Kohana environment constants and custom environments
- The current 3.1 environment constants do not allow custom environments to be inserted between the defaults.
I sugg... -
01:23 am Image Bug Report #3561: property declaration is absent
- What is the issue you are having? Yes the Image class is abstract, you never create an instance of the Image class......
-
01:05 am Bug Report #3565 (Feedback): Kohana environment consideration
-
12:10 am Bug Report #3565 (Closed): Kohana environment consideration
- In 3.1 I've noticed you've switched over to using integers for the different environments. While this means you can d...
01/09/2011
-
11:00 pm ORM Bug Report #3564 (Closed): ORM lazy loading issue
- i downloaded fresh kohana 3.0.9
there is such issue.
[code]
$user = ORM::factory('user',$realid);
if(Arr... -
08:43 pm Bug Report #3562: Validate library - bug when using ->rule/filter(TRUE, 'some_rule');
- Aha, ok than. If expected then I will adjust :)
-
08:42 pm Bug Report #3562: Validate library - bug when using ->rule/filter(TRUE, 'some_rule');
- Version 3.0.8
-
08:33 pm ORM Feature Request #3559: Overloading ORM::factory
- I just want to remake model basing on some condition. Anyway when I'm creating Test object with given ID all in all i...
-
08:32 pm Bug Report #3562 (Closed): Validate library - bug when using ->rule/filter(TRUE, 'some_rule');
- This is expected behavior.
-
08:26 pm Image Feature Request #3563 (Closed): static function valid() to validate image
- Hello.
Alternative to Upload::valid($file) i suggest to add function Image::valid($file)... -
08:21 pm Bug Report #3562 (Closed): Validate library - bug when using ->rule/filter(TRUE, 'some_rule');
- Hi there.
My rules are like that:... -
08:04 pm Image Bug Report #3561 (Closed): property declaration is absent
- Hello.
line 110 in file MODPATH."image\classes\kohana\image.php":... -
06:17 pm ORM Feature Request #3559 (Feedback): Overloading ORM::factory
- I don't think this is a good idea. Your example is getting close to abusing the factory pattern, I don't really think...
-
06:08 pm ORM Feature Request #3560 (Closed): function set() in ORM class
- It is already included in 3.1. We are trying to limit changes to minor versions to bug fixes only so this won't be ad...
-
05:30 pm ORM Feature Request #3560 (Closed): function set() in ORM class
- Hello.
Please consider to add a new function set() into ORM class... -
12:41 pm ORM Feature Request #3559: Overloading ORM::factory
- I think one and only disadvantage is that ORM::factory will be runned 2 times while checking existing factory method...
-
12:38 pm ORM Feature Request #3559: Overloading ORM::factory
- Example of using:...
-
12:36 pm ORM Feature Request #3559 (Closed): Overloading ORM::factory
- All structure in Kohana core are using ORM::factory to create valid ORM object. But there is no way to overload facto...
01/08/2011
-
06:14 pm Bug Report #3505: Adjust the way default qualities are assigned to mime-types in Request::_parse_...
- As promised I have had a stab at coding a suitable replacement.
Rather than attempt to take on the nightmare of wh... -
11:46 am Bug Report #3558 (Closed): Request::$client_ip retuns a list of addresses
- X-Forwarded-For can contain multiple IPs acording to http://wiki.squid-cache.org/SquidFaq/ConfiguringSquid#What_is_.2...
Also available in: Atom