Kohana v3.x - Activity - Kohana Development

Activity

From 05/27/2011 to 06/25/2011

06/25/2011

10:45 pm Feature Request #3536: Remove controller method parameters: I would rather see this removed in 3.2.0 as well. We should all be using $this->request->param() Lorenzo Pisani
04:43 pm Core Revision d88db1c4: Add ability for Route::defaults() to act as a getter, Fixes #3974: Jeremy Bush
04:37 pm Feature Request #3974 (Closed): Add a way to get protected property Route::$_defaults: Fixed and tested by d88db1c. Jeremy Bush
04:34 pm Core Revision 96847162: Add stack trace logging by default to all exceptions, Fixes #3440: Jeremy Bush
04:32 pm Feature Request #3796: Allow aliases in callbacks: The description had $_rules, it sure looked like an ORM change :( Jeremy Bush
04:30 pm Bug Report #3690: Request::uri() should return the actual URI: If you want to do that, you can use $this->request->route->uri(). Jeremy Bush
04:28 pm Feature Request #3440 (Closed): Log stracktraces by default: Fixed by 9684716. Jeremy Bush
04:15 pm Core Revision 282cc243: Merge 39431549a30f4068b777462210ad47bb263429c6 into 9a53f22cfa32624d54bb414c98...: GitHub Merge Button
04:02 pm Core Revision aceeed6b: Remove port from valid emails, Fixes #3427: Jeremy Bush
03:56 pm Bug Report #3427 (Closed): Pointless port part in the email validator: Fixed and tested in aceeed6. Jeremy Bush
02:47 pm Feature Request #3796: Allow aliases in callbacks: This is a validation change... why did it move to orm? Lorenzo Pisani
01:41 am Feature Request #4064: Valid min/max value: How about an $inclusive parameter for the 'or equals' parts? Lorenzo Pisani

06/24/2011

11:13 pm Feature Request #4064: Valid min/max value: Hmm. Perhaps "less/greater than" are better...
Since negation isn't easy in Validation, we may want "less/greater ... Chris Bandy
11:06 pm Feature Request #4064 (New): Valid min/max value: Identical to min/max length methods, but compare values rather than lengths.
Similar to range but definitely diffe... Chris Bandy
11:00 pm Bug Report #3849: Failed 3 tests in Kohana_NumTest::test_format: I find the solution to fix my problem in the apache running unittest. It's simple, this problem will apears on Ubuntu... Gabriel Reitz Giannattasio
10:49 pm Bug Report #3849: Failed 3 tests in Kohana_NumTest::test_format: I'm with the same problem, but not in CLI mode, my LC_ALL is en_US.UTF-8 but when apache run the tests, it fails.
... Gabriel Reitz Giannattasio
01:42 pm Bug Report #4063 (Closed): error: use "Arr:path" to get a value from database object result: Jeremy Bush
12:53 pm Core Revision 06ff764c: Merge 64cab7e15274b3e254eddac10ecc68832f546961 into a7658e5d24f6e48fcb8f13749a...: GitHub Merge Button
05:51 am Core Revision 881803a3: Adding some extra Valid tests: Lorenzo Pisani
05:41 am Core Revision 62b73c3e: updating a docblock.: Lorenzo Pisani
05:36 am Core Revision 09782587: Making the ArrayAccess methods in Validation read-only (refs #4034): Lorenzo Pisani
05:31 am Core Revision 6f9ed0df: Adding tests for Validation's implementation of ArrayAccess (refs #4034): Lorenzo Pisani
04:51 am Core Revision a4d2c441: Valid::email_domain() doesn't need to run checkdnsrr() on empty fields (refs #...: Lorenzo Pisani
04:48 am Core Revision 6fc01414: adjusting the Valid tests on empty fields (refs #3552): Lorenzo Pisani
04:47 am Core Revision 55c10308: Revert "removing Validation::$_empty_rules(refs #3552)": This reverts commit a294de50d4f46b66eab7a96f561dd8f39f2bc9e1. Lorenzo Pisani
04:45 am Core Revision 84330d5a: Revert "removing _empty_rules from validation tests (refs #3552)": This reverts commit d0e5bcd36161d214965d4c45a569078fd6606bec. Lorenzo Pisani
04:34 am Core Revision b789a719: Revert "adjusting the valid methods to pass the new tests (refs #3552)": This reverts commit 3760e1d717ec162590ec54dfa9f03fbb1d9b4090.
Conflicts:
classes/kohana/valid.php Lorenzo Pisani
04:18 am Bug Report #3552: Validation needs a better way to specify '_empty_rules': So after some more talking on IRC, we decided to keep the current _empty_rules property for 3.2.0. We will discuss wh... Lorenzo Pisani
04:05 am Bug Report #4063: error: use "Arr:path" to get a value from database object result: I'm sorry， is not bug 宗鑫朱
03:58 am Bug Report #4063 (Closed): error: use "Arr:path" to get a value from database object result: change file "system/class/kohana/arr.php" line 154:
return $array[$key];
to:
return is_object($array) ? $arr... 宗鑫朱

06/23/2011

08:11 am Core Revision 7ba33479: Adding another test for Valid::exact_length(): Lorenzo Pisani
08:10 am Core Revision 6a09d33f: testing new Valid::exact_length() format (refs #3424): Lorenzo Pisani
08:10 am Feature Request #3424: Validate exact_length should accept an array of possible lengths: https://github.com/kohana/core/pull/136 Lorenzo Pisani
08:10 am Bug Report #3552: Validation needs a better way to specify '_empty_rules': https://github.com/kohana/core/pull/136 Lorenzo Pisani
08:10 am Core Revision d8179fd6: Allowing Valid::exact_length() to validate an array of lengths (refs #3424): Lorenzo Pisani
08:09 am Bug Report #4034: Validation does not need to extend ArrayObject any more: https://github.com/kohana/core/pull/136 Lorenzo Pisani
08:09 am Feature Request #4062: Add Validation::data(), :data, deprecate Validation::as_array(): https://github.com/kohana/core/pull/136 Lorenzo Pisani
08:01 am Core Revision 71a3b58f: adding tests for Validation::data() and Validation::as_array() (refs #4062): Lorenzo Pisani
07:57 am Core Revision 4472455f: updating tests to use non-deprecated Validation::data() (refs #4062): Lorenzo Pisani
07:52 am Core Revision d50cb876: adding :data bound value (refs #4062): Lorenzo Pisani
07:50 am Core Revision 33c92ccf: added Validation::data() deprecated Validation::as_array() (refs #4062): Lorenzo Pisani
07:42 am Core Revision ff33edfa: implementing ArrayAccess instead of extending ArrayObject (refs #4034): Lorenzo Pisani
07:15 am Core Revision 3584e565: fixing test for exact_length rule (refs #3552): Lorenzo Pisani
07:13 am Database Patch #4057: Fix: Database::quote_columns on aliased columns breaks WHERE and ORDER BY clauses: Why do you think they shouldn't? It's valid and common to use column aliases in SQL WHERE or ORDER BY, so where() and... Michael Fielding
07:10 am Core Revision 3760e1d7: adjusting the valid methods to pass the new tests (refs #3552): Lorenzo Pisani
07:09 am Core Revision 2a714b7c: fixing one of the new tests (refs #3552): Lorenzo Pisani
06:25 am Core Revision 0715547d: fixing whitespace issues: Lorenzo Pisani
03:46 am Core Revision 62e5036f: Corrected syntax error of misplaced closing paren.: Jonathan Sharp

06/22/2011

07:29 pm Database Bug Report #2005: Let the database query result $as_object = FALSE or TRUE: Fixed in 3.0.9 Chris Bandy
07:11 pm Database Patch #4057: Fix: Database::quote_columns on aliased columns breaks WHERE and ORDER BY clauses: I don't think @where()@ and @order_by()@ should accept aliased columns as input. The docs say they do... Chris Bandy
07:10 pm Database Revision 3c8ce02b: Merge 0e793bcb647965f409c00ae2f910f16d58ca07db into 13e79daa5bb1cf14a44a437f11...: GitHub Merge Button
07:00 pm Database Feature Request #4007 (Closed): Manipulate loaded Database_Result: The SPL iterators are implementations. Just pass the @Database_Result@ into their constructors.
In your example @s... Chris Bandy
11:13 am Bug Report #4061 (Closed): Bad Valid::color method: There's actually tests for these too:
https://github.com/kohana/core/blob/3.1%2Fmaster/tests/kohana/ValidTest.php#... Jeremy Bush
07:59 am Core Revision 53db11b9: adding tests for all the valid helpers that fail on empty fields (refs #3552): Lorenzo Pisani
07:58 am Core Revision d0e5bcd3: removing _empty_rules from validation tests (refs #3552): Lorenzo Pisani
05:59 am Core Revision a294de50: removing Validation::$_empty_rules(refs #3552): Lorenzo Pisani
05:55 am Bug Report #4061: Bad Valid::color method: You're right. For some reason also I thought the three digit color had to be a repeat (#fff, efe being invalid) but w... Ben Midget
05:35 am Bug Report #4061 (Assigned): Bad Valid::color method: Did you actually test the current regex?... Geert De Deckere
04:52 am Feature Request #3553 (Closed): Validation::not_empty(): Closing because of this: http://dev.kohanaframework.org/issues/3552#note-11 no longer needing this :) Lorenzo Pisani
12:22 am Feature Request #4062 (Closed): Add Validation::data(), :data, deprecate Validation::as_array(): Filing ticket from conversations on IRC earlier this morning.
Validation::as_array() doesn't make sense because we... Lorenzo Pisani

06/21/2011

08:42 pm Bug Report #4061 (Closed): Bad Valid::color method: The current method doesn't validate for three-character shorthand colors. Those shorthand colors must be a repeated v... Ben Midget
05:30 pm Feature Request #3355 (Closed): Validation callbacks, filters, rules, etc: Closing as 'worksforme', let me know if I misunderstood. Lorenzo Pisani
05:29 pm Feature Request #3796: Allow aliases in callbacks: https://github.com/kohana/core/pull/134 Lorenzo Pisani
03:06 pm Bug Report #4060 (Closed): PHP5 UTF-8: Hello.
My name is Rinat, I want to contribute by my class.
PHP5 UTF-8 is a UTF-8 aware library of functions mirro... Rin Nas
12:29 pm OAuth Revision 16799172: Merge pull request #9 from biakaveron/7bb49d724f4c065acb520c65e1ed737f1324d811: OAuth v2 access token request must send redirect_uri (at least if set) Woody Gilk
11:00 am ORM Feature Request #4059 (Closed): Missing param() on $_db_methods: Include param() on $_db_methods Gah Gneh
10:29 am Feature Request #3897: Controller actions return Response object: David Pommer wrote:
> While thinking about the view class, i consider to use the decorator pattern for rendering htm... Sam de Freyssinet
10:24 am Feature Request #3897: Controller actions return Response object: While thinking about the view class, i consider to use the decorator pattern for rendering html, json, ... etc. But t... David Pommer
09:58 am Feature Request #3709: Support per-module install.php?: If Kohana is running, you place a dependency check in the module's init.php, which can throw an exception. Also add a... David Pommer
09:06 am Core Revision 247de913: Adding a test for using bound values in callbacks (refs #3796): Lorenzo Pisani
08:29 am Core Revision 1b36a56f: Allowing bound values to be used in validation callbacks(refs #3796): Lorenzo Pisani
06:53 am Bug Report #4034: Validation does not need to extend ArrayObject any more: I always hated that :) we should name it either $object or $validation Lorenzo Pisani

06/20/2011

08:54 pm ORM Feature Request #4058 (Closed): Configurable message file for errors: http://forum.kohanaframework.org/discussion/9189/orm-validation-messages
Basically just add a property to use inst... Lorenzo Pisani
04:49 pm Database Patch #4057 (Closed): Fix: Database::quote_columns on aliased columns breaks WHERE and ORDER BY c...: Database::quote_columns can take an array of values where the second element is the alias and appends 'AS xyz' to the... Michael Fielding
03:35 pm ORM Revision bf8e804a: extending the example for filters in issue #4056: Joel Pittet
03:30 pm ORM Patch #4056: Filters documentation update: https://github.com/kohana/orm/pull/33 Joel Pittet
03:21 pm ORM Patch #4056 (Closed): Filters documentation update: Added more examples to the filters documentation. Joel Pittet

06/19/2011

11:22 pm Bug Report #4054: Request::$current is always NULL when an Exception is thrown: Jeremy Bush wrote:
> If you throw an exception before your first Request::factory() call in your index.php, you'll g... Marcel Evenson
11:03 pm Bug Report #4054: Request::$current is always NULL when an Exception is thrown: If you throw an exception before your first Request::factory() call in your index.php, you'll get this behavior. For ... Jeremy Bush
08:35 pm Core Revision a298b9a3: Refs #4009, removing the accidental comments committed: Sam de Freyssinet
08:20 pm Core Revision e2884c51: Refs #4009, base HTTP_Header object completed, now 42% faster execution that K...: Still to implement Accept-* HTTP header parsing; update rest of Kohana core to use new API and update unittests to re... Sam de Freyssinet
05:06 pm Core Revision a1943b0d: Refs #4009, WIP on refectoring HTTP_Header. Header does not convert values to ...: Text::ucwords() implemented to restore pseudo standard http header format
Moved the core function of Response::send_... Sam de Freyssinet
04:21 pm ORM Revision ae9f365e: Merge 2ccb28fdc76755a1fa9f135a26a2f5dfb3ddfab0 into af3137ed33244a18909ab25a5f...: GitHub Merge Button
02:44 pm Patch #4055 (Closed): Class and constans name in uppercase: It's in @280@ line of @date.php@ file:... Damian Stasik
12:27 pm Bug Report #4054 (Closed): Request::$current is always NULL when an Exception is thrown: I noticed that ajax exceptions were still being thrown with all their HTML included in their back trace but the Kohan... Marcel Evenson
10:13 am ORM Revision 2ccb28fd: Added set_values method: Juan Lago
06:34 am Database Feature Request #4007: Manipulate loaded Database_Result: wow, I'm a PHP programmer for 8 years now, and JUST EVER used the ArrayIterator!
Indeed, a mix of FilterIterator an... Gah Gneh
05:55 am Database Feature Request #4007: Manipulate loaded Database_Result: I think most of this can already be done with the built-in "iterators":http://php.net/manual/spl.iterators Chris Bandy

06/18/2011

04:19 pm Core Revision 73592d6b: Merge fa07a43c01c6c34d5fdb11f636f1c942cb620bc9 into 9a53f22cfa32624d54bb414c98...: GitHub Merge Button
04:13 pm Core Revision fa07a43c: fixing references to old Validate class: Joel Pittet
04:11 pm Patch #4053: Leftover guide and comments relating to Validate class: https://github.com/kohana/core/pull/133
https://github.com/joelpittet/core/commit/fa07a43c01c6c34d5fdb11f636f1c942cb... Joel Pittet
04:02 pm Patch #4053 (Closed): Leftover guide and comments relating to Validate class: There are a few references to the older Validate class. Joel Pittet

06/17/2011

01:52 pm Database Bug Report #4052: Ignore empty parentheses in or_where_close() / and_where_close(): This isn't a bad idea, but I think such behavior should be optional. I think an optional parameter to @close()@ would... Chris Bandy
09:04 am Database Bug Report #4052: Ignore empty parentheses in or_where_close() / and_where_close(): I mixed up the order of or_where_open() and or_where_close() in the name search example but you get the point Kemal Delalic
09:03 am Database Bug Report #4052 (Closed): Ignore empty parentheses in or_where_close() / and_where_close(): This would allow us not to worry about having something inside of these conditions. Usage example (search):... Kemal Delalic

06/16/2011

07:19 pm ORM Feature Request #3935: Using with() is slow compared to join(): Fixed some formatting. Chris Bandy
01:18 pm Bug Report #3088 (Feedback): Validate::date() doesn't handle dates correctly: Hi !
I reopen this bug because I recently used the php DateTime class which could fit the needs of the validation cl... Thomas Lété
01:11 pm UnitTest Bug Report #4051 (Closed): SYSPATH/system/tests/kohana/ViewTest.php: Uses the 5.3 __DIR__ in the setupBeforeClass function in v3.1.3.1 of Kohana Iain Carsberg
12:00 pm OAuth Revision 9eea5af8: Merge pull request #8 from rafi/3.1/linkedin_provider: 3.1/linkedin provider Woody Gilk
10:34 am OAuth Revision 59331b62: Fixing typo: Rafael B.

06/15/2011

11:48 pm OAuth Revision 7bf140eb: Merge pull request #7 from rafi/3.1/linkedin_provider: 3.1/develop Woody Gilk
09:59 pm OAuth Revision fc6ceb65: Adding a Linkedin provider: Rafael B.
06:14 pm Database Bug Report #4047: Returning if query was successful in UPDATE: As for my previous comment, I didn't realize I was looking at early 3.0 branch. Kohana_Database_PDO::query() throws D... Vit Brunner
04:27 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: One more thing I noticed is that we often name a @Validation@ object "@$array@", e.g., "Kohana_Validation_Exception::... Chris Bandy
02:55 pm ORM Bug Report #3866: Static method for checking if a record exists: +1 - it will be useful
and also wish for this method to support not only single value but array of values Tiger SEO
02:46 pm ORM Feature Request #3935: Using with() is slow compared to join(): ... Tiger SEO
02:44 pm ORM Feature Request #4049 (Closed): add using() to ORM::$_db_methods: Hi.
There is ability to use using() method in query builder, but it can't be used in ORM, cause it's not listed in $... Tiger SEO
02:07 pm Database Bug Report #4047 (Closed): Returning if query was successful in UPDATE: Yeah, I'm not sure what you mean. An "unsuccessful" query (one that never hit the database) would result in a databas... Jeremy Bush
11:56 am Database Bug Report #4047: Returning if query was successful in UPDATE: If I see it right, you should get an exception on an unsuccesful query:
* Kohana_Database_MySQL::query() throws Data... Vit Brunner
10:23 am Bug Report #4048: Log writer fails when messages use Log::ALERT: Pull request: https://github.com/kohana/core/pull/132 Mathew Davies
10:14 am Bug Report #4048 (Closed): Log writer fails when messages use Log::ALERT: If you have a line like this:... Mathew Davies
08:35 am Database Bug Report #4047 (Closed): Returning if query was successful in UPDATE: Currently the we get the number of affected rows on UPDATE queries.
It would be good if we would also get if the que... George Fekete

06/14/2011

03:09 pm Userguide Revision 539273cb: Check if API browser has been disabled (bug fix #4046): Phil Paxton
03:05 pm Userguide Bug Report #4046: Route Exception after disabling the API Browser in \config\userguide.php: Bug fix added to https://github.com/kohana/userguide/pull/19 Phil Paxton
02:56 pm Userguide Bug Report #4046 (Closed): Route Exception after disabling the API Browser in \config\userguide.php: Disabling the API browser in *\userguide\config\userguide.php*... Phil Paxton
12:02 pm OAuth Revision 1bf8c312: Merge pull request #6 from rafi/3.1/develop: 3.1/develop Woody Gilk
11:59 am OAuth Feature Request #4045 (Closed): Ability to add more options to the oAuth cURL call: classes\kohana\oauth.php - Kohana_OAuth::remote($url, array $options = NULL)
Being able to add more options to the... Rafael B.
11:58 am OAuth Revision 253111ad: Fixing: Request::uri() is a function, closing <h2> tag: Rafael B.
12:39 am Bug Report #4044 (Assigned): 3.1 Request_Client_External::_native_execute() passing integer heade...: Jeremy Bush

06/13/2011

07:53 pm Bug Report #4044 (Closed): 3.1 Request_Client_External::_native_execute() passing integer header ...: system/classes/kohana/request/client/external.php:369 passes an integer to Kohana_Request::headers(), which triggers ... Mike Matz
12:21 pm Bug Report #4043 (Closed): Valid::range: HTML5 has the ability to validate range for "number" and "range" input types, and I think it only makes sense for Koh... Ben Midget

06/12/2011

12:59 pm Bug Report #4042 (Closed): DocBlocks for Response::serialize/unserialize() referrer to JSON: Both methods utilize php arrays and not JSON.
The DocBlock for _public function unserialize()_ is completely wrong... Nick Gregory

06/11/2011

07:03 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: Kiall Mac Innes wrote:
> Testing the correct SQL is generated should happen in the Database tests, rather than ORM.
>... Matt Button
06:36 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: For what it's worth... we are planning a lot of changes for ORM in 3.3 which will use DI properly... this might have ... Lorenzo Pisani
05:44 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: Testing the correct SQL is generated should happen in the Database tests, rather than ORM.
Testing that ORM calls ... Kiall Mac Innes
05:22 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: > If the use case is for testing - switching out the environment is IMO the correct way to handle this. Using a "test... Matt Button
03:31 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: Kiall, I agree. However we still need a way to inject the database instance into ORM so we can test ORM. It should be... Isaiah DeRose-Wilson
03:12 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: I'm not sure I understand how that retains either the functionality being asked for, or the existing functionality?
... Kiall Mac Innes
03:05 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: In my opinion, the relationship should get the database instance from the target model or just not pass it in. Mathew Davies
03:00 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: Matt Button wrote:
> The main problem is that ORM would need to inject the connection into any model instances it "c... Kiall Mac Innes
02:57 pm ORM Feature Request #3520: Allow a database connection to be injected into an ORM model: My comment on #4041 applies to this as well ..
I disagree that this is the correct way to handle testing.
IMO ... Kiall Mac Innes
02:55 pm ORM Feature Request #4041: Allow the db instance to be injected into ORM: Since I already had it typed out before Isaiah closed this .. I may as well post it!
I disagree that this is the c... Kiall Mac Innes
02:46 pm ORM Feature Request #4041 (Closed): Allow the db instance to be injected into ORM: Isaiah DeRose-Wilson
02:38 pm ORM Feature Request #4041 (Closed): Allow the db instance to be injected into ORM: Right now it's a pain in the ass to do any tests with ORM because you can't set the database group/instance without c... Mathew Davies
01:02 am Bug Report #3876: Code Sniffer 1.3.0 support: Merged https://github.com/kohana/coding-standards/pull/4 Matt Button
12:11 am Core Revision dc9b8e35: Merge branch '3.2/feature/3000-config-rewrite' of http://github.com/kohana/cor...: Matt Button
12:04 am Revision b77ad889: Updating submodules: Matt Button
12:02 am UnitTest Revision 615d0631: Removing db_connection config group, fixes #3677: Matt Button
12:00 am UnitTest Bug Report #3677 (Closed): Remove the need for a separate database group: Applied in changeset commit:615d06312e8e46f1e2e29acc6ea2e65110e1d33d. Anonymous
12:00 am UnitTest Bug Report #3663 (Closed): DOCROOT is wrong: Applied in changeset commit:8acd875021f74c189d6cde73dc2f36015244a762. Anonymous

06/10/2011

11:56 pm UnitTest Bug Report #3677: Remove the need for a separate database group: This introduces API changes hence is a 3.2 fix only Matt Button
11:54 pm UnitTest Revision 8acd8750: Use correct DOCROOT path in bootstrap, fixes #3663: Matt Button
11:52 pm UnitTest Revision 2def390d: Use correct DOCROOT path in bootstrap, fixes #3663: Matt Button
11:45 pm Revision b8d9f2bc: Updating unittest module: Matt Button
07:49 pm UnitTest Revision 8bfb9e31: Add abstract transparent extension for db testcase fixes #3920: Matt Button
07:47 pm UnitTest Revision 62b9a05d: Add abstract transparent extension for db testcase fixes #3920: Matt Button
07:45 pm UnitTest Bug Report #3920 (Closed): Abstract Transparent Classes: Applied in changeset commit:8bfb9e318f948629279549dae1ea2bce90d5df67. Anonymous

06/09/2011

03:39 pm Revision 7b67ee11: Tracking database: Chris Bandy
03:36 pm Revision c40fd7ee: Tracking database: Chris Bandy
03:34 pm Database Revision 13e79daa: Merge branch '3.1/develop' into 3.2/develop. Refs #3485: Chris Bandy
03:32 pm Database Revision cc21f544: Fix bad merge 4acfcdbdc47135e8e8161135bd012289c4045136. Refs #3485: Chris Bandy
02:15 pm Bug Report #4039 (Closed): Kohana_Exception does not handle semi-numeric codes: Applied in changeset commit:fb23e916ed8334dda53f4efbbbefea66f6d4a070. Chris Bandy
02:07 pm Revision f9ab9fd4: Tracking system: Chris Bandy
02:05 pm Core Revision fb23e916: Save the code after the parent constructor. Fixes #4039: Chris Bandy

06/08/2011

09:59 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: Fine then, @data()@ as a getter for @$_data$ seems logical to me. I'm also not too opposed to Kiall's suggestion. Lorenzo Pisani
09:44 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: fwiw, @as_array()@ seems semantically ambiguous to me. Does it return the rules? the labels? everything in some kind ... Chris Bandy
09:42 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: Yeah, I was referring to ArrayObject which is the current class we extend. Lorenzo Pisani
09:32 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: ArrayAccess is 4 methods total, get, set, unset and exists.. personally - I prefer this than an as_array.. but either... Kiall Mac Innes
09:28 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: We are basically removing about 20 methods that we should never need. I think @:data@ and @as_array()@ are the only t... Lorenzo Pisani
09:23 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: Dropping ArrayObject and instead implementing a read only version of ArrayAccess seems like a good option to me.. Kiall Mac Innes
08:39 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: Does extending/implementing ArrayObject have any kind of performance impact? Jeremy Bush
08:04 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: We can add simple @as_array()@ and @get()@ methods for that kind of stuff. We can also add @:data@ to the list of thi... Lorenzo Pisani
06:43 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: In data models, I often have fields whose validation depends on each other. For example, one field must be not empty ... Chris Bandy
05:25 pm Bug Report #4040 (Closed): Kohana_Exception does not handle semi-numeric codes: The string @'25P01'@ still returns integer @25@ from getCode(). Chris Bandy
05:24 pm Bug Report #4039 (Closed): Kohana_Exception does not handle semi-numeric codes: The string @'25P01'@ still returns integer @25@ from getCode(). Chris Bandy

06/07/2011

02:26 pm Userguide Revision 0f9f1239: Merge 8285896e608b00b97a7d0e3c178b74a89b340669 into 2d991eb50c38970138ca223a33...: GitHub Merge Button
12:40 pm Userguide Bug Report #4037: API Browser anchors conflict with page styles: I've changed element IDs in template by adding @kodoc-@ prefix to them, so we have @#kodoc-body@, @#kodoc-content@, e... Korney Czukowski
12:38 pm Userguide Revision 8285896e: Updated template element IDs: Korney Czukowski
10:08 am Feature Request #3992: Support setting Request::body() to a resource/file handle: Aha - Nice to know I wasn't missing anything obvious .. Just the 'native' driver todo then .. Kiall Mac Innes
09:42 am Feature Request #3992: Support setting Request::body() to a resource/file handle: I think your current implementation is the only way to do this at the moment with PECL HTTP. Sam de Freyssinet
05:30 am Revision 50654e65: Updating submodules: Kiall Mac Innes
05:25 am Core Revision 9a53f22c: Documentation fix - Messages files are merged LIKE not UNLIKE config files.: Kiall Mac Innes

06/06/2011

11:45 am Feature Request #4038 (New): Log should be able to handle arrays & objects: Because values in Kohana_Log are replaced using the following technique... Peter Briers
10:39 am Userguide Bug Report #4037 (Closed): API Browser anchors conflict with page styles: See the example here:
http://kohanaframework.org/3.1/guide/api/Response#body
The page template already defines ... Korney Czukowski

06/04/2011

10:00 pm ORM Patch #3877: Remove directories from message path: I'll take a look soon. You should try to keep commits as specific as possible, it seems like you cleaned up the docbl... Lorenzo Pisani
04:40 pm ORM Feature Request #4036: Allow count_all() to use reset() without clearing search conditions: Never mind - see it now. Thanks! Logan Aube
04:36 pm ORM Feature Request #4036: Allow count_all() to use reset() without clearing search conditions: the issue I see here is that count_all() calls reset(TRUE) automatically. Am I missing something obvious? Logan Aube
04:26 pm ORM Feature Request #4036 (Closed): Allow count_all() to use reset() without clearing search conditions: Yes reset(FALSE) is what you want. Isaiah DeRose-Wilson
10:42 am ORM Feature Request #4036: Allow count_all() to use reset() without clearing search conditions: @$object->reset(FALSE)->count_all()@ ? Kemal Delalic
10:10 am ORM Patch #3877: Remove directories from message path: Here is a fresh one [[https://github.com/kohana/orm/pull/31]]. Please, do something with this exception. I am buildin... Damian Stasik

06/03/2011

10:25 pm ORM Feature Request #4036 (Closed): Allow count_all() to use reset() without clearing search conditions: In cases like using the pagination model, you want to use the same condotions for a count before the paginated query.... Logan Aube
06:13 pm Feature Request #4035: Nested validation objects: I dislike the dot notation syntax too. I think being able to inject a validation object in for a field rule would be ... Isaiah DeRose-Wilson
04:49 pm Feature Request #4035: Nested validation objects: As I said, I'm simply going for consistency throughout here .. The originally suggested syntax is fine, I'm simply sa... Kiall Mac Innes
03:56 pm Feature Request #4035: Nested validation objects: Me and zombor kind of dislike dot notation because it's valid for array keys. It also actually makes the class more c... Lorenzo Pisani
03:33 pm Userguide Bug Report #4030: Kohana Views being called from within code blocks: I've noticed the same problem happening in the API browser if a method's comment contains an example view. In my cas... Phil Paxton
03:07 pm Userguide Revision c3bf9e3c: Don't check for/include views in the API: Phil Paxton
02:33 pm Feature Request #4035: Nested validation objects: Not sure I like the syntax for consistency reasons, we use dot notation in other areas of Kohana, why not continue to... Kiall Mac Innes
02:30 pm Bug Report #4034: Validation does not need to extend ArrayObject any more: +1 Its no longer necessary IMO. Kiall Mac Innes
04:13 am Bug Report #4034 (Assigned): Validation does not need to extend ArrayObject any more: I agree. Jeremy Bush
01:14 am Feature Request #4035 (New): Nested validation objects: I would like the ability to validate multi-dimensional arrays and I think allowing the validation objects to be neste... Lorenzo Pisani
01:06 am Bug Report #4034 (Closed): Validation does not need to extend ArrayObject any more: For 3.1.x, we simplified the Validation object to remove filters and narrow the focus of the class down to simply mak... Lorenzo Pisani

06/02/2011

08:37 pm Userguide Revision 4d460ec1: Merge 3c5e6dd809702c903685fe0208e4b976ae415c00 into afeda5b7bedcc9f7617db9d75e...: GitHub Merge Button
11:34 am Userguide Bug Report #4030: Kohana Views being called from within code blocks: I've since come up with and committed a better solution to this bug.
Pull Request: https://github.com/kohana/use... Phil Paxton
11:33 am Userguide Revision 3c5e6dd8: Escape views within code tags (fixes bug #4030): Phil Paxton
10:48 am Userguide Revision 163fb556: Escape views within code tags (fixes bug #4030): Phil Paxton

06/01/2011

05:35 pm Database Bug Report #4033: Configuration defaults: Damn, I can no longer edit the original description :)
As promised, the pull request: https://github.com/kohana/da... Vit Brunner
04:39 pm Bug Report #3401 (Assigned): Set Request::$client_ip from HTTP headers only if a trusted proxy se...: After talking with Kiall on IRC I might have changed my mind about this. Adding a simple whitelist would be okay. By ... Isaiah DeRose-Wilson
04:14 pm Bug Report #3401 (Closed): Set Request::$client_ip from HTTP headers only if a trusted proxy set ...: Having a list of trusted proxies sounds like a good solution, however I think this is outside the scope of the reques... Isaiah DeRose-Wilson
02:35 pm Database Bug Report #4033 (Closed): Configuration defaults: Right now, configuration of a database instance does not have any defaults (there are defaults for the "default" and ... Vit Brunner
12:15 pm Bug Report #3401: Set Request::$client_ip from HTTP headers only if a trusted proxy set the header.: Marcus Cobden wrote:
> We allow people to specify trusted chains of proxies/load balancers.
I've seen implementat... Kiall Mac Innes
11:31 am Bug Report #3401: Set Request::$client_ip from HTTP headers only if a trusted proxy set the header.: Jeremy, seems so: #3558 Alex Kurilo

05/31/2011

06:00 pm Userguide Bug Report #4030: Kohana Views being called from within code blocks: Scratch the pull request I submitted as the regex does not work for more complicated scenarios. Phil Paxton
05:32 pm Feature Request #3355: Validation callbacks, filters, rules, etc: Sorry for the confusion, I am just trying to understand what you want exactly... seeing as how this feature seems to ... Lorenzo Pisani
04:21 pm Cache Bug Report #3063 (Closed): RecursiveDirectoryIterator error when using file cache: Sam de Freyssinet
04:21 pm Cache Bug Report #3123 (Closed): ErrorException in Kohana_Cache_File::get: Sam de Freyssinet
04:21 pm Cache Bug Report #3290 (Closed): Cache failure callback should be public: Sam de Freyssinet
04:20 pm Cache Bug Report #3377 (Closed): Kohana_Cache_File default settings: Sam de Freyssinet
04:20 pm Cache Bug Report #3390 (Closed): Cache_Memcachetag always throughs Exception in __construct: Sam de Freyssinet
04:19 pm Cache Bug Report #3409 (Closed): No default for instanst_death in memcache: Sam de Freyssinet
04:15 pm Cache Bug Report #3573 (Closed): Cache_MemcacheTag::set_with_tags() does not sanitize ID: Applied in changeset commit:e24ee32ff3e160bbae33d529a4e1557cce6bdee8. Sam de Freyssinet
04:09 pm Cache Revision e24ee32f: Fixes #3573, memcache tag now sanitizes the id just as it should: Sam de Freyssinet
04:08 pm Cache Revision be44604b: Fixes #3573, memcache tag now sanitizes the id just as it should: Sam de Freyssinet
04:00 pm Cache Feature Request #4023 (Closed): Basic Arithmetic: Applied in changeset commit:52bd4821645d62827d15e8f2050613306cbe813e. Sam de Freyssinet
03:55 pm Cache Revision 0f8196ee: Refs #4023, adds the Cache_Arithmetic interface to the APC cache driver: Sam de Freyssinet
03:54 pm Cache Revision 52bd4821: Fixes #4023, Cache library now supports basic arithmetic for drivers than nati...: Sam de Freyssinet
03:43 pm Cache Revision 33896690: Refs #2819, better use of Kohana::find_file() to include required abstract cla...: Sam de Freyssinet
03:38 pm Cache Revision bc2c42d2: Refs #4023, tests for Arithmetic created: Sam de Freyssinet
02:49 pm Cache Revision 2b41c377: Refs #4023, interfaces for Basic arithmetic defined: Sam de Freyssinet
02:49 pm Cache Revision e10837ba: Updated the docs to reflect supported cache engines in 3.2: Code style changes to the File driver Sam de Freyssinet
12:01 pm Feature Request #3355: Validation callbacks, filters, rules, etc: I'm certainly not in charge of whether this is still supposed to happen, though Zombor said he wanted to support both... Ben Midget
11:04 am Cache Revision 48658184: Fixes #3275, File cache driver now supports utf-8: Sam de Freyssinet
11:00 am Cache Bug Report #3275 (Closed): File driver does not save data properly if charset is not utf-8: Applied in changeset commit:48658184b727b6693a64ec8760763f0f45fb189a. Sam de Freyssinet
12:32 am Database Bug Report #4032 (Closed): Logic in execute() results in no result queries being run again.: In Kohana_Database_Query::execute(), there is a test to see if a query is in the cache.... Deon George

05/30/2011

09:24 pm ORM Patch #3877: Remove directories from message path: It looks like you linked to the wrong pull request, can you get back to me? Lorenzo Pisani
09:20 pm Feature Request #3355: Validation callbacks, filters, rules, etc: Just checking up on issues assigned to me... so is this an invalid request? We already support this in 3.1.x. Are you... Lorenzo Pisani
09:16 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules': Another solution mentioned on IRC by Kiall that I like is to remove this type of handling from Validation completely ... Lorenzo Pisani
08:54 pm Bug Report #3552: Validation needs a better way to specify '_empty_rules': Kiall Mac Innes wrote:
> From @Lorenzo's pull:
> [...]
>
> Without really looking into the code or reasoning etc... Lorenzo Pisani
08:42 pm OAuth Revision f635fbb2: Added OAuth v2 Facebook driver: Ivan Brotkin
08:41 pm OAuth Revision 7bb49d72: OAuth2 Access_Request must sent redirect_uri if set: Ivan Brotkin
06:28 pm Bug Report #3690: Request::uri() should return the actual URI: Jeremy, now Request::uri() can change request params in new generated url, do you think it is wrong?
I think it is g... Tomek Rychlik
05:50 pm Bug Report #4031 (Assigned): Unnecessary check for cache dir: Went though this with Steve on IRC, there are a few areas in @Kohana_Core@ that could use some cleanup ..
BUT - I... Kiall Mac Innes
05:47 pm Bug Report #4031: Unnecessary check for cache dir: This is Konaha::init
system/classes/kohana/core.php Steve Gula
05:46 pm Bug Report #4031 (Assigned): Unnecessary check for cache dir: Kohana checks for (and then creates, if not found) a cache directory before it checks to see if $settings['caching'] ... Steve Gula
02:59 pm Userguide Bug Report #4030 (Closed): Kohana Views being called from within code blocks: I received the following error when trying to view the user guide markdown page (/guide/userguide/markdown):... Phil Paxton
02:49 pm Bug Report #4000: We don't use "and" in an integer in English: @Samsoir lol I agree. It's more of a joke to myself. I know anyone outside the US gets so sick of stuff like that. I ... Ben Midget
02:47 pm Bug Report #4000: We don't use "and" in an integer in English: > Shouldn't the built-in text be determined by messages and then ultimately a translation string then?
I agree with ... Sam de Freyssinet
02:39 pm Core Revision a7658e5d: Merge branch '3.2/develop' of github.com:kohana/core into 3.2/develop: Sam de Freyssinet
02:38 pm Core Revision ccd0655a: Fixes 3947, Headers now render correctly when value is an Array: Sam de Freyssinet
01:01 pm Core Revision 94484c02: Fixes #3947, Headers now render correctly when value is an Array: Sam de Freyssinet
01:01 pm Bug Report #3947 (Closed): Headers corrupt when Header_Value is array: Applied in changeset commit:94484c0298f02804de5f256cc597b8169038aeeb. Sam de Freyssinet
12:49 pm Core Revision 8357e393: Fixes #4029, the Curl external request driver now will parse headers as expect...: Sam de Freyssinet
12:45 pm Bug Report #4029 (Closed): Request_External Curl driver not parsing headers: Applied in changeset commit:8357e3939d6b65cc3193ee680800e00068db41e5. Sam de Freyssinet
12:37 pm Bug Report #4029 (Closed): Request_External Curl driver not parsing headers: @$response->headers()@ returns empty object. If I add @CURLOPT_HEADERS => true@ to request, then headers of the respo... Sam de Freyssinet
05:59 am Bug Report #3436: Text::auto_link_urls breaks if link text contains 'http://' and located between...: Whoo thank you! (Now I have 4 characters in ko3 core, yay ;) Vit Brunner

05/29/2011

09:51 pm ORM Bug Report #4028 (Closed): Speed up ORM::as_array(): This method works quick & fine on single rows without any related objects being loaded.
The problem occurs when th... Kemal Delalic
12:36 pm Revision f1dd1b83: Update 3.2 README.md: Kiall Mac Innes
12:31 pm Revision 53a96dbe: Updating submodules: Kiall Mac Innes
12:30 pm Core Revision 9ab29aa7: Merge branch '3.1/develop' into 3.2/develop: Kiall Mac Innes
12:29 pm Revision 3dbdd202: Updating submodules: Kiall Mac Innes
12:29 pm Core Revision 3be71da0: Merge branch '3.0/develop' into 3.1/develop: Conflicts:
classes/kohana/core.php
classes/kohana/session.php Kiall Mac Innes
12:26 pm Bug Report #3436: Text::auto_link_urls breaks if link text contains 'http://' and located between...: Vit Brunner wrote:
> I added a test case to the pull request.
>
> Geert's last activity here is from half a year ... Kiall Mac Innes
12:26 pm Bug Report #3436 (Closed): Text::auto_link_urls breaks if link text contains 'http://' and locate...: Kiall Mac Innes
12:24 pm Revision bd2c851b: Updating submodules: Kiall Mac Innes
12:22 pm Core Revision 49782566: Merge pull request #121 from tasuk/3.0/develop: Fixes #3436 - Text::auto_link_urls() breaks between tags Kiall Mac Innes
11:53 am Bug Report #3436 (Assigned): Text::auto_link_urls breaks if link text contains 'http://' and loca...: Kiall Mac Innes

05/28/2011

07:32 pm Bug Report #3436: Text::auto_link_urls breaks if link text contains 'http://' and located between...: I added a test case to the pull request.
Geert's last activity here is from half a year ago. Could we perhaps reas... Vit Brunner

05/27/2011

04:06 pm Cache Bug Report #3837 (Closed): File cache will not delete directories: Sam de Freyssinet
03:50 pm Cache Revision a3b3b6ff: Fixes #3753. Cache will not remove files that are protected by the configurati...: Test included with fix Sam de Freyssinet
03:47 pm Cache Feature Request #3378: Move Cache Module to Kohana-Core: Cache in 3.3 will support full dependency injection, including configuration - making this possible. Sam de Freyssinet
03:45 pm Cache Bug Report #3753 (Closed): Kohana_Cache_File::_delete_file failed to delete directory: Applied in changeset commit:a3b3b6ff3649d6a5d050c9687c4e4d6a6be3446c. Sam de Freyssinet
03:27 pm Cache Revision 930f4c22: Fixes #4027 Removed support for xcache and eaccelerator from cache library: Sam de Freyssinet
03:16 pm Cache Feature Request #2819 (Closed): Unit Tests for cache module: Applied in changeset commit:0eacc0040d0085b51d5b056d33ce77d5ac4c04fd. Sam de Freyssinet
03:14 pm Cache Revision d519d231: Refs #2819, fixes Wincache test skip message: Sam de Freyssinet
03:11 pm Cache Revision 0eacc004: Fixes #2819, Unit Tests now cover most of the Cache module, testing core featu...: #4027 Removed support for xcache and eaccelerator from cache library Sam de Freyssinet
03:10 pm Cache Feature Request #4027 (Closed): Xcache and Eaccelerator are no longer supported: Fixed in https://github.com/kohana/cache/commit/0eacc0040d0085b51d5b056d33ce77d5ac4c04fd Sam de Freyssinet
03:05 pm Cache Feature Request #4027 (Closed): Xcache and Eaccelerator are no longer supported: Remove the core cache drivers for Xcache and Eaccelerator as they are no longer supported. Sam de Freyssinet
11:44 am Bug Report #3000: Config system rewrite: Awesome! Looking forward to this. Thanks for the work. supster .
08:38 am Patch #4020: Stack traces for Fatal PHP errors: xdebug doesn't normally collect function parameters, this snippet would enable that.
Where should it go, in @bootstr... Marcus Cobden

« Previous

Also available in: Atom

KohanaPHP » Kohana v3.x

Activity

Activity

06/25/2011

06/24/2011

06/23/2011

06/22/2011

06/21/2011

06/20/2011

06/19/2011

06/18/2011

06/17/2011

06/16/2011

06/15/2011

06/14/2011

06/13/2011

06/12/2011

06/11/2011

06/10/2011

06/09/2011

06/08/2011

06/07/2011

06/06/2011

06/04/2011

06/03/2011

06/02/2011

06/01/2011

05/31/2011

05/30/2011

05/29/2011

05/28/2011

05/27/2011