Activity
From 12/01/2011 to 12/30/2011
12/30/2011
-
11:58 pm Core Revision f5481e75: Remove stray debugging output.
-
11:55 pm Core Revision 0b7471a2: Refactor Exception -> View conversion and reinstate correct exception handling...
-
10:43 pm Core Revision 669f3850: Refs #4374 / Refs #4373 - Return a Response from Controllers and Cleanup Reque...
-
10:42 pm Core Revision 7a63bbbc: Cleanup Request+Add HTTP tests
-
10:24 pm Core Revision 623e8c7e: Reintroduce HTTP redirection.
-
09:43 pm Feature Request #4374 (Closed): Decouple Response object creation from the Request class..
- Decouple Response object creation from the Request class..
-
09:43 pm Feature Request #4373 (Closed): Provide better isolation of requests/sub-requests
- Provide better isolation of requests/sub-requests.
Eg throwing an Exception inside a sub-request should return a R... -
09:25 pm Revision ce4747ea: Reinstate Controller:: and Controller::
-
09:25 pm Core Revision e3fee0f7: Reinstate Controller:: and Controller::
-
09:08 pm Feature Request #3897: Controller actions return Response object
- I actually (force) pushed some more changes after my comment to the branch.. The Controller controller action returni...
-
08:59 pm Revision 023a197d: Request/Response instances should be passed around as necessary.
-
08:58 pm Core Revision 43d88a5f: Request/Response instances should be passed around as necessary.
-
07:46 pm Revision 0709f1ee: Add minion module. Refs #3989.
-
04:18 pm Feature Request #3989: Make Minion official
- This should include removing all ideas of "cli" from kohana core: requests, controllers, routes, etc.
-
12:26 am Cache Feature Request #4100 (Closed): Memcache Timeout Should Be In Milliseconds
- The timeout is is measured in seconds as that is the measurement accepted by the PHP memcache extension.
See http:...
12/29/2011
- 03:01 pm Revision d61cab09: Update submodules
- 03:01 pm Revision cf765dfc: Update submodules
-
03:00 pm Database Bug Report #4078 (Closed): PDO connection set charset not universal
- Applied in changeset commit:4c6f81daab68fdf40eda46c91905e936fbfbee07.
-
03:00 pm Database Feature Request #4203 (Closed): Database profiling
- Applied in changeset commit:b25c56e4e94c56b0f0c57c8e43cdd2c1d98f1244.
-
03:00 pm Database Feature Request #4372 (Closed): Allow PDO options to be configured
- Applied in changeset commit:d8adaca45a2df7be691107f2ac1990a23830b2f9.
-
02:45 pm Database Revision 4c6f81da: PDO: Do not call SET NAMES during connect(). Fixes #4078
-
02:39 pm Database Revision f003d075: Merge branch '3.2/develop' into 3.3/develop
-
02:38 pm Database Revision d8adaca4: Allow PDO options to be configured. Fixes #4372
-
02:37 pm Database Feature Request #4372 (Closed): Allow PDO options to be configured
- I want to provide the fourth parameter to "PDO::__construct()":http://www.php.net/manual/en/pdo.construct.php using d...
-
02:16 pm Database Revision b25c56e4: Remove 'profiling' configuration. Fixes #4203
-
02:16 am Feature Request #4271: Controller action execution wrapper
- A request should execute one action. multiple actions for one request? that makes the execution flows confuse. I thin...
12/28/2011
-
07:56 pm Database Feature Request #4203: Database profiling
- I think the config parameter should probably just go away and @Database@ should read @Kohana::$profiling@ directly.
-
05:37 pm Feature Request #3897: Controller actions return Response object
- @Kiall, Maybe. I think your solution is a little different from the description of this issue. You are having the exe...
-
05:08 am Revision 7a38ed9b: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
-
05:07 am Core Revision 3f0efc43: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
-
04:52 am Feature Request #3897: Controller actions return Response object
- I've added 2x "mock up" branches for this to both kohana/kohana and kohana/core.
Initial thoughts?
https://gith... -
04:46 am Revision b72ac8c8: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
-
04:44 am Core Revision 2eaa8596: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
-
04:03 am Feature Request #3897: Controller actions return Response object
- In fact, This would help with fixing up some of the request isolation issues discussed as well..
Specifically with e... -
03:56 am Feature Request #3897: Controller actions return Response object
- @Isaiah - Is this not a small step towards the general cleanup we discussed today that can easily be implemented?
-
03:45 am Feature Request #2693 (Closed): Re-introduce events.
- I don't think this is ever going to happen. If it does a new issue can be created, this one has been around long enough!
- 03:16 am Revision 4a1242a8: Update submodules
- 03:15 am Revision 4e084bc8: Update submodules
-
03:06 am Core Revision 2c897839: Merge branch '3.2/develop' into 3.3/develop
-
03:05 am Core Revision 42f5b7e1: Changed usage of $_POST to Request::post() in guide documentation. Fixes #4256.
-
03:05 am Bug Report #4256 (Closed): Kohana documentation uses $_POST instead of Request::post()
- Fixed in 3.2 and 3.3. Thanks!
- 03:01 am Revision 137d8057: Update submodules
- 03:00 am Revision 07d65070: Update submodules
-
03:00 am Patch #4251 (Closed): Fix error on deprecated get_magic_quotes_gpc() in PHP 5.4+
- The other ticket's pull request was merged before I noticed this one! Either way, Fixed.
- 03:00 am Core Revision c17dab71: Fixes #4291, checks for PHP 5.4 before doing get_magic_quotes_gpc as it has be...
-
02:59 am Bug Report #4291: get_magic_quotes_gpc is deprecated in 5.4
- I merged this before noticing the other pull.. Either way, done.
- 02:59 am Core Revision acf8ff0a: Fixes #4291, checks for PHP 5.4 before doing get_magic_quotes_gpc as it has be...
-
02:55 am Core Revision a94e45db: Merge pull request #189 from kohana/3.3/feature/4371-extract-paths
- Fixes #4371 - Merge "Arr::extract() with paths"
-
02:48 am Core Revision 72567e22: Add tests for Arr::extract() via paths. Tests #4371.
-
02:46 am Feature Request #4371 (Closed): Convert Arr::extract to work with paths not keys
- Applied in changeset commit:cad88a9799e27e2150a846ee1726a96dc1d0e110.
-
02:44 am Core Revision 87131d09: Add tests for Arr::extract() via paths. Tests #4371.
-
02:32 am Feature Request #4371: Convert Arr::extract to work with paths not keys
- See https://github.com/kohana/core/pull/189
-
02:24 am Core Revision cad88a97: Converting method Arr::extract to work with paths not keys. Fixes #4371
-
02:20 am Feature Request #4371 (Closed): Convert Arr::extract to work with paths not keys
- See https://github.com/kohana/core/pull/173
- 02:16 am Revision 4bcf4978: Update submodules
- 02:16 am Revision c59950d3: Update submodules
- 02:16 am Revision 13e54b27: Update submodules
-
02:15 am Core Revision eedefa15: Add additional irregular pluralizations to inflector config. Remove entries ha...
- Adds:
- appendix
- cactus
- calf
- crisis
- criterion
- curriculum
- diagnosis
- elf
- ellipsis
- foot
- hoof
- hypot... -
02:15 am Core Revision 03a4af58: Add additional irregular pluralizations to inflector config. Remove entries ha...
- Adds:
- appendix
- cactus
- calf
- crisis
- criterion
- curriculum
- diagnosis
- elf
- ellipsis
- foot
- hoof
- hypot... -
02:13 am Core Revision a0b63485: Merge pull request #177 from jordanthomas/3.1/develop
- Add additional irregular pluralizations to inflector config
-
02:10 am Feature Request #4322 (Assigned): More irregular pluralizations
- 02:00 am Revision fe4fce49: Update submodules
-
02:00 am Feature Request #3178 (Closed): Kohana Exception's hide $previous (PHP 5.3)
- Applied in changeset commit:e36c698f50668466c517814eb4d911835809c8f9.
-
01:57 am Revision c8eb139d: Update the minimum PHP version required to 5.3.3.
- PHP 5.3.3 is available on RHEL/CentOS 5 and Ubuntu Lucid (10.04 LTS)
-
01:52 am ORM Revision 641b0150: Fixes #3178 - "Kohana Exception's hide $previous".
- First PHP 5.2 compatibility break.
-
01:50 am Core Revision e36c698f: Fixes #3178 - "Kohana Exception's hide $previous".
- First PHP 5.2 compatibility break.
-
01:37 am Feature Request #4271 (Closed): Controller action execution wrapper
-
01:36 am Core Revision dc43fd37: Merge pull request #188 from kohana/3.3/feature/4271-ActionWrapper
- Merge pull request for #4271
-
01:35 am Core Revision 6b7ae2a6: Update action wrapper per feedback. Refs #4271
-
01:30 am Core Revision 56dd060c: Update action wrapper per feedback. Refs #4271
-
01:30 am Core Revision 72258b72: Add a action execution wrapper. Refs #4271
-
12:32 am ORM Feature Request #3413 (Closed): Multi primary keys / foreign keys in ORM
- We aren't going to include this in ORM anytime soon. In the future we can create a new issue if needed for this.
12/26/2011
-
10:50 pm Feature Request #4370: Routing defaults and conventions
- I agree, using the name to set the "defaults" sounds like way too much magic. I think this would be handled better by...
12/24/2011
-
08:54 pm Feature Request #4369: Actions' return should be passed to the after method
- The "why not" is code clarity. We need good reasons to add this functionality and it seems we are having trouble find...
-
08:48 pm Feature Request #4370: Routing defaults and conventions
- I'm not sure how I feel about this. I don't think the route names should be linked to the defaults. If anything shoul...
-
08:43 pm Feature Request #4370: Routing defaults and conventions
- Another thought: routes should be able to inherit defaults from previously defined routes;...
-
11:58 am Feature Request #4370: Routing defaults and conventions
- Additionally, default Routes' controller can be "detected" based on the Route name in case it doesn't contain the '::...
12/23/2011
-
03:19 pm Bug Report #4116: Route::uri() should NOT use parameter from $params argument if value is the sam...
- route : 'article/<id>(/<action>)' , result: 'article/show/100' , why not 'article/100/show' ?
12/22/2011
-
09:02 pm Feature Request #4369: Actions' return should be passed to the after method
- The thing is: I don't see why not? There is practically no benefit of type-hinting Response to the after() method whe...
-
05:15 pm Feature Request #4369: Actions' return should be passed to the after method
- I agree with Jeremy and Lorenzo, it seems like this just makes the code more complicated and provides no real benefit...
-
03:27 pm Feature Request #4369: Actions' return should be passed to the after method
- This doesn't sound all that useful to me. What is the benefit of this over just storing the information in a property...
-
03:14 pm Feature Request #4369: Actions' return should be passed to the after method
- My problem with it is you'd have to always return the same kind of thing from every controller action that shares the...
-
02:59 pm Feature Request #4370: Routing defaults and conventions
- This commit can be used as a guideline (although there's an assignment fail in Route::set(), line 1)
https://githu... -
01:58 pm Feature Request #4370: Routing defaults and conventions
- I should also mention that these "detected" defaults probably shouldn't be defined in the $_defaults array but $_dete...
-
01:53 pm Feature Request #4370 (New): Routing defaults and conventions
- Current route naming can be improved so that the defaults are defined implicitly. Example:...
-
01:40 pm Feature Request #4369: Actions' return should be passed to the after method
- Jeremy Bush wrote:
> If we were to do this, I'd prefer that controllers always return a response instance. Then the ... -
12:29 pm Feature Request #4369: Actions' return should be passed to the after method
- If we were to do this, I'd prefer that controllers always return a response instance. Then the after() method paramet...
-
01:19 am Feature Request #4369: Actions' return should be passed to the after method
- Below is my current implementation, maybe there is a better solution?
https://github.com/kemo/core/commit/2cb520f6...
12/21/2011
-
10:35 pm Bug Report #4365 (Needs Test): Validation does not check message type
- It is possible to write a test for this, but PHPUnit is giving me crap and I'm not going to fight with it.
- 09:46 pm Revision 49811927: Update submodules
-
09:45 pm Bug Report #4344 (Closed): Response::send_file determines mime type incorrectly
- Applied in changeset commit:e6ed6170161e796cbe9b06903f66194d86ab0100.
-
09:45 pm Bug Report #4365 (Closed): Validation does not check message type
- Applied in changeset commit:fe38fe9d426a0d6ac608e63bc0b6e7d71a76fda4.
-
09:43 pm Core Revision cbd340ba: Merge pull request #186 from shadowhand/3.2/issue/4365-validation-message-type...
- Check message type in Validation::errors(), fixes #4365
-
09:42 pm Bug Report #4365 (Needs Test): Validation does not check message type
- Fixed by https://github.com/kohana/core/commit/cbd340ba0f6c2668c6adfbc43ab7c2e4e2bfb7f3
-
09:39 pm Core Revision e6ed6170: Merge pull request #183 from stillman/3.2/develop
- Send the correct mime type when sending files, fixes #4344
-
09:39 pm Bug Report #4344 (Needs Test): Response::send_file determines mime type incorrectly
- Fixed by https://github.com/kohana/core/commit/e6ed6170161e796cbe9b06903f66194d86ab0100
I don't know if this is te... -
01:25 am Feature Request #4369 (Assigned): Actions' return should be passed to the after method
-
12:12 am Feature Request #4369 (Assigned): Actions' return should be passed to the after method
- Request_Client_Internal should pass the actions' return to the after method as parameter.
This can be really usefu...
12/19/2011
-
09:09 pm Bug Report #4285 (Closed): $params variable not used
- This was fixed in https://github.com/kohana/core/commit/d8a36f6fb63250963aa3834dd4d0f62167fc8bc1
12/17/2011
-
04:03 pm Bug Report #4367: Validation not_empty on all fields
- I've just taken a look in the validation class and on line 205 in the method rule there is a check on whether a rule ...
-
03:55 pm Bug Report #4367 (New): Validation not_empty on all fields
- When applying the rule "non_empty" on all fields and supplying no more rules for any/some fields to the validation ob...
12/16/2011
-
12:03 am Bug Report #4365: Validation does not check message type
- Pull request opened https://github.com/kohana/core/pull/186
12/15/2011
-
11:54 pm Core Revision fe38fe9d: Check the type of $message in Validation::errors() to prevent issues when a fi...
-
11:49 pm Bug Report #4365: Validation does not check message type
- The obvious solution is to simply check that the message is a string before attempting to use it.
-
11:49 pm Bug Report #4365 (Closed): Validation does not check message type
- If you have a field called "email" with a the "email" rule attached, it will trigger an error from @strtr()@ if you a...
-
08:42 am Feature Request #3024: A method to convert Database_Result object to an array of arrays
- Add a perfect path, PR "here":https://github.com/kohana/orm/pull/48
12/14/2011
-
07:09 pm Bug Report #4359: FILE_SECURITY should use "OR" instead of "or"
- Ok, Now I agree with you. We should update Kohana's conventions.
Thank you.
12/13/2011
-
06:09 pm Bug Report #4288: Redirect on HTTPS site does not function properly in 3.2.0
- Looks like it's fixed for 3.2.1, based on the following bug report:
http://dev.kohanaframework.org/issues/4135
He... -
11:49 am Cache Bug Report #4364 (New): Cache tests fail if memcache isn't running
- The memcache unit tests will fail if the memcache extension is available but there is no memcache server available on...
12/12/2011
- 08:59 pm Revision 2b9ad23b: Update submodules
-
08:22 pm UnitTest Bug Report #4363 (Closed): use_whitelist does not default to FALSE
- In @config/unittest.php@, @use_whitelist@ is set to @TRUE@ when the comment says it should default to @FALSE@:
<pr... - 08:18 pm Revision 7a09a29a: Update submodules
-
07:17 pm Auth Revision b2b19315: Removed reference to Kohana "3.0" from the guide
-
02:54 pm Revision 455386ec: Update Auth submodule
-
02:52 pm Auth Revision e1b4b95b: Merge pull request #12 from daveWid/3.2/develop
- Fixes #4362 - Adds basic userguide content.
Thanks @daveWid :) -
02:51 pm Auth Feature Request #4362 (Closed): Add Userguide
-
02:13 pm Auth Revision 521e3435: Integrating suggestions form the forum into the user guide.
-
02:10 pm Auth Feature Request #4362 (Closed): Add Userguide
- I forked the auth module https://github.com/daveWid/auth/tree/3.2/develop and filled out the userguide.
This ticke...
12/11/2011
-
08:22 pm Bug Report #4359: FILE_SECURITY should use "OR" instead of "or"
- As Dmitry pointed out, those are constants and they should be written all-caps anyways.
We don't write `foreach`,... -
09:30 am Bug Report #4361 (Feedback): Security issues on Kohana_Encrypt
- Hello,
I was looking at Kohana's encrypt library and I noticed few issues, and thought I should mention about them.
...
12/10/2011
-
07:26 pm ORM Bug Report #4185: _external array for Validation loads the incorrect file
- I also got bit by this bug and spent more time than I'd have liked to resolve it. The current 3.2 way of doing things...
-
06:16 pm Revision debda210: Update submodules
-
06:13 pm Userguide Revision b795e0f8: Removes text references (again??) to bluehawk's forks. Refs #3782
-
03:05 pm Bug Report #4359: FILE_SECURITY should use "OR" instead of "or"
- NULL, TRUE and FALSE are sort of constants. But AND and OR are pure operators therefore I agree with Kimal and think ...
-
02:39 pm Bug Report #4359: FILE_SECURITY should use "OR" instead of "or"
- Kemal Delalić, I understand your point of view.
I like uppercase style. What about NULL, TRUE, FALSE, AND ... ?
... -
01:05 pm Bug Report #4359: FILE_SECURITY should use "OR" instead of "or"
- This is correct, although lowercase looks way nicer - current convention makes you feel like screaming.
Maybe a bu... -
05:02 am Userguide Bug Report #4360 (New): Id is not contained in the link of TOC
- Links does not work in a case with the header which there are two or more same headers as one page, or does not conta...
-
01:00 am Feature Request #4001: Fully Support PSR-0 autoloading requirements
- Here's another place with PSR-0, in case more links break: https://github.com/php-fig/fig-standards/blob/master/accep...
12/09/2011
-
02:24 pm Bug Report #4359 (Closed): FILE_SECURITY should use "OR" instead of "or"
- FILE_SECURITY const (class Kohana_Core) should follow "Kohana's conventions and coding style":http://kohanaframework....
12/08/2011
-
10:09 am Userguide Bug Report #4358 (Closed): UG try use all files (not only php)
- userguide try use all files. It's problem, when it contains spaces.
MODULES\userguide\classes\kohana\kodoc.php line:...
12/07/2011
-
09:42 pm Feature Request #4357: Please return controller parameters
- Yes, you're right. I agree with you now. @Request::param()@ has support for default values too, and this is not a pro...
-
09:32 pm Bug Report #4288: Redirect on HTTPS site does not function properly in 3.2.0
- Looks like that did the trick, with a small modification. I changed this code block in system/classes/kohana/url.php...
-
07:50 pm Feature Request #4357: Please return controller parameters
- Dmitry T. wrote:
> > Dmitry how exactly do you reach that?
>
> Just like how it was before 3.2 :)
>
> Controll... -
02:44 pm Feature Request #4357: Please return controller parameters
- These won't be coming back. If you really feel like you need them, there's a fork button on github, and you can easil...
-
01:10 pm Feature Request #4357: Please return controller parameters
- The only real difference is how you access the action parameters. You should write your routes the same, and trying t...
-
09:36 am Feature Request #4357: Please return controller parameters
- > I mean why even have parameters when the @action_@ methods are only ever going to be called by the system?
First... -
09:22 am Feature Request #4357: Please return controller parameters
- > Dmitry how exactly do you reach that?
Just like how it was before 3.2 :)
Controller parameters help to write ...
12/06/2011
-
08:53 pm Auth Revision b229d585: Userguide reorganization and small copy editing.
-
08:52 pm Feature Request #4357: Please return controller parameters
- Dmitry T. wrote:
> Yes, it's when controller action is called with some parameters, eg.
> [...]
Dmitry how exact... -
05:19 pm Auth Revision c303a730: First crack at userguide documentation.
-
05:13 pm Auth Revision 3c0a94a9: Activating the userguide.
-
12:55 pm Feature Request #4357 (Closed): Please return controller parameters
- They likely won't be coming back. Feel free to continue to discuss it here though. They just don't fit into how Kohan...
-
12:02 pm Feature Request #4357: Please return controller parameters
- Yes, it's when controller action is called with some parameters, eg....
-
11:35 am Feature Request #4357: Please return controller parameters
- Controller parameters?
-
11:32 am Bug Report #4347: Route::cache() should append cached routes
- Kemal Delalić wrote:
> Don't worry about possible security flaws, I'm just curious if you see anything wrong with wh... -
11:00 am Feature Request #4357 (Closed): Please return controller parameters
- I really miss them :) If someone shares my opinion — please comment here
12/05/2011
-
06:55 pm Bug Report #4347: Route::cache() should append cached routes
- Steven G. wrote:
> Kemal Delalić wrote:
> > Steven G. wrote:
> > > Kemal Delalić wrote:
> > > > As the title says... -
03:39 pm UnitTest Bug Report #4248: Unable to unit-test with in-memory PDO databases
- I think the right way to resolve this is to implement a @PHPUnit_Extensions_Database_DB_IDatabaseConnection@ backed b...
-
02:21 pm Bug Report #4356 (Closed): Incorrect quotation of where values
- And what happens when your value you are searching for has a period in it? There's no good way to automatically detec...
-
01:49 pm Bug Report #4356 (Closed): Incorrect quotation of where values
- In a query like this:
db::select('*')
->from('table1', 'table2')
->where('table1.parent_id', '=', 'table2.id')...
12/04/2011
-
02:43 pm Feature Request #4262: Arr::rotate should be added to Arr class by default
- +1 for that, Arr::rotate needs to be added in Kohana v3.2.1
-
02:18 pm Bug Report #4355 (New): Validation failing when using alternative syntax for rules in Validation:...
- *Tested versions*:
- 3.1.x
- 3.2.x
*Steps to reproduce*:
Code:... -
04:12 am Database Bug Report #4341 (Closed): Inserting or updating records with oversize field value in MySQL doesn...
12/02/2011
-
09:21 pm UnitTest Revision 467c4627: Only assign filter to valid coverage object in Unittest_Testsuite
- Thanks to @namtabmai for picking this up
-
07:21 pm Feature Request #4354 (Assigned): Response should include the effective URL
- After a series of redirects, the request URL may no longer match the response URL. This is called the "effective URL"...
-
07:11 pm Feature Request #4353 (Closed): External Requests should support Location: redirects
- In curl, this is the @CURLOPT_FOLLOWLOCATION@ option. Something like:...
12/01/2011
-
05:28 pm ORM Bug Report #4352 (Closed): Array to string conversion Error
- Platform:
* Windows
* xampp
* PHP 5.3.8
* Apache/2.2.21 (Win32)
Having a basic Model that just extends the OR...
Also available in: Atom