Activity

From 12/21/2011 to 01/19/2012

01/19/2012

05:15 pm Feature Request #4412: HTML class and attributes
By default, XHTML strict mode is still enabled. This just starts opening the path towards HTML5 support. At this poin... Woody Gilk
05:11 pm Feature Request #4412: HTML class and attributes
So are we officially supporting html5 now? This seems to not be valid for xhtml, our supported version of html. Jeremy Bush
04:46 pm Revision e908b0e3: Update submodules
Kohana Jenkins
04:46 pm Feature Request #4412 (Needs Test): HTML class and attributes
Woody Gilk
04:45 pm Feature Request #4412 (Closed): HTML class and attributes
Applied in changeset commit:9cffcd9a50ae324241f28de22366181a1df38d66. Shadowhand -
04:43 pm Core Revision 9cffcd9a: Added HTML::$strict and modified HTML::attributes() accordingly, allows empty ...
Shadowhand -
04:37 pm Feature Request #4412 (Closed): HTML class and attributes
One of the changes in HTML5 is dropping the requirement that all HTML attributes have values. In HTML, this is perfec... Woody Gilk
01:43 pm Feature Request #4411 (New): Sessions with namespace
I think Kohana should use sessions with namespace, maybe something like ZF:
http://framework.zend.com/manual/en/...
Enrique Piatti
01:34 pm ORM Bug Report #4410 (Closed): has method with wrong documentation
The documentation for Orm::has says the return type is Database_Result, you should change it to "bool"
http://k...
Enrique Piatti
12:14 pm Proposals (Political/Workflow) #4409 (New): Maybe Kohana_Confg_Database should extend Config_Data...
Instead of Kohana_Config_Database_Writer ? Ruslan Sukhar

01/18/2012

01:38 pm Image Feature Request #4408 (New): Image library should be have a square function
It would be nice to be able to add "padding" to an image to make it square, providing a background color.
Eg:
140...
Dave Carlson
05:09 am Bug Report #4407 (New): ORM count_all()
The using the count_all() in the ORM Module it does not return the correct columns.
I have found the problem:
C:\...
Geo G

01/17/2012

02:39 pm Bug Report #3300 (Feedback): Cache Directory must be writable even with Caching disabled
What if we are on a read only filesystem? dp de
01:09 am Bug Report #4403 (Closed): i18n shortcut __($string, $values = array(), $lang = ('en-us')) ignore...
Jeremy Bush
12:16 am Revision f4fd3cfd: Update submodules
Kohana Jenkins
12:15 am ORM Bug Report #4406 (Closed): Belongs to relationships return the wrong record
Applied in changeset commit:bc56b3d42274013c61a2fcfda41c5545bf849697. Isaiah DeRose-Wilson
12:14 am ORM Revision bc56b3d4: Fixes #4406 - Make sure we check for NULL value before loading belongs to data.
Isaiah DeRose-Wilson
12:12 am ORM Bug Report #4406 (Closed): Belongs to relationships return the wrong record
When ORM loads "belongs to" relationships it runs @$model->where($col, '=', $val)->find()@ without making sure $val i... Isaiah DeRose-Wilson
12:12 am ORM Bug Report #4405 (Closed): Belongs to relationships return the wrong record
When ORM loads "belongs to" relationships it runs @$model->where($col, '=', $val)->find()@ without making sure $val i... Isaiah DeRose-Wilson

01/16/2012

09:42 pm ORM Bug Report #4404 (Assigned): Belongs to relationships return the wrong record
Isaiah DeRose-Wilson
09:25 pm ORM Bug Report #4404 (Closed): Belongs to relationships return the wrong record
When ORM loads "belongs to" relationships it runs @$model->where($col, '=', $val)->find()@ without making sure $val i... Isaiah DeRose-Wilson
08:40 pm Bug Report #4403: i18n shortcut __($string, $values = array(), $lang = ('en-us')) ignores the $la...
Please ignore/delete this, I posted to quickly.
I think I confused the source language with the target language. Was...
Mike Gustafsson
08:28 pm Bug Report #4403 (Closed): i18n shortcut __($string, $values = array(), $lang = ('en-us')) ignore...
Think the subject says it all, but here's the line I'm talking about:
https://github.com/kohana/core/blob/3.2/develo...
Mike Gustafsson
10:42 am Cache Bug Report #4364: Cache tests fail if memcache isn't running
I opened a "PR":https://github.com/kohana/cache/pull/21 surely this can land in 3.2? Chris Smith
10:27 am Database Feature Request #4384: Add Database Insert ignore()
Gah Gneh wrote:
> could, at least the @compile()@ function be decoupled, so I can call @parent::compile()@ without h...
Chris Smith
04:46 am Revision f45dee1c: Update submodules
Kohana Jenkins
04:46 am Revision 0a884558: Update submodules
Kohana Jenkins
04:43 am Core Revision 374419b1: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
04:43 am Core Revision 962c5f12: Merge pull request #203 from badsyntax/3.2/develop
Clean URLs tutorial update Woody Gilk

01/15/2012

03:02 am Core Revision 3f5e3e13: Updated the Clean URLs tutorial to include a short explanation of why the .hta...
Richard Willis
02:40 am Database Bug Report #4402 (Closed): Fatal Error after attaching Database_Config object
Isaiah DeRose-Wilson

01/14/2012

10:49 pm Database Bug Report #4402 (Closed): Fatal Error after attaching Database_Config object
h3. The problem
Here is a quick example:...
Ivan Brotkin
10:31 pm Bug Report #4401 (Closed): Config cache should be reset after new Config source attached
h3. The problem
For example, I have a Config_File attached by default:...
Ivan Brotkin
07:39 pm Feature Request #4209 (Feedback): Combine regex and callback functionality in Routes
Jeremy, it looks like this feature has basically been implemented by Woody (the filters: http://dev.kohanaframework.o... Lorenzo Pisani
04:24 pm Feature Request #4209: Combine regex and callback functionality in Routes
This is kind of related to: http://dev.kohanaframework.org/issues/3866 , it would be nice if both could be added in t... Kemal Delalic

01/13/2012

04:09 pm Bug Report #4194 (Feedback): Date::span() returns wrong values
More tests won't tell us anything we don't already know. The code needs to be modified in some way. Woody Gilk
04:08 pm Bug Report #4194: Date::span() returns wrong values
Well do you want it mostly accurate for most situations, or perfectly accurate for corner cases? Unfortunately, the m... Woody Gilk
03:45 pm Bug Report #4194 (Needs Test): Date::span() returns wrong values
Needs more unit tests. Jeremy Bush
03:39 pm Bug Report #4194: Date::span() returns wrong values
There's still a problem with this method as it's returning wtful data:... MichaƂ Matyas
09:55 am Bug Report #4400 (Assigned): Documentation Typos in Config class
There's a few small typos in the doc block comments in a couple of the Config classes/tests
Pull request: https://...
Paul Dixon

01/12/2012

07:38 pm Cache Feature Request #4024 (Closed): Redis driver
I don't think we want to support this in core. A third party module would be best. Jeremy Bush
06:18 pm Cache Feature Request #4024: Redis driver
Is the standard Redis PHP extension https://github.com/nicolasff/phpredis? I'd be willing to take a stab at it as lon... Logan Aube
11:42 am Bug Report #4399 (New): Seeding incorrect PRNG
The Encrypt class calls @mt_srand()@ to seed the PRNG when @MCRYPT_RAND@ is being used to generate an IV, however it ... Chris Smith
04:46 am Revision 5d49dd86: Update submodules
Kohana Jenkins
04:44 am Core Revision efda553d: Update docs regarding redirects including a note on potential changes before 3...
Kiall Mac Innes

01/11/2012

08:29 pm Feature Request #4398 (New): Preserve keys in Arr::pluck()
Like this:... Ivan Petropolsky
10:33 am Patch #4020: Stack traces for Fatal PHP errors
Thanks, I must have missed it somehow :) Marcus Cobden
07:47 am Revision d9efe13d: Update submodules
Kohana Jenkins
07:47 am Revision 27ccb97d: Update submodules
Kohana Jenkins
07:46 am Revision c9ee8087: Update submodules
Kohana Jenkins
07:45 am Database Bug Report #4033 (Closed): Configuration defaults
Applied in changeset commit:005ecf12b6a15a66b0d05412adfb54df7783de11. Chris Bandy
07:32 am Database Revision 25a7aa92: Merge branch '3.2/develop' into 3.3/develop
Chris Bandy
07:32 am Database Revision d7ce493a: Merge branch '3.1/develop' into 3.2/develop
Chris Bandy
07:32 am Revision bbea71aa: Update submodules
Kohana Jenkins
07:31 am Revision e155a3aa: Update submodules
Kohana Jenkins
07:31 am Database Revision 005ecf12: Ensure the table_prefix is assigned. Fixes #4033
Chris Bandy
07:31 am Revision 4d5824ac: Update submodules
Kohana Jenkins
07:30 am Database Feature Request #3963 (Closed): Db query docs: the term "prepared statements" is misleading.
Applied in changeset commit:f226b9139d1119c68c3a4b05426b0ff7ff5dcb41. Chris Bandy
07:17 am Database Revision 8e39e898: Merge branch '3.2/develop' into 3.3/develop
Chris Bandy
07:16 am Database Revision 49ee952a: Merge branch '3.1/develop' into 3.2/develop
Chris Bandy
07:16 am Database Revision f226b913: Use 'parameterized' rather than 'prepared' in docs. Fixes #3963
Chris Bandy

01/10/2012

11:02 pm Revision 106f6117: Update submodules
Kohana Jenkins
10:55 pm Feature Request #3141 (Closed): Config merging should treat non-associative array elelemts as unique
Kiall Mac Innes
10:54 pm Core Revision fa8f2182: Merge pull request #198 from kohana/3.3/issue/3141-merge-indexed-arrays
#3141 - Handle indexed arrays consistently in Arr::merge(). Fixes #3141. Kiall Mac Innes
09:47 pm Revision 3c67a143: Update submodules
Kohana Jenkins
09:46 pm Revision 7b60e925: Update submodules
Kohana Jenkins
09:46 pm Revision 7cbedb31: Update submodules
Kohana Jenkins
09:45 pm Bug Report #4397 (Closed): Broken links in core guide
Applied in changeset commit:2463efe93a65cb0223cbefeebe1eec596514e1a8. Woody Gilk
09:37 pm Core Revision 140a88d6: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
09:37 pm Core Revision 6f722f3b: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
09:37 pm Bug Report #4397 (Assigned): Broken links in core guide
Merged up to v3.2 and v3.3. Woody Gilk
09:34 pm Core Revision 2463efe9: Merge pull request #201 from mintbridge/3.1/issue/4397-guide-broken-links
Fixes #4397 Woody Gilk
09:03 pm Bug Report #4397: Broken links in core guide
Pull request at https://github.com/kohana/core/pull/200 Paul Dixon
08:38 pm Core Revision a3ac81ac: fixing broken links on the main guide page
Paul Dixon
08:00 pm Bug Report #4397 (Closed): Broken links in core guide
There are a few broken links in the guide for core. I'm correcting them now, pull request to follow Paul Dixon
07:47 pm Revision dc39fc8d: Update submodules
Kohana Jenkins
07:39 pm Core Revision 47132998: Follow up to f3425119c7b5cb1a7e49b92730d1c10c0415b155, reference HTTP_Header m...
Woody Gilk
07:34 pm Core Revision f3425119: Deprecated Request methods: accept_lang(), accept_encoding(), accept_type(), r...
Woody Gilk
07:15 pm Revision 07c91f7a: Update submodules
Kohana Jenkins
07:15 pm Feature Request #4383: append() and prepend() for View class
suppose I have this template:... Gah Gneh
07:15 pm Revision 4963bbc2: Update submodules
Kohana Jenkins
07:15 pm Revision a989baf8: Update submodules
Kohana Jenkins
07:13 pm UnitTest Revision 93e88bbb: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Database Revision bcb3515a: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Image Revision 87b7e783: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Codebench Revision 241226a6: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm ORM Revision 7ea060e0: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Auth Revision dc590e17: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Cache Revision 970ee406: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Userguide Revision c93e8d63: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:13 pm Core Revision 196f96cf: Merge branch 3.2/develop into 3.3/develop
Kiall Mac Innes
07:12 pm UnitTest Revision 5291551a: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Database Revision 45f900b0: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Codebench Revision 98aace38: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm ORM Revision 6be969a1: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Core Revision c2d22a90: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Userguide Revision 7c4baf17: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Cache Revision b42f9eec: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:12 pm Image Revision f077aa89: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
07:11 pm Auth Revision 135f4bf6: Merge branch '3.1/develop' into 3.2/develop
Kiall Mac Innes
07:07 pm Database Revision 87b3466b: Merge branch '3.1/develop' of http://github.com/kohana/database into 3.1/develop
Kiall Mac Innes
07:04 pm ORM Revision 5212e985: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Core Revision f0c2f80a: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Userguide Revision 159e5b8f: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm UnitTest Revision 4356acb9: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Auth Revision 7ad3e737: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Database Revision 4abc7035: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Codebench Revision df799d99: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Image Revision 47412f2e: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:04 pm Cache Revision af71caf2: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
07:02 pm Revision e34e08f5: Update submodules
Kohana Jenkins
07:01 pm Revision 39764f14: Update submodules
Kohana Jenkins
07:01 pm Revision 925dd293: Update submodules
Kohana Jenkins
07:00 pm Bug Report #4396 (Closed): Update @copyright notices to 2012
Applied in changeset commit:af7abfeb60e2d367d067443bdb47cb011baf358d. Kiall Mac Innes
06:58 pm Core Revision 1fcafa4b: Merge branch '3.3/develop' of http://github.com/kohana/core into 3.3/develop
Kiall Mac Innes
06:57 pm Core Revision f5f99b4e: Merge branch '3.2/develop' into 3.3/develop
Conflicts:
classes/kohana/http/cache.php
tests/kohana/request/client/CacheTest.php
Kiall Mac Innes
06:57 pm Core Revision 86d2a2cd: Merge branch 3.1/develop into 3.2/develop
Kiall Mac Innes
06:55 pm Bug Report #4396 (Closed): Update @copyright notices to 2012
Kiall Mac Innes
06:55 pm Core Revision af7abfeb: Update @copyright notices to 2012. Fixes #4396.
Kiall Mac Innes
06:44 pm Patch #4020: Stack traces for Fatal PHP errors
@Marcus Cobden - yes it did.
See: http://dev.kohanaframework.org/projects/kohana3-core/repository/revisions/039737...
Kiall Mac Innes
06:38 pm Database Feature Request #4384 (Feedback): Add Database Insert ignore()
could, at least the @compile()@ function be decoupled, so I can call @parent::compile()@ without having to manually c... Gah Gneh
06:32 pm Revision e3f6f040: Update submodules
Kohana Jenkins
06:30 pm Codebench Revision 6e4d4a36: Fixup CodeBench controller for $request->redirect() changes. Refs #4375.
Kiall Mac Innes
06:24 pm Userguide Revision a185e310: Update userguide controller for $response->check_cache() changes. Refs #4373
Kiall Mac Innes
06:13 pm Revision f281f66b: Update submodules
Kohana Jenkins
06:05 pm Bug Report #4319 (Closed): Kohana_Request::redirect() and HMVC
Kiall Mac Innes
06:05 pm Feature Request #4373 (Closed): Provide better isolation of requests/sub-requests
Kiall Mac Innes
06:04 pm Feature Request #4374 (Closed): Decouple Response object creation from the Request class..
Kiall Mac Innes
06:04 pm Feature Request #4375 (Closed): Remove redirect() from the Request class
Kiall Mac Innes
06:04 pm Feature Request #4377 (Closed): Introduce the notion of `HTTP_Exception_Expected` and `HTTP_Excep...
Kiall Mac Innes
06:02 pm Revision 36dbad1a: Update submodules
Kohana Jenkins
06:01 pm Core Revision 0c6854b0: Merge pull request #194 from kohana/3.3/feature/RequestResponseCleanup
Fixes #4377, #4375, #4374, #4373, #4319 Kiall Mac Innes
05:33 pm Core Revision 6bc6cf0a: Truncate rather than scrap the stack trace under PHPUnit. Refs #4373
Kiall Mac Innes
05:17 pm Cache Revision 45fa4375: Fixup HTTP_Cache for #4374
Kiall Mac Innes
05:07 pm Core Revision c6186dc0: Fixup Kohana_Request_Client_Internal test. Refs #4373
Kiall Mac Innes
05:06 pm Core Revision ca05ec91: Remove HTTPTest, It has no tests..
Kiall Mac Innes
05:04 pm Core Revision 7ce1a72e: Fixup Request_Client_External. Refs #4374.
Kiall Mac Innes
03:42 pm Core Revision 31226d0f: Merge branch '3.3/develop' into 3.3/feature/RequestResponseCleanup
Conflicts:
guide/kohana/menu.md
Kiall Mac Innes
01:14 pm Core Revision 24e4c3d7: Remove cli check from exception handler, remove exit calls. Refs #3989
Jeremy Bush
12:26 pm Bug Report #4313: Kohana_Session throws exception when session_start was already called
and it also could be useful to add some info to documentation about kohana_session. saying that kohana sessions shoul... Dmitry Selin
12:24 pm Bug Report #4313: Kohana_Session throws exception when session_start was already called
this "specific" situation will become more common, when people will begin to use more external libraries and classes ... Dmitry Selin
10:41 am Patch #4020: Stack traces for Fatal PHP errors
*bump*
Did the ini_set make it in?
(my last comment was sent when the mail queue had backed up)
Marcus Cobden
09:47 am Feature Request #3396: Move User Agent parser out of Request::user_agent()
How about @HTTP_Text@ or @Text_HTTP@ then? Korney Czukowski
07:41 am Bug Report #4016 (Feedback): Validation message for "matches" should say :param3 instead of :param2
You are correct, the original ticket is invalid. The issue is with the order of the fields in the rule definition:
...
Nano Documet
05:47 am Revision 4d438e7b: Update submodules
Kohana Jenkins
05:45 am Database Bug Report #4052 (Closed): Ignore empty parentheses in or_where_close() / and_where_close()
Applied in changeset commit:5173c52f728cad71cdb9d9be7384de220ff8c5f6. Chris Bandy
05:41 am Database Revision 5173c52f: Method to remove empty WHERE parentheses. Fixes #4052
Chris Bandy
05:32 am Revision f0c6c482: Update submodules
Kohana Jenkins
05:31 am Revision 90aac332: Update submodules
Kohana Jenkins
05:31 am Revision 9befdaca: Update submodules
Kohana Jenkins
05:30 am Database Bug Report #4394 (Closed): MySQL enum doesn't handle values with parentheses
Applied in changeset commit:7109723b97383d2594abc324627500a7a02fdd56. Chris Bandy
05:30 am Database Bug Report #4393 (Closed): MySQL enum doesn't handle values with parentheses
Applied in changeset commit:a7e8d984909d66c93403c056c38dcc4b1dbb2b07. Chris Bandy
05:25 am Database Revision 9b4d1151: Merge branch '3.2/develop' into 3.3/develop
Chris Bandy
05:23 am Bug Report #4313: Kohana_Session throws exception when session_start was already called
If you need sessions always running, then yes, you should always start it in boostrap. Your "bug" only applies to you... Woody Gilk
05:18 am Bug Report #4313: Kohana_Session throws exception when session_start was already called
in such case.. may be it would be better to automatically start session from bootstrap or some core class?
or have s...
Dmitry Selin
03:11 am Database Revision 7109723b: Merge branch '3.1/develop' into 3.2/develop. Fixes #4394
Chris Bandy
03:09 am Database Revision a7e8d984: MySQL: Handle ENUM values with parentheses. Fixes #4393
Chris Bandy
02:51 am Feature Request #3989: Make Minion official
The changes in #3931 should be reverted as part of this, and a new exception handler attached for CLI mode. Woody Gilk
02:23 am Bug Report #3931: Kohana_Exception::handler() doesn't exit with proper error codes
This should be changed as part of #3989. Jeremy Bush
12:37 am Bug Report #3931: Kohana_Exception::handler() doesn't exit with proper error codes
This is a regression. We used to call @exit@ in exception handlers, but doing so is broken behavior, as it prevents n... Woody Gilk

01/09/2012

11:33 pm Bug Report #4336 (Closed): Request/Response header support broken
I should have put more information into the original issue. Now I can't figure out how to replicate this.
Closing ...
Woody Gilk
11:22 pm Bug Report #4313: Kohana_Session throws exception when session_start was already called
Dmitry Selin wrote:
> the only way to make everything work is calling Session::Instance() prior to including faceboo...
Woody Gilk
11:21 pm Bug Report #4313: Kohana_Session throws exception when session_start was already called
Your suggested fix is not reliable at all. As I mentioned before, we _must_ use @session_set_cookie_params@ before st... Woody Gilk
09:58 pm Bug Report #4336: Request/Response header support broken
I assume you're referring to Kohana 3.1 as 3.2 does not parse headers in this way? Sam de Freyssinet
09:57 pm Bug Report #4315: Internal sub-request not receiving correct accept type
The @HTTP_Header@ class handles all of this encapsulated. Also helps if you use the _correct_ http headers! Sam de Freyssinet
09:15 pm Bug Report #4313: Kohana_Session throws exception when session_start was already called
hey, but i suggested fix .
with check of session_id()
so we can conditionally run session_start().
in such way eve...
Dmitry Selin
08:49 pm Bug Report #3900 (Assigned): Validation::check doesn't check errors added manually
Whoops, not fixed, but refs 0e363a9b9b9c9f7d30262106d934f1405bc36a33. Woody Gilk
08:48 pm Bug Report #3900 (Closed): Validation::check doesn't check errors added manually
This was fixed by 0e363a9b9b9c9f7d30262106d934f1405bc36a33. Woody Gilk
08:47 pm Revision 5abef0ad: Update submodules
Kohana Jenkins
08:46 pm Revision 673f907f: Update submodules
Kohana Jenkins
08:45 pm Feature Request #4283 (Closed): HTML::style improvement
Applied in changeset commit:1f76bf490f1d62d668a10579de3b21a290b5751f. Woody Gilk
08:45 pm Feature Request #3911 (Closed): Add mime type for .webm format to mime types config
Applied in changeset commit:324f0fb96006c8c37f555589446af98d929ed4ad. Woody Gilk
08:45 pm Userguide Feature Request #4298 (Closed): Show property defaults
Applied in changeset commit:19856ed612de85b77cee3d0cf946e7dd0a3b3fd7. Woody Gilk
08:44 pm Core Revision 3bed1cef: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
08:44 pm Feature Request #3911 (Assigned): Add mime type for .webm format to mime types config
Woody Gilk
08:44 pm Core Revision 324f0fb9: Added webm content type to config/mimes.php, fixes #3911
Woody Gilk
08:41 pm Bug Report #4016 (Closed): Validation message for "matches" should say :param3 instead of :param2
I'm 99% sure this is invalid. Please reopen if it is not. Woody Gilk
08:40 pm Feature Request #4255 (Closed): More strict URL Validation
Use a custom callback, I don't see a reason for this. Woody Gilk
08:39 pm OAuth Feature Request #4045 (Closed): Ability to add more options to the oAuth cURL call
Please open an issue at https://github.com/shadowhand/oauth, this module is no longer part of Kohana. Woody Gilk
08:38 pm Core Revision 1f76bf49: Allow "rel" attribute to be overloaded in HTML::style(), fixes #4283
Woody Gilk
08:38 pm Feature Request #4283 (Assigned): HTML::style improvement
Woody Gilk
08:34 pm Bug Report #4288 (Closed): Redirect on HTTPS site does not function properly in 3.2.0
Woody Gilk
08:33 pm Bug Report #4284 (Assigned): Syslog driver doesn't use $_syslog_levels
Woody Gilk
08:33 pm Userguide Revision 19856ed6: Show default class property values, fixes #4298
Woody Gilk
08:33 pm Userguide Feature Request #4298 (Assigned): Show property defaults
Woody Gilk
08:19 pm UnitTest Bug Report #4304 (Closed): Guide page incorrectly references application index.php instead of mod...
This was fixed by "bc9259ed76886278cd800e56c5b9596c28fd4ca4":https://github.com/kohana/unittest/commit/bc9259ed768862... Woody Gilk
08:18 pm Bug Report #4334 (Feedback): Proposed Upload::type change
I don't see why we should change the logic of this specific rule and none of the others. Woody Gilk
08:17 pm Bug Report #4315: Internal sub-request not receiving correct accept type
Committed a deprecation, as per Sam. Maybe we should do something similar to #3396 and make `Request::_parse_accept` ... Woody Gilk
08:17 pm Revision 6e048526: Update submodules
Kohana Jenkins
08:16 pm Revision 10fb076f: Update submodules
Kohana Jenkins
08:15 pm Bug Report #4351 (Closed): installation guide error
Applied in changeset commit:aa472ab4852143bef299412161562a640dbf3993. Woody Gilk
08:14 pm Core Revision dd823936: Deprecated Request::parse_accept(), refs #4315
Woody Gilk
08:10 pm Bug Report #4319 (Assigned): Kohana_Request::redirect() and HMVC
Yea, its implemented in a branch already.
I have a few hours tomorrow to try clean it all up...
Kiall Mac Innes
08:09 pm Bug Report #4306 (Closed): URL::base() fails to account for HTTPS under certain situations
Woody Gilk
08:06 pm Bug Report #4351: installation guide error
The upgrading page in 3.3 has not been updated for 3.2. This only fixes explicit references to version in the menu an... Woody Gilk
08:04 pm Bug Report #4351 (Assigned): installation guide error
Fixed and merged up to v3.3. Woody Gilk
08:03 pm Core Revision 3a01c55c: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
08:03 pm Core Revision aa472ab4: Remove version-specific references from guide install and menu files, fixes #4351
Woody Gilk
07:54 pm Bug Report #4313 (Closed): Kohana_Session throws exception when session_start was already called
Kohana uses @session_set_cookie_params@ and other functions before starting session that are required for things to w... Woody Gilk
07:51 pm Bug Report #4319 (Feedback): Kohana_Request::redirect() and HMVC
Kiall, does this fit into the Request/Response work you are doing for v3.3? Woody Gilk
07:50 pm Bug Report #4332 (Feedback): Please fix docblock
I think most docblocks have been fixed in recent versions. Do you have a list of methods that are incorrect? Woody Gilk
07:47 pm Bug Report #4347: Route::cache() should append cached routes
This targets v3.3 because it adds a new parameter to @Route::cache@. Woody Gilk
07:47 pm Revision 5a0f50ed: Update submodules
Kohana Jenkins
07:46 pm Core Revision 6033b757: Follow up to 73032a6db0770c68d69abc9635c2f159814deb25, rather than changing ex...
Woody Gilk
07:45 pm Bug Report #4347 (Closed): Route::cache() should append cached routes
Applied in changeset commit:73032a6db0770c68d69abc9635c2f159814deb25. Woody Gilk
07:32 pm Revision 1160f36d: Update submodules
Kohana Jenkins
07:31 pm Core Revision 73032a6d: Append, rather than replace, cached routes in Route::cache(). Fixes #4347
Woody Gilk
07:30 pm ORM Feature Request #4349 (Closed): Add has_any function or ORM
Applied in changeset commit:980c9da7dfd0a581d60dfa7c3d263b33b71d9b05. Jim K
07:26 pm ORM Feature Request #4349 (Assigned): Add has_any function or ORM
Woody Gilk
07:26 pm ORM Revision 980c9da7: Added ORM::has_any() for checking if a relationship exists, moved ORM::has() t...
Jim K
07:16 pm Feature Request #4350 (Closed): money and currency helper functions in Num
Currency display is very region/language/locale dependent, I don't think this is a good solution for a difficult prob... Woody Gilk
07:06 pm Feature Request #4383 (Feedback): append() and prepend() for View class
I'm not really sure what the use case for this would be. Can you provide a real-world example? Woody Gilk
06:05 pm Bug Report #4306: URL::base() fails to account for HTTPS under certain situations
Ohh, this is duplicated: http://dev.kohanaframework.org/issues/4135 Alejandro GarcĂ­a Iglesias
05:50 pm Bug Report #4306: URL::base() fails to account for HTTPS under certain situations
Same here, it returns a non-HTTPS URL with the addition of :443 port...
http://stackoverflow.com/questions/8792553/k...
Alejandro GarcĂ­a Iglesias
05:07 pm Bug Report #4365 (Closed): Validation does not check message type
Tests were added in 77847ce628c404f36b091cfd938eed627628b680. Woody Gilk
05:06 pm Database Feature Request #4384 (Closed): Add Database Insert ignore()
We don't support database-specific features.
BTW, have you considered copying the Insert class and making a @REPLA...
Woody Gilk
04:56 pm Feature Request #3396: Move User Agent parser out of Request::user_agent()
The point is to allow parsing of eg: user agent strings that have been stored elsewhere. This makes perfect sense. Ma... Woody Gilk
04:04 pm Database Bug Report #4394 (Closed): MySQL enum doesn't handle values with parentheses
bq. This field's Type looks like @enum('student','professional','retired','other (see description)')@.
@Kohana_Datab...
Chris Bandy
12:21 pm Feature Request #4376: Isolate PHP Superglobals for sub requests
No, we "isolate" them inside `query()` and `post()` methods. Pure isolation into the globals is damn hard (nearly imp... Jeremy Bush
12:19 pm Feature Request #3396: Move User Agent parser out of Request::user_agent()
I'm not sure I really agree with this. A user agent is specific to http (requests, specifically).
I think a better...
Jeremy Bush
12:00 pm Database Feature Request #3963: Db query docs: the term "prepared statements" is misleading.
Yeah, parameterized queries. Jeremy Bush
07:13 am Feature Request #4174: Add `Arr::values()`
Wrap it in @array_values@ then. Woody Gilk
07:05 am Feature Request #4174: Add `Arr::values()`
Woody Gilk wrote:
> We already have @Arr::extract@ which does the same thing.
Almost the same thing, `list()` doe...
Kemal Delalic
06:46 am Revision 4e206a67: Update submodules
Kohana Jenkins
06:46 am Feature Request #4376: Isolate PHP Superglobals for sub requests
Don't we already do this? Woody Gilk
06:46 am Revision 8d502517: Update submodules
Kohana Jenkins
06:46 am Revision a54ea0e7: Update submodules
Kohana Jenkins
06:45 am Bug Report #4361 (Feedback): Security issues on Kohana_Encrypt
Patches welcome. Woody Gilk
06:45 am Bug Report #3659 (Closed): Irregular Inflector class term
Applied in changeset commit:3b44190a9d70bbb69eb936ff59b98502b7113a01. Woody Gilk
06:45 am Database Feature Request #3963: Db query docs: the term "prepared statements" is misleading.
Parameterized Chris Bandy
06:35 am Database Bug Report #4393 (Assigned): MySQL enum doesn't handle values with parentheses
Woody Gilk
06:34 am Bug Report #3659 (Assigned): Irregular Inflector class term
Woody Gilk
06:31 am Core Revision c3f8ccbb: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
06:31 am Revision 4c19ef93: Update submodules
Kohana Jenkins
06:31 am Core Revision d9808dee: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
06:31 am Core Revision 3b44190a: Added "releases" to irregular inflector config, fixes #3659
Woody Gilk
06:31 am Revision 7078315a: Update submodules
Kohana Jenkins
06:30 am Bug Report #4359 (Closed): FILE_SECURITY should use "OR" instead of "or"
Applied in changeset commit:57c4566153e7e3cc57887479e59ec9d29ee1cbce. Woody Gilk
06:29 am UnitTest Bug Report #3814 (Closed): Not work with PHPUnit Releases: 3.5.12 (stable)
#4381 Fixes this for v3.3, previous versions will just have to suffer with PHPUnit inconsistency. Woody Gilk
06:26 am Bug Report #4359 (Assigned): FILE_SECURITY should use "OR" instead of "or"
Woody Gilk
06:26 am Database Bug Report #4393 (Closed): MySQL enum doesn't handle values with parentheses
My inserts didn't work until tracked this down:
I have a field in my database. This field's Type looks like "enum...
Alexey Serikov
06:24 am Core Revision 6ad162dc: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
06:23 am Core Revision 57c45661: Fixed missed CS "OR" value in Kohana::FILE_SECURITY, fixes #4359
Woody Gilk
06:20 am Feature Request #4174 (Closed): Add `Arr::values()`
We already have @Arr::extract@ which does the same thing. Woody Gilk
06:16 am Revision 10736933: Update submodules
Kohana Jenkins
06:16 am Bug Report #4207 (Closed): Kohana should enforce environment usage
Woody Gilk
06:15 am Bug Report #4200 (Closed): <controller> is case insensitive
This only applies to the "default" route that ships with Kohana. If you want to control casing, use proper routing. Woody Gilk
06:15 am Bug Report #4043 (Closed): Valid::range
Applied in changeset commit:23e1b0bc03f5457aa54a4a2b95a50b4c0313979a. Woody Gilk
06:06 am Feature Request #4026 (Closed): Add option for url-safe encryption
Just use "rawurlencode":http://php.net/rawurlencode on the encrypted string. Using "URL::query":http://kohanaframewor... Woody Gilk
06:03 am Core Revision 23e1b0bc: Added $step parameter to Valid::range(), fixes #4043
Woody Gilk
06:03 am Bug Report #4043 (Assigned): Valid::range
Woody Gilk
05:46 am Revision d4a083f8: Update submodules
Kohana Jenkins
05:45 am Bug Report #4194 (Closed): Date::span() returns wrong values
Applied in changeset commit:c9e8d0255548e6a84f2f8a7d0ad652525d77195f. Woody Gilk
05:44 am Bug Report #4194 (Assigned): Date::span() returns wrong values
Without a lot of effort, this can only be fixed in v3.3 (when we require PHP 5.3+). Woody Gilk
05:44 am Core Revision c9e8d025: Use date_diff() in Date::span() for calculating months, as not all months are ...
Woody Gilk
05:31 am Revision 1242bc66: Update submodules
Kohana Jenkins
05:30 am Feature Request #4158 (Closed): Request query/post methods should use Arr::path() rather than Arr...
Applied in changeset commit:b25d30f405e571fcae6f194fcefe5984d1d8a7e1. Woody Gilk
05:18 am Core Revision b25d30f4: Use Arr::path() instead of Arr::get() in Request::query() and Request::post(),...
Woody Gilk
05:17 am Revision 2e6ef468: Update submodules
Kohana Jenkins
05:16 am Feature Request #4158 (Assigned): Request query/post methods should use Arr::path() rather than A...
I take it back, this makes perfect sense and is much more convenient. Woody Gilk
05:15 am Feature Request #3872 (Closed): Make Database instance parameter in Database_Query_Builder_XXX::C...
Applied in changeset commit:8e2e3d08b11a9277011f7c95de490fd0791fe378. Woody Gilk
05:14 am Feature Request #4158 (Closed): Request query/post methods should use Arr::path() rather than Arr...
I don't think this is a good idea, as it applies a little too much magic to something that has to be as efficient and... Woody Gilk
05:06 am Database Revision 8e2e3d08: Modify the signature of Database_Query::compile(), do not require the $db para...
Woody Gilk
05:05 am Feature Request #3872 (Assigned): Make Database instance parameter in Database_Query_Builder_XXX:...
Woody Gilk
05:01 am Revision d072e431: Update submodules
Kohana Jenkins
05:01 am Revision b165d444: Update submodules
Kohana Jenkins
05:01 am Revision 7749616a: Update submodules
Kohana Jenkins
05:00 am Feature Request #3326 (Closed): Arr::flatten doesn't flatten like I expected it to
Applied in changeset commit:56aac4745299476163161f10057ea498564471be. Woody Gilk
04:58 am Feature Request #3497 (Closed): Allow a controller to query the name of the matched route
We already have @Route::name()@ and as Jeremy said, we have to support anonymous routes. Woody Gilk
04:55 am Feature Request #3326 (Assigned): Arr::flatten doesn't flatten like I expected it to
Woody Gilk
04:53 am Core Revision d8fcaae7: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
04:53 am Core Revision 6b11df25: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
04:53 am Core Revision 56aac474: Use array_merge() instead of += in Arr::flatten(), which causes issues when fl...
Woody Gilk
04:52 am Core Revision b350db6e: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
04:46 am Revision ed1f2917: Update submodules
Kohana Jenkins
04:45 am Feature Request #3396 (Closed): Move User Agent parser out of Request::user_agent()
Applied in changeset commit:3c732353ff55c859c70737663e60880b51fc2b24. Woody Gilk
04:42 am Core Revision 3c732353: Moved Request::user_agent() to Text::user_agent(), user agent string can now b...
Woody Gilk
04:42 am Feature Request #3396 (Assigned): Move User Agent parser out of Request::user_agent()
Woody Gilk
04:31 am Revision a284ee0d: Update submodules
Kohana Jenkins
04:31 am Revision 2e86d40f: Update submodules
Kohana Jenkins
04:28 am Core Revision 160011f2: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
04:28 am Core Revision 77847ce6: Added tests for fe38fe9d426a0d6ac608e63bc0b6e7d71a76fda4, refs #4365
Woody Gilk
04:05 am Feature Request #2529 (Closed): HMVC request with array values
Woody Gilk
04:05 am Feature Request #2312 (Closed): Optional third parameter for Session::get() to set the session ke...
This would be confusing behavior; and I don't see a good use case for this. Woody Gilk
04:02 am Feature Request #2750 (Closed): Add GUID support
I created a "UUID module":https://github.com/shadowhand/uuid a while ago. This doesn't need to be added to Kohana core. Woody Gilk
04:01 am Revision a230b15b: Update submodules
Kohana Jenkins
04:01 am Revision 3fcd3909: Update submodules
Kohana Jenkins
04:01 am Revision a67440e7: Update submodules
Kohana Jenkins
04:01 am Userguide Revision 7febaf78: Merge branch '3.1/develop' of http://github.com/kohana/userguide into 3.1/develop
Kohana Jenkins
04:00 am Userguide Bug Report #4358 (Closed): UG try use all files (not only php)
Applied in changeset commit:8f596ed3456f61796d6e06784792c70d4531c553. Woody Gilk
03:53 am Userguide Bug Report #4358 (Assigned): UG try use all files (not only php)
Fixed in 8f596ed3456f61796d6e06784792c70d4531c553 and merged up to 3.2 and 3.3. Woody Gilk
03:53 am Userguide Revision d6910174: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
03:53 am Userguide Revision 60792e8f: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
03:53 am Userguide Revision 8f596ed3: Apply extension checks to Kodoc::classes(), fixes #4358
Woody Gilk
03:52 am Userguide Revision 267d8f55: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
03:51 am Userguide Revision e9791f49: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
03:31 am Revision 8522dd24: Update submodules
Kohana Jenkins
03:31 am Revision 37ffd318: Update submodules
Kohana Jenkins
03:31 am Revision e3f6da83: Update submodules
Kohana Jenkins
03:28 am Database Feature Request #3963: Db query docs: the term "prepared statements" is misleading.
Does anyone have a suggestion for a better name? Woody Gilk
03:24 am Database Patch #4133 (Closed): Error in documentation
Fixed by 88d83b7b7aa0f5d318e4d7b98f7fda9c8ec44c34. Woody Gilk
03:22 am Database Revision 49c9ddb2: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
03:22 am Database Revision a51b24d1: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
03:21 am Database Revision 88d83b7b: Calling Kohana::debug((string) $query)
throws an Exception: ErrorException [ Fatal Error ]: Call to undefined method Kohana::debug()
This code works.
Signe...
moshe-kaplan
03:16 am Revision 390956f7: Update submodules
Kohana Jenkins
03:16 am Revision 9745d15d: Update submodules
Kohana Jenkins
03:16 am Revision 3173fdb9: Update submodules
Kohana Jenkins
03:08 am Image Patch #3970 (Closed): Userguide for Image module
This was merged in https://github.com/kohana/image/commit/a8885520a7c13455d1c0fbc56b30e0c128547559 and has been merge... Woody Gilk
03:03 am Image Revision 2c84a8a7: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
03:02 am Image Revision d324eed8: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
03:02 am Image Revision a8885520: Merge remote-tracking branch 'lysender/3.1/dev-lysender' into 3.1/develop
Woody Gilk

01/08/2012

11:43 am Cache Bug Report #4392: Garbage collection in Kohana_Cache_File is broken
Please see: https://github.com/kohana/cache/pull/20
PS: Isn't it a little schizophrenic to have everything both he...
Vit Brunner
11:24 am Cache Bug Report #4392 (New): Garbage collection in Kohana_Cache_File is broken
As per docs, the gc is supposed to clear *expired* entries. Kohana_Cache_File::garbage_collect() currently clears all... Vit Brunner
06:13 am Core Revision acf1a5e4: Clean up whitespace and comments for Request::files()
Woody Gilk
06:13 am Core Revision 24105dda: Added Request_Client_Stream::encode_header_param(), applies quoted printable e...
Woody Gilk
01:42 am Feature Request #4391 (Closed): Themes support
This isn't something that belongs in a developer framework. Isaiah DeRose-Wilson

01/07/2012

06:22 pm Feature Request #4391 (Closed): Themes support
Please add theme support, it is very useful function for different developers and different kinds of project. Yaroslav Losev
05:12 pm Bug Report #4389: Change getters/setters behavior
Sorry, target version should be 3.3 Dmitry T.
04:46 pm Revision 31a39ae3: Update submodules
Kohana Jenkins
04:46 pm Revision 4b19cbaf: Update submodules
Kohana Jenkins
04:44 pm Core Revision 9c58f38a: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
04:44 pm Core Revision b9729110: Using closure at validation rule. Change comments and userguide
Sergey Loguntsov
04:25 pm Feature Request #4370: Routing defaults and conventions
Lorenzo Pisani wrote:
> I'm not sure how I feel about this. I don't think the route names should be linked to the de...
Kemal Delalic
03:49 pm Feature Request #4210: Allow different actions for different request methods
I believe Woody is working on this for 3.3? Kiall Mac Innes
03:26 pm Bug Report #4389: Change getters/setters behavior
The other option is to separate getters and setters (@Request::get_query()@ and @Request::set_query()@) Dmitry T.
03:24 pm Bug Report #4389 (New): Change getters/setters behavior
Currently we have a little bug in getter-setter functions (Request::query for example). The current implementation lo... Dmitry T.
04:42 am Core Revision 835a334c: Clean up whitespace and comments for Request::files()
Woody Gilk
04:42 am Core Revision 5fc99466: Add $_FILES to the initial request using Request::files()
Woody Gilk
04:29 am Core Revision 31dfb6c6: Use addslashes() to escape header values that are placed inside of double quotes
Woody Gilk
04:29 am Core Revision 80d62553: Added Request_Client_Stream::quoted_printable_encode(), applies RFC 2045 (sect...
Woody Gilk
04:29 am Core Revision f770f49f: Fixed incorrect boundary placement in Request_Client_Stream
Woody Gilk
04:28 am Core Revision b50010ca: Added Request_Client::CRLF, replace all "\n" references in Request_Client_Stre...
Woody Gilk
04:28 am Core Revision 5f6b8177: Always set the proper Content-Type, even when no data is being sent
Woody Gilk
04:28 am Core Revision ad0bca2a: Fixed all request clients to properly handle POST data in all situations
Woody Gilk
04:28 am Core Revision 6fd1151b: Fixing broken test case, this is not functionally required
Woody Gilk
04:28 am Core Revision d4a19a71: Added file upload support to Request_Client_Stream
Woody Gilk
02:55 am Core Revision d56a3bd3: Do not set the body() to POST data in Request_Client_External::execute(), this...
Woody Gilk
02:55 am Core Revision 5cad3a04: Follow up to 36ff1d30f18ac681b4e37ebf76ec3f24f9636b5e, adds file upload suppor...
Woody Gilk
02:55 am Core Revision 0dbc4dbd: Added in the ability to upload files through the HTTP external client class wi...
Signed-off-by: Woody Gilk <[email protected]> Brian Greenacre
02:55 am Core Revision 55289056: Set the proper MIME type in Request_Client_HTTP when creating file uploads
Woody Gilk

01/06/2012

03:50 pm ORM Bug Report #4244: save() not assigning primary_key_value when id column isn't auto-increment
https://github.com/kohana/orm/pull/51 Chris Smith
03:36 pm ORM Revision e40fa17e: Store PK if it has been set on a created model, fixes #4244
Chris Smith
03:32 pm ORM Bug Report #4244: save() not assigning primary_key_value when id column isn't auto-increment
This causes problems if you are serializing models, when they reload the PK is NULL. Chris Smith
03:01 pm Feature Request #3141: Config merging should treat non-associative array elelemts as unique
I've opened a proper PR: https://github.com/kohana/core/pull/198 Chris Bandy

01/05/2012

11:07 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
@Isaiah thanks for the clarification - that makes sense.
I still think the actual vendoring in of the phpunit clas...
Andrew Coulton
06:04 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
@Andrew, I agree with your comment about using phpunit 3.6 for Kohana 3.3.x. One of the nice things about vendoring i... Isaiah DeRose-Wilson
05:19 pm Feature Request #4261 (Closed): Overwrite with custom options - system\classes\kohana\request\cli...
This is not valid, as all of these curl options must be controlled by the client. Upload functionality will be decide... Woody Gilk
05:16 pm Revision 219cf808: Update submodules
Kohana Jenkins
05:15 pm Feature Request #4388 (Closed): Route Filters / Callbacks
Applied in changeset commit:a282ef12619b64fd2fe4a53cd40d6ce5edc02fd6. Woody Gilk
05:10 pm Core Revision a282ef12: Merge pull request #196 from kohana/3.3/feature/4388-route-filters
Fixes #4388 Woody Gilk
05:03 pm Feature Request #4388: Route Filters / Callbacks
It looks like Redmine doesn't like my @git rebase@ tricks... getting duplicate commits attached here. Woody Gilk
05:01 pm Core Revision 45937d62: Added tests for Route::filter(), refs #4388
Woody Gilk
04:36 pm Core Revision 3b457891: Modified how filter return values are handled in Route::matches(), refs #4388
Woody Gilk
04:36 pm Core Revision af999fb7: Added Route::filter(), callback support for route matching, refs #4388
Woody Gilk
04:36 pm Revision 574a0660: Update submodules
Kohana Jenkins
04:35 pm Cache Revision 392139de: Accidently took the HTTP_Cache class from the wrong branch, fixing. Refs #4382.
Kiall Mac Innes
02:40 pm Core Revision 5819300d: Added Route::filter(), callback support for route matching. Refs #4388
Woody Gilk
02:37 pm Feature Request #4388 (Assigned): Route Filters / Callbacks
Woody Gilk
02:36 pm Feature Request #4388 (Closed): Route Filters / Callbacks
Being able to assign callbacks to routes and have them executed on the parameters during @Route::matches()@ would off... Woody Gilk
02:12 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
@Isaiah, not doubting you, but I just quickly ran a full set of the Kohana 3.2/master tests on PHPUnit 3.6.7 on one o... Andrew Coulton
12:15 pm Userguide Bug Report #4150: Translated messages should not rely on the default language being English
https://github.com/kohana/userguide/pull/34 Ernestas Lisauskas
11:11 am Bug Report #4147: Translated messages should not rely on the default language being English
https://github.com/kohana/core/pull/195
Two commits in the pull request are relevant. I can separate into differen...
Ernestas Lisauskas
08:52 am Feature Request #4387: add optional param "offset_fix" for Image::watermark()
I use the Image::watermark() to merge a few images.
If I use the negative value as the offset_x or offset_y, it wi...
SAN KAI LIAO
07:23 am Bug Report #4120: Fix __() to use default source language
https://github.com/kohana/core/pull/195
#4147 and #4150 must be done before this fix. I'll send pull requests.
Ernestas Lisauskas
07:06 am Feature Request #4387 (New): add optional param "offset_fix" for Image::watermark()
I use the Image::watermark() to marge a few images, but some of them has negative offset.
Image::watermark() will ...
SAN KAI LIAO
06:32 am Revision 4e3007a8: Update submodules
Kohana Jenkins
06:32 am Revision 5cbde965: Update submodules
Kohana Jenkins
06:30 am Bug Report #4012 (Closed): Arr::get should use array_key_exists instead of isset
Applied in changeset commit:76f6e4c51b5bb5d0bf03a74b20ae199cfbd43fd9. Kevin D
06:27 am Bug Report #4012: Arr::get should use array_key_exists instead of isset
Fix and tests in https://github.com/kohana/core/pull/190, committed. Woody Gilk
06:26 am Bug Report #4012 (Assigned): Arr::get should use array_key_exists instead of isset
Woody Gilk
06:26 am Core Revision 7dc2a8e3: Merge pull request #190 from Ikke/3.3/fix-4012
Fixes #4012 Woody Gilk
06:23 am Userguide Bug Report #3873 (Closed): change "Request::$instance" by "Request::$initial"
If this is still valid, please reopen it.
Are we still supporting 3.1?
Woody Gilk
06:15 am Bug Report #3902 (Closed): Date::formatted_time $timezone parameter overridden by timezone in $da...
Applied in changeset commit:09b8fc513d92aba0b83c2aceaff7748b1731196a. Anonymous
06:11 am Core Revision d5aaf925: Fixed all request clients to properly handle POST data in all situations
Woody Gilk
06:11 am Core Revision ff6d9ea9: Do not set the body() to POST data in Request_Client_External::execute(), this...
Woody Gilk
06:11 am Core Revision cc276b3f: Set the proper MIME type in Request_Client_HTTP when creating file uploads
Woody Gilk
06:11 am Core Revision b8f21b0e: Follow up to 36ff1d30f18ac681b4e37ebf76ec3f24f9636b5e, adds file upload suppor...
Woody Gilk
06:11 am Core Revision 8b174aad: Added in the ability to upload files through the HTTP external client class wi...
Signed-off-by: Woody Gilk <[email protected]> Brian Greenacre
06:11 am Core Revision 5fd1bea6: Added file upload support to Request_Client_Stream
Woody Gilk
06:11 am Core Revision 8257a343: Fixing broken test case, this is not functionally required
Woody Gilk
06:11 am Core Revision 08b70f9d: Always set the proper Content-Type, even when no data is being sent
Woody Gilk
06:09 am Bug Report #3902: Date::formatted_time $timezone parameter overridden by timezone in $datetime_str
A pull request was made https://github.com/kohana/core/pull/99 and has been committed. Woody Gilk
06:05 am Core Revision 111b0696: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
06:04 am Core Revision 09b8fc51: Make Date::formatted_time()'s timezone parameter work even if the input date/t...
Peter Cowburn

01/04/2012

08:16 pm ORM Bug Report #4386: order_by() causes ORM::count_all() to fail
Actually, my fix needs a fix too ;)... N Komay
08:00 pm ORM Bug Report #4386 (New): order_by() causes ORM::count_all() to fail
I have prepared ORM/QueryBuilder query to show paginated records on the page. I have set the @ORDER BY@ clause using ... N Komay
06:48 pm ORM Bug Report #4385 (New): ORM_Validation_Exception has_many bug
I think generate_errors in ORM_Validation_Exception has bug when adds new objects with has_many.
*It generates wro...
Tomek Rychlik
05:30 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
@Andrew, That only fixes one of the issues. It's hard to write tests that support multiple phpunit versions because o... Isaiah DeRose-Wilson
09:12 am Database Feature Request #4384 (Feedback): Add Database Insert ignore()
I'm using MYSQL, and sometimes I use the INSERT IGNORE so it won't trigger any exceptions on a duplicate, usually whe... Gah Gneh
07:34 am UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
Not sure why? It is v. hard to install 3.5, however I've found that once my pull at https://github.com/kohana/unittes... Andrew Coulton
12:23 am Feature Request #4383 (Feedback): append() and prepend() for View class
I've done it extending the core classes, but I would like to see it in next releases.
Basically, when doing @View:...
Gah Gneh

01/03/2012

10:31 pm Revision 422f4884: Update submodules
Kohana Jenkins
10:24 pm Core Revision 1ea4fe24: Merge branch '3.3/develop' into 3.3/feature/RequestResponseCleanup
Conflicts:
classes/kohana/http/cache.php
tests/kohana/request/client/CacheTest.php
Kiall Mac Innes
10:21 pm Cache Feature Request #4382 (Closed): Move the HTTP_Cache class to the Cache module
Kiall Mac Innes
10:21 pm Core Revision 18c7a895: Move HTTP_Cache class to the Cache module. Fixes #4382
Kiall Mac Innes
10:19 pm Cache Feature Request #4382 (Closed): Move the HTTP_Cache class to the Cache module
Move the HTTP_Cache class to the Cache module. Kiall Mac Innes
10:19 pm Cache Revision 8089de35: Move HTTP_Cache class to the Cache module. Fixes #4382
Kiall Mac Innes
10:01 pm Revision c80532a3: Update submodules
Kohana Jenkins
09:54 pm UnitTest Revision 164b4fbb: Vendoring PHPUnit 3.5. Refs #4381.
Kiall Mac Innes
09:52 pm UnitTest Feature Request #4381 (Closed): Vendor PHPUnit 3.5 and its dependencies
Vendor PHPUnit 3.5 and its dependencies as it is next to impossible to install now that 3.6 is out... Kiall Mac Innes
09:01 pm UnitTest Feature Request #4323: Support PHPUnit 3.6
See also: https://github.com/kohana/unittest/tree/3.2/bugfix/4380-codecoverage-1.1 Woody Gilk
09:00 pm Bug Report #4380: PHPUnit 3.6 / CodeCoverage 1.1
Locking in a specific version is definitely a good idea, but we absolutely must provide proper @pear install ...@ ins... Woody Gilk
07:46 pm Bug Report #4380: PHPUnit 3.6 / CodeCoverage 1.1
We talked about this in -elite a few weeks ago. IMO, the unit test module should only be supported for running kohana... Jeremy Bush
07:35 pm Core Revision 8600a476: Fixed all request clients to properly handle POST data in all situations
Woody Gilk
07:02 pm Bug Report #4380 (Closed): PHPUnit 3.6 / CodeCoverage 1.1
It looks like this is the same as #4323. We need to decide what phpunit versions we support in each Kohana version. I... Isaiah DeRose-Wilson
05:33 pm Bug Report #4380: PHPUnit 3.6 / CodeCoverage 1.1
Also committed patch to a new branch for this: https://github.com/kohana/unittest/tree/3.2/bugfix/4380-codecoverage-1.1 Woody Gilk
05:32 pm UnitTest Revision a0339511: Fixing errors with CodeCoverage 1.1 (PHPUnit 3.6), but does not handle CC inje...
Woody Gilk
05:30 pm Bug Report #4380: PHPUnit 3.6 / CodeCoverage 1.1
I'm attaching my patch that prevents the error from happening, but does not actually perform the CodeCoverage injection. Woody Gilk
05:28 pm Bug Report #4380 (Closed): PHPUnit 3.6 / CodeCoverage 1.1
PHPUnit 3.6 uses CodeCoverage 1.1, which has dropped all singleton support for CodeCoverage filters. This results in ... Woody Gilk
03:38 pm Core Revision 7af34d75: Remove calls to Request::create_response() from the tests. Refs #4374.
Kiall Mac Innes
02:59 pm Core Revision aa68cd6c: Remove tests that no longer apply.
Kiall Mac Innes
02:35 pm Core Revision c8c8c7fe: Merge branch '3.3/develop' into 3.3/feature/RequestResponseCleanup
Kiall Mac Innes
02:02 pm Core Revision ddb166d0: Remove reamining CLI test. Refs #3989
Kiall Mac Innes
01:10 pm Patch #4020: Stack traces for Fatal PHP errors
Did the ini_set make it in? Marcus Cobden
12:34 pm Core Revision 85c00aa9: Remove all instances of `cli` from kohana-core, Refs #3989
Jeremy Bush
12:33 pm Feature Request #3989 (Assigned): Make Minion official
Because we are removing cli from core, minion should extend Kohana_Kohana_Exception to replace the functionality that... Jeremy Bush
07:49 am Core Revision 7b18250c: Always set the proper Content-Type, even when no data is being sent
Woody Gilk
07:42 am Core Revision 715209e6: Fixing broken test case, this is not functionally required
Woody Gilk
07:31 am Revision 79b0188d: Update submodules
Kohana Jenkins
07:26 am Bug Report #4337 (Feedback): Upload Files with Request
Completed pull request: https://github.com/kohana/core/pull/192 Woody Gilk
07:21 am Core Revision 193deb0e: Merge pull request #94 from simshaun/3.2/develop
3.2/develop Woody Gilk
07:19 am Core Revision c9eb58a4: Added file upload support to Request_Client_Stream
Woody Gilk
07:17 am Core Revision 62e786d2: Set the proper MIME type in Request_Client_HTTP when creating file uploads
Woody Gilk
06:11 am Core Revision 1c892459: Follow up to 36ff1d30f18ac681b4e37ebf76ec3f24f9636b5e, adds file upload suppor...
Woody Gilk
06:03 am Core Revision 7a7b4a19: Do not set the body() to POST data in Request_Client_External::execute(), this...
Woody Gilk
05:53 am Feature Request #4261: Overwrite with custom options - system\classes\kohana\request\client\curl.php
Actually this probably shouldn't be allowed, the client interface should support anything that overloading these opti... Woody Gilk
05:46 am Revision 92e9297b: Update submodules
Kohana Jenkins
05:43 am Core Revision 36ff1d30: Added in the ability to upload files through the HTTP external client class wi...
Signed-off-by: Woody Gilk <[email protected]> Brian Greenacre
05:40 am Bug Report #4337 (Assigned): Upload Files with Request
Pull request for HTTP client: https://github.com/kohana/core/pull/154 Woody Gilk
05:38 am Feature Request #4261: Overwrite with custom options - system\classes\kohana\request\client\curl.php
Sam, is there any reason this can't be merged? Woody Gilk
05:36 am Feature Request #4379 (Closed): Session Serialization
Fixed by https://github.com/kohana/core/commit/43804ad9b42b3e4a1bc9e0d2ddce8cc84373c15e Woody Gilk
05:35 am Core Revision 43804ad9: Decouple session data serialization
Parsha Pourkhomami
05:31 am Revision 69e588ab: Update submodules
Kohana Jenkins
05:30 am Feature Request #4379 (Assigned): Session Serialization
Woody Gilk
05:30 am Feature Request #4379 (Closed): Session Serialization
Allow session serialization to be overloaded independent of other functionality.
https://github.com/kohana/core/pu...
Woody Gilk
05:23 am Bug Report #4297 (Closed): Missing parameter in examples for Upload::Image()
Fixed by https://github.com/kohana/core/commit/c518ba39681e08cd0f3bf4902e84d846d7a25da0 Woody Gilk
05:23 am Core Revision c518ba39: Merge pull request #191 from Ikke/3.3/fix-4297
3.3/fix 4297 Woody Gilk
02:01 am Revision d54b0f5e: Update submodules
Kohana Jenkins
02:01 am Revision 407cc09a: Update submodules
Kohana Jenkins
02:01 am Revision 845ab3e3: Update submodules
Kohana Jenkins
01:53 am Userguide Bug Report #4046 (Closed): Route Exception after disabling the API Browser in \config\userguide.php
Fixed in:
- 3.1 - https://github.com/kohana/userguide/commit/1a9554e2c1bb4be650b31fcf008d7f25f438a6db
- 3.2 - htt...
Kiall Mac Innes
01:51 am Userguide Revision 616e1570: Display API Browser link on condition that userguide.api_browser is true. Othe...
Tom Rochette
01:51 am Userguide Revision 1a9554e2: Display API Browser link on condition that userguide.api_browser is true. Othe...
Tom Rochette
01:51 am Userguide Revision 7e792a76: Merge pull request #32 from tomzx/bugfix/hide_api_browser_link_if_api_browser_...
Display user documentation with disabled API access. Fixes #4046 Kiall Mac Innes
12:56 am Userguide Revision 7f64f3ce: Display API Browser link on condition that userguide.api_browser is true. Othe...
Tom Rochette

01/01/2012

05:21 am Bug Report #4297: Missing parameter in examples for Upload::Image()
Pull request: https://github.com/kohana/core/pull/191 Kevin D
05:16 am Core Revision 12f27427: Add missing argument in example for Upload::Image()
Kevin D
03:20 am Core Revision 10414485: Fix tab/space problem
Kevin D
02:44 am Core Revision 76f6e4c5: Arr::get() uses array_key_exists now in stead of isset. Fixes #4012
Kevin D
02:44 am Core Revision 0128655c: Change arr::get so that it fixes #4012 and still work with ArrayAccess
ArrayObjects with STD_PROP_LIST don't work together with
array_key_exists. These tests test if arr::get still works w...
Kevin D

12/31/2011

08:16 pm Revision 38f99b3f: Update submodules
Kohana Jenkins
08:16 pm Revision b56759b3: Update submodules
Kohana Jenkins
08:15 pm Image Feature Request #3584 (Closed): Method resize with argument Image::PRECISE
Applied in changeset commit:5348649bb77095ad792926394afc18d06be1ed7f. Max Kamashev
08:05 pm Revision 4290848b: Update submodules
Kohana Jenkins
08:04 pm Image Revision 323593a2: Cleanup CS Issues with previous commit. Refs #3584.
Kiall Mac Innes
08:04 pm Image Revision a079d389: Added a new argument to Image:: PRECISE for precise cutting and zooming.
Fixes #3584 Max Kamashev
08:04 pm Image Revision c68463ef: Cleanup CS Issues with previous commit. Refs #3584.
Kiall Mac Innes
08:04 pm Image Revision dd55da35: Added a new argument to Image:: PRECISE for precise cutting and zooming.
Fixes #3584 Max Kamashev
08:03 pm Image Revision 68eb0c2c: Cleanup CS Issues with previous commit. Refs #3584.
Kiall Mac Innes
08:02 pm Image Revision 5348649b: Added a new argument to Image:: PRECISE for precise cutting and zooming.
Fixes #3584 Max Kamashev
07:46 pm Revision ae9c4dc3: Update submodules
Kohana Jenkins
07:31 pm Revision d9b69088: Update submodules
Kohana Jenkins
07:31 pm Core Revision 02542a78: Fixing typo in Doc block for Valid::alpha_numeric() Test
Paul Dixon
07:30 pm Revision fa8ce067: Update submodules
Kohana Jenkins
07:30 pm Core Revision 881a9793: Merge pull request #146 from mintbridge/patch-1
Fixing typo in Doc block for Valid::alpha_numeric() Test Kiall Mac Innes
07:29 pm Patch #4231 (Closed): Adding the ability to specify the prefix for a controller action.
I have to agree with Sam on the change being superfluous.. I think its safe to close this ticket considering the comm... Kiall Mac Innes
07:22 pm Core Revision a7b5ba46: Fix bug introduced by 5b8159f fixing Arr::map callback syntax - fixes #4259
Andrew Coulton
07:21 pm Core Revision f3e64d01: Clarify syntax for passing array callbacks to Arr::map - fixes #4259
Andrew Coulton
07:16 pm Revision b5e4c188: Update submodules
Kohana Jenkins
07:15 pm Bug Report #4259 (Closed): Syntax for passing array callbacks to Arr::map is not clear
Applied in changeset commit:5b8159ff1ba2545574db1dc38582cb5dbaddf627. Anonymous
07:09 pm Core Revision 814b2b82: Merge pull request #160 from acoulton/bug/4259-syntax-for-arr-map
Clarify syntax for passing array callbacks to Arr::map. Fixes #4259. Kiall Mac Innes
06:53 pm Bug Report #4012: Arr::get should use array_key_exists instead of isset
This seems like an API change to me, hence the 3.3 change.
@Kevin D: Can you update the pull with the comments on ...
Kiall Mac Innes
06:49 pm Bug Report #4013 (Closed): Arr::get should use array_key_exists instead of isset
Kiall Mac Innes
06:40 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Might be related? https://github.com/kohana/core/pull/185 Kiall Mac Innes
05:56 pm Core Revision 03973720: Enable XDebug parameter collection in development. Refs #4020.
Kiall Mac Innes
05:55 pm Patch #4020: Stack traces for Fatal PHP errors
Never mind - I had a configuration error with nGinx which was causing the issue.
Adding the ini_set now.
Kiall Mac Innes
05:45 pm Patch #4020 (Closed): Stack traces for Fatal PHP errors
Applied in changeset commit:f86c9b877895e5d356284d197de94bc1581c670a. Kiall Mac Innes
05:43 pm Patch #4020 (Review): Stack traces for Fatal PHP errors
@Marcus Cobden:
for me, setting 'xdebug.collect_params' to anything other than 0 caused some weirdness (ie PHP faile...
Kiall Mac Innes
05:36 pm Patch #4020 (Closed): Stack traces for Fatal PHP errors
Kiall Mac Innes
05:33 pm Core Revision f86c9b87: Use XDebug to provide stack traces for fatal errors if available. Fixes #4020.
Kiall Mac Innes
05:33 pm Patch #4020 (Assigned): Stack traces for Fatal PHP errors
Kiall Mac Innes
05:08 pm Core Revision 15329a32: Fix environment comparison operator in docs. Refs #4377.
Kiall Mac Innes
05:01 pm Revision 9ac1dc96: Update submodules
Kohana Jenkins
05:00 pm Core Revision 15824cef: Merge remote-tracking branch 'origin/3.3/develop' into 3.3/feature/RequestResp...
Kiall Mac Innes
04:59 pm Core Revision 9743e427: Removed unused variable "Kohana::$log_errors"
Kiall Mac Innes
04:58 pm Core Revision b9c57376: Update occurrences of 3.2 in the docs to 3.3.
Kiall Mac Innes
04:57 pm Core Revision 76d51af3: Expand on docs for custom error pages. Refs #4377.
Kiall Mac Innes
04:17 pm Core Revision cc0beff3: Add class-level docblock to HTTP_Exception_Expected and HTTP_Exception_Redirec...
Kiall Mac Innes
03:45 pm Core Revision fd8e3af9: Fixup some bugs in the previous commits + Add a HTTP_Exception::request() method.
Kiall Mac Innes
03:22 pm Core Revision dca0a3c1: First stab at documentation for #4373, #4374, #4375 and #4377.
Refs #4373 / Refs #4374 / Refs #4375 / Refs #4377 Kiall Mac Innes
05:40 am Userguide Bug Report #4378 (Closed): Wrong toc anchors with cyrillic headers
Markdown uses headers like @# title {#anchor}@. This works, and correct anchor will be created ("link to this" object... Ivan Brotkin
05:11 am Core Revision f2eca6fa: Add HTTP_Exception_Redirect to house common code for redirections. Refs #4377
Kiall Mac Innes
04:18 am Core Revision a6ee21a8: General cleanup of the Kohana_Exception class. Refs #4377.
Kiall Mac Innes
03:17 am Core Revision 1440b6a2: Introduce the notion of `HTTP_Exception_Expected` and `HTTP_Exception::get_res...
Kiall Mac Innes
03:12 am Feature Request #4377 (Closed): Introduce the notion of `HTTP_Exception_Expected` and `HTTP_Excep...
From discussion on IRC related to redirects/304 Not Modified's and the interaction with the Controllers `after()` met... Kiall Mac Innes
01:43 am Core Revision 5b9bd8e1: Move Response::check_cache() to HTTP class. Refs #4373.
Kiall Mac Innes
01:17 am Core Revision 03b569ac: Fixup HTTP_Cache. Refs #4374.
Kiall Mac Innes
12:38 am Feature Request #4376 (New): Isolate PHP Superglobals for sub requests
Isolate PHP Superglobals for sub requests
Eg Inside a sub-request `$this->request->query()` == `$_GET` etc.
Kiall Mac Innes
12:19 am Feature Request #3897 (Closed): Controller actions return Response object
After discussing the changes, we've decided the Controller (rather than Controller actions) should return the Respons... Kiall Mac Innes
12:16 am Feature Request #4375: Remove redirect() from the Request class
Fixed in 669f3850608f823dd0966d003ce5e0053f77692a in the 3.3/feature/RequestResponseCleanup branch.
Should get merge...
Kiall Mac Innes
12:13 am Feature Request #4375 (Closed): Remove redirect() from the Request class
Remove `Request::redirect()` and move it to the `HTTP` class, with a helper method in `Controller` Kiall Mac Innes
12:11 am Core Revision b9b6f7db: Fixup exception handling from outside the initial Request_Client_Internal::exe...
Kiall Mac Innes

12/30/2011

11:58 pm Core Revision f5481e75: Remove stray debugging output.
Kiall Mac Innes
11:55 pm Core Revision 0b7471a2: Refactor Exception -> View conversion and reinstate correct exception handling...
Kiall Mac Innes
10:43 pm Core Revision 669f3850: Refs #4374 / Refs #4373 - Return a Response from Controllers and Cleanup Reque...
Kiall Mac Innes
10:42 pm Core Revision 7a63bbbc: Cleanup Request+Add HTTP tests
Kiall Mac Innes
10:24 pm Core Revision 623e8c7e: Reintroduce HTTP redirection.
Kiall Mac Innes
09:43 pm Feature Request #4374 (Closed): Decouple Response object creation from the Request class..
Decouple Response object creation from the Request class.. Kiall Mac Innes
09:43 pm Feature Request #4373 (Closed): Provide better isolation of requests/sub-requests
Provide better isolation of requests/sub-requests.
Eg throwing an Exception inside a sub-request should return a R...
Kiall Mac Innes
09:25 pm Revision ce4747ea: Reinstate Controller:: and Controller::
Kiall Mac Innes
09:25 pm Core Revision e3fee0f7: Reinstate Controller:: and Controller::
Kiall Mac Innes
09:08 pm Feature Request #3897: Controller actions return Response object
I actually (force) pushed some more changes after my comment to the branch.. The Controller controller action returni... Kiall Mac Innes
08:59 pm Revision 023a197d: Request/Response instances should be passed around as necessary.
Kiall Mac Innes
08:58 pm Core Revision 43d88a5f: Request/Response instances should be passed around as necessary.
Kiall Mac Innes
07:46 pm Revision 0709f1ee: Add minion module. Refs #3989.
Kiall Mac Innes
04:18 pm Feature Request #3989: Make Minion official
This should include removing all ideas of "cli" from kohana core: requests, controllers, routes, etc. Jeremy Bush
12:26 am Cache Feature Request #4100 (Closed): Memcache Timeout Should Be In Milliseconds
The timeout is is measured in seconds as that is the measurement accepted by the PHP memcache extension.
See http:...
Kiall Mac Innes

12/29/2011

03:01 pm Revision d61cab09: Update submodules
Kohana Jenkins
03:01 pm Revision cf765dfc: Update submodules
Kohana Jenkins
03:00 pm Database Bug Report #4078 (Closed): PDO connection set charset not universal
Applied in changeset commit:4c6f81daab68fdf40eda46c91905e936fbfbee07. Chris Bandy
03:00 pm Database Feature Request #4203 (Closed): Database profiling
Applied in changeset commit:b25c56e4e94c56b0f0c57c8e43cdd2c1d98f1244. Chris Bandy
03:00 pm Database Feature Request #4372 (Closed): Allow PDO options to be configured
Applied in changeset commit:d8adaca45a2df7be691107f2ac1990a23830b2f9. Chris Bandy
02:45 pm Database Revision 4c6f81da: PDO: Do not call SET NAMES during connect(). Fixes #4078
Chris Bandy
02:39 pm Database Revision f003d075: Merge branch '3.2/develop' into 3.3/develop
Chris Bandy
02:38 pm Database Revision d8adaca4: Allow PDO options to be configured. Fixes #4372
Chris Bandy
02:37 pm Database Feature Request #4372 (Closed): Allow PDO options to be configured
I want to provide the fourth parameter to "PDO::__construct()":http://www.php.net/manual/en/pdo.construct.php using d... Chris Bandy
02:16 pm Database Revision b25c56e4: Remove 'profiling' configuration. Fixes #4203
Chris Bandy
02:16 am Feature Request #4271: Controller action execution wrapper
A request should execute one action. multiple actions for one request? that makes the execution flows confuse. I thin... Yahasana .

12/28/2011

07:56 pm Database Feature Request #4203: Database profiling
I think the config parameter should probably just go away and @Database@ should read @Kohana::$profiling@ directly. Chris Bandy
05:37 pm Feature Request #3897: Controller actions return Response object
@Kiall, Maybe. I think your solution is a little different from the description of this issue. You are having the exe... Isaiah DeRose-Wilson
05:08 am Revision 7a38ed9b: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
Kiall Mac Innes
05:07 am Core Revision 3f0efc43: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
Kiall Mac Innes
04:52 am Feature Request #3897: Controller actions return Response object
I've added 2x "mock up" branches for this to both kohana/kohana and kohana/core.
Initial thoughts?
https://gith...
Kiall Mac Innes
04:46 am Revision b72ac8c8: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
Kiall Mac Innes
04:44 am Core Revision 2eaa8596: Refs #3897. Return a Response from Controllers and Cleanup Request Isolation /...
Kiall Mac Innes
04:03 am Feature Request #3897: Controller actions return Response object
In fact, This would help with fixing up some of the request isolation issues discussed as well..
Specifically with e...
Kiall Mac Innes
03:56 am Feature Request #3897: Controller actions return Response object
@Isaiah - Is this not a small step towards the general cleanup we discussed today that can easily be implemented? Kiall Mac Innes
03:45 am Feature Request #2693 (Closed): Re-introduce events.
I don't think this is ever going to happen. If it does a new issue can be created, this one has been around long enough! Isaiah DeRose-Wilson
03:16 am Revision 4a1242a8: Update submodules
Kohana Jenkins
03:15 am Revision 4e084bc8: Update submodules
Kohana Jenkins
03:06 am Core Revision 2c897839: Merge branch '3.2/develop' into 3.3/develop
Kiall Mac Innes
03:05 am Core Revision 42f5b7e1: Changed usage of $_POST to Request::post() in guide documentation. Fixes #4256.
Alex Cartwright
03:05 am Bug Report #4256 (Closed): Kohana documentation uses $_POST instead of Request::post()
Fixed in 3.2 and 3.3. Thanks! Kiall Mac Innes
03:01 am Revision 137d8057: Update submodules
Kohana Jenkins
03:00 am Revision 07d65070: Update submodules
Kohana Jenkins
03:00 am Patch #4251 (Closed): Fix error on deprecated get_magic_quotes_gpc() in PHP 5.4+
The other ticket's pull request was merged before I noticed this one! Either way, Fixed. Kiall Mac Innes
03:00 am Core Revision c17dab71: Fixes #4291, checks for PHP 5.4 before doing get_magic_quotes_gpc as it has be...
Jonathan Cremin
02:59 am Bug Report #4291: get_magic_quotes_gpc is deprecated in 5.4
I merged this before noticing the other pull.. Either way, done. Kiall Mac Innes
02:59 am Core Revision acf8ff0a: Fixes #4291, checks for PHP 5.4 before doing get_magic_quotes_gpc as it has be...
Jonathan Cremin
02:55 am Core Revision a94e45db: Merge pull request #189 from kohana/3.3/feature/4371-extract-paths
Fixes #4371 - Merge "Arr::extract() with paths" Kiall Mac Innes
02:48 am Core Revision 72567e22: Add tests for Arr::extract() via paths. Tests #4371.
Kiall Mac Innes
02:46 am Feature Request #4371 (Closed): Convert Arr::extract to work with paths not keys
Applied in changeset commit:cad88a9799e27e2150a846ee1726a96dc1d0e110. Zbigniew Motyka
02:44 am Core Revision 87131d09: Add tests for Arr::extract() via paths. Tests #4371.
Kiall Mac Innes
02:32 am Feature Request #4371: Convert Arr::extract to work with paths not keys
See https://github.com/kohana/core/pull/189 Kiall Mac Innes
02:24 am Core Revision cad88a97: Converting method Arr::extract to work with paths not keys. Fixes #4371
Zbigniew Motyka
02:20 am Feature Request #4371 (Closed): Convert Arr::extract to work with paths not keys
See https://github.com/kohana/core/pull/173 Kiall Mac Innes
02:16 am Revision 4bcf4978: Update submodules
Kohana Jenkins
02:16 am Revision c59950d3: Update submodules
Kohana Jenkins
02:16 am Revision 13e54b27: Update submodules
Kohana Jenkins
02:15 am Core Revision eedefa15: Add additional irregular pluralizations to inflector config. Remove entries ha...
Adds:
- appendix
- cactus
- calf
- crisis
- criterion
- curriculum
- diagnosis
- elf
- ellipsis
- foot
- hoof
- hypot...
Jordan Thomas
02:15 am Core Revision 03a4af58: Add additional irregular pluralizations to inflector config. Remove entries ha...
Adds:
- appendix
- cactus
- calf
- crisis
- criterion
- curriculum
- diagnosis
- elf
- ellipsis
- foot
- hoof
- hypot...
Jordan Thomas
02:13 am Core Revision a0b63485: Merge pull request #177 from jordanthomas/3.1/develop
Add additional irregular pluralizations to inflector config Kiall Mac Innes
02:10 am Feature Request #4322 (Assigned): More irregular pluralizations
Kiall Mac Innes
02:00 am Revision fe4fce49: Update submodules
Kohana Jenkins
02:00 am Feature Request #3178 (Closed): Kohana Exception's hide $previous (PHP 5.3)
Applied in changeset commit:e36c698f50668466c517814eb4d911835809c8f9. Kiall Mac Innes
01:57 am Revision c8eb139d: Update the minimum PHP version required to 5.3.3.
PHP 5.3.3 is available on RHEL/CentOS 5 and Ubuntu Lucid (10.04 LTS) Kiall Mac Innes
01:52 am ORM Revision 641b0150: Fixes #3178 - "Kohana Exception's hide $previous".
First PHP 5.2 compatibility break. Kiall Mac Innes
01:50 am Core Revision e36c698f: Fixes #3178 - "Kohana Exception's hide $previous".
First PHP 5.2 compatibility break. Kiall Mac Innes
01:37 am Feature Request #4271 (Closed): Controller action execution wrapper
Kiall Mac Innes
01:36 am Core Revision dc43fd37: Merge pull request #188 from kohana/3.3/feature/4271-ActionWrapper
Merge pull request for #4271 Kiall Mac Innes
01:35 am Core Revision 6b7ae2a6: Update action wrapper per feedback. Refs #4271
Kiall Mac Innes
01:30 am Core Revision 56dd060c: Update action wrapper per feedback. Refs #4271
Kiall Mac Innes
01:30 am Core Revision 72258b72: Add a action execution wrapper. Refs #4271
Kiall Mac Innes
12:32 am ORM Feature Request #3413 (Closed): Multi primary keys / foreign keys in ORM
We aren't going to include this in ORM anytime soon. In the future we can create a new issue if needed for this. Isaiah DeRose-Wilson

12/26/2011

10:50 pm Feature Request #4370: Routing defaults and conventions
I agree, using the name to set the "defaults" sounds like way too much magic. I think this would be handled better by... Isaiah DeRose-Wilson

12/24/2011

08:54 pm Feature Request #4369: Actions' return should be passed to the after method
The "why not" is code clarity. We need good reasons to add this functionality and it seems we are having trouble find... Lorenzo Pisani
08:48 pm Feature Request #4370: Routing defaults and conventions
I'm not sure how I feel about this. I don't think the route names should be linked to the defaults. If anything shoul... Lorenzo Pisani
08:43 pm Feature Request #4370: Routing defaults and conventions
Another thought: routes should be able to inherit defaults from previously defined routes;... Kemal Delalic
11:58 am Feature Request #4370: Routing defaults and conventions
Additionally, default Routes' controller can be "detected" based on the Route name in case it doesn't contain the '::... Kemal Delalic

12/23/2011

03:19 pm Bug Report #4116: Route::uri() should NOT use parameter from $params argument if value is the sam...
route : 'article/<id>(/<action>)' , result: 'article/show/100' , why not 'article/100/show' ? Ramil Rafikov

12/22/2011

09:02 pm Feature Request #4369: Actions' return should be passed to the after method
The thing is: I don't see why not? There is practically no benefit of type-hinting Response to the after() method whe... Kemal Delalic
05:15 pm Feature Request #4369: Actions' return should be passed to the after method
I agree with Jeremy and Lorenzo, it seems like this just makes the code more complicated and provides no real benefit... Isaiah DeRose-Wilson
03:27 pm Feature Request #4369: Actions' return should be passed to the after method
This doesn't sound all that useful to me. What is the benefit of this over just storing the information in a property... Lorenzo Pisani
03:14 pm Feature Request #4369: Actions' return should be passed to the after method
My problem with it is you'd have to always return the same kind of thing from every controller action that shares the... Jeremy Bush
02:59 pm Feature Request #4370: Routing defaults and conventions
This commit can be used as a guideline (although there's an assignment fail in Route::set(), line 1)
https://githu...
Kemal Delalic
01:58 pm Feature Request #4370: Routing defaults and conventions
I should also mention that these "detected" defaults probably shouldn't be defined in the $_defaults array but $_dete... Kemal Delalic
01:53 pm Feature Request #4370 (New): Routing defaults and conventions
Current route naming can be improved so that the defaults are defined implicitly. Example:... Kemal Delalic
01:40 pm Feature Request #4369: Actions' return should be passed to the after method
Jeremy Bush wrote:
> If we were to do this, I'd prefer that controllers always return a response instance. Then the ...
Kemal Delalic
12:29 pm Feature Request #4369: Actions' return should be passed to the after method
If we were to do this, I'd prefer that controllers always return a response instance. Then the after() method paramet... Jeremy Bush
01:19 am Feature Request #4369: Actions' return should be passed to the after method
Below is my current implementation, maybe there is a better solution?
https://github.com/kemo/core/commit/2cb520f6...
Kemal Delalic

12/21/2011

10:35 pm Bug Report #4365 (Needs Test): Validation does not check message type
It is possible to write a test for this, but PHPUnit is giving me crap and I'm not going to fight with it. Woody Gilk
09:46 pm Revision 49811927: Update submodules
Kohana Jenkins
09:45 pm Bug Report #4344 (Closed): Response::send_file determines mime type incorrectly
Applied in changeset commit:e6ed6170161e796cbe9b06903f66194d86ab0100. Woody Gilk
09:45 pm Bug Report #4365 (Closed): Validation does not check message type
Applied in changeset commit:fe38fe9d426a0d6ac608e63bc0b6e7d71a76fda4. Woody Gilk
09:43 pm Core Revision cbd340ba: Merge pull request #186 from shadowhand/3.2/issue/4365-validation-message-type...
Check message type in Validation::errors(), fixes #4365 Woody Gilk
09:42 pm Bug Report #4365 (Needs Test): Validation does not check message type
Fixed by https://github.com/kohana/core/commit/cbd340ba0f6c2668c6adfbc43ab7c2e4e2bfb7f3 Woody Gilk
09:39 pm Core Revision e6ed6170: Merge pull request #183 from stillman/3.2/develop
Send the correct mime type when sending files, fixes #4344 Woody Gilk
09:39 pm Bug Report #4344 (Needs Test): Response::send_file determines mime type incorrectly
Fixed by https://github.com/kohana/core/commit/e6ed6170161e796cbe9b06903f66194d86ab0100
I don't know if this is te...
Woody Gilk
01:25 am Feature Request #4369 (Assigned): Actions' return should be passed to the after method
Sam de Freyssinet
12:12 am Feature Request #4369 (Assigned): Actions' return should be passed to the after method
Request_Client_Internal should pass the actions' return to the after method as parameter.
This can be really usefu...
Kemal Delalic
« Previous
Next »
 

Also available in: Atom