Activity

From 02/04/2012 to 03/04/2012

03/04/2012

11:52 pm Core Revision 90bc6d68: Refactor Kohana_Request_ClientTest for more powerful mocking [refs #4353]
Implement a dummy controller and route to allow test cases to execute internal
requests and specify controller respon...
Andrew Coulton
11:43 pm ORM Patch #4466: Reconsider ORM::values() behavior and documentation
+1 for removing the default completely Kemal Delalic
11:33 pm ORM Patch #4466: Reconsider ORM::values() behavior and documentation
I am all for simply forcing the second parameter (just remove the default). I don't think a config property for the s... Lorenzo Pisani
11:31 pm ORM Patch #4466: Reconsider ORM::values() behavior and documentation
One more thing: created and updated columns should *never* be set with values() either. Kemal Delalic
11:17 pm ORM Patch #4466 (Closed): Reconsider ORM::values() behavior and documentation
After "Github getting hacked":https://github.com/rails/rails/commit/b83965785db1eec019edf1fc272b1aa393e6dc57 because ... Kemal Delalic
04:19 pm Feature Request #4353: External Requests should support Location: redirects
Following on from @kiall's "comment on the pull request":https://github.com/kohana/core/pull/223#issuecomment-4306118... Andrew Coulton
03:20 pm Core Revision 98451ebd: Resend request body when following redirects other than GET [refs #4353]
Andrew Coulton

03/03/2012

11:45 pm Feature Request #4353 (Feedback): External Requests should support Location: redirects
Kiall Mac Innes
11:45 pm Feature Request #4353 (Closed): External Requests should support Location: redirects
Applied in changeset commit:89f13fd72e25f082e8675e93058522c34f35612d. Andrew Coulton
11:34 pm Revision 2d24701e: Update system submodule
Kohana Jenkins
11:33 pm Core Revision a4ea8763: Merge pull request #223 from acoulton/3.3/feature/4353-FollowRedirects
Refs #4353 - strict_redirect option and tests Kiall Mac Innes
09:36 pm Core Revision 58eda473: Use property accessors rather than internal fields in Kohana_Request_Client fo...
Andrew Coulton
06:30 pm Bug Report #4284 (Closed): Syslog driver doesn't use $_syslog_levels
Applied in changeset commit:0c47ecbfd189d6a8aaf47bb1d2f497d501e2ca93. Woody Gilk
06:24 pm Revision eec116a4: Update system submodule
Kohana Jenkins
06:23 pm Core Revision d8a6e9a8: Merge branch '3.2/develop' into 3.3/develop
Conflicts:
classes/Kohana/Request.php
Woody Gilk
06:22 pm Revision 9afad974: Update system submodule
Kohana Jenkins
06:21 pm Core Revision 12837cb2: Merge pull request #205 from awellis13/3.2/develop
IDE comment fix Woody Gilk
06:21 pm Revision ad6721fb: Update system submodule
Kohana Jenkins
06:20 pm Core Revision 0c47ecbf: Merge pull request #209 from AlexC/3.2/develop
Cleanup syslog, fixes #4284 Woody Gilk
06:16 pm Revision df9b63e6: Update system submodule
Kohana Jenkins
06:15 pm Bug Report #4465 (Closed): Response::generate_etag() is failing to check body
Applied in changeset commit:01518e12cffe09604fb307632a76935529066800. Woody Gilk
06:15 pm Patch #4414 (Closed): Add Facebook user agent
Applied in changeset commit:01518e12cffe09604fb307632a76935529066800. Woody Gilk
06:15 pm Core Revision ead576e3: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
06:15 pm Revision 68e8a216: Update system submodule
Kohana Jenkins
06:14 pm Core Revision 03c4cbdf: Merge pull request #220 from deeceefar2/3.2/develop
fixed bug in Kohana::init() documentation Woody Gilk
06:11 pm Revision 52616129: Update system submodule
Kohana Jenkins
06:10 pm Core Revision bab30d60: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
06:09 pm Revision f1f80305: Update system submodule
Kohana Jenkins
06:09 pm Bug Report #4465 (Assigned): Response::generate_etag() is failing to check body
Woody Gilk
06:09 pm Patch #4414 (Assigned): Add Facebook user agent
Woody Gilk
06:09 pm Core Revision 01518e12: Merge pull request #228 from kemo/3.2/develop
fixes #4414, fixes #4465 Woody Gilk

03/02/2012

11:56 am Bug Report #4465: Response::generate_etag() is failing to check body
Pull request:
https://github.com/kohana/core/pull/228
Kemal Delalic
11:54 am Core Revision 05ea261f: Refs #4465: Response::generate_etag() is failing to check body
Kemal Delalic
11:52 am Patch #4414: Add Facebook user agent
Pull request: https://github.com/kohana/core/pull/228 Kemal Delalic
11:47 am Core Revision a21882ad: Refs #4414: Add Facebook user agent to robots config
Kemal Delalic
11:32 am Bug Report #4465 (Closed): Response::generate_etag() is failing to check body
This method is checking for Response::$_body being NULL, which is impossible - it's an empty string by default and it... Kemal Delalic
11:07 am Feature Request #4463: Response::body() shouldn't cast to string
I don't really think Request mix-up is a big deal here, it's a one line change in Request_Client_Internal (to make su... Kemal Delalic
07:08 am Bug Report #4464 (Closed): Kohana_Config_Database_Writer runs out of memory
Isaiah DeRose-Wilson
07:05 am Feature Request #4463 (Closed): Response::body() shouldn't cast to string
Changing this would break any view that needed information about the current request. A response body should be conve... Isaiah DeRose-Wilson

03/01/2012

09:39 pm Bug Report #4464: Kohana_Config_Database_Writer runs out of memory
This was already fixed here: http://dev.kohanaframework.org/issues/4316
Z Binzl
09:31 pm Bug Report #4464 (Closed): Kohana_Config_Database_Writer runs out of memory
attaching:
Kohana::$config->attach(new Kohana_Config_Database_Writer, false);
after the modules section on boot...
Ygam Retuta
05:35 pm Bug Report #4450 (Closed): Character support issue
If you are using a font in your IDE that does not support UTF-8, how can you possibly be using a UTF-8 enabled framew... Woody Gilk
05:34 pm Core Revision 13dd2386: Revert "Merge pull request #221 from thinkclay/3.3/develop"
This reverts commit 0055c46badbb846f4dd9fb80abada6749dc0c510, reversing
changes made to c5c45ac6a8b09ee5925c6f94df521...
Woody Gilk
05:33 pm Revision 21905ad7: Update system submodule
Kohana Jenkins
02:08 pm Feature Request #4463 (Closed): Response::body() shouldn't cast to string
I know the response body is always supposed to be a string, and it should stay that way - *when being rendered*.
The...
Kemal Delalic

02/29/2012

02:43 pm Feature Request #4462 (New): regenerate session ID
I would like to ask someone to add optional param for session ID regenerate, especialy for native (could be for datab... Dominik Chvila
12:45 pm Bug Report #4450: Character support issue
If you aren't using UTF-8, you are Doing It Wrong™. Jeremy Bush

02/28/2012

11:58 pm Bug Report #4450: Character support issue
I should address to, the htmlentities() helper definitely helps but it seems like a bandaid solution rather than a pr... Clay McIlrath
11:53 pm Bug Report #4450: Character support issue
I'm sorry but I really have to adamantly fight this one. The ellipsis character is not supported in all encoding and ... Clay McIlrath
02:28 am Feature Request #4375: Remove redirect() from the Request class
Agree with Dmitry
parameter should be (url, code)
dexcell -
01:27 am Feature Request #4353: External Requests should support Location: redirects
Just looking at this again, and the currently implemented solution also doesn't resend the request body with a POST/P... Andrew Coulton
01:13 am Userguide Feature Request #3486: Show what interfaces a class implements
While tidying up my other userguide pull I noticed this was also still floating - have created a pull at https://gith... Andrew Coulton
01:10 am Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Thanks! Merged into 3.3 Kiall Mac Innes
01:09 am Revision 4fc55f62: Update userguide submodule
Kohana Jenkins
01:09 am Userguide Feature Request #3529 (Closed): Configurable transparent extension prefixes in API browser
Kiall Mac Innes
01:08 am Userguide Revision b82317cb: Merge pull request #42 from acoulton/3.3/feature/3529-configurable-transparent...
Fixes #3529 - Configurable transparent class prefixes Kiall Mac Innes
12:36 am Userguide Revision 00e1569e: Hide base classes for both styles of transparent class naming - refs #3529
Now hides base classes for Module extends Module_Core and Foo extends
Module_Foo.
Additionally some coding standards...
Andrew Coulton

02/27/2012

11:33 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
Just picking up on a comment from @kiall in the forums (also see my comment on #4323 about making the test runner 3.6... Andrew Coulton
11:08 pm UnitTest Feature Request #4323: Support PHPUnit 3.6
Just bumped this ticket in the forum, and got the following from @kiall:
??#4323 probably won't be merged - we've ...
Andrew Coulton
10:48 pm Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Updated pull request for 3.3 with passing tests and coding style validated is at https://github.com/kohana/userguide/... Andrew Coulton
10:42 pm Userguide Revision 756f4957: Hide class prefixes other than Kohana_ in userguide - implements #3529
Userguide now uses Kodoc::is_transparent() method to determine whether
a class is a transparent extension class or no...
Andrew Coulton
07:37 pm Revision bbca9038: Update minion submodule
Kohana Jenkins
06:51 pm Bug Report #4450 (Feedback): Character support issue
From the GitHub discussion @ https://github.com/kohana/core/commit/26b90dba7b96a03b40ff53dadee6ed6e6b7571c9
> Have...
Kiall Mac Innes
06:40 pm Revision 89e17c96: Update minion submodule
Kohana Jenkins
01:50 pm Patch #4314: Use Request::query() instead of $_GET in the URL::query() function
@Kemal - Agreed. I'll see about getting this sorted in 3.3. I just want to make sure that we're consistent and allow ... Kiall Mac Innes
01:41 pm Revision 071708ab: Update unittest submodule
Kohana Jenkins
01:40 pm UnitTest Bug Report #4237 (Closed): Bootstrap sends headers when calling ob_end_flush() even if no output ...
Merged pull #15 - thanks! Kiall Mac Innes
01:39 pm Revision a7fbc7ac: Update unittest submodule
Kohana Jenkins
01:39 pm UnitTest Revision d1856448: Merge branch '3.2/develop' into 3.3/develop
Kiall Mac Innes
01:38 pm UnitTest Revision 075c121a: Merge pull request #15 from leth/issue/4237
Only ob_end_flush() if the buffer is not empty.
Fixes #4237
Kiall Mac Innes
01:30 pm Revision e1df08d8: Update unittest submodule
Kohana Jenkins
01:25 pm UnitTest Bug Report #4232 (Closed): PHP files under system/tests/test_data are executed when building list...
Merged - Thanks! Kiall Mac Innes
01:25 pm UnitTest Revision affe1120: Merge branch '3.2/develop' into 3.3/develop
Kiall Mac Innes
01:23 pm UnitTest Revision 065343a9: Merge pull request #14 from acoulton/3.2/develop
Use DIRECTORY_SEPARATOR when excluding php files under test_data - issue with fix for #4232
Refs #4232
Kiall Mac Innes
01:20 pm Patch #4314: Use Request::query() instead of $_GET in the URL::query() function
@Kemal - Agreed. I'll see about Kiall Mac Innes
01:13 pm Revision e40f7db8: Update system submodule
Kohana Jenkins
01:12 pm Core Revision 27770ec6: Update error handling example for #4377.
Refs #4377 Kiall Mac Innes
01:00 pm Revision 90979a4e: Update system submodule
Kohana Jenkins
12:59 pm Core Revision c2fed8b1: Use the correct exception handler for rendering errors in View::__toString()
Kiall Mac Innes
12:59 pm Revision 24ffd013: Update userguide submodule
Kohana Jenkins
12:58 pm Userguide Revision f6569199: Use the correct exception handler for rendering errors.
Kiall Mac Innes
11:29 am Patch #4314: Use Request::query() instead of $_GET in the URL::query() function
I think this method should be able to accept Request injection, using the initial (current?) Request by default. Kemal Delalic

02/26/2012

09:58 pm Bug Report #4461 (New): Request::uri shortcut no longer available
According to the documentation (http://kohanaframework.org/3.2/guide/kohana/routing), you can create a new URI that d... Yehuda Katz
09:22 pm Minion Proposals (Political/Workflow) #4460: Minion Design
Done.
https://github.com/srcspider/Minion-Alternative-Example
Steven G.
07:46 pm Minion Proposals (Political/Workflow) #4460: Minion Design
Jeremy Bush wrote:
> > Needs to contain syntax help, usage example, and how to get help information (by default) and...
Steven G.
05:14 pm Revision c54b7064: Update minion submodule
Kohana Jenkins
05:12 pm Minion Proposals (Political/Workflow) #4460: Minion Design
Those two files aren't supposed to be there. They need to be removed before release, they were left over from the por... Jeremy Bush
09:07 am Minion Proposals (Political/Workflow) #4460: Minion Design
Isaiah DeRose-Wilson wrote:
> What version of Minion are you talking about? I recommend looking at the official mini...
Steven G.
05:47 am ORM Bug Report #4455: Cannot join using ORM
Thanks Kemal,
Any reason / merit why it's changed this way?
Because i imagine this would become a mess in the c...
dexcell -

02/25/2012

08:34 pm UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
I see that all the cool kids these days also seem to be distributing their packages as phar archives that can be incl... Z Binzl
06:51 pm Minion Proposals (Political/Workflow) #4460: Minion Design
What version of Minion are you talking about? I recommend looking at the official minion module that will be included... Isaiah DeRose-Wilson
06:34 pm ORM Bug Report #4455 (Closed): Cannot join using ORM
Isaiah DeRose-Wilson
03:49 pm Minion Proposals (Political/Workflow) #4460 (New): Minion Design
I'm just gonna place this here as a proposal for discussion, so there might be several issues in one but I feel it's ... Steven G.
09:22 am ORM Bug Report #4455: Cannot join using ORM
dexcell - wrote:
> Can you elaborate how to do it correctly in 3.2? Because there is no migration guide for ORM as f...
Kemal Delalic
09:03 am Database Feature Request #4459 (New): Database order_by accept array parameter
Something like this... Krzysztof Skowron
08:49 am ORM Bug Report #4455: Cannot join using ORM
Can you elaborate how to do it correctly in 3.2? Because there is no migration guide for ORM as far as i can recall.
...
dexcell -
08:27 am Database Feature Request #4458 (New): Returning for postgresql insert statement
Add returning to insert statement
`DB::insert($table, $columns)->returning('table_id')`
Krzysztof Skowron
06:44 am Bug Report #4457: Kohana::$config incorrectly initialized in Kohana_Core
Fixed by "9ef1896fa04...":https://github.com/kohana/core/commit/9ef1896fa04e1f94d2bea9def35cf5584fb8d6c6 Isaiah DeRose-Wilson
06:43 am Bug Report #4457 (Closed): Kohana::$config incorrectly initialized in Kohana_Core
file: system/kohana/core.php
line: 339
code: Kohana::$config = new Kohana_Config;
This should be:
Kohana::$conf...
Isaiah DeRose-Wilson
06:43 am Bug Report #4224 (Closed): Kohana::$config incorrectly initialized in Kohana_Core
Isaiah DeRose-Wilson
06:43 am Bug Report #4224: Kohana::$config incorrectly initialized in Kohana_Core
Thanks for the pull request. Merged in "29fef91f89a":https://github.com/kohana/core/commit/29fef91f89abbce4ed1c6ae8a1... Isaiah DeRose-Wilson
06:42 am Bug Report #4456 (Closed): Kohana::init() overwrites any existing internal Log or Config instances
Fixed by "05eb9b8d1ce...":https://github.com/kohana/core/commit/05eb9b8d1ce499e96e757025165f0734b0efe0da Isaiah DeRose-Wilson
06:41 am Revision 037ac514: Update system submodule
Kohana Jenkins
06:41 am Bug Report #4413 (Closed): Kohana::init() overwrites any existing internal Log or Config instances
Thanks for the pull request. Fixed by "9ef1896fa04e1...":https://github.com/kohana/core/commit/9ef1896fa04e1f94d2bea9... Isaiah DeRose-Wilson
06:38 am Revision c6a2b30e: Update system submodule
Kohana Jenkins
06:38 am Core Revision 9ef1896f: Merge commit '29fef91f89abbce4ed1c6ae8a165a0d04cce4c86' into 3.3/develop
Isaiah DeRose-Wilson
06:36 am Core Revision 05eb9b8d: Merge commit '29fef91f89abbce4ed1c6ae8a165a0d04cce4c86' into 3.2/develop
Isaiah DeRose-Wilson
06:31 am Bug Report #4456 (Closed): Kohana::init() overwrites any existing internal Log or Config instances
During the init() method the Kohana::$log and Kohana::$config properties are set without first checking if they are e... Isaiah DeRose-Wilson
01:44 am Core Revision 84965a6d: Remove comment about $_FILES content, it is no longer true
Woody Gilk
01:44 am Core Revision c7ae57f7: Clean up whitespace and comments for Request::files()
Woody Gilk
01:44 am Core Revision 5d51abb7: Fixed all request clients to properly handle POST data in all situations
Woody Gilk
01:44 am Core Revision 582cf2d9: Added Request_Client_Stream::encode_header_param(), applies quoted printable e...
Woody Gilk
01:44 am Core Revision 6930f3d8: Fixed incorrect boundary placement in Request_Client_Stream
Woody Gilk
01:44 am Core Revision 2c38e98d: Added Request_Client::CRLF, replace all "\n" references in Request_Client_Stre...
Woody Gilk
01:44 am Core Revision 72de10e0: Fixing broken test case, this is not functionally required
Woody Gilk
01:44 am Core Revision 359aee65: Added file upload support to Request_Client_Stream
Woody Gilk
01:44 am Core Revision 0c029ca2: Always set the proper Content-Type, even when no data is being sent
Woody Gilk
01:44 am Core Revision 544fd4d0: Set the proper MIME type in Request_Client_HTTP when creating file uploads
Woody Gilk
01:44 am Core Revision f45101da: Follow up to 36ff1d30f18ac681b4e37ebf76ec3f24f9636b5e, adds file upload suppor...
Woody Gilk
01:44 am Core Revision 8b9370cf: Added in the ability to upload files through the HTTP external client class wi...
Signed-off-by: Woody Gilk <[email protected]> Brian Greenacre
01:44 am Core Revision d1d00aff: Do not set the body() to POST data in Request_Client_External::execute(), this...
Woody Gilk
12:37 am UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
I haven't been using it from the vendor path yet so haven't encountered this but I can see how it could be an issue -... Andrew Coulton

02/24/2012

11:19 pm UnitTest Feature Request #4323: Support PHPUnit 3.6
It would be great to see this merged so that the unittest module is forward-compatible to 3.6 - whether or not the ve... Andrew Coulton
11:10 pm Userguide Feature Request #3529: Configurable transparent extension prefixes in API browser
Is there anything more I can do to get this mergeable? Would really love to see this in 3.3. Andrew Coulton
11:05 pm UnitTest Bug Report #4237: Bootstrap sends headers when calling ob_end_flush() even if no output sent
It would be great to see this merged in? Andrew Coulton
11:01 pm UnitTest Revision a26b2b79: Use platform independent DIRECTORY_SEPARATOR when excluding php files under te...
Andrew Coulton
10:57 pm UnitTest Bug Report #4232: PHP files under system/tests/test_data are executed when building list of tests
Just a gentle reminder that I still have a pull request open at https://github.com/kohana/unittest/pull/14 to make th... Andrew Coulton
12:44 pm ORM Bug Report #4455: Cannot join using ORM
It's the expected behavior, ORM uses the singular alias when building queries (since 3.2) - invalid ticket Kemal Delalic
01:57 am Feature Request #4353: External Requests should support Location: redirects
I've created a pull at https://github.com/kohana/core/pull/223 implementing the behaviour, tests and some basic docum... Andrew Coulton
01:40 am Bug Report #4413 (Assigned): Kohana::init() overwrites any existing internal Log or Config instances
Isaiah DeRose-Wilson
01:39 am Bug Report #4432 (Assigned): Fix 'password confirm' error message in ORM module
Isaiah DeRose-Wilson
01:09 am Core Revision 89f13fd7: Fixes #4353 - adds non-strict redirect method, docs and tests
Mainly implements the strict_redirect option to support non-compliant
POST - 302 Redirect - GET from third party serv...
Andrew Coulton
12:45 am Revision 8a5a1db2: Update userguide submodule
Kohana Jenkins
12:43 am Userguide Revision 83858d3d: Add unit test tags for Jenkins
Chris Bandy
12:23 am Revision b158d2a9: Update userguide submodule
Kohana Jenkins
12:22 am Userguide Revision d971804f: Merge pull request #40 from cbandy/3.3/feature/api-menu-performance
Improve menu performance in API browser Chris Bandy

02/23/2012

10:42 pm Feature Request #4353: External Requests should support Location: redirects
Fully agree - hence offering to write some including for the behaviour that's already implemented :)
The issue is ...
Andrew Coulton
10:29 pm Feature Request #4353: External Requests should support Location: redirects
> Alternatively if you'd rather just leave tests out for now I could just do the method and docs.
Tests are import...
Sam de Freyssinet
10:18 pm Feature Request #4353: External Requests should support Location: redirects
I'm very happy to create a pull request for this for review if it's helpful (seems only fair!). One thing I noticed i... Andrew Coulton
10:16 pm Feature Request #4353: External Requests should support Location: redirects
Now all that remains is the question of how `strict_mode` is going to handle the need for user confirmation in order ... Z Binzl
09:41 pm Feature Request #4353: External Requests should support Location: redirects
I agree with Sam here, @strict_redirect@ should default to @TRUE@. The goal is to make it easy to turn off this behav... Woody Gilk
09:35 pm Feature Request #4353: External Requests should support Location: redirects
Andrew Coulton wrote:
> Including in the options array is good - I think strict_redirect is more semantic than quirk...
Sam de Freyssinet
09:30 pm Feature Request #4353: External Requests should support Location: redirects
Including in the options array is good - I think strict_redirect is more semantic than quirksmode. People are used to... Andrew Coulton

02/22/2012

05:13 pm Feature Request #4353: External Requests should support Location: redirects
Static variable would not be my preferred option. Dependency Injection is better for testing. Sam de Freyssinet
05:11 pm Feature Request #4353: External Requests should support Location: redirects
I am fine with having a switch to enforce strict behavior, but it should be @FALSE@ by default:
@$options = array(...
Woody Gilk
05:07 pm Feature Request #4353: External Requests should support Location: redirects
> I am not a fan of killswitches.
Me neither. How about this as a signature?
*EDIT* updated the signature...
Sam de Freyssinet
05:05 pm Feature Request #4353: External Requests should support Location: redirects
I am not a fan of killswitches. Jeremy Bush
05:04 pm Feature Request #4353: External Requests should support Location: redirects
We should call the switch, "quirksmode" as that is exactly what this is. ;) Sam de Freyssinet
04:58 pm Feature Request #4353: External Requests should support Location: redirects
Well I will always support being true to a specification. If we add a kill switch, it must be *off* by default. Sam de Freyssinet
04:47 pm Feature Request #4353: External Requests should support Location: redirects
I admire that fact that you wrote several short essays to argue your point, Andrew. ;) "A" for effort. Woody Gilk
04:45 pm Feature Request #4353: External Requests should support Location: redirects
Or I could have said that much more simply how @shadowhand put it while I was writing :) Andrew Coulton
04:44 pm Feature Request #4353: External Requests should support Location: redirects
@samsoir
OK, I think it's unlikely we're going to reach agreement here, which is a shame. But just in case:
> I...
Andrew Coulton
04:28 pm Feature Request #4353: External Requests should support Location: redirects
@Sam: Although I completely agree with your idealism, I don't think it is pragmatic. Redirecting POST to POST using 3... Woody Gilk
04:18 pm Feature Request #4353: External Requests should support Location: redirects
But here's the rub. After reading this discussion, isn't Joe Developer inevitably going to think as follows:
1. I'...
Z Binzl
03:29 pm Feature Request #4353: External Requests should support Location: redirects
Andrew Coulton wrote:
> @samsoir thanks for the full response and I do understand where you're coming from. This iss...
Sam de Freyssinet
03:14 pm Feature Request #3536: Remove controller method parameters
Lorenzo Pisani wrote:
> people that agree with it will not come to this ticket and voice their agreement.
More li...
Steven G.
10:57 am Revision cbfda958: Update system submodule
Kohana Jenkins
10:56 am Core Revision bd384ba5: Add an example of multiple field validation.
Kiall Mac Innes
07:04 am Feature Request #4353: External Requests should support Location: redirects
It seems that the real problem with the 1.1 spec is that it has two codes that are supposed to be responded to identi... Z Binzl
03:10 am Feature Request #4353: External Requests should support Location: redirects
@samsoir thanks for the full response and I do understand where you're coming from. This issue has prompted.me to re-... Andrew Coulton
02:49 am Feature Request #3536: Remove controller method parameters
You can't say most people did not agree with this change because the people that agree with it will not come to this ... Lorenzo Pisani
01:08 am Feature Request #3536: Remove controller method parameters
@Ruben, could you please provide an example of how this is more complex?
I see when you are coming from other fram...
Joel Pittet
12:42 am Feature Request #4353: External Requests should support Location: redirects
Thanks, that's a very complete explanation. So just to confirm, as the spec also requires that the redirect (from "no... Z Binzl
12:33 am Feature Request #3536: Remove controller method parameters
Hi Everyone,
This is the first time I write in this community. The first application I wrote in Kohana was in the ...
Ruben Rubio
12:24 am Feature Request #4353: External Requests should support Location: redirects
@Kiall, I'm fully supportive of your proposed specification for handling redirects as it ensures that Kohana is doing... Sam de Freyssinet

02/21/2012

11:44 pm Userguide Revision f8778fb4: Do not convert class description and tags to HTML in the constructor
Chris Bandy
11:44 pm Userguide Revision cf1c27b8: Make formatting optional in the parse method
Chris Bandy
11:44 pm Userguide Revision 14c09e6f: Separate tag formatting from parse method
Chris Bandy
11:15 pm Userguide Bug Report #4428 (Closed): Support comment tags that span multiple lines
Applied in changeset commit:84143418f6a7d30c58b089d8e3cac2df66fbd2f2. Chris Bandy
11:12 pm Userguide Revision d91e0de2: Do not covert class constants to HTML in the constructor
Chris Bandy
11:12 pm Userguide Revision bc5a9f64: Remove some unused variables
Chris Bandy
11:11 pm Revision 55adb014: Update userguide submodule
Kohana Jenkins
11:10 pm Userguide Revision 3e9de262: Merge pull request #39 from cbandy/3.3/feature/multiple-lines
Fixes #4428 Chris Bandy
09:34 pm Feature Request #4353: External Requests should support Location: redirects
I think it's a good thing to add in terms of general flexibility, but it still leaves end-users needing to duplicate ... Andrew Coulton
08:09 pm Feature Request #4353: External Requests should support Location: redirects
That seems like an elegant and flexible solution to me if I understand it correctly. But there's still a need (inevit... Z Binzl
07:34 pm Feature Request #4353: External Requests should support Location: redirects
Myself and sam have discussed the changes on GTalk, I'm sure he'll comment here too and correct me if I'm wrong on an... Kiall Mac Innes
07:14 pm Feature Request #4353: External Requests should support Location: redirects
Maybe it would also help with consistency if Kohana's redirect method, which I now see is in Controller and HTTP rath... Z Binzl
03:37 pm Feature Request #4353: External Requests should support Location: redirects
@kiall appreciate your response and it does seem a tricky balance. I think there are a reasonable number of use cases... Andrew Coulton
03:18 pm Feature Request #3776: Text::standardize()
What's about @ini_set("auto_detect_line_endings", true);@? David Pommer
05:05 am Revision e80b703e: Update system submodule
Kohana Jenkins
05:04 am Feature Request #4353: External Requests should support Location: redirects
Also, I had left out the ability to customize the headers to be re-used when following a redirect.
Fixed in ff9582...
Kiall Mac Innes
05:03 am Core Revision ff9582c1: Refs #4353 - Allow the list of headers to re-use when following a redirect to ...
Kiall Mac Innes
04:33 am Feature Request #4353: External Requests should support Location: redirects
Sam, can you please comment on this? I think I understand what is going on, but would prefer your input before giving... Woody Gilk
02:40 am Feature Request #4353: External Requests should support Location: redirects
@Andrew Coulton: I'm personally of the opinion "follow the spec", if a user is dealing with a misbehaving server they... Kiall Mac Innes
02:39 am ORM Bug Report #4455 (Closed): Cannot join using ORM
For example, there is 2 tables
users and notes,
user has many notes.
And when i need to join the table
ORM::f...
dexcell -
02:27 am Bug Report #4454 (New): Default validation message incorrect
In system/messages/validation.php
'matches' => ':field must be the same as :param2',
should be
'matche...
dexcell -
01:08 am Feature Request #4353: External Requests should support Location: redirects
And note also that this has been further clarified in the HTTPbis draft of the new HTTP/1.1 spec here:
http://tool...
Z Binzl
12:19 am Feature Request #4353 (Feedback): External Requests should support Location: redirects
Although this uses the correct request method per the HTTP spec at http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.... Andrew Coulton

02/20/2012

07:05 pm Revision a50d0040: Update system submodule
Kohana Jenkins
07:04 pm Revision b1d886b4: Fixes #4452 - External Requests from inside a Minion task fail.
Kiall Mac Innes
07:03 pm Core Revision b3aff1c7: Fixes #4452 - External Requests from inside a Minion task fail
Kiall Mac Innes
07:02 pm Bug Report #4452 (Closed): External Requests from inside a Minion task fail
Kiall Mac Innes
06:37 pm Feature Request #4353: External Requests should support Location: redirects
Usage ended up as:... Kiall Mac Innes
06:31 pm Feature Request #4353 (Closed): External Requests should support Location: redirects
Applied in changeset commit:f508bc3302fe04f96b2c4f63e81fded627ed0b9f. Kiall Mac Innes
06:19 pm Revision 7df31b8b: Update system submodule
Kohana Jenkins
06:18 pm Core Revision f508bc33: Merge pull request #215 from kohana/3.3/feature/4353-FollowRedirects
Fixes #4353 - Request::execute() should be able to follow Location headers Kiall Mac Innes
06:13 pm Bug Report #4453 (Closed): The "factory" method for "Kohana_Request" has a wrong PHPDoc @return
Kohana_Request::factory has a "@return void" instead of "@return Request".
As seen on http://kohanaframework.org...
Bogdan Popa
06:07 pm Core Revision 151ffd52: Refs #4353 - Request::execute() should be able to follow Location headers.
Kiall Mac Innes
05:53 pm Revision 5661a1d5: Update database submodule
Kohana Jenkins
02:02 pm Database Revision 8e250936: Update database config for PSR-0. Refs #4001.
Kiall Mac Innes
01:27 pm Bug Report #4452 (Closed): External Requests from inside a Minion task fail
External Requests from inside a Minion task fail due to @Request::$initial === NULL@.
This needs to change, but I'...
Kiall Mac Innes
11:59 am Revision 5eae3479: Update minion submodule
Kohana Jenkins
06:48 am UnitTest Feature Request #4381: Vendor PHPUnit 3.5 and its dependencies
How is everyone handling the fact that the unpackaged files from the repos still have the @package_version@ placehold... Z Binzl

02/19/2012

06:07 pm Userguide Bug Report #4428 (Review): Support comment tags that span multiple lines
https://github.com/kohana/userguide/pull/39 Chris Bandy
05:59 pm Userguide Revision 6b7191da: Link @see tags the same as @uses tags
Chris Bandy
05:59 pm Userguide Revision 3f32e112: Allow tags with trailing whitespace
Chris Bandy
05:59 pm Userguide Revision 84143418: Allow tags to span multiple lines. Fixes #4428
Chris Bandy
05:59 pm Userguide Revision 9e4d5efb: Some tests for Kodoc::parse
Chris Bandy
05:47 pm Revision 9433ac85: Update userguide submodule
Kohana Jenkins
05:45 pm Userguide Revision d457c06c: Class names are case-sensitive. Refs #4001
Also clean up the method description. Chris Bandy
01:52 am ORM Bug Report #4451 (Rejected): trim filter on a NULL value should leave it as NULL
Just create your own method that checks to see if the value is null, and have it return trim($value) when it isn't nu... Isaiah DeRose-Wilson

02/18/2012

11:00 am ORM Bug Report #4451 (Rejected): trim filter on a NULL value should leave it as NULL
When using ... dan caragea

02/17/2012

03:00 pm Userguide Bug Report #3695 (Closed): Markdown should not be included in the controller
Applied in changeset commit:5de14dc49879268b64fb9f2352ab5212d2a3a32e. Chris Bandy
02:48 pm Revision d57e27fe: Update userguide submodule
Kohana Jenkins
02:48 pm Revision 04b1225d: Update userguide submodule
Kohana Jenkins
02:48 pm Revision e831dff4: Update userguide submodule
Kohana Jenkins
02:45 pm Userguide Bug Report #3695 (Resolved): Markdown should not be included in the controller
Chris Bandy
02:45 pm Userguide Revision 462a0d5f: Merge branch '3.2/develop' into 3.3/develop
Chris Bandy
02:45 pm Userguide Revision f2e39343: Merge branch '3.1/develop' into 3.2/develop
Conflicts:
classes/controller/userguide.php
Chris Bandy
06:02 am Core Revision 92fc9926: Clean up whitespace and comments for Request::files()
Woody Gilk
06:02 am Core Revision c89d2fa9: Fixed incorrect boundary placement in Request_Client_Stream
Woody Gilk
06:02 am Core Revision 51088eb4: Added Request_Client_Stream::encode_header_param(), applies quoted printable e...
Woody Gilk
06:02 am Core Revision c6835956: Added Request_Client::CRLF, replace all "\n" references in Request_Client_Stre...
Woody Gilk
06:02 am Core Revision 7e2433a8: Always set the proper Content-Type, even when no data is being sent
Woody Gilk
06:02 am Core Revision de630282: Fixed all request clients to properly handle POST data in all situations
Woody Gilk
06:02 am Core Revision e96eebe1: Added file upload support to Request_Client_Stream
Woody Gilk
06:02 am Core Revision 73e24168: Fixing broken test case, this is not functionally required
Woody Gilk
06:02 am Core Revision 9092c968: Follow up to 36ff1d30f18ac681b4e37ebf76ec3f24f9636b5e, adds file upload suppor...
Woody Gilk
06:02 am Core Revision d0fa79fa: Set the proper MIME type in Request_Client_HTTP when creating file uploads
Woody Gilk
06:00 am Core Revision 5e3323a7: Do not set the body() to POST data in Request_Client_External::execute(), this...
Woody Gilk
06:00 am Core Revision 1f6cf9b8: Added in the ability to upload files through the HTTP external client class wi...
Signed-off-by: Woody Gilk <[email protected]> Brian Greenacre
05:53 am Revision e47387b0: Update system submodule
Kohana Jenkins
05:53 am Core Revision 5b8db1e1: Clean up c5c45ac6a8b09ee5925c6f94df521f66dc84c0d8 and use empty() instead of a...
Woody Gilk
03:15 am Bug Report #4450 (Closed): Character support issue
Applied in changeset commit:0055c46badbb846f4dd9fb80abada6749dc0c510. Anonymous
03:11 am Revision 247c4d4f: Update system submodule
Kohana Jenkins
03:11 am Core Revision 0055c46b: Merge pull request #221 from thinkclay/3.3/develop
Fixes #4450 Woody Gilk
03:09 am Bug Report #4450: Character support issue
Merged. Woody Gilk
03:08 am Bug Report #4450 (Assigned): Character support issue
Woody Gilk
03:05 am Bug Report #4450 (Closed): Character support issue
Ellipsis characters are not supported by all IDE's or fonts and as such, should be removed from the core. See:
htt...
Clay McIlrath
02:47 am Core Revision 26b90dba: Removing elipsis character in favor of (3) periods
Clay McIlrath

02/16/2012

11:26 pm Database Feature Request #3898: Add support for MySQLi
There was a message on the internals mailing list about "deprecating ext/mysql":http://news.php.net/php.internals/53799. Chris Bandy
03:53 pm Userguide Revision 5de14dc4: Call Kodoc_Markdown directly rather than the Markdown() function
Fixes #3695 Chris Bandy
02:23 pm Core Revision 82a5fdfe: fixed bug with comments on core->init missing new line
David Farnan
06:22 am Bug Report #4315 (Closed): Internal sub-request not receiving correct accept type
I'm going to mark this as "wontfix" since the underlying issue is not really solved, but rather the methods described... Woody Gilk
04:54 am Revision 598bc983: Update system submodule
Kohana Jenkins
04:51 am Core Revision c5c45ac6: Switch to ucwords() for controller and directory route matches. Refs #4001.
Kiall Mac Innes
04:15 am Revision 7889a64d: Update image submodule
Kohana Jenkins
04:15 am Image Revision f94e3c19: Cleanup coding stye violations.
Kiall Mac Innes
04:10 am Revision 8e962556: Update auth submodule
Kohana Jenkins
04:09 am Auth Revision ac727ead: Cleanup coding stye violations.
Kiall Mac Innes
03:55 am Revision 6faafbd0: Update system submodule
Kohana Jenkins
03:55 am Revision 1e2df997: Update system submodule
Kohana Jenkins
03:12 am Revision eb4c884f: Add minion module to bootstrap.php. Refs #3989.
Kiall Mac Innes
03:03 am Bug Report #4315: Internal sub-request not receiving correct accept type
Sam / Woody - Is this ticket now closeable? Kiall Mac Innes
03:01 am Revision 4ed40b55: Fixes #4443 - PSR-0 changes broke install.php tests
Kiall Mac Innes
03:00 am Bug Report #4443 (Closed): 3.3.0 Core Class Capitlization Change Breaks install.php
Applied in changeset commit:4ed40b558b1e319a8a7bfe49693955c73f46c64d. Kiall Mac Innes
02:45 am Feature Request #4449 (Closed): Refactor user-agent generation into a single method to allow for ...
Applied in changeset commit:e79574774920fc11695adc16790b8160c3ae187e. Kiall Mac Innes
02:41 am Revision 591deea3: Update submodules
Kohana Jenkins
02:30 am Feature Request #4449 (Closed): Refactor user-agent generation into a single method to allow for ...
Refactor user-agent generation into a single method to allow for easy overrides.
This is currently used in several...
Kiall Mac Innes
02:30 am Core Revision e7957477: Refactor user-agent generation into a single method. Fixes #4449
Kiall Mac Innes
02:15 am Revision ae2f192f: Update submodule pointers
Kiall Mac Innes
01:59 am Core Revision 8454dde1: Merge branch '3.2/develop' into 3.3/develop
Conflicts:
tests/kohana/CLITest.php
Kiall Mac Innes
01:58 am Core Revision 804cc57a: Merge branch '3.1/develop' into 3.2/develop
Conflicts:
tests/kohana/Http/HeaderTest.php
tests/kohana/RequestTest.php
Kiall Mac Innes
01:55 am Core Revision 0d42aa9d: Update unit test @group's
Kiall Mac Innes

02/14/2012

01:26 pm Bug Report #4448 (New): Alias key for error array
Considering the following code:... Willian Veiga
03:31 am ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
$no_avatars = ORM::factory('user')
->with('profile')
->where('profile.avatar', 'IS', ...
Ivan Kurnosov
03:29 am ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
> I'm not totally against this, but I don't like adding additional "magic" to ORM. Writing more verbose code isn't a ... Ivan Kurnosov
03:22 am ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
Ivan Kurnosov wrote:
> > There is no reason that where conditions couldn't be applied to the joined table.
> This s...
Isaiah DeRose-Wilson
02:56 am ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
> There is no reason that where conditions couldn't be applied to the joined table.
This statement makes no sense, a...
Ivan Kurnosov
02:54 am ORM Feature Request #4445 (Feedback): ORM::with() doesn't prepend `WHERE` fields with alias
> There is no reason that where conditions couldn't be applied to the joined table.
The `with()` is used to have b...
Ivan Kurnosov
02:48 am ORM Feature Request #4445 (Rejected): ORM::with() doesn't prepend `WHERE` fields with alias
Ivan Kurnosov wrote:
> If I do it in `where()` - obviously I apply the conditions to the main entity, that is used f...
Isaiah DeRose-Wilson

02/13/2012

09:51 pm ORM Bug Report #4447 (Closed): Wrong @return for ORM::with()
It is `@return void` obviously should be `@return $this` Ivan Kurnosov
09:42 pm ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
If I do it in `where()` - obviously I apply the conditions to the main entity, that is used for `from`, because `with... Ivan Kurnosov
09:38 pm ORM Feature Request #4445 (Feedback): ORM::with() doesn't prepend `WHERE` fields with alias
If you do @where('some_field', '=', 100)@, how would ORM know which alias/table name to use? Please include your fix ... Isaiah DeRose-Wilson
09:31 pm ORM Feature Request #4445: ORM::with() doesn't prepend `WHERE` fields with alias
Omg.
Why client should even care of that?! It is ORM business - to make the clients' life easier, by encapsulating...
Ivan Kurnosov
09:26 pm ORM Feature Request #4445 (Closed): ORM::with() doesn't prepend `WHERE` fields with alias
This is expected. You need to include the table alias manually when it is required. Isaiah DeRose-Wilson
09:19 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Jeremy Bush wrote:
> Isaiah DeRose-Wilson wrote:
> > Following a strict coding standard would help with this, but it ...
Isaiah DeRose-Wilson
08:50 pm Revision da1f7ab4: Update system submodule
Kohana Jenkins
08:19 pm Feature Request #4446 (New): Add max_numeric and min_numeric to Valid class.
For example. If you have a field that must be greater than 10 but has no maximum number. John Chipps-Harding
08:12 pm ORM Feature Request #4445 (Feedback): ORM::with() doesn't prepend `WHERE` fields with alias
So it leads to the ambiguous references:... Ivan Kurnosov
08:04 pm ORM Bug Report #4444 (Closed): Wrong alias character in ORM (postgresql)
It is `:` (colon char) used in alias name in `Kohana_ORM::with()` implementation and it is a denied char to use in po... Ivan Kurnosov
07:34 pm Revision 52f3bcdc: Update .gitmodules to point at "kohanatest" repos
Kiall Mac Innes
06:01 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Isaiah DeRose-Wilson wrote:
> Following a strict coding standard would help with this, but it would be almost imposs...
Jeremy Bush
05:53 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Kiall Mac Innes wrote:
> @Dmitry T: All lowercase means not supporting PSR-0.
>
> We have chosen to support PSR-0...
Isaiah DeRose-Wilson
05:45 pm Revision 3ef127f2: Update system submodule
Kohana Jenkins
05:44 pm Core Revision e44612df: Fixup Route tests after PSR-0 changes. Refs #4001.
Kiall Mac Innes
05:33 pm Revision ab834312: Update cache submodule
Kohana Jenkins
05:32 pm Revision c48f3ab6: Update system submodule
Kohana Jenkins
05:21 pm Core Revision 2ed1d300: Ensure the default controller param is used if a controller part was not match...
Kiall Mac Innes
05:17 pm Cache Revision 0aaf50cc: Update MemcacheTag filename for PSR-0. Refs #4001.
Kiall Mac Innes
04:46 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Good to hear. Thanks Dmitry T.
04:16 pm Revision bfd75a0b: Update system submodule
Kohana Jenkins
04:15 pm Core Revision 83d0f215: Refs #4001 - ucfirst() the controller name, if it was matched from the URL, fo...
Kiall Mac Innes
04:13 pm Core Revision 66da57cb: Revert "Refs #4001 - ucfirst() the controller name for PSR-0"
This reverts commit 4eb6180377036da0a523178dca1d134cebfde06f. Kiall Mac Innes
04:10 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Dmitry T. wrote:
> How would controller classes look like?
> Controller_News
> Controller_news
> Controller_Admin...
Jeremy Bush
04:08 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
How would controller classes look like?
Controller_News
Controller_news
Controller_Admin_News
Controller_admin_ne...
Dmitry T.
03:16 pm Revision 547fd2b1: Update submodules
Kohana Jenkins
03:02 pm Core Revision 4eb61803: Refs #4001 - ucfirst() the controller name for PSR-0
Kiall Mac Innes
02:57 pm Bug Report #4437 (Resolved): html::style, image, script base prepending issue
We've already rejected this feature twice. See the related issues. Jeremy Bush
01:06 pm Bug Report #4437: html::style, image, script base prepending issue
Yes, here is the url I use :... Thomas Lété
08:32 am Bug Report #4437: html::style, image, script base prepending issue
Hello Thomas,
Could you give some examples of when this will fail?
Robert-Jan Dreu -rjd22-
03:25 am Bug Report #4443 (Closed): 3.3.0 Core Class Capitlization Change Breaks install.php
The first letter of classes such as system/classes/*.php have changed to uppercase. However, line 68 of install.php h... Brendan Mulholland

02/12/2012

04:04 pm ORM Bug Report #4442 (New): Validation Example Error

http://kohanaframework.org/3.1/guide/orm/examples/validation
http://kohanaframework.org/3.2/guide/orm/examples/val...
mike trotta
03:24 pm Bug Report #4440: Remove the `die` call in the auto loaders
Dooh.. Typo! *Fixs* #4440 - Remove the `die` call from the auto loaders.
Fixed by "198fb2626ec28eaaf3de1f2c12a04db...
Kiall Mac Innes
03:23 pm Bug Report #4440: Remove the `die` call in the auto loaders
Humm - I wonder if I used the wrong ticket # in the commit..
Will check now..
Kiall Mac Innes
03:22 pm Bug Report #4440: Remove the `die` call in the auto loaders
How come there's no commit reference for this? Woody Gilk
02:48 pm Revision 8243d50c: Disable the pre PSR-0 compatiblity autoloader now that all core modules have b...
Kiall Mac Innes
02:42 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
@Dmitry T: All lowercase means not supporting PSR-0.
We have chosen to support PSR-0 along with nearly every other...
Kiall Mac Innes
02:40 pm Revision a9664a2f: Update cache module
Kiall Mac Innes
02:40 pm Cache Revision cef1d230: Missed a file on the first pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:37 pm Revision 91ca2bf2: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:37 pm Userguide Revision 4e667099: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:35 pm ORM Revision 8221614b: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:31 pm Image Revision f0bc8896: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:30 pm Database Revision cb64b293: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:27 pm Codebench Revision 29e93494: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:26 pm Cache Revision d46853b4: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
02:20 pm Auth Revision a725a68e: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
01:17 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
I vote for all-lowercase file names like it always was in Kohana. This is easier and no need to remember where is a c... Dmitry T.
01:16 pm Revision 0a07cd3e: Update submodules
Kohana Jenkins
01:07 pm Bug Report #4441 (Feedback): Clean up use of CameCase in class names.
Our use of CamelCase (and all caps) is somewhat inconsistent at the moment.
With PSR-0 now implemented, this has b...
Kiall Mac Innes
01:02 pm Core Revision 198fb262: Fixs #4440 - Remove the `die` call from the auto loaders.
Kiall Mac Innes
01:01 pm Bug Report #4440 (Closed): Remove the `die` call in the auto loaders
Kiall Mac Innes
12:57 pm Bug Report #4440 (Closed): Remove the `die` call in the auto loaders
Remove the `die` call in the auto loaders.
This breaks sub-requests for one, and does not provide a proper exit co...
Kiall Mac Innes
12:54 pm Feature Request #4001: Fully Support PSR-0 autoloading requirements
Okay - So we have an issue with PSR-0 support.
with "Controller_Welcome" in "classes/Controller/Welcome.php" our rou...
Kiall Mac Innes

02/11/2012

08:16 pm Revision 139177b2: Temporarily enable the pre PSR-0 compatiblity autoloader. Refs #4001
Kiall Mac Innes
08:11 pm Revision e387def1: Initial pass for PSR-0 autoloading support. Refs #4001
Kohana Jenkins
08:09 pm UnitTest Revision 93480c14: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
08:08 pm UnitTest Revision 82952bec: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
08:07 pm Core Revision 38061c9d: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
07:56 pm Core Revision 7a12b2ba: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
07:43 pm Core Revision 67939be9: Initial pass for PSR-0 autoloading support. Refs #4001
Kiall Mac Innes
04:07 pm Userguide Feature Request #3922 (Assigned): Add module conventions to the userguide
Kiall Mac Innes
02:21 pm Feature Request #3989: Make Minion official
Duh, ignore and/or delete previous post. Michał Lipka
02:11 pm Feature Request #3989: Make Minion official
After removal of all CLI code from Request class, kohana can not properly detect URI in CLI mode. Before it was detec... Michał Lipka

02/10/2012

05:33 pm Revision c4fb148c: Update submodules
Kohana Jenkins
05:31 pm Core Revision 4bafc4df: Disable Kohana_CoreTest::test_message() due to its fragility.
Kiall Mac Innes
05:25 pm Revision 58291d42: Update submodules
Kohana Jenkins
05:23 pm Core Revision 672e9921: Remove CLI classes - Refs #3989
Kiall Mac Innes
05:07 pm Feature Request #4353 (Assigned): External Requests should support Location: redirects
Pull Request @ http://dev.kohanaframework.org/issues/4353
Needs tests and a decision re 3.3 inclusion.
Also - S...
Kiall Mac Innes
05:06 pm Core Revision ee6dcca1: Refs #4353 - Request::execute() should be able to follow Location headers.
Kiall Mac Innes
06:06 am Feature Request #4439 (New): Kohana_Config_File_Writer
How about to create the class, that can write default config files?
Just the same as Kohana_Config_Database_Writer
...
Ruslan Sukhar

02/09/2012

04:59 pm Bug Report #4438 (New): Kohana_Valid::email_domain() doesn't comply to RFC5321
The @Kohana_Valid::email_domain()@ method only checks if an MX RR is present, it doesn't check if there is a CNAME or... Chris Smith
01:50 pm Bug Report #4437 (Resolved): html::style, image, script base prepending issue
Hi,
Functions on HTML class uses a simple test to detect if the URI of the file is absolute :
strpos($file, ':/...
Thomas Lété
09:14 am Patch #4263: Redirect userguide by default to kohana
Please move this to 3.2 I've made the patch to that version:
https://github.com/kohana/userguide/pull/38
Robert-Jan Dreu -rjd22-
12:45 am Database Feature Request #3898: Add support for MySQLi
I resent the pull request against the correct branch. See https://github.com/kohana/database/pull/29 Moshe Katz

02/08/2012

11:59 pm Database Feature Request #3898: Add support for MySQLi
https://github.com/kohana/database/pull/27 Isaiah DeRose-Wilson
11:04 pm UnitTest Bug Report #4435 (New): Kohana_SecurityTest: test_csrf_token() relies on session data which may b...
As per this discussion: http://forum.kohanaframework.org/discussion/comment/69697
test_csrf_token() in the Kohana_...
Matt Lyon
06:35 pm Bug Report #4434: Request::$initial and Request::$current should be protected properties
> Fixed: https://github.com/kohana/core/pull/213
I've closed that pull request as it is not a sufficient fix, sinc...
Adam Radwon
01:02 pm Bug Report #4434: Request::$initial and Request::$current should be protected properties
Fixed: https://github.com/kohana/core/pull/213 Adam Radwon
12:31 pm Core Revision 29fef91f: The init() method instantiates the Kohana::$log and Kohana::$config properties...
Valery Bogdanov
12:23 pm Bug Report #4434 (New): Request::$initial and Request::$current should be protected properties
@Request::$initial@ and @Request::$current@ should be protected properties and only accessed via their corresponding ... Adam Radwon
07:57 am Feature Request #3683 (Feedback): Exception naming conventions
Sorry for bumping this again, but this seems not to be a duplicate of #3765.
The sugestion there is to use the trans...
David Pommer

02/07/2012

04:17 pm Revision 399986ee: Update submodules
Kohana Jenkins
04:16 pm Revision 28b4a10f: Update submodules
Kohana Jenkins
04:16 pm Revision 4a6af8a6: Update submodules
Kohana Jenkins
04:06 pm Core Revision 6fbee88b: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
04:06 pm Core Revision 446f032f: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
04:06 pm Bug Report #4431 (Closed): View::capture no longer uses global references
Even if it does work, still not the correct solution. Fixed. Woody Gilk
04:05 pm Core Revision 2b9a02dd: Follow up to 9803c24111b6b8a9b7665106a0a916ebefd97605, use a bitwise OR instea...
Woody Gilk
04:01 pm Bug Report #4431: View::capture no longer uses global references
Did you try it? My tests showed that using @OR@ worked just fine. From the "horse's mouth":http://php.net/extract
...
Woody Gilk
09:01 am Bug Report #4431 (Feedback): View::capture no longer uses global references
I think there is an error
http://dev.kohanaframework.org/projects/kohana3-core/repository/revisions/9803c24111b6b8a9...
Dmitry T.
02:47 am Revision af063db7: Update submodules
Kohana Jenkins
02:46 am Revision 0a72cd1c: Update submodules
Kohana Jenkins
02:36 am Core Revision c9820797: Merge branch '3.2/develop' into 3.3/develop
Woody Gilk
02:35 am Core Revision 64753b7a: Merge branch '3.1/develop' into 3.2/develop
Woody Gilk
01:16 am Revision 54ef4845: Update submodules
Kohana Jenkins
01:05 am Core Revision 9803c241: Fixed a regression in how global variable references are handled, refs #2919, ...
Woody Gilk
01:04 am Bug Report #4431: View::capture no longer uses global references
Merged into @3.1/develop@. Woody Gilk
01:02 am Bug Report #4431: View::capture no longer uses global references
3.0 is unsupported. It can go in the final 3.1 release (which should be soon...) Jeremy Bush
12:42 am Bug Report #4432: Fix 'password confirm' error message in ORM module
Blast, I'm sorry for creating this issue in the wrong section. Please let me know if I should recreate this issue for... Richard Willis
12:32 am Bug Report #4432 (Closed): Fix 'password confirm' error message in ORM module
When using the get_password_validation() rules for validation a password_cofirm field, the error message returned is ... Richard Willis
12:17 am Bug Report #4431 (Closed): View::capture no longer uses global references
Applied in changeset commit:9a149a65a8cd3b321bcfbf86c10a9f09c4a44298. Woody Gilk
12:13 am Bug Report #4431: View::capture no longer uses global references
Jeremy, should we do a hotfix on 3.0 or just target this into the final 3.1 maintenance release? The fix is currently... Woody Gilk
12:12 am Feature Request #2919 (Closed): Write access to global data with references in views
New issue #4431. Woody Gilk
12:11 am Core Revision 9a149a65: Fixed a regression in how global variable references are handled, refs #2919, ...
Woody Gilk
12:09 am Bug Report #4431 (Closed): View::capture no longer uses global references
As discussed here http://forum.kohanaframework.org/discussion/10366/viewcapture-extract-by-reference
This regressi...
Woody Gilk
12:08 am Feature Request #2919 (Feedback): Write access to global data with references in views
http://forum.kohanaframework.org/discussion/10366/viewcapture-extract-by-reference#Item_1
This feature request doe...
Chris McKeever

02/05/2012

06:47 pm Revision 837333fe: Update submodules
Kohana Jenkins
06:46 pm Core Revision 36303498: Merge pull request #212 from gevans/3.3/feature/4412-empty-attributes-test
Adds tests for HTML::attributes(), refs #4412 Woody Gilk
06:45 pm Feature Request #4412 (Closed): HTML class and attributes
Tests added. Woody Gilk
02:19 pm Core Revision 485acf48: Update HTML::attributes tests for 9cffcd9, refs #4412
Gabriel Evans
01:52 pm Bug Report #4120: Fix __() to use default source language
Reverted #4120 in the pull request since it brings more complexity than the intent of the change. Please close this. Ernestas Lisauskas
10:17 am Revision c0170275: Update submodules
Kohana Jenkins
10:02 am Core Revision 7ae7010e: Merge branch '3.2/develop' into 3.3/develop (fixes #4430)
Lorenzo Pisani
10:01 am Bug Report #4430 (Closed): Validation::check doesn't check errors added manually
applied here: 7ae7010e3c95d4c8277b9464dd4c90eefe6f4807 Lorenzo Pisani
10:01 am Revision d57820fb: Update submodules
Kohana Jenkins
10:00 am Bug Report #4430 (Closed): Validation::check doesn't check errors added manually
In Validation::check, you are stoping the rules if you find an error in a field:
But you are not checking for errors...
Lorenzo Pisani
09:59 am Bug Report #3900 (Closed): Validation::check doesn't check errors added manually
applied here: https://github.com/kohana/core/commit/f876ba59ea406fea6347127dd2407321e78e270d Lorenzo Pisani
09:57 am Core Revision f876ba59: unittest and fix for validation callbacks adding errors manually (fixes #3900)
Lorenzo Pisani
09:33 am Revision 3f83893f: Update submodules
Kohana Jenkins
09:32 am Revision 3331fa21: Update submodules
Kohana Jenkins
09:23 am ORM Revision 075cb722: Merge branch '3.2/develop' into 3.3/develop
Lorenzo Pisani
09:23 am ORM Bug Report #4429: _external array for Validation loads the incorrect file
fixed by this merge: https://github.com/kohana/orm/commit/075cb722fedc0333fa2a7dc746bc72abaca85db9 Lorenzo Pisani
09:21 am ORM Bug Report #4429 (Closed): _external array for Validation loads the incorrect file
Test platform:
- Ubuntu 11.04
- PHP 5.3.5
- Apache 2.2.17
This error surfaces when using external validation wi...
Lorenzo Pisani
09:21 am ORM Bug Report #4185 (Closed): _external array for Validation loads the incorrect file
fixed here: https://github.com/kohana/orm/commit/2f68382df5767ac5f5a69bfb23c48d8b4a392ce0
The messages for `_exter...
Lorenzo Pisani
09:20 am ORM Revision 2f68382d: handling external validation differently from merged model validation (fixes #...
Lorenzo Pisani
07:17 am Revision ed9638ef: Update submodules
Kohana Jenkins
07:04 am ORM Revision 94ddee89: adding the missing alias to using() (fixes #4049)
Lorenzo Pisani
07:03 am ORM Feature Request #4049 (Closed): add using() to ORM::$_db_methods
applied here: https://github.com/kohana/orm/commit/94ddee89fe6eeadce504edeec83165ead23d7613 Lorenzo Pisani
05:17 am ORM Feature Request #4163 (Closed): Skip validations
I don't think we should be adding a parameter to save() for the sake of skipping proper behavior. My suggestion would... Lorenzo Pisani
05:10 am ORM Feature Request #3949 (Closed): has_one through
No one seems to have voiced their opinion about this and I still don't find it useful so feel free to reopen with som... Lorenzo Pisani
05:02 am Revision 9d9f74c0: Update submodules
Kohana Jenkins
04:56 am ORM Revision 59c7d119: making sure fields are unserialized as arrays (fixes #4188)
Lorenzo Pisani
04:55 am ORM Bug Report #4188 (Closed): ORM _unserialize_value() can result in stdClass for associative array
applied here: https://github.com/kohana/orm/commit/59c7d119208e35b5220772b2ae125c5b8e701fb2 Lorenzo Pisani
04:47 am Revision eb739a63: Update submodules
Kohana Jenkins
04:41 am Userguide Bug Report #4223 (Closed): Use non-conflicting routes for media and api
Applied here: https://github.com/kohana/userguide/commit/11f20122d93a9f0ff32f5454bf90b7e535901edf Lorenzo Pisani
04:41 am Userguide Revision 11f20122: moving api and media routes so they do not conflict with any possible module n...
Lorenzo Pisani
04:40 am Userguide Bug Report #4223 (Assigned): Use non-conflicting routes for media and api
Taking care of this now Lorenzo Pisani

02/04/2012

11:00 am Bug Report #4141: Fix Request::redirect() when using an index_page
TJ Krause wrote:
> Has this issue been solved? If not the fix is quite simple. The third parameter must be a boolean...
Максим Нагайченко
« Previous
Next »
 

Also available in: Atom